Re: [LyX/master] Length.cpp: add new unit representing \baselineskip

2017-04-10 Thread Scott Kostyshak 
On Tue, Apr 11, 2017 at 02:58:08AM +0200, Uwe Stöhr wrote:
> El 10.04.2017 a las 05:35, Scott Kostyshak escribió:
> 
> > This commit broke the test
> > 
> >check_Length
> > 
> > I'm guessing that there is no regression and that the test just needs to
> > be updated. Uwe, can you please take a look?
> 
> How is this test executed? What problems do you get and where is the test
> defined?

If you use CMake, you can run:

  ctest -R "check_Length"

For autotools, I think this test is run when you do

  make check
  make distcheck

But I think the test has been fixed.

Scott


signature.asc
Description: PGP signature

Re: [LyX/master] Length.cpp: add new unit representing \baselineskip

2017-04-10 Thread Uwe Stöhr 

El 10.04.2017 a las 05:35, Scott Kostyshak escribió:


This commit broke the test

   check_Length

I'm guessing that there is no regression and that the test just needs to
be updated. Uwe, can you please take a look?


How is this test executed? What problems do you get and where is the 
test defined?


I only find check_Length.cpp which compiles here without errors or warnings.

regards Uwe

Re: [LyX/master] Length.cpp: add new unit representing \baselineskip

2017-04-09 Thread Scott Kostyshak 
On Sat, Apr 08, 2017 at 03:30:29AM +0200, Uwe Stöhr wrote:
> commit b3b7675f544128ea4bbff564262774533af3598f
> Author: Uwe Stöhr 
> Date:   Sat Apr 8 03:30:21 2017 +0200
> 
> Length.cpp: add new unit representing \baselineskip
> 
> - fileformat change

This commit broke the test

  check_Length

I'm guessing that there is no regression and that the test just needs to
be updated. Uwe, can you please take a look?

Scott


signature.asc
Description: PGP signature