Re: [PATCH] InsetGraphics updates
On Sun, 29 Jul 2001, Baruch Even wrote: Please apply soon, the GRAPHICS to Graphics change means that the inset loading after saving doesnt work until it is applied. I'd love to if you send the patch. Thanks, Asger
Re: [PATCH] InsetGraphics updates
Sure, sure, couldn't you just read it off my mind... ah, never mind I'll send it anyway... * Asger K. Alstrup Nielsen [EMAIL PROTECTED] [010729 13:36]: On Sun, 29 Jul 2001, Baruch Even wrote: Please apply soon, the GRAPHICS to Graphics change means that the inset loading after saving doesnt work until it is applied. I'd love to if you send the patch. Thanks, Asger -- Baruch Even http://baruch.ev-en.org/ graphics.diff.gz
Re: [PATCH] InsetGraphics updates
On Sun, 29 Jul 2001, Baruch Even wrote: Sure, sure, couldn't you just read it off my mind... ah, never mind I'll send it anyway... I promise to practice that. After all, it would be fairly useful. Meanwhile, I'll applied the patch. Greets, Asger graphics.diff.gz
Re: [PATCH] InsetGraphics updates #2
Baruch Even wrote: Adds the scale method as request by Michael. Fixes the EPS detection part, non hacky revision (Garst please test). Happily, let you know in 2h. Thanks, Garst
Re: [PATCH] InsetGraphics updates #2
Baruch Even wrote:
Adds the scale method as request by Michael.
Fixes the EPS detection part, non hacky revision (Garst please test).
Maybe missing an include.
cvs log attached.
Garst
Making all in insets
make[3]: Entering directory `/usr/local/garst/lyx-devel/src/insets'
/bin/sh ../../libtool --mode=compile g++ -DHAVE_CONFIG_H -I. -I. -I../../src -I./../
-I../.. -I../.. -I../../boost -isystem /usr/X11R6/include -O -W -Wall -c
insetgraphics.C
g++ -DHAVE_CONFIG_H -I. -I. -I../../src -I./../ -I../.. -I../.. -I../../boost -isystem
/usr/X11R6/include -O -W -Wall -Wp,-MD,.deps/insetgraphics.pp -c insetgraphics.C
insetgraphics.C: In function `bool unnamed::isEPS(const std::string)':
insetgraphics.C:539: `ifstream' undeclared (first use this function)
insetgraphics.C:539: (Each undeclared identifier is reported only once for each
function it appears in.)
insetgraphics.C:539: parse error before `(' token
insetgraphics.C:541: `ifs' undeclared (first use this function)
make[3]: *** [insetgraphics.lo] Error 1
Re: [PATCH] InsetGraphics updates #2
Garst R. Reese wrote: Baruch Even wrote: Adds the scale method as request by Michael. Fixes the EPS detection part, non hacky revision (Garst please test). Maybe missing an include. cvs log attached. Garst No, it needed using std::ifstream; compiling now. Garst
Re: [PATCH] InsetGraphics updates #2
Baruch Even wrote: Adds the scale method as request by Michael. Fixes the EPS detection part, non hacky revision (Garst please test). The scale option is added to the horizontal part but affects both horizontal and vertical, bad UI, I know. Consider this a proof of concept, and if someone won't do the UI fix I'll do it some other time. -- Baruch Even http://baruch.ev-en.org/ Name: ig2.diff.gz ig2.diff.gzType: unspecified type (application/octet-stream) Encoding: base64 Looks good here. Got all of weird filenames with no sweat. mathpanel patch also retested. Thanks much, Garst
Re: [PATCH] InsetGraphics updates #2
On Sun, Jul 29, 2001 at 02:42:48PM +0300, Baruch Even wrote: Adds the scale method as request by Michael. Fixes the EPS detection part, non hacky revision (Garst please test). The scale option is added to the horizontal part but affects both horizontal and vertical, bad UI, I know. Consider this a proof of concept, and if someone won't do the UI fix I'll do it some other time. Looking at the patch, it seems that if you have foo.epsi, lyx will try to convert it to foo.eps ... Also, why did you define epsi format in your previous patch ? One argument in Converter::Convert is the format of the from_file, so it can be used as follows: converters.Convert(..,foo.epsi,..., eps, pdf)
Re: [PATCH] InsetGraphics updates #2
* Dekel Tsur [EMAIL PROTECTED] [010729 19:02]: On Sun, Jul 29, 2001 at 02:42:48PM +0300, Baruch Even wrote: Adds the scale method as request by Michael. Fixes the EPS detection part, non hacky revision (Garst please test). The scale option is added to the horizontal part but affects both horizontal and vertical, bad UI, I know. Consider this a proof of concept, and if someone won't do the UI fix I'll do it some other time. Looking at the patch, it seems that if you have foo.epsi, lyx will try to convert it to foo.eps ... The latest patch will avoid this since it will detect it to be an eps file and avoid converting it, the detectFormat function will return the same suffix and so the if (suffix == fmt_to_convert_to) return; will just return with no conversion. Also, why did you define epsi format in your previous patch ? One argument in Converter::Convert is the format of the from_file, so it can be used as follows: converters.Convert(..,foo.epsi,..., eps, pdf) gotcha, can you finally write doc strings for converter? Everytime I need to use it and want to know how to do something I need to read the goddamn code, and it's not that easy to follow. If you'll document it's features and how to use it I'll know how to use it better and will not need such hacks. -- Baruch Even http://baruch.ev-en.org/
Re: [PATCH] InsetGraphics updates
On Sun, 29 Jul 2001, Baruch Even wrote: > Please apply soon, the GRAPHICS to Graphics change means that the inset > loading after saving doesnt work until it is applied. I'd love to if you send the patch. Thanks, Asger
Re: [PATCH] InsetGraphics updates
Sure, sure, couldn't you just read it off my mind... ah, never mind I'll send it anyway... * Asger K. Alstrup Nielsen <[EMAIL PROTECTED]> [010729 13:36]: > On Sun, 29 Jul 2001, Baruch Even wrote: > > > Please apply soon, the GRAPHICS to Graphics change means that the inset > > loading after saving doesnt work until it is applied. > > I'd love to if you send the patch. > > Thanks, > > Asger > > -- Baruch Even http://baruch.ev-en.org/ graphics.diff.gz
Re: [PATCH] InsetGraphics updates
On Sun, 29 Jul 2001, Baruch Even wrote: > Sure, sure, couldn't you just read it off my mind... ah, never mind I'll > send it anyway... I promise to practice that. After all, it would be fairly useful. Meanwhile, I'll applied the patch. Greets, Asger graphics.diff.gz
Re: [PATCH] InsetGraphics updates #2
Baruch Even wrote: > > Adds the scale method as request by Michael. > Fixes the EPS detection part, non hacky revision (Garst please test). Happily, let you know in 2h. Thanks, Garst
Re: [PATCH] InsetGraphics updates #2
Baruch Even wrote:
>
> Adds the scale method as request by Michael.
> Fixes the EPS detection part, non hacky revision (Garst please test).
Maybe missing an include.
cvs log attached.
Garst
Making all in insets
make[3]: Entering directory `/usr/local/garst/lyx-devel/src/insets'
/bin/sh ../../libtool --mode=compile g++ -DHAVE_CONFIG_H -I. -I. -I../../src -I./../
-I../.. -I../.. -I../../boost -isystem /usr/X11R6/include -O -W -Wall -c
insetgraphics.C
g++ -DHAVE_CONFIG_H -I. -I. -I../../src -I./../ -I../.. -I../.. -I../../boost -isystem
/usr/X11R6/include -O -W -Wall -Wp,-MD,.deps/insetgraphics.pp -c insetgraphics.C
insetgraphics.C: In function `bool ::isEPS(const std::string&)':
insetgraphics.C:539: `ifstream' undeclared (first use this function)
insetgraphics.C:539: (Each undeclared identifier is reported only once for each
function it appears in.)
insetgraphics.C:539: parse error before `(' token
insetgraphics.C:541: `ifs' undeclared (first use this function)
make[3]: *** [insetgraphics.lo] Error 1
Re: [PATCH] InsetGraphics updates #2
"Garst R. Reese" wrote: > > Baruch Even wrote: > > > > Adds the scale method as request by Michael. > > Fixes the EPS detection part, non hacky revision (Garst please test). > Maybe missing an include. > cvs log attached. > Garst No, it needed using std::ifstream; compiling now. Garst
Re: [PATCH] InsetGraphics updates #2
Baruch Even wrote: > > Adds the scale method as request by Michael. > Fixes the EPS detection part, non hacky revision (Garst please test). > > The scale option is added to the horizontal part but affects both > horizontal and vertical, bad UI, I know. Consider this a proof of > concept, and if someone won't do the UI fix I'll do it some other time. > > -- > Baruch Even > http://baruch.ev-en.org/ > > > Name: ig2.diff.gz >ig2.diff.gzType: unspecified type (application/octet-stream) > Encoding: base64 Looks good here. Got all of "weird" filenames with no sweat. mathpanel patch also retested. Thanks much, Garst
Re: [PATCH] InsetGraphics updates #2
On Sun, Jul 29, 2001 at 02:42:48PM +0300, Baruch Even wrote: > Adds the scale method as request by Michael. > Fixes the EPS detection part, non hacky revision (Garst please test). > > The scale option is added to the horizontal part but affects both > horizontal and vertical, bad UI, I know. Consider this a proof of > concept, and if someone won't do the UI fix I'll do it some other time. Looking at the patch, it seems that if you have foo.epsi, lyx will try to convert it to foo.eps ... Also, why did you define epsi format in your previous patch ? One argument in Converter::Convert is the format of the from_file, so it can be used as follows: converters.Convert(..,"foo.epsi",..., "eps", "pdf")
Re: [PATCH] InsetGraphics updates #2
* Dekel Tsur <[EMAIL PROTECTED]> [010729 19:02]: > On Sun, Jul 29, 2001 at 02:42:48PM +0300, Baruch Even wrote: > > Adds the scale method as request by Michael. > > Fixes the EPS detection part, non hacky revision (Garst please test). > > > > The scale option is added to the horizontal part but affects both > > horizontal and vertical, bad UI, I know. Consider this a proof of > > concept, and if someone won't do the UI fix I'll do it some other time. > > Looking at the patch, it seems that if you have foo.epsi, lyx will try to > convert it to foo.eps ... The latest patch will avoid this since it will detect it to be an eps file and avoid converting it, the detectFormat function will return the same suffix and so the if (suffix == fmt_to_convert_to) return; will just return with no conversion. > Also, why did you define epsi format in your previous patch ? > One argument in Converter::Convert is the format of the from_file, so > it can be used as follows: >converters.Convert(..,"foo.epsi",..., "eps", "pdf") gotcha, can you finally write doc strings for converter? Everytime I need to use it and want to know how to do something I need to read the goddamn code, and it's not that easy to follow. If you'll document it's features and how to use it I'll know how to use it better and will not need such hacks. -- Baruch Even http://baruch.ev-en.org/
