Re: [PATCH] Re: crash while dissolving tabular
Jürgen Spitzmüller wrote: Abdelrazak Younes wrote: Here is a radical solution. I should have thought about this earlier! The dialog will be updated in any case by the LyXFunc::dispatch() method so the updating done in InsetTabular::dispatch() is superfluous. This patch - doesn't compile (is_deleted_ is still used in the destructor) Yes, I was about to send an updated patch when I noticed this: - breaks the tabular dialog (try to check something in the dialog, e.g. multicolumn; it's not possible). This is because the controller/dialog/dispatch is so brain damaged that I wonder how it worked up until now. So we need to investigate further. I am going to try to put the updateDialog() method in the Controller instead and see how it goes. Abdel.
Re: [PATCH] Re: crash while dissolving tabular
Abdelrazak Younes wrote: Here is a radical solution. I should have thought about this earlier! The dialog will be updated in any case by the LyXFunc::dispatch() method so the updating done in InsetTabular::dispatch() is superfluous. This patch - doesn't compile (is_deleted_ is still used in the destructor) - fixes the crash, but - breaks the tabular dialog (try to check something in the dialog, e.g. multicolumn; it's not possible). So we need to investigate further. Jürgen
Re: [PATCH] Re: crash while dissolving tabular
Jürgen Spitzmüller wrote: Abdelrazak Younes wrote: Here is a radical solution. I should have thought about this earlier! The dialog will be updated in any case by the LyXFunc::dispatch() method so the updating done in InsetTabular::dispatch() is superfluous. This patch - doesn't compile (is_deleted_ is still used in the destructor) Yes, I was about to send an updated patch when I noticed this: - breaks the tabular dialog (try to check something in the dialog, e.g. "multicolumn"; it's not possible). This is because the controller/dialog/dispatch is so brain damaged that I wonder how it worked up until now. So we need to investigate further. I am going to try to put the updateDialog() method in the Controller instead and see how it goes. Abdel.
Re: [PATCH] Re: crash while dissolving tabular
Abdelrazak Younes wrote: > Here is a radical solution. I should have thought about this earlier! > The dialog will be updated in any case by the LyXFunc::dispatch() method > so the updating done in InsetTabular::dispatch() is superfluous. This patch - doesn't compile (is_deleted_ is still used in the destructor) - fixes the crash, but - breaks the tabular dialog (try to check something in the dialog, e.g. "multicolumn"; it's not possible). So we need to investigate further. Jürgen
