Re: [patch] LyX crashes with multiple views, #3785
Jürgen Spitzmüller wrote: Alfredo Braunstein wrote: I was hoping for the patch to be applied sooner, as it was discussed enough, fixed a crash, and had some good side effects (removal of the destroyed signals etc)... But you wrote it's completely untested. If this is no more true, I'd say go ahead and apply it. I tested it a few days without problems. I don't have svn rights ATM, could someone else do it for me? Last version is in the 'road to rc2' thread. A/
Re: [patch] LyX crashes with multiple views, #3785
Alfredo Braunstein wrote: I tested it a few days without problems. I don't have svn rights ATM, you should get them back as soon as possible IMHO. Then you're indebted to contribute again ;-) could someone else do it for me? Last version is in the 'road to rc2' thread. I'll do it. Jürgen
Re: [patch] LyX crashes with multiple views, #3785
Am Samstag, 9. Juni 2007 schrieb Jürgen Spitzmüller: could someone else do it for me? Last version is in the 'road to rc2' thread. I'll do it. But please write a log message. Jürgen
Re: [patch] LyX crashes with multiple views, #3785
Am 09.06.2007 um 11:07 schrieb Jürgen Spitzmüller: Alfredo Braunstein wrote: I tested it a few days without problems. I don't have svn rights ATM, you should get them back as soon as possible IMHO. Then you're indebted to contribute again ;-) could someone else do it for me? Last version is in the 'road to rc2' thread. I'll do it. Please read my comment in the rc2 thread. Stefan PGP.sig Description: Signierter Teil der Nachricht
Re: [patch] LyX crashes with multiple views, #3785
And, if the inset = 0 it's a broken cursor in any way, no? So take a wrong idx, hence inset=0. In the next loop with inset()==inset will not cut if off. I think it's wrong. I was right. You can crash it like this: abcde, insert ERT inset, type inside fgh. Place the cursor behind the h. Create a new window, select the everything and delete (even less is enough) = crash because nargs is called on a 0 inset. Stefan PGP.sig Description: Signierter Teil der Nachricht
Re: [patch] LyX crashes with multiple views, #3785
Jürgen Spitzmüller wrote: > Alfredo Braunstein wrote: >> I was hoping for the patch to be applied sooner, as >> it was discussed enough, fixed a crash, and had some good side effects >> (removal of the destroyed signals etc)... > > But you wrote it's "completely untested". If this is no more true, I'd say > go ahead and apply it. I tested it a few days without problems. I don't have svn rights ATM, could someone else do it for me? Last version is in the 'road to rc2' thread. A/
Re: [patch] LyX crashes with multiple views, #3785
Alfredo Braunstein wrote: > I tested it a few days without problems. I don't have svn rights ATM, you should get them back as soon as possible IMHO. Then you're indebted to contribute again ;-) > could someone else do it for me? Last version is in the 'road to rc2' > thread. I'll do it. Jürgen
Re: [patch] LyX crashes with multiple views, #3785
Am Samstag, 9. Juni 2007 schrieb Jürgen Spitzmüller: > > could someone else do it for me? Last version is in the 'road to rc2' > > thread. > > I'll do it. But please write a log message. Jürgen
Re: [patch] LyX crashes with multiple views, #3785
Am 09.06.2007 um 11:07 schrieb Jürgen Spitzmüller: Alfredo Braunstein wrote: I tested it a few days without problems. I don't have svn rights ATM, you should get them back as soon as possible IMHO. Then you're indebted to contribute again ;-) could someone else do it for me? Last version is in the 'road to rc2' thread. I'll do it. Please read my comment in the rc2 thread. Stefan PGP.sig Description: Signierter Teil der Nachricht
Re: [patch] LyX crashes with multiple views, #3785
And, if the inset = 0 it's a broken cursor in any way, no? So take a wrong idx, hence inset=0. In the next loop with inset()==inset will not cut if off. I think it's wrong. I was right. You can crash it like this: "abcde", insert ERT inset, type inside "fgh". Place the cursor behind the h. Create a new window, select the everything and delete (even less is enough) => crash because nargs is called on a 0 inset. Stefan PGP.sig Description: Signierter Teil der Nachricht
Re: [patch] LyX crashes with multiple views, #3785
Stefan Schimanski wrote: If we want multiple views and update the cursors when switching, we should do it properly, maybe somehow similar to the patch below. The bug: http://bugzilla.lyx.org/show_bug.cgi?id=3785 Stefan Or... just apply http://www.mail-archive.com/lyx-devel@lists.lyx.org/msg119336.html ;-) A/
Re: [patch] LyX crashes with multiple views, #3785
Am 08.06.2007 um 20:05 schrieb Alfredo Braunstein: Stefan Schimanski wrote: If we want multiple views and update the cursors when switching, we should do it properly, maybe somehow similar to the patch below. The bug: http://bugzilla.lyx.org/show_bug.cgi?id=3785 Stefan Or... just apply http://www.mail-archive.com/lyx-devel@lists.lyx.org/msg119336.html ;-) Grrr, it would be helpful if one puts a comment at a bug if one has a patch. The subject of that thread is not really indicating that is has something to do with the bug. Stefan PGP.sig Description: Signierter Teil der Nachricht
Re: [patch] LyX crashes with multiple views, #3785
Stefan Schimanski wrote: Grrr, it would be helpful if one puts a comment at a bug if one has a patch. The subject of that thread is not really indicating that is has something to do with the bug. Yes, sorry about that... I was hoping for the patch to be applied sooner, as it was discussed enough, fixed a crash, and had some good side effects (removal of the destroyed signals etc)... A/
Re: [patch] LyX crashes with multiple views, #3785
Alfredo Braunstein wrote: I was hoping for the patch to be applied sooner, as it was discussed enough, fixed a crash, and had some good side effects (removal of the destroyed signals etc)... But you wrote it's completely untested. If this is no more true, I'd say go ahead and apply it. Jürgen
Re: [patch] LyX crashes with multiple views, #3785
Stefan Schimanski wrote: > If we want multiple views and update the cursors when switching, we > should do it properly, maybe somehow similar to the patch below. > > The bug: http://bugzilla.lyx.org/show_bug.cgi?id=3785 > > Stefan Or... just apply http://www.mail-archive.com/lyx-devel@lists.lyx.org/msg119336.html ;-) A/
Re: [patch] LyX crashes with multiple views, #3785
Am 08.06.2007 um 20:05 schrieb Alfredo Braunstein: Stefan Schimanski wrote: If we want multiple views and update the cursors when switching, we should do it properly, maybe somehow similar to the patch below. The bug: http://bugzilla.lyx.org/show_bug.cgi?id=3785 Stefan Or... just apply http://www.mail-archive.com/lyx-devel@lists.lyx.org/msg119336.html ;-) Grrr, it would be helpful if one puts a comment at a bug if one has a patch. The subject of that thread is not really indicating that is has something to do with the bug. Stefan PGP.sig Description: Signierter Teil der Nachricht
Re: [patch] LyX crashes with multiple views, #3785
Stefan Schimanski wrote: > Grrr, it would be helpful if one puts a comment at a bug if one has a > patch. The subject of that thread is not really indicating that is > has something to do with the bug. Yes, sorry about that... I was hoping for the patch to be applied sooner, as it was discussed enough, fixed a crash, and had some good side effects (removal of the destroyed signals etc)... A/
Re: [patch] LyX crashes with multiple views, #3785
Alfredo Braunstein wrote: > I was hoping for the patch to be applied sooner, as > it was discussed enough, fixed a crash, and had some good side effects > (removal of the destroyed signals etc)... But you wrote it's "completely untested". If this is no more true, I'd say go ahead and apply it. Jürgen
