Re: [patch] remove linuxdoc from all doc files
Richard Heck wrote: I've done this: patch attached. That said, just removing the option from the dialog won't do anything one way or another about old files in which it exists. Those files will still be loaded with that option, and it won't be handled properly. Maybe that's OK for now, but I'd have thought we should eliminate it altogether, if we're removing it from the dialog. If so, this is a format change, and appropriate lyx2lyx will presumably be needed (maybe just to convert htmlurl insets into url insets). I haven't gone into lyx2lyx, so someone else would need to do that. To eliminate this, we'd need changes everywhere htmlurl is mentioned: factory.cpp:430: || cmdName == htmlurl) { insets/Inset.cpp:64: InsetName(htmlurl, Inset::HTMLURL_CODE), insets/InsetCommandParams.cpp:166: if (name == htmlurl || name == url) { Text3.cpp:1166: InsetCommandParams p(htmlurl); But those changes are pretty obvious. It's the lyx2lyx stuff that I don't understand. Richard The lyx2lyx change would probably be very trivial, something like (untested): def convert_htmlurl(document): \begin_inset LatexCommand htmlurl - \begin_inset LatexCommand url for i in range(len(document.body)): document.body[i] = document.body[i].replace(\\begin_inset LatexCommand htmlurl, \\begin_inset LatexCommand url) reversion would not be needed. However, I'm not sure we should do all these changes now. What happens with old LinuxDoc documents BTW? Jürgen
Re: [patch] remove linuxdoc from all doc files
Jürgen Spitzmüller wrote: Richard Heck wrote: I've done this: patch attached. That said, just removing the option from the dialog won't do anything one way or another about old files in which it exists. Those files will still be loaded with that option, and it won't be handled properly. Maybe that's OK for now, but I'd have thought we should eliminate it altogether, if we're removing it from the dialog. If so, this is a format change, and appropriate lyx2lyx will presumably be needed (maybe just to convert htmlurl insets into url insets). I haven't gone into lyx2lyx, so someone else would need to do that. To eliminate this, we'd need changes everywhere htmlurl is mentioned: factory.cpp:430: || cmdName == htmlurl) { insets/Inset.cpp:64:InsetName(htmlurl, Inset::HTMLURL_CODE), insets/InsetCommandParams.cpp:166: if (name == htmlurl || name == url) { Text3.cpp:1166: InsetCommandParams p(htmlurl); But those changes are pretty obvious. It's the lyx2lyx stuff that I don't understand. Richard The lyx2lyx change would probably be very trivial, something like (untested): def convert_htmlurl(document): \begin_inset LatexCommand htmlurl - \begin_inset LatexCommand url for i in range(len(document.body)): document.body[i] = document.body[i].replace(\\begin_inset LatexCommand htmlurl, \\begin_inset LatexCommand url) reversion would not be needed. However, I'm not sure we should do all these changes now. It may not be critical to do this now. But What happens with old LinuxDoc documents BTW? Presumably, if you load one of these, it'll load fine, but if you opened one of the URL insets and did something to it, it'd be changed from htmlurl to url behind your back. Again, maybe not a huge problem, since that's what the lyx2lyx change would have done, anyway. But for what it's worth, my sense is that---modulo the lyx2lyx stuff, which I don't understand---the changes here are simple and safe, but not critical at this time. But this stuff should be removed before it is forgotten. Richard -- == Richard G Heck, Jr Professor of Philosophy Brown University http://frege.brown.edu/heck/ == Get my public key from http://sks.keyserver.penguin.de Hash: 0x1DE91F1E66FFBDEC Learn how to sign your email using Thunderbird and GnuPG at: http://dudu.dyn.2-h.org/nist/gpg-enigmail-howto
Re: [patch] remove linuxdoc from all doc files
On Wednesday 18 July 2007 07:22:17 Richard Heck wrote: Presumably, if you load one of these, it'll load fine, but if you opened one of the URL insets and did something to it, it'd be changed from htmlurl to url behind your back. Again, maybe not a huge problem, since that's what the lyx2lyx change would have done, anyway. But for what it's worth, my sense is that---modulo the lyx2lyx stuff, which I don't understand---the changes here are simple and safe, but not critical at this time. But this stuff should be removed before it is forgotten. I propose to ignore this for the moment. It is low hanging fruit so we can take care of it at any time. Richard -- José Abílio
Re: [patch] remove linuxdoc from all doc files
On Wednesday 18 July 2007 11:07:33 José Matos wrote: I propose to ignore this for the moment. It is low hanging fruit so we can take care of it at any time. In case it matters this really means to move this fix to 1.6 since it (possibly) involves a file format change. -- José Abílio -- José Abílio
Re: [patch] remove linuxdoc from all doc files
I propose to ignore this for the moment. It is low hanging fruit so we can take care of it at any time. OK, but what about the docs? Should I remove the description of linuxdoc or not? regards Uwe
Re: [patch] remove linuxdoc from all doc files
On Wednesday 18 July 2007 12:38:05 Uwe Stöhr wrote: OK, but what about the docs? Should I remove the description of linuxdoc or not? Remove it. regards Uwe -- José Abílio
Re: [patch] remove linuxdoc from all doc files
OK, but what about the docs? Should I remove the description of linuxdoc or not? Remove it. Done. Uwe
Re: [patch] remove linuxdoc from all doc files
Richard Heck wrote: > I've done this: patch attached. That said, just removing the option from > the dialog won't do anything one way or another about old files in which > it exists. Those files will still be loaded with that option, and it > won't be handled properly. > > Maybe that's OK for now, but I'd have thought we should eliminate it > altogether, if we're removing it from the dialog. If so, this is a > format change, and appropriate lyx2lyx will presumably be needed (maybe > just to convert htmlurl insets into url insets). I haven't gone into > lyx2lyx, so someone else would need to do that. To eliminate this, we'd > need changes everywhere htmlurl is mentioned: > factory.cpp:430: || cmdName == "htmlurl") { > insets/Inset.cpp:64: InsetName("htmlurl", Inset::HTMLURL_CODE), > insets/InsetCommandParams.cpp:166: if (name == "htmlurl" || name == > "url") { > Text3.cpp:1166: InsetCommandParams p("htmlurl"); > But those changes are pretty obvious. It's the lyx2lyx stuff that I > don't understand. > > Richard The lyx2lyx change would probably be very trivial, something like (untested): def convert_htmlurl(document): " \begin_inset LatexCommand htmlurl -> \begin_inset LatexCommand url" for i in range(len(document.body)): document.body[i] = document.body[i].replace("\\begin_inset LatexCommand htmlurl", "\\begin_inset LatexCommand url") reversion would not be needed. However, I'm not sure we should do all these changes now. What happens with old LinuxDoc documents BTW? Jürgen
Re: [patch] remove linuxdoc from all doc files
Jürgen Spitzmüller wrote: Richard Heck wrote: I've done this: patch attached. That said, just removing the option from the dialog won't do anything one way or another about old files in which it exists. Those files will still be loaded with that option, and it won't be handled properly. Maybe that's OK for now, but I'd have thought we should eliminate it altogether, if we're removing it from the dialog. If so, this is a format change, and appropriate lyx2lyx will presumably be needed (maybe just to convert htmlurl insets into url insets). I haven't gone into lyx2lyx, so someone else would need to do that. To eliminate this, we'd need changes everywhere htmlurl is mentioned: factory.cpp:430: || cmdName == "htmlurl") { insets/Inset.cpp:64:InsetName("htmlurl", Inset::HTMLURL_CODE), insets/InsetCommandParams.cpp:166: if (name == "htmlurl" || name == "url") { Text3.cpp:1166: InsetCommandParams p("htmlurl"); But those changes are pretty obvious. It's the lyx2lyx stuff that I don't understand. Richard The lyx2lyx change would probably be very trivial, something like (untested): def convert_htmlurl(document): " \begin_inset LatexCommand htmlurl -> \begin_inset LatexCommand url" for i in range(len(document.body)): document.body[i] = document.body[i].replace("\\begin_inset LatexCommand htmlurl", "\\begin_inset LatexCommand url") reversion would not be needed. However, I'm not sure we should do all these changes now. It may not be critical to do this now. But What happens with old LinuxDoc documents BTW? Presumably, if you load one of these, it'll load fine, but if you opened one of the URL insets and did something to it, it'd be changed from htmlurl to url behind your back. Again, maybe not a huge problem, since that's what the lyx2lyx change would have done, anyway. But for what it's worth, my sense is that---modulo the lyx2lyx stuff, which I don't understand---the changes here are simple and safe, but not critical at this time. But this stuff should be removed before it is forgotten. Richard -- == Richard G Heck, Jr Professor of Philosophy Brown University http://frege.brown.edu/heck/ == Get my public key from http://sks.keyserver.penguin.de Hash: 0x1DE91F1E66FFBDEC Learn how to sign your email using Thunderbird and GnuPG at: http://dudu.dyn.2-h.org/nist/gpg-enigmail-howto
Re: [patch] remove linuxdoc from all doc files
On Wednesday 18 July 2007 07:22:17 Richard Heck wrote: > > Presumably, if you load one of these, it'll load fine, but if you opened > one of the URL insets and did something to it, it'd be changed from > htmlurl to url behind your back. Again, maybe not a huge problem, since > that's what the lyx2lyx change would have done, anyway. But for what > it's worth, my sense is that---modulo the lyx2lyx stuff, which I don't > understand---the changes here are simple and safe, but not critical at > this time. But this stuff should be removed before it is forgotten. I propose to ignore this for the moment. It is low hanging fruit so we can take care of it at any time. > Richard -- José Abílio
Re: [patch] remove linuxdoc from all doc files
On Wednesday 18 July 2007 11:07:33 José Matos wrote: > I propose to ignore this for the moment. It is low hanging fruit so we > can take care of it at any time. In case it matters this really means to move this fix to 1.6 since it (possibly) involves a file format change. > -- > José Abílio -- José Abílio
Re: [patch] remove linuxdoc from all doc files
> I propose to ignore this for the moment. It is low hanging fruit so we can > take care of it at any time. OK, but what about the docs? Should I remove the description of linuxdoc or not? regards Uwe
Re: [patch] remove linuxdoc from all doc files
On Wednesday 18 July 2007 12:38:05 Uwe Stöhr wrote: > OK, but what about the docs? Should I remove the description of linuxdoc or > not? Remove it. > regards Uwe -- José Abílio
Re: [patch] remove linuxdoc from all doc files
>> OK, but what about the docs? Should I remove the description of linuxdoc or >> not? > Remove it. Done. Uwe
Re: [patch] remove linuxdoc from all doc files
Uwe Stöhr wrote: Jürgen requested that I fix bug 2787: http://bugzilla.lyx.org/show_bug.cgi?id=2787 for LyX 1.5.0. I did this in the attached patch. (I can do the same for the translated manuals when I get the OK.) But when applying this, the generate hyperlink option in the URL dialog is then senseless (perhaps this is already the case) and should be removed from this dialog. (Someone else should do this please.) I've done this: patch attached. That said, just removing the option from the dialog won't do anything one way or another about old files in which it exists. Those files will still be loaded with that option, and it won't be handled properly. Maybe that's OK for now, but I'd have thought we should eliminate it altogether, if we're removing it from the dialog. If so, this is a format change, and appropriate lyx2lyx will presumably be needed (maybe just to convert htmlurl insets into url insets). I haven't gone into lyx2lyx, so someone else would need to do that. To eliminate this, we'd need changes everywhere htmlurl is mentioned: factory.cpp:430: || cmdName == htmlurl) { insets/Inset.cpp:64:InsetName(htmlurl, Inset::HTMLURL_CODE), insets/InsetCommandParams.cpp:166: if (name == htmlurl || name == url) { Text3.cpp:1166: InsetCommandParams p(htmlurl); But those changes are pretty obvious. It's the lyx2lyx stuff that I don't understand. Richard Opinions? regards Uwe Index: Customization.lyx === --- Customization.lyx (revision 19106) +++ Customization.lyx (working copy) @@ -1,5 +1,5 @@ #LyX 1.5.0svn created this file. For more info see http://www.lyx.org/ -\lyxformat 274 +\lyxformat 276 \begin_document \begin_header \textclass book @@ -39,9 +39,10 @@ \paperpagestyle headings \tracking_changes false \output_changes false -\author Richard Heck -\author Jean-Marc Lasgouttes -\author usti +\author +\author +\author +\author \end_header \begin_body @@ -5967,7 +5968,7 @@ \begin_layout Standard This indicates that your text class uses the foo.sty package. - Finally, it is also possible to declare classes for SGML and DocBook code. + Finally, it is also possible to declare classes for DocBook code. Typical declarations will look like \end_layout @@ -5982,20 +5983,6 @@ \size small # \backslash -DeclareSGMLClass{SGML (LinuxDoc)} -\end_layout - -\begin_layout Standard -or -\end_layout - -\begin_layout LyX-Code -#% Do not delete the line below; configure depends on this -\end_layout - -\begin_layout LyX-Code -# -\backslash DeclareDocBookClass[article]{SGML (DocBook article)} \end_layout @@ -9473,10 +9460,6 @@ \end_layout \begin_layout LyX-Code -Format LinuxDoc -\end_layout - -\begin_layout LyX-Code Product [XFig: $$FName] \end_layout @@ -9666,7 +9649,7 @@ \family typewriter \series medium Format\InsetSpace ~ -LaTeX|PDFLaTeX|PlainText|DocBook|LinuxDoc +LaTeX|PDFLaTeX|PlainText|DocBook \family default \series default The primary document file format that this format definition is for. @@ -9676,8 +9659,7 @@ Format \family default section for all formats. - Use a dummy text when no representation is available (see the LinuxDoc - format in the example above). + Use a dummy text when no representation is available. Then you can at least see a reference to the external material in the exported document. \end_layout Index: EmbeddedObjects.lyx === --- EmbeddedObjects.lyx (revision 19106) +++ EmbeddedObjects.lyx (working copy) @@ -201,7 +201,8 @@ \bullet 3 2 7 -1 \tracking_changes false \output_changes false -\author Uwe Stöhr +\author +\author \end_header \begin_body @@ -26880,28 +26881,6 @@ \end_layout \begin_layout Standard -The option -\family sans -Generate\InsetSpace ~ -hyperlink -\family default - in the URL dialog has only an affect when you export your document to the - format -\begin_inset Quotes eld -\end_inset - - -\family sans -LinuxDoc -\family default - -\begin_inset Quotes erd -\end_inset - -. -\end_layout - -\begin_layout Standard You cannot change the style of the link text. The text of the \family sans Index: Extended.lyx === --- Extended.lyx(revision 19106) +++ Extended.lyx(working copy) @@ -1,5 +1,5 @@ #LyX 1.5.0svn created this file. For more info see http://www.lyx.org/ -\lyxformat 274 +\lyxformat 276 \begin_document \begin_header \textclass book @@ -37,7 +37,8 @@ \paperpagestyle headings \tracking_changes false \output_changes false -\author usti +\author +\author \end_header \begin_body @@ -15404,675 +15405,6 @@ \end_layout \begin_layout Section -Using LyX with SGML-Tools (aka LinuxDoc) -\end_layout - -\begin_layout
Re: [patch] remove linuxdoc from all doc files
Uwe Stöhr wrote: Jürgen requested that I fix bug 2787: http://bugzilla.lyx.org/show_bug.cgi?id=2787 for LyX 1.5.0. I did this in the attached patch. (I can do the same for the translated manuals when I get the OK.) But when applying this, the "generate hyperlink" option in the URL dialog is then senseless (perhaps this is already the case) and should be removed from this dialog. (Someone else should do this please.) I've done this: patch attached. That said, just removing the option from the dialog won't do anything one way or another about old files in which it exists. Those files will still be loaded with that option, and it won't be handled properly. Maybe that's OK for now, but I'd have thought we should eliminate it altogether, if we're removing it from the dialog. If so, this is a format change, and appropriate lyx2lyx will presumably be needed (maybe just to convert htmlurl insets into url insets). I haven't gone into lyx2lyx, so someone else would need to do that. To eliminate this, we'd need changes everywhere htmlurl is mentioned: factory.cpp:430: || cmdName == "htmlurl") { insets/Inset.cpp:64:InsetName("htmlurl", Inset::HTMLURL_CODE), insets/InsetCommandParams.cpp:166: if (name == "htmlurl" || name == "url") { Text3.cpp:1166: InsetCommandParams p("htmlurl"); But those changes are pretty obvious. It's the lyx2lyx stuff that I don't understand. Richard Opinions? regards Uwe Index: Customization.lyx === --- Customization.lyx (revision 19106) +++ Customization.lyx (working copy) @@ -1,5 +1,5 @@ #LyX 1.5.0svn created this file. For more info see http://www.lyx.org/ -\lyxformat 274 +\lyxformat 276 \begin_document \begin_header \textclass book @@ -39,9 +39,10 @@ \paperpagestyle headings \tracking_changes false \output_changes false -\author "Richard Heck" -\author "Jean-Marc Lasgouttes" -\author "usti" +\author "" +\author "" +\author "" +\author "" \end_header \begin_body @@ -5967,7 +5968,7 @@ \begin_layout Standard This indicates that your text class uses the foo.sty package. - Finally, it is also possible to declare classes for SGML and DocBook code. + Finally, it is also possible to declare classes for DocBook code. Typical declarations will look like \end_layout @@ -5982,20 +5983,6 @@ \size small # \backslash -DeclareSGMLClass{SGML (LinuxDoc)} -\end_layout - -\begin_layout Standard -or -\end_layout - -\begin_layout LyX-Code -#% Do not delete the line below; configure depends on this -\end_layout - -\begin_layout LyX-Code -# -\backslash DeclareDocBookClass[article]{SGML (DocBook article)} \end_layout @@ -9473,10 +9460,6 @@ \end_layout \begin_layout LyX-Code -Format LinuxDoc -\end_layout - -\begin_layout LyX-Code Product "[XFig: $$FName]" \end_layout @@ -9666,7 +9649,7 @@ \family typewriter \series medium Format\InsetSpace ~ -LaTeX|PDFLaTeX|PlainText|DocBook|LinuxDoc +LaTeX|PDFLaTeX|PlainText|DocBook \family default \series default The primary document file format that this format definition is for. @@ -9676,8 +9659,7 @@ Format \family default section for all formats. - Use a dummy text when no representation is available (see the LinuxDoc - format in the example above). + Use a dummy text when no representation is available. Then you can at least see a reference to the external material in the exported document. \end_layout Index: EmbeddedObjects.lyx === --- EmbeddedObjects.lyx (revision 19106) +++ EmbeddedObjects.lyx (working copy) @@ -201,7 +201,8 @@ \bullet 3 2 7 -1 \tracking_changes false \output_changes false -\author "Uwe Stöhr" +\author "" +\author "" \end_header \begin_body @@ -26880,28 +26881,6 @@ \end_layout \begin_layout Standard -The option -\family sans -Generate\InsetSpace ~ -hyperlink -\family default - in the URL dialog has only an affect when you export your document to the - format -\begin_inset Quotes eld -\end_inset - - -\family sans -LinuxDoc -\family default - -\begin_inset Quotes erd -\end_inset - -. -\end_layout - -\begin_layout Standard You cannot change the style of the link text. The text of the \family sans Index: Extended.lyx === --- Extended.lyx(revision 19106) +++ Extended.lyx(working copy) @@ -1,5 +1,5 @@ #LyX 1.5.0svn created this file. For more info see http://www.lyx.org/ -\lyxformat 274 +\lyxformat 276 \begin_document \begin_header \textclass book @@ -37,7 +37,8 @@ \paperpagestyle headings \tracking_changes false \output_changes false -\author "usti" +\author "" +\author "" \end_header \begin_body @@ -15404,675 +15405,6 @@ \end_layout \begin_layout Section -Using LyX with SGML-Tools (aka