Re: LyX crashes when handling selected databases in the BibTeX Bibliography dialog.

2019-11-20 Thread Jürgen Spitzmüller
Am Mittwoch, den 20.11.2019, 13:25 +0100 schrieb pdv:
> In the dialog for adding a citation, when selecting an item in the
> list 
> on the left, the detail-view is not updated. It's only updated when 
> selecting an item in the list on the right.
> 
> Can you confirm that?

Yes, confirmed. And fixed (hopefully).

Jürgen


signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: LyX crashes when handling selected databases in the BibTeX Bibliography dialog.

2019-11-20 Thread pdv

On 19/11/2019 13:49, Jürgen Spitzmüller wrote:

Am Montag, den 18.11.2019, 10:10 +0100 schrieb pdv:

It works without and when I put it back in, I got immediately a
crash.


Tested and committed.

Thanks!

Jürgen




Jürgen

I just found out another issue.

In the dialog for adding a citation, when selecting an item in the list 
on the left, the detail-view is not updated. It's only updated when 
selecting an item in the list on the right.


Can you confirm that?

To be on the safe side I've inserted the 2 selectionChanged() calls 
again but it's not related to that.


Patrick

--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: LyX crashes when handling selected databases in the BibTeX Bibliography dialog.

2019-11-19 Thread Jürgen Spitzmüller
Am Montag, den 18.11.2019, 10:10 +0100 schrieb pdv:
> It works without and when I put it back in, I got immediately a
> crash.

Tested and committed.

Thanks!

Jürgen


signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: LyX crashes when handling selected databases in the BibTeX Bibliography dialog.

2019-11-18 Thread pdv

On 18/11/2019 09:55, Jürgen Spitzmüller wrote:

Am Sonntag, den 17.11.2019, 19:50 +0100 schrieb pdv:

In addPB_clicked() the idx is only used in one place and it’s
definition
can be moved. In upPB_clicked() and downPB_clicked() I first made idx
of
type QPersistentModelIndex and this avoids the crashes but the
selection
is lost when moving an item up/down.

I then redefined idx before the 2nd use and removed the
selectionChanged() signals and this avoids the crashes and keeps the
selection intact (patch included).


Thanks. Are you sure the selectionChanged() signal does not need to be
emitted?

Jürgen



P. De Visschere



It works without and when I put it back in, I got immediately a crash.

--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: LyX crashes when handling selected databases in the BibTeX Bibliography dialog.

2019-11-18 Thread Jürgen Spitzmüller
Am Sonntag, den 17.11.2019, 19:50 +0100 schrieb pdv:
> In addPB_clicked() the idx is only used in one place and it’s
> definition 
> can be moved. In upPB_clicked() and downPB_clicked() I first made idx
> of 
> type QPersistentModelIndex and this avoids the crashes but the
> selection 
> is lost when moving an item up/down.
> 
> I then redefined idx before the 2nd use and removed the 
> selectionChanged() signals and this avoids the crashes and keeps the 
> selection intact (patch included).

Thanks. Are you sure the selectionChanged() signal does not need to be
emitted?

Jürgen

> 
> P. De Visschere


signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel