Re: Regression on master: cannot insert math in a table cell

2024-02-08 Thread Richard Kimberly Heck

On 2/8/24 12:42, didiergab...@free.fr wrote:
Will the .exe version for Windows64 be corrected in the coming days, 
in the form of "RC2.1",or do you advise me to wait for RC3?

I have a lot of tables containing mathematical elements...


I'll package RC3 this weekend.


Riki

-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Regression on master: cannot insert math in a table cell

2024-02-08 Thread Richard Kimberly Heck

On 2/8/24 03:16, Jürgen Spitzmüller wrote:

Am Donnerstag, dem 08.02.2024 um 09:02 +0100 schrieb Jürgen
Spitzmüller:

Should be fixed as of 61aa19ef9cbaf81

Sorry.

Riki, this might warrant a soonish RC3. It's not only math that was
disabled, but also special characters, spacing and others.


OK. I'll package that this weekend.

Riki


--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Regression on master: cannot insert math in a table cell

2024-02-08 Thread didiergabory
Will the .exe version for Windows64 be corrected in the coming days, in the 
form of "RC2.1", or do you advise me to wait for RC3? 

I have a lot of tables containing mathematical elements... 
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Regression on master: cannot insert math in a table cell

2024-02-08 Thread Scott Kostyshak
On Thu, Feb 08, 2024 at 09:02:31AM +0100, Jürgen Spitzmüller wrote:
> Am Donnerstag, dem 08.02.2024 um 08:43 +0100 schrieb Jürgen
> Spitzmüller:
> > Am Donnerstag, dem 08.02.2024 um 00:23 +0100 schrieb Jean-Marc
> > Lasgouttes:
> > > Manual inspection reveals that the commit below is the culprit.
> > 
> > I thought so. I'll have a look.
> 
> Should be fixed as of 61aa19ef9cbaf81

Works well. Thanks for the quick fix!

Scott


signature.asc
Description: PGP signature
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Regression on master: cannot insert math in a table cell

2024-02-08 Thread José Matos
On Thu, 2024-02-08 at 09:16 +0100, Jürgen Spitzmüller wrote:
> Riki, this might warrant a soonish RC3. It's not only math that was
> disabled, but also special characters, spacing and others.

FWIW I have backported this fix to RC2 (Jürgen's patch applies cleanly)
for Fedora/RHEL packages in copr.

Unsurprisingly I can confirm that this fixes the problem. :-)
-- 
José Abílio
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Regression on master: cannot insert math in a table cell

2024-02-08 Thread Jürgen Spitzmüller
Am Donnerstag, dem 08.02.2024 um 09:02 +0100 schrieb Jürgen
Spitzmüller:
> Should be fixed as of 61aa19ef9cbaf81
> 
> Sorry.

Riki, this might warrant a soonish RC3. It's not only math that was
disabled, but also special characters, spacing and others.

-- 
Jürgen
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Regression on master: cannot insert math in a table cell

2024-02-08 Thread Jürgen Spitzmüller
Am Donnerstag, dem 08.02.2024 um 08:43 +0100 schrieb Jürgen
Spitzmüller:
> Am Donnerstag, dem 08.02.2024 um 00:23 +0100 schrieb Jean-Marc
> Lasgouttes:
> > Manual inspection reveals that the commit below is the culprit.
> 
> I thought so. I'll have a look.

Should be fixed as of 61aa19ef9cbaf81

Sorry.

-- 
Jürgen
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Regression on master: cannot insert math in a table cell

2024-02-07 Thread Jürgen Spitzmüller
Am Donnerstag, dem 08.02.2024 um 00:23 +0100 schrieb Jean-Marc
Lasgouttes:
> Manual inspection reveals that the commit below is the culprit.

I thought so. I'll have a look.

-- 
Jürgen
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Regression on master: cannot insert math in a table cell

2024-02-07 Thread Jean-Marc Lasgouttes

Le 07/02/2024 à 22:34, José Matos a écrit :

On Wed, 2024-02-07 at 12:49 -0500, Scott Kostyshak wrote:

I cannot get into math mode in a table cell, on current master. Just
in
case it helps, I attach an example (but you can also insert a table
in a
new document yourself instead).

I can bisect tomorrow if that would help.

Scott


I can confirm, in addition if we use the menu we can see that the whole
math insertion section is grayed out. So it seems that this is
inadvertently on purpose. :-)
  


Manual inspection reveals that the commit below is the culprit.

JMarc

commit ad6aa8ba4b9525c07e30242dd66e79ec172a2b78
Author: Juergen Spitzmueller 
Date:   Sun Jan 28 12:13:27 2024 +0100

Restrict caption insertion in tables to where it makes sense (#13037)

This requires to move insetAllowed() to the cell level, as only cells
in the caption row of a longtable actually can take a caption.


--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Regression on master: cannot insert math in a table cell

2024-02-07 Thread José Matos
On Wed, 2024-02-07 at 12:49 -0500, Scott Kostyshak wrote:
> I cannot get into math mode in a table cell, on current master. Just
> in
> case it helps, I attach an example (but you can also insert a table
> in a
> new document yourself instead).
> 
> I can bisect tomorrow if that would help.
> 
> Scott

I can confirm, in addition if we use the menu we can see that the whole
math insertion section is grayed out. So it seems that this is
inadvertently on purpose. :-)
 
-- 
José Abílio
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel