Re: Slow responding to mouse clicks in included child document
Am Fri, 9 Apr 2021 18:20:36 +0200 schrieb Jean-Marc Lasgouttes : > Le 09/04/2021 à 16:24, Kornel Benko a écrit : > > I meant the same. Waiting more than 3 seconds. > > Should be fixed now. A very stupid thinko. > > JMarc > Confirmed. Perfect! Kornel pgpHT_29Y67HW.pgp Description: Digitale Signatur von OpenPGP -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: Slow responding to mouse clicks in included child document
Le 09/04/2021 à 16:24, Kornel Benko a écrit : I meant the same. Waiting more than 3 seconds. Should be fixed now. A very stupid thinko. JMarc -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: Slow responding to mouse clicks in included child document
Am Fri, 9 Apr 2021 14:52:07 +0200 schrieb Jean-Marc Lasgouttes : > Le 09/04/2021 à 13:02, Kornel Benko a écrit : > > Am Fri, 9 Apr 2021 12:03:18 +0200 > > schrieb Jean-Marc Lasgouttes : > >> Thanks Kornel for doing the bisect. I did not anticipate this at all. I > >> will take a look and hope this is easily fixable. > >> > >> JMarc > >> > > > > Yes, sometimes the effects are hard to foresee ... > > I am trying to reproduce and all I see (which is already a bug) is > slugish selection with mouse. > > What do you mean by "wait, wait, wait"? > > JMarc I meant the same. Waiting more than 3 seconds. Kornel pgpTOwM_7Embz.pgp Description: Digitale Signatur von OpenPGP -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: Slow responding to mouse clicks in included child document
Le 09/04/2021 à 13:02, Kornel Benko a écrit : Am Fri, 9 Apr 2021 12:03:18 +0200 schrieb Jean-Marc Lasgouttes : Thanks Kornel for doing the bisect. I did not anticipate this at all. I will take a look and hope this is easily fixable. JMarc Yes, sometimes the effects are hard to foresee ... I am trying to reproduce and all I see (which is already a bug) is slugish selection with mouse. What do you mean by "wait, wait, wait"? JMarc -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: Slow responding to mouse clicks in included child document
Am Fri, 9 Apr 2021 12:03:18 +0200 schrieb Jean-Marc Lasgouttes : > Le 09/04/2021 à 11:28, Kornel Benko a écrit : > > Am Thu, 8 Apr 2021 18:33:47 +0200 > > schrieb Kornel Benko : > > > >> Master: > >> > >> 1.) Open 'MergedManuals' > >> 2.) Goto Intro.lyx > >> 2a.) Edit included document > >> 3.) Mouse click anywhere inside this documen > >>3a.) wait, wait, ... > >> > >> > >> No such problems with lyx2.3. > >> > >>Kornel > > > > Bisect lead to > > > > f3a0e8ff9a9b914d40eb520bb31674d1ad4eb0d0 is the first bad commit > > commit f3a0e8ff9a9b914d40eb520bb31674d1ad4eb0d0 > > Author: Jean-Marc Lasgouttes > > Date: Thu Jan 28 10:10:18 2021 +0100 > > > > Run updateBuffer when adding/merging changes > > Thanks Kornel for doing the bisect. I did not anticipate this at all. I > will take a look and hope this is easily fixable. > > JMarc > Yes, sometimes the effects are hard to foresee ... :) Kornel pgp_d6j8kzZtM.pgp Description: Digitale Signatur von OpenPGP -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: Slow responding to mouse clicks in included child document
Le 09/04/2021 à 11:28, Kornel Benko a écrit : Am Thu, 8 Apr 2021 18:33:47 +0200 schrieb Kornel Benko : Master: 1.) Open 'MergedManuals' 2.) Goto Intro.lyx 2a.) Edit included document 3.) Mouse click anywhere inside this documen 3a.) wait, wait, ... No such problems with lyx2.3. Kornel Bisect lead to f3a0e8ff9a9b914d40eb520bb31674d1ad4eb0d0 is the first bad commit commit f3a0e8ff9a9b914d40eb520bb31674d1ad4eb0d0 Author: Jean-Marc Lasgouttes Date: Thu Jan 28 10:10:18 2021 +0100 Run updateBuffer when adding/merging changes Thanks Kornel for doing the bisect. I did not anticipate this at all. I will take a look and hope this is easily fixable. JMarc -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: Slow responding to mouse clicks in included child document
Am Thu, 8 Apr 2021 18:33:47 +0200 schrieb Kornel Benko : > Master: > > 1.) Open 'MergedManuals' > 2.) Goto Intro.lyx > 2a.) Edit included document > 3.) Mouse click anywhere inside this documen > 3a.) wait, wait, ... > > > No such problems with lyx2.3. > > Kornel Bisect lead to f3a0e8ff9a9b914d40eb520bb31674d1ad4eb0d0 is the first bad commit commit f3a0e8ff9a9b914d40eb520bb31674d1ad4eb0d0 Author: Jean-Marc Lasgouttes Date: Thu Jan 28 10:10:18 2021 +0100 Run updateBuffer when adding/merging changes Following 4a4ded22, the enabling of some change-related functions is handled in updateBuffer. However, this method is not ran at every document change for performance reasons. This patch adds code to every place that modifies Paragraph::Private::changes_ that checks whether the `changedness' of the paragraph, err... changes. To this end, a new helper struct is introduced that remembers paragraph state at contruction time, and compares it to new state in the destructor. New forceUpdate/needUpdate methods are added to Buffer class, since the cursor is in general not available in the places where these changes are made. Fixes bug #12074. :04 04 51604870808f821addf92eeed8ac5bfbd1843c84 72930f724d365abc33c2563aad847730dc0d03bf M src Kornel pgpA2Wmgp00bL.pgp Description: Digitale Signatur von OpenPGP -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
