Re: Where to use qt4 (Re: Export-to fails for xhtml)
Op 11-12-2012 13:09, Pavel Sanda schreef: Tommaso Cucinotta wrote: Yes, everything compiles fine. Also ColorCache.h was not giving any trouble, till I included it in graphics/PreviewLoader.cpp, because then gcc complained it cannot find QColor nor QPalette (and I had to add the QtGui/). Yes I understand the issue now. Qt4 creeping out of qt4/ directory. I don't have strong opinion since we already crossed the line in server and compare feature. But other may have some comments as well, it's not just technical issue (shall we get rid of frontend/qt4 structure?) Pavel The reasons we have crossed the line is to make use of the cross-platform implementation of Qt. This doesn't mean that we can pull in frontend or gui stuff into the core. Vincent
Re: Where to use qt4 (Re: Export-to fails for xhtml)
On 12/12/12 19:40, Tommaso Cucinotta wrote: > On 12/12/12 10:20, Jean-Marc Lasgouttes wrote: >> Le 12/12/2012 01:13, Tommaso Cucinotta a écrit : >>> I see, it seems we opened a "Pandora" box here. Well, if any Xmas presents >>> come out of it, then it's not too bad :-). However, so far, it seems >>> only a lot of work with likely disruption of the compilation/makefile >>> functionality :-)... for weeks :-) perhaps months, as anything >>> will be deferred to the new year >> >> OTOH, if we want to do something like that, just before a major version is >> the right time, since it ensures that the devel tree and the master >> tree are not too far off. > > Anyway, for now, I've just put the SEGFAULT fix in as [4285b0b3/lyxgit], > deferring optimal restructuring of the sources to whoever feels that > urgency ... > > Is that needed for branch too ? Yes, in branch we don't have -E, but we do have -e, which was crashing anyway. Fixed in [60c96e3a/lyxgit]. Any status.20x update needed ? We don't have any trac bug to connect with. T.
Re: Where to use qt4 (Re: Export-to fails for xhtml)
On 12/12/12 10:20, Jean-Marc Lasgouttes wrote: > Le 12/12/2012 01:13, Tommaso Cucinotta a écrit : >> I see, it seems we opened a "Pandora" box here. Well, if any Xmas presents >> come out of it, then it's not too bad :-). However, so far, it seems >> only a lot of work with likely disruption of the compilation/makefile >> functionality :-)... for weeks :-) perhaps months, as anything >> will be deferred to the new year > > OTOH, if we want to do something like that, just before a major version is > the right time, since it ensures that the devel tree and the master > tree are not too far off. Anyway, for now, I've just put the SEGFAULT fix in as [4285b0b3/lyxgit], deferring optimal restructuring of the sources to whoever feels that urgency ... Is that needed for branch too ? T.
Re: Where to use qt4 (Re: Export-to fails for xhtml)
Le 12/12/2012 01:13, Tommaso Cucinotta a écrit : On 11/12/12 14:57, Abdelrazak Younes wrote: Ah... a flameware just in time before Christmas! :-P [...] And of course we should get rid of frontend/* (not qt4) and use signal/slot connection for communication with the core (src/). I see, it seems we opened a "Pandora" box here. Well, if any Xmas presents come out of it, then it's not too bad :-). However, so far, it seems only a lot of work with likely disruption of the compilation/makefile functionality :-)... for weeks :-) perhaps months, as anything will be deferred to the new year OTOH, if we want to do something like that, just before a major version is the right time, since it ensures that the devel tree and the master tree are not too far off. JMarc
Re: Where to use qt4 (Re: Export-to fails for xhtml)
On 11/12/12 14:57, Abdelrazak Younes wrote: > Ah... a flameware just in time before Christmas! :-P [...] > And of course we should get rid of frontend/* (not qt4) and use signal/slot > connection for communication with the core (src/). I see, it seems we opened a "Pandora" box here. Well, if any Xmas presents come out of it, then it's not too bad :-). However, so far, it seems only a lot of work with likely disruption of the compilation/makefile functionality :-)... for weeks :-) perhaps months, as anything will be deferred to the new year Btw, as we're at it, happy Xmas to everybody T.
Re: Where to use qt4 (Re: Export-to fails for xhtml)
On Tue, Dec 11, 2012 at 3:57 PM, Abdelrazak Younes wrote: > > A while ago, I proposed a flatter directory structure, I will look for it. > Here is it: src/lyx/ : basically one C++ file with main() using the other libraries below or not src/boost/ : to be removed later when we get rid of boost. src/intl/ src/core/ : everything that is now in src/. Some of that may go in new src/export/ and src/import/ directories. src/gui/ : everything that is now in src/frontents/ src/frontents/qt4 src/frontents/qt4/ui src/graphics/ (mostly) src/support/ : same as now src/insets/ : same as now plus a bit of what is now in src/graphics src/mathed/ : same as now src/tex2lyx/ : same as now. Most of that may go in new src/import/ directory . src/client/ : same as now This way we would have one directory per program or library. Abdel.
Re: Where to use qt4 (Re: Export-to fails for xhtml)
Ah... a flameware just in time before Christmas! :-P On Tue, Dec 11, 2012 at 1:09 PM, Pavel Sanda wrote: > Tommaso Cucinotta wrote: > > Yes, everything compiles fine. Also ColorCache.h was not giving any > trouble, till I included it in graphics/PreviewLoader.cpp, because then gcc > > complained it cannot find QColor nor QPalette (and I had to add the > QtGui/). > > Yes I understand the issue now. Qt4 creeping out of qt4/ directory. > I don't have strong opinion since we already crossed the line in server > and compare feature. But other may have some comments as well, it's not > just > technical issue (shall we get rid of frontend/qt4 structure?) > A while ago, I proposed a flatter directory structure, I will look for it. the graphics namespace is really an artefact of the past, it should be completely merged in the frontend code. And of course we should get rid of frontend/* (not qt4) and use signal/slot connection for communication with the core (src/). Abdel > Pavel >
