Re: lyxeditor not executable when installed with cmake

2019-11-27 Thread Kornel Benko
Am Tue, 26 Nov 2019 20:34:47 -0500
schrieb Richard Kimberly Heck :

> On 11/26/19 3:04 PM, Kornel Benko wrote:
> > Am Tue, 26 Nov 2019 20:57:22 +0100
> > schrieb Kornel Benko :
> >  
> >> Am Tue, 26 Nov 2019 19:52:15 +0100
> >> schrieb pdv :
> >>  
> >>> When installing with the latest CMake on MacOS the lyxeditor, inkscape 
> >>> and maxima files, copied into the bundle, are not longer executable. 
> >>> This is in particular a nuisance for the "reverse search" feature which 
> >>> calls lyxeditor.
> >>>
> >>> In the "install(FILES ...)" command (in development/cmake/install.cmake) 
> >>> the PERMISSIONS should be mentioned explicitly. See enclosed patch.
> >>>
> >>> Patrick
> >> Looks good. Will do it for master. Candidate for branch.
> >>
> >>Kornel  
> > Too fast. What about
> > install(PROGRAMS ...)
> > instead of 'install(FILES ...)?  
> 
> Feel free to fix this in stable when you know exactly how to do it.
> 
> Riki
> 
> 

Done at 87672a1d.

Kornel


pgpJntJSZdi2k.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: lyxeditor not executable when installed with cmake

2019-11-27 Thread Kornel Benko
Am Wed, 27 Nov 2019 14:49:56 +0100
schrieb pdv :

> On 26/11/2019 21:04, Kornel Benko wrote:
> > Am Tue, 26 Nov 2019 20:57:22 +0100
> > schrieb Kornel Benko :
> >   
> >> Am Tue, 26 Nov 2019 19:52:15 +0100
> >> schrieb pdv :
> >>  
> >>> When installing with the latest CMake on MacOS the lyxeditor, inkscape
> >>> and maxima files, copied into the bundle, are not longer executable.
> >>> This is in particular a nuisance for the "reverse search" feature which
> >>> calls lyxeditor.
> >>>
> >>> In the "install(FILES ...)" command (in development/cmake/install.cmake)
> >>> the PERMISSIONS should be mentioned explicitly. See enclosed patch.
> >>>
> >>> Patrick  
> >>
> >> Looks good. Will do it for master. Candidate for branch.
> >>
> >>Kornel  
> > 
> > Too fast. What about
> > install(PROGRAMS ...)
> > instead of 'install(FILES ...)?
> > 
> > Kornel
> > 
> >   
> Agreed, that's shorter.
> 
> Patrick
> 


Good, it's in (58ed976d) now.

Kornel


pgpxTNdaDF0Wc.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: lyxeditor not executable when installed with cmake

2019-11-27 Thread pdv

On 26/11/2019 21:04, Kornel Benko wrote:

Am Tue, 26 Nov 2019 20:57:22 +0100
schrieb Kornel Benko :


Am Tue, 26 Nov 2019 19:52:15 +0100
schrieb pdv :


When installing with the latest CMake on MacOS the lyxeditor, inkscape
and maxima files, copied into the bundle, are not longer executable.
This is in particular a nuisance for the "reverse search" feature which
calls lyxeditor.

In the "install(FILES ...)" command (in development/cmake/install.cmake)
the PERMISSIONS should be mentioned explicitly. See enclosed patch.

Patrick


Looks good. Will do it for master. Candidate for branch.

Kornel


Too fast. What about
install(PROGRAMS ...)
instead of 'install(FILES ...)?

Kornel



Agreed, that's shorter.

Patrick

--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: lyxeditor not executable when installed with cmake

2019-11-26 Thread Richard Kimberly Heck
On 11/26/19 3:04 PM, Kornel Benko wrote:
> Am Tue, 26 Nov 2019 20:57:22 +0100
> schrieb Kornel Benko :
>
>> Am Tue, 26 Nov 2019 19:52:15 +0100
>> schrieb pdv :
>>
>>> When installing with the latest CMake on MacOS the lyxeditor, inkscape 
>>> and maxima files, copied into the bundle, are not longer executable. 
>>> This is in particular a nuisance for the "reverse search" feature which 
>>> calls lyxeditor.
>>>
>>> In the "install(FILES ...)" command (in development/cmake/install.cmake) 
>>> the PERMISSIONS should be mentioned explicitly. See enclosed patch.
>>>
>>> Patrick  
>> Looks good. Will do it for master. Candidate for branch.
>>
>>  Kornel
> Too fast. What about
>   install(PROGRAMS ...)
> instead of 'install(FILES ...)?

Feel free to fix this in stable when you know exactly how to do it.

Riki


-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: lyxeditor not executable when installed with cmake

2019-11-26 Thread Kornel Benko
Am Tue, 26 Nov 2019 20:57:22 +0100
schrieb Kornel Benko :

> Am Tue, 26 Nov 2019 19:52:15 +0100
> schrieb pdv :
> 
> > When installing with the latest CMake on MacOS the lyxeditor, inkscape 
> > and maxima files, copied into the bundle, are not longer executable. 
> > This is in particular a nuisance for the "reverse search" feature which 
> > calls lyxeditor.
> > 
> > In the "install(FILES ...)" command (in development/cmake/install.cmake) 
> > the PERMISSIONS should be mentioned explicitly. See enclosed patch.
> > 
> > Patrick  
> 
> Looks good. Will do it for master. Candidate for branch.
> 
>   Kornel

Too fast. What about
install(PROGRAMS ...)
instead of 'install(FILES ...)?

Kornel


pgpsRelOmMDIn.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: lyxeditor not executable when installed with cmake

2019-11-26 Thread Kornel Benko
Am Tue, 26 Nov 2019 19:52:15 +0100
schrieb pdv :

> When installing with the latest CMake on MacOS the lyxeditor, inkscape 
> and maxima files, copied into the bundle, are not longer executable. 
> This is in particular a nuisance for the "reverse search" feature which 
> calls lyxeditor.
> 
> In the "install(FILES ...)" command (in development/cmake/install.cmake) 
> the PERMISSIONS should be mentioned explicitly. See enclosed patch.
> 
> Patrick

Looks good. Will do it for master. Candidate for branch.

Kornel


pgp4tdrm5DjNR.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel