Re: Trivial patch review request
On Thu, Aug 15, 2019 at 07:26:44AM -0600, Joel Kulesza wrote: > On Wed, Aug 14, 2019 at 5:35 PM Scott Kostyshak wrote: > > > On Wed, Aug 14, 2019 at 12:10:46PM -0600, Joel Kulesza wrote: > > > > > Hopefully my activity in the credits > > > isn't seen as too vain. > > > > Not at all. I hope my attempt at humor wasn't what made you think that. > > Whenever I attempt to make a joke I get myself into trouble. > > > No offense whatsoever. Good to know! > I had just hoped to submit something simple to be > minimum effort, but having done so incorrectly required outsize effort to > fix. All in the name of making sure my vanity is preserved, and typo free. > > Nevertheless, I appreciate the work that all the development team members > put in (even on these little issues)—it truly makes the writing required > for my work easier and more pleasant than otherwise. Thank you for all of your help and contributions! Scott signature.asc Description: PGP signature
Re: Trivial patch review request
On Wed, Aug 14, 2019 at 5:35 PM Scott Kostyshak wrote: > On Wed, Aug 14, 2019 at 12:10:46PM -0600, Joel Kulesza wrote: > > > Hopefully my activity in the credits > > isn't seen as too vain. > > Not at all. I hope my attempt at humor wasn't what made you think that. > Whenever I attempt to make a joke I get myself into trouble. No offense whatsoever. I had just hoped to submit something simple to be minimum effort, but having done so incorrectly required outsize effort to fix. All in the name of making sure my vanity is preserved, and typo free. Nevertheless, I appreciate the work that all the development team members put in (even on these little issues)—it truly makes the writing required for my work easier and more pleasant than otherwise. Thanks again, Joel
Re: Trivial patch review request
On Wed, Aug 14, 2019 at 07:32:45PM -0400, Scott Kostyshak wrote: > On Wed, Aug 14, 2019 at 12:14:02PM -0600, Joel Kulesza wrote: > > > Sorry for the quick follow-up, but Riki alerted me offline that the CREDITS > > file is generated from generate_contributors.py so this fix (and the others > > I see you just made) are needed there. > > Ah good to know. I just ported the changes to the source file at > 792f4282. Hopefully f11e9adf will prevent others (most notably my future self) from making the same mistake. Scott signature.asc Description: PGP signature
Re: Trivial patch review request
On Wed, Aug 14, 2019 at 12:10:46PM -0600, Joel Kulesza wrote: > Riki took care of this not long after I'd sent it, so I think we're good > but I appreciate you following up! Ah good to know. > Hopefully my activity in the credits > isn't seen as too vain. Not at all. I hope my attempt at humor wasn't what made you think that. Whenever I attempt to make a joke I get myself into trouble. > Also, I assume that with your increased activity on the list of late that > mom, baby, and dad are all doing well? I hope so! Everyone is doing well! Scott signature.asc Description: PGP signature
Re: Trivial patch review request
On Wed, Aug 14, 2019 at 12:14:02PM -0600, Joel Kulesza wrote: > Sorry for the quick follow-up, but Riki alerted me offline that the CREDITS > file is generated from generate_contributors.py so this fix (and the others > I see you just made) are needed there. Ah good to know. I just ported the changes to the source file at 792f4282. > Sorry for submitting a bogus patch that causes you rework. No problem at all! Scott signature.asc Description: PGP signature
Re: Trivial patch review request
On Wed, Aug 14, 2019 at 12:10 PM Joel Kulesza wrote: > On Wed, Aug 14, 2019 at 11:08 AM Scott Kostyshak wrote: > >> On Wed, Jul 24, 2019 at 09:10:00PM -0600, Joel Kulesza wrote: >> > LyX Developers, >> > >> > Can someone please review/incorporate the attached, trivial, patch, >> which >> > corrects a typo in the credits? >> > >> > Please let me know if a tracker issue is warranted. >> > >> > Otherwise, please contact me with any comments, questions, or concerns. >> >> Sorry this took so long, Joel. I don't remember if I missed your message >> or if I was just feeling lazy. >> >> It's in master at 29b725af. CC Riki if you want this to go to stable so >> that you don't have to wait until 2.4.0 for the SPAM bots to pick up the >> correction :) >> >> Scott >> > > Scott, > > Riki took care of this not long after I'd sent it, so I think we're good > but I appreciate you following up! Hopefully my activity in the credits > isn't seen as too vain. > > Also, I assume that with your increased activity on the list of late that > mom, baby, and dad are all doing well? I hope so! > > Thanks again, > Joel > Scott, Sorry for the quick follow-up, but Riki alerted me offline that the CREDITS file is generated from generate_contributors.py so this fix (and the others I see you just made) are needed there. Sorry for submitting a bogus patch that causes you rework. - Joel
Re: Trivial patch review request
On Wed, Aug 14, 2019 at 11:08 AM Scott Kostyshak wrote: > On Wed, Jul 24, 2019 at 09:10:00PM -0600, Joel Kulesza wrote: > > LyX Developers, > > > > Can someone please review/incorporate the attached, trivial, patch, which > > corrects a typo in the credits? > > > > Please let me know if a tracker issue is warranted. > > > > Otherwise, please contact me with any comments, questions, or concerns. > > Sorry this took so long, Joel. I don't remember if I missed your message > or if I was just feeling lazy. > > It's in master at 29b725af. CC Riki if you want this to go to stable so > that you don't have to wait until 2.4.0 for the SPAM bots to pick up the > correction :) > > Scott > Scott, Riki took care of this not long after I'd sent it, so I think we're good but I appreciate you following up! Hopefully my activity in the credits isn't seen as too vain. Also, I assume that with your increased activity on the list of late that mom, baby, and dad are all doing well? I hope so! Thanks again, Joel
Re: Trivial patch review request
On Wed, Jul 24, 2019 at 09:10:00PM -0600, Joel Kulesza wrote: > LyX Developers, > > Can someone please review/incorporate the attached, trivial, patch, which > corrects a typo in the credits? > > Please let me know if a tracker issue is warranted. > > Otherwise, please contact me with any comments, questions, or concerns. Sorry this took so long, Joel. I don't remember if I missed your message or if I was just feeling lazy. It's in master at 29b725af. CC Riki if you want this to go to stable so that you don't have to wait until 2.4.0 for the SPAM bots to pick up the correction :) Scott signature.asc Description: PGP signature
Trivial patch review request
LyX Developers, Can someone please review/incorporate the attached, trivial, patch, which corrects a typo in the credits? Please let me know if a tracker issue is warranted. Otherwise, please contact me with any comments, questions, or concerns. Thank you, Joel 0001-Correct-typo-in-contributor-email-address.patch Description: Binary data
