Re: cmake compilation error
Am Sonntag, 12. März 2017 um 19:52:57, schrieb Guillaume Munch > Le 12/03/2017 à 16:51, Kornel Benko a écrit : > > > > Should we emit a warning (which probably will be ignored) or better refuse > > to build > > with "5.0" <= QT < "5.4" ? > > I don't think so, the indication INSTALL file should be enough in that case. > > > > > From my POV, if user selects QT5, we should use it. > > > > Agreed. In addition, from my POV, it is better if Qt5 for big enough > values of 5 are selected as default, so that one does not have to select > it explicitly. > I have problems with this approach. So for instance if I prepare the OS environments (like PATH, ldconfig values etc) for QT4, cmake only finds QT4. We would have to provide info about valid paths for 'qmake' (platform and user dependent). The complications are not worth the struggle to make it right. Kornel signature.asc Description: This is a digitally signed message part.
Re: cmake compilation error
Le 12/03/2017 à 16:51, Kornel Benko a écrit : Should we emit a warning (which probably will be ignored) or better refuse to build with "5.0" <= QT < "5.4" ? I don't think so, the indication INSTALL file should be enough in that case. From my POV, if user selects QT5, we should use it. Agreed. In addition, from my POV, it is better if Qt5 for big enough values of 5 are selected as default, so that one does not have to select it explicitly.
Re: cmake compilation error
Am Samstag, 11. März 2017 um 22:23:22, schrieb Guillaume Munch > Le 11/03/2017 à 18:07, Jean-Pierre Chrétien a écrit : > > Le 11/03/2017 à 17:57, Kornel Benko a écrit : > > > >> I see the same with installed QT5.2.1. But no problems with QT5.7. > > > > Seems that I've got 5.3.2 here, Debian Jessie (up to date stable). > > Indeed the function is introduced in qt5.4. It is now fixed. Note that > from what I remember, LyX suffers various bugs with early releases of > qt5, which is why the release notes strongly advises qt>=5.4. CMake > should select qt4.8 over qt5.3 when possible. > > Guillaume Even if user _selects_ QT5? (default is QT4). Should we emit a warning (which probably will be ignored) or better refuse to build with "5.0" <= QT < "5.4" ? From my POV, if user selects QT5, we should use it. Kornel signature.asc Description: This is a digitally signed message part.
Re: cmake compilation error
Le 11/03/2017 à 18:07, Jean-Pierre Chrétien a écrit : Le 11/03/2017 à 17:57, Kornel Benko a écrit : I see the same with installed QT5.2.1. But no problems with QT5.7. Seems that I've got 5.3.2 here, Debian Jessie (up to date stable). Indeed the function is introduced in qt5.4. It is now fixed. Note that from what I remember, LyX suffers various bugs with early releases of qt5, which is why the release notes strongly advises qt>=5.4. CMake should select qt4.8 over qt5.3 when possible. Guillaume
Re: cmake compilation error
Le 11/03/2017 à 17:57, Kornel Benko a écrit : I see the same with installed QT5.2.1. But no problems with QT5.7. Seems that I've got 5.3.2 here, Debian Jessie (up to date stable). -- Jean-Pierre
Re: cmake compilation error
Am Samstag, 11. März 2017 um 17:43:54, schrieb Jean-Pierre Chrétien > Hello, > > I get this with a clean build of up-to-date master: > > /ext/lyx/master/src/support/FileMonitor.cpp: In member function ‘void > lyx::support::FileMonitorGuard::refresh(bool)’: > /ext/lyx/master/src/support/FileMonitor.cpp:115:6: error: no matching > function > for call to ‘QTimer::singleShot(int, lyx::support::FileMonitorGuard*, > lyx::support::FileMonitorGuard::refresh(bool)::)’ > }); >^ I see the same with installed QT5.2.1. But no problems with QT5.7. Kornel signature.asc Description: This is a digitally signed message part.
cmake compilation error
Hello, I get this with a clean build of up-to-date master: /ext/lyx/master/src/support/FileMonitor.cpp: In member function ‘void lyx::support::FileMonitorGuard::refresh(bool)’: /ext/lyx/master/src/support/FileMonitor.cpp:115:6: error: no matching function for call to ‘QTimer::singleShot(int, lyx::support::FileMonitorGuard*, lyx::support::FileMonitorGuard::refresh(bool)::)’ }); ^ /ext/lyx/master/src/support/FileMonitor.cpp:115:6: note: candidates are: In file included from /usr/include/x86_64-linux-gnu/qt5/QtCore/QTimer:1:0, from /ext/lyx/master/src/support/FileMonitor.cpp:22: /usr/include/x86_64-linux-gnu/qt5/QtCore/qtimer.h:81:17: note: static void QTimer::singleShot(int, const QObject*, const char*) static void singleShot(int msec, const QObject *receiver, const char *member); ^ /usr/include/x86_64-linux-gnu/qt5/QtCore/qtimer.h:81:17: note: no known conversion for argument 3 from ‘lyx::support::FileMonitorGuard::refresh(bool)::’ to ‘const char*’ /usr/include/x86_64-linux-gnu/qt5/QtCore/qtimer.h:82:17: note: static void QTimer::singleShot(int, Qt::TimerType, const QObject*, const char*) static void singleShot(int msec, Qt::TimerType timerType, const QObject *receiver, const char *member); ^ /usr/include/x86_64-linux-gnu/qt5/QtCore/qtimer.h:82:17: note: candidate expects 4 arguments, 3 provided src/support/CMakeFiles/support.dir/build.make:557: recipe for target 'src/support/CMakeFiles/support.dir/FileMonitor.cpp.o' failed -- Jean-Pierre
Re: Cmake compilation error
On 04/07/2010 06:19 PM, Kornel Benko wrote: Am Mittwoch 07 April 2010 schrieb José Matos: On Wednesday 07 April 2010 15:23:18 Kornel Benko wrote: Corrected and commited already. Sorry for not being responsive, but I broke my right arm, and it is somehow not easy to use a computer. Kornel I hope you have a fast recovery. :-) FWIW there is no need to reply. :-) Best regards, Thanks to all. It is now 8 days from the surgery, things are getting better. Courage Kornel! Abdel.
Re: Cmake compilation error
Am Mittwoch 07 April 2010 schrieb José Matos: > On Wednesday 07 April 2010 15:23:18 Kornel Benko wrote: > > Corrected and commited already. > > Sorry for not being responsive, but I broke my right arm, and it is > > somehow not easy to use a computer. > > > > Kornel > > I hope you have a fast recovery. :-) > > FWIW there is no need to reply. :-) > > Best regards, > Thanks to all. It is now 8 days from the surgery, things are getting better. Kornel signature.asc Description: This is a digitally signed message part.
Re: Cmake compilation error
On 04/07/2010 10:23 AM, Kornel Benko wrote: Sorry for not being responsive, but I broke my right arm, and it is somehow not easy to use a computer. Sorry to hear that! rh
Re: Cmake compilation error
Am Mittwoch 07 April 2010 schrieb BH: > On Tue, Apr 6, 2010 at 10:29 PM, rgheck wrote: > I'm guessing this is some Windows, or possibly cmake, thing. This is a > macro defined in config.h, and it should be available. > >>> > >>> Indeed: SCons compiles while CMake doesn't. > >> > >> It's not just Windows -- I have the same problem with cmake on Mac. > > > > OK, so it's some cmake issue. Can someone help us with this? > > I just tried make clean ... make, and it compiled fine for me now. > (cmake on Mac) > > BH > Corrected and commited already. Sorry for not being responsive, but I broke my right arm, and it is somehow not easy to use a computer. Kornel signature.asc Description: This is a digitally signed message part.
Re: Cmake compilation error
On Tue, Apr 6, 2010 at 10:29 PM, rgheck wrote: I'm guessing this is some Windows, or possibly cmake, thing. This is a macro defined in config.h, and it should be available. >>> >>> Indeed: SCons compiles while CMake doesn't. >>> >> >> It's not just Windows -- I have the same problem with cmake on Mac. >> >> > > OK, so it's some cmake issue. Can someone help us with this? I just tried make clean ... make, and it compiled fine for me now. (cmake on Mac) BH
Cmake compilation error
On 04/06/2010 08:02 PM, BH wrote: On Mon, Apr 5, 2010 at 8:46 PM, Uwe Stöhr wrote: Am 06.04.2010 02:23, schrieb Richard Heck: since r34059 I cannot compile LyX: ..\..\src\Buffer.cpp(1571) : error C2065: 'PACKAGE_STRING' : undeclared identifier I'm guessing this is some Windows, or possibly cmake, thing. This is a macro defined in config.h, and it should be available. Indeed: SCons compiles while CMake doesn't. It's not just Windows -- I have the same problem with cmake on Mac. OK, so it's some cmake issue. Can someone help us with this? rh
Re: Branch-cmake-compilation error
Peter Kümmel wrote: > Yes, this is missing in the 1.5 branch, please check it in. Done. Jürgen
Re: Branch-cmake-compilation error
Kornel Benko wrote: I had to modify "development/cmake/config.h.cmake" in order to get it compile. Kornel Yes, this is missing in the 1.5 branch, please check it in. Peter
Branch-cmake-compilation error
I had to modify "development/cmake/config.h.cmake" in order to get it compile.
Kornel
--
Kornel Benko
[EMAIL PROTECTED]
Index: development/cmake/config.h.cmake
===
--- development/cmake/config.h.cmake (Revision 22011)
+++ development/cmake/config.h.cmake (Arbeitskopie)
@@ -112,7 +112,7 @@
#endif
#cmakedefine PACKAGE "${PACKAGE}"
-#cmakedefine PACKAGE_VERSION ${PACKAGE_VERSION}
+#cmakedefine PACKAGE_VERSION "${PACKAGE_VERSION}"
#cmakedefine USE_POSIX_PACKAGING 1
#cmakedefine USE_WINDOWS_PACKAGING 1
pgpySA4zsAAlF.pgp
Description: PGP signature
