RE: Re: drawing of selection in tabulars
I'm specializing in one-liners lately ;-) good work! OK? yes
Re: drawing of selection in tabulars
Stefan Schimanski wrote: Looks good. While you are at it, can you take care of 80 columns per line? That one is more than 150... Done. A/
RE: Re: drawing of selection in tabulars
> I'm specializing in one-liners lately ;-) good work! > OK? yes
Re: drawing of selection in tabulars
Stefan Schimanski wrote: > Looks good. While you are at it, can you take care of 80 columns per > line? That one is more than 150... Done. A/
drawing of selection in tabulars
is a couple of pixels off. see attached... inline: sel1.pnginline: sel2.png
Re: drawing of selection in tabulars
Edwin Leuven wrote:
is a couple of pixels off.
see attached...
I'm specializing in one-liners lately ;-)
OK?
A/
Index: src/insets/InsetTabular.cpp
===
--- src/insets/InsetTabular.cpp (revision 18873)
+++ src/insets/InsetTabular.cpp (working copy)
@@ -3096,7 +3096,7 @@
}
} else {
- cur.text()-drawSelection(pi, x + getCellXPos(cur.idx()) + tabular.getBeginningOfTextInCell(cur.idx()), 0 /*this value is ignored */);
+ cell(cur.idx())-drawSelection(pi, x + getCellXPos(cur.idx()) + tabular.getBeginningOfTextInCell(cur.idx()), 0 /*this value is ignored */);
}
}
@@ -3969,11 +3969,11 @@
for (; !tabular.isFirstCellInRow(c); --c)
;
- int lx = tabular.getWidthOfColumn(cell);
+ int lx = 0;
for (; c cell; ++c)
lx += tabular.getWidthOfColumn(c);
- return lx - tabular.getWidthOfColumn(cell);
+ return lx;
}
Re: drawing of selection in tabulars
Looks good. While you are at it, can you take care of 80 columns per line? That one is more than 150... Stefan Am 24.06.2007 um 23:16 schrieb Alfredo Braunstein: Edwin Leuven wrote: is a couple of pixels off. see attached... I'm specializing in one-liners lately ;-) OK? A/ tabular.diff PGP.sig Description: Signierter Teil der Nachricht
drawing of selection in tabulars
is a couple of pixels off. see attached... <><>
Re: drawing of selection in tabulars
Edwin Leuven wrote:
> is a couple of pixels off.
>
> see attached...
I'm specializing in one-liners lately ;-)
OK?
A/
Index: src/insets/InsetTabular.cpp
===
--- src/insets/InsetTabular.cpp (revision 18873)
+++ src/insets/InsetTabular.cpp (working copy)
@@ -3096,7 +3096,7 @@
}
} else {
- cur.text()->drawSelection(pi, x + getCellXPos(cur.idx()) + tabular.getBeginningOfTextInCell(cur.idx()), 0 /*this value is ignored */);
+ cell(cur.idx())->drawSelection(pi, x + getCellXPos(cur.idx()) + tabular.getBeginningOfTextInCell(cur.idx()), 0 /*this value is ignored */);
}
}
@@ -3969,11 +3969,11 @@
for (; !tabular.isFirstCellInRow(c); --c)
;
- int lx = tabular.getWidthOfColumn(cell);
+ int lx = 0;
for (; c < cell; ++c)
lx += tabular.getWidthOfColumn(c);
- return lx - tabular.getWidthOfColumn(cell);
+ return lx;
}
Re: drawing of selection in tabulars
Looks good. While you are at it, can you take care of 80 columns per line? That one is more than 150... Stefan Am 24.06.2007 um 23:16 schrieb Alfredo Braunstein: Edwin Leuven wrote: is a couple of pixels off. see attached... I'm specializing in one-liners lately ;-) OK? A/ PGP.sig Description: Signierter Teil der Nachricht
