Re: r37705 - lyx-devel/trunk/src/insets
On Thu, Feb 17, 2011 at 12:25:54AM +0100, Vincent van Ravesteijn wrote: > Op 17-2-2011 0:23, Enrico Forestieri schreef: > >On Thu, Feb 17, 2011 at 12:22:48AM +0100, Vincent van Ravesteijn wrote: > >> Op 17-2-2011 0:22, Enrico Forestieri schreef: > >>>On Thu, Feb 17, 2011 at 12:06:43AM +0100, v...@lyx.org wrote: > Author: vfr > Date: Thu Feb 17 00:06:43 2011 > New Revision: 37705 > URL: http://www.lyx.org/trac/changeset/37705 > > Log: > Revert r37704. It enabled SET_TABULAR_WIDTH for all longtables (new fix > coming soon) > >>>This patch was working fine. I don't understand why you are doing this > >>>without discussing it with me. > >>> > >>Because it's wrong. > >You are wrong. > > > I'm not. Childish. -- Enrico
Re: r37705 - lyx-devel/trunk/src/insets
Op 17-2-2011 0:23, Enrico Forestieri schreef: On Thu, Feb 17, 2011 at 12:22:48AM +0100, Vincent van Ravesteijn wrote: Op 17-2-2011 0:22, Enrico Forestieri schreef: On Thu, Feb 17, 2011 at 12:06:43AM +0100, v...@lyx.org wrote: Author: vfr Date: Thu Feb 17 00:06:43 2011 New Revision: 37705 URL: http://www.lyx.org/trac/changeset/37705 Log: Revert r37704. It enabled SET_TABULAR_WIDTH for all longtables (new fix coming soon) This patch was working fine. I don't understand why you are doing this without discussing it with me. Because it's wrong. You are wrong. I'm not. Vincent
Re: r37705 - lyx-devel/trunk/src/insets
On Thu, Feb 17, 2011 at 12:22:48AM +0100, Vincent van Ravesteijn wrote: > Op 17-2-2011 0:22, Enrico Forestieri schreef: > >On Thu, Feb 17, 2011 at 12:06:43AM +0100, v...@lyx.org wrote: > >>Author: vfr > >>Date: Thu Feb 17 00:06:43 2011 > >>New Revision: 37705 > >>URL: http://www.lyx.org/trac/changeset/37705 > >> > >>Log: > >>Revert r37704. It enabled SET_TABULAR_WIDTH for all longtables (new fix > >>coming soon) > > > >This patch was working fine. I don't understand why you are doing this > >without discussing it with me. > > > Because it's wrong. You are wrong. -- Enrico
Re: r37705 - lyx-devel/trunk/src/insets
Op 17-2-2011 0:22, Enrico Forestieri schreef: On Thu, Feb 17, 2011 at 12:06:43AM +0100, v...@lyx.org wrote: Author: vfr Date: Thu Feb 17 00:06:43 2011 New Revision: 37705 URL: http://www.lyx.org/trac/changeset/37705 Log: Revert r37704. It enabled SET_TABULAR_WIDTH for all longtables (new fix coming soon) This patch was working fine. I don't understand why you are doing this without discussing it with me. Because it's wrong. Vincent
Re: r37705 - lyx-devel/trunk/src/insets
On Thu, Feb 17, 2011 at 12:06:43AM +0100, v...@lyx.org wrote: > Author: vfr > Date: Thu Feb 17 00:06:43 2011 > New Revision: 37705 > URL: http://www.lyx.org/trac/changeset/37705 > > Log: > Revert r37704. It enabled SET_TABULAR_WIDTH for all longtables (new fix > coming soon) This patch was working fine. I don't understand why you are doing this without discussing it with me. > Modified: >lyx-devel/trunk/src/insets/InsetTabular.cpp > > Modified: lyx-devel/trunk/src/insets/InsetTabular.cpp > == > --- lyx-devel/trunk/src/insets/InsetTabular.cpp Wed Feb 16 23:19:49 > 2011(r37704) > +++ lyx-devel/trunk/src/insets/InsetTabular.cpp Thu Feb 17 00:06:43 > 2011(r37705) > @@ -4323,10 +4323,8 @@ > return true; > > case Tabular::SET_TABULAR_WIDTH: > - status.setEnabled(tabular.tabular_width.zero() > - || (!tabular.rotate && !tabular.is_long_tabular > - && tabular.tabular_valignment == > - Tabular::LYX_VALIGN_MIDDLE)); > + status.setEnabled(!tabular.rotate && > !tabular.is_long_tabular > + && tabular.tabular_valignment == > Tabular::LYX_VALIGN_MIDDLE); > break; > > case Tabular::SET_DECIMAL_POINT: -- Enrico
