Re: r40348 - lyx-devel/trunk/src/insets

2013-05-26 Thread Julien Rioux 
On Sun, Dec 4, 2011 at 5:24 PM, Richard Heck  wrote:

> On 12/04/2011 04:27 PM, Julien Rioux wrote:
> > On Sat, Dec 3, 2011 at 10:16 PM, Richard Heck  > > wrote:
> >
> > On 12/03/2011 05:24 PM, jri...@lyx.org 
> wrote:
> > > Author: jrioux
> > > Date: Sat Dec  3 23:24:38 2011
> > > New Revision: 40348
> > > URL: http://www.lyx.org/trac/changeset/40348
> > >
> > > Log:
> > > Show insets as text in the formatted bibliography entry.
> > >
> > Probably also for branch? That said, can you tell me what the
> > issue was
> > here?
> >
> > Richard
> >
> >
> > The issue was, if you have an inset within a bibitem (an hyperlink
> > would be common), the content of this inset was dropped from the
> > biblio info. So in the Citation GUI, it would look like the citation
> > was incomplete, some part of it was simply dropped.
> >
> > I noticed this from the file example/FeynmanDiagrams.lyx. Before this
> > commit you had in the citation GUI
> > "of the LaTeX-package feyn"
> > and now:
> > "[http link||Documentation] of the LaTeX-package feyn"
> >
> OK, good for branch, then.
>
> Richard
>
>
Finally in, at 3e5c9e51.
--
Julien

Re: r40348 - lyx-devel/trunk/src/insets

2011-12-04 Thread Richard Heck 
On 12/04/2011 04:27 PM, Julien Rioux wrote:
> On Sat, Dec 3, 2011 at 10:16 PM, Richard Heck  > wrote:
>
> On 12/03/2011 05:24 PM, jri...@lyx.org  wrote:
> > Author: jrioux
> > Date: Sat Dec  3 23:24:38 2011
> > New Revision: 40348
> > URL: http://www.lyx.org/trac/changeset/40348
> >
> > Log:
> > Show insets as text in the formatted bibliography entry.
> >
> Probably also for branch? That said, can you tell me what the
> issue was
> here?
>
> Richard
>
>
> The issue was, if you have an inset within a bibitem (an hyperlink
> would be common), the content of this inset was dropped from the
> biblio info. So in the Citation GUI, it would look like the citation
> was incomplete, some part of it was simply dropped.
>
> I noticed this from the file example/FeynmanDiagrams.lyx. Before this
> commit you had in the citation GUI
> "of the LaTeX-package feyn"
> and now:
> "[http link||Documentation] of the LaTeX-package feyn"
>
OK, good for branch, then.

Richard

Re: r40348 - lyx-devel/trunk/src/insets

2011-12-04 Thread Julien Rioux 
On Sat, Dec 3, 2011 at 10:16 PM, Richard Heck  wrote:

> On 12/03/2011 05:24 PM, jri...@lyx.org wrote:
> > Author: jrioux
> > Date: Sat Dec  3 23:24:38 2011
> > New Revision: 40348
> > URL: http://www.lyx.org/trac/changeset/40348
> >
> > Log:
> > Show insets as text in the formatted bibliography entry.
> >
> Probably also for branch? That said, can you tell me what the issue was
> here?
>
> Richard
>
>
The issue was, if you have an inset within a bibitem (an hyperlink would be
common), the content of this inset was dropped from the biblio info. So in
the Citation GUI, it would look like the citation was incomplete, some part
of it was simply dropped.

I noticed this from the file example/FeynmanDiagrams.lyx. Before this
commit you had in the citation GUI
"of the LaTeX-package feyn"
and now:
"[http link||Documentation] of the LaTeX-package feyn"

Cheers,
Julien

Re: r40348 - lyx-devel/trunk/src/insets

2011-12-03 Thread Richard Heck 
On 12/03/2011 05:24 PM, jri...@lyx.org wrote:
> Author: jrioux
> Date: Sat Dec  3 23:24:38 2011
> New Revision: 40348
> URL: http://www.lyx.org/trac/changeset/40348
>
> Log:
> Show insets as text in the formatted bibliography entry.
>
Probably also for branch? That said, can you tell me what the issue was
here?

Richard

> Modified:
>lyx-devel/trunk/src/insets/InsetBibitem.cpp
>
> Modified: lyx-devel/trunk/src/insets/InsetBibitem.cpp
> ==
> --- lyx-devel/trunk/src/insets/InsetBibitem.cpp   Sat Dec  3 23:24:30 
> 2011(r40347)
> +++ lyx-devel/trunk/src/insets/InsetBibitem.cpp   Sat Dec  3 23:24:38 
> 2011(r40348)
> @@ -318,7 +318,8 @@
>   keyvalmap.label(bibLabel());
>   DocIterator doc_it(it);
>   doc_it.forwardPos();
> - keyvalmap[from_ascii("ref")] = doc_it.paragraph().asString();
> + keyvalmap[from_ascii("ref")] = doc_it.paragraph().asString(
> + AS_STR_INSETS | AS_STR_SKIPDELETE);
>   buffer().addBibTeXInfo(key, keyvalmap);
>  }
>