Re: Commented TeX with track changes

2018-12-09 Thread Jean-Marc Lasgouttes

Le 09/12/2018 à 13:53, Daniel Goya a écrit :
thanks Paul, Jean-Marc and Daniel for your replies. Maybe there's not 
much point in reporting it if ERTs are so prone to these kind of issues. 
In fact I think I just found another one, a change-tracked new ERT 
inputing a .tex is not showing the inputed file when compiled with show 
changes (but I haven't built an MWE, it might be something else causing 
the problem)


With ERT, we try to make things right when possible, but basically you 
are on you own :)


JMarc


Re: Commented TeX with track changes

2018-12-09 Thread Daniel Goya
On Thu, 6 Dec 2018 at 19:39, Daniel Goya  wrote:

> Hello everyone,
>
> I just realised that I could not compile a file displaying changes, when
> the change, within a TeX code, includes a %.
>
> I attach an MWE. Sure it doesn't make much sense to try to display
> something commented out, but still, it's useful within LyX to be able to
> see where I added a comment, but if I keep it as "added" with track
> changes, then I can't compile a version displaying all other changes.
>
> Is it just a bug? Has it been reported? (not sure where of how to look for
> it).
>
> Thanks!
>
> Best,
>
> Daniel
>

thanks Paul, Jean-Marc and Daniel for your replies. Maybe there's not much
point in reporting it if ERTs are so prone to these kind of issues. In fact
I think I just found another one, a change-tracked new ERT inputing a .tex
is not showing the inputed file when compiled with show changes (but I
haven't built an MWE, it might be something else causing the problem)

best,

Daniel


Re: Commented TeX with track changes

2018-12-07 Thread Daniel

On 07/12/2018 09:53, Jean-Marc Lasgouttes wrote:

Le 06/12/2018 à 23:39, Daniel Goya a écrit :

Hello everyone,

I just realised that I could not compile a file displaying changes, 
when the change, within a TeX code, includes a %.


This is a bug indeed, but I have no idea how we can solve it. This is a 
general issue with ERT: you can find 100 ways to break documents with it.


The question is whether we can solve it (or even want to try).

JMarc



I guess one drastic way to deal with the problem would be to disallow 
change tracking in ERTs. A less drastic one to show a message when using 
it in ERTs so that the user knows his code might not work as expected.


Daniel



Re: Commented TeX with track changes

2018-12-07 Thread Jean-Marc Lasgouttes

Le 06/12/2018 à 23:39, Daniel Goya a écrit :

Hello everyone,

I just realised that I could not compile a file displaying changes, when 
the change, within a TeX code, includes a %.


This is a bug indeed, but I have no idea how we can solve it. This is a 
general issue with ERT: you can find 100 ways to break documents with it.


The question is whether we can solve it (or even want to try).

JMarc


Re: Commented TeX with track changes

2018-12-06 Thread Paul A. Rubin

On 12/6/18 5:39 PM, Daniel Goya wrote:

Hello everyone,

I just realised that I could not compile a file displaying changes, 
when the change, within a TeX code, includes a %.


I attach an MWE. Sure it doesn't make much sense to try to display 
something commented out, but still, it's useful within LyX to be able 
to see where I added a comment, but if I keep it as "added" with track 
changes, then I can't compile a version displaying all other changes.


Is it just a bug?
I would say so. If you look at the "code" view to see what LaTeX is 
generated, you can see that the percent sign not only makes the 
following text look like it's commented out but also comments out the 
closing brace (}) of the LyX-inserted LaTeX function for which the 
changed text is an argument. So you get a fatal LaTeX syntax error. My 
feeling is that LyX should escape any percent signs in changed content.

Has it been reported? (not sure where of how to look for it).
The place to look would be the bug tracker, which you can find in the 
left margin of the LyX home page (http://lyx.org). Unfortunately, the 
bug tracker does not have advanced search functionality (at least not 
that I can find), so my search attempts either found nothing (which 
might or might not mean it's unreported) or a zillion hits (all 
extraneous as best I could tell). I'd suggest reporting it and let the 
devs decide if it duplicates an existing ticket. If you do report it, 
there's a box to indicate which component of LyX is the offender. I 
think "changes" would be the correct setting there.


Paul