Re: [34368] trunk/dports/games/tuxmath/Portfile

2008-02-22 Thread Ryan Schmidt
You need to bump the port revision too so everyone gets that change.


On Feb 22, 2008, at 10:50, [EMAIL PROTECTED] wrote:

> Revision: 34368
>   http://trac.macosforge.org/projects/macports/changeset/34368
> Author:   [EMAIL PROTECTED]
> Date: 2008-02-22 08:50:30 -0800 (Fri, 22 Feb 2008)
>
> Log Message:
> ---
> games/tuxmath:
> Applying patch from maintainer, closes #14440

[snip]

> +platform darwin  {
> +post-destroot {
> +xinstall -m 755 -d ${destroot}/Applications/MacPorts/ 
> TuxMath.app/Contents/MacOS
> +ln -s ${prefix}/bin/tuxmath ${destroot}/Applications/ 
> MacPorts/TuxMath.app/Contents/MacOS/TuxMath
> +}
> +}

___
macports-dev mailing list
macports-dev@lists.macosforge.org
http://lists.macosforge.org/mailman/listinfo.cgi/macports-dev


Re: [34368] trunk/dports/games/tuxmath/Portfile

2008-02-22 Thread Rainer Müller
Ryan Schmidt wrote:
> You need to bump the port revision too so everyone gets that change.

I thought about that, but was uncertain if just this addition justifies 
a revision increment.

Rainer
___
macports-dev mailing list
macports-dev@lists.macosforge.org
http://lists.macosforge.org/mailman/listinfo.cgi/macports-dev


Re: [34368] trunk/dports/games/tuxmath/Portfile

2008-02-22 Thread Ryan Schmidt

On Feb 22, 2008, at 15:48, Rainer Müller wrote:

> Ryan Schmidt wrote:
>
>> You need to bump the port revision too so everyone gets that change.
>
> I thought about that, but was uncertain if just this addition  
> justifies a revision increment.

If a different set of files ends up on the user's machine, the  
revision must be incremented. Otherwise some users with tuxmath  
1.6.1_0 have one set of files and other users with 1.6.1_0 have a  
different set of files. That's not reliable; that's not reproducible.  
I incremented the port revision in r34385.
___
macports-dev mailing list
macports-dev@lists.macosforge.org
http://lists.macosforge.org/mailman/listinfo.cgi/macports-dev


Re: [34368] trunk/dports/games/tuxmath/Portfile

2008-02-22 Thread Rainer Müller
Ryan Schmidt wrote:
> If a different set of files ends up on the user's machine, the  
> revision must be incremented. Otherwise some users with tuxmath  
> 1.6.1_0 have one set of files and other users with 1.6.1_0 have a  
> different set of files. That's not reliable; that's not reproducible.  
> I incremented the port revision in r34385.

True story. Thanks for your constant review of the commits!

Rainer
___
macports-dev mailing list
macports-dev@lists.macosforge.org
http://lists.macosforge.org/mailman/listinfo.cgi/macports-dev