Re: Open CASCADE Community Edition fetch type

2014-06-14 Thread David Evans
On 6/14/14 6:24 AM, Mark Brethen wrote:
 Open CASCADE is required to build FreeCAD, and since it is a software 
 development platform for 3D surface and solid modeling I thought it deserved 
 its own Portfile.
Yes, it should be a separate port.  While the lines you have written are
not incorrect per se, the preferred approach would be to use the github
PortGroup to do all this (and more) for you more simply.  The equivalent
would then be

PortGroup   github 1.0

github.setuptpaviot oce 0.15 OCE-

Look at
http://svn.macports.org/repository/macports/trunk/dports/_resources/port1.0/group/github-1.0.tcl
to see how this works.

Dave Evans
___
macports-dev mailing list
macports-dev@lists.macosforge.org
https://lists.macosforge.org/mailman/listinfo/macports-dev


Re: Open CASCADE Community Edition fetch type

2014-06-14 Thread Mark Brethen

On Jun 14, 2014, at 9:06 AM, David Evans dev...@macports.org wrote:

 While the lines you have written are
 not incorrect per se, the preferred approach would be to use the github
 PortGroup to do all this (and more) for you more simply. 

This is what I have in the Portfile so far:

# -*- coding: utf-8; mode: tcl; tab-width: 4; indent-tabs-mode: nil; 
c-basic-offset: 4 -*- vim:fenc=utf-8:ft=tcl:et:sw=4:ts=4:sts=4
# $Id$

PortSystem  1.0

PortGroup   github 1.0
github.setuptpaviot oce 0.15 OCE-

categories  graphics
maintainers gmail.com:mark.brethen
description Open CASCADE Community Edition
Long_descriptionOCE is a fork for patches/improvements/experiments\
over OpenCascade.

homepagehttps://github.com/tpaviot/oce

checksums rmd160 be53cced4d5463d466fd17c3f721ae56fb89e32b \
  sha256 
2d7632dda63be06dc79202a025076deb4f1b0d1dede20b68da9536ce184d5ed1

depends_build   port:cmake \
port:ftgl  \
port:freeimage \
port:gl2ps \
Port:tbb

configure {
system cd ${worksrcpath}  cmake ${configure.args} ${worksrcpath};
}

configure.args  \
-DOCE_INSTALL_PREFIX:STRING=#{prefix} \
-DOCE_COPY_HEADERS_BUILD:BOOL=ON \
-DOCE_DRAW:BOOL=ON \
-DOCE_WITH_FREEIMAGE:BOOL=ON \
-DOCE_WITH_GL2PS:BOOL=ON \
-DOCE_MULTITHREAD_LIBRARY:STRING=TBB


The install guide uses install/strip for the install phase, which is not the 
default, but is it necessary?

Thanks,


Mark




___
macports-dev mailing list
macports-dev@lists.macosforge.org
https://lists.macosforge.org/mailman/listinfo/macports-dev


Re: Open CASCADE Community Edition fetch type

2014-06-14 Thread Frank Schima
Hi Mark,


Some observations about this Portfile:

On Jun 14, 2014, at 9:49 AM, Mark Brethen mark.bret...@gmail.com wrote:

 This is what I have in the Portfile so far:
 
 # -*- coding: utf-8; mode: tcl; tab-width: 4; indent-tabs-mode: nil; 
 c-basic-offset: 4 -*- vim:fenc=utf-8:ft=tcl:et:sw=4:ts=4:sts=4
 # $Id$
 
 PortSystem  1.0
 
 PortGroup   github 1.0
 github.setuptpaviot oce 0.15 OCE-
 
 categories  graphics
 maintainers gmail.com:mark.brethen
 description Open CASCADE Community Edition
 Long_descriptionOCE is a fork for patches/improvements/experiments\
over OpenCascade.

Please determine and add the correct license. This will allow Macports to 
distribute a binary -  license permitting. 

 
 homepagehttps://github.com/tpaviot/oce
 
 checksums rmd160 be53cced4d5463d466fd17c3f721ae56fb89e32b \
  sha256 
 2d7632dda63be06dc79202a025076deb4f1b0d1dede20b68da9536ce184d5ed1
 
 depends_build   port:cmake \
port:ftgl  \
port:freeimage \
port:gl2ps \
Port:tbb

Since you are using a portgroup - github in this case - it might have 
dependencies. But you are overriding them by setting depends_build. Instead you 
should use depends_build-append. 

 configure {
system cd ${worksrcpath}  cmake ${configure.args} ${worksrcpath};”
 }

A couple of issues here. You should consider adding the cmake portgroup which 
is designed for ports that build with cmake. That will likely make this entire 
block unnecessary. Also, please do not use system “cd….”. Per the guide [1], 
you should use the -W flag instead. I.e.

system -W ${worksrcpath} “cmake ...


Cheers!
Frank

[1] https://trac.macports.org/wiki/FAQ#cd

___
macports-dev mailing list
macports-dev@lists.macosforge.org
https://lists.macosforge.org/mailman/listinfo/macports-dev


Re: Open CASCADE Community Edition fetch type

2014-06-14 Thread Joshua Root
On 2014-6-14 23:24 , Mark Brethen wrote:
 Open CASCADE Community Edition has both a git clone url 
 (https://github.com/tpaviot/oce.git) and a tarball for download. I read in 
 the port documentation that fetching with git url may cause non-reproducible 
 builds, so downloaded the tarball 
 (https://github.com/tpaviot/oce/archive/OCE-0.15.tar.gz) but it has the 
 filename: oce-OCE-0.15.tar.gz. I setup the Portfile as follows:
 
 name  oce
 version   0.15
 master_siteshttps://github.com/tpaviot/oce/archive/
 distnameOCE-${version}
 distfile${name}-OCE-${version}
 
 Am I missing anything?

I assume 'distfile' is a typo and your portfile actually says
'distfiles' (otherwise it would fail to parse).

If you're going to set distfiles, it needs to contain complete
filenames, i.e. oce-OCE-0.15.tar.gz. The default value of distfiles is
${distname}${extract.suffix}. Setting distname when you also set
distfiles only ends up indirectly affecting the value of worksrcdir
(which has a default value of $distname). So when you have a single
distfile, it's more clear to not set distfiles at all, but do this:

distname${name}-OCE-${version}
worksrcdir  OCE-${version}

- Josh
___
macports-dev mailing list
macports-dev@lists.macosforge.org
https://lists.macosforge.org/mailman/listinfo/macports-dev


Re: Open CASCADE Community Edition fetch type

2014-06-14 Thread Mark Brethen

On Jun 14, 2014, at 11:01 AM, Frank Schima m...@macports.org wrote:

 Hi Mark,
 
 
 Some observations about this Portfile:
 
 On Jun 14, 2014, at 9:49 AM, Mark Brethen mark.bret...@gmail.com wrote:
 
 This is what I have in the Portfile so far:
 
 # -*- coding: utf-8; mode: tcl; tab-width: 4; indent-tabs-mode: nil; 
 c-basic-offset: 4 -*- vim:fenc=utf-8:ft=tcl:et:sw=4:ts=4:sts=4
 # $Id$
 
 PortSystem  1.0
 
 PortGroup   github 1.0
 github.setuptpaviot oce 0.15 OCE-
 
 categories  graphics
 maintainers gmail.com:mark.brethen
 description Open CASCADE Community Edition
 Long_descriptionOCE is a fork for patches/improvements/experiments\
over OpenCascade.
 
 Please determine and add the correct license. This will allow Macports to 
 distribute a binary -  license permitting. 
 
 
 homepagehttps://github.com/tpaviot/oce
 
 checksums rmd160 be53cced4d5463d466fd17c3f721ae56fb89e32b \
  sha256 
 2d7632dda63be06dc79202a025076deb4f1b0d1dede20b68da9536ce184d5ed1
 
 depends_build   port:cmake \
port:ftgl  \
port:freeimage \
port:gl2ps \
Port:tbb
 
 Since you are using a portgroup - github in this case - it might have 
 dependencies. But you are overriding them by setting depends_build. Instead 
 you should use depends_build-append. 
 
 configure {
system cd ${worksrcpath}  cmake ${configure.args} ${worksrcpath};”
 }
 
 A couple of issues here. You should consider adding the cmake portgroup which 
 is designed for ports that build with cmake. That will likely make this 
 entire block unnecessary. Also, please do not use system “cd….”. Per the 
 guide [1], you should use the -W flag instead. I.e.
 
 system -W ${worksrcpath} “cmake ...
 
 
 Cheers!
 Frank
 
 [1] https://trac.macports.org/wiki/FAQ#cd
 
 ___
 macports-dev mailing list
 macports-dev@lists.macosforge.org
 https://lists.macosforge.org/mailman/listinfo/macports-dev

Revised Portfile based on comments from the group:

# -*- coding: utf-8; mode: tcl; tab-width: 4; indent-tabs-mode: nil; 
c-basic-offset: 4 -*- vim:fenc=utf-8:ft=tcl:et:sw=4:ts=4:sts=4
# $Id$

PortSystem  1.0

PortGroup   cmake 1.0
PortGroup   github 1.0
github.setuptpaviot oce 0.15 OCE-

categories  graphics
maintainers gmail.com:mark.brethen
description Open CASCADE Community Edition
Long_descriptionOCE is a fork for patches/improvements/experiments\
over OpenCascade.
license LGPL 2.1
homepagehttps://github.com/tpaviot/oce

checksums rmd160 be53cced4d5463d466fd17c3f721ae56fb89e32b \
  sha256 
2d7632dda63be06dc79202a025076deb4f1b0d1dede20b68da9536ce184d5ed1

depends_build-append port:cmake \
port:ftgl  \
port:freeimage \
port:gl2ps \
Port:tbb

configure.args-append  \
-DOCE_DRAW:BOOL=ON \
-DOCE_WITH_FREEIMAGE:BOOL=ON \
-DOCE_WITH_GL2PS:BOOL=ON \
-DOCE_MULTITHREAD_LIBRARY:STRING=TBB

Again, I'm following build notes for Mac OS X at: 
https://github.com/tpaviot/oce/wiki/Build-%28Mac-OSX%29 .

Thanks,

Mark




___
macports-dev mailing list
macports-dev@lists.macosforge.org
https://lists.macosforge.org/mailman/listinfo/macports-dev


Re: Open CASCADE Community Edition fetch type

2014-06-14 Thread Mark Brethen


Begin forwarded message:

 From: Mark Brethen mark.bret...@gmail.com
 Subject: Re: Open CASCADE Community Edition fetch type
 Date: June 14, 2014 at 12:19:15 PM CDT
 To: Frank Schima m...@macports.org
 Cc: MacPorts Development macports-dev@lists.macosforge.org
 
 
 On Jun 14, 2014, at 11:01 AM, Frank Schima m...@macports.org wrote:
 
 Hi Mark,
 
 
 Some observations about this Portfile:
 
 On Jun 14, 2014, at 9:49 AM, Mark Brethen mark.bret...@gmail.com wrote:
 
 This is what I have in the Portfile so far:
 
 # -*- coding: utf-8; mode: tcl; tab-width: 4; indent-tabs-mode: nil; 
 c-basic-offset: 4 -*- vim:fenc=utf-8:ft=tcl:et:sw=4:ts=4:sts=4
 # $Id$
 
 PortSystem  1.0
 
 PortGroup   github 1.0
 github.setuptpaviot oce 0.15 OCE-
 
 categories  graphics
 maintainers gmail.com:mark.brethen
 description Open CASCADE Community Edition
 Long_descriptionOCE is a fork for patches/improvements/experiments\
   over OpenCascade.
 
 Please determine and add the correct license. This will allow Macports to 
 distribute a binary -  license permitting. 
 
 
 homepagehttps://github.com/tpaviot/oce
 
 checksums rmd160 be53cced4d5463d466fd17c3f721ae56fb89e32b \
 sha256 
 2d7632dda63be06dc79202a025076deb4f1b0d1dede20b68da9536ce184d5ed1
 
 depends_build   port:cmake \
   port:ftgl  \
   port:freeimage \
   port:gl2ps \
   Port:tbb
 
 Since you are using a portgroup - github in this case - it might have 
 dependencies. But you are overriding them by setting depends_build. Instead 
 you should use depends_build-append. 
 
 configure {
   system cd ${worksrcpath}  cmake ${configure.args} ${worksrcpath};”
 }
 
 A couple of issues here. You should consider adding the cmake portgroup 
 which is designed for ports that build with cmake. That will likely make 
 this entire block unnecessary. Also, please do not use system “cd….”. Per 
 the guide [1], you should use the -W flag instead. I.e.
 
 system -W ${worksrcpath} “cmake ...
 
 
 Cheers!
 Frank
 
 [1] https://trac.macports.org/wiki/FAQ#cd
 
 ___
 macports-dev mailing list
 macports-dev@lists.macosforge.org
 https://lists.macosforge.org/mailman/listinfo/macports-dev
 
 Revised Portfile based on comments from the group:
 
 # -*- coding: utf-8; mode: tcl; tab-width: 4; indent-tabs-mode: nil; 
 c-basic-offset: 4 -*- vim:fenc=utf-8:ft=tcl:et:sw=4:ts=4:sts=4
 # $Id$
 
 PortSystem  1.0
 
 PortGroup   cmake 1.0
 PortGroup   github 1.0
 github.setuptpaviot oce 0.15 OCE-
 
 categories  graphics
 maintainers gmail.com:mark.brethen
 description Open CASCADE Community Edition
 Long_descriptionOCE is a fork for patches/improvements/experiments\
over OpenCascade.
 license LGPL 2.1
 homepagehttps://github.com/tpaviot/oce
 
 checksums rmd160 be53cced4d5463d466fd17c3f721ae56fb89e32b \
  sha256 
 2d7632dda63be06dc79202a025076deb4f1b0d1dede20b68da9536ce184d5ed1
 
 depends_build-append port:cmake \
port:ftgl  \
port:freeimage \
port:gl2ps \
Port:tbb
 
 configure.args-append  \
-DOCE_DRAW:BOOL=ON \
-DOCE_WITH_FREEIMAGE:BOOL=ON \
-DOCE_WITH_GL2PS:BOOL=ON \
-DOCE_MULTITHREAD_LIBRARY:STRING=TBB
 
 Again, I'm following build notes for Mac OS X at: 
 https://github.com/tpaviot/oce/wiki/Build-%28Mac-OSX%29 .
 
 Thanks,
 
 Mark
 
 
 
 

The above Portfile failed to build. Here is the end of the log:

:debug:configure Environment: 
CC='/usr/bin/clang'
CC_PRINT_OPTIONS='YES'
CC_PRINT_OPTIONS_FILE='/opt/local/var/macports/build/_Users_marbre_ports_graphics_oce/oce/work/.CC_PRINT_OPTIONS'
CFLAGS='-pipe -Os -I/opt/local/include -arch x86_64'
CPATH='/opt/local/include'
CPPFLAGS='-I/opt/local/include'
CXX='/usr/bin/clang++'
CXXFLAGS='-pipe -Os -I/opt/local/include -arch x86_64 -stdlib=libc++'
F77FLAGS='-m64'
F90FLAGS='-pipe -Os -m64'
FCFLAGS='-pipe -Os -m64'
FFLAGS='-pipe -Os'
INSTALL='/usr/bin/install -c'
LDFLAGS='-L/opt/local/lib -Wl,-headerpad_max_install_names -arch x86_64'
LIBRARY_PATH='/opt/local/lib'
MACOSX_DEPLOYMENT_TARGET='10.9'
OBJC='/usr/bin/clang'
OBJCFLAGS='-pipe -Os -arch x86_64'
OBJCXX='/usr/bin/clang++'
OBJCXXFLAGS='-pipe -Os -arch x86_64 -stdlib=libc++'
:debug:configure Assembled command: 'cd 
/opt/local/var/macports/build/_Users_marbre_ports_graphics_oce/oce/work/oce-0.15
  /opt/local/bin/cmake -DCMAKE_INSTALL_PREFIX=/opt/local 
-DCMAKE_VERBOSE_MAKEFILE=ON -DCMAKE_COLOR_MAKEFILE=ON 
-DCMAKE_BUILD_TYPE=Release -DCMAKE_BUILD_WITH_INSTALL_RPATH=ON 
-DCMAKE_INSTALL_RPATH=/opt/local/lib -DCMAKE_INSTALL_NAME_DIR=/opt/local/lib 
-DCMAKE_SYSTEM_PREFIX_PATH=/opt/local;/usr 
-DCMAKE_MODULE_PATH=/opt/local/share/cmake/modules -DCMAKE_FIND_FRAMEWORK=LAST 
-Wno-dev -DOCE_DRAW:BOOL=ON -DOCE_WITH_FREEIMAGE:BOOL=ON 
-DOCE_WITH_GL2PS:BOOL=ON -DOCE_MULTITHREAD_LIBRARY:STRING=TBB 
-DCMAKE_C_FLAGS_RELEASE=-DNDEBUG

Re: Open CASCADE Community Edition fetch type

2014-06-14 Thread Joshua Root
On 2014-6-15 10:09 , Mark Brethen wrote:
 
 
 Begin forwarded message:
 
 From: Mark Brethen mark.bret...@gmail.com
 Subject: Re: Open CASCADE Community Edition fetch type
 Date: June 14, 2014 at 12:19:15 PM CDT
 To: Frank Schima m...@macports.org
 Cc: MacPorts Development macports-dev@lists.macosforge.org


 On Jun 14, 2014, at 11:01 AM, Frank Schima m...@macports.org wrote:

 Hi Mark,


 Some observations about this Portfile:

 On Jun 14, 2014, at 9:49 AM, Mark Brethen mark.bret...@gmail.com wrote:

 This is what I have in the Portfile so far:

 # -*- coding: utf-8; mode: tcl; tab-width: 4; indent-tabs-mode: nil; 
 c-basic-offset: 4 -*- vim:fenc=utf-8:ft=tcl:et:sw=4:ts=4:sts=4
 # $Id$

 PortSystem  1.0

 PortGroup   github 1.0
 github.setuptpaviot oce 0.15 OCE-

 categories  graphics
 maintainers gmail.com:mark.brethen
 description Open CASCADE Community Edition
 Long_descriptionOCE is a fork for patches/improvements/experiments\
   over OpenCascade.

 Please determine and add the correct license. This will allow Macports to 
 distribute a binary -  license permitting. 


 homepagehttps://github.com/tpaviot/oce

 checksums rmd160 be53cced4d5463d466fd17c3f721ae56fb89e32b \
 sha256 
 2d7632dda63be06dc79202a025076deb4f1b0d1dede20b68da9536ce184d5ed1

 depends_build   port:cmake \
   port:ftgl  \
   port:freeimage \
   port:gl2ps \
   Port:tbb

 Since you are using a portgroup - github in this case - it might have 
 dependencies. But you are overriding them by setting depends_build. Instead 
 you should use depends_build-append. 

 configure {
   system cd ${worksrcpath}  cmake ${configure.args} ${worksrcpath};”
 }

 A couple of issues here. You should consider adding the cmake portgroup 
 which is designed for ports that build with cmake. That will likely make 
 this entire block unnecessary. Also, please do not use system “cd….”. Per 
 the guide [1], you should use the -W flag instead. I.e.

 system -W ${worksrcpath} “cmake ...


 Cheers!
 Frank

 [1] https://trac.macports.org/wiki/FAQ#cd

 ___
 macports-dev mailing list
 macports-dev@lists.macosforge.org
 https://lists.macosforge.org/mailman/listinfo/macports-dev

 Revised Portfile based on comments from the group:

 # -*- coding: utf-8; mode: tcl; tab-width: 4; indent-tabs-mode: nil; 
 c-basic-offset: 4 -*- vim:fenc=utf-8:ft=tcl:et:sw=4:ts=4:sts=4
 # $Id$

 PortSystem  1.0

 PortGroup   cmake 1.0
 PortGroup   github 1.0
 github.setuptpaviot oce 0.15 OCE-

 categories  graphics
 maintainers gmail.com:mark.brethen
 description Open CASCADE Community Edition
 Long_descriptionOCE is a fork for patches/improvements/experiments\
over OpenCascade.
 license LGPL 2.1
 homepagehttps://github.com/tpaviot/oce

 checksums rmd160 be53cced4d5463d466fd17c3f721ae56fb89e32b \
  sha256 
 2d7632dda63be06dc79202a025076deb4f1b0d1dede20b68da9536ce184d5ed1

 depends_build-append port:cmake \
port:ftgl  \
port:freeimage \
port:gl2ps \
Port:tbb

 configure.args-append  \
-DOCE_DRAW:BOOL=ON \
-DOCE_WITH_FREEIMAGE:BOOL=ON \
-DOCE_WITH_GL2PS:BOOL=ON \
-DOCE_MULTITHREAD_LIBRARY:STRING=TBB

 Again, I'm following build notes for Mac OS X at: 
 https://github.com/tpaviot/oce/wiki/Build-%28Mac-OSX%29 .

 Thanks,

 Mark




 
 The above Portfile failed to build. Here is the end of the log:
 
 :debug:configure Environment: 
 CC='/usr/bin/clang'
 CC_PRINT_OPTIONS='YES'
 CC_PRINT_OPTIONS_FILE='/opt/local/var/macports/build/_Users_marbre_ports_graphics_oce/oce/work/.CC_PRINT_OPTIONS'
 CFLAGS='-pipe -Os -I/opt/local/include -arch x86_64'
 CPATH='/opt/local/include'
 CPPFLAGS='-I/opt/local/include'
 CXX='/usr/bin/clang++'
 CXXFLAGS='-pipe -Os -I/opt/local/include -arch x86_64 -stdlib=libc++'
 F77FLAGS='-m64'
 F90FLAGS='-pipe -Os -m64'
 FCFLAGS='-pipe -Os -m64'
 FFLAGS='-pipe -Os'
 INSTALL='/usr/bin/install -c'
 LDFLAGS='-L/opt/local/lib -Wl,-headerpad_max_install_names -arch x86_64'
 LIBRARY_PATH='/opt/local/lib'
 MACOSX_DEPLOYMENT_TARGET='10.9'
 OBJC='/usr/bin/clang'
 OBJCFLAGS='-pipe -Os -arch x86_64'
 OBJCXX='/usr/bin/clang++'
 OBJCXXFLAGS='-pipe -Os -arch x86_64 -stdlib=libc++'
 :debug:configure Assembled command: 'cd 
 /opt/local/var/macports/build/_Users_marbre_ports_graphics_oce/oce/work/oce-0.15
   /opt/local/bin/cmake -DCMAKE_INSTALL_PREFIX=/opt/local 
 -DCMAKE_VERBOSE_MAKEFILE=ON -DCMAKE_COLOR_MAKEFILE=ON 
 -DCMAKE_BUILD_TYPE=Release -DCMAKE_BUILD_WITH_INSTALL_RPATH=ON 
 -DCMAKE_INSTALL_RPATH=/opt/local/lib -DCMAKE_INSTALL_NAME_DIR=/opt/local/lib 
 -DCMAKE_SYSTEM_PREFIX_PATH=/opt/local;/usr 
 -DCMAKE_MODULE_PATH=/opt/local/share/cmake/modules 
 -DCMAKE_FIND_FRAMEWORK=LAST -Wno-dev -DOCE_DRAW:BOOL=ON 
 -DOCE_WITH_FREEIMAGE:BOOL=ON -DOCE_WITH_GL2PS:BOOL=ON 
 -DOCE_MULTITHREAD_LIBRARY:STRING=TBB

Re: Open CASCADE Community Edition fetch type

2014-06-14 Thread Ryan Schmidt
I have an unfinished portfile for OpenCASCADE 6.3.0 I was working on in July 
2010, but nothing about our portfiles is similar. Maybe that was a different 
software package.


On Jun 14, 2014, at 12:19 PM, Mark Brethen wrote:

 Revised Portfile based on comments from the group:
 
 # -*- coding: utf-8; mode: tcl; tab-width: 4; indent-tabs-mode: nil; 
 c-basic-offset: 4 -*- vim:fenc=utf-8:ft=tcl:et:sw=4:ts=4:sts=4
 # $Id$
 
 PortSystem  1.0

There should not be a blank line here.

 PortGroup   cmake 1.0
 PortGroup   github 1.0

There should be a blank line here.

 Long_descriptionOCE is a fork for patches/improvements/experiments\
over OpenCascade.

Long_description should not be capitalized (should be long_description).

 license LGPL 2.1

The correct way to express this license would be LGPL-2.1.

 homepagehttps://github.com/tpaviot/oce

Unnecessary; the github portgroup sets this for you.

 depends_build-append port:cmake \

Unnecessary; the cmake portgroup sets this for you.

 configure.args-append  \
-DOCE_DRAW:BOOL=ON \

There should not be a closing quotation mark there.

-DOCE_WITH_FREEIMAGE:BOOL=ON \
-DOCE_WITH_GL2PS:BOOL=ON \
-DOCE_MULTITHREAD_LIBRARY:STRING=TBB

___
macports-dev mailing list
macports-dev@lists.macosforge.org
https://lists.macosforge.org/mailman/listinfo/macports-dev


Re: Open CASCADE Community Edition fetch type

2014-06-14 Thread Mark Brethen

On Jun 14, 2014, at 7:27 PM, Ryan Schmidt ryandes...@macports.org wrote:

 I have an unfinished portfile for OpenCASCADE 6.3.0 I was working on in July 
 2010, but nothing about our portfiles is similar. Maybe that was a different 
 software package.
 
 
 On Jun 14, 2014, at 12:19 PM, Mark Brethen wrote:
 
 Revised Portfile based on comments from the group:
 
 # -*- coding: utf-8; mode: tcl; tab-width: 4; indent-tabs-mode: nil; 
 c-basic-offset: 4 -*- vim:fenc=utf-8:ft=tcl:et:sw=4:ts=4:sts=4
 # $Id$
 
 PortSystem  1.0
 
 There should not be a blank line here.
 
 PortGroup   cmake 1.0
 PortGroup   github 1.0
 
 There should be a blank line here.
 
 Long_descriptionOCE is a fork for patches/improvements/experiments\
   over OpenCascade.
 
 Long_description should not be capitalized (should be long_description).
 
 license LGPL 2.1
 
 The correct way to express this license would be LGPL-2.1.
 
 homepagehttps://github.com/tpaviot/oce
 
 Unnecessary; the github portgroup sets this for you.
 
 depends_build-append port:cmake \
 
 Unnecessary; the cmake portgroup sets this for you.
 
 configure.args-append  \
   -DOCE_DRAW:BOOL=ON \
 
 There should not be a closing quotation mark there.
 
   -DOCE_WITH_FREEIMAGE:BOOL=ON \
   -DOCE_WITH_GL2PS:BOOL=ON \
   -DOCE_MULTITHREAD_LIBRARY:STRING=TBB
 

They're the same, but different. The project aims to establish a separate 
community-based release and bug-report process for the library. From what I've 
read this is more successful building on mac os X. Homebrew uses it in their 
build, but I don't need/want another package manager. Macports is building it 
at this very moment.
.

Mark




___
macports-dev mailing list
macports-dev@lists.macosforge.org
https://lists.macosforge.org/mailman/listinfo/macports-dev


Re: Open CASCADE Community Edition fetch type

2014-06-14 Thread Mark Brethen

On Jun 14, 2014, at 7:22 PM, Joshua Root j...@macports.org wrote:

 On 2014-6-15 10:09 , Mark Brethen wrote:
 
 
 Begin forwarded message:
 
 From: Mark Brethen mark.bret...@gmail.com
 Subject: Re: Open CASCADE Community Edition fetch type
 Date: June 14, 2014 at 12:19:15 PM CDT
 To: Frank Schima m...@macports.org
 Cc: MacPorts Development macports-dev@lists.macosforge.org
 
 
 On Jun 14, 2014, at 11:01 AM, Frank Schima m...@macports.org wrote:
 
 Hi Mark,
 
 
 Some observations about this Portfile:
 
 On Jun 14, 2014, at 9:49 AM, Mark Brethen mark.bret...@gmail.com wrote:
 
 This is what I have in the Portfile so far:
 
 # -*- coding: utf-8; mode: tcl; tab-width: 4; indent-tabs-mode: nil; 
 c-basic-offset: 4 -*- vim:fenc=utf-8:ft=tcl:et:sw=4:ts=4:sts=4
 # $Id$
 
 PortSystem  1.0
 
 PortGroup   github 1.0
 github.setuptpaviot oce 0.15 OCE-
 
 categories  graphics
 maintainers gmail.com:mark.brethen
 description Open CASCADE Community Edition
 Long_descriptionOCE is a fork for patches/improvements/experiments\
  over OpenCascade.
 
 Please determine and add the correct license. This will allow Macports to 
 distribute a binary -  license permitting. 
 
 
 homepagehttps://github.com/tpaviot/oce
 
 checksums rmd160 be53cced4d5463d466fd17c3f721ae56fb89e32b \
sha256 
 2d7632dda63be06dc79202a025076deb4f1b0d1dede20b68da9536ce184d5ed1
 
 depends_build   port:cmake \
  port:ftgl  \
  port:freeimage \
  port:gl2ps \
  Port:tbb
 
 Since you are using a portgroup - github in this case - it might have 
 dependencies. But you are overriding them by setting depends_build. 
 Instead you should use depends_build-append. 
 
 configure {
  system cd ${worksrcpath}  cmake ${configure.args} ${worksrcpath};”
 }
 
 A couple of issues here. You should consider adding the cmake portgroup 
 which is designed for ports that build with cmake. That will likely make 
 this entire block unnecessary. Also, please do not use system “cd….”. Per 
 the guide [1], you should use the -W flag instead. I.e.
 
 system -W ${worksrcpath} “cmake ...
 
 
 Cheers!
 Frank
 
 [1] https://trac.macports.org/wiki/FAQ#cd
 
 ___
 macports-dev mailing list
 macports-dev@lists.macosforge.org
 https://lists.macosforge.org/mailman/listinfo/macports-dev
 
 Revised Portfile based on comments from the group:
 
 # -*- coding: utf-8; mode: tcl; tab-width: 4; indent-tabs-mode: nil; 
 c-basic-offset: 4 -*- vim:fenc=utf-8:ft=tcl:et:sw=4:ts=4:sts=4
 # $Id$
 
 PortSystem  1.0
 
 PortGroup   cmake 1.0
 PortGroup   github 1.0
 github.setuptpaviot oce 0.15 OCE-
 
 categories  graphics
 maintainers gmail.com:mark.brethen
 description Open CASCADE Community Edition
 Long_descriptionOCE is a fork for patches/improvements/experiments\
   over OpenCascade.
 license LGPL 2.1
 homepagehttps://github.com/tpaviot/oce
 
 checksums rmd160 be53cced4d5463d466fd17c3f721ae56fb89e32b \
 sha256 
 2d7632dda63be06dc79202a025076deb4f1b0d1dede20b68da9536ce184d5ed1
 
 depends_build-append port:cmake \
   port:ftgl  \
   port:freeimage \
   port:gl2ps \
   Port:tbb
 
 configure.args-append  \
   -DOCE_DRAW:BOOL=ON \
   -DOCE_WITH_FREEIMAGE:BOOL=ON \
   -DOCE_WITH_GL2PS:BOOL=ON \
   -DOCE_MULTITHREAD_LIBRARY:STRING=TBB
 
 Again, I'm following build notes for Mac OS X at: 
 https://github.com/tpaviot/oce/wiki/Build-%28Mac-OSX%29 .
 
 Thanks,
 
 Mark
 
 
 
 
 
 The above Portfile failed to build. Here is the end of the log:
 
 :debug:configure Environment: 
 CC='/usr/bin/clang'
 CC_PRINT_OPTIONS='YES'
 CC_PRINT_OPTIONS_FILE='/opt/local/var/macports/build/_Users_marbre_ports_graphics_oce/oce/work/.CC_PRINT_OPTIONS'
 CFLAGS='-pipe -Os -I/opt/local/include -arch x86_64'
 CPATH='/opt/local/include'
 CPPFLAGS='-I/opt/local/include'
 CXX='/usr/bin/clang++'
 CXXFLAGS='-pipe -Os -I/opt/local/include -arch x86_64 -stdlib=libc++'
 F77FLAGS='-m64'
 F90FLAGS='-pipe -Os -m64'
 FCFLAGS='-pipe -Os -m64'
 FFLAGS='-pipe -Os'
 INSTALL='/usr/bin/install -c'
 LDFLAGS='-L/opt/local/lib -Wl,-headerpad_max_install_names -arch x86_64'
 LIBRARY_PATH='/opt/local/lib'
 MACOSX_DEPLOYMENT_TARGET='10.9'
 OBJC='/usr/bin/clang'
 OBJCFLAGS='-pipe -Os -arch x86_64'
 OBJCXX='/usr/bin/clang++'
 OBJCXXFLAGS='-pipe -Os -arch x86_64 -stdlib=libc++'
 :debug:configure Assembled command: 'cd 
 /opt/local/var/macports/build/_Users_marbre_ports_graphics_oce/oce/work/oce-0.15
   /opt/local/bin/cmake -DCMAKE_INSTALL_PREFIX=/opt/local 
 -DCMAKE_VERBOSE_MAKEFILE=ON -DCMAKE_COLOR_MAKEFILE=ON 
 -DCMAKE_BUILD_TYPE=Release -DCMAKE_BUILD_WITH_INSTALL_RPATH=ON 
 -DCMAKE_INSTALL_RPATH=/opt/local/lib -DCMAKE_INSTALL_NAME_DIR=/opt/local/lib 
 -DCMAKE_SYSTEM_PREFIX_PATH=/opt/local;/usr 
 -DCMAKE_MODULE_PATH=/opt/local/share/cmake/modules 
 -DCMAKE_FIND_FRAMEWORK=LAST -Wno-dev -DOCE_DRAW:BOOL