> On Feb 28, 2017, at 07:56, Kurt Hindenburg <khindenb...@macports.org> wrote: > > Kurt Hindenburg (kurthindenburg) pushed a commit to branch master > in repository macports-ports. > > > https://github.com/macports/macports-ports/commit/6262d02ad4539a02372e9959b8a653ba2d03b043 > > The following commit(s) were added to refs/heads/master by this push: > > new 6262d02 smlr: new port > > new c8ad1a4 Merge branch 'master' of github.com:macports/macports-ports > > 6262d02 is described below > > > commit 6262d02ad4539a02372e9959b8a653ba2d03b043 > > Author: Kurt Hindenburg <khindenb...@macports.org> > AuthorDate: Tue Feb 28 08:54:46 2017 -0500 > > > smlr: new port > > > > closes https://trac.macports.org/ticket/53478 > > --- > sysutils/smlr/Portfile | 32 ++++++++++++++++++++ > sysutils/smlr/files/patch-Makefile.diff | 53 > +++++++++++++++++++++++++++++++++ > 2 files changed, 85 insertions(+) > > > diff --git a/sysutils/smlr/Portfile b/sysutils/smlr/Portfile > > new file mode 100644 > > index 0000000..7362a3f > > --- /dev/null > > +++ b/sysutils/smlr/Portfile > > @@ -0,0 +1,32 @@ > > +# -*- coding: utf-8; mode: tcl; tab-width: 2; indent-tabs-mode: nil; > c-basic-offset: 2 -*- vim:fenc=utf-8:ft=tcl:et:sw=4:ts=4:sts=4 > > + > > +PortSystem 1.0 > > +PortGroup github 1.0 > > + > > +github.setup thenatefisher smlr 0.0.6 > > +categories sysutils > > +platforms darwin > > +license MIT > > +maintainers @thenatefisher openmaintainer > > + > > +homepage https://github.com/thenatefisher/smlr > > + > > +description Text truncation utility > > +long_description smlr reduces the size of a text input based on \ > > + specified parameters. It makes your string smaller, if it's too big. > > + > > +checksums sha256 > 4641de211cd5d7ab7df5508568cf885920dce0046900c73656f5a5d6a81e7982 \ > > + rmd160 95a6d0a71604993b31bbb4c468299e176ad028d2 > > + > > +patchfiles patch-Makefile.diff > > + > > +variant universal {} > > + > > +use_configure no > > + > > +build.env CC="${configure.cc}" \ > > + CFLAGS="${configure.cflags} [get_canonical_archflags > cc]" \ > > + LDFLAGS="${configure.ldflags} [get_canonical_archflags > ld]" \ > > + PREFIX=${prefix} > > + > > +destroot.env PREFIX=${destroot}${prefix} > > diff --git a/sysutils/smlr/files/patch-Makefile.diff > b/sysutils/smlr/files/patch-Makefile.diff > > new file mode 100644 > > index 0000000..85fcadb > > --- /dev/null > > +++ b/sysutils/smlr/files/patch-Makefile.diff > > @@ -0,0 +1,53 @@ > > +--- Makefile 2017-02-03 03:41:09.000000000 -0500 > > ++++ Makefile 2017-02-28 08:52:27.000000000 -0500 > > +@@ -1,47 +1,19 @@ > > + SRC_DIR =src > > + BUILD_DIR =build > > +-TESTS_DIR =tests > > +-GTEST_DIR =googletest/googletest > > +-GTEST_INC =-I$(GTEST_DIR)/include -I$(GTEST_DIR)/include/gtest > -I$(GTEST_DIR)/include/gtest/internal > > +-INSTALL_DIR =opt/local/bin > > + > > + all : $(BUILD_DIR)/rel/smlr > > + > > +-test : $(BUILD_DIR)/rel/smlr_ut > > +- @git submodule update --init > > +- @$(BUILD_DIR)/rel/smlr_ut > > +- > > + install : $(BUILD_DIR)/rel/smlr > > +- cp $^ $(DESTDIR)/$(INSTALL_DIR) > > ++ cp $^ $(PREFIX)/bin/ >
I'd rather not see a patch that removes DESTDIR support from a Makefile. We prefer DESTDIR support. I agree the way in which the Makefile was supporting changing the prefix (using the INSTALL_DIR variable) was sub-optimal, but I'd rather see a patch that fixes that while retaining the DESTDIR support.