Re: Updating OpenSSH port to 8.4p1
On Oct 16, 2020, at 20:26, Blake Garner wrote: > Thanks for the info and I'll have a look at the issues. I have setup a repo > to test updated and customized ports > https://github.com/trodemaster/blakeports . Successfully rolled the version > of openssh to 8.4p1 and incremented the port revision to 10. Currently I'm > sorting through the patches. > > These ones work as expected > pam.patch > patch-sandbox-darwin.c-apple-sandbox-named-external.diff > patch-sshd.c-apple-sandbox-named-external.diff > > Not working > 0002-Apple-keychain-integration-other-changes.patch Homebrew has a thread > on it here https://archive.is/hSB6d#10%25 > > Questioning if these are really needed? > launchd.patch > macports-config.patch > patch-openbsd_compat-memmem-bug.diff > > Some of these patches may be obsolete with the 8.4 version of openssh. I'm > just searching the trac for info on each of them to get details. Any feedback > is appreciated otherwise I'll just keep at it as I find time. You'll have to figure it out. You can look at the git history to discover when the patches were added / last updated and read the commit message(s) and/or linked ticket(s) to see why the patches exist. You can then decide whether they're still needed. Generally I agree with the sentiment expressed in the homebrew thread you referred to above: we don't want to be in the business of forever maintaining extensive patches to software. Instead we want to provide the software that the developers have developed. If any patches are needed, they should be sent to the developers for inclusion in their code; then everyone benefits, not just us. If upstream is not willing to accept a patch, we should consider whether we should stop using that patch.
Re: Updating OpenSSH port to 8.4p1
Thanks will do. On Sat, Oct 17, 2020 at 12:24 AM Nils Breunese wrote: > Blake Garner wrote: > > > Successfully rolled the version of openssh to 8.4p1 and incremented the > port revision to 10. > > I see the Portfile Reference [0] doesn’t mention this, but when you > increment the version, the revision should be reset to 0. Bumping the > revision should only happen when making changes to a Portfile that impact > users, while the version of the software that gets installed stays the same. > > Nils. > > [0] https://guide.macports.org/chunked/reference.html
Re: Updating OpenSSH port to 8.4p1
Blake Garner wrote: > Successfully rolled the version of openssh to 8.4p1 and incremented the port > revision to 10. I see the Portfile Reference [0] doesn’t mention this, but when you increment the version, the revision should be reset to 0. Bumping the revision should only happen when making changes to a Portfile that impact users, while the version of the software that gets installed stays the same. Nils. [0] https://guide.macports.org/chunked/reference.html
Re: Updating OpenSSH port to 8.4p1
Thanks for the info and I'll have a look at the issues. I have setup a repo to test updated and customized ports https://github.com/trodemaster/blakeports . Successfully rolled the version of openssh to 8.4p1 and incremented the port revision to 10. Currently I'm sorting through the patches. These ones work as expected pam.patch patch-sandbox-darwin.c-apple-sandbox-named-external.diff patch-sshd.c-apple-sandbox-named-external.diff Not working 0002-Apple-keychain-integration-other-changes.patch Homebrew has a thread on it here https://archive.is/hSB6d#10%25 Questioning if these are really needed? launchd.patch macports-config.patch patch-openbsd_compat-memmem-bug.diff Some of these patches may be obsolete with the 8.4 version of openssh. I'm just searching the trac for info on each of them to get details. Any feedback is appreciated otherwise I'll just keep at it as I find time. Blake On Thu, Oct 1, 2020 at 12:18 AM Mojca Miklavec wrote: > Dear Blake, > > On Wed, 30 Sep 2020 at 19:56, Blake Garner wrote: > > > > I see that the port for OpenSSH has no maintainer and hasn't been > updated in a while. Reviewing the docs it looks reasonable for me to try > and update the port and submit it. Is anybody else already working on it? > > I cannot answer about whether anyone else is working on this, but new > contributors are always welcome and greatly appreciated. > > > Advice for a updating a port the first time beyond what's on the site? > > Apart from updating the port itself we also need to increase the > revision of all the ports depending on OpenSSH (and ideally check > whether they still build after the update). > (Updating the dependencies may be done in a separate commit, but it > needs to be taken care of.) > > As the first approximation you could get the list of dependent ports here: > https://ports.macports.org/port/openssh/ > (The list may not be 100% accurate, so another grep for openssh inside > the ports tree may not hurt.) > > On the website you can also check the list of open tickets: > https://ports.macports.org/port/openssh/tickets > We are not asking you to address any of those, but sometimes an update > resolves an issue, or there's already an update request in the trac > that can be closed. > > Mojca >
Re: Updating OpenSSH port to 8.4p1
Dear Blake, On Wed, 30 Sep 2020 at 19:56, Blake Garner wrote: > > I see that the port for OpenSSH has no maintainer and hasn't been updated in > a while. Reviewing the docs it looks reasonable for me to try and update the > port and submit it. Is anybody else already working on it? I cannot answer about whether anyone else is working on this, but new contributors are always welcome and greatly appreciated. > Advice for a updating a port the first time beyond what's on the site? Apart from updating the port itself we also need to increase the revision of all the ports depending on OpenSSH (and ideally check whether they still build after the update). (Updating the dependencies may be done in a separate commit, but it needs to be taken care of.) As the first approximation you could get the list of dependent ports here: https://ports.macports.org/port/openssh/ (The list may not be 100% accurate, so another grep for openssh inside the ports tree may not hurt.) On the website you can also check the list of open tickets: https://ports.macports.org/port/openssh/tickets We are not asking you to address any of those, but sometimes an update resolves an issue, or there's already an update request in the trac that can be closed. Mojca
Re: Updating OpenSSH port to 8.4p1
On Sep 30, 2020, at 1:55 PM, Blake Garner wrote: > I see that the port for OpenSSH has no maintainer and hasn't been updated in > a while. Reviewing the docs it looks reasonable for me to try and update the > port and submit it. Is anybody else already working on it? Advice for a > updating a port the first time beyond what's on the site? Updating the openssh port is easy if you only use the 'default' variants (I do that locally because I want to update sooner than MacPorts usually updates). Historically making the +hpn and +gsskex variants work has required effort. If you've got time+interest in making it work - please do so! -- Daniel J. Luke
Updating OpenSSH port to 8.4p1
I see that the port for OpenSSH has no maintainer and hasn't been updated in a while. Reviewing the docs it looks reasonable for me to try and update the port and submit it. Is anybody else already working on it? Advice for a updating a port the first time beyond what's on the site? Thanks, Blake
