Re: eigen

2014-03-31 Thread René J.V. Bertin

On Mar 21, 2014, at 19:38, René J.V. Bertin wrote:

 Have you contacted the developers of eigen about whether this change is 
 correct?
 
 No. But I'm planning to have a deeper look into this.

Took me a while but today I ran `make test` on the modified code, and that 
completed just fine.

R.
___
macports-users mailing list
macports-users@lists.macosforge.org
https://lists.macosforge.org/mailman/listinfo/macports-users


Re: eigen

2014-03-21 Thread René J.V. Bertin

On Mar 20, 2014, at 17:41, Nicolas Pavillon wrote:

 I may have expressed myself incorrectly, but the compatibility mode of eigen3 
 does not reduce the amount of options of calligra. provides full support, 
 apart from some modules which are not supported. It is thus a yes/no case, 
 where either you can use the compatibility mode if you are not using the 
 unsupported modules, or you have to adjust your code. 

Exactly, and that's not something I'm very much interested in testing in 
something that's not a stable release :)

Anyway, I figured out why eigen 2 doesn't build with clang. Apparently a C++ 
specialisation error in a single file. I'm not sure I understood it completely, 
but googling the error led me to a very simple solution that allows the build 
to complete (hopefully without introducing any regressions). A patch file and 
modified Portfile are attached to this message.

 [snip] but the applications I tested seemed functional enough. The suite is 
 well too complicated to assert if it's completely working, aside from what 
 the unit tests say…
 
 Well, if you get something which is working satisfyingly, I would encourage 
 you to attach your Portfile to the ticket #37579. Calligra is still not an 
 official port of Macports, so if there is something working, it would be nice 
 to have it committed. 

Heh, for the moment I don't have anything like a Portfile, neither for Calligra 
nor for the 2 or 3 dependencies I had to install outside of MacPorts ... but 
who knows. In any case I'll post an update when I think things are ripe. I hope 
the build process will be as standard as possible (and strive to get any 
adaptations accepted upstream) so making a Portfile ought to be easy enough for 
anyone accustomed to do so.

R.


patch-QrInstantiations.cpp.txt.diff
Description: Binary data



Portfile
Description: Binary data
___
macports-users mailing list
macports-users@lists.macosforge.org
https://lists.macosforge.org/mailman/listinfo/macports-users


Re: eigen

2014-03-21 Thread Ryan Schmidt
On Mar 21, 2014, at 08:05, René J.V. Bertin wrote:

 On Mar 20, 2014, at 17:41, Nicolas Pavillon wrote:
 
 I may have expressed myself incorrectly, but the compatibility mode of 
 eigen3 does not reduce the amount of options of calligra. provides full 
 support, apart from some modules which are not supported. It is thus a 
 yes/no case, where either you can use the compatibility mode if you are not 
 using the unsupported modules, or you have to adjust your code. 
 
 Exactly, and that's not something I'm very much interested in testing in 
 something that's not a stable release :)
 
 Anyway, I figured out why eigen 2 doesn't build with clang. Apparently a C++ 
 specialisation error in a single file. I'm not sure I understood it 
 completely, but googling the error led me to a very simple solution that 
 allows the build to complete (hopefully without introducing any regressions). 
 A patch file and modified Portfile are attached to this message.

Thanks. I submitted a ticket for this problem for you:

https://trac.macports.org/ticket/42969

I generated a unified diff of your Portfile changes, removing the lines you had 
commented out, and also converted your contextual diff to a unified one.

I can confirm that this now builds on Mavericks. However, I am not a C++ 
developer so I cannot say whether the change you have made is correct. How did 
you come to this solution? Have you contacted the developers of eigen about 
whether this change is correct?


___
macports-users mailing list
macports-users@lists.macosforge.org
https://lists.macosforge.org/mailman/listinfo/macports-users


Re: eigen

2014-03-21 Thread René J.V. Bertin
Hello Ryan,


On Mar 21, 2014, at 18:45, Ryan Schmidt wrote:

 I can confirm that this now builds on Mavericks. However, I am not a C++ 
 developer so I cannot say whether the change you have made is correct. How 
 did you come to this solution?

Here: 
http://stackoverflow.com/questions/767477/template-specialization-for-static-member-functions-howto

 Have you contacted the developers of eigen about whether this change is 
 correct?

No. But I'm planning to have a deeper look into this.

R.
___
macports-users mailing list
macports-users@lists.macosforge.org
https://lists.macosforge.org/mailman/listinfo/macports-users


Re: eigen

2014-03-20 Thread Nicolas Pavillon
Hello, 

 More generally, it is also possible to use eigen3 in compatibility mode, 
 which works for most modules. I could use this for example in Kstars to keep 
 to the port to build.
 
 I'll have a look at that, but I prefer to have the maximum of optional 
 components available. I started out trying to build without GLEW, but 
 realised rather quickly that the code hadn't been tested for a while in its 
 absence. And in fact, the only true issue I had until now was probably 
 introduced by (or was at least concurrent with) not building the gmic 
 extension for Krita.

I may have expressed myself incorrectly, but the compatibility mode of eigen3 
does not reduce the amount of options of calligra. It provides full support, 
apart from some modules which are not supported. It is thus a yes/no case, 
where either you can use the compatibility mode if you are not using the 
unsupported modules, or you have to adjust your code. 
For what I tested in the past with Calligra’s Portfile, it is possible to use 
the compatibility mode. 

 [snip] but the applications I tested seemed functional enough. The suite is 
 well too complicated to assert if it's completely working, aside from what 
 the unit tests say…

Well, if you get something which is working satisfyingly, I would encourage you 
to attach your Portfile to the ticket #37579. Calligra is still not an official 
port of Macports, so if there is something working, it would be nice to have it 
committed. 

Cheers, 

Nicolas
___
macports-users mailing list
macports-users@lists.macosforge.org
https://lists.macosforge.org/mailman/listinfo/macports-users


Re: eigen

2014-03-19 Thread René J . V . Bertin
Hello,

On Wednesday March 19 2014 09:00:50 you wrote:

  In fact, I'm more interested in eigen 2, required by Calligra …
 I do not remember the specific reason why eigen2 cannot build on Mavericks, 
 but in the case of calligra (which is not an official port, by the way, there 
 is only a tentative port in a ticket to my knowledge), eigen2 is an optional 
 dependency, not a required one. So if you are referring to the ticket #37579, 
 you can remove the dependency eigen2 and try to build in this way. But note 
 that there are other issues too. I looked a little bit at it some time ago, 
 but could not reach a completely working program to then commit the Portfile. 

I'm working on Calligra git/master (0.9.0 pre-alpha) following the official 
build instructions and product set, and until now I have been rather surprised 
at how well things worked. Of course I had to install a certain number of 
packages in /opt/local, as well as tweak a cmake file or two, only about 70% of 
the unit tests succeeded, but the applications I tested seemed functional 
enough. The suite is well too complicated to assert if it's completely 
working, aside from what the unit tests say...

 More generally, it is also possible to use eigen3 in compatibility mode, 
 which works for most modules. I could use this for example in Kstars to keep 
 to the port to build.

I'll have a look at that, but I prefer to have the maximum of optional 
components available. I started out trying to build without GLEW, but realised 
rather quickly that the code hadn't been tested for a while in its absence. And 
in fact, the only true issue I had until now was probably introduced by (or was 
at least concurrent with) not building the gmic extension for Krita.

R.
___
macports-users mailing list
macports-users@lists.macosforge.org
https://lists.macosforge.org/mailman/listinfo/macports-users