Re: [Mageia-dev] Help needed: rpmlint checks not working
'Twas brillig, and Pascal Terjan at 15/01/13 18:34 did gyre and gimble: On Tue, Jan 15, 2013 at 6:21 PM, Thierry Vignaud Well no. No as in it may be possible that some updates upload will break due to some error now being detected and rejected. Could we script a pass on all packages with that rpmlint config to catch any such packages and fix them? Well the first commit certainly applied to updates (and I queried as much), but I think the second commit means it only applies to cauldron, not any updates to mga2 etc. My point is we just added to _CAULDRON_ == mga3 a lot of rules that were missed, just after mass rebuild, and I fear that when we'll try to issue updates to _mga3_, we may see some being rejected, this is why I ask we check current cauldron with upload server rpmlint config... The options used to apply to all versions They were copied to cauldron specific rules and those ones removed from the default rules That's what I took from it too. Those copied rules used to apply to everything, but because of the extra rules I wanted for cauldron only, all the other rules were copied to a cauldron specific list. It doesn't mean they are all new. At least that was my assumption of it all - no idea of the implementation! Col -- Colin Guthrie colin(at)mageia.org http://colin.guthr.ie/ Day Job: Tribalogic Limited http://www.tribalogic.net/ Open Source: Mageia Contributor http://www.mageia.org/ PulseAudio Hacker http://www.pulseaudio.org/ Trac Hacker http://trac.edgewall.org/
Re: [Mageia-dev] Help needed: rpmlint checks not working
'Twas brillig, and Olivier Blin at 15/01/13 22:49 did gyre and gimble: nicolas vigier bo...@mars-attacks.org writes: The file distribution.error.list from rpmlint-mageia-policy is not used by the buildsystem to reject uploads. Instead it is using a list of rpmlint errors defined in youri configuration. I added them now : http://svnweb.mageia.org/adm/puppet/modules/buildsystem/templates/youri/submit-upload.conf?r1=2928r2=2963 Maybe we could change it to use distribution.error.list file instead. [...] This should now be fixed. http://svnweb.mageia.org/adm/puppet/modules/buildsystem/templates/youri/submit-upload.conf?r1=2963r2=2967 This is still an hardcoded list that does not reflect the default Mageia policy from rpmlint-mageia-policy, and this is quite a maintenance burden. Why don't we use rules from these packages directly? If needed, we could maybe have setup per-distro extraction of rpmlint policy on upload of the rpmlint-mageia-policy package. That certainly sounds like a nice idea and a good way to keep things simple for packagers. Col -- Colin Guthrie colin(at)mageia.org http://colin.guthr.ie/ Day Job: Tribalogic Limited http://www.tribalogic.net/ Open Source: Mageia Contributor http://www.mageia.org/ PulseAudio Hacker http://www.pulseaudio.org/ Trac Hacker http://trac.edgewall.org/
Re: [Mageia-dev] Help needed: rpmlint checks not working
'Twas brillig, and Colin Guthrie at 13/01/13 13:26 did gyre and gimble: 'Twas brillig, and AL13N at 12/01/13 21:42 did gyre and gimble: Op zaterdag 12 januari 2013 22:24:35 schreef AL13N: Op zaterdag 12 januari 2013 16:43:09 schreef Colin Guthrie: [..] There are currently ~70 ish packages to fix. I'll fix them up, but help is welcome :) [...] Then there are the udev rules :) [...] I will do all of these but as I've said already, people are more than welcome to fix some up :D Col i'll try and fix xen for both it seems for xen, it doesn't seem so standard. fedora ghosted those 3, so i did that too. Ghosting achieves very little in this case. Does xen automatically create those directories happily without the need for tmpfiles? If so I'd personally not package them at all (as it just continues to show up in the list generated by the urpmf command listed earlier as a false positive). Seems fedora also added tmpfiles support as well as ghosting - I've now fixed that up in the xen package. http://svnweb.mageia.org/packages?view=revisionrevision=388627 I also dropped the ghosting. At least for now I don't see how it creates any significant advantage that is worth the overhead. So, question. Does xen actually work? There appears to be no tmpfiles in it and thus I don't see what creates those folders unless xen does it internally (i.e. like gdm does). Can you confirm it's OK without tmpfiles and I'll manually filter it out of my urpmf command. If you also feel there is no real point in ghosting here specifically and not in any of the other packages, please do remove the ghosts as it'll save that manual filtering. So this was apparently broken (as per TV's tests at least). As mentioned above, I've now added the tmpfiles snippets to create those folders. Fingers crossed that fixes it :) Cheers Col -- Colin Guthrie colin(at)mageia.org http://colin.guthr.ie/ Day Job: Tribalogic Limited http://www.tribalogic.net/ Open Source: Mageia Contributor http://www.mageia.org/ PulseAudio Hacker http://www.pulseaudio.org/ Trac Hacker http://trac.edgewall.org/
Re: [Mageia-dev] Help needed: rpmlint checks not working
On Mon, 14 Jan 2013, nicolas vigier wrote: On Sat, 12 Jan 2013, Colin Guthrie wrote: 'Twas brillig, and nicolas vigier at 12/01/13 15:45 did gyre and gimble: On Sat, 12 Jan 2013, Colin Guthrie wrote: Hi, It seems the rpmlint checks I added to detect (and prevent upload of) files in /var/run and in /etc/udev/rules.d etc. are not working. Can someone see if I've done something wrong? The file distribution.error.list from rpmlint-mageia-policy is not used by the buildsystem to reject uploads. Instead it is using a list of rpmlint errors defined in youri configuration. I added them now : http://svnweb.mageia.org/adm/puppet/modules/buildsystem/templates/youri/submit-upload.conf?r1=2928r2=2963 Maybe we could change it to use distribution.error.list file instead. Awesome, thanks. Will this affect mga2 builds too? It shouldn't there so hopefully there is no conflict :) Hmm, actually it probably applies to Mageia 2 builds too. I will try to change this. This should now be fixed. http://svnweb.mageia.org/adm/puppet/modules/buildsystem/templates/youri/submit-upload.conf?r1=2963r2=2967
Re: [Mageia-dev] Help needed: rpmlint checks not working
'Twas brillig, and nicolas vigier at 15/01/13 10:57 did gyre and gimble: Awesome, thanks. Will this affect mga2 builds too? It shouldn't there so hopefully there is no conflict :) Hmm, actually it probably applies to Mageia 2 builds too. I will try to change this. This should now be fixed. http://svnweb.mageia.org/adm/puppet/modules/buildsystem/templates/youri/submit-upload.conf?r1=2963r2=2967 Lovely. Thank you :) Col -- Colin Guthrie colin(at)mageia.org http://colin.guthr.ie/ Day Job: Tribalogic Limited http://www.tribalogic.net/ Open Source: Mageia Contributor http://www.mageia.org/ PulseAudio Hacker http://www.pulseaudio.org/ Trac Hacker http://trac.edgewall.org/
Re: [Mageia-dev] Help needed: rpmlint checks not working
On 15 January 2013 11:57, nicolas vigier bo...@mars-attacks.org wrote: Awesome, thanks. Will this affect mga2 builds too? It shouldn't there so hopefully there is no conflict :) Hmm, actually it probably applies to Mageia 2 builds too. I will try to change this. This should now be fixed. http://svnweb.mageia.org/adm/puppet/modules/buildsystem/templates/youri/submit-upload.conf?r1=2963r2=2967 Isn't that commit showing we didn't rejected some packages which should have been due to missing rules?
Re: [Mageia-dev] Help needed: rpmlint checks not working
On Tue, 15 Jan 2013, Thierry Vignaud wrote: On 15 January 2013 11:57, nicolas vigier bo...@mars-attacks.org wrote: Awesome, thanks. Will this affect mga2 builds too? It shouldn't there so hopefully there is no conflict :) Hmm, actually it probably applies to Mageia 2 builds too. I will try to change this. This should now be fixed. http://svnweb.mageia.org/adm/puppet/modules/buildsystem/templates/youri/submit-upload.conf?r1=2963r2=2967 Isn't that commit showing we didn't rejected some packages which should have been due to missing rules? Yes, we didn't reject some packages which should have been. Until this commit : http://svnweb.mageia.org/adm/puppet/modules/buildsystem/templates/youri/submit-upload.conf?r1=2928r2=2963 But after this one we were rejecting too much on Mageia 2. Now it should be ok on Cauldron and Mageia 2.
Re: [Mageia-dev] Help needed: rpmlint checks not working
On 15 January 2013 19:00, nicolas vigier bo...@mars-attacks.org wrote: Will this affect mga2 builds too? It shouldn't there so hopefully there is no conflict :) Hmm, actually it probably applies to Mageia 2 builds too. I will try to change this. This should now be fixed. http://svnweb.mageia.org/adm/puppet/modules/buildsystem/templates/youri/submit-upload.conf?r1=2963r2=2967 Isn't that commit showing we didn't rejected some packages which should have been due to missing rules? Yes, we didn't reject some packages which should have been. Until this commit : http://svnweb.mageia.org/adm/puppet/modules/buildsystem/templates/youri/submit-upload.conf?r1=2928r2=2963 But after this one we were rejecting too much on Mageia 2. Now it should be ok on Cauldron and Mageia 2. Well no. No as in it may be possible that some updates upload will break due to some error now being detected and rejected. Could we script a pass on all packages with that rpmlint config to catch any such packages and fix them?
Re: [Mageia-dev] Help needed: rpmlint checks not working
'Twas brillig, and nicolas vigier at 15/01/13 18:00 did gyre and gimble: On Tue, 15 Jan 2013, Thierry Vignaud wrote: This should now be fixed. http://svnweb.mageia.org/adm/puppet/modules/buildsystem/templates/youri/submit-upload.conf?r1=2963r2=2967 Isn't that commit showing we didn't rejected some packages which should have been due to missing rules? Yes, we didn't reject some packages which should have been. Until this commit : http://svnweb.mageia.org/adm/puppet/modules/buildsystem/templates/youri/submit-upload.conf?r1=2928r2=2963 But after this one we were rejecting too much on Mageia 2. Now it should be ok on Cauldron and Mageia 2. For packages affected by the rules I added, I use the following commands to get the affected packages (now mercifully small!): urpmf ^(/var)?/(run|lock)/ | sort -u run-lock.txt urpmf ^/etc/udev/rules.d/ | sort -u udev.txt urpmf ^/etc/tmpfiles.d/ | sort -u tmpfiles.txt urpmf ^/etc/systemd/system/ | sort -u units.txt The first two show 21 (ignoring xen) and 19 respectively. The last two commands both show no affected packages \o/ So not too much to fix up :) Col -- Colin Guthrie colin(at)mageia.org http://colin.guthr.ie/ Day Job: Tribalogic Limited http://www.tribalogic.net/ Open Source: Mageia Contributor http://www.mageia.org/ PulseAudio Hacker http://www.pulseaudio.org/ Trac Hacker http://trac.edgewall.org/
Re: [Mageia-dev] Help needed: rpmlint checks not working
On 15 January 2013 19:15, Colin Guthrie mag...@colin.guthr.ie wrote: http://svnweb.mageia.org/adm/puppet/modules/buildsystem/templates/youri/submit-upload.conf?r1=2963r2=2967 Isn't that commit showing we didn't rejected some packages which should have been due to missing rules? Yes, we didn't reject some packages which should have been. Until this commit : http://svnweb.mageia.org/adm/puppet/modules/buildsystem/templates/youri/submit-upload.conf?r1=2928r2=2963 But after this one we were rejecting too much on Mageia 2. Now it should be ok on Cauldron and Mageia 2. For packages affected by the rules I added, I use the following commands to get the affected packages (now mercifully small!): urpmf ^(/var)?/(run|lock)/ | sort -u run-lock.txt urpmf ^/etc/udev/rules.d/ | sort -u udev.txt urpmf ^/etc/tmpfiles.d/ | sort -u tmpfiles.txt urpmf ^/etc/systemd/system/ | sort -u units.txt The first two show 21 (ignoring xen) and 19 respectively. The last two commands both show no affected packages \o/ So not too much to fix up :) err, just look at all the rules that were added (copied from mga2)...
Re: [Mageia-dev] Help needed: rpmlint checks not working
'Twas brillig, and Thierry Vignaud at 15/01/13 18:09 did gyre and gimble: On 15 January 2013 19:00, nicolas vigier bo...@mars-attacks.org wrote: Will this affect mga2 builds too? It shouldn't there so hopefully there is no conflict :) Hmm, actually it probably applies to Mageia 2 builds too. I will try to change this. This should now be fixed. http://svnweb.mageia.org/adm/puppet/modules/buildsystem/templates/youri/submit-upload.conf?r1=2963r2=2967 Isn't that commit showing we didn't rejected some packages which should have been due to missing rules? Yes, we didn't reject some packages which should have been. Until this commit : http://svnweb.mageia.org/adm/puppet/modules/buildsystem/templates/youri/submit-upload.conf?r1=2928r2=2963 But after this one we were rejecting too much on Mageia 2. Now it should be ok on Cauldron and Mageia 2. Well no. No as in it may be possible that some updates upload will break due to some error now being detected and rejected. Could we script a pass on all packages with that rpmlint config to catch any such packages and fix them? Well the first commit certainly applied to updates (and I queried as much), but I think the second commit means it only applies to cauldron, not any updates to mga2 etc. Col -- Colin Guthrie colin(at)mageia.org http://colin.guthr.ie/ Day Job: Tribalogic Limited http://www.tribalogic.net/ Open Source: Mageia Contributor http://www.mageia.org/ PulseAudio Hacker http://www.pulseaudio.org/ Trac Hacker http://trac.edgewall.org/
Re: [Mageia-dev] Help needed: rpmlint checks not working
On 15 January 2013 19:17, Colin Guthrie mag...@colin.guthr.ie wrote: Will this affect mga2 builds too? It shouldn't there so hopefully there is no conflict :) Hmm, actually it probably applies to Mageia 2 builds too. I will try to change this. This should now be fixed. http://svnweb.mageia.org/adm/puppet/modules/buildsystem/templates/youri/submit-upload.conf?r1=2963r2=2967 Isn't that commit showing we didn't rejected some packages which should have been due to missing rules? Yes, we didn't reject some packages which should have been. Until this commit : http://svnweb.mageia.org/adm/puppet/modules/buildsystem/templates/youri/submit-upload.conf?r1=2928r2=2963 But after this one we were rejecting too much on Mageia 2. Now it should be ok on Cauldron and Mageia 2. Well no. No as in it may be possible that some updates upload will break due to some error now being detected and rejected. Could we script a pass on all packages with that rpmlint config to catch any such packages and fix them? Well the first commit certainly applied to updates (and I queried as much), but I think the second commit means it only applies to cauldron, not any updates to mga2 etc. My point is we just added to _CAULDRON_ == mga3 a lot of rules that were missed, just after mass rebuild, and I fear that when we'll try to issue updates to _mga3_, we may see some being rejected, this is why I ask we check current cauldron with upload server rpmlint config...
Re: [Mageia-dev] Help needed: rpmlint checks not working
On Tue, Jan 15, 2013 at 6:21 PM, Thierry Vignaud thierry.vign...@gmail.com wrote: On 15 January 2013 19:17, Colin Guthrie mag...@colin.guthr.ie wrote: Will this affect mga2 builds too? It shouldn't there so hopefully there is no conflict :) Hmm, actually it probably applies to Mageia 2 builds too. I will try to change this. This should now be fixed. http://svnweb.mageia.org/adm/puppet/modules/buildsystem/templates/youri/submit-upload.conf?r1=2963r2=2967 Isn't that commit showing we didn't rejected some packages which should have been due to missing rules? Yes, we didn't reject some packages which should have been. Until this commit : http://svnweb.mageia.org/adm/puppet/modules/buildsystem/templates/youri/submit-upload.conf?r1=2928r2=2963 But after this one we were rejecting too much on Mageia 2. Now it should be ok on Cauldron and Mageia 2. Well no. No as in it may be possible that some updates upload will break due to some error now being detected and rejected. Could we script a pass on all packages with that rpmlint config to catch any such packages and fix them? Well the first commit certainly applied to updates (and I queried as much), but I think the second commit means it only applies to cauldron, not any updates to mga2 etc. My point is we just added to _CAULDRON_ == mga3 a lot of rules that were missed, just after mass rebuild, and I fear that when we'll try to issue updates to _mga3_, we may see some being rejected, this is why I ask we check current cauldron with upload server rpmlint config... The options used to apply to all versions They were copied to cauldron specific rules and those ones removed from the default rules
Re: [Mageia-dev] Help needed: rpmlint checks not working
Thierry Vignaud thierry.vign...@gmail.com writes: My point is we just added to _CAULDRON_ == mga3 a lot of rules that were missed, just after mass rebuild, and I fear that when we'll try to issue updates to _mga3_, we may see some being rejected, this is why I ask we check current cauldron with upload server rpmlint config... Right, we need to schedule a new mass rebuild, to check packages against the real rpmlint rules. -- Olivier Blin - blino
Re: [Mageia-dev] Help needed: rpmlint checks not working
nicolas vigier bo...@mars-attacks.org writes: The file distribution.error.list from rpmlint-mageia-policy is not used by the buildsystem to reject uploads. Instead it is using a list of rpmlint errors defined in youri configuration. I added them now : http://svnweb.mageia.org/adm/puppet/modules/buildsystem/templates/youri/submit-upload.conf?r1=2928r2=2963 Maybe we could change it to use distribution.error.list file instead. [...] This should now be fixed. http://svnweb.mageia.org/adm/puppet/modules/buildsystem/templates/youri/submit-upload.conf?r1=2963r2=2967 This is still an hardcoded list that does not reflect the default Mageia policy from rpmlint-mageia-policy, and this is quite a maintenance burden. Why don't we use rules from these packages directly? If needed, we could maybe have setup per-distro extraction of rpmlint policy on upload of the rpmlint-mageia-policy package. -- Olivier Blin - blino
Re: [Mageia-dev] Help needed: rpmlint checks not working
On Sat, 12 Jan 2013, Colin Guthrie wrote: 'Twas brillig, and nicolas vigier at 12/01/13 15:45 did gyre and gimble: On Sat, 12 Jan 2013, Colin Guthrie wrote: Hi, It seems the rpmlint checks I added to detect (and prevent upload of) files in /var/run and in /etc/udev/rules.d etc. are not working. Can someone see if I've done something wrong? The file distribution.error.list from rpmlint-mageia-policy is not used by the buildsystem to reject uploads. Instead it is using a list of rpmlint errors defined in youri configuration. I added them now : http://svnweb.mageia.org/adm/puppet/modules/buildsystem/templates/youri/submit-upload.conf?r1=2928r2=2963 Maybe we could change it to use distribution.error.list file instead. Awesome, thanks. Will this affect mga2 builds too? It shouldn't there so hopefully there is no conflict :) Hmm, actually it probably applies to Mageia 2 builds too. I will try to change this.
Re: [Mageia-dev] Help needed: rpmlint checks not working
'Twas brillig, and AL13N at 12/01/13 21:42 did gyre and gimble: Op zaterdag 12 januari 2013 22:24:35 schreef AL13N: Op zaterdag 12 januari 2013 16:43:09 schreef Colin Guthrie: [..] There are currently ~70 ish packages to fix. I'll fix them up, but help is welcome :) [...] Then there are the udev rules :) [...] I will do all of these but as I've said already, people are more than welcome to fix some up :D Col i'll try and fix xen for both it seems for xen, it doesn't seem so standard. fedora ghosted those 3, so i did that too. Ghosting achieves very little in this case. Does xen automatically create those directories happily without the need for tmpfiles? If so I'd personally not package them at all (as it just continues to show up in the list generated by the urpmf command listed earlier as a false positive). While ghosting does have the advantage that rpm -qf will return sort of valid results, it does make this transition period more difficult as it would mean our list of packages would never get smaller. I'm also not totally convinced that the rpm -qf use case is benefitial enough to keep package %files+%ghosts synced with tmpfiles contents, especially as the tmpfiles become part of the upstream package. If it could somehow become automated (i.e. via a packaging script) then I'd be happy to support that. So, question. Does xen actually work? There appears to be no tmpfiles in it and thus I don't see what creates those folders unless xen does it internally (i.e. like gdm does). Can you confirm it's OK without tmpfiles and I'll manually filter it out of my urpmf command. If you also feel there is no real point in ghosting here specifically and not in any of the other packages, please do remove the ghosts as it'll save that manual filtering. no idea what to do with the udev parts, what is wrong with it? Nothing crazy. They just shouldn't be in /etc they should be in %_udevrulesdir when shipping in a package (and not be %config). Cheers Col -- Colin Guthrie colin(at)mageia.org http://colin.guthr.ie/ Day Job: Tribalogic Limited http://www.tribalogic.net/ Open Source: Mageia Contributor http://www.mageia.org/ PulseAudio Hacker http://www.pulseaudio.org/ Trac Hacker http://trac.edgewall.org/
Re: [Mageia-dev] Help needed: rpmlint checks not working
'Twas brillig, and Colin Guthrie at 13/01/13 13:26 did gyre and gimble: 'Twas brillig, and AL13N at 12/01/13 21:42 did gyre and gimble: Op zaterdag 12 januari 2013 22:24:35 schreef AL13N: Op zaterdag 12 januari 2013 16:43:09 schreef Colin Guthrie: [..] There are currently ~70 ish packages to fix. I'll fix them up, but help is welcome :) [...] Then there are the udev rules :) [...] I will do all of these but as I've said already, people are more than welcome to fix some up :D Col i'll try and fix xen for both it seems for xen, it doesn't seem so standard. fedora ghosted those 3, so i did that too. Ghosting achieves very little in this case. Does xen automatically create those directories happily without the need for tmpfiles? If so I'd personally not package them at all (as it just continues to show up in the list generated by the urpmf command listed earlier as a false positive). Hmm, actually no, I think I must be wrong here... seems ghosted files don't show up in urpmf... So I guess there is no harm in leaving the %ghosts, but I still say it'll be an annoying packaging overhead to keep it in sync with either tmpfiles or internal application logic. Col -- Colin Guthrie colin(at)mageia.org http://colin.guthr.ie/ Day Job: Tribalogic Limited http://www.tribalogic.net/ Open Source: Mageia Contributor http://www.mageia.org/ PulseAudio Hacker http://www.pulseaudio.org/ Trac Hacker http://trac.edgewall.org/
Re: [Mageia-dev] Help needed: rpmlint checks not working
Op zondag 13 januari 2013 13:26:51 schreef Colin Guthrie: [...] Ghosting achieves very little in this case. Does xen automatically create those directories happily without the need for tmpfiles? If so I'd personally not package them at all (as it just continues to show up in the list generated by the urpmf command listed earlier as a false positive). While ghosting does have the advantage that rpm -qf will return sort of valid results, it does make this transition period more difficult as it would mean our list of packages would never get smaller. I'm also not totally convinced that the rpm -qf use case is benefitial enough to keep package %files+%ghosts synced with tmpfiles contents, especially as the tmpfiles become part of the upstream package. If it could somehow become automated (i.e. via a packaging script) then I'd be happy to support that. So, question. Does xen actually work? There appears to be no tmpfiles in it and thus I don't see what creates those folders unless xen does it internally (i.e. like gdm does). Can you confirm it's OK without tmpfiles and I'll manually filter it out of my urpmf command. If you also feel there is no real point in ghosting here specifically and not in any of the other packages, please do remove the ghosts as it'll save that manual filtering. thanks, i'll take this under advisement
[Mageia-dev] Help needed: rpmlint checks not working
Hi, It seems the rpmlint checks I added to detect (and prevent upload of) files in /var/run and in /etc/udev/rules.d etc. are not working. Can someone see if I've done something wrong? I was able to push through a version of proftpd that shipped a dir /var/run/proftpd. It shouldn't have been allowed by my reckoning. I would have preferred to get this working before mass rebuild, but I can do manual checks with urpmf to fix any problems so it's not the end of the world. Col -- Colin Guthrie colin(at)mageia.org http://colin.guthr.ie/ Day Job: Tribalogic Limited http://www.tribalogic.net/ Open Source: Mageia Contributor http://www.mageia.org/ PulseAudio Hacker http://www.pulseaudio.org/ Trac Hacker http://trac.edgewall.org/
Re: [Mageia-dev] Help needed: rpmlint checks not working
On Sat, 12 Jan 2013, Colin Guthrie wrote: Hi, It seems the rpmlint checks I added to detect (and prevent upload of) files in /var/run and in /etc/udev/rules.d etc. are not working. Can someone see if I've done something wrong? The file distribution.error.list from rpmlint-mageia-policy is not used by the buildsystem to reject uploads. Instead it is using a list of rpmlint errors defined in youri configuration. I added them now : http://svnweb.mageia.org/adm/puppet/modules/buildsystem/templates/youri/submit-upload.conf?r1=2928r2=2963 Maybe we could change it to use distribution.error.list file instead.
Re: [Mageia-dev] Help needed: rpmlint checks not working
'Twas brillig, and nicolas vigier at 12/01/13 15:45 did gyre and gimble: On Sat, 12 Jan 2013, Colin Guthrie wrote: Hi, It seems the rpmlint checks I added to detect (and prevent upload of) files in /var/run and in /etc/udev/rules.d etc. are not working. Can someone see if I've done something wrong? The file distribution.error.list from rpmlint-mageia-policy is not used by the buildsystem to reject uploads. Instead it is using a list of rpmlint errors defined in youri configuration. I added them now : http://svnweb.mageia.org/adm/puppet/modules/buildsystem/templates/youri/submit-upload.conf?r1=2928r2=2963 Maybe we could change it to use distribution.error.list file instead. Awesome, thanks. Will this affect mga2 builds too? It shouldn't there so hopefully there is no conflict :) Col -- Colin Guthrie colin(at)mageia.org http://colin.guthr.ie/ Day Job: Tribalogic Limited http://www.tribalogic.net/ Open Source: Mageia Contributor http://www.mageia.org/ PulseAudio Hacker http://www.pulseaudio.org/ Trac Hacker http://trac.edgewall.org/
Re: [Mageia-dev] Help needed: rpmlint checks not working
On 12 January 2013 16:45, nicolas vigier bo...@mars-attacks.org wrote: It seems the rpmlint checks I added to detect (and prevent upload of) files in /var/run and in /etc/udev/rules.d etc. are not working. Can someone see if I've done something wrong? The file distribution.error.list from rpmlint-mageia-policy is not used by the buildsystem to reject uploads. Instead it is using a list of rpmlint errors defined in youri configuration. I added them now : http://svnweb.mageia.org/adm/puppet/modules/buildsystem/templates/youri/submit-upload.conf?r1=2928r2=2963 Maybe we could change it to use distribution.error.list file instead. We've a couple packages to fix. eg: https://bugs.mageia.org/show_bug.cgi?id=8672 188/241: gkrellm # error: unpacking of archive failed on file /var/lock/gkrellm: cpio: mkdir failed - Inappropriate ioctl for device error: gkrellm-2.3.5-6.mga3.x86_64: install failed urpmf /var/lock|sort -u reports filesystem:/var/lock gkrellm:/var/lock/gkrellm gnokii:/var/lock/gnokii leafnode:/var/lock/news rear:/usr/share/rear/skel/default/var/lock rear:/usr/share/rear/skel/default/var/lock/lockdev rear:/usr/share/rear/skel/default/var/lock/lockdev/.gitignore rear:/usr/share/rear/skel/default/var/lock/lvm rear:/usr/share/rear/skel/default/var/lock/lvm/.gitignore rear:/usr/share/rear/skel/default/var/lock/subsys rear:/usr/share/rear/skel/default/var/lock/subsys/.gitignore uucp:/var/lock/uucp vtun:/var/lock/vtund Some are probably already %ghost but some are not (such as rear obviously) and are breaking some builds
Re: [Mageia-dev] Help needed: rpmlint checks not working
On Saturday 12. January 2013 17.43, Colin Guthrie wrote:
I will do all of these but as I've said already, people are more than
welcome to fix some up :D
As I'm the maintainer of radvd I can try and fix that one. :-)=
But just so I understand this: We should replace e.g
«%{buildroot}%{_localstatedir}/run/blahblah»
with «%{buildroot}/run/blahblah» ?
Or is there another rpm variable I should use?
--
Johnny A. Solbu
PGP key ID: 0xFA687324
signature.asc
Description: This is a digitally signed message part.
Re: [Mageia-dev] Help needed: rpmlint checks not working
'Twas brillig, and Johnny A. Solbu at 12/01/13 17:29 did gyre and gimble:
On Saturday 12. January 2013 17.43, Colin Guthrie wrote:
I will do all of these but as I've said already, people are more than
welcome to fix some up :D
As I'm the maintainer of radvd I can try and fix that one. :-)=
But just so I understand this: We should replace e.g
«%{buildroot}%{_localstatedir}/run/blahblah»
with «%{buildroot}/run/blahblah» ?
Or is there another rpm variable I should use?
https://wiki.mageia.org/en/System_Service_policy
:)
Col
--
Colin Guthrie
colin(at)mageia.org
http://colin.guthr.ie/
Day Job:
Tribalogic Limited http://www.tribalogic.net/
Open Source:
Mageia Contributor http://www.mageia.org/
PulseAudio Hacker http://www.pulseaudio.org/
Trac Hacker http://trac.edgewall.org/
Re: [Mageia-dev] Help needed: rpmlint checks not working
Op zaterdag 12 januari 2013 16:43:09 schreef Colin Guthrie: [..] There are currently ~70 ish packages to fix. I'll fix them up, but help is welcome :) [...] Then there are the udev rules :) [...] I will do all of these but as I've said already, people are more than welcome to fix some up :D Col i'll try and fix xen for both
Re: [Mageia-dev] Help needed: rpmlint checks not working
Op zaterdag 12 januari 2013 18:20:25 schreef Colin Guthrie:
'Twas brillig, and Johnny A. Solbu at 12/01/13 17:29 did gyre and gimble:
On Saturday 12. January 2013 17.43, Colin Guthrie wrote:
I will do all of these but as I've said already, people are more than
welcome to fix some up :D
As I'm the maintainer of radvd I can try and fix that one. :-)=
But just so I understand this: We should replace e.g
«%{buildroot}%{_localstatedir}/run/blahblah» with
«%{buildroot}/run/blahblah» ?
Or is there another rpm variable I should use?
https://wiki.mageia.org/en/System_Service_policy
:)
Col
what wiki page deals with the udev part?
Re: [Mageia-dev] Help needed: rpmlint checks not working
Op zaterdag 12 januari 2013 22:24:35 schreef AL13N: Op zaterdag 12 januari 2013 16:43:09 schreef Colin Guthrie: [..] There are currently ~70 ish packages to fix. I'll fix them up, but help is welcome :) [...] Then there are the udev rules :) [...] I will do all of these but as I've said already, people are more than welcome to fix some up :D Col i'll try and fix xen for both it seems for xen, it doesn't seem so standard. fedora ghosted those 3, so i did that too. no idea what to do with the udev parts, what is wrong with it?
