[Mahara-contributors] [Bug 1455265] Re: TinyMCE "full screen" button doesn't work in block config

2015-05-14 Thread Aaron Wells
After a little experimentation, it looks like the problem is in the
".blockinstance.configure.vertcentre" CSS class. If you remove this line
from that class, then the fullscreen button works again, in FF and
Chromium.

   transform: translate( 50%, 50%);

I haven't tested it in IE yet, but there's an "-ms-transform" line in
that same class, which probably does the same thing in IE.

However, just removing this style isn't the fix, because if you take
this away, then when TinyMCE is not in full screen, the block config is
off-center. The way that CSS block works, it uses "top" and "left" to
position the top-left corner of the block in the middle of the screen,
then it uses "transform" to shift the block itself to the middle.

So, we either need to find some other CSS that will achieve the same
thing without interfering with the TinyMCE fullscreen button, or we need
to patch the TinyMCE fullscreen button to disable this particular style.

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1455265

Title:
  TinyMCE "full screen" button doesn't work in block config

Status in Mahara ePortfolio:
  Confirmed
Status in Mahara 15.04 series:
  Confirmed
Status in Mahara 15.10 series:
  Confirmed

Bug description:
  Mahara 1504

  It appears that the fullscreen is not fullscreen in 1504. I tried on a
  couple instances, including master.dev.mahara.org and various
  browsers. Adding screenshot also

  To replicate:

  1. Create a page
  2. Go to the "Edit Content" tab
  3. Put a text block onto the page
  4. Click the "Toggle toolbars" button on TinyMCE to expose the fullscreen 
button (it's on the right end of the second row of buttons)
  5. Click the "Fullscreen" button

  Expected result:
  TinyMCE goes to full screen (fills the whole browser window)

  Actual result:
  TinyMCE only fills the block config iframe. This actually makes it *smaller* 
than before.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1455265/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1374163] Re: List of shared pages to a group not taking account of access date

2015-05-14 Thread Aaron Wells
In implementing this I noticed that at some point we added code to the
get_sharedviews_data() method that checks the start and end date for the
group's view_access record. But, we were still missing code to check the
overriding start and end date (which is stored in view.startdate and
view.enddate). We also had no code to check for collections to check for
any of the start and end dates.

My patch fixes all of these scenarios. So, to test this patch fully,
you'll need to create and share pages and collections with a group, with
future start dates and past end dates, on both the group access line and
the total page access line. In all there are 8 permutations, plus it's
good to add another 2 without start and end dates to make sure they
still show up.

1. Create Group Z

2. Create these pages, and share them with the Group Z. (In order to
create past end dates, the easiest thing is to set an end date 1 day in
the future, then move your system clock forward 1 week. This is
obviously not possible in Behat, so for automated testing we can just
skip testing the past end dates. Or do a direct database update.)

- Page 1: future start date on group access
- Page 2: past end date on group access
- Page 3: future start date on total page access
- Page 4: past end date on total page access
- Page 5: no start/end date
- Collection 1: future start date on group access
- Collection 2: past end date on group access
- Collection 3: future start date on total page access
- Collection 4: past end date on total page access
- Collection 5: no start/end date

3. Make sure Group Z's homepages has a "Group Pages" block on it, and
that it is set to display pages and collections shared with the group.

4. View Group Z's homepage

Expected Result: You should only see Page 5 and Collection 5.

Actual Result: You see Pages 3, 4, and 5, and Collections 1, 2, 3, 4,
and 5.

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1374163

Title:
  List of shared pages to a group not taking account of access date

Status in Mahara ePortfolio:
  In Progress
Status in Mahara 1.10 series:
  Won't Fix
Status in Mahara 1.8 series:
  Won't Fix
Status in Mahara 1.9 series:
  Won't Fix
Status in Mahara 15.04 series:
  In Progress
Status in Mahara 15.10 series:
  In Progress

Bug description:
  Version: master(1.10) and previous version
  Browser, platform: any

  When I clicked a shared page in the  list of shared pages in the group 
homepage (htdocs/group/view.php), I got "Access denied" message.
  Steps

  1. Login as user A, create a page, share the page to a group Z
  2. Set the  'Overriding start date' to a future date
  3. Login as a member of group Z
  4. In the group Z homepage, click the page shared by the user A
  You will see the "Access denied" message.

  Expected result: The page shared by the user A to the group Z should
  not be displayed in the list until the date set by  'Overriding start
  date'

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1374163/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1374163] Re: List of shared pages to a group not taking account of access date

2015-05-14 Thread Aaron Wells
I've pushed a patch up to gerrit. We made a lot of changes in the Group
Pages block in 15.04, so this patch won't cherry-pick cleanly to 1.10
and earlier. So I'm marking those branches "Won't Fix" because this is
only a medium bug.

Keeping the priority at medium, because I don't think access start and
end dates are a heavily-used feature. But nonetheless this would be a
good bug to fix in 15.04.1, because it does lead to a visible error
message for the user.

** Changed in: mahara/1.9
   Status: Confirmed => Won't Fix

** Changed in: mahara/1.10
   Status: Confirmed => Won't Fix

** Changed in: mahara/15.10
   Status: Confirmed => In Progress

** Changed in: mahara/15.04
   Status: Confirmed => In Progress

** Changed in: mahara/15.04
 Assignee: (unassigned) => Aaron Wells (u-aaronw)

** Changed in: mahara/15.10
 Assignee: (unassigned) => Aaron Wells (u-aaronw)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1374163

Title:
  List of shared pages to a group not taking account of access date

Status in Mahara ePortfolio:
  In Progress
Status in Mahara 1.10 series:
  Won't Fix
Status in Mahara 1.8 series:
  Won't Fix
Status in Mahara 1.9 series:
  Won't Fix
Status in Mahara 15.04 series:
  In Progress
Status in Mahara 15.10 series:
  In Progress

Bug description:
  Version: master(1.10) and previous version
  Browser, platform: any

  When I clicked a shared page in the  list of shared pages in the group 
homepage (htdocs/group/view.php), I got "Access denied" message.
  Steps

  1. Login as user A, create a page, share the page to a group Z
  2. Set the  'Overriding start date' to a future date
  3. Login as a member of group Z
  4. In the group Z homepage, click the page shared by the user A
  You will see the "Access denied" message.

  Expected result: The page shared by the user A to the group Z should
  not be displayed in the list until the date set by  'Overriding start
  date'

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1374163/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1374163] Re: List of shared pages to a group not taking account of access date

2015-05-14 Thread Aaron Wells
Other places that show lists of pages do not exhibit this behavior: the
"Latest pages" block, the "Shared with me" screen. It's just the Group
Pages block that shows you these pages you don't yet have access to.

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1374163

Title:
  List of shared pages to a group not taking account of access date

Status in Mahara ePortfolio:
  Confirmed
Status in Mahara 1.10 series:
  Confirmed
Status in Mahara 1.8 series:
  Won't Fix
Status in Mahara 1.9 series:
  Confirmed
Status in Mahara 15.04 series:
  Confirmed
Status in Mahara 15.10 series:
  Confirmed

Bug description:
  Version: master(1.10) and previous version
  Browser, platform: any

  When I clicked a shared page in the  list of shared pages in the group 
homepage (htdocs/group/view.php), I got "Access denied" message.
  Steps

  1. Login as user A, create a page, share the page to a group Z
  2. Set the  'Overriding start date' to a future date
  3. Login as a member of group Z
  4. In the group Z homepage, click the page shared by the user A
  You will see the "Access denied" message.

  Expected result: The page shared by the user A to the group Z should
  not be displayed in the list until the date set by  'Overriding start
  date'

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1374163/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1374163] Re: List of shared pages to a group not taking account of access date

2015-05-14 Thread Aaron Wells
Not actually a regression as far as I can tell. This bug has been
present since at least Mahara 1.7.

** Tags removed: regression

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1374163

Title:
  List of shared pages to a group not taking account of access date

Status in Mahara ePortfolio:
  Confirmed
Status in Mahara 1.10 series:
  Confirmed
Status in Mahara 1.8 series:
  Won't Fix
Status in Mahara 1.9 series:
  Confirmed
Status in Mahara 15.04 series:
  Confirmed
Status in Mahara 15.10 series:
  Confirmed

Bug description:
  Version: master(1.10) and previous version
  Browser, platform: any

  When I clicked a shared page in the  list of shared pages in the group 
homepage (htdocs/group/view.php), I got "Access denied" message.
  Steps

  1. Login as user A, create a page, share the page to a group Z
  2. Set the  'Overriding start date' to a future date
  3. Login as a member of group Z
  4. In the group Z homepage, click the page shared by the user A
  You will see the "Access denied" message.

  Expected result: The page shared by the user A to the group Z should
  not be displayed in the list until the date set by  'Overriding start
  date'

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1374163/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1455122] Re: Upgrade form 1.10 to 15.04 fails if 3rd party plugins are not present

2015-05-14 Thread Aaron Wells
To replicate:

1. Install Mahara 1.10 (or earlier)

2. Delete the Creative Commons block

3. Upgrade to Mahara 15.04 or 15.10. (If you're doing this with git,
make sure the creativecommons blocktype is still completely missing
after your checkout)

Expected Result: Upgrade should carry through okay

Actual Result: Upgrade crashes

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1455122

Title:
  Upgrade form 1.10 to 15.04 fails if 3rd party plugins are not present

Status in Mahara ePortfolio:
  Confirmed
Status in Mahara 15.04 series:
  Confirmed
Status in Mahara 15.10 series:
  Confirmed

Bug description:
  When upgrading from 1.10 (latest build) to 15.04 (latest build) today
  I get the following error because some 3rd party plugins are not
  present on my server but, due to the lack on auto-unstallation, their
  traces remain in the database.

  If I run again the command later I get the second error message (see
  below).

  The upgrade process should be resilient when 3rd party plugins are not
  here. I think we already had this with previous versions of Mahara and
  it has been fixed. My only way to upgrade to 15.04 is either :

  1/ Find all the bit of information related to the missing plugins and delete 
them from the database
  or
  2/ Reinstall everything from scratch loosing all the data from the Groups (no 
option to export group work in Leap2a)
  or
  3/ Reinstall the missing plugins. I already tried this solution without 
success; some plugins are so old and unmaintaned that they crash the server 
when re-introduced inside Mahara.

  
   Message I got after the first attempt for upgrading the system 

  root@ubuntu:/var/www/html/mahara/htdocs# php admin/cli/upgrade.php
  [INF] 61 (admin/cli/upgrade.php:49) Mise à jour de Mahara
  [INF] 61 (lib/mahara.php:221) Mise à jour de core
  [WAR] 61 (lib/mahara.php:1429) File 
/var/www/html/mahara/htdocs/blocktype/chemnih/lib.php did not exist
  Call stack (most recent first):
* safe_require("blocktype", "chemnih") at 
/var/www/html/mahara/htdocs/lib/upgrade.php:1128
* install_blocktype_categories_for_plugin("chemnih") at 
/var/www/html/mahara/htdocs/lib/db/upgrade.php:3974
* xmldb_core_upgrade("2014092314") at 
/var/www/html/mahara/htdocs/lib/upgrade.php:359
* upgrade_core(object(stdClass)) at 
/var/www/html/mahara/htdocs/lib/mahara.php:253
* upgrade_mahara(array(size 40)) at 
/var/www/html/mahara/htdocs/admin/cli/upgrade.php:50

  A nonrecoverable error occurred. This probably means you have
  encountered a bug in the
  systemroot@ubuntu:/var/www/html/mahara/htdocs# git pull

  --- Message I got after my second attempt
  root@ubuntu:/var/www/html/mahara/htdocs# php admin/cli/upgrade.php
  [INF] 87 (admin/cli/upgrade.php:49) Mise à jour de Mahara
  [INF] 87 (lib/mahara.php:221) Mise à jour de core
  [WAR] 87 (lib/errors.php:747) Failed to get a recordset: mysqli error: [1062: 
Duplicate entry 'shortcut' for key 'PRIMARY'] in adodb_throw(INSERT INTO 
"blocktype_category" ("name", "sort") VALUES ('shortcut', '0'), )
  [WAR] 87 (lib/errors.php:747) Command was: INSERT INTO "blocktype_category" 
("name", "sort") VALUES (?, ?) and values was (shortcut,0)
  Call stack (most recent first):
* log_message("Failed to get a recordset: mysqli error: [1062: Du...", 8, 
true, true) at /var/www/html/mahara/htdocs/lib/errors.php:97
* log_warn("Failed to get a recordset: mysqli error: [1062: Du...") at 
/var/www/html/mahara/htdocs/lib/errors.php:747
* SQLException->__construct("Failed to get a recordset: mysqli error: 
[1062: Du...") at /var/www/html/mahara/htdocs/lib/dml.php:1054
* insert_record("blocktype_category", object(stdClass)) at 
/var/www/html/mahara/htdocs/lib/db/upgrade.php:3856
* xmldb_core_upgrade("2014092314") at 
/var/www/html/mahara/htdocs/lib/upgrade.php:359
* upgrade_core(object(stdClass)) at 
/var/www/html/mahara/htdocs/lib/mahara.php:253
* upgrade_mahara(array(size 40)) at 
/var/www/html/mahara/htdocs/admin/cli/upgrade.php:50

  [WAR] 87 (lib/dml.php:1054) Failed to get a recordset: mysqli error: [1062: 
Duplicate entry 'shortcut' for key 'PRIMARY'] in adodb_throw(INSERT INTO 
"blocktype_category" ("name", "sort") VALUES ('shortcut', '0'), )
  [WAR] 87 (lib/dml.php:1054) Command was: INSERT INTO "blocktype_category" 
("name", "sort") VALUES (?, ?) and values was (shortcut,0)
  Call stack (most recent first):
* insert_record("blocktype_category", object(stdClass)) at 
/var/www/html/mahara/htdocs/lib/db/upgrade.php:3856
* xmldb_core_upgrade("2014092314") at 
/var/www/html/mahara/htdocs/lib/upgrade.php:359
* upgrade_core(object(stdClass)) at 
/var/www/html/mahara/htdocs/lib/mahara.php:253
* upgrade_mahara(array(size 40)) at 
/va

[Mahara-contributors] [Bug 1455122] Re: Upgrade form 1.10 to 15.04 fails if 3rd party plugins are not present

2015-05-14 Thread Aaron Wells
This one would require some intense effort to test in behat, because it
requires you to remove some files from the installation.

** Tags added: no-behat-needed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1455122

Title:
  Upgrade form 1.10 to 15.04 fails if 3rd party plugins are not present

Status in Mahara ePortfolio:
  Confirmed
Status in Mahara 15.04 series:
  Confirmed
Status in Mahara 15.10 series:
  Confirmed

Bug description:
  When upgrading from 1.10 (latest build) to 15.04 (latest build) today
  I get the following error because some 3rd party plugins are not
  present on my server but, due to the lack on auto-unstallation, their
  traces remain in the database.

  If I run again the command later I get the second error message (see
  below).

  The upgrade process should be resilient when 3rd party plugins are not
  here. I think we already had this with previous versions of Mahara and
  it has been fixed. My only way to upgrade to 15.04 is either :

  1/ Find all the bit of information related to the missing plugins and delete 
them from the database
  or
  2/ Reinstall everything from scratch loosing all the data from the Groups (no 
option to export group work in Leap2a)
  or
  3/ Reinstall the missing plugins. I already tried this solution without 
success; some plugins are so old and unmaintaned that they crash the server 
when re-introduced inside Mahara.

  
   Message I got after the first attempt for upgrading the system 

  root@ubuntu:/var/www/html/mahara/htdocs# php admin/cli/upgrade.php
  [INF] 61 (admin/cli/upgrade.php:49) Mise à jour de Mahara
  [INF] 61 (lib/mahara.php:221) Mise à jour de core
  [WAR] 61 (lib/mahara.php:1429) File 
/var/www/html/mahara/htdocs/blocktype/chemnih/lib.php did not exist
  Call stack (most recent first):
* safe_require("blocktype", "chemnih") at 
/var/www/html/mahara/htdocs/lib/upgrade.php:1128
* install_blocktype_categories_for_plugin("chemnih") at 
/var/www/html/mahara/htdocs/lib/db/upgrade.php:3974
* xmldb_core_upgrade("2014092314") at 
/var/www/html/mahara/htdocs/lib/upgrade.php:359
* upgrade_core(object(stdClass)) at 
/var/www/html/mahara/htdocs/lib/mahara.php:253
* upgrade_mahara(array(size 40)) at 
/var/www/html/mahara/htdocs/admin/cli/upgrade.php:50

  A nonrecoverable error occurred. This probably means you have
  encountered a bug in the
  systemroot@ubuntu:/var/www/html/mahara/htdocs# git pull

  --- Message I got after my second attempt
  root@ubuntu:/var/www/html/mahara/htdocs# php admin/cli/upgrade.php
  [INF] 87 (admin/cli/upgrade.php:49) Mise à jour de Mahara
  [INF] 87 (lib/mahara.php:221) Mise à jour de core
  [WAR] 87 (lib/errors.php:747) Failed to get a recordset: mysqli error: [1062: 
Duplicate entry 'shortcut' for key 'PRIMARY'] in adodb_throw(INSERT INTO 
"blocktype_category" ("name", "sort") VALUES ('shortcut', '0'), )
  [WAR] 87 (lib/errors.php:747) Command was: INSERT INTO "blocktype_category" 
("name", "sort") VALUES (?, ?) and values was (shortcut,0)
  Call stack (most recent first):
* log_message("Failed to get a recordset: mysqli error: [1062: Du...", 8, 
true, true) at /var/www/html/mahara/htdocs/lib/errors.php:97
* log_warn("Failed to get a recordset: mysqli error: [1062: Du...") at 
/var/www/html/mahara/htdocs/lib/errors.php:747
* SQLException->__construct("Failed to get a recordset: mysqli error: 
[1062: Du...") at /var/www/html/mahara/htdocs/lib/dml.php:1054
* insert_record("blocktype_category", object(stdClass)) at 
/var/www/html/mahara/htdocs/lib/db/upgrade.php:3856
* xmldb_core_upgrade("2014092314") at 
/var/www/html/mahara/htdocs/lib/upgrade.php:359
* upgrade_core(object(stdClass)) at 
/var/www/html/mahara/htdocs/lib/mahara.php:253
* upgrade_mahara(array(size 40)) at 
/var/www/html/mahara/htdocs/admin/cli/upgrade.php:50

  [WAR] 87 (lib/dml.php:1054) Failed to get a recordset: mysqli error: [1062: 
Duplicate entry 'shortcut' for key 'PRIMARY'] in adodb_throw(INSERT INTO 
"blocktype_category" ("name", "sort") VALUES ('shortcut', '0'), )
  [WAR] 87 (lib/dml.php:1054) Command was: INSERT INTO "blocktype_category" 
("name", "sort") VALUES (?, ?) and values was (shortcut,0)
  Call stack (most recent first):
* insert_record("blocktype_category", object(stdClass)) at 
/var/www/html/mahara/htdocs/lib/db/upgrade.php:3856
* xmldb_core_upgrade("2014092314") at 
/var/www/html/mahara/htdocs/lib/upgrade.php:359
* upgrade_core(object(stdClass)) at 
/var/www/html/mahara/htdocs/lib/mahara.php:253
* upgrade_mahara(array(size 40)) at 
/var/www/html/mahara/htdocs/admin/cli/upgrade.php:50

  A nonrecoverable error occurred. This probably means you have
  encountered a bug in the
  systemroot@ubuntu:/var/www/

[Mahara-contributors] [Bug 1446412] Re: Webservice cron doesn't run due to missing function

2015-05-14 Thread Aaron Wells
** Changed in: mahara/15.04
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1446412

Title:
  Webservice cron doesn't run due to missing function

Status in Mahara ePortfolio:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Committed

Bug description:
  The cron job webservice_clean_webservice_logs does not run due to the
  file webservice/lib.php not being included into the lib/cron.php file

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1446412/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1454458] Re: Navigation group pages

2015-05-14 Thread Jono Mingard
OK, this happens because (in theory) whenever you view the list of group
pages there is a "Copy page" button next to any which are copyable.
However, blocktype/groupviews/groupviews.json.php doesn't import
pieforms, meaning it fails when trying to create the button. So the
simple fix is to require pieforms in that page.

** Changed in: mahara
   Importance: Undecided => Medium

** Changed in: mahara
 Assignee: (unassigned) => Jono Mingard (mingard)

** Changed in: mahara
   Status: Confirmed => In Progress

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1454458

Title:
  Navigation group pages

Status in Mahara ePortfolio:
  In Progress

Bug description:
  Mahara version: 1.10.3+patches (latest version is 15.04.0)

  This is for http://myportfolio.ac.nz/

  If you have enough group pages they are split in lots of 5. If there
  is a group page that is able to be copied once you navigate to the
  second page you cannot nav back to page 1.

  To Replicate:

  Create a brand new group.

  Make 7 or 8 group pages in the group (they can be empty pages, don’t
  change any other settings).

  Note that the list of group pages on the group dashboard page only
  shows five, and you can go forward and back to view the next five then
  back to viewing the first five in the list.

  Now, make one of the pages (such as the third page on the list)
  copiable.

  Now try navigating forwards and backwards through the list of pages on
  the group dashboard.


  If you made the third page copiable, it will let you go to “page 2” of
  the list of pages, but not go back. We have established that any list
  that contains a copiable page seems to bug out the forward and back
  buttons on the group dashboard page.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1454458/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1455122] Re: Upgrade form 1.10 to 15.04 fails if 3rd party plugins are not present

2015-05-14 Thread Aaron Wells
** Tags added: upgrade

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1455122

Title:
  Upgrade form 1.10 to 15.04 fails if 3rd party plugins are not present

Status in Mahara ePortfolio:
  Confirmed
Status in Mahara 15.04 series:
  Confirmed
Status in Mahara 15.10 series:
  Confirmed

Bug description:
  When upgrading from 1.10 (latest build) to 15.04 (latest build) today
  I get the following error because some 3rd party plugins are not
  present on my server but, due to the lack on auto-unstallation, their
  traces remain in the database.

  If I run again the command later I get the second error message (see
  below).

  The upgrade process should be resilient when 3rd party plugins are not
  here. I think we already had this with previous versions of Mahara and
  it has been fixed. My only way to upgrade to 15.04 is either :

  1/ Find all the bit of information related to the missing plugins and delete 
them from the database
  or
  2/ Reinstall everything from scratch loosing all the data from the Groups (no 
option to export group work in Leap2a)
  or
  3/ Reinstall the missing plugins. I already tried this solution without 
success; some plugins are so old and unmaintaned that they crash the server 
when re-introduced inside Mahara.

  
   Message I got after the first attempt for upgrading the system 

  root@ubuntu:/var/www/html/mahara/htdocs# php admin/cli/upgrade.php
  [INF] 61 (admin/cli/upgrade.php:49) Mise à jour de Mahara
  [INF] 61 (lib/mahara.php:221) Mise à jour de core
  [WAR] 61 (lib/mahara.php:1429) File 
/var/www/html/mahara/htdocs/blocktype/chemnih/lib.php did not exist
  Call stack (most recent first):
* safe_require("blocktype", "chemnih") at 
/var/www/html/mahara/htdocs/lib/upgrade.php:1128
* install_blocktype_categories_for_plugin("chemnih") at 
/var/www/html/mahara/htdocs/lib/db/upgrade.php:3974
* xmldb_core_upgrade("2014092314") at 
/var/www/html/mahara/htdocs/lib/upgrade.php:359
* upgrade_core(object(stdClass)) at 
/var/www/html/mahara/htdocs/lib/mahara.php:253
* upgrade_mahara(array(size 40)) at 
/var/www/html/mahara/htdocs/admin/cli/upgrade.php:50

  A nonrecoverable error occurred. This probably means you have
  encountered a bug in the
  systemroot@ubuntu:/var/www/html/mahara/htdocs# git pull

  --- Message I got after my second attempt
  root@ubuntu:/var/www/html/mahara/htdocs# php admin/cli/upgrade.php
  [INF] 87 (admin/cli/upgrade.php:49) Mise à jour de Mahara
  [INF] 87 (lib/mahara.php:221) Mise à jour de core
  [WAR] 87 (lib/errors.php:747) Failed to get a recordset: mysqli error: [1062: 
Duplicate entry 'shortcut' for key 'PRIMARY'] in adodb_throw(INSERT INTO 
"blocktype_category" ("name", "sort") VALUES ('shortcut', '0'), )
  [WAR] 87 (lib/errors.php:747) Command was: INSERT INTO "blocktype_category" 
("name", "sort") VALUES (?, ?) and values was (shortcut,0)
  Call stack (most recent first):
* log_message("Failed to get a recordset: mysqli error: [1062: Du...", 8, 
true, true) at /var/www/html/mahara/htdocs/lib/errors.php:97
* log_warn("Failed to get a recordset: mysqli error: [1062: Du...") at 
/var/www/html/mahara/htdocs/lib/errors.php:747
* SQLException->__construct("Failed to get a recordset: mysqli error: 
[1062: Du...") at /var/www/html/mahara/htdocs/lib/dml.php:1054
* insert_record("blocktype_category", object(stdClass)) at 
/var/www/html/mahara/htdocs/lib/db/upgrade.php:3856
* xmldb_core_upgrade("2014092314") at 
/var/www/html/mahara/htdocs/lib/upgrade.php:359
* upgrade_core(object(stdClass)) at 
/var/www/html/mahara/htdocs/lib/mahara.php:253
* upgrade_mahara(array(size 40)) at 
/var/www/html/mahara/htdocs/admin/cli/upgrade.php:50

  [WAR] 87 (lib/dml.php:1054) Failed to get a recordset: mysqli error: [1062: 
Duplicate entry 'shortcut' for key 'PRIMARY'] in adodb_throw(INSERT INTO 
"blocktype_category" ("name", "sort") VALUES ('shortcut', '0'), )
  [WAR] 87 (lib/dml.php:1054) Command was: INSERT INTO "blocktype_category" 
("name", "sort") VALUES (?, ?) and values was (shortcut,0)
  Call stack (most recent first):
* insert_record("blocktype_category", object(stdClass)) at 
/var/www/html/mahara/htdocs/lib/db/upgrade.php:3856
* xmldb_core_upgrade("2014092314") at 
/var/www/html/mahara/htdocs/lib/upgrade.php:359
* upgrade_core(object(stdClass)) at 
/var/www/html/mahara/htdocs/lib/mahara.php:253
* upgrade_mahara(array(size 40)) at 
/var/www/html/mahara/htdocs/admin/cli/upgrade.php:50

  A nonrecoverable error occurred. This probably means you have
  encountered a bug in the
  systemroot@ubuntu:/var/www/html/mahara/htdocs#

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1455122/+subscriptions


[Mahara-contributors] [Bug 1455122] Re: Upgrade form 1.10 to 15.04 fails if 3rd party plugins are not present

2015-05-14 Thread Aaron Wells
Confirmed. This does not happen when upgrading from 1.9 -> 1.10. It
appears that it's due to the blocktype category code that we added in
15.04 to store block sortorders.

While we don't yet support fully uninstalling plugins (that's bug
505732), Mahara shouldn't crash like this if you've just deleted the
plugin.

Another possible workaround to those listed above, would be to put in a
"dummy" placeholder plugin with no functionality, but with the same name
as the expected plugin. But I'm going to try to get this bug fixed for
15.04.1.

Cheers,
Aaron

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1455122

Title:
  Upgrade form 1.10 to 15.04 fails if 3rd party plugins are not present

Status in Mahara ePortfolio:
  Confirmed
Status in Mahara 15.04 series:
  Confirmed
Status in Mahara 15.10 series:
  Confirmed

Bug description:
  When upgrading from 1.10 (latest build) to 15.04 (latest build) today
  I get the following error because some 3rd party plugins are not
  present on my server but, due to the lack on auto-unstallation, their
  traces remain in the database.

  If I run again the command later I get the second error message (see
  below).

  The upgrade process should be resilient when 3rd party plugins are not
  here. I think we already had this with previous versions of Mahara and
  it has been fixed. My only way to upgrade to 15.04 is either :

  1/ Find all the bit of information related to the missing plugins and delete 
them from the database
  or
  2/ Reinstall everything from scratch loosing all the data from the Groups (no 
option to export group work in Leap2a)
  or
  3/ Reinstall the missing plugins. I already tried this solution without 
success; some plugins are so old and unmaintaned that they crash the server 
when re-introduced inside Mahara.

  
   Message I got after the first attempt for upgrading the system 

  root@ubuntu:/var/www/html/mahara/htdocs# php admin/cli/upgrade.php
  [INF] 61 (admin/cli/upgrade.php:49) Mise à jour de Mahara
  [INF] 61 (lib/mahara.php:221) Mise à jour de core
  [WAR] 61 (lib/mahara.php:1429) File 
/var/www/html/mahara/htdocs/blocktype/chemnih/lib.php did not exist
  Call stack (most recent first):
* safe_require("blocktype", "chemnih") at 
/var/www/html/mahara/htdocs/lib/upgrade.php:1128
* install_blocktype_categories_for_plugin("chemnih") at 
/var/www/html/mahara/htdocs/lib/db/upgrade.php:3974
* xmldb_core_upgrade("2014092314") at 
/var/www/html/mahara/htdocs/lib/upgrade.php:359
* upgrade_core(object(stdClass)) at 
/var/www/html/mahara/htdocs/lib/mahara.php:253
* upgrade_mahara(array(size 40)) at 
/var/www/html/mahara/htdocs/admin/cli/upgrade.php:50

  A nonrecoverable error occurred. This probably means you have
  encountered a bug in the
  systemroot@ubuntu:/var/www/html/mahara/htdocs# git pull

  --- Message I got after my second attempt
  root@ubuntu:/var/www/html/mahara/htdocs# php admin/cli/upgrade.php
  [INF] 87 (admin/cli/upgrade.php:49) Mise à jour de Mahara
  [INF] 87 (lib/mahara.php:221) Mise à jour de core
  [WAR] 87 (lib/errors.php:747) Failed to get a recordset: mysqli error: [1062: 
Duplicate entry 'shortcut' for key 'PRIMARY'] in adodb_throw(INSERT INTO 
"blocktype_category" ("name", "sort") VALUES ('shortcut', '0'), )
  [WAR] 87 (lib/errors.php:747) Command was: INSERT INTO "blocktype_category" 
("name", "sort") VALUES (?, ?) and values was (shortcut,0)
  Call stack (most recent first):
* log_message("Failed to get a recordset: mysqli error: [1062: Du...", 8, 
true, true) at /var/www/html/mahara/htdocs/lib/errors.php:97
* log_warn("Failed to get a recordset: mysqli error: [1062: Du...") at 
/var/www/html/mahara/htdocs/lib/errors.php:747
* SQLException->__construct("Failed to get a recordset: mysqli error: 
[1062: Du...") at /var/www/html/mahara/htdocs/lib/dml.php:1054
* insert_record("blocktype_category", object(stdClass)) at 
/var/www/html/mahara/htdocs/lib/db/upgrade.php:3856
* xmldb_core_upgrade("2014092314") at 
/var/www/html/mahara/htdocs/lib/upgrade.php:359
* upgrade_core(object(stdClass)) at 
/var/www/html/mahara/htdocs/lib/mahara.php:253
* upgrade_mahara(array(size 40)) at 
/var/www/html/mahara/htdocs/admin/cli/upgrade.php:50

  [WAR] 87 (lib/dml.php:1054) Failed to get a recordset: mysqli error: [1062: 
Duplicate entry 'shortcut' for key 'PRIMARY'] in adodb_throw(INSERT INTO 
"blocktype_category" ("name", "sort") VALUES ('shortcut', '0'), )
  [WAR] 87 (lib/dml.php:1054) Command was: INSERT INTO "blocktype_category" 
("name", "sort") VALUES (?, ?) and values was (shortcut,0)
  Call stack (most recent first):
* insert_record("blocktype_category", object(stdClass)) at 
/var/www/html/mahara/htdocs/lib/db/upgrade.php:3856

[Mahara-contributors] [Bug 1454458] Re: Navigation group pages

2015-05-14 Thread Jono Mingard
** Changed in: mahara
   Status: New => Confirmed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1454458

Title:
  Navigation group pages

Status in Mahara ePortfolio:
  Confirmed

Bug description:
  Mahara version: 1.10.3+patches (latest version is 15.04.0)

  This is for http://myportfolio.ac.nz/

  If you have enough group pages they are split in lots of 5. If there
  is a group page that is able to be copied once you navigate to the
  second page you cannot nav back to page 1.

  To Replicate:

  Create a brand new group.

  Make 7 or 8 group pages in the group (they can be empty pages, don’t
  change any other settings).

  Note that the list of group pages on the group dashboard page only
  shows five, and you can go forward and back to view the next five then
  back to viewing the first five in the list.

  Now, make one of the pages (such as the third page on the list)
  copiable.

  Now try navigating forwards and backwards through the list of pages on
  the group dashboard.


  If you made the third page copiable, it will let you go to “page 2” of
  the list of pages, but not go back. We have established that any list
  that contains a copiable page seems to bug out the forward and back
  buttons on the group dashboard page.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1454458/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1455122] Re: Upgrade form 1.10 to 15.04 fails if 3rd party plugins are not present

2015-05-14 Thread Aaron Wells
** Also affects: mahara/15.04
   Importance: Undecided
   Status: New

** Also affects: mahara/15.10
   Importance: Undecided
   Status: New

** Changed in: mahara/15.04
   Status: New => Confirmed

** Changed in: mahara/15.10
   Status: New => Confirmed

** Changed in: mahara/15.04
   Importance: Undecided => High

** Changed in: mahara/15.10
   Importance: Undecided => High

** Changed in: mahara/15.04
Milestone: None => 15.04.1

** Changed in: mahara/15.10
Milestone: None => 15.10.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1455122

Title:
  Upgrade form 1.10 to 15.04 fails if 3rd party plugins are not present

Status in Mahara ePortfolio:
  Confirmed
Status in Mahara 15.04 series:
  Confirmed
Status in Mahara 15.10 series:
  Confirmed

Bug description:
  When upgrading from 1.10 (latest build) to 15.04 (latest build) today
  I get the following error because some 3rd party plugins are not
  present on my server but, due to the lack on auto-unstallation, their
  traces remain in the database.

  If I run again the command later I get the second error message (see
  below).

  The upgrade process should be resilient when 3rd party plugins are not
  here. I think we already had this with previous versions of Mahara and
  it has been fixed. My only way to upgrade to 15.04 is either :

  1/ Find all the bit of information related to the missing plugins and delete 
them from the database
  or
  2/ Reinstall everything from scratch loosing all the data from the Groups (no 
option to export group work in Leap2a)
  or
  3/ Reinstall the missing plugins. I already tried this solution without 
success; some plugins are so old and unmaintaned that they crash the server 
when re-introduced inside Mahara.

  
   Message I got after the first attempt for upgrading the system 

  root@ubuntu:/var/www/html/mahara/htdocs# php admin/cli/upgrade.php
  [INF] 61 (admin/cli/upgrade.php:49) Mise à jour de Mahara
  [INF] 61 (lib/mahara.php:221) Mise à jour de core
  [WAR] 61 (lib/mahara.php:1429) File 
/var/www/html/mahara/htdocs/blocktype/chemnih/lib.php did not exist
  Call stack (most recent first):
* safe_require("blocktype", "chemnih") at 
/var/www/html/mahara/htdocs/lib/upgrade.php:1128
* install_blocktype_categories_for_plugin("chemnih") at 
/var/www/html/mahara/htdocs/lib/db/upgrade.php:3974
* xmldb_core_upgrade("2014092314") at 
/var/www/html/mahara/htdocs/lib/upgrade.php:359
* upgrade_core(object(stdClass)) at 
/var/www/html/mahara/htdocs/lib/mahara.php:253
* upgrade_mahara(array(size 40)) at 
/var/www/html/mahara/htdocs/admin/cli/upgrade.php:50

  A nonrecoverable error occurred. This probably means you have
  encountered a bug in the
  systemroot@ubuntu:/var/www/html/mahara/htdocs# git pull

  --- Message I got after my second attempt
  root@ubuntu:/var/www/html/mahara/htdocs# php admin/cli/upgrade.php
  [INF] 87 (admin/cli/upgrade.php:49) Mise à jour de Mahara
  [INF] 87 (lib/mahara.php:221) Mise à jour de core
  [WAR] 87 (lib/errors.php:747) Failed to get a recordset: mysqli error: [1062: 
Duplicate entry 'shortcut' for key 'PRIMARY'] in adodb_throw(INSERT INTO 
"blocktype_category" ("name", "sort") VALUES ('shortcut', '0'), )
  [WAR] 87 (lib/errors.php:747) Command was: INSERT INTO "blocktype_category" 
("name", "sort") VALUES (?, ?) and values was (shortcut,0)
  Call stack (most recent first):
* log_message("Failed to get a recordset: mysqli error: [1062: Du...", 8, 
true, true) at /var/www/html/mahara/htdocs/lib/errors.php:97
* log_warn("Failed to get a recordset: mysqli error: [1062: Du...") at 
/var/www/html/mahara/htdocs/lib/errors.php:747
* SQLException->__construct("Failed to get a recordset: mysqli error: 
[1062: Du...") at /var/www/html/mahara/htdocs/lib/dml.php:1054
* insert_record("blocktype_category", object(stdClass)) at 
/var/www/html/mahara/htdocs/lib/db/upgrade.php:3856
* xmldb_core_upgrade("2014092314") at 
/var/www/html/mahara/htdocs/lib/upgrade.php:359
* upgrade_core(object(stdClass)) at 
/var/www/html/mahara/htdocs/lib/mahara.php:253
* upgrade_mahara(array(size 40)) at 
/var/www/html/mahara/htdocs/admin/cli/upgrade.php:50

  [WAR] 87 (lib/dml.php:1054) Failed to get a recordset: mysqli error: [1062: 
Duplicate entry 'shortcut' for key 'PRIMARY'] in adodb_throw(INSERT INTO 
"blocktype_category" ("name", "sort") VALUES ('shortcut', '0'), )
  [WAR] 87 (lib/dml.php:1054) Command was: INSERT INTO "blocktype_category" 
("name", "sort") VALUES (?, ?) and values was (shortcut,0)
  Call stack (most recent first):
* insert_record("blocktype_category", object(stdClass)) at 
/var/www/html/mahara/htdocs/lib/db/upgrade.php:3856
* xmldb_core_upgrade("2014092314") a

[Mahara-contributors] [Bug 1338381] Re: Switch from commandline zip/unzip to PHP ZipArchive class

2015-05-14 Thread Jono Mingard
** Changed in: mahara
 Assignee: (unassigned) => Jono Mingard (mingard)

** Changed in: mahara
   Status: Confirmed => In Progress

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1338381

Title:
  Switch from commandline zip/unzip to PHP ZipArchive class

Status in Mahara ePortfolio:
  In Progress

Bug description:
  We get a steady stream of support requests from people on shared
  hosting or Windows, who can't find their command-line zip & unzip
  utilities.

  There's really no reason for us to be using those anymore, though. PHP
  5.3 ships with a fully functional zip library, and we should use that
  instead: http://nz1.php.net/manual/en/book.zip.php

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1338381/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1455265] Re: TinyMCE "full screen" button doesn't work in block config

2015-05-14 Thread Aaron Wells
This problem is only present in Mahara 15.04 & 15.10dev, and it's only
on block configs, not TinyMCE's in other situations (like a page
description).

Using git bisect I've traced it to this commit:

commit 141ee71b4a56c14023a7b3f2b7932934895bce0c
Author: Nigel Cunningham 
Date:   Mon Dec 29 09:30:10 2014 +1100

Bug1051844: Fix block configure dialog width.

The configure dialog for blocks is currently set to a fixed width via
Javascript, but there is no handler for browser resizing and it results in 
the
dialogue being very wide for the sake of just one line when a license 
agreement
is enabled.

Fix this issue by making all dimensions percentages, and using a 
combination of
max-width: 90% and width: max-content. In addition, make the dialog fixed
position with its own scrollbars as needed (the body's scrollbar is disabled
when the dialog is shown).

Contextual help's width code and CSS is also adjusted so that it wraps 
within
dialog boxes rather than pushing the width out.

Change-Id: If2a40739f1510cedcf9a6133ccfb8f0a18257356

So it appears that it's a side effect of the code that we added to keep
the block config from getting too wide when there was a wide piece of
text in it. Perhaps what we need to do is hook into the TinyMCE
fullscreen button and make it toggle the max-width and max-content on
the dialog?

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1455265

Title:
  TinyMCE "full screen" button doesn't work in block config

Status in Mahara ePortfolio:
  Confirmed
Status in Mahara 15.04 series:
  Confirmed
Status in Mahara 15.10 series:
  Confirmed

Bug description:
  Mahara 1504

  It appears that the fullscreen is not fullscreen in 1504. I tried on a
  couple instances, including master.dev.mahara.org and various
  browsers. Adding screenshot also

  To replicate:

  1. Create a page
  2. Go to the "Edit Content" tab
  3. Put a text block onto the page
  4. Click the "Toggle toolbars" button on TinyMCE to expose the fullscreen 
button (it's on the right end of the second row of buttons)
  5. Click the "Fullscreen" button

  Expected result:
  TinyMCE goes to full screen (fills the whole browser window)

  Actual result:
  TinyMCE only fills the block config iframe. This actually makes it *smaller* 
than before.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1455265/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1455265] Re: TinyMCE "full screen" button doesn't work in block config

2015-05-14 Thread Aaron Wells
** Summary changed:

- full screen not working in Tinymce
+ TinyMCE "full screen" button doesn't work in block config

** Tags added: tinymce

** Description changed:

  Mahara 1504
  
  It appears that the fullscreen is not fullscreen in 1504. I tried on a
  couple instances, including master.dev.mahara.org and various browsers.
  Adding screenshot also
+ 
+ To replicate:
+ 
+ 1. Create a page
+ 2. Go to the "Edit Content" tab
+ 3. Put a text block onto the page
+ 4. Click the "Toggle toolbars" button on TinyMCE to expose the fullscreen 
button (it's on the right end of the second row of buttons)
+ 5. Click the "Fullscreen" button
+ 
+ Expected result:
+ TinyMCE goes to full screen (fills the whole browser window)
+ 
+ Actual result:
+ TinyMCE only fills the block config iframe. This actually makes it *smaller* 
than before.

** Changed in: mahara
   Status: New => Confirmed

** Changed in: mahara
   Importance: Undecided => High

** Also affects: mahara/15.04
   Importance: Undecided
   Status: New

** Also affects: mahara/15.10
   Importance: High
   Status: Confirmed

** Changed in: mahara/15.04
   Status: New => Confirmed

** Changed in: mahara/15.04
   Importance: Undecided => High

** Changed in: mahara/15.10
Milestone: None => 15.10.0

** Changed in: mahara/15.04
Milestone: None => 15.04.1

** Changed in: mahara/15.10
 Assignee: (unassigned) => Aaron Wells (u-aaronw)

** Changed in: mahara/15.04
 Assignee: (unassigned) => Aaron Wells (u-aaronw)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1455265

Title:
  TinyMCE "full screen" button doesn't work in block config

Status in Mahara ePortfolio:
  Confirmed
Status in Mahara 15.04 series:
  Confirmed
Status in Mahara 15.10 series:
  Confirmed

Bug description:
  Mahara 1504

  It appears that the fullscreen is not fullscreen in 1504. I tried on a
  couple instances, including master.dev.mahara.org and various
  browsers. Adding screenshot also

  To replicate:

  1. Create a page
  2. Go to the "Edit Content" tab
  3. Put a text block onto the page
  4. Click the "Toggle toolbars" button on TinyMCE to expose the fullscreen 
button (it's on the right end of the second row of buttons)
  5. Click the "Fullscreen" button

  Expected result:
  TinyMCE goes to full screen (fills the whole browser window)

  Actual result:
  TinyMCE only fills the block config iframe. This actually makes it *smaller* 
than before.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1455265/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1455137] Re: "Edit access" screen has trouble with jscalendar dates if you change calendar_dateFormat and/or strtimedatetimeshort

2015-05-14 Thread Aaron Wells
Hi David,

I've confirmed this problem. For now, the workaround is to change
calendar_dateFormat and strftimedatetimeshort back to the originals from
the English langpack. (And update the lang strings for the help text, to
match.) I've looked through the code and verified that
calendar_dateFormat and strftimedatetimeshort are nearly only used for
the JS calendar widget  (strftimedatetimeshort also has a couple of
other minor uses, usually in outputting data to admins).

Going forward, here's what I would suggest for the fix:

1. For the calendar, instead of using "strftimedatetimeshort", we use a
new lang string called "calendar_phpdatetimeformat".

2. We rename "calendar_dateformat" to "calendar_jsdateformat", and
"calendar_timeformat" to "calendar_jstimeformat".

3. Items #1 and #2 together should help make it clearer to devs that
these strings must match each other.

4. If possible we add some code to the Pieform calendar and acl
elements, so that they themselves do the date format validation, and so
that they render the human-readable date into a hard-coded format by the
time it gets sent to the form's "_submit" function. That way, we won't
have to rely on the devs remembering to use the correct lang strings to
parse and validate the calendar's dates on every form where it is used.
(It is evident we devs have not been remembering to do that.)

5. If #4 is not possible, at least add some documentation to the Pieform
calendar and acl elements. And go through all the forms that use them
and fix their validation and submission code.

Unfortunately, this is a non-trivial fix, so I'm probably not going to
get to it immediately. In the meantime, I'd suggest using that
workaround, of changing calendar_dateFormat and strftimedatetimeshort
back to the original values. This shouldn't be a huge inconvenience to
your users, because the JS calendar widget means they shouldn't actually
need to type in a date anyway.

Cheers,
Aaron

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1455137

Title:
  "Edit access" screen has trouble with jscalendar dates if you change
  calendar_dateFormat and/or strtimedatetimeshort

Status in Mahara ePortfolio:
  Confirmed
Status in Mahara 1.10 series:
  Confirmed
Status in Mahara 15.04 series:
  Confirmed
Status in Mahara 15.10 series:
  Confirmed

Bug description:
  This is a follow up on Bug #1376997 Date picker not working for certain 
languages
  The date picker works with the dd.mm.yy format when editing access ("shared 
by me" page).

  However if you are to change in langconfig.php the parameters to a french 
format:
  $string['calendar_dateFormat']= 'dd/mm/yy';
  $string['strftimedatetimeshort'] = '%%d/%%m/%%Y %%H:%%M';

  You can use the date picker and define a new access. However, you
  cannot edit a preexisting access besause it doesnt show up when you go
  to edit it. You are forced to redefine all your access if you want to
  modify anything.

  Theres also a problem when you try to define "Access start date/time"
  and "Access end date/time" in the Advanced option. It will take the
  dd/mm/yy format of the datepicker. However, you cannot choose a day
  higher then 12. You can on the other hand enter a mm/dd/yy format into
  the textbox manually to define the access.

  If the code itself is too complicated to fix, there should at least be
  a converter to show the chosen date format to the users.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1455137/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1455137] Re: Edit access not working in french

2015-05-14 Thread Aaron Wells
** Changed in: mahara
   Status: New => Confirmed

** Changed in: mahara
   Importance: Undecided => Medium

** Also affects: mahara/1.10
   Importance: Undecided
   Status: New

** Also affects: mahara/15.04
   Importance: Undecided
   Status: New

** Also affects: mahara/15.10
   Importance: Medium
   Status: Confirmed

** Changed in: mahara/1.10
   Status: New => Confirmed

** Changed in: mahara/15.04
   Status: New => Confirmed

** Changed in: mahara/15.04
   Importance: Undecided => Medium

** Changed in: mahara/1.10
   Importance: Undecided => Medium

** Changed in: mahara/15.10
Milestone: None => 15.10.0

** Changed in: mahara/15.04
Milestone: None => 15.04.1

** Changed in: mahara/1.10
Milestone: None => 1.10.4

** Summary changed:

- Edit access not working in french
+ "Edit access" screen has trouble with jscalendar dates if you change 
calendar_dateFormat and/or strtimedatetimeshort

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1455137

Title:
  "Edit access" screen has trouble with jscalendar dates if you change
  calendar_dateFormat and/or strtimedatetimeshort

Status in Mahara ePortfolio:
  Confirmed
Status in Mahara 1.10 series:
  Confirmed
Status in Mahara 15.04 series:
  Confirmed
Status in Mahara 15.10 series:
  Confirmed

Bug description:
  This is a follow up on Bug #1376997 Date picker not working for certain 
languages
  The date picker works with the dd.mm.yy format when editing access ("shared 
by me" page).

  However if you are to change in langconfig.php the parameters to a french 
format:
  $string['calendar_dateFormat']= 'dd/mm/yy';
  $string['strftimedatetimeshort'] = '%%d/%%m/%%Y %%H:%%M';

  You can use the date picker and define a new access. However, you
  cannot edit a preexisting access besause it doesnt show up when you go
  to edit it. You are forced to redefine all your access if you want to
  modify anything.

  Theres also a problem when you try to define "Access start date/time"
  and "Access end date/time" in the Advanced option. It will take the
  dd/mm/yy format of the datepicker. However, you cannot choose a day
  higher then 12. You can on the other hand enter a mm/dd/yy format into
  the textbox manually to define the access.

  If the code itself is too complicated to fix, there should at least be
  a converter to show the chosen date format to the users.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1455137/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1455265] [NEW] full screen not working in Tinymce

2015-05-14 Thread Dirk Meyer
Public bug reported:

Mahara 1504

It appears that the fullscreen is not fullscreen in 1504. I tried on a
couple instances, including master.dev.mahara.org and various browsers.
Adding screenshot also

** Affects: mahara
 Importance: Undecided
 Status: New

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1455265

Title:
  full screen not working in Tinymce

Status in Mahara ePortfolio:
  New

Bug description:
  Mahara 1504

  It appears that the fullscreen is not fullscreen in 1504. I tried on a
  couple instances, including master.dev.mahara.org and various
  browsers. Adding screenshot also

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1455265/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1455265] Re: full screen not working in Tinymce

2015-05-14 Thread Dirk Meyer
attachment to previous post

** Attachment added: "fullscreen_mahara1504.PNG"
   
https://bugs.launchpad.net/mahara/+bug/1455265/+attachment/4397754/+files/fullscreen_mahara1504.PNG

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1455265

Title:
  full screen not working in Tinymce

Status in Mahara ePortfolio:
  New

Bug description:
  Mahara 1504

  It appears that the fullscreen is not fullscreen in 1504. I tried on a
  couple instances, including master.dev.mahara.org and various
  browsers. Adding screenshot also

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1455265/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1455137] [NEW] Edit access not working in french

2015-05-14 Thread David
Public bug reported:

This is a follow up on Bug #1376997 Date picker not working for certain 
languages
The date picker works with the dd.mm.yy format when editing access ("shared by 
me" page).

However if you are to change in langconfig.php the parameters to a french 
format:
$string['calendar_dateFormat']= 'dd/mm/yy';
$string['strftimedatetimeshort'] = '%%d/%%m/%%Y %%H:%%M';

You can use the date picker and define a new access. However, you cannot
edit a preexisting access besause it doesnt show up when you go to edit
it. You are forced to redefine all your access if you want to modify
anything.

Theres also a problem when you try to define "Access start date/time"
and "Access end date/time" in the Advanced option. It will take the
dd/mm/yy format of the datepicker. However, you cannot choose a day
higher then 12. You can on the other hand enter a mm/dd/yy format into
the textbox manually to define the access.

If the code itself is too complicated to fix, there should at least be a
converter to show the chosen date format to the users.

** Affects: mahara
 Importance: Undecided
 Status: New

** Description changed:

  This is a follow up on Bug #1376997 Date picker not working for certain 
languages
- The date picker works with the dd.mm.yy format when editing access (shared by 
me).
+ The date picker works with the dd.mm.yy format when editing access ("shared 
by me" page).
  
- However if you are to change in langconfig.php the parameters to a french 
format:  
+ However if you are to change in langconfig.php the parameters to a french 
format:
  $string['calendar_dateFormat']= 'dd/mm/yy';
  $string['strftimedatetimeshort'] = '%%d/%%m/%%Y %%H:%%M';
  
  You can use the date picker and define a new access. However, you cannot
  edit a preexisting access besause it doesnt show up when you go to edit
  it. You are forced to redefine all your access if you want to modify
  anything.
  
  Theres also a problem when you try to define "Access start date/time"
  and "Access end date/time" in the Advanced option. It will take the
  dd/mm/yy format of the datepicker. However, you cannot choose a day
  higher then 12. You can on the other hand enter a mm/dd/yy format into
  the textbox manually to define the access.
  
  If the code itself is too complicated to fix, there should at least be a
  converter to show the chosen date format to the users.

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1455137

Title:
  Edit access not working in french

Status in Mahara ePortfolio:
  New

Bug description:
  This is a follow up on Bug #1376997 Date picker not working for certain 
languages
  The date picker works with the dd.mm.yy format when editing access ("shared 
by me" page).

  However if you are to change in langconfig.php the parameters to a french 
format:
  $string['calendar_dateFormat']= 'dd/mm/yy';
  $string['strftimedatetimeshort'] = '%%d/%%m/%%Y %%H:%%M';

  You can use the date picker and define a new access. However, you
  cannot edit a preexisting access besause it doesnt show up when you go
  to edit it. You are forced to redefine all your access if you want to
  modify anything.

  Theres also a problem when you try to define "Access start date/time"
  and "Access end date/time" in the Advanced option. It will take the
  dd/mm/yy format of the datepicker. However, you cannot choose a day
  higher then 12. You can on the other hand enter a mm/dd/yy format into
  the textbox manually to define the access.

  If the code itself is too complicated to fix, there should at least be
  a converter to show the chosen date format to the users.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1455137/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1455122] [NEW] Upgrade form 1.10 to 15.04 fails if 3rd party plugins are not present

2015-05-14 Thread Dominique-Alain JAN
Public bug reported:

When upgrading from 1.10 (latest build) to 15.04 (latest build) today I
get the following error because some 3rd party plugins are not present
on my server but, due to the lack on auto-unstallation, their traces
remain in the database.

If I run again the command later I get the second error message (see
below).

The upgrade process should be resilient when 3rd party plugins are not
here. I think we already had this with previous versions of Mahara and
it has been fixed. My only way to upgrade to 15.04 is either :

1/ Find all the bit of information related to the missing plugins and delete 
them from the database
or
2/ Reinstall everything from scratch loosing all the data from the Groups (no 
option to export group work in Leap2a)
or
3/ Reinstall the missing plugins. I already tried this solution without 
success; some plugins are so old and unmaintaned that they crash the server 
when re-introduced inside Mahara.


 Message I got after the first attempt for upgrading the system 

root@ubuntu:/var/www/html/mahara/htdocs# php admin/cli/upgrade.php
[INF] 61 (admin/cli/upgrade.php:49) Mise à jour de Mahara
[INF] 61 (lib/mahara.php:221) Mise à jour de core
[WAR] 61 (lib/mahara.php:1429) File 
/var/www/html/mahara/htdocs/blocktype/chemnih/lib.php did not exist
Call stack (most recent first):
  * safe_require("blocktype", "chemnih") at 
/var/www/html/mahara/htdocs/lib/upgrade.php:1128
  * install_blocktype_categories_for_plugin("chemnih") at 
/var/www/html/mahara/htdocs/lib/db/upgrade.php:3974
  * xmldb_core_upgrade("2014092314") at 
/var/www/html/mahara/htdocs/lib/upgrade.php:359
  * upgrade_core(object(stdClass)) at 
/var/www/html/mahara/htdocs/lib/mahara.php:253
  * upgrade_mahara(array(size 40)) at 
/var/www/html/mahara/htdocs/admin/cli/upgrade.php:50

A nonrecoverable error occurred. This probably means you have
encountered a bug in the systemroot@ubuntu:/var/www/html/mahara/htdocs#
git pull

--- Message I got after my second attempt
root@ubuntu:/var/www/html/mahara/htdocs# php admin/cli/upgrade.php
[INF] 87 (admin/cli/upgrade.php:49) Mise à jour de Mahara
[INF] 87 (lib/mahara.php:221) Mise à jour de core
[WAR] 87 (lib/errors.php:747) Failed to get a recordset: mysqli error: [1062: 
Duplicate entry 'shortcut' for key 'PRIMARY'] in adodb_throw(INSERT INTO 
"blocktype_category" ("name", "sort") VALUES ('shortcut', '0'), )
[WAR] 87 (lib/errors.php:747) Command was: INSERT INTO "blocktype_category" 
("name", "sort") VALUES (?, ?) and values was (shortcut,0)
Call stack (most recent first):
  * log_message("Failed to get a recordset: mysqli error: [1062: Du...", 8, 
true, true) at /var/www/html/mahara/htdocs/lib/errors.php:97
  * log_warn("Failed to get a recordset: mysqli error: [1062: Du...") at 
/var/www/html/mahara/htdocs/lib/errors.php:747
  * SQLException->__construct("Failed to get a recordset: mysqli error: [1062: 
Du...") at /var/www/html/mahara/htdocs/lib/dml.php:1054
  * insert_record("blocktype_category", object(stdClass)) at 
/var/www/html/mahara/htdocs/lib/db/upgrade.php:3856
  * xmldb_core_upgrade("2014092314") at 
/var/www/html/mahara/htdocs/lib/upgrade.php:359
  * upgrade_core(object(stdClass)) at 
/var/www/html/mahara/htdocs/lib/mahara.php:253
  * upgrade_mahara(array(size 40)) at 
/var/www/html/mahara/htdocs/admin/cli/upgrade.php:50

[WAR] 87 (lib/dml.php:1054) Failed to get a recordset: mysqli error: [1062: 
Duplicate entry 'shortcut' for key 'PRIMARY'] in adodb_throw(INSERT INTO 
"blocktype_category" ("name", "sort") VALUES ('shortcut', '0'), )
[WAR] 87 (lib/dml.php:1054) Command was: INSERT INTO "blocktype_category" 
("name", "sort") VALUES (?, ?) and values was (shortcut,0)
Call stack (most recent first):
  * insert_record("blocktype_category", object(stdClass)) at 
/var/www/html/mahara/htdocs/lib/db/upgrade.php:3856
  * xmldb_core_upgrade("2014092314") at 
/var/www/html/mahara/htdocs/lib/upgrade.php:359
  * upgrade_core(object(stdClass)) at 
/var/www/html/mahara/htdocs/lib/mahara.php:253
  * upgrade_mahara(array(size 40)) at 
/var/www/html/mahara/htdocs/admin/cli/upgrade.php:50

A nonrecoverable error occurred. This probably means you have
encountered a bug in the systemroot@ubuntu:/var/www/html/mahara/htdocs#

** Affects: mahara
 Importance: Undecided
 Status: New

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1455122

Title:
  Upgrade form 1.10 to 15.04 fails if 3rd party plugins are not present

Status in Mahara ePortfolio:
  New

Bug description:
  When upgrading from 1.10 (latest build) to 15.04 (latest build) today
  I get the following error because some 3rd party plugins are not
  present on my server but, due to the lack on auto-unstallation, their
  traces remain in the database.

  If