[Mahara-contributors] [Bug 1486813] A patch has been submitted for review
Patch for "1.9_STABLE" branch: https://reviews.mahara.org/5422 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1486813 Title: Prompt for new stat data after upgrade needs a 'no thanks' option Status in Mahara: Fix Committed Status in Mahara 1.10 series: New Status in Mahara 1.9 series: New Status in Mahara 15.04 series: New Bug description: With the patch for Bug 1450334 an admin on upgrade is redirected to the Register site page. If they navigate away rather than deciding to register the check 'new_registration_policy' is still active. This means that if the user upgrades again (or upgrades a plugin ) they are again redirected to the register site page. We need to alter the register site form so that there is a 'no thanks' (cancel) option that updates the 'new_registration_policy' to false as well otherwise it will get a bit annoying for those not wanting to register their site. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1486813/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1486813] A patch has been submitted for review
Patch for "15.04_STABLE" branch: https://reviews.mahara.org/5420 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1486813 Title: Prompt for new stat data after upgrade needs a 'no thanks' option Status in Mahara: Fix Committed Status in Mahara 1.10 series: New Status in Mahara 1.9 series: New Status in Mahara 15.04 series: New Bug description: With the patch for Bug 1450334 an admin on upgrade is redirected to the Register site page. If they navigate away rather than deciding to register the check 'new_registration_policy' is still active. This means that if the user upgrades again (or upgrades a plugin ) they are again redirected to the register site page. We need to alter the register site form so that there is a 'no thanks' (cancel) option that updates the 'new_registration_policy' to false as well otherwise it will get a bit annoying for those not wanting to register their site. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1486813/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1486813] A patch has been submitted for review
Patch for "1.10_STABLE" branch: https://reviews.mahara.org/5421 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1486813 Title: Prompt for new stat data after upgrade needs a 'no thanks' option Status in Mahara: Fix Committed Status in Mahara 1.10 series: New Status in Mahara 1.9 series: New Status in Mahara 15.04 series: New Bug description: With the patch for Bug 1450334 an admin on upgrade is redirected to the Register site page. If they navigate away rather than deciding to register the check 'new_registration_policy' is still active. This means that if the user upgrades again (or upgrades a plugin ) they are again redirected to the register site page. We need to alter the register site form so that there is a 'no thanks' (cancel) option that updates the 'new_registration_policy' to false as well otherwise it will get a bit annoying for those not wanting to register their site. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1486813/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1486813] A change has been merged
Reviewed: https://reviews.mahara.org/5421 Committed: https://git.nzoss.org.nz/mahara/mahara/commit/297b6003cb2a92a817fa64cbdaa98b6c5ca39ebd Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:1.10_STABLE commit 297b6003cb2a92a817fa64cbdaa98b6c5ca39ebd Author: Robert Lyon Date: Fri Sep 4 10:28:36 2015 +1200 Bug 1486813: Stop redirect to 'register site' page after each upgrade By adding a cancel option to the register site form that clears the new_registration_policy config setting. behatnotneeded Change-Id: I65cf7239b9fe021d17be387eeb8bfda9547c5032 Signed-off-by: Robert Lyon -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1486813 Title: Prompt for new stat data after upgrade needs a 'no thanks' option Status in Mahara: Fix Committed Status in Mahara 1.10 series: New Status in Mahara 1.9 series: New Status in Mahara 15.04 series: New Bug description: With the patch for Bug 1450334 an admin on upgrade is redirected to the Register site page. If they navigate away rather than deciding to register the check 'new_registration_policy' is still active. This means that if the user upgrades again (or upgrades a plugin ) they are again redirected to the register site page. We need to alter the register site form so that there is a 'no thanks' (cancel) option that updates the 'new_registration_policy' to false as well otherwise it will get a bit annoying for those not wanting to register their site. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1486813/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1486813] A change has been merged
Reviewed: https://reviews.mahara.org/5422 Committed: https://git.nzoss.org.nz/mahara/mahara/commit/824c1dbbec1e8f0419f94fa3596196871ca7317f Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:1.9_STABLE commit 824c1dbbec1e8f0419f94fa3596196871ca7317f Author: Robert Lyon Date: Fri Sep 4 10:28:36 2015 +1200 Bug 1486813: Stop redirect to 'register site' page after each upgrade By adding a cancel option to the register site form that clears the new_registration_policy config setting. behatnotneeded Change-Id: I65cf7239b9fe021d17be387eeb8bfda9547c5032 Signed-off-by: Robert Lyon -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1486813 Title: Prompt for new stat data after upgrade needs a 'no thanks' option Status in Mahara: Fix Committed Status in Mahara 1.10 series: New Status in Mahara 1.9 series: New Status in Mahara 15.04 series: New Bug description: With the patch for Bug 1450334 an admin on upgrade is redirected to the Register site page. If they navigate away rather than deciding to register the check 'new_registration_policy' is still active. This means that if the user upgrades again (or upgrades a plugin ) they are again redirected to the register site page. We need to alter the register site form so that there is a 'no thanks' (cancel) option that updates the 'new_registration_policy' to false as well otherwise it will get a bit annoying for those not wanting to register their site. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1486813/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1494908] Re: Memory exhausted on cron import_process_queue
** Changed in: mahara/15.04
Status: In Progress => Fix Committed
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1494908
Title:
Memory exhausted on cron import_process_queue
Status in Mahara:
Fix Committed
Status in Mahara 15.04 series:
Fix Committed
Status in Mahara 15.10 series:
Fix Committed
Bug description:
Hi,
We're on Mahara 1.10, running on Linux and MySQL.
We got this error :
[INF] c2 (lib/cron.php:30) -- cron running Wed, 09 Sep 2015 15:10:01
-0400 -- [INF] c2 (lib/cron.php:75) Running
PluginSearchElasticsearch::cron [INF] c2 (lib/cron.php:137) Running core cron
activity_process_queue [INF] c2 (lib/cron.php:137) Running core cron
import_process_queue PHP Fatal error: Allowed memory size of 134217728 bytes
exhausted (tried to allocate 20777539 bytes) in
/app/apache2/htdocs/mahara/lib/errors.php on line 148
We don't know exactly what happened, but a simple solution would be to add :
"raise_memory_limit('512M');"
in /import/lib.php, function import_process_queue().
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1494908/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1486813] Re: Prompt for new stat data after upgrade needs a 'no thanks' option
** Changed in: mahara/15.04 Importance: Undecided => High ** Changed in: mahara/1.9 Importance: Undecided => High ** Changed in: mahara/1.10 Importance: Undecided => High ** Changed in: mahara/1.10 Status: New => Fix Committed ** Changed in: mahara/1.9 Status: New => Fix Committed ** Changed in: mahara/15.04 Status: New => In Progress -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1486813 Title: Prompt for new stat data after upgrade needs a 'no thanks' option Status in Mahara: Fix Committed Status in Mahara 1.10 series: Fix Committed Status in Mahara 1.9 series: Fix Committed Status in Mahara 15.04 series: In Progress Bug description: With the patch for Bug 1450334 an admin on upgrade is redirected to the Register site page. If they navigate away rather than deciding to register the check 'new_registration_policy' is still active. This means that if the user upgrades again (or upgrades a plugin ) they are again redirected to the register site page. We need to alter the register site form so that there is a 'no thanks' (cancel) option that updates the 'new_registration_policy' to false as well otherwise it will get a bit annoying for those not wanting to register their site. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1486813/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1500215] A patch has been submitted for review
Patch for "1.10_STABLE" branch: https://reviews.mahara.org/5424 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1500215 Title: descending folders - setting does not carry to subfolders Status in Mahara: In Progress Status in Mahara 1.10 series: In Progress Status in Mahara 15.04 series: In Progress Bug description: Re: the feature "Sort files in the "Folder" block ascending or descending and set default sort order" When this feature was introduced in 1.9, if you set the folder to 'descending' then that setting also applied to all subfolders. Now, currently running version 15.04.2, if setting a folder to 'descending' then the subfolders within it are 'ascending' - and no way to change that. help, please? we need the subfolders to remain descending as is the top-level folder! thanks, Fran To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1500215/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1500215] A patch has been submitted for review
Patch for "15.04_STABLE" branch: https://reviews.mahara.org/5423 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1500215 Title: descending folders - setting does not carry to subfolders Status in Mahara: In Progress Status in Mahara 1.10 series: In Progress Status in Mahara 15.04 series: In Progress Bug description: Re: the feature "Sort files in the "Folder" block ascending or descending and set default sort order" When this feature was introduced in 1.9, if you set the folder to 'descending' then that setting also applied to all subfolders. Now, currently running version 15.04.2, if setting a folder to 'descending' then the subfolders within it are 'ascending' - and no way to change that. help, please? we need the subfolders to remain descending as is the top-level folder! thanks, Fran To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1500215/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1500215] A change has been merged
Reviewed: https://reviews.mahara.org/5424 Committed: https://git.nzoss.org.nz/mahara/mahara/commit/69c32f564e0d96fd6711cb5c094d18d0705dea62 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:1.10_STABLE commit 69c32f564e0d96fd6711cb5c094d18d0705dea62 Author: Robert Lyon Date: Tue Sep 29 09:34:52 2015 +1300 Bug 1500215: Loop through artefact ancestors in correct order Go from child to parent to grandparent etc. behatnotneeded Change-Id: If30d63483f33a50888a590875ddd979d6900c613 Signed-off-by: Robert Lyon (cherry picked from commit 244076406720a21251a1da0f4f270985ed16e36a) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1500215 Title: descending folders - setting does not carry to subfolders Status in Mahara: Fix Committed Status in Mahara 1.10 series: Fix Committed Status in Mahara 15.04 series: In Progress Bug description: Re: the feature "Sort files in the "Folder" block ascending or descending and set default sort order" When this feature was introduced in 1.9, if you set the folder to 'descending' then that setting also applied to all subfolders. Now, currently running version 15.04.2, if setting a folder to 'descending' then the subfolders within it are 'ascending' - and no way to change that. help, please? we need the subfolders to remain descending as is the top-level folder! thanks, Fran To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1500215/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1500215] Re: descending folders - setting does not carry to subfolders
** Changed in: mahara Status: In Progress => Fix Committed ** Changed in: mahara/1.10 Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1500215 Title: descending folders - setting does not carry to subfolders Status in Mahara: Fix Committed Status in Mahara 1.10 series: Fix Committed Status in Mahara 15.04 series: In Progress Bug description: Re: the feature "Sort files in the "Folder" block ascending or descending and set default sort order" When this feature was introduced in 1.9, if you set the folder to 'descending' then that setting also applied to all subfolders. Now, currently running version 15.04.2, if setting a folder to 'descending' then the subfolders within it are 'ascending' - and no way to change that. help, please? we need the subfolders to remain descending as is the top-level folder! thanks, Fran To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1500215/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1495676] A patch has been submitted for review
Patch for "15.04_STABLE" branch: https://reviews.mahara.org/5425 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1495676 Title: The setting 'maxuploadsize' did not count Status in Mahara: Fix Committed Status in Mahara 1.10 series: Fix Committed Status in Mahara 1.9 series: Fix Committed Status in Mahara 15.04 series: In Progress Bug description: Version: master(15.10), 15.04 In Mahara, the setting $cfg->maxuploadsize can be set to limit the maximum size for one upload. However, this value did not use to calculate the value of "Maximum upload size" to show in htdocs/artefact/file/index.php. Steps 1. Assume that the postmaxsize value in php setting is 32MB, quota is 50MB and there is no file in the user file area, set the value of $cfg->maxuploadsize to 16MB (16777216) 2. Login as the user, open file browser (htdocs/artefact/file/index.php) Expected result: - The value of "Maximum upload size" should be 16MB Actual: - The value is 32MB To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1495676/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1495676] A patch has been submitted for review
Patch for "1.10_STABLE" branch: https://reviews.mahara.org/5426 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1495676 Title: The setting 'maxuploadsize' did not count Status in Mahara: Fix Committed Status in Mahara 1.10 series: Fix Committed Status in Mahara 1.9 series: Fix Committed Status in Mahara 15.04 series: In Progress Bug description: Version: master(15.10), 15.04 In Mahara, the setting $cfg->maxuploadsize can be set to limit the maximum size for one upload. However, this value did not use to calculate the value of "Maximum upload size" to show in htdocs/artefact/file/index.php. Steps 1. Assume that the postmaxsize value in php setting is 32MB, quota is 50MB and there is no file in the user file area, set the value of $cfg->maxuploadsize to 16MB (16777216) 2. Login as the user, open file browser (htdocs/artefact/file/index.php) Expected result: - The value of "Maximum upload size" should be 16MB Actual: - The value is 32MB To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1495676/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1495676] A change has been merged
Reviewed: https://reviews.mahara.org/5427 Committed: https://git.nzoss.org.nz/mahara/mahara/commit/4503a05085aca330b6c87302c5e985829e7b07f8 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:1.9_STABLE commit 4503a05085aca330b6c87302c5e985829e7b07f8 Author: Son Nguyen Date: Mon Jul 13 11:11:53 2015 +1200 Take into account the mahara setting 'maxuploadsize'. Bug 1495676 behatnotneeded Change-Id: Icca153ae8d4728ff840bc088d719affb3b80a68f -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1495676 Title: The setting 'maxuploadsize' did not count Status in Mahara: Fix Committed Status in Mahara 1.10 series: Fix Committed Status in Mahara 1.9 series: Fix Committed Status in Mahara 15.04 series: In Progress Bug description: Version: master(15.10), 15.04 In Mahara, the setting $cfg->maxuploadsize can be set to limit the maximum size for one upload. However, this value did not use to calculate the value of "Maximum upload size" to show in htdocs/artefact/file/index.php. Steps 1. Assume that the postmaxsize value in php setting is 32MB, quota is 50MB and there is no file in the user file area, set the value of $cfg->maxuploadsize to 16MB (16777216) 2. Login as the user, open file browser (htdocs/artefact/file/index.php) Expected result: - The value of "Maximum upload size" should be 16MB Actual: - The value is 32MB To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1495676/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1494565] Re: Web services auth uses wrong lang string in auth list
** Changed in: mahara/15.04 Status: Confirmed => In Progress -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1494565 Title: Web services auth uses wrong lang string in auth list Status in Mahara: Fix Committed Status in Mahara 15.04 series: In Progress Bug description: Mahara 15.04 and 15.10 When you are on /admin/users/institutions.php and edit an institution, you an choose "Web services" from the list of authentication methods. The description only reads "Description" instead of the actual description "Web services-only users authenticated against Mahara's database". I tracked it down to the following (in Mahara 15.10): The "description" string on line 16 of /auth/webservice/lang/en.utf8/auth.webservice.php is correct. However, the auth list uses string "description" from line 153 from the section "wsdoc" instead. When I comment the wsdoc "description" out, the proper description shows up in the authlist. So changing the string ID for the wsdoc to "wsdocdescription" should all that is needed. Unfortunately, I couldn't identify where I could change the string in the code and thus couldn't change it myself. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1494565/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1495676] Re: The setting 'maxuploadsize' did not count
** Changed in: mahara/1.10 Status: In Progress => Fix Committed ** Changed in: mahara/1.9 Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1495676 Title: The setting 'maxuploadsize' did not count Status in Mahara: Fix Committed Status in Mahara 1.10 series: Fix Committed Status in Mahara 1.9 series: Fix Committed Status in Mahara 15.04 series: In Progress Bug description: Version: master(15.10), 15.04 In Mahara, the setting $cfg->maxuploadsize can be set to limit the maximum size for one upload. However, this value did not use to calculate the value of "Maximum upload size" to show in htdocs/artefact/file/index.php. Steps 1. Assume that the postmaxsize value in php setting is 32MB, quota is 50MB and there is no file in the user file area, set the value of $cfg->maxuploadsize to 16MB (16777216) 2. Login as the user, open file browser (htdocs/artefact/file/index.php) Expected result: - The value of "Maximum upload size" should be 16MB Actual: - The value is 32MB To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1495676/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1494565] A patch has been submitted for review
Patch for "15.04_STABLE" branch: https://reviews.mahara.org/5428 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1494565 Title: Web services auth uses wrong lang string in auth list Status in Mahara: Fix Committed Status in Mahara 15.04 series: In Progress Bug description: Mahara 15.04 and 15.10 When you are on /admin/users/institutions.php and edit an institution, you an choose "Web services" from the list of authentication methods. The description only reads "Description" instead of the actual description "Web services-only users authenticated against Mahara's database". I tracked it down to the following (in Mahara 15.10): The "description" string on line 16 of /auth/webservice/lang/en.utf8/auth.webservice.php is correct. However, the auth list uses string "description" from line 153 from the section "wsdoc" instead. When I comment the wsdoc "description" out, the proper description shows up in the authlist. So changing the string ID for the wsdoc to "wsdocdescription" should all that is needed. Unfortunately, I couldn't identify where I could change the string in the code and thus couldn't change it myself. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1494565/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1495676] Re: The setting 'maxuploadsize' did not count
** Changed in: mahara/1.10 Status: Fix Committed => In Progress -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1495676 Title: The setting 'maxuploadsize' did not count Status in Mahara: Fix Committed Status in Mahara 1.10 series: In Progress Status in Mahara 1.9 series: Fix Committed Status in Mahara 15.04 series: In Progress Bug description: Version: master(15.10), 15.04 In Mahara, the setting $cfg->maxuploadsize can be set to limit the maximum size for one upload. However, this value did not use to calculate the value of "Maximum upload size" to show in htdocs/artefact/file/index.php. Steps 1. Assume that the postmaxsize value in php setting is 32MB, quota is 50MB and there is no file in the user file area, set the value of $cfg->maxuploadsize to 16MB (16777216) 2. Login as the user, open file browser (htdocs/artefact/file/index.php) Expected result: - The value of "Maximum upload size" should be 16MB Actual: - The value is 32MB To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1495676/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1465107] A patch has been submitted for review
Patch for "master" branch: https://reviews.mahara.org/5429 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1465107 Title: Use the Bootstrap CSS framework Status in Mahara: In Progress Bug description: Mahara's CSS, and general front-end coding, is a bit chaotic. So for the past several months we've had a couple of front-end developers working on rewriting the entire Mahara front end to use the Bootstrap CSS framework. http://getbootstrap.com/css/ This should make all of our front-end development work easier henceforth, as well as providing a nice set of standard widgets to make Mahara look better right away. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1465107/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1465107] A patch has been submitted for review
Patch for "master" branch: https://reviews.mahara.org/5430 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1465107 Title: Use the Bootstrap CSS framework Status in Mahara: In Progress Bug description: Mahara's CSS, and general front-end coding, is a bit chaotic. So for the past several months we've had a couple of front-end developers working on rewriting the entire Mahara front end to use the Bootstrap CSS framework. http://getbootstrap.com/css/ This should make all of our front-end development work easier henceforth, as well as providing a nice set of standard widgets to make Mahara look better right away. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1465107/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1501078] Re: All user to set their theme to site default
IE and Firefox browsers are showing broken language strings on the landing page. Please see the attached screen shot. ** Attachment added: "IE 10 and Firefox broken language string" https://bugs.launchpad.net/mahara/+bug/1501078/+attachment/4481345/+files/IE%20broken%20language.png -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1501078 Title: All user to set their theme to site default Status in Mahara: In Progress Bug description: When the $cfg->sitethemeprefs = true; is set one can choose to use a particular theme. But they can't NOT choose a theme and just go with the site/institution default if they have already chosen. Will add a patch to allow the ability to choose 'No theme selected' To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1501078/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1262040] Re: Problems with group artefact permissions due to misuse of $USER->can_view_artefact and $USER->can_edit_artefact
** Changed in: mahara/15.04 Milestone: 15.04.4 => 15.04.5 ** Changed in: mahara/1.10 Milestone: 1.10.7 => 1.10.8 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1262040 Title: Problems with group artefact permissions due to misuse of $USER->can_view_artefact and $USER->can_edit_artefact Status in Mahara: Confirmed Status in Mahara 1.10 series: Confirmed Status in Mahara 1.8 series: Won't Fix Status in Mahara 1.9 series: Confirmed Status in Mahara 15.04 series: Confirmed Status in Mahara 15.10 series: In Progress Bug description: While discussing the export to ZIP bug ( Bug 1013022 ) I realized that $USER->can_view_artefact() does not do what I thought it did. I thought that it was like can_view_view(), i.e. it was an easy way to tell whether a particular user is allowed to see the contents of a particular artefact. But it does not mean that, as evidenced by the fact that it's not accessed at all on the artefact detail page, view/artefact.php. Instead, this function refers to whether or not the user should be able to see the artefact in their own or a group's Content area. The reason it exists and has this name, is because of the group files permissions system (see http://manual.mahara.org/en/1.8/groups/inside_group.html#index-16 ). This defines three permission levels for a file: "View" lets you see the page in Contents and use it in Group pages, "Edit" lets you change the file's metadata, and "Publish" lets you use the file in your own Portfolio pages. Anyway, I misunderstood it as doing the same thing as can_view_view(), which checks whether a particular user can see a particular Page in display-mode. The similar functionality for artefacts, as seen on view/artefact.php, is to provide an artefact ID & a page ID, and to check whether the artefact is in the page and the user can view the page. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1262040/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1415252] Re: New Behat step: We need a step for dialogue boxes
** Changed in: mahara/15.04 Milestone: 15.04.4 => 15.04.5 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1415252 Title: New Behat step: We need a step for dialogue boxes Status in Mahara: In Progress Status in Mahara 15.04 series: Confirmed Status in Mahara 15.10 series: In Progress Bug description: Hi, We need to implement a step that can click on the dialogue boxes when they pop up. I have attached a part of a test below, this should allow for a dialogue box to pop up so you can see it. I cant run it on my machine at the mo, but these are the steps that made the confirmation box to appear in 1.10. Thanks, Jinelle To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1415252/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1340151] Re: Consider a different approach to libxml_disable_entity_loader(true) in init.php
** Changed in: mahara/15.04
Milestone: 15.04.4 => 15.04.5
** Changed in: mahara/1.10
Milestone: 1.10.7 => 1.10.8
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1340151
Title:
Consider a different approach to libxml_disable_entity_loader(true) in
init.php
Status in Mahara:
Confirmed
Status in Mahara 1.10 series:
Confirmed
Status in Mahara 1.8 series:
Won't Fix
Status in Mahara 1.9 series:
Confirmed
Status in Mahara 15.04 series:
Confirmed
Status in Mahara 15.10 series:
Confirmed
Status in Mahara 16.04 series:
Confirmed
Bug description:
Unfortunately it seems like using libxml_disable_entity_loader(true)
in init.php is unkind to other applications living on the same system.
PHP Bug https://bugs.php.net/bug.php?id=64938 is the heart of the
problem - the use of this setting leaks between different threads and
by setting it for the duration of every single Mahara request this bug
comes into play much more easily.
The other problem is https://bugs.php.net/bug.php?id=62577 which means
that simplexml_load_file() will not even load *local* files off disk.
For example, this would break in Mahara even though no entities come
into play:
$xml = simplexml_load_file(get_config('libroot').'/db/install.xml');
In Moodle we've been warned on one of our issues that users have seen
this problem in the wild with Mahara, I didn't find an issue reported
to you about it, so i'll copy and paste the report from our tracker
here:
"We had experience with this problem on an upgrade to Mahara 1.7, when
https://bugs.launchpad.net/mahara/+bug/1047111 was fixed. The approach
was the same as is suggested in this ticket. This caused seemingly
random failures in Moodle (which is run on the same webserver)
whenever there was usage of Mahara. The root cause was not obvious,
nor well advertised with the Mahara fix, so it took awhile to finally
implement a fix. In the meantime, significant functionality is broken.
Unfortunately, there's really no way around this unless you switch
from using mod_php."
Yesterday whilst debugging some code with Yuliya we realised she also
was encountering this horrible combination of bugs affecting her
Moodle install so it seems this is not a theoretical problem.
In Moodle we have decided to use the same approach of many other projects and
enable/disable the loader around vulnerable code to reduce the chance of this
combination of bugs affecting other applications or uses of the the
simplexml_load_file:
http://cgit.drupalcode.org/drupal/commit/?id=b912710
https://github.com/symfony/symfony/blob/8ef8a1d289a6ce454b7c79baeddbfb45e4af6191/src/Symfony/Component/Config/Util/XmlUtils.php#L41
http://www.mediawiki.org/wiki/XML_External_Entity_Processing
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1340151/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1446395] Re: Behat tests: Removing duplicates and tidying tests
** Changed in: mahara/15.10 Status: In Progress => Fix Committed ** Changed in: mahara/15.04 Status: In Progress => Invalid ** Changed in: mahara/15.04 Milestone: 15.04.0 => None -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1446395 Title: Behat tests: Removing duplicates and tidying tests Status in Mahara: Fix Committed Status in Mahara 15.04 series: Invalid Status in Mahara 15.10 series: Fix Committed Bug description: Hi All, The suite needs a little maintenance and tidying. In order to make the tests run faster and be more efficient we need to tidy the tests up. Eg: put them into the correct folders, make sure they have appropriate tags for running them in groups, delete those that are testing duplicate things and also delete those that are directly duplicate tests. Thanks, Jinelle To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1446395/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1415247] Re: Behat uploading a file step is currently broken
** Changed in: mahara/15.04 Milestone: 15.04.4 => 15.04.5 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1415247 Title: Behat uploading a file step is currently broken Status in Mahara: In Progress Status in Mahara 15.04 series: Confirmed Status in Mahara 15.10 series: In Progress Bug description: Hi Sonn, There is an issue with the "Attaching a file" step. Currently it passes and says it's a success but they file doesn't actually attach. I have attached a test script below for you to test with. Thanks, Jinelle To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1415247/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1431659] Re: Problems importing Annotations via Leap2a
** Changed in: mahara/15.04 Milestone: 15.04.4 => 15.04.5 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1431659 Title: Problems importing Annotations via Leap2a Status in Mahara: Confirmed Status in Mahara 15.04 series: Confirmed Status in Mahara 15.10 series: Confirmed Status in Mahara 16.04 series: Confirmed Bug description: As reported on https://reviews.mahara.org/#/c/4123/: "When I import a Leap2A (a collection with two pages; one with a text and 2 annotation blocks and the other with an image block and an annotation block), I get "[INF] 83 (import/index.php:301) Leap2A import failed: Cannot find reflection entry for annotation." The text block does not have an embedded image. Just plain text." To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1431659/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1468137] Re: Change default dummy Behat PW
** Changed in: mahara/15.04 Milestone: 15.04.4 => 15.04.5 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1468137 Title: Change default dummy Behat PW Status in Mahara: Confirmed Status in Mahara 15.04 series: Confirmed Status in Mahara 15.10 series: Confirmed Bug description: Hi all, The dummy Behat PW needs to be changed from Password1 to something that's not on the list of PW's Mahara shouldn't accept To know what Mahara shouldn't accept please refer to the Sucky passwords list. When we come up with a solution please update the wiki page before closing this bug report off. https://wiki.mahara.org/wiki/Testing/Behat_Testing/Steps Thanks, Jinelle To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1468137/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1485763] Re: Submissions to group; only last five submissions display
** Changed in: mahara/15.04 Status: Confirmed => In Progress -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1485763 Title: Submissions to group; only last five submissions display Status in Mahara: Fix Committed Status in Mahara 15.04 series: In Progress Status in Mahara 15.10 series: Fix Committed Bug description: In a Controlled group page, under heading "Submissions to this group", only the last five submissions are listed. Clicking on the link for the Next page displays "undefined" under the same heading; we expect to see earlier submissions. Even if there are 35 submissions (generating estimated 7 pages) links for only two pages are offered. Link on 2/Next/Last: https://[mahara]/group/view.php?id=723&group=723&editing=&offset=5 Steps to reproduce: 1. With a user (teacher) with Site staff role, create a controlled group. 2. Add at least six users (students) to the group. 3. Logging in as each of the students in turn, submit a collection or page to the controlled group. (You may wish to view the list of entries under the group's 'Submissions to this group' heading as you go.) 4. When you've submitted more than five collections or pages, the link to page 2 / Next will appear. Clicking on the link will display the Group page with 'Submissions to this group' = undefined. Mahara 15.04.1, Linux, mySQL I believe this is our first use of a Controlled group in this way since we upgraded a few months ago from v1.9 a few months ago. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1485763/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1485763] A patch has been submitted for review
Patch for "15.04_STABLE" branch: https://reviews.mahara.org/5432 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1485763 Title: Submissions to group; only last five submissions display Status in Mahara: Fix Committed Status in Mahara 15.04 series: In Progress Status in Mahara 15.10 series: Fix Committed Bug description: In a Controlled group page, under heading "Submissions to this group", only the last five submissions are listed. Clicking on the link for the Next page displays "undefined" under the same heading; we expect to see earlier submissions. Even if there are 35 submissions (generating estimated 7 pages) links for only two pages are offered. Link on 2/Next/Last: https://[mahara]/group/view.php?id=723&group=723&editing=&offset=5 Steps to reproduce: 1. With a user (teacher) with Site staff role, create a controlled group. 2. Add at least six users (students) to the group. 3. Logging in as each of the students in turn, submit a collection or page to the controlled group. (You may wish to view the list of entries under the group's 'Submissions to this group' heading as you go.) 4. When you've submitted more than five collections or pages, the link to page 2 / Next will appear. Clicking on the link will display the Group page with 'Submissions to this group' = undefined. Mahara 15.04.1, Linux, mySQL I believe this is our first use of a Controlled group in this way since we upgraded a few months ago from v1.9 a few months ago. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1485763/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1486699] Re: Username character limit preventing login via SAML
** Changed in: mahara/1.10 Status: Confirmed => Fix Committed ** Changed in: mahara/1.9 Status: Confirmed => Fix Committed ** Changed in: mahara/15.04 Status: Confirmed => In Progress -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1486699 Title: Username character limit preventing login via SAML Status in Mahara: Fix Committed Status in Mahara 1.10 series: Fix Committed Status in Mahara 1.9 series: Fix Committed Status in Mahara 15.04 series: In Progress Bug description: Mahara version15.04.1 This report is in relation to my earlier forum post https://mahara.org/interaction/forum/topic.php?id=7310 but I have tracked down the problem. Issue: User is logging in via SAML and the user is being auto-created on first login. Remote username is a unique id (example: 51c717bc-425c-4b31-9674-d38ba03b4f1f) When the user tries subsequent logins they are rejected with a error message that the user already exists and cannot be created. Reason: When the user is auto-created only the first 30 characters of the unique id are stored in the username field so the user is not recognised as being on the system when cheaked agains the full username from the login. The system then tries to auto-create the user, which fails because the full unique id is stored in the 'auth_remote_user' table. Solution: Changing $maxlen from 30 to 40 in function get_new_username() of user.php populates the user name with the full unique id. Maybe this could be a configurable option? To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1486699/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1486699] A change has been merged
Reviewed: https://reviews.mahara.org/5435 Committed: https://git.nzoss.org.nz/mahara/mahara/commit/d6af8c863fb020477dfe95b155d6f639704c0568 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:1.9_STABLE commit d6af8c863fb020477dfe95b155d6f639704c0568 Author: Kevin Rickis Date: Mon Aug 24 09:34:22 2015 +1200 Bug 1486699: get_new_username() truncating username badly for SAML Ends up with username in auth_remote_user being different to the username in usr table. behatnotneeded Change-Id: If6a5a18360ef82da2e3a709899e7d4d1624e8fab Signed-off-by: Robert Lyon (cherry picked from commit dc3b3292415b17730e809afc0a9bfd80decd19a8) (cherry picked from commit 884b9f71d4479cb604ee071e32ec7480ac3ed203) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1486699 Title: Username character limit preventing login via SAML Status in Mahara: Fix Committed Status in Mahara 1.10 series: Fix Committed Status in Mahara 1.9 series: Fix Committed Status in Mahara 15.04 series: In Progress Bug description: Mahara version15.04.1 This report is in relation to my earlier forum post https://mahara.org/interaction/forum/topic.php?id=7310 but I have tracked down the problem. Issue: User is logging in via SAML and the user is being auto-created on first login. Remote username is a unique id (example: 51c717bc-425c-4b31-9674-d38ba03b4f1f) When the user tries subsequent logins they are rejected with a error message that the user already exists and cannot be created. Reason: When the user is auto-created only the first 30 characters of the unique id are stored in the username field so the user is not recognised as being on the system when cheaked agains the full username from the login. The system then tries to auto-create the user, which fails because the full unique id is stored in the 'auth_remote_user' table. Solution: Changing $maxlen from 30 to 40 in function get_new_username() of user.php populates the user name with the full unique id. Maybe this could be a configurable option? To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1486699/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1486699] A patch has been submitted for review
Patch for "1.10_STABLE" branch: https://reviews.mahara.org/5434 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1486699 Title: Username character limit preventing login via SAML Status in Mahara: Fix Committed Status in Mahara 1.10 series: Fix Committed Status in Mahara 1.9 series: Fix Committed Status in Mahara 15.04 series: In Progress Bug description: Mahara version15.04.1 This report is in relation to my earlier forum post https://mahara.org/interaction/forum/topic.php?id=7310 but I have tracked down the problem. Issue: User is logging in via SAML and the user is being auto-created on first login. Remote username is a unique id (example: 51c717bc-425c-4b31-9674-d38ba03b4f1f) When the user tries subsequent logins they are rejected with a error message that the user already exists and cannot be created. Reason: When the user is auto-created only the first 30 characters of the unique id are stored in the username field so the user is not recognised as being on the system when cheaked agains the full username from the login. The system then tries to auto-create the user, which fails because the full unique id is stored in the 'auth_remote_user' table. Solution: Changing $maxlen from 30 to 40 in function get_new_username() of user.php populates the user name with the full unique id. Maybe this could be a configurable option? To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1486699/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1486699] A patch has been submitted for review
Patch for "1.9_STABLE" branch: https://reviews.mahara.org/5435 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1486699 Title: Username character limit preventing login via SAML Status in Mahara: Fix Committed Status in Mahara 1.10 series: Fix Committed Status in Mahara 1.9 series: Fix Committed Status in Mahara 15.04 series: In Progress Bug description: Mahara version15.04.1 This report is in relation to my earlier forum post https://mahara.org/interaction/forum/topic.php?id=7310 but I have tracked down the problem. Issue: User is logging in via SAML and the user is being auto-created on first login. Remote username is a unique id (example: 51c717bc-425c-4b31-9674-d38ba03b4f1f) When the user tries subsequent logins they are rejected with a error message that the user already exists and cannot be created. Reason: When the user is auto-created only the first 30 characters of the unique id are stored in the username field so the user is not recognised as being on the system when cheaked agains the full username from the login. The system then tries to auto-create the user, which fails because the full unique id is stored in the 'auth_remote_user' table. Solution: Changing $maxlen from 30 to 40 in function get_new_username() of user.php populates the user name with the full unique id. Maybe this could be a configurable option? To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1486699/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1486699] A change has been merged
Reviewed: https://reviews.mahara.org/5434 Committed: https://git.nzoss.org.nz/mahara/mahara/commit/884b9f71d4479cb604ee071e32ec7480ac3ed203 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:1.10_STABLE commit 884b9f71d4479cb604ee071e32ec7480ac3ed203 Author: Kevin Rickis Date: Mon Aug 24 09:34:22 2015 +1200 Bug 1486699: get_new_username() truncating username badly for SAML Ends up with username in auth_remote_user being different to the username in usr table. behatnotneeded Change-Id: If6a5a18360ef82da2e3a709899e7d4d1624e8fab Signed-off-by: Robert Lyon (cherry picked from commit dc3b3292415b17730e809afc0a9bfd80decd19a8) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1486699 Title: Username character limit preventing login via SAML Status in Mahara: Fix Committed Status in Mahara 1.10 series: Fix Committed Status in Mahara 1.9 series: Fix Committed Status in Mahara 15.04 series: In Progress Bug description: Mahara version15.04.1 This report is in relation to my earlier forum post https://mahara.org/interaction/forum/topic.php?id=7310 but I have tracked down the problem. Issue: User is logging in via SAML and the user is being auto-created on first login. Remote username is a unique id (example: 51c717bc-425c-4b31-9674-d38ba03b4f1f) When the user tries subsequent logins they are rejected with a error message that the user already exists and cannot be created. Reason: When the user is auto-created only the first 30 characters of the unique id are stored in the username field so the user is not recognised as being on the system when cheaked agains the full username from the login. The system then tries to auto-create the user, which fails because the full unique id is stored in the 'auth_remote_user' table. Solution: Changing $maxlen from 30 to 40 in function get_new_username() of user.php populates the user name with the full unique id. Maybe this could be a configurable option? To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1486699/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1486699] A patch has been submitted for review
Patch for "15.04_STABLE" branch: https://reviews.mahara.org/5433 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1486699 Title: Username character limit preventing login via SAML Status in Mahara: Fix Committed Status in Mahara 1.10 series: Fix Committed Status in Mahara 1.9 series: Fix Committed Status in Mahara 15.04 series: In Progress Bug description: Mahara version15.04.1 This report is in relation to my earlier forum post https://mahara.org/interaction/forum/topic.php?id=7310 but I have tracked down the problem. Issue: User is logging in via SAML and the user is being auto-created on first login. Remote username is a unique id (example: 51c717bc-425c-4b31-9674-d38ba03b4f1f) When the user tries subsequent logins they are rejected with a error message that the user already exists and cannot be created. Reason: When the user is auto-created only the first 30 characters of the unique id are stored in the username field so the user is not recognised as being on the system when cheaked agains the full username from the login. The system then tries to auto-create the user, which fails because the full unique id is stored in the 'auth_remote_user' table. Solution: Changing $maxlen from 30 to 40 in function get_new_username() of user.php populates the user name with the full unique id. Maybe this could be a configurable option? To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1486699/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1487464] A patch has been submitted for review
Patch for "1.10_STABLE" branch: https://reviews.mahara.org/5437
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1487464
Title:
SAML Update user details on login option creating new email artefact
on every login
Status in Mahara:
Fix Committed
Status in Mahara 1.10 series:
Confirmed
Status in Mahara 1.9 series:
Confirmed
Status in Mahara 15.04 series:
Confirmed
Bug description:
Mahara version: 15.04.1
Issue: When a user logs in via SAML and the configuration option is
set to update the user's details then a new email artefact is created
every time.
I think I have traced the problem
saml/lib.php line #234 calls set_profile_field($user->id, 'email',
$email);
lib/user.php lines #511-516 are a try{} in which $email =
artefact_instance_from_type('email', $userid); is called.
This fails with the message "This artefact type is not a 'singular'
artefact type" and so a new email artefact is created.
It will always fail because artefact/internal/lib.php lines #705-708
returns false for is_singular()
class ArtefactTypeEmail extends ArtefactTypeProfileField {
public static function is_singular() {
return false;
}
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1487464/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1487464] A patch has been submitted for review
Patch for "15.04_STABLE" branch: https://reviews.mahara.org/5436
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1487464
Title:
SAML Update user details on login option creating new email artefact
on every login
Status in Mahara:
Fix Committed
Status in Mahara 1.10 series:
Confirmed
Status in Mahara 1.9 series:
Confirmed
Status in Mahara 15.04 series:
Confirmed
Bug description:
Mahara version: 15.04.1
Issue: When a user logs in via SAML and the configuration option is
set to update the user's details then a new email artefact is created
every time.
I think I have traced the problem
saml/lib.php line #234 calls set_profile_field($user->id, 'email',
$email);
lib/user.php lines #511-516 are a try{} in which $email =
artefact_instance_from_type('email', $userid); is called.
This fails with the message "This artefact type is not a 'singular'
artefact type" and so a new email artefact is created.
It will always fail because artefact/internal/lib.php lines #705-708
returns false for is_singular()
class ArtefactTypeEmail extends ArtefactTypeProfileField {
public static function is_singular() {
return false;
}
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1487464/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1487464] A patch has been submitted for review
Patch for "1.9_STABLE" branch: https://reviews.mahara.org/5438
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1487464
Title:
SAML Update user details on login option creating new email artefact
on every login
Status in Mahara:
Fix Committed
Status in Mahara 1.10 series:
Confirmed
Status in Mahara 1.9 series:
Confirmed
Status in Mahara 15.04 series:
Confirmed
Bug description:
Mahara version: 15.04.1
Issue: When a user logs in via SAML and the configuration option is
set to update the user's details then a new email artefact is created
every time.
I think I have traced the problem
saml/lib.php line #234 calls set_profile_field($user->id, 'email',
$email);
lib/user.php lines #511-516 are a try{} in which $email =
artefact_instance_from_type('email', $userid); is called.
This fails with the message "This artefact type is not a 'singular'
artefact type" and so a new email artefact is created.
It will always fail because artefact/internal/lib.php lines #705-708
returns false for is_singular()
class ArtefactTypeEmail extends ArtefactTypeProfileField {
public static function is_singular() {
return false;
}
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1487464/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1495676] Re: The setting 'maxuploadsize' did not count
** Changed in: mahara/1.10 Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1495676 Title: The setting 'maxuploadsize' did not count Status in Mahara: Fix Committed Status in Mahara 1.10 series: Fix Committed Status in Mahara 1.9 series: Fix Committed Status in Mahara 15.04 series: In Progress Bug description: Version: master(15.10), 15.04 In Mahara, the setting $cfg->maxuploadsize can be set to limit the maximum size for one upload. However, this value did not use to calculate the value of "Maximum upload size" to show in htdocs/artefact/file/index.php. Steps 1. Assume that the postmaxsize value in php setting is 32MB, quota is 50MB and there is no file in the user file area, set the value of $cfg->maxuploadsize to 16MB (16777216) 2. Login as the user, open file browser (htdocs/artefact/file/index.php) Expected result: - The value of "Maximum upload size" should be 16MB Actual: - The value is 32MB To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1495676/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1465107] A patch has been submitted for review
Patch for "15.10_STABLE" branch: https://reviews.mahara.org/5439 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1465107 Title: Use the Bootstrap CSS framework Status in Mahara: In Progress Bug description: Mahara's CSS, and general front-end coding, is a bit chaotic. So for the past several months we've had a couple of front-end developers working on rewriting the entire Mahara front end to use the Bootstrap CSS framework. http://getbootstrap.com/css/ This should make all of our front-end development work easier henceforth, as well as providing a nice set of standard widgets to make Mahara look better right away. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1465107/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1465107] A change has been merged
Reviewed: https://reviews.mahara.org/5415 Committed: https://git.nzoss.org.nz/mahara/mahara/commit/74c6631166c35743d55805e55c88486a3a73317c Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:master commit 74c6631166c35743d55805e55c88486a3a73317c Author: Liam Sharpe Date: Thu Oct 1 17:05:28 2015 +1300 Removed the extra line on the plugin page and refactored some btn-group- items code - Bug #1465107 behatnotneeded Change-Id: I1b6edd6a429a25ec51dcdef67b74f05e1ad03544 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1465107 Title: Use the Bootstrap CSS framework Status in Mahara: In Progress Bug description: Mahara's CSS, and general front-end coding, is a bit chaotic. So for the past several months we've had a couple of front-end developers working on rewriting the entire Mahara front end to use the Bootstrap CSS framework. http://getbootstrap.com/css/ This should make all of our front-end development work easier henceforth, as well as providing a nice set of standard widgets to make Mahara look better right away. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1465107/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1465107] A change has been merged
Reviewed: https://reviews.mahara.org/5439 Committed: https://git.nzoss.org.nz/mahara/mahara/commit/78074cce960c3023a66d350d35798264a2ec5381 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:15.10_STABLE commit 78074cce960c3023a66d350d35798264a2ec5381 Author: Liam Sharpe Date: Thu Oct 1 17:05:28 2015 +1300 Removed the extra line on the plugin page and refactored some btn-group- items code - Bug #1465107 behatnotneeded Change-Id: I1b6edd6a429a25ec51dcdef67b74f05e1ad03544 (cherry picked from commit 74c6631166c35743d55805e55c88486a3a73317c) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1465107 Title: Use the Bootstrap CSS framework Status in Mahara: In Progress Bug description: Mahara's CSS, and general front-end coding, is a bit chaotic. So for the past several months we've had a couple of front-end developers working on rewriting the entire Mahara front end to use the Bootstrap CSS framework. http://getbootstrap.com/css/ This should make all of our front-end development work easier henceforth, as well as providing a nice set of standard widgets to make Mahara look better right away. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1465107/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1487464] A change has been merged
Reviewed: https://reviews.mahara.org/5437
Committed:
https://git.nzoss.org.nz/mahara/mahara/commit/0ac92e839662e22d6913a24609633ee19a46cfe1
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:1.10_STABLE
commit 0ac92e839662e22d6913a24609633ee19a46cfe1
Author: Kevin Rickis
Date: Mon Aug 24 09:50:47 2015 +1200
Bug 1487464: SAML creating new email artefact on login
Problem is the dealing with the email artefact type happens after the check
for is_singular(), which 'email' artefact type is not.
behatnotneeded
Change-Id: I4d1ffbb2fb89cc705bf3e2e6211f22e24ca55b26
Signed-off-by: Robert Lyon
(cherry picked from commit 4eec36102eadf8da684806afe5600e79e28e7737)
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1487464
Title:
SAML Update user details on login option creating new email artefact
on every login
Status in Mahara:
Fix Committed
Status in Mahara 1.10 series:
Fix Committed
Status in Mahara 1.9 series:
Fix Committed
Status in Mahara 15.04 series:
In Progress
Bug description:
Mahara version: 15.04.1
Issue: When a user logs in via SAML and the configuration option is
set to update the user's details then a new email artefact is created
every time.
I think I have traced the problem
saml/lib.php line #234 calls set_profile_field($user->id, 'email',
$email);
lib/user.php lines #511-516 are a try{} in which $email =
artefact_instance_from_type('email', $userid); is called.
This fails with the message "This artefact type is not a 'singular'
artefact type" and so a new email artefact is created.
It will always fail because artefact/internal/lib.php lines #705-708
returns false for is_singular()
class ArtefactTypeEmail extends ArtefactTypeProfileField {
public static function is_singular() {
return false;
}
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1487464/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1487464] A change has been merged
Reviewed: https://reviews.mahara.org/5438
Committed:
https://git.nzoss.org.nz/mahara/mahara/commit/3aeefdf1b83547303df0d9539bef9d169a8627eb
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:1.9_STABLE
commit 3aeefdf1b83547303df0d9539bef9d169a8627eb
Author: Kevin Rickis
Date: Mon Aug 24 09:50:47 2015 +1200
Bug 1487464: SAML creating new email artefact on login
Problem is the dealing with the email artefact type happens after the check
for is_singular(), which 'email' artefact type is not.
behatnotneeded
Change-Id: I4d1ffbb2fb89cc705bf3e2e6211f22e24ca55b26
Signed-off-by: Robert Lyon
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1487464
Title:
SAML Update user details on login option creating new email artefact
on every login
Status in Mahara:
Fix Committed
Status in Mahara 1.10 series:
Fix Committed
Status in Mahara 1.9 series:
Fix Committed
Status in Mahara 15.04 series:
In Progress
Bug description:
Mahara version: 15.04.1
Issue: When a user logs in via SAML and the configuration option is
set to update the user's details then a new email artefact is created
every time.
I think I have traced the problem
saml/lib.php line #234 calls set_profile_field($user->id, 'email',
$email);
lib/user.php lines #511-516 are a try{} in which $email =
artefact_instance_from_type('email', $userid); is called.
This fails with the message "This artefact type is not a 'singular'
artefact type" and so a new email artefact is created.
It will always fail because artefact/internal/lib.php lines #705-708
returns false for is_singular()
class ArtefactTypeEmail extends ArtefactTypeProfileField {
public static function is_singular() {
return false;
}
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1487464/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1487464] Re: SAML Update user details on login option creating new email artefact on every login
** Changed in: mahara/1.10
Status: Confirmed => Fix Committed
** Changed in: mahara/1.9
Status: Confirmed => Fix Committed
** Changed in: mahara/15.04
Status: Confirmed => In Progress
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1487464
Title:
SAML Update user details on login option creating new email artefact
on every login
Status in Mahara:
Fix Committed
Status in Mahara 1.10 series:
Fix Committed
Status in Mahara 1.9 series:
Fix Committed
Status in Mahara 15.04 series:
In Progress
Bug description:
Mahara version: 15.04.1
Issue: When a user logs in via SAML and the configuration option is
set to update the user's details then a new email artefact is created
every time.
I think I have traced the problem
saml/lib.php line #234 calls set_profile_field($user->id, 'email',
$email);
lib/user.php lines #511-516 are a try{} in which $email =
artefact_instance_from_type('email', $userid); is called.
This fails with the message "This artefact type is not a 'singular'
artefact type" and so a new email artefact is created.
It will always fail because artefact/internal/lib.php lines #705-708
returns false for is_singular()
class ArtefactTypeEmail extends ArtefactTypeProfileField {
public static function is_singular() {
return false;
}
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1487464/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1495676] A change has been merged
Reviewed: https://reviews.mahara.org/5426 Committed: https://git.nzoss.org.nz/mahara/mahara/commit/dc0695faf66ec84566c62dd538ff3d0d0ff670ed Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:1.10_STABLE commit dc0695faf66ec84566c62dd538ff3d0d0ff670ed Author: Son Nguyen Date: Mon Jul 13 11:11:53 2015 +1200 Take into account the mahara setting 'maxuploadsize'. Bug 1495676 behatnotneeded Change-Id: Icca153ae8d4728ff840bc088d719affb3b80a68f -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1495676 Title: The setting 'maxuploadsize' did not count Status in Mahara: Fix Committed Status in Mahara 1.10 series: Fix Committed Status in Mahara 1.9 series: Fix Committed Status in Mahara 15.04 series: In Progress Bug description: Version: master(15.10), 15.04 In Mahara, the setting $cfg->maxuploadsize can be set to limit the maximum size for one upload. However, this value did not use to calculate the value of "Maximum upload size" to show in htdocs/artefact/file/index.php. Steps 1. Assume that the postmaxsize value in php setting is 32MB, quota is 50MB and there is no file in the user file area, set the value of $cfg->maxuploadsize to 16MB (16777216) 2. Login as the user, open file browser (htdocs/artefact/file/index.php) Expected result: - The value of "Maximum upload size" should be 16MB Actual: - The value is 32MB To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1495676/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1499122] A patch has been submitted for review
Patch for "master" branch: https://reviews.mahara.org/5440 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1499122 Title: Threaded comments display in the wrong order Status in Mahara: Confirmed Status in Mahara 15.10 series: Confirmed Status in Mahara 16.04 series: Confirmed Bug description: To replicate: 1. Clean install of Mahara 2. In the "No institution" settings, turn on threaded comments. Leave the comment sort order on the default "ascending" 3. Create a page 4. Leave about 10 comments on the page. Don't make any of them be replies. Expected result: Because the comments aren't replies, they should be displayed on the page in the order they were created Actual result: After the first few comments are posted, comments will start showing up at the top of the list of comments The reason for this is because the sortorder for "threaded ascending" is (artefact.path, artefact.ctime, id). Since artefact.path is a string, and gets sorted in alphabetical order, when the artefact IDs go from 1 digit to 2 digits, the 1 digit ones will start sorting below the 2 digit ones. I.e. "/11" comes before "/6", in string sorting order. A similar thing will happen if threaded comments are sorted in descending order. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1499122/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1496681] A change has been merged
Reviewed: https://reviews.mahara.org/5442 Committed: https://git.nzoss.org.nz/mahara/mahara/commit/e2d001a8873c3897ef088d6ed609f11846c82c41 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:master commit e2d001a8873c3897ef088d6ed609f11846c82c41 Author: Aaron Wells Date: Wed Sep 30 17:15:49 2015 +1300 Remove unnecessary cached form from the session Bug 1495200 & Bug 1496681 behatnotneeded: Well, we could test this, but it would require a 60-second wait for the session to timeout (since the least you can set the session timeout via the UI is 1 minute) Change-Id: Ia5c861c16b6c893ada9d5eb2111f0b6a9aee49ad (cherry picked from commit aee374c0aa5d89cadba50a2eff2891af4ee751c0) (cherry picked from commit 784dbf9d5a5a8fc31a7d5b49bbcb41fe68578b7b) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1496681 Title: Login box lang strings don't change when language is switched Status in Mahara: Fix Committed Status in Mahara 1.10 series: Fix Committed Status in Mahara 1.9 series: Fix Committed Status in Mahara 15.04 series: Fix Committed Status in Mahara 15.10 series: Fix Committed Status in Mahara 16.04 series: Fix Committed Bug description: Evonne found the following on her instance of 15.10dev: When she changes the language and clicks the "Change" button, the inside of the login box is not changed. She needs to refresh the page to get the other language's strings. The text in the middle and also the "Links and resources" strings change. The title of the login box changes, but not "Username", "Password", the register etc. links and the help. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1496681/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1495200] A patch has been submitted for review
Patch for "master" branch: https://reviews.mahara.org/5442 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1495200 Title: White screen when session times out Status in Mahara: Fix Committed Status in Mahara 1.10 series: Fix Committed Status in Mahara 1.9 series: Fix Committed Status in Mahara 15.04 series: Fix Committed Status in Mahara 15.10 series: Fix Committed Status in Mahara 16.04 series: Fix Committed Bug description: Issue with 15.10 If you are logged into mahara and leave the site open in a browser for some time when you come back and try to navigate somewhere you can end up with a white blank screen - on refresh of page all works fine. The problem is this: PHP Fatal error: auth_generate_login_form(): The script tried to execute a method or access a property of an incomplete object. Please ensure that the class definition "Pieform" of the object you are trying to operate on was loaded _before_ unserialize() gets called or provide a __autoload() function to load the class definition in /home/robertl/htdocs/mahara-devel/mahara/htdocs/auth/lib.php on line 1945 Which deals with the line: return get_login_form_js($SESSION->loginform->build()); In earlier Mahara you would instead be given (via js) a popup login box. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1495200/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1496681] A change has been merged
Reviewed: https://reviews.mahara.org/5407 Committed: https://git.nzoss.org.nz/mahara/mahara/commit/aee374c0aa5d89cadba50a2eff2891af4ee751c0 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:15.04_STABLE commit aee374c0aa5d89cadba50a2eff2891af4ee751c0 Author: Aaron Wells Date: Wed Sep 30 17:15:49 2015 +1300 Remove unnecessary cached form from the session Bug 1495200 & Bug 1496681 behatnotneeded: Well, we could test this, but it would require a 60-second wait for the session to timeout (since the least you can set the session timeout via the UI is 1 minute) Change-Id: Ia5c861c16b6c893ada9d5eb2111f0b6a9aee49ad -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1496681 Title: Login box lang strings don't change when language is switched Status in Mahara: Fix Committed Status in Mahara 1.10 series: Fix Committed Status in Mahara 1.9 series: Fix Committed Status in Mahara 15.04 series: Fix Committed Status in Mahara 15.10 series: Fix Committed Status in Mahara 16.04 series: Fix Committed Bug description: Evonne found the following on her instance of 15.10dev: When she changes the language and clicks the "Change" button, the inside of the login box is not changed. She needs to refresh the page to get the other language's strings. The text in the middle and also the "Links and resources" strings change. The title of the login box changes, but not "Username", "Password", the register etc. links and the help. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1496681/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1495200] A patch has been submitted for review
Patch for "1.10_STABLE" branch: https://reviews.mahara.org/5443 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1495200 Title: White screen when session times out Status in Mahara: Fix Committed Status in Mahara 1.10 series: Fix Committed Status in Mahara 1.9 series: Fix Committed Status in Mahara 15.04 series: Fix Committed Status in Mahara 15.10 series: Fix Committed Status in Mahara 16.04 series: Fix Committed Bug description: Issue with 15.10 If you are logged into mahara and leave the site open in a browser for some time when you come back and try to navigate somewhere you can end up with a white blank screen - on refresh of page all works fine. The problem is this: PHP Fatal error: auth_generate_login_form(): The script tried to execute a method or access a property of an incomplete object. Please ensure that the class definition "Pieform" of the object you are trying to operate on was loaded _before_ unserialize() gets called or provide a __autoload() function to load the class definition in /home/robertl/htdocs/mahara-devel/mahara/htdocs/auth/lib.php on line 1945 Which deals with the line: return get_login_form_js($SESSION->loginform->build()); In earlier Mahara you would instead be given (via js) a popup login box. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1495200/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1496681] A patch has been submitted for review
Patch for "1.10_STABLE" branch: https://reviews.mahara.org/5443 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1496681 Title: Login box lang strings don't change when language is switched Status in Mahara: Fix Committed Status in Mahara 1.10 series: Fix Committed Status in Mahara 1.9 series: Fix Committed Status in Mahara 15.04 series: Fix Committed Status in Mahara 15.10 series: Fix Committed Status in Mahara 16.04 series: Fix Committed Bug description: Evonne found the following on her instance of 15.10dev: When she changes the language and clicks the "Change" button, the inside of the login box is not changed. She needs to refresh the page to get the other language's strings. The text in the middle and also the "Links and resources" strings change. The title of the login box changes, but not "Username", "Password", the register etc. links and the help. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1496681/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1495200] A change has been merged
Reviewed: https://reviews.mahara.org/5441 Committed: https://git.nzoss.org.nz/mahara/mahara/commit/784dbf9d5a5a8fc31a7d5b49bbcb41fe68578b7b Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:15.10_STABLE commit 784dbf9d5a5a8fc31a7d5b49bbcb41fe68578b7b Author: Aaron Wells Date: Wed Sep 30 17:15:49 2015 +1300 Remove unnecessary cached form from the session Bug 1495200 & Bug 1496681 behatnotneeded: Well, we could test this, but it would require a 60-second wait for the session to timeout (since the least you can set the session timeout via the UI is 1 minute) Change-Id: Ia5c861c16b6c893ada9d5eb2111f0b6a9aee49ad (cherry picked from commit aee374c0aa5d89cadba50a2eff2891af4ee751c0) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1495200 Title: White screen when session times out Status in Mahara: Fix Committed Status in Mahara 1.10 series: Fix Committed Status in Mahara 1.9 series: Fix Committed Status in Mahara 15.04 series: Fix Committed Status in Mahara 15.10 series: Fix Committed Status in Mahara 16.04 series: Fix Committed Bug description: Issue with 15.10 If you are logged into mahara and leave the site open in a browser for some time when you come back and try to navigate somewhere you can end up with a white blank screen - on refresh of page all works fine. The problem is this: PHP Fatal error: auth_generate_login_form(): The script tried to execute a method or access a property of an incomplete object. Please ensure that the class definition "Pieform" of the object you are trying to operate on was loaded _before_ unserialize() gets called or provide a __autoload() function to load the class definition in /home/robertl/htdocs/mahara-devel/mahara/htdocs/auth/lib.php on line 1945 Which deals with the line: return get_login_form_js($SESSION->loginform->build()); In earlier Mahara you would instead be given (via js) a popup login box. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1495200/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1495200] A patch has been submitted for review
Patch for "15.10_STABLE" branch: https://reviews.mahara.org/5441 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1495200 Title: White screen when session times out Status in Mahara: Fix Committed Status in Mahara 1.10 series: Fix Committed Status in Mahara 1.9 series: Fix Committed Status in Mahara 15.04 series: Fix Committed Status in Mahara 15.10 series: Fix Committed Status in Mahara 16.04 series: Fix Committed Bug description: Issue with 15.10 If you are logged into mahara and leave the site open in a browser for some time when you come back and try to navigate somewhere you can end up with a white blank screen - on refresh of page all works fine. The problem is this: PHP Fatal error: auth_generate_login_form(): The script tried to execute a method or access a property of an incomplete object. Please ensure that the class definition "Pieform" of the object you are trying to operate on was loaded _before_ unserialize() gets called or provide a __autoload() function to load the class definition in /home/robertl/htdocs/mahara-devel/mahara/htdocs/auth/lib.php on line 1945 Which deals with the line: return get_login_form_js($SESSION->loginform->build()); In earlier Mahara you would instead be given (via js) a popup login box. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1495200/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1495200] A change has been merged
Reviewed: https://reviews.mahara.org/5442 Committed: https://git.nzoss.org.nz/mahara/mahara/commit/e2d001a8873c3897ef088d6ed609f11846c82c41 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:master commit e2d001a8873c3897ef088d6ed609f11846c82c41 Author: Aaron Wells Date: Wed Sep 30 17:15:49 2015 +1300 Remove unnecessary cached form from the session Bug 1495200 & Bug 1496681 behatnotneeded: Well, we could test this, but it would require a 60-second wait for the session to timeout (since the least you can set the session timeout via the UI is 1 minute) Change-Id: Ia5c861c16b6c893ada9d5eb2111f0b6a9aee49ad (cherry picked from commit aee374c0aa5d89cadba50a2eff2891af4ee751c0) (cherry picked from commit 784dbf9d5a5a8fc31a7d5b49bbcb41fe68578b7b) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1495200 Title: White screen when session times out Status in Mahara: Fix Committed Status in Mahara 1.10 series: Fix Committed Status in Mahara 1.9 series: Fix Committed Status in Mahara 15.04 series: Fix Committed Status in Mahara 15.10 series: Fix Committed Status in Mahara 16.04 series: Fix Committed Bug description: Issue with 15.10 If you are logged into mahara and leave the site open in a browser for some time when you come back and try to navigate somewhere you can end up with a white blank screen - on refresh of page all works fine. The problem is this: PHP Fatal error: auth_generate_login_form(): The script tried to execute a method or access a property of an incomplete object. Please ensure that the class definition "Pieform" of the object you are trying to operate on was loaded _before_ unserialize() gets called or provide a __autoload() function to load the class definition in /home/robertl/htdocs/mahara-devel/mahara/htdocs/auth/lib.php on line 1945 Which deals with the line: return get_login_form_js($SESSION->loginform->build()); In earlier Mahara you would instead be given (via js) a popup login box. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1495200/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1495200] A change has been merged
Reviewed: https://reviews.mahara.org/5407 Committed: https://git.nzoss.org.nz/mahara/mahara/commit/aee374c0aa5d89cadba50a2eff2891af4ee751c0 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:15.04_STABLE commit aee374c0aa5d89cadba50a2eff2891af4ee751c0 Author: Aaron Wells Date: Wed Sep 30 17:15:49 2015 +1300 Remove unnecessary cached form from the session Bug 1495200 & Bug 1496681 behatnotneeded: Well, we could test this, but it would require a 60-second wait for the session to timeout (since the least you can set the session timeout via the UI is 1 minute) Change-Id: Ia5c861c16b6c893ada9d5eb2111f0b6a9aee49ad -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1495200 Title: White screen when session times out Status in Mahara: Fix Committed Status in Mahara 1.10 series: Fix Committed Status in Mahara 1.9 series: Fix Committed Status in Mahara 15.04 series: Fix Committed Status in Mahara 15.10 series: Fix Committed Status in Mahara 16.04 series: Fix Committed Bug description: Issue with 15.10 If you are logged into mahara and leave the site open in a browser for some time when you come back and try to navigate somewhere you can end up with a white blank screen - on refresh of page all works fine. The problem is this: PHP Fatal error: auth_generate_login_form(): The script tried to execute a method or access a property of an incomplete object. Please ensure that the class definition "Pieform" of the object you are trying to operate on was loaded _before_ unserialize() gets called or provide a __autoload() function to load the class definition in /home/robertl/htdocs/mahara-devel/mahara/htdocs/auth/lib.php on line 1945 Which deals with the line: return get_login_form_js($SESSION->loginform->build()); In earlier Mahara you would instead be given (via js) a popup login box. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1495200/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1496681] A change has been merged
Reviewed: https://reviews.mahara.org/5441 Committed: https://git.nzoss.org.nz/mahara/mahara/commit/784dbf9d5a5a8fc31a7d5b49bbcb41fe68578b7b Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:15.10_STABLE commit 784dbf9d5a5a8fc31a7d5b49bbcb41fe68578b7b Author: Aaron Wells Date: Wed Sep 30 17:15:49 2015 +1300 Remove unnecessary cached form from the session Bug 1495200 & Bug 1496681 behatnotneeded: Well, we could test this, but it would require a 60-second wait for the session to timeout (since the least you can set the session timeout via the UI is 1 minute) Change-Id: Ia5c861c16b6c893ada9d5eb2111f0b6a9aee49ad (cherry picked from commit aee374c0aa5d89cadba50a2eff2891af4ee751c0) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1496681 Title: Login box lang strings don't change when language is switched Status in Mahara: Fix Committed Status in Mahara 1.10 series: Fix Committed Status in Mahara 1.9 series: Fix Committed Status in Mahara 15.04 series: Fix Committed Status in Mahara 15.10 series: Fix Committed Status in Mahara 16.04 series: Fix Committed Bug description: Evonne found the following on her instance of 15.10dev: When she changes the language and clicks the "Change" button, the inside of the login box is not changed. She needs to refresh the page to get the other language's strings. The text in the middle and also the "Links and resources" strings change. The title of the login box changes, but not "Username", "Password", the register etc. links and the help. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1496681/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1496681] A patch has been submitted for review
Patch for "15.10_STABLE" branch: https://reviews.mahara.org/5441 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1496681 Title: Login box lang strings don't change when language is switched Status in Mahara: Fix Committed Status in Mahara 1.10 series: Fix Committed Status in Mahara 1.9 series: Fix Committed Status in Mahara 15.04 series: Fix Committed Status in Mahara 15.10 series: Fix Committed Status in Mahara 16.04 series: Fix Committed Bug description: Evonne found the following on her instance of 15.10dev: When she changes the language and clicks the "Change" button, the inside of the login box is not changed. She needs to refresh the page to get the other language's strings. The text in the middle and also the "Links and resources" strings change. The title of the login box changes, but not "Username", "Password", the register etc. links and the help. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1496681/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1496681] A patch has been submitted for review
Patch for "master" branch: https://reviews.mahara.org/5442 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1496681 Title: Login box lang strings don't change when language is switched Status in Mahara: Fix Committed Status in Mahara 1.10 series: Fix Committed Status in Mahara 1.9 series: Fix Committed Status in Mahara 15.04 series: Fix Committed Status in Mahara 15.10 series: Fix Committed Status in Mahara 16.04 series: Fix Committed Bug description: Evonne found the following on her instance of 15.10dev: When she changes the language and clicks the "Change" button, the inside of the login box is not changed. She needs to refresh the page to get the other language's strings. The text in the middle and also the "Links and resources" strings change. The title of the login box changes, but not "Username", "Password", the register etc. links and the help. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1496681/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1495200] A patch has been submitted for review
Patch for "1.9_STABLE" branch: https://reviews.mahara.org/5444 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1495200 Title: White screen when session times out Status in Mahara: Fix Committed Status in Mahara 1.10 series: Fix Committed Status in Mahara 1.9 series: Fix Committed Status in Mahara 15.04 series: Fix Committed Status in Mahara 15.10 series: Fix Committed Status in Mahara 16.04 series: Fix Committed Bug description: Issue with 15.10 If you are logged into mahara and leave the site open in a browser for some time when you come back and try to navigate somewhere you can end up with a white blank screen - on refresh of page all works fine. The problem is this: PHP Fatal error: auth_generate_login_form(): The script tried to execute a method or access a property of an incomplete object. Please ensure that the class definition "Pieform" of the object you are trying to operate on was loaded _before_ unserialize() gets called or provide a __autoload() function to load the class definition in /home/robertl/htdocs/mahara-devel/mahara/htdocs/auth/lib.php on line 1945 Which deals with the line: return get_login_form_js($SESSION->loginform->build()); In earlier Mahara you would instead be given (via js) a popup login box. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1495200/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1495200] A change has been merged
Reviewed: https://reviews.mahara.org/5443 Committed: https://git.nzoss.org.nz/mahara/mahara/commit/ea1bdc16d53ac5c659a9df853fae8fa891102e51 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:1.10_STABLE commit ea1bdc16d53ac5c659a9df853fae8fa891102e51 Author: Aaron Wells Date: Wed Sep 30 17:15:49 2015 +1300 Remove unnecessary cached form from the session Bug 1495200 & Bug 1496681 behatnotneeded: Well, we could test this, but it would require a 60-second wait for the session to timeout (since the least you can set the session timeout via the UI is 1 minute) Change-Id: Ia5c861c16b6c893ada9d5eb2111f0b6a9aee49ad (cherry picked from commit aee374c0aa5d89cadba50a2eff2891af4ee751c0) (cherry picked from commit 784dbf9d5a5a8fc31a7d5b49bbcb41fe68578b7b) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1495200 Title: White screen when session times out Status in Mahara: Fix Committed Status in Mahara 1.10 series: Fix Committed Status in Mahara 1.9 series: Fix Committed Status in Mahara 15.04 series: Fix Committed Status in Mahara 15.10 series: Fix Committed Status in Mahara 16.04 series: Fix Committed Bug description: Issue with 15.10 If you are logged into mahara and leave the site open in a browser for some time when you come back and try to navigate somewhere you can end up with a white blank screen - on refresh of page all works fine. The problem is this: PHP Fatal error: auth_generate_login_form(): The script tried to execute a method or access a property of an incomplete object. Please ensure that the class definition "Pieform" of the object you are trying to operate on was loaded _before_ unserialize() gets called or provide a __autoload() function to load the class definition in /home/robertl/htdocs/mahara-devel/mahara/htdocs/auth/lib.php on line 1945 Which deals with the line: return get_login_form_js($SESSION->loginform->build()); In earlier Mahara you would instead be given (via js) a popup login box. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1495200/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1495200] A change has been merged
Reviewed: https://reviews.mahara.org/5444 Committed: https://git.nzoss.org.nz/mahara/mahara/commit/af0f74a9dafa0b3726df925e65c1443f7aa2e29a Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:1.9_STABLE commit af0f74a9dafa0b3726df925e65c1443f7aa2e29a Author: Aaron Wells Date: Wed Sep 30 17:15:49 2015 +1300 Remove unnecessary cached form from the session Bug 1495200 & Bug 1496681 behatnotneeded: Well, we could test this, but it would require a 60-second wait for the session to timeout (since the least you can set the session timeout via the UI is 1 minute) Change-Id: Ia5c861c16b6c893ada9d5eb2111f0b6a9aee49ad (cherry picked from commit aee374c0aa5d89cadba50a2eff2891af4ee751c0) (cherry picked from commit 784dbf9d5a5a8fc31a7d5b49bbcb41fe68578b7b) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1495200 Title: White screen when session times out Status in Mahara: Fix Committed Status in Mahara 1.10 series: Fix Committed Status in Mahara 1.9 series: Fix Committed Status in Mahara 15.04 series: Fix Committed Status in Mahara 15.10 series: Fix Committed Status in Mahara 16.04 series: Fix Committed Bug description: Issue with 15.10 If you are logged into mahara and leave the site open in a browser for some time when you come back and try to navigate somewhere you can end up with a white blank screen - on refresh of page all works fine. The problem is this: PHP Fatal error: auth_generate_login_form(): The script tried to execute a method or access a property of an incomplete object. Please ensure that the class definition "Pieform" of the object you are trying to operate on was loaded _before_ unserialize() gets called or provide a __autoload() function to load the class definition in /home/robertl/htdocs/mahara-devel/mahara/htdocs/auth/lib.php on line 1945 Which deals with the line: return get_login_form_js($SESSION->loginform->build()); In earlier Mahara you would instead be given (via js) a popup login box. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1495200/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1496681] A change has been merged
Reviewed: https://reviews.mahara.org/5444 Committed: https://git.nzoss.org.nz/mahara/mahara/commit/af0f74a9dafa0b3726df925e65c1443f7aa2e29a Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:1.9_STABLE commit af0f74a9dafa0b3726df925e65c1443f7aa2e29a Author: Aaron Wells Date: Wed Sep 30 17:15:49 2015 +1300 Remove unnecessary cached form from the session Bug 1495200 & Bug 1496681 behatnotneeded: Well, we could test this, but it would require a 60-second wait for the session to timeout (since the least you can set the session timeout via the UI is 1 minute) Change-Id: Ia5c861c16b6c893ada9d5eb2111f0b6a9aee49ad (cherry picked from commit aee374c0aa5d89cadba50a2eff2891af4ee751c0) (cherry picked from commit 784dbf9d5a5a8fc31a7d5b49bbcb41fe68578b7b) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1496681 Title: Login box lang strings don't change when language is switched Status in Mahara: Fix Committed Status in Mahara 1.10 series: Fix Committed Status in Mahara 1.9 series: Fix Committed Status in Mahara 15.04 series: Fix Committed Status in Mahara 15.10 series: Fix Committed Status in Mahara 16.04 series: Fix Committed Bug description: Evonne found the following on her instance of 15.10dev: When she changes the language and clicks the "Change" button, the inside of the login box is not changed. She needs to refresh the page to get the other language's strings. The text in the middle and also the "Links and resources" strings change. The title of the login box changes, but not "Username", "Password", the register etc. links and the help. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1496681/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1496681] A change has been merged
Reviewed: https://reviews.mahara.org/5443 Committed: https://git.nzoss.org.nz/mahara/mahara/commit/ea1bdc16d53ac5c659a9df853fae8fa891102e51 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:1.10_STABLE commit ea1bdc16d53ac5c659a9df853fae8fa891102e51 Author: Aaron Wells Date: Wed Sep 30 17:15:49 2015 +1300 Remove unnecessary cached form from the session Bug 1495200 & Bug 1496681 behatnotneeded: Well, we could test this, but it would require a 60-second wait for the session to timeout (since the least you can set the session timeout via the UI is 1 minute) Change-Id: Ia5c861c16b6c893ada9d5eb2111f0b6a9aee49ad (cherry picked from commit aee374c0aa5d89cadba50a2eff2891af4ee751c0) (cherry picked from commit 784dbf9d5a5a8fc31a7d5b49bbcb41fe68578b7b) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1496681 Title: Login box lang strings don't change when language is switched Status in Mahara: Fix Committed Status in Mahara 1.10 series: Fix Committed Status in Mahara 1.9 series: Fix Committed Status in Mahara 15.04 series: Fix Committed Status in Mahara 15.10 series: Fix Committed Status in Mahara 16.04 series: Fix Committed Bug description: Evonne found the following on her instance of 15.10dev: When she changes the language and clicks the "Change" button, the inside of the login box is not changed. She needs to refresh the page to get the other language's strings. The text in the middle and also the "Links and resources" strings change. The title of the login box changes, but not "Username", "Password", the register etc. links and the help. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1496681/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1496681] A patch has been submitted for review
Patch for "1.9_STABLE" branch: https://reviews.mahara.org/5444 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1496681 Title: Login box lang strings don't change when language is switched Status in Mahara: Fix Committed Status in Mahara 1.10 series: Fix Committed Status in Mahara 1.9 series: Fix Committed Status in Mahara 15.04 series: Fix Committed Status in Mahara 15.10 series: Fix Committed Status in Mahara 16.04 series: Fix Committed Bug description: Evonne found the following on her instance of 15.10dev: When she changes the language and clicks the "Change" button, the inside of the login box is not changed. She needs to refresh the page to get the other language's strings. The text in the middle and also the "Links and resources" strings change. The title of the login box changes, but not "Username", "Password", the register etc. links and the help. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1496681/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1496681] Re: Login box lang strings don't change when language is switched
** Changed in: mahara/1.10 Status: In Progress => Fix Committed ** Changed in: mahara/1.9 Status: In Progress => Fix Committed ** Changed in: mahara/15.04 Status: In Progress => Fix Committed ** Changed in: mahara/15.10 Status: In Progress => Fix Committed ** Changed in: mahara/16.04 Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1496681 Title: Login box lang strings don't change when language is switched Status in Mahara: Fix Committed Status in Mahara 1.10 series: Fix Committed Status in Mahara 1.9 series: Fix Committed Status in Mahara 15.04 series: Fix Committed Status in Mahara 15.10 series: Fix Committed Status in Mahara 16.04 series: Fix Committed Bug description: Evonne found the following on her instance of 15.10dev: When she changes the language and clicks the "Change" button, the inside of the login box is not changed. She needs to refresh the page to get the other language's strings. The text in the middle and also the "Links and resources" strings change. The title of the login box changes, but not "Username", "Password", the register etc. links and the help. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1496681/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1495200] Re: White screen when session times out
** Changed in: mahara/16.04 Status: Confirmed => Fix Committed ** Changed in: mahara/15.10 Status: Confirmed => Fix Committed ** Changed in: mahara/15.04 Status: Confirmed => Fix Committed ** Also affects: mahara/1.10 Importance: Undecided Status: New ** Also affects: mahara/1.9 Importance: Undecided Status: New ** Changed in: mahara/1.9 Status: New => Fix Committed ** Changed in: mahara/1.10 Status: New => Fix Committed ** Changed in: mahara/1.10 Importance: Undecided => High ** Changed in: mahara/1.9 Importance: Undecided => High ** Changed in: mahara/1.10 Milestone: None => 1.10.7 ** Changed in: mahara/1.9 Milestone: None => 1.9.9 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1495200 Title: White screen when session times out Status in Mahara: Fix Committed Status in Mahara 1.10 series: Fix Committed Status in Mahara 1.9 series: Fix Committed Status in Mahara 15.04 series: Fix Committed Status in Mahara 15.10 series: Fix Committed Status in Mahara 16.04 series: Fix Committed Bug description: Issue with 15.10 If you are logged into mahara and leave the site open in a browser for some time when you come back and try to navigate somewhere you can end up with a white blank screen - on refresh of page all works fine. The problem is this: PHP Fatal error: auth_generate_login_form(): The script tried to execute a method or access a property of an incomplete object. Please ensure that the class definition "Pieform" of the object you are trying to operate on was loaded _before_ unserialize() gets called or provide a __autoload() function to load the class definition in /home/robertl/htdocs/mahara-devel/mahara/htdocs/auth/lib.php on line 1945 Which deals with the line: return get_login_form_js($SESSION->loginform->build()); In earlier Mahara you would instead be given (via js) a popup login box. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1495200/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1500774] A change has been merged
Reviewed: https://reviews.mahara.org/5403
Committed:
https://git.nzoss.org.nz/mahara/mahara/commit/4deca62129f7d6c0f2a8f57aa5e63b95e0848d29
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master
commit 4deca62129f7d6c0f2a8f57aa5e63b95e0848d29
Author: Manuel Gogl
Date: Wed Sep 30 08:37:29 2015 +1300
Bug 1500774: Use correct path for deleting old sessions
behatnotneeded: dealing with deletign files from dataroot
Change-Id: I0c6f2ef1b04b8ac4beef2daef2459b619db9a9ed
Signed-off-by: Robert Lyon
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1500774
Title:
remove old session files doesn't work with adapted sessionpath
Status in Mahara:
Fix Committed
Status in Mahara 1.10 series:
Fix Committed
Status in Mahara 1.9 series:
Fix Committed
Status in Mahara 15.04 series:
Fix Committed
Status in Mahara 15.10 series:
Fix Committed
Bug description:
auth/lib.php is using
$basedir = get_config('dataroot') . 'sessions/';
for trying to remove the old session files.
If there is a different session path set, mahara does not notice this
adaptation.
Following modification is fixing the problem:
auth/lib.php:
function auth_remove_old_session_files() {
$basedir = get_config('sessionpath');
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1500774/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1500774] A patch has been submitted for review
Patch for "1.10_STABLE" branch: https://reviews.mahara.org/5446
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1500774
Title:
remove old session files doesn't work with adapted sessionpath
Status in Mahara:
Fix Committed
Status in Mahara 1.10 series:
Fix Committed
Status in Mahara 1.9 series:
Fix Committed
Status in Mahara 15.04 series:
Fix Committed
Status in Mahara 15.10 series:
Fix Committed
Bug description:
auth/lib.php is using
$basedir = get_config('dataroot') . 'sessions/';
for trying to remove the old session files.
If there is a different session path set, mahara does not notice this
adaptation.
Following modification is fixing the problem:
auth/lib.php:
function auth_remove_old_session_files() {
$basedir = get_config('sessionpath');
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1500774/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1500774] A change has been merged
Reviewed: https://reviews.mahara.org/5446
Committed:
https://git.nzoss.org.nz/mahara/mahara/commit/c810999b9d10b03de05ca67bb2c3d8591c4d8d94
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:1.10_STABLE
commit c810999b9d10b03de05ca67bb2c3d8591c4d8d94
Author: Manuel Gogl
Date: Wed Sep 30 08:37:29 2015 +1300
Bug 1500774: Use correct path for deleting old sessions
behatnotneeded: dealing with deletign files from dataroot
Change-Id: I0c6f2ef1b04b8ac4beef2daef2459b619db9a9ed
Signed-off-by: Robert Lyon
(cherry picked from commit 4deca62129f7d6c0f2a8f57aa5e63b95e0848d29)
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1500774
Title:
remove old session files doesn't work with adapted sessionpath
Status in Mahara:
Fix Committed
Status in Mahara 1.10 series:
Fix Committed
Status in Mahara 1.9 series:
Fix Committed
Status in Mahara 15.04 series:
Fix Committed
Status in Mahara 15.10 series:
Fix Committed
Bug description:
auth/lib.php is using
$basedir = get_config('dataroot') . 'sessions/';
for trying to remove the old session files.
If there is a different session path set, mahara does not notice this
adaptation.
Following modification is fixing the problem:
auth/lib.php:
function auth_remove_old_session_files() {
$basedir = get_config('sessionpath');
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1500774/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1500774] A change has been merged
Reviewed: https://reviews.mahara.org/5447
Committed:
https://git.nzoss.org.nz/mahara/mahara/commit/7062f357add00f3b90bb00eafb7994e729d7230a
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:1.9_STABLE
commit 7062f357add00f3b90bb00eafb7994e729d7230a
Author: Manuel Gogl
Date: Wed Sep 30 08:37:29 2015 +1300
Bug 1500774: Use correct path for deleting old sessions
behatnotneeded: dealing with deletign files from dataroot
Change-Id: I0c6f2ef1b04b8ac4beef2daef2459b619db9a9ed
Signed-off-by: Robert Lyon
(cherry picked from commit 4deca62129f7d6c0f2a8f57aa5e63b95e0848d29)
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1500774
Title:
remove old session files doesn't work with adapted sessionpath
Status in Mahara:
Fix Committed
Status in Mahara 1.10 series:
Fix Committed
Status in Mahara 1.9 series:
Fix Committed
Status in Mahara 15.04 series:
Fix Committed
Status in Mahara 15.10 series:
Fix Committed
Bug description:
auth/lib.php is using
$basedir = get_config('dataroot') . 'sessions/';
for trying to remove the old session files.
If there is a different session path set, mahara does not notice this
adaptation.
Following modification is fixing the problem:
auth/lib.php:
function auth_remove_old_session_files() {
$basedir = get_config('sessionpath');
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1500774/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1500774] A patch has been submitted for review
Patch for "1.9_STABLE" branch: https://reviews.mahara.org/5447
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1500774
Title:
remove old session files doesn't work with adapted sessionpath
Status in Mahara:
Fix Committed
Status in Mahara 1.10 series:
Fix Committed
Status in Mahara 1.9 series:
Fix Committed
Status in Mahara 15.04 series:
Fix Committed
Status in Mahara 15.10 series:
Fix Committed
Bug description:
auth/lib.php is using
$basedir = get_config('dataroot') . 'sessions/';
for trying to remove the old session files.
If there is a different session path set, mahara does not notice this
adaptation.
Following modification is fixing the problem:
auth/lib.php:
function auth_remove_old_session_files() {
$basedir = get_config('sessionpath');
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1500774/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1500774] Re: remove old session files doesn't work with adapted sessionpath
** Changed in: mahara/15.10
Status: In Progress => Fix Committed
** Changed in: mahara/15.04
Importance: Undecided => High
** Changed in: mahara/1.9
Importance: Undecided => High
** Changed in: mahara/1.10
Importance: Undecided => High
** Changed in: mahara/15.04
Status: New => Fix Committed
** Changed in: mahara/1.9
Status: New => Fix Committed
** Changed in: mahara/1.10
Status: New => Fix Committed
** Changed in: mahara/15.04
Milestone: None => 15.04.4
** Changed in: mahara/1.9
Milestone: None => 1.9.9
** Changed in: mahara/1.10
Milestone: None => 1.10.7
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1500774
Title:
remove old session files doesn't work with adapted sessionpath
Status in Mahara:
Fix Committed
Status in Mahara 1.10 series:
Fix Committed
Status in Mahara 1.9 series:
Fix Committed
Status in Mahara 15.04 series:
Fix Committed
Status in Mahara 15.10 series:
Fix Committed
Bug description:
auth/lib.php is using
$basedir = get_config('dataroot') . 'sessions/';
for trying to remove the old session files.
If there is a different session path set, mahara does not notice this
adaptation.
Following modification is fixing the problem:
auth/lib.php:
function auth_remove_old_session_files() {
$basedir = get_config('sessionpath');
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1500774/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1486813] A change has been merged
Reviewed: https://reviews.mahara.org/5420 Committed: https://git.nzoss.org.nz/mahara/mahara/commit/48c1e54ea275d679a2228d86a8994562a55d91ff Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:15.04_STABLE commit 48c1e54ea275d679a2228d86a8994562a55d91ff Author: Robert Lyon Date: Fri Sep 4 10:28:36 2015 +1200 Bug 1486813: Stop redirect to 'register site' page after each upgrade By adding a cancel option to the register site form that clears the new_registration_policy config setting. behatnotneeded Change-Id: I65cf7239b9fe021d17be387eeb8bfda9547c5032 Signed-off-by: Robert Lyon -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1486813 Title: Prompt for new stat data after upgrade needs a 'no thanks' option Status in Mahara: Fix Committed Status in Mahara 1.10 series: Fix Committed Status in Mahara 1.9 series: Fix Committed Status in Mahara 15.04 series: Fix Committed Bug description: With the patch for Bug 1450334 an admin on upgrade is redirected to the Register site page. If they navigate away rather than deciding to register the check 'new_registration_policy' is still active. This means that if the user upgrades again (or upgrades a plugin ) they are again redirected to the register site page. We need to alter the register site form so that there is a 'no thanks' (cancel) option that updates the 'new_registration_policy' to false as well otherwise it will get a bit annoying for those not wanting to register their site. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1486813/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1500774] A change has been merged
Reviewed: https://reviews.mahara.org/5445
Committed:
https://git.nzoss.org.nz/mahara/mahara/commit/b33100b4c87d26165c31ca231750500d7f2fae01
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:15.04_STABLE
commit b33100b4c87d26165c31ca231750500d7f2fae01
Author: Manuel Gogl
Date: Wed Sep 30 08:37:29 2015 +1300
Bug 1500774: Use correct path for deleting old sessions
behatnotneeded: dealing with deletign files from dataroot
Change-Id: I0c6f2ef1b04b8ac4beef2daef2459b619db9a9ed
Signed-off-by: Robert Lyon
(cherry picked from commit 4deca62129f7d6c0f2a8f57aa5e63b95e0848d29)
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1500774
Title:
remove old session files doesn't work with adapted sessionpath
Status in Mahara:
Fix Committed
Status in Mahara 1.10 series:
Fix Committed
Status in Mahara 1.9 series:
Fix Committed
Status in Mahara 15.04 series:
Fix Committed
Status in Mahara 15.10 series:
Fix Committed
Bug description:
auth/lib.php is using
$basedir = get_config('dataroot') . 'sessions/';
for trying to remove the old session files.
If there is a different session path set, mahara does not notice this
adaptation.
Following modification is fixing the problem:
auth/lib.php:
function auth_remove_old_session_files() {
$basedir = get_config('sessionpath');
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1500774/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1500774] A patch has been submitted for review
Patch for "15.04_STABLE" branch: https://reviews.mahara.org/5445
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1500774
Title:
remove old session files doesn't work with adapted sessionpath
Status in Mahara:
Fix Committed
Status in Mahara 1.10 series:
Fix Committed
Status in Mahara 1.9 series:
Fix Committed
Status in Mahara 15.04 series:
Fix Committed
Status in Mahara 15.10 series:
Fix Committed
Bug description:
auth/lib.php is using
$basedir = get_config('dataroot') . 'sessions/';
for trying to remove the old session files.
If there is a different session path set, mahara does not notice this
adaptation.
Following modification is fixing the problem:
auth/lib.php:
function auth_remove_old_session_files() {
$basedir = get_config('sessionpath');
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1500774/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1486813] Re: Prompt for new stat data after upgrade needs a 'no thanks' option
** Changed in: mahara/15.04 Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1486813 Title: Prompt for new stat data after upgrade needs a 'no thanks' option Status in Mahara: Fix Committed Status in Mahara 1.10 series: Fix Committed Status in Mahara 1.9 series: Fix Committed Status in Mahara 15.04 series: Fix Committed Bug description: With the patch for Bug 1450334 an admin on upgrade is redirected to the Register site page. If they navigate away rather than deciding to register the check 'new_registration_policy' is still active. This means that if the user upgrades again (or upgrades a plugin ) they are again redirected to the register site page. We need to alter the register site form so that there is a 'no thanks' (cancel) option that updates the 'new_registration_policy' to false as well otherwise it will get a bit annoying for those not wanting to register their site. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1486813/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
