[Mahara-contributors] [Bug 1465107] A patch has been submitted for review

2015-10-21 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/5590

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1465107

Title:
  Use the Bootstrap CSS framework

Status in Mahara:
  In Progress

Bug description:
  Mahara's CSS, and general front-end coding, is a bit chaotic. So for
  the past several months we've had a couple of front-end developers
  working on rewriting the entire Mahara front end to use the Bootstrap
  CSS framework. http://getbootstrap.com/css/

  This should make all of our front-end development work easier
  henceforth, as well as providing a nice set of standard widgets to
  make Mahara look better right away.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1465107/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1482448] A patch has been submitted for review

2015-10-21 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/5589

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1482448

Title:
  Help links should include the form element they refer to in their alt
  text

Status in Mahara:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed

Bug description:
  Many form elements in Mahara have blue "help" icons beside them, which
  pop up a dialog when clicked. These do currently include the
  accessible text "Help", but it is sometimes ambiguous to screen reader
  users which form element they refer to. It would be good to include
  the label of the element in the help text, eg. "Help for Auto-add
  users"

  Affects latest master

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1482448/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1490569] Re: Sort submitted pages "Most recently submitted" doesn't work

2015-10-21 Thread Jono Mingard
This is now fixed in both 15.04 and 15.10, BUT the group pages block
does not update when you click "Save" - you need to refresh the page
before the new sort order takes effect.

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1490569

Title:
  Sort submitted pages "Most recently submitted" doesn't work

Status in Mahara:
  Confirmed

Bug description:
  Hello,

  When adding a 'pages shared' block to a group, one of the settings is "Sort 
submitted pages and collections" by "Most recently updated". While trying to 
use this with a group (v15.04)  I've found that the displayed sort order of the 
shared pages doesn't change from the default 'alphabetically'.
  Worth noting it would also be worth having the option to display pages in the 
order 'most recently shared' - subtly different from when they were updated but 
a useful feature if it could be added.

  Regards, Gordon.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1490569/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1506695] A patch has been submitted for review

2015-10-21 Thread Mahara Bot
Patch for "15.10_STABLE" branch: https://reviews.mahara.org/5588

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1506695

Title:
  Undefined theme index when upgrading to 15.10

Status in Mahara:
  In Progress

Bug description:
  When im on this URL and I upload a CSV file containing 1000 new users
  the following happens:

  It takes 6mins to upload but stops at 51% and page displays 504
  gateway timeout message. But users are still uploaded in the system.

  [DBG] 40 (admin/users/uploadcsv.php:553) added user user0784
  [WAR] ed (lib/user.php:306) Undefined index: primary
  Call stack (most recent first):

  log_message("Undefined index: primary", 8, true, true, 
"/var/www/master-bigdb-prod-mahara/releases/2015101...", 306) at 
/var/www/master-bigdb-prod-mahara/releases/20151015203951/lib/errors.php:441
  error(8, "Undefined index: primary", 
"/var/www/master-bigdb-prod-mahara/releases/2015101...", 306, array(size 12)) 
at /var/www/master-bigdb-prod-mahara/releases/20151015203951/lib/user.php:306
  general_account_prefs_form_elements(object(stdClass)) at 
/var/www/master-bigdb-prod-mahara/releases/20151015203951/admin/users/uploadcsv.php:127

  [WAR] ed (lib/user.php:306) Trying to get property of non-object
  Call stack (most recent first):

  log_message("Trying to get property of non-object", 8, true, true, 
"/var/www/master-bigdb-prod-mahara/releases/2015101...", 306) at 
/var/www/master-bigdb-prod-mahara/releases/20151015203951/lib/errors.php:441
  error(8, "Trying to get property of non-object", 
"/var/www/master-bigdb-prod-mahara/releases/2015101...", 306, array(size 12)) 
at /var/www/master-bigdb-prod-mahara/releases/20151015203951/lib/user.php:306
  general_account_prefs_form_elements(object(stdClass)) at 
/var/www/master-bigdb-prod-mahara/releases/20151015203951/admin/users/uploadcsv.php:127

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1506695/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1506695] A change has been merged

2015-10-21 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/5549
Committed: 
https://git.nzoss.org.nz/mahara/mahara/commit/06cc26d14d56440c8e0f0438d4393bd5b92c202f
Submitter: Aaron Wells (aar...@catalyst.net.nz)
Branch:master

commit 06cc26d14d56440c8e0f0438d4393bd5b92c202f
Author: Robert Lyon 
Date:   Sat Oct 17 22:14:21 2015 +1300

Bug 1506695: Undefined theme index error

Suppress this for user if institution hasn't got around to updating
their theme.

Occurs when $cfg->sitethemeprefs is true and user is in an institution
with an old theme like 'ultima' and they go to their settings page.

Change-Id: I6289da0777b1964cabc8f933478f90ae22569af8
Signed-off-by: Robert Lyon 

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1506695

Title:
  Undefined theme index when upgrading to 15.10

Status in Mahara:
  In Progress

Bug description:
  When im on this URL and I upload a CSV file containing 1000 new users
  the following happens:

  It takes 6mins to upload but stops at 51% and page displays 504
  gateway timeout message. But users are still uploaded in the system.

  [DBG] 40 (admin/users/uploadcsv.php:553) added user user0784
  [WAR] ed (lib/user.php:306) Undefined index: primary
  Call stack (most recent first):

  log_message("Undefined index: primary", 8, true, true, 
"/var/www/master-bigdb-prod-mahara/releases/2015101...", 306) at 
/var/www/master-bigdb-prod-mahara/releases/20151015203951/lib/errors.php:441
  error(8, "Undefined index: primary", 
"/var/www/master-bigdb-prod-mahara/releases/2015101...", 306, array(size 12)) 
at /var/www/master-bigdb-prod-mahara/releases/20151015203951/lib/user.php:306
  general_account_prefs_form_elements(object(stdClass)) at 
/var/www/master-bigdb-prod-mahara/releases/20151015203951/admin/users/uploadcsv.php:127

  [WAR] ed (lib/user.php:306) Trying to get property of non-object
  Call stack (most recent first):

  log_message("Trying to get property of non-object", 8, true, true, 
"/var/www/master-bigdb-prod-mahara/releases/2015101...", 306) at 
/var/www/master-bigdb-prod-mahara/releases/20151015203951/lib/errors.php:441
  error(8, "Trying to get property of non-object", 
"/var/www/master-bigdb-prod-mahara/releases/2015101...", 306, array(size 12)) 
at /var/www/master-bigdb-prod-mahara/releases/20151015203951/lib/user.php:306
  general_account_prefs_form_elements(object(stdClass)) at 
/var/www/master-bigdb-prod-mahara/releases/20151015203951/admin/users/uploadcsv.php:127

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1506695/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1487815] A change has been merged

2015-10-21 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/5166
Committed: 
https://git.nzoss.org.nz/mahara/mahara/commit/f62cafd8da4cf4c1512c966dd9f6fbb54cc898e5
Submitter: Aaron Wells (aar...@catalyst.net.nz)
Branch:master

commit f62cafd8da4cf4c1512c966dd9f6fbb54cc898e5
Author: Robert Lyon 
Date:   Tue Oct 20 13:53:45 2015 +1300

Bug 1487815: Dealing with missing theme select box error

On site config page after upgrade some themes will not exist anymore
so we need to reset the theme to the default theme whatever that is
and alert the user about this.

We also need to set institution theme to sitedefault if their set theme
has gone.

behatnotneeded

Change-Id: I9459a920f1d870b71a9a0d48cc0ed39761152143
Signed-off-by: Robert Lyon 

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1487815

Title:
  Error message when theme cannot be found

Status in Mahara:
  In Progress

Bug description:
  on master 15.10dev

  To test:

  1. Install Mahara 15.04
  2. Change the site theme to a theme that is not "Raw" or "Default".
  3. Upgrade the site to the latest master.

  When logging back into the site, I get the following warning when I'm
  on "Configure site" -> "Site options":

  [WAR] dd (lib/pieforms/pieform.php:1314) Invalid value for select "theme"
  Call stack (most recent first):

  log_message("Invalid value for select "theme"", 8, true, true, 
"/home/kristina/code/mahara/htdocs/lib/pieforms/pie...", 1314) at 
/home/kristina/code/mahara/htdocs/lib/errors.php:441
  error(1024, "Invalid value for select "theme"", 
"/home/kristina/code/mahara/htdocs/lib/pieforms/pie...", 1314, array(size 2)) 
at Unknown:0
  trigger_error("Invalid value for select "theme"", 1024) at 
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:1314
  Pieform::info("Invalid value for select "theme"") at 
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform/elements/select.php:143
  pieform_element_select(object(Pieform), array(size 13)) at 
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:1480
  Pieform->build_element_html(array(size 13)) at 
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:709
  Pieform->build() at 
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:169
  Pieform::process(array(size 7)) at 
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:71
  pieform(array(size 7)) at 
/home/kristina/code/mahara/htdocs/admin/site/options.php:774

  
  The old theme cannot be found (correct), but also the value can't be found.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1487815/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1487815] A patch has been submitted for review

2015-10-21 Thread Mahara Bot
Patch for "15.10_STABLE" branch: https://reviews.mahara.org/5587

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1487815

Title:
  Error message when theme cannot be found

Status in Mahara:
  In Progress

Bug description:
  on master 15.10dev

  To test:

  1. Install Mahara 15.04
  2. Change the site theme to a theme that is not "Raw" or "Default".
  3. Upgrade the site to the latest master.

  When logging back into the site, I get the following warning when I'm
  on "Configure site" -> "Site options":

  [WAR] dd (lib/pieforms/pieform.php:1314) Invalid value for select "theme"
  Call stack (most recent first):

  log_message("Invalid value for select "theme"", 8, true, true, 
"/home/kristina/code/mahara/htdocs/lib/pieforms/pie...", 1314) at 
/home/kristina/code/mahara/htdocs/lib/errors.php:441
  error(1024, "Invalid value for select "theme"", 
"/home/kristina/code/mahara/htdocs/lib/pieforms/pie...", 1314, array(size 2)) 
at Unknown:0
  trigger_error("Invalid value for select "theme"", 1024) at 
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:1314
  Pieform::info("Invalid value for select "theme"") at 
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform/elements/select.php:143
  pieform_element_select(object(Pieform), array(size 13)) at 
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:1480
  Pieform->build_element_html(array(size 13)) at 
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:709
  Pieform->build() at 
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:169
  Pieform::process(array(size 7)) at 
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:71
  pieform(array(size 7)) at 
/home/kristina/code/mahara/htdocs/admin/site/options.php:774

  
  The old theme cannot be found (correct), but also the value can't be found.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1487815/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1508760] [NEW] Rows added to artefact_file_embedded when editing Note not in a page

2015-10-21 Thread Jono Mingard
Public bug reported:

When a Note is removed from all pages it is in, any embedded images in
the note have their entries removed from the artefact_file_embedded
table (since the note can't be shared they aren't needed). However, if
you then edit the note from the Notes area and click Save, the embedded
image rows are added back to the table.

More specifically
- Add a Note block to a page, and embed an image in the note (using the TinyMCE 
image button)
- Confirm that a new "textbox" row has been added to the artefact_file_embedded 
table
- Remove the block from the page. This should remove the artefact_file_embedded 
row that you saw previously
- Go to "Notes" and edit that note. Click "Save" without changing anything
- Another new "textbox" row will appear in the artefact_file_embedded table

This row isn't necessary, so it shouldn't be added unless the note is in
one or more pages.

Affects latest master

** Affects: mahara
 Importance: Low
 Status: New

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1508760

Title:
  Rows added to artefact_file_embedded when editing Note not in a page

Status in Mahara:
  New

Bug description:
  When a Note is removed from all pages it is in, any embedded images in
  the note have their entries removed from the artefact_file_embedded
  table (since the note can't be shared they aren't needed). However, if
  you then edit the note from the Notes area and click Save, the
  embedded image rows are added back to the table.

  More specifically
  - Add a Note block to a page, and embed an image in the note (using the 
TinyMCE image button)
  - Confirm that a new "textbox" row has been added to the 
artefact_file_embedded table
  - Remove the block from the page. This should remove the 
artefact_file_embedded row that you saw previously
  - Go to "Notes" and edit that note. Click "Save" without changing anything
  - Another new "textbox" row will appear in the artefact_file_embedded table

  This row isn't necessary, so it shouldn't be added unless the note is
  in one or more pages.

  Affects latest master

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1508760/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1508743] [NEW] $CFG->filepermissions calculation in init.php provides unexpected result

2015-10-21 Thread Richard Hills
Public bug reported:

Mahara 15.04.3
Linux (CentOS)

I have the $CFG->directorypermissions set to 0740 and expected
filepermissions to come out to 0640 however they were coming out as
0416.

Once I changed the settings for both of the permission values to be
strings "0740" and "0660" the expected result 0640 was returned.

** Affects: mahara
 Importance: Undecided
 Status: New

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1508743

Title:
  $CFG->filepermissions calculation in init.php provides unexpected
  result

Status in Mahara:
  New

Bug description:
  Mahara 15.04.3
  Linux (CentOS)

  I have the $CFG->directorypermissions set to 0740 and expected
  filepermissions to come out to 0640 however they were coming out as
  0416.

  Once I changed the settings for both of the permission values to be
  strings "0740" and "0660" the expected result 0640 was returned.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1508743/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1489284] A change has been merged

2015-10-21 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/5211
Committed: 
https://git.nzoss.org.nz/mahara/mahara/commit/dc680af3e7cfe687671843465150ea6276c47387
Submitter: Jono Mingard (reason.k...@gmail.com)
Branch:15.04_STABLE

commit dc680af3e7cfe687671843465150ea6276c47387
Author: Robert Lyon 
Date:   Fri Sep 4 11:51:04 2015 +1200

Bug 1489284: Check for blogpost embedded images as attachments

Before trying to loop through them

behatnotneeded

Change-Id: Iaabf96b02ab29d4b9f2edd44b14f45224206919b
Signed-off-by: Robert Lyon 

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1489284

Title:
  Warning message when deleting a blog

Status in Mahara:
  In Progress
Status in Mahara 15.04 series:
  In Progress
Status in Mahara 15.10 series:
  In Progress

Bug description:
  I noticed this warning message when deleting a journal. I'm not sure
  whether the journal has to have embedded images in an entry or not,
  but here's what I did.

  1. Create a journal
  2. Create a journal entry
  3. Use the TinyMCE image button to embed an image in the journal entry
  4. Select the journal entry in a journal entry block on a page
  5. Delete the page
  6. Delete the journal

  Result:

  [WAR] 75 (lib/embeddedimage.php:176) Invalid argument supplied for foreach()
  Call stack (most recent first):

  log_message("Invalid argument supplied for foreach()", 8, true, true, 
"/home/aaronw/www/mahara/htdocs/lib/embeddedimage.p...", 176) at 
/home/aaronw/www/mahara/htdocs/lib/errors.php:441
  error(2, "Invalid argument supplied for foreach()", 
"/home/aaronw/www/mahara/htdocs/lib/embeddedimage.p...", 176, array(size 3)) at 
/home/aaronw/www/mahara/htdocs/lib/embeddedimage.php:176
  EmbeddedImage::delete_embedded_images("blog", "58") at 
/home/aaronw/www/mahara/htdocs/artefact/blog/index.php:56
  delete_blog_submit(object(Pieform), array(size 3)) at Unknown:0
  call_user_func_array("delete_blog_submit", array(size 2)) at 
/home/aaronw/www/mahara/htdocs/lib/pieforms/pieform.php:532
  Pieform->__construct(array(size 4)) at 
/home/aaronw/www/mahara/htdocs/lib/pieforms/pieform.php:162
  Pieform::process(array(size 4)) at 
/home/aaronw/www/mahara/htdocs/lib/pieforms/pieform.php:71
  pieform(array(size 4)) at 
/home/aaronw/www/mahara/htdocs/artefact/blog/lib.php:461
  ArtefactTypeBlog::delete_form(58) at 
/home/aaronw/www/mahara/htdocs/artefact/blog/index.php:28

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1489284/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1508728] A patch has been submitted for review

2015-10-21 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/5586

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1508728

Title:
  Hard-coded language string in editfile.tpl

Status in Mahara:
  Confirmed
Status in Mahara 15.10 series:
  Confirmed
Status in Mahara 16.04 series:
  Confirmed

Bug description:
  Just noticed a hard-coded "On" and "Off" in the "Allow comments"
  switchbox in
  theme/raw/plugintype/artefact/file/templates/form/editfile.tpl. This
  template file is accessed when you go to "Content -> Files" and then
  click the "edit" button next to an uploaded file.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1508728/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1487052] A change has been merged

2015-10-21 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/5212
Committed: 
https://git.nzoss.org.nz/mahara/mahara/commit/671ee2e0418a5e2274189b67d9e524577229ea39
Submitter: Son Nguyen (son.ngu...@catalyst.net.nz)
Branch:master

commit 671ee2e0418a5e2274189b67d9e524577229ea39
Author: Robert Lyon 
Date:   Fri Sep 4 12:12:06 2015 +1200

Bug 1487052: Fixing up places where link to mahara wiki are not correct

behatnotneeded

Change-Id: I7c2e8953dc3da61bb9c3f7e438efe6205f665796
Signed-off-by: Robert Lyon 

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1487052

Title:
  Link to cron installation guide returns a 404

Status in Mahara:
  In Progress

Bug description:
  Mahara 15.04.1

  The link to the guide on setting up Cron fro Mahara on the admin and
  statistics pages point to
  https://wiki.mahara.org/System_Administrator's_Guide/Installing_Mahara
  which returns a 404.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1487052/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1508723] Re: Have dedicated language strings for switchbox labels

2015-10-21 Thread Aaron Wells
For example, the 'yes' and 'no' strings are also used in
admin/groups/delete.php, where they label a pair of buttons.

It's less clear whether 'on', 'off', 'true', and 'false', are used
anywhere else in Mahara.

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1508723

Title:
  Have dedicated language strings for switchbox labels

Status in Mahara:
  In Progress
Status in Mahara 15.10 series:
  In Progress
Status in Mahara 16.04 series:
  In Progress

Bug description:
  Due to Bug 1467252, it may be necessary in some languages to relabel
  the switchboxes so that they don't say a direct translation of
  "Yes/No" or "Off/On".

  The problem is, the switchboxes currently use the strings 'yes', 'no',
  'off', and 'on' from mahara.php, which are potentially used throughout
  Mahara and can't be safely changed.

  The solution is to use dedicated language strings just for the
  switchboxes, so that they can be relabelled for brevity without
  affecting the rest of Mahara.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1508723/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1508728] [NEW] Hard-coded language string in editfile.tpl

2015-10-21 Thread Aaron Wells
Public bug reported:

Just noticed a hard-coded "On" and "Off" in the "Allow comments"
switchbox in
theme/raw/plugintype/artefact/file/templates/form/editfile.tpl. This
template file is accessed when you go to "Content -> Files" and then
click the "edit" button next to an uploaded file.

** Affects: mahara
 Importance: Medium
 Assignee: Aaron Wells (u-aaronw)
 Status: Confirmed

** Affects: mahara/15.10
 Importance: Medium
 Assignee: Aaron Wells (u-aaronw)
 Status: Confirmed

** Affects: mahara/16.04
 Importance: Medium
 Assignee: Aaron Wells (u-aaronw)
 Status: Confirmed

** Also affects: mahara/16.04
   Importance: Undecided
   Status: New

** Also affects: mahara/15.10
   Importance: Undecided
   Status: New

** Changed in: mahara/15.10
   Status: New => Confirmed

** Changed in: mahara/16.04
   Status: New => Confirmed

** Changed in: mahara/15.10
   Importance: Undecided => Medium

** Changed in: mahara/16.04
   Importance: Undecided => Medium

** Changed in: mahara/15.10
 Assignee: (unassigned) => Aaron Wells (u-aaronw)

** Changed in: mahara/16.04
 Assignee: (unassigned) => Aaron Wells (u-aaronw)

** Changed in: mahara/15.10
Milestone: None => 15.10.0

** Changed in: mahara/16.04
Milestone: None => 16.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1508728

Title:
  Hard-coded language string in editfile.tpl

Status in Mahara:
  Confirmed
Status in Mahara 15.10 series:
  Confirmed
Status in Mahara 16.04 series:
  Confirmed

Bug description:
  Just noticed a hard-coded "On" and "Off" in the "Allow comments"
  switchbox in
  theme/raw/plugintype/artefact/file/templates/form/editfile.tpl. This
  template file is accessed when you go to "Content -> Files" and then
  click the "edit" button next to an uploaded file.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1508728/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1508725] A patch has been submitted for review

2015-10-21 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/5585

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1508725

Title:
  Warning icon on upgrade to 15.10 doesn't show

Status in Mahara:
  In Progress

Bug description:
  To Test

  1) Install 15.04 stable site

  2) Checkout 15.10 stable branch

  3) Do upgrade

  The artefact.comment plugin upgrade should show an exclamation icon -
  instead it shows a broken  tag

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1508725/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1508725] [NEW] Warning icon on upgrade to 15.10 doesn't show

2015-10-21 Thread Robert Lyon
Public bug reported:

To Test

1) Install 15.04 stable site

2) Checkout 15.10 stable branch

3) Do upgrade

The artefact.comment plugin upgrade should show an exclamation icon -
instead it shows a broken  tag

** Affects: mahara
 Importance: Low
 Assignee: Robert Lyon (robertl-9)
 Status: In Progress


** Tags: regression

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1508725

Title:
  Warning icon on upgrade to 15.10 doesn't show

Status in Mahara:
  In Progress

Bug description:
  To Test

  1) Install 15.04 stable site

  2) Checkout 15.10 stable branch

  3) Do upgrade

  The artefact.comment plugin upgrade should show an exclamation icon -
  instead it shows a broken  tag

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1508725/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1508723] A patch has been submitted for review

2015-10-21 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/5584

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1508723

Title:
  Have dedicated language strings for switchbox labels

Status in Mahara:
  In Progress
Status in Mahara 15.10 series:
  In Progress
Status in Mahara 16.04 series:
  In Progress

Bug description:
  Due to Bug 1467252, it may be necessary in some languages to relabel
  the switchboxes so that they don't say a direct translation of
  "Yes/No" or "Off/On".

  The problem is, the switchboxes currently use the strings 'yes', 'no',
  'off', and 'on' from mahara.php, which are potentially used throughout
  Mahara and can't be safely changed.

  The solution is to use dedicated language strings just for the
  switchboxes, so that they can be relabelled for brevity without
  affecting the rest of Mahara.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1508723/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1467252] Re: Display problem with Switchbox when label strings aren't the same length as "On" & "Off"

2015-10-21 Thread Aaron Wells
I've filed a separate bug 1508723 to separate the switchbox language
strings into separate language strings, in order to make it easier for
them to be customized.

So with that, a workaround for other languages becomes easier, and the
priority of this bug can drop to medium.

** Also affects: mahara/15.10
   Importance: High
   Status: In Progress

** Also affects: mahara/16.04
   Importance: Undecided
   Status: New

** Changed in: mahara/16.04
   Importance: Undecided => High

** Changed in: mahara/16.04
   Status: New => In Progress

** Changed in: mahara/16.04
Milestone: None => 16.04.0

** Changed in: mahara/16.04
   Importance: High => Medium

** Changed in: mahara/15.10
   Importance: High => Medium

** Also affects: mahara/15.04
   Importance: Undecided
   Status: New

** Changed in: mahara/15.04
   Status: New => Confirmed

** Changed in: mahara/15.04
   Importance: Undecided => Medium

** Changed in: mahara/15.04
Milestone: None => 15.04.5

** Changed in: mahara/15.04
   Importance: Medium => High

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1467252

Title:
  Display problem with Switchbox when label strings aren't the same
  length as "On" & "Off"

Status in Mahara:
  In Progress
Status in Mahara 15.04 series:
  Confirmed
Status in Mahara 15.10 series:
  In Progress
Status in Mahara 16.04 series:
  In Progress

Bug description:
  It was ok in 15.04 but the the new interface of 15.10dev, the
  translated text for the "switch" options are not displayed correctly.

  1/ When "On", the translated text for "on" is displayed, with the text for 
"off" partially 
  2/ When "Off", the translated text for "off" is displayed centered below the 
the red bullet

  (see inclosed picture)

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1467252/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1508723] [NEW] Have dedicated language strings for switchbox labels

2015-10-21 Thread Aaron Wells
Public bug reported:

Due to Bug 1467252, it may be necessary in some languages to relabel the
switchboxes so that they don't say a direct translation of "Yes/No" or
"Off/On".

The problem is, the switchboxes currently use the strings 'yes', 'no',
'off', and 'on' from mahara.php, which are potentially used throughout
Mahara and can't be safely changed.

The solution is to use dedicated language strings just for the
switchboxes, so that they can be relabelled for brevity without
affecting the rest of Mahara.

** Affects: mahara
 Importance: High
 Assignee: Aaron Wells (u-aaronw)
 Status: In Progress

** Affects: mahara/15.10
 Importance: High
 Assignee: Aaron Wells (u-aaronw)
 Status: In Progress

** Affects: mahara/16.04
 Importance: High
 Assignee: Aaron Wells (u-aaronw)
 Status: In Progress


** Tags: pieforms switchbox translations

** Also affects: mahara/15.10
   Importance: Undecided
   Status: New

** Also affects: mahara/16.04
   Importance: Undecided
   Status: New

** Changed in: mahara/16.04
   Status: New => In Progress

** Changed in: mahara/15.10
   Status: New => In Progress

** Changed in: mahara/16.04
   Importance: Undecided => High

** Changed in: mahara/15.10
   Importance: Undecided => High

** Changed in: mahara/15.10
 Assignee: (unassigned) => Aaron Wells (u-aaronw)

** Changed in: mahara/16.04
 Assignee: (unassigned) => Aaron Wells (u-aaronw)

** Changed in: mahara/15.10
Milestone: None => 15.10.0

** Changed in: mahara/16.04
Milestone: None => 16.04.0

** Tags added: pieforms switchbox translations

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1508723

Title:
  Have dedicated language strings for switchbox labels

Status in Mahara:
  In Progress
Status in Mahara 15.10 series:
  In Progress
Status in Mahara 16.04 series:
  In Progress

Bug description:
  Due to Bug 1467252, it may be necessary in some languages to relabel
  the switchboxes so that they don't say a direct translation of
  "Yes/No" or "Off/On".

  The problem is, the switchboxes currently use the strings 'yes', 'no',
  'off', and 'on' from mahara.php, which are potentially used throughout
  Mahara and can't be safely changed.

  The solution is to use dedicated language strings just for the
  switchboxes, so that they can be relabelled for brevity without
  affecting the rest of Mahara.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1508723/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1508721] Re: Session setting should be more secure

2015-10-21 Thread Son Nguyen
https://reviews.mahara.org/#/c/5574/

** Information type changed from Public to Public Security

** Information type changed from Public Security to Private Security

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1508721

Title:
  Session setting should be more secure

Status in Mahara:
  In Progress

Bug description:
  Version: from 1.9
  Platform: any
  Browser: any

  According to http://php.net/manual/en/session.security.php, we should
  enable some session setting for better web security.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1508721/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1508721] [NEW] Session setting should be more secure

2015-10-21 Thread Son Nguyen
*** This bug is a security vulnerability ***

Private security bug reported:

Version: from 1.9
Platform: any
Browser: any

According to http://php.net/manual/en/session.security.php, we should
enable some session setting for better web security.

** Affects: mahara
 Importance: High
 Assignee: Son Nguyen (ngson2000)
 Status: In Progress

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1508721

Title:
  Session setting should be more secure

Status in Mahara:
  In Progress

Bug description:
  Version: from 1.9
  Platform: any
  Browser: any

  According to http://php.net/manual/en/session.security.php, we should
  enable some session setting for better web security.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1508721/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1507777] A change has been merged

2015-10-21 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/5560
Committed: 
https://git.nzoss.org.nz/mahara/mahara/commit/886cee51fb7d3ce9d89ebb10e8508930584c15f9
Submitter: Son Nguyen (son.ngu...@catalyst.net.nz)
Branch:master

commit 886cee51fb7d3ce9d89ebb10e8508930584c15f9
Author: Robert Lyon 
Date:   Tue Oct 20 17:40:24 2015 +1300

Bug 150: Allow user search to check secondary emails

behatnotneeded

Change-Id: I9b6a8206d420bc75fb913604cf7d4fa241450428
Signed-off-by: Robert Lyon 

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/150

Title:
  Secondary email addresses aren't searched on in "User search" in admin
  area

Status in Mahara:
  Confirmed
Status in Mahara 15.10 series:
  Confirmed
Status in Mahara 16.04 series:
  In Progress

Bug description:
  In 15.10 we implemented that secondary email addresses are displayed
  on the "User search" page in the admin area /admin/users/search.php

  However, these secondary email addresses are not searchable in that
  interface.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/150/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1465107] A patch has been submitted for review

2015-10-21 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/5583

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1465107

Title:
  Use the Bootstrap CSS framework

Status in Mahara:
  In Progress

Bug description:
  Mahara's CSS, and general front-end coding, is a bit chaotic. So for
  the past several months we've had a couple of front-end developers
  working on rewriting the entire Mahara front end to use the Bootstrap
  CSS framework. http://getbootstrap.com/css/

  This should make all of our front-end development work easier
  henceforth, as well as providing a nice set of standard widgets to
  make Mahara look better right away.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1465107/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1416147] A change has been merged

2015-10-21 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/5577
Committed: 
https://git.nzoss.org.nz/mahara/mahara/commit/fb33d6de34785cf3d0b64445e2298ee37d83d31b
Submitter: Aaron Wells (aar...@catalyst.net.nz)
Branch:1.10_STABLE

commit fb33d6de34785cf3d0b64445e2298ee37d83d31b
Author: Yuliya Bozhko 
Date:   Fri Jan 30 11:34:58 2015 +1300

SQL error in ORDER BY clause in get_artefactchooser_artefacts (Bug
#1416147)

Change-Id: I3b94130c605592ef22e1d5d30f038d3aafe1e03a
Signed-off-by: Yuliya Bozhko 
(cherry picked from commit 9ed9a6326f85c1b0ee0465e5dc52945f2bccd570)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1416147

Title:
  MySQL error in ORDER BY clause in get_artefactchooser_artefacts()

Status in Mahara:
  Fix Released
Status in Mahara 1.10 series:
  In Progress
Status in Mahara 1.9 series:
  In Progress

Bug description:
  For some reason works fine on Postgres...

  To reproduce:

  1. Create a journal post.
  2.  Go to pages.
  3. Create a page.
  4. Add "Journal entry" block.
  5. See this error:

  Failed to get a recordset: mysqli error: [1064: You have an error in
  your SQL syntax; check the manual that corresponds to your MySQL
  server version for the right syntax to use near 'BY parent ASC, ctime
  DESC LIMIT 10' at line 15] in EXECUTE("SELECT a.*, (a.owner IS NOT
  NULL AND a.owner = '1') AS editable FROM "mhr_artefact" a WHERE (
  a.owner = '1' OR a.id IN ( SELECT id FROM "mhr_artefact" WHERE (path =
  '/5' OR path LIKE '/5/%') AND institution = 'mahara' ) OR a.id IN (
  SELECT aar.artefact FROM "mhr_group_member" m JOIN "mhr_artefact" aa
  ON m.group = aa.group JOIN "mhr_artefact_access_role" aar ON aar.role
  = m.role AND aar.artefact = aa.id WHERE m.member = '1' AND
  aar.can_republish = 1 ) OR a.id IN (SELECT artefact FROM
  "mhr_artefact_access_usr" WHERE usr = '1' AND can_republish = 1) OR
  a.institution IN ('mahara') ) AND artefacttype IN('blogpost') AND id =
  6ORDER BY parent ASC, ctime DESC LIMIT 10") Command was: SELECT a.*,
  (a.owner IS NOT NULL AND a.owner = ?) AS editable FROM "mhr_artefact"
  a WHERE ( a.owner = ? OR a.id IN ( SELECT id FROM "mhr_artefact" WHERE
  (path = ? OR path LIKE ?) AND institution = 'mahara' ) OR a.id IN (
  SELECT aar.artefact FROM "mhr_group_member" m JOIN "mhr_artefact" aa
  ON m.group = aa.group JOIN "mhr_artefact_access_role" aar ON aar.role
  = m.role AND aar.artefact = aa.id WHERE m.member = ? AND
  aar.can_republish = 1 ) OR a.id IN (SELECT artefact FROM
  "mhr_artefact_access_usr" WHERE usr = ? AND can_republish = 1) OR
  a.institution IN (?) ) AND artefacttype IN(?) AND id = 6ORDER BY
  parent ASC, ctime DESC and values was
  (1,1,/5,/5/%,1,1,mahara,blogpost)

  SQL is missing space before ORDER BY...

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1416147/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1416147] A change has been merged

2015-10-21 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/5578
Committed: 
https://git.nzoss.org.nz/mahara/mahara/commit/142592ddf2ec1a579c4aad1e6a6d2dfa0379
Submitter: Aaron Wells (aar...@catalyst.net.nz)
Branch:1.9_STABLE

commit 142592ddf2ec1a579c4aad1e6a6d2dfa0379
Author: Yuliya Bozhko 
Date:   Fri Jan 30 11:34:58 2015 +1300

SQL error in ORDER BY clause in get_artefactchooser_artefacts (Bug
#1416147)

Change-Id: I3b94130c605592ef22e1d5d30f038d3aafe1e03a
Signed-off-by: Yuliya Bozhko 
(cherry picked from commit 9ed9a6326f85c1b0ee0465e5dc52945f2bccd570)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1416147

Title:
  MySQL error in ORDER BY clause in get_artefactchooser_artefacts()

Status in Mahara:
  Fix Released
Status in Mahara 1.10 series:
  In Progress
Status in Mahara 1.9 series:
  In Progress

Bug description:
  For some reason works fine on Postgres...

  To reproduce:

  1. Create a journal post.
  2.  Go to pages.
  3. Create a page.
  4. Add "Journal entry" block.
  5. See this error:

  Failed to get a recordset: mysqli error: [1064: You have an error in
  your SQL syntax; check the manual that corresponds to your MySQL
  server version for the right syntax to use near 'BY parent ASC, ctime
  DESC LIMIT 10' at line 15] in EXECUTE("SELECT a.*, (a.owner IS NOT
  NULL AND a.owner = '1') AS editable FROM "mhr_artefact" a WHERE (
  a.owner = '1' OR a.id IN ( SELECT id FROM "mhr_artefact" WHERE (path =
  '/5' OR path LIKE '/5/%') AND institution = 'mahara' ) OR a.id IN (
  SELECT aar.artefact FROM "mhr_group_member" m JOIN "mhr_artefact" aa
  ON m.group = aa.group JOIN "mhr_artefact_access_role" aar ON aar.role
  = m.role AND aar.artefact = aa.id WHERE m.member = '1' AND
  aar.can_republish = 1 ) OR a.id IN (SELECT artefact FROM
  "mhr_artefact_access_usr" WHERE usr = '1' AND can_republish = 1) OR
  a.institution IN ('mahara') ) AND artefacttype IN('blogpost') AND id =
  6ORDER BY parent ASC, ctime DESC LIMIT 10") Command was: SELECT a.*,
  (a.owner IS NOT NULL AND a.owner = ?) AS editable FROM "mhr_artefact"
  a WHERE ( a.owner = ? OR a.id IN ( SELECT id FROM "mhr_artefact" WHERE
  (path = ? OR path LIKE ?) AND institution = 'mahara' ) OR a.id IN (
  SELECT aar.artefact FROM "mhr_group_member" m JOIN "mhr_artefact" aa
  ON m.group = aa.group JOIN "mhr_artefact_access_role" aar ON aar.role
  = m.role AND aar.artefact = aa.id WHERE m.member = ? AND
  aar.can_republish = 1 ) OR a.id IN (SELECT artefact FROM
  "mhr_artefact_access_usr" WHERE usr = ? AND can_republish = 1) OR
  a.institution IN (?) ) AND artefacttype IN(?) AND id = 6ORDER BY
  parent ASC, ctime DESC and values was
  (1,1,/5,/5/%,1,1,mahara,blogpost)

  SQL is missing space before ORDER BY...

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1416147/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1508204] A change has been merged

2015-10-21 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/5566
Committed: 
https://git.nzoss.org.nz/mahara/mahara/commit/6cfee3c6c1dcd6e65545a955d5627d1475fdf149
Submitter: Son Nguyen (son.ngu...@catalyst.net.nz)
Branch:master

commit 6cfee3c6c1dcd6e65545a955d5627d1475fdf149
Author: Robert Lyon 
Date:   Wed Oct 21 15:30:57 2015 +1300

Bug 1508204: Can remove tagged blog options in modal

Stops the modal from being closed when clicking on the 'x' on the tag
options.

behatnotneeded: will add behat test is subpatch as there needs to be a
new step added

Change-Id: I8c1589fb708e654ca3200e1893ed25def19a5a3d
Signed-off-by: Robert Lyon 

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1508204

Title:
  Unable to remove a tagged journal option in 15.10

Status in Mahara:
  In Progress

Bug description:
  When I go to remove a tag option in 15.10 the modal closes rather than
  removing the item.

  To Test:

  1) Add a few journal entries to your site and tag them with a few
  different things

  2) Add a tagged journal entry block to a page and select more than one
  tag.

  3) Save the block config

  4) Edit the block config and try removing one of the tags

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1508204/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1465107] A change has been merged

2015-10-21 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/5553
Committed: 
https://git.nzoss.org.nz/mahara/mahara/commit/fb217aaea487d310bbc3987418ef9ab21c573b52
Submitter: Son Nguyen (son.ngu...@catalyst.net.nz)
Branch:master

commit fb217aaea487d310bbc3987418ef9ab21c573b52
Author: Robert Lyon 
Date:   Mon Oct 19 17:22:37 2015 +1300

Bug 1465107: Change default max image resize to fit with bootstrap
dimensions

behatnotneeded

Change-Id: Iaccd9ea363c80ea00040d75e9d171a6d87259f23
Signed-off-by: Robert Lyon 

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1465107

Title:
  Use the Bootstrap CSS framework

Status in Mahara:
  In Progress

Bug description:
  Mahara's CSS, and general front-end coding, is a bit chaotic. So for
  the past several months we've had a couple of front-end developers
  working on rewriting the entire Mahara front end to use the Bootstrap
  CSS framework. http://getbootstrap.com/css/

  This should make all of our front-end development work easier
  henceforth, as well as providing a nice set of standard widgets to
  make Mahara look better right away.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1465107/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1502371] A change has been merged

2015-10-21 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/5581
Committed: 
https://git.nzoss.org.nz/mahara/mahara/commit/966ef9df7cc398fdfe693b998ce8f3c5850f0620
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:15.04_STABLE

commit 966ef9df7cc398fdfe693b998ce8f3c5850f0620
Author: Robert Lyon 
Date:   Tue Oct 6 17:41:00 2015 +1300

Bug 1502371: Allowing the tinymce to record alt text for an embedded
image

based on either the description or the title of the image

behatnotneeded

Change-Id: I6deb362339ceeac29c6bb6425e853b120702ddae
Signed-off-by: Robert Lyon 
(cherry picked from commit 5edaff776e42a9389ca49ff48b77b01623b49507)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1502371

Title:
  No proper alt text for images and replacing of alt text in images in
  TinyMCE

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Committed

Bug description:
  Tested in 15.04 and 15.10

  When an image is put into a text or note block via TinyMCE, the alt
  text is automatically set to the image's path. Even when you overwrite
  it in the HTML code, it is replaced with the image path upon saving.

  https://yoururl/artefact/file/download.php?file=520&embedded=1&text=569296";
  alt="download.php?file=520&embedded=1&text=56">

  It would be better if the alt text could be the image description or
  if it could be entered manually via the interface.

  The alt text changing upon saving the HTML is a problem for
  accessibility.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1502371/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1502371] A patch has been submitted for review

2015-10-21 Thread Mahara Bot
Patch for "15.04_STABLE" branch: https://reviews.mahara.org/5581

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1502371

Title:
  No proper alt text for images and replacing of alt text in images in
  TinyMCE

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Committed

Bug description:
  Tested in 15.04 and 15.10

  When an image is put into a text or note block via TinyMCE, the alt
  text is automatically set to the image's path. Even when you overwrite
  it in the HTML code, it is replaced with the image path upon saving.

  https://yoururl/artefact/file/download.php?file=520&embedded=1&text=569296";
  alt="download.php?file=520&embedded=1&text=56">

  It would be better if the alt text could be the image description or
  if it could be entered manually via the interface.

  The alt text changing upon saving the HTML is a problem for
  accessibility.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1502371/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1507808] Re: Image browser selected option not sticking

2015-10-21 Thread Robert Lyon
** Also affects: mahara/15.04
   Importance: Undecided
   Status: New

** Changed in: mahara/15.04
   Status: New => Fix Committed

** Changed in: mahara/15.04
   Importance: Undecided => High

** Changed in: mahara/15.04
Milestone: None => 15.04.4

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1507808

Title:
  Image browser selected option not sticking

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Committed

Bug description:
  When I follow these steps:

  1) Add a 'text' block to a page
  2) Click the 'image' icon and choose an image and save popup form
  3) Save 'text' block form
  4) Edit 'text' block form again
  5) Select the image in tinymce content  and then click the 'image' icon
  6) Expand the 'Image' tab

  What I should see is the image I am dealing with be the selected
  option

  What I do see is no image selected

  Need the image broswer to remember it's already selected item.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1507808/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1502373] A patch has been submitted for review

2015-10-21 Thread Mahara Bot
Patch for "15.04_STABLE" branch: https://reviews.mahara.org/5580

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1502373

Title:
  Can't change image description in image selector in TinyMCE

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Committed

Bug description:
  Mahara 15.10RC1

  When you want to add an image to text via TinyMCE and you are on the
  "Insert or edit image" modal, and you want to change / add a
  description, add tags or change the commenting properties, you can't
  do so because upon clicking the "Save" button, nothing happens. You
  are just taken out of the modal, which is not correct either.

  The correct behavior should be that the new description, tags,
  comments properties are saved upon clicking the "Save" button and that
  you return to the modal where you can choose the image.

  Steps to replicate:

  1. Add a text block to a page.
  2. In TinyMCE in edit mode of the text block, click the image icon.
  3. In the "Image" panel, click the "Edit" button for an image and add a 
description, a tag and change the commenting status.
  4. Click the "Save" button.
  Expected result: The properties changed for the image when you click the 
"Edit" button next to the image again (or in Content -> Files). You can also 
continue selecting the image.

  Actual result: The properties are not changed and upon clicking "Save"
  you are returned to the main TinyMCE window and have to click the
  image button again in order to add the image.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1502373/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1502373] A change has been merged

2015-10-21 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/5580
Committed: 
https://git.nzoss.org.nz/mahara/mahara/commit/1edc31d8681731051a00b5a173c0c0a21181373d
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:15.04_STABLE

commit 1edc31d8681731051a00b5a173c0c0a21181373d
Author: Son Nguyen 
Date:   Wed Oct 7 11:08:06 2015 +1300

Updating image description in image selector in TinyMCE. Bug 1502373

behatnotneeded: this is a fix not a feature

Change-Id: I3ecc5facdcff97edf3dd8433dc17cc60c26243f5

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1502373

Title:
  Can't change image description in image selector in TinyMCE

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Committed

Bug description:
  Mahara 15.10RC1

  When you want to add an image to text via TinyMCE and you are on the
  "Insert or edit image" modal, and you want to change / add a
  description, add tags or change the commenting properties, you can't
  do so because upon clicking the "Save" button, nothing happens. You
  are just taken out of the modal, which is not correct either.

  The correct behavior should be that the new description, tags,
  comments properties are saved upon clicking the "Save" button and that
  you return to the modal where you can choose the image.

  Steps to replicate:

  1. Add a text block to a page.
  2. In TinyMCE in edit mode of the text block, click the image icon.
  3. In the "Image" panel, click the "Edit" button for an image and add a 
description, a tag and change the commenting status.
  4. Click the "Save" button.
  Expected result: The properties changed for the image when you click the 
"Edit" button next to the image again (or in Content -> Files). You can also 
continue selecting the image.

  Actual result: The properties are not changed and upon clicking "Save"
  you are returned to the main TinyMCE window and have to click the
  image button again in order to add the image.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1502373/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1507808] A change has been merged

2015-10-21 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/5582
Committed: 
https://git.nzoss.org.nz/mahara/mahara/commit/bd1c33796a71f84c2fd796f1f14c95f4c3972b60
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:15.04_STABLE

commit bd1c33796a71f84c2fd796f1f14c95f4c3972b60
Author: Robert Lyon 
Date:   Tue Oct 20 12:00:32 2015 +1300

Bug 1507808: TinyMce Image browser to remember selected option

When we go back to edit the image

behatnotneeded

Change-Id: I54c44461b8c148fa4a6386060d09dba3ee5d8984
Signed-off-by: Robert Lyon 

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1507808

Title:
  Image browser selected option not sticking

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Committed

Bug description:
  When I follow these steps:

  1) Add a 'text' block to a page
  2) Click the 'image' icon and choose an image and save popup form
  3) Save 'text' block form
  4) Edit 'text' block form again
  5) Select the image in tinymce content  and then click the 'image' icon
  6) Expand the 'Image' tab

  What I should see is the image I am dealing with be the selected
  option

  What I do see is no image selected

  Need the image broswer to remember it's already selected item.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1507808/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1502371] Re: No proper alt text for images and replacing of alt text in images in TinyMCE

2015-10-21 Thread Robert Lyon
** Changed in: mahara/15.04
   Status: Confirmed => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1502371

Title:
  No proper alt text for images and replacing of alt text in images in
  TinyMCE

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Committed

Bug description:
  Tested in 15.04 and 15.10

  When an image is put into a text or note block via TinyMCE, the alt
  text is automatically set to the image's path. Even when you overwrite
  it in the HTML code, it is replaced with the image path upon saving.

  https://yoururl/artefact/file/download.php?file=520&embedded=1&text=569296";
  alt="download.php?file=520&embedded=1&text=56">

  It would be better if the alt text could be the image description or
  if it could be entered manually via the interface.

  The alt text changing upon saving the HTML is a problem for
  accessibility.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1502371/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1502373] Re: Can't change image description in image selector in TinyMCE

2015-10-21 Thread Robert Lyon
** Changed in: mahara/15.04
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1502373

Title:
  Can't change image description in image selector in TinyMCE

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Committed

Bug description:
  Mahara 15.10RC1

  When you want to add an image to text via TinyMCE and you are on the
  "Insert or edit image" modal, and you want to change / add a
  description, add tags or change the commenting properties, you can't
  do so because upon clicking the "Save" button, nothing happens. You
  are just taken out of the modal, which is not correct either.

  The correct behavior should be that the new description, tags,
  comments properties are saved upon clicking the "Save" button and that
  you return to the modal where you can choose the image.

  Steps to replicate:

  1. Add a text block to a page.
  2. In TinyMCE in edit mode of the text block, click the image icon.
  3. In the "Image" panel, click the "Edit" button for an image and add a 
description, a tag and change the commenting status.
  4. Click the "Save" button.
  Expected result: The properties changed for the image when you click the 
"Edit" button next to the image again (or in Content -> Files). You can also 
continue selecting the image.

  Actual result: The properties are not changed and upon clicking "Save"
  you are returned to the main TinyMCE window and have to click the
  image button again in order to add the image.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1502373/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1507808] A patch has been submitted for review

2015-10-21 Thread Mahara Bot
Patch for "15.04_STABLE" branch: https://reviews.mahara.org/5582

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1507808

Title:
  Image browser selected option not sticking

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Committed

Bug description:
  When I follow these steps:

  1) Add a 'text' block to a page
  2) Click the 'image' icon and choose an image and save popup form
  3) Save 'text' block form
  4) Edit 'text' block form again
  5) Select the image in tinymce content  and then click the 'image' icon
  6) Expand the 'Image' tab

  What I should see is the image I am dealing with be the selected
  option

  What I do see is no image selected

  Need the image broswer to remember it's already selected item.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1507808/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1502373] Re: Can't change image description in image selector in TinyMCE

2015-10-21 Thread Robert Lyon
** Also affects: mahara/15.04
   Importance: Undecided
   Status: New

** Changed in: mahara/15.04
   Status: New => In Progress

** Changed in: mahara/15.04
   Importance: Undecided => High

** Changed in: mahara/15.04
 Assignee: (unassigned) => Robert Lyon (robertl-9)

** Changed in: mahara/15.04
Milestone: None => 15.04.4

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1502373

Title:
  Can't change image description in image selector in TinyMCE

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  In Progress

Bug description:
  Mahara 15.10RC1

  When you want to add an image to text via TinyMCE and you are on the
  "Insert or edit image" modal, and you want to change / add a
  description, add tags or change the commenting properties, you can't
  do so because upon clicking the "Save" button, nothing happens. You
  are just taken out of the modal, which is not correct either.

  The correct behavior should be that the new description, tags,
  comments properties are saved upon clicking the "Save" button and that
  you return to the modal where you can choose the image.

  Steps to replicate:

  1. Add a text block to a page.
  2. In TinyMCE in edit mode of the text block, click the image icon.
  3. In the "Image" panel, click the "Edit" button for an image and add a 
description, a tag and change the commenting status.
  4. Click the "Save" button.
  Expected result: The properties changed for the image when you click the 
"Edit" button next to the image again (or in Content -> Files). You can also 
continue selecting the image.

  Actual result: The properties are not changed and upon clicking "Save"
  you are returned to the main TinyMCE window and have to click the
  image button again in order to add the image.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1502373/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1508693] [NEW] Bad help box styling in "fresh" theme

2015-10-21 Thread Aaron Wells
Public bug reported:

Reported on the forums:
https://mahara.org/interaction/forum/topic.php?id=7415&offset=0&limit=10#post29802

In the 15.04 "fresh" theme, the pop-up help box is hard to read because
of its CSS styling.

** Affects: mahara
 Importance: Medium
 Status: Confirmed

** Affects: mahara/1.10
 Importance: Medium
 Status: Confirmed

** Affects: mahara/1.9
 Importance: Medium
 Status: Confirmed

** Affects: mahara/15.04
 Importance: Medium
 Status: Confirmed


** Tags: theming

** Changed in: mahara
   Status: New => Confirmed

** Changed in: mahara
   Importance: Undecided => Medium

** Tags added: theming

** Also affects: mahara/15.04
   Importance: Undecided
   Status: New

** Changed in: mahara/15.04
Milestone: None => 15.04.4

** Changed in: mahara/15.04
   Status: New => Confirmed

** Changed in: mahara/15.04
   Importance: Undecided => Medium

** Also affects: mahara/1.10
   Importance: Undecided
   Status: New

** Also affects: mahara/1.9
   Importance: Undecided
   Status: New

** Changed in: mahara/1.9
   Status: New => Confirmed

** Changed in: mahara/1.10
   Status: New => Confirmed

** Changed in: mahara/1.9
   Importance: Undecided => Medium

** Changed in: mahara/1.10
   Importance: Undecided => Medium

** Changed in: mahara/1.9
Milestone: None => 1.9.9

** Changed in: mahara/1.10
Milestone: None => 1.10.8

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1508693

Title:
  Bad help box styling in "fresh" theme

Status in Mahara:
  Confirmed
Status in Mahara 1.10 series:
  Confirmed
Status in Mahara 1.9 series:
  Confirmed
Status in Mahara 15.04 series:
  Confirmed

Bug description:
  Reported on the forums:
  
https://mahara.org/interaction/forum/topic.php?id=7415&offset=0&limit=10#post29802

  In the 15.04 "fresh" theme, the pop-up help box is hard to read
  because of its CSS styling.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1508693/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1508693] Re: Bad help box styling in "fresh" theme

2015-10-21 Thread Aaron Wells
It turns out this problem goes back at least to Mahara 1.9. It won't be
a problem in 15.10+, because we've eliminated the "fresh" theme.

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1508693

Title:
  Bad help box styling in "fresh" theme

Status in Mahara:
  Confirmed
Status in Mahara 1.10 series:
  Confirmed
Status in Mahara 1.9 series:
  Confirmed
Status in Mahara 15.04 series:
  Confirmed

Bug description:
  Reported on the forums:
  
https://mahara.org/interaction/forum/topic.php?id=7415&offset=0&limit=10#post29802

  In the 15.04 "fresh" theme, the pop-up help box is hard to read
  because of its CSS styling.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1508693/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1499122] Re: Threaded comments display in the wrong order

2015-10-21 Thread Robert Lyon
** Changed in: mahara/15.10
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1499122

Title:
  Threaded comments display in the wrong order

Status in Mahara:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed

Bug description:
  To replicate:

  1. Clean install of Mahara
  2. In the "No institution" settings, turn on threaded comments. Leave the 
comment sort order on the default "ascending"
  3. Create a page
  4. Leave about 10 comments on the page. Don't make any of them be replies.

  Expected result: Because the comments aren't replies, they should be 
displayed on the page in the order they were created
  Actual result: After the first few comments are posted, comments will start 
showing up at the top of the list of comments

  The reason for this is because the sortorder for "threaded ascending"
  is (artefact.path, artefact.ctime, id). Since artefact.path is a
  string, and gets sorted in alphabetical order, when the artefact IDs
  go from 1 digit to 2 digits, the 1 digit ones will start sorting below
  the 2 digit ones. I.e. "/11" comes before "/6", in string sorting
  order.

  A similar thing will happen if threaded comments are sorted in
  descending order.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1499122/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1499122] A change has been merged

2015-10-21 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/5568
Committed: 
https://git.nzoss.org.nz/mahara/mahara/commit/acfa725937c99b586a0fc31fc3e5523f6549b647
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:15.10_STABLE

commit acfa725937c99b586a0fc31fc3e5523f6549b647
Author: Son Nguyen 
Date:   Wed Oct 21 12:23:15 2015 +1300

Fix sorting threaded comments. Bug 1499122

- Add new column 'threadedposition' to table artefact_comment_comment
- Update the column for existing comments
- Calculate the position for new comments
- Display threaded commented using this for correct order
- Add a behat test
- Fix problems in upgrade script (Bug 1508301)

Change-Id: I607f26fee8f761754a41a21c6f58dd74cfb6

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1499122

Title:
  Threaded comments display in the wrong order

Status in Mahara:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed

Bug description:
  To replicate:

  1. Clean install of Mahara
  2. In the "No institution" settings, turn on threaded comments. Leave the 
comment sort order on the default "ascending"
  3. Create a page
  4. Leave about 10 comments on the page. Don't make any of them be replies.

  Expected result: Because the comments aren't replies, they should be 
displayed on the page in the order they were created
  Actual result: After the first few comments are posted, comments will start 
showing up at the top of the list of comments

  The reason for this is because the sortorder for "threaded ascending"
  is (artefact.path, artefact.ctime, id). Since artefact.path is a
  string, and gets sorted in alphabetical order, when the artefact IDs
  go from 1 digit to 2 digits, the 1 digit ones will start sorting below
  the 2 digit ones. I.e. "/11" comes before "/6", in string sorting
  order.

  A similar thing will happen if threaded comments are sorted in
  descending order.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1499122/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1508301] A change has been merged

2015-10-21 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/5568
Committed: 
https://git.nzoss.org.nz/mahara/mahara/commit/acfa725937c99b586a0fc31fc3e5523f6549b647
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:15.10_STABLE

commit acfa725937c99b586a0fc31fc3e5523f6549b647
Author: Son Nguyen 
Date:   Wed Oct 21 12:23:15 2015 +1300

Fix sorting threaded comments. Bug 1499122

- Add new column 'threadedposition' to table artefact_comment_comment
- Update the column for existing comments
- Calculate the position for new comments
- Display threaded commented using this for correct order
- Add a behat test
- Fix problems in upgrade script (Bug 1508301)

Change-Id: I607f26fee8f761754a41a21c6f58dd74cfb6

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1508301

Title:
  Fatal error in threaded comments sortorder upgrade script

Status in Mahara:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Committed
Status in Mahara 16.04 series:
  In Progress

Bug description:
  The upgrade script for Bug 1499122 causes some fatal errors during
  upgrade.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1508301/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1508301] Re: Fatal error in threaded comments sortorder upgrade script

2015-10-21 Thread Robert Lyon
** Changed in: mahara/15.10
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1508301

Title:
  Fatal error in threaded comments sortorder upgrade script

Status in Mahara:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Committed
Status in Mahara 16.04 series:
  In Progress

Bug description:
  The upgrade script for Bug 1499122 causes some fatal errors during
  upgrade.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1508301/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1416147] A patch has been submitted for review

2015-10-21 Thread Mahara Bot
Patch for "1.10_STABLE" branch: https://reviews.mahara.org/5577

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1416147

Title:
  MySQL error in ORDER BY clause in get_artefactchooser_artefacts()

Status in Mahara:
  Fix Released
Status in Mahara 1.10 series:
  In Progress
Status in Mahara 1.9 series:
  In Progress

Bug description:
  For some reason works fine on Postgres...

  To reproduce:

  1. Create a journal post.
  2.  Go to pages.
  3. Create a page.
  4. Add "Journal entry" block.
  5. See this error:

  Failed to get a recordset: mysqli error: [1064: You have an error in
  your SQL syntax; check the manual that corresponds to your MySQL
  server version for the right syntax to use near 'BY parent ASC, ctime
  DESC LIMIT 10' at line 15] in EXECUTE("SELECT a.*, (a.owner IS NOT
  NULL AND a.owner = '1') AS editable FROM "mhr_artefact" a WHERE (
  a.owner = '1' OR a.id IN ( SELECT id FROM "mhr_artefact" WHERE (path =
  '/5' OR path LIKE '/5/%') AND institution = 'mahara' ) OR a.id IN (
  SELECT aar.artefact FROM "mhr_group_member" m JOIN "mhr_artefact" aa
  ON m.group = aa.group JOIN "mhr_artefact_access_role" aar ON aar.role
  = m.role AND aar.artefact = aa.id WHERE m.member = '1' AND
  aar.can_republish = 1 ) OR a.id IN (SELECT artefact FROM
  "mhr_artefact_access_usr" WHERE usr = '1' AND can_republish = 1) OR
  a.institution IN ('mahara') ) AND artefacttype IN('blogpost') AND id =
  6ORDER BY parent ASC, ctime DESC LIMIT 10") Command was: SELECT a.*,
  (a.owner IS NOT NULL AND a.owner = ?) AS editable FROM "mhr_artefact"
  a WHERE ( a.owner = ? OR a.id IN ( SELECT id FROM "mhr_artefact" WHERE
  (path = ? OR path LIKE ?) AND institution = 'mahara' ) OR a.id IN (
  SELECT aar.artefact FROM "mhr_group_member" m JOIN "mhr_artefact" aa
  ON m.group = aa.group JOIN "mhr_artefact_access_role" aar ON aar.role
  = m.role AND aar.artefact = aa.id WHERE m.member = ? AND
  aar.can_republish = 1 ) OR a.id IN (SELECT artefact FROM
  "mhr_artefact_access_usr" WHERE usr = ? AND can_republish = 1) OR
  a.institution IN (?) ) AND artefacttype IN(?) AND id = 6ORDER BY
  parent ASC, ctime DESC and values was
  (1,1,/5,/5/%,1,1,mahara,blogpost)

  SQL is missing space before ORDER BY...

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1416147/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1416147] A patch has been submitted for review

2015-10-21 Thread Mahara Bot
Patch for "1.9_STABLE" branch: https://reviews.mahara.org/5578

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1416147

Title:
  MySQL error in ORDER BY clause in get_artefactchooser_artefacts()

Status in Mahara:
  Fix Released
Status in Mahara 1.10 series:
  In Progress
Status in Mahara 1.9 series:
  In Progress

Bug description:
  For some reason works fine on Postgres...

  To reproduce:

  1. Create a journal post.
  2.  Go to pages.
  3. Create a page.
  4. Add "Journal entry" block.
  5. See this error:

  Failed to get a recordset: mysqli error: [1064: You have an error in
  your SQL syntax; check the manual that corresponds to your MySQL
  server version for the right syntax to use near 'BY parent ASC, ctime
  DESC LIMIT 10' at line 15] in EXECUTE("SELECT a.*, (a.owner IS NOT
  NULL AND a.owner = '1') AS editable FROM "mhr_artefact" a WHERE (
  a.owner = '1' OR a.id IN ( SELECT id FROM "mhr_artefact" WHERE (path =
  '/5' OR path LIKE '/5/%') AND institution = 'mahara' ) OR a.id IN (
  SELECT aar.artefact FROM "mhr_group_member" m JOIN "mhr_artefact" aa
  ON m.group = aa.group JOIN "mhr_artefact_access_role" aar ON aar.role
  = m.role AND aar.artefact = aa.id WHERE m.member = '1' AND
  aar.can_republish = 1 ) OR a.id IN (SELECT artefact FROM
  "mhr_artefact_access_usr" WHERE usr = '1' AND can_republish = 1) OR
  a.institution IN ('mahara') ) AND artefacttype IN('blogpost') AND id =
  6ORDER BY parent ASC, ctime DESC LIMIT 10") Command was: SELECT a.*,
  (a.owner IS NOT NULL AND a.owner = ?) AS editable FROM "mhr_artefact"
  a WHERE ( a.owner = ? OR a.id IN ( SELECT id FROM "mhr_artefact" WHERE
  (path = ? OR path LIKE ?) AND institution = 'mahara' ) OR a.id IN (
  SELECT aar.artefact FROM "mhr_group_member" m JOIN "mhr_artefact" aa
  ON m.group = aa.group JOIN "mhr_artefact_access_role" aar ON aar.role
  = m.role AND aar.artefact = aa.id WHERE m.member = ? AND
  aar.can_republish = 1 ) OR a.id IN (SELECT artefact FROM
  "mhr_artefact_access_usr" WHERE usr = ? AND can_republish = 1) OR
  a.institution IN (?) ) AND artefacttype IN(?) AND id = 6ORDER BY
  parent ASC, ctime DESC and values was
  (1,1,/5,/5/%,1,1,mahara,blogpost)

  SQL is missing space before ORDER BY...

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1416147/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1416147] Re: MySQL error in ORDER BY clause in get_artefactchooser_artefacts()

2015-10-21 Thread Robert Lyon
** Also affects: mahara/1.10
   Importance: Undecided
   Status: New

** Also affects: mahara/1.9
   Importance: Undecided
   Status: New

** Changed in: mahara/1.10
   Importance: Undecided => Medium

** Changed in: mahara/1.9
   Importance: Undecided => Medium

** Changed in: mahara/1.10
   Status: New => In Progress

** Changed in: mahara/1.9
   Status: New => In Progress

** Changed in: mahara/1.10
Milestone: None => 1.9.9

** Changed in: mahara/1.9
Milestone: None => 1.9.9

** Changed in: mahara/1.10
Milestone: 1.9.9 => 1.10.7

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1416147

Title:
  MySQL error in ORDER BY clause in get_artefactchooser_artefacts()

Status in Mahara:
  Fix Released
Status in Mahara 1.10 series:
  In Progress
Status in Mahara 1.9 series:
  In Progress

Bug description:
  For some reason works fine on Postgres...

  To reproduce:

  1. Create a journal post.
  2.  Go to pages.
  3. Create a page.
  4. Add "Journal entry" block.
  5. See this error:

  Failed to get a recordset: mysqli error: [1064: You have an error in
  your SQL syntax; check the manual that corresponds to your MySQL
  server version for the right syntax to use near 'BY parent ASC, ctime
  DESC LIMIT 10' at line 15] in EXECUTE("SELECT a.*, (a.owner IS NOT
  NULL AND a.owner = '1') AS editable FROM "mhr_artefact" a WHERE (
  a.owner = '1' OR a.id IN ( SELECT id FROM "mhr_artefact" WHERE (path =
  '/5' OR path LIKE '/5/%') AND institution = 'mahara' ) OR a.id IN (
  SELECT aar.artefact FROM "mhr_group_member" m JOIN "mhr_artefact" aa
  ON m.group = aa.group JOIN "mhr_artefact_access_role" aar ON aar.role
  = m.role AND aar.artefact = aa.id WHERE m.member = '1' AND
  aar.can_republish = 1 ) OR a.id IN (SELECT artefact FROM
  "mhr_artefact_access_usr" WHERE usr = '1' AND can_republish = 1) OR
  a.institution IN ('mahara') ) AND artefacttype IN('blogpost') AND id =
  6ORDER BY parent ASC, ctime DESC LIMIT 10") Command was: SELECT a.*,
  (a.owner IS NOT NULL AND a.owner = ?) AS editable FROM "mhr_artefact"
  a WHERE ( a.owner = ? OR a.id IN ( SELECT id FROM "mhr_artefact" WHERE
  (path = ? OR path LIKE ?) AND institution = 'mahara' ) OR a.id IN (
  SELECT aar.artefact FROM "mhr_group_member" m JOIN "mhr_artefact" aa
  ON m.group = aa.group JOIN "mhr_artefact_access_role" aar ON aar.role
  = m.role AND aar.artefact = aa.id WHERE m.member = ? AND
  aar.can_republish = 1 ) OR a.id IN (SELECT artefact FROM
  "mhr_artefact_access_usr" WHERE usr = ? AND can_republish = 1) OR
  a.institution IN (?) ) AND artefacttype IN(?) AND id = 6ORDER BY
  parent ASC, ctime DESC and values was
  (1,1,/5,/5/%,1,1,mahara,blogpost)

  SQL is missing space before ORDER BY...

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1416147/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1508684] [NEW] Unserialize untrusted data when importing skins

2015-10-21 Thread Son Nguyen
*** This bug is a security vulnerability ***

Private security bug reported:

Version: 1.10, 15.04. 15.10, master
Platform: any

There is a unserialize vulnerability in skin import function

see line 200 in htdocs/skin/import.php

When importing the attached skin, you will see the error:

[WAR] ce (lib/web.php:3684) Object of class __PHP_Incomplete_Class could not be 
converted to string
Call stack (most recent first):
log_message("Object of class __PHP_Incomplete_Class could not b...", 8, true, 
true, "/var/www/mahara/master/htdocs/lib/web.php", 3684) at 
/var/www/mahara/master/htdocs/lib/errors.php:441
error(4096, "Object of class __PHP_Incomplete_Class could not b...", 
"/var/www/mahara/master/htdocs/lib/web.php", 3684, array(size 5)) at 
/var/www/mahara/master/htdocs/lib/web.php:3684
clean_css(object(__PHP_Incomplete_Class), true) at 
/var/www/mahara/master/htdocs/skin/import.php:200
importskinform_submit(object(Pieform), array(size 4)) at Unknown:0
call_user_func_array("importskinform_submit", array(size 2)) at 
/var/www/mahara/master/htdocs/lib/pieforms/pieform.php:537
Pieform->__construct(array(size 4)) at 
/var/www/mahara/master/htdocs/lib/pieforms/pieform.php:164
Pieform::process(array(size 4)) at 
/var/www/mahara/master/htdocs/lib/pieforms/pieform.php:71
pieform(array(size 4)) at /var/www/mahara/master/htdocs/skin/import.php:64

** Affects: mahara
 Importance: Critical
 Assignee: Son Nguyen (ngson2000)
 Status: Confirmed

** Attachment added: "myskin.xml"
   https://bugs.launchpad.net/bugs/1508684/+attachment/4502005/+files/myskin.xml

** Information type changed from Public to Private Security

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1508684

Title:
  Unserialize untrusted data when importing skins

Status in Mahara:
  Confirmed

Bug description:
  Version: 1.10, 15.04. 15.10, master
  Platform: any

  There is a unserialize vulnerability in skin import function

  see line 200 in htdocs/skin/import.php

  When importing the attached skin, you will see the error:

  [WAR] ce (lib/web.php:3684) Object of class __PHP_Incomplete_Class could not 
be converted to string
  Call stack (most recent first):
  log_message("Object of class __PHP_Incomplete_Class could not b...", 8, true, 
true, "/var/www/mahara/master/htdocs/lib/web.php", 3684) at 
/var/www/mahara/master/htdocs/lib/errors.php:441
  error(4096, "Object of class __PHP_Incomplete_Class could not b...", 
"/var/www/mahara/master/htdocs/lib/web.php", 3684, array(size 5)) at 
/var/www/mahara/master/htdocs/lib/web.php:3684
  clean_css(object(__PHP_Incomplete_Class), true) at 
/var/www/mahara/master/htdocs/skin/import.php:200
  importskinform_submit(object(Pieform), array(size 4)) at Unknown:0
  call_user_func_array("importskinform_submit", array(size 2)) at 
/var/www/mahara/master/htdocs/lib/pieforms/pieform.php:537
  Pieform->__construct(array(size 4)) at 
/var/www/mahara/master/htdocs/lib/pieforms/pieform.php:164
  Pieform::process(array(size 4)) at 
/var/www/mahara/master/htdocs/lib/pieforms/pieform.php:71
  pieform(array(size 4)) at /var/www/mahara/master/htdocs/skin/import.php:64

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1508684/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1490569] A change has been merged

2015-10-21 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/5576
Committed: 
https://git.nzoss.org.nz/mahara/mahara/commit/04095d7e2e65057719b3cdd123fd9266e2a52531
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:15.10_STABLE

commit 04095d7e2e65057719b3cdd123fd9266e2a52531
Author: Son Nguyen 
Date:   Thu Oct 8 09:52:52 2015 +1300

Show created or updated time for shared pages to a group. Bug 1490569.

Change-Id: Ie30deb73078269be4b3f0e1414e1ea4cb70dc917
(cherry picked from commit d2a4f3862b62453eb68bf249734c4ca828779f78)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1490569

Title:
  Sort submitted pages "Most recently submitted" doesn't work

Status in Mahara:
  Confirmed

Bug description:
  Hello,

  When adding a 'pages shared' block to a group, one of the settings is "Sort 
submitted pages and collections" by "Most recently updated". While trying to 
use this with a group (v15.04)  I've found that the displayed sort order of the 
shared pages doesn't change from the default 'alphabetically'.
  Worth noting it would also be worth having the option to display pages in the 
order 'most recently shared' - subtly different from when they were updated but 
a useful feature if it could be added.

  Regards, Gordon.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1490569/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1490569] A patch has been submitted for review

2015-10-21 Thread Mahara Bot
Patch for "15.10_STABLE" branch: https://reviews.mahara.org/5576

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1490569

Title:
  Sort submitted pages "Most recently submitted" doesn't work

Status in Mahara:
  Confirmed

Bug description:
  Hello,

  When adding a 'pages shared' block to a group, one of the settings is "Sort 
submitted pages and collections" by "Most recently updated". While trying to 
use this with a group (v15.04)  I've found that the displayed sort order of the 
shared pages doesn't change from the default 'alphabetically'.
  Worth noting it would also be worth having the option to display pages in the 
order 'most recently shared' - subtly different from when they were updated but 
a useful feature if it could be added.

  Regards, Gordon.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1490569/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1506034] A change has been merged

2015-10-21 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/5558
Committed: 
https://git.nzoss.org.nz/mahara/mahara/commit/69c60285f08d9376499acc37fa0f88fdd9b50af1
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master

commit 69c60285f08d9376499acc37fa0f88fdd9b50af1
Author: Pat Kira 
Date:   Fri Oct 16 13:27:55 2015 +1300

Fix edit group modal dialog (bug:1506034)

behatnotneeded

Change-Id: I7bebd67a8a860d707eeaa0b867352559910223b5

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1506034

Title:
  Unable to scroll when editing Group Membership under My Friends.

Status in Mahara:
  Fix Committed

Bug description:
  When you click 'Edit group membership' under the 'My Friends' tab, if
  you have a large number of groups you are administering there is no
  way to scroll down to the bottom on the list.

  This issue is the same on Macs and PC. Has been tested with Safari and
  Chrome.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1506034/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1506034] A change has been merged

2015-10-21 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/5575
Committed: 
https://git.nzoss.org.nz/mahara/mahara/commit/c7ce0fb06adf38323b4cfbeb153e295800de85e2
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:15.10_STABLE

commit c7ce0fb06adf38323b4cfbeb153e295800de85e2
Author: Pat Kira 
Date:   Fri Oct 16 13:27:55 2015 +1300

Fix edit group modal dialog (bug:1506034)

behatnotneeded

Change-Id: I7bebd67a8a860d707eeaa0b867352559910223b5
(cherry picked from commit 69c60285f08d9376499acc37fa0f88fdd9b50af1)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1506034

Title:
  Unable to scroll when editing Group Membership under My Friends.

Status in Mahara:
  Fix Committed

Bug description:
  When you click 'Edit group membership' under the 'My Friends' tab, if
  you have a large number of groups you are administering there is no
  way to scroll down to the bottom on the list.

  This issue is the same on Macs and PC. Has been tested with Safari and
  Chrome.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1506034/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1506034] Re: Unable to scroll when editing Group Membership under My Friends.

2015-10-21 Thread Robert Lyon
** Changed in: mahara
   Status: Confirmed => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1506034

Title:
  Unable to scroll when editing Group Membership under My Friends.

Status in Mahara:
  Fix Committed

Bug description:
  When you click 'Edit group membership' under the 'My Friends' tab, if
  you have a large number of groups you are administering there is no
  way to scroll down to the bottom on the list.

  This issue is the same on Macs and PC. Has been tested with Safari and
  Chrome.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1506034/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1506034] A patch has been submitted for review

2015-10-21 Thread Mahara Bot
Patch for "15.10_STABLE" branch: https://reviews.mahara.org/5575

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1506034

Title:
  Unable to scroll when editing Group Membership under My Friends.

Status in Mahara:
  Fix Committed

Bug description:
  When you click 'Edit group membership' under the 'My Friends' tab, if
  you have a large number of groups you are administering there is no
  way to scroll down to the bottom on the list.

  This issue is the same on Macs and PC. Has been tested with Safari and
  Chrome.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1506034/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1490569] A change has been merged

2015-10-21 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/5475
Committed: 
https://git.nzoss.org.nz/mahara/mahara/commit/d2a4f3862b62453eb68bf249734c4ca828779f78
Submitter: Son Nguyen (son.ngu...@catalyst.net.nz)
Branch:master

commit d2a4f3862b62453eb68bf249734c4ca828779f78
Author: Son Nguyen 
Date:   Thu Oct 8 09:52:52 2015 +1300

Show created or updated time for shared pages to a group. Bug 1490569.

Change-Id: Ie30deb73078269be4b3f0e1414e1ea4cb70dc917

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1490569

Title:
  Sort submitted pages "Most recently submitted" doesn't work

Status in Mahara:
  Confirmed

Bug description:
  Hello,

  When adding a 'pages shared' block to a group, one of the settings is "Sort 
submitted pages and collections" by "Most recently updated". While trying to 
use this with a group (v15.04)  I've found that the displayed sort order of the 
shared pages doesn't change from the default 'alphabetically'.
  Worth noting it would also be worth having the option to display pages in the 
order 'most recently shared' - subtly different from when they were updated but 
a useful feature if it could be added.

  Regards, Gordon.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1490569/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1502371] A change has been merged

2015-10-21 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/5572
Committed: 
https://git.nzoss.org.nz/mahara/mahara/commit/a380e693017ee804f272bc527052fe92bfe8db67
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:15.10_STABLE

commit a380e693017ee804f272bc527052fe92bfe8db67
Author: Robert Lyon 
Date:   Tue Oct 6 17:41:00 2015 +1300

Bug 1502371: Allowing the tinymce to record alt text for an embedded
image

based on either the description or the title of the image

behatnotneeded

Change-Id: I6deb362339ceeac29c6bb6425e853b120702ddae
Signed-off-by: Robert Lyon 
(cherry picked from commit 5edaff776e42a9389ca49ff48b77b01623b49507)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1502371

Title:
  No proper alt text for images and replacing of alt text in images in
  TinyMCE

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Confirmed
Status in Mahara 15.10 series:
  Fix Committed

Bug description:
  Tested in 15.04 and 15.10

  When an image is put into a text or note block via TinyMCE, the alt
  text is automatically set to the image's path. Even when you overwrite
  it in the HTML code, it is replaced with the image path upon saving.

  https://yoururl/artefact/file/download.php?file=520&embedded=1&text=569296";
  alt="download.php?file=520&embedded=1&text=56">

  It would be better if the alt text could be the image description or
  if it could be entered manually via the interface.

  The alt text changing upon saving the HTML is a problem for
  accessibility.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1502371/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1502371] A patch has been submitted for review

2015-10-21 Thread Mahara Bot
Patch for "15.10_STABLE" branch: https://reviews.mahara.org/5572

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1502371

Title:
  No proper alt text for images and replacing of alt text in images in
  TinyMCE

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Confirmed
Status in Mahara 15.10 series:
  Fix Committed

Bug description:
  Tested in 15.04 and 15.10

  When an image is put into a text or note block via TinyMCE, the alt
  text is automatically set to the image's path. Even when you overwrite
  it in the HTML code, it is replaced with the image path upon saving.

  https://yoururl/artefact/file/download.php?file=520&embedded=1&text=569296";
  alt="download.php?file=520&embedded=1&text=56">

  It would be better if the alt text could be the image description or
  if it could be entered manually via the interface.

  The alt text changing upon saving the HTML is a problem for
  accessibility.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1502371/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1502371] Re: No proper alt text for images and replacing of alt text in images in TinyMCE

2015-10-21 Thread Robert Lyon
** Changed in: mahara/15.10
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1502371

Title:
  No proper alt text for images and replacing of alt text in images in
  TinyMCE

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Confirmed
Status in Mahara 15.10 series:
  Fix Committed

Bug description:
  Tested in 15.04 and 15.10

  When an image is put into a text or note block via TinyMCE, the alt
  text is automatically set to the image's path. Even when you overwrite
  it in the HTML code, it is replaced with the image path upon saving.

  https://yoururl/artefact/file/download.php?file=520&embedded=1&text=569296";
  alt="download.php?file=520&embedded=1&text=56">

  It would be better if the alt text could be the image description or
  if it could be entered manually via the interface.

  The alt text changing upon saving the HTML is a problem for
  accessibility.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1502371/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1507808] A change has been merged

2015-10-21 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/5573
Committed: 
https://git.nzoss.org.nz/mahara/mahara/commit/d22b7454263d7dec8475f296cf28cd0095b23fce
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:15.10_STABLE

commit d22b7454263d7dec8475f296cf28cd0095b23fce
Author: Robert Lyon 
Date:   Tue Oct 20 12:00:32 2015 +1300

Bug 1507808: TinyMce Image browser to remember selected option

When we go back to edit the image

behatnotneeded

Change-Id: I54c44461b8c148fa4a6386060d09dba3ee5d8984
Signed-off-by: Robert Lyon 
(cherry picked from commit 1c5966422b8fc1fda54d4e9ff74b9ebbcf7d6672)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1507808

Title:
  Image browser selected option not sticking

Status in Mahara:
  Fix Committed

Bug description:
  When I follow these steps:

  1) Add a 'text' block to a page
  2) Click the 'image' icon and choose an image and save popup form
  3) Save 'text' block form
  4) Edit 'text' block form again
  5) Select the image in tinymce content  and then click the 'image' icon
  6) Expand the 'Image' tab

  What I should see is the image I am dealing with be the selected
  option

  What I do see is no image selected

  Need the image broswer to remember it's already selected item.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1507808/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1507808] Re: Image browser selected option not sticking

2015-10-21 Thread Robert Lyon
** Changed in: mahara
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1507808

Title:
  Image browser selected option not sticking

Status in Mahara:
  Fix Committed

Bug description:
  When I follow these steps:

  1) Add a 'text' block to a page
  2) Click the 'image' icon and choose an image and save popup form
  3) Save 'text' block form
  4) Edit 'text' block form again
  5) Select the image in tinymce content  and then click the 'image' icon
  6) Expand the 'Image' tab

  What I should see is the image I am dealing with be the selected
  option

  What I do see is no image selected

  Need the image broswer to remember it's already selected item.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1507808/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1507808] A patch has been submitted for review

2015-10-21 Thread Mahara Bot
Patch for "15.10_STABLE" branch: https://reviews.mahara.org/5573

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1507808

Title:
  Image browser selected option not sticking

Status in Mahara:
  Fix Committed

Bug description:
  When I follow these steps:

  1) Add a 'text' block to a page
  2) Click the 'image' icon and choose an image and save popup form
  3) Save 'text' block form
  4) Edit 'text' block form again
  5) Select the image in tinymce content  and then click the 'image' icon
  6) Expand the 'Image' tab

  What I should see is the image I am dealing with be the selected
  option

  What I do see is no image selected

  Need the image broswer to remember it's already selected item.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1507808/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1502371] A change has been merged

2015-10-21 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/5465
Committed: 
https://git.nzoss.org.nz/mahara/mahara/commit/5edaff776e42a9389ca49ff48b77b01623b49507
Submitter: Son Nguyen (son.ngu...@catalyst.net.nz)
Branch:master

commit 5edaff776e42a9389ca49ff48b77b01623b49507
Author: Robert Lyon 
Date:   Tue Oct 6 17:41:00 2015 +1300

Bug 1502371: Allowing the tinymce to record alt text for an embedded
image

based on either the description or the title of the image

behatnotneeded

Change-Id: I6deb362339ceeac29c6bb6425e853b120702ddae
Signed-off-by: Robert Lyon 

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1502371

Title:
  No proper alt text for images and replacing of alt text in images in
  TinyMCE

Status in Mahara:
  In Progress
Status in Mahara 15.04 series:
  Confirmed
Status in Mahara 15.10 series:
  In Progress

Bug description:
  Tested in 15.04 and 15.10

  When an image is put into a text or note block via TinyMCE, the alt
  text is automatically set to the image's path. Even when you overwrite
  it in the HTML code, it is replaced with the image path upon saving.

  https://yoururl/artefact/file/download.php?file=520&embedded=1&text=569296";
  alt="download.php?file=520&embedded=1&text=56">

  It would be better if the alt text could be the image description or
  if it could be entered manually via the interface.

  The alt text changing upon saving the HTML is a problem for
  accessibility.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1502371/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1507808] A change has been merged

2015-10-21 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/
Committed: 
https://git.nzoss.org.nz/mahara/mahara/commit/1c5966422b8fc1fda54d4e9ff74b9ebbcf7d6672
Submitter: Son Nguyen (son.ngu...@catalyst.net.nz)
Branch:master

commit 1c5966422b8fc1fda54d4e9ff74b9ebbcf7d6672
Author: Robert Lyon 
Date:   Tue Oct 20 12:00:32 2015 +1300

Bug 1507808: TinyMce Image browser to remember selected option

When we go back to edit the image

behatnotneeded

Change-Id: I54c44461b8c148fa4a6386060d09dba3ee5d8984
Signed-off-by: Robert Lyon 

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1507808

Title:
  Image browser selected option not sticking

Status in Mahara:
  In Progress

Bug description:
  When I follow these steps:

  1) Add a 'text' block to a page
  2) Click the 'image' icon and choose an image and save popup form
  3) Save 'text' block form
  4) Edit 'text' block form again
  5) Select the image in tinymce content  and then click the 'image' icon
  6) Expand the 'Image' tab

  What I should see is the image I am dealing with be the selected
  option

  What I do see is no image selected

  Need the image broswer to remember it's already selected item.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1507808/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1506034] Re: Unable to scroll when editing Group Membership under My Friends.

2015-10-21 Thread Domi Sinclair
Thank you :)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1506034

Title:
  Unable to scroll when editing Group Membership under My Friends.

Status in Mahara:
  Confirmed

Bug description:
  When you click 'Edit group membership' under the 'My Friends' tab, if
  you have a large number of groups you are administering there is no
  way to scroll down to the bottom on the list.

  This issue is the same on Macs and PC. Has been tested with Safari and
  Chrome.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1506034/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp