[Mahara-contributors] [Bug 1514718] [NEW] help icons don't work in modal windows
Public bug reported: Mahara 15.10 $config->version = 2015092910; $config->series = '15.10'; $config->release = '15.10.0'; Browser: Firefox 42 When adding an Authentication plugin to an institution, in the modal forms, the help icons generate javascript errors. such as: * node.nextSibling is null (coming from admin/users/addauthority.php) once the above is fixed: * elem is null (coming from js/MOchiKit/DOM.js) ** Affects: mahara Importance: Undecided Status: New -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1514718 Title: help icons don't work in modal windows Status in Mahara: New Bug description: Mahara 15.10 $config->version = 2015092910; $config->series = '15.10'; $config->release = '15.10.0'; Browser: Firefox 42 When adding an Authentication plugin to an institution, in the modal forms, the help icons generate javascript errors. such as: * node.nextSibling is null (coming from admin/users/addauthority.php) once the above is fixed: * elem is null (coming from js/MOchiKit/DOM.js) To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1514718/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1514608] Re: MySQL deadlock issues with simultaneous users
Okay, I was able to replicate this locally by hand, by having multiple users copy the same collection at the same time, and adding a command of "sleep(1)" into the execute_sql() function in lib/dml.php to increase the amount by which the queries overlap. 1. Set up a Mahara site with five users. 2. Have one of the users create a collection with several pages and artefacts. 3. Set the collection so that it is shared with all registered users, and it can be copied, and the owner retains view access to copies. 4. In four browser simultaneously: 4.1. Log in as one of the other four users. 4.2. View the copyable collection 4.3. Click the "copy" button (but don't yet click "Collection" in the confirmation popup) 5. Edit lib/dml.php, adding "sleep(1);" on line 138, inside of the execute_sql() function 6. In each of the four browsers in quick succession, click the "Collection" button. Expected result: It should copy the collection successfully in all four sessions. Actual result: Some of the sessions get a deadlock error message. In my case, two of them did, and they both deadlocked while trying to insert into the "view_rows_columns" table. [WAR] d9 (lib/errors.php:747) Failed to get a recordset: mysqli error: [1213: Deadlock found when trying to get lock; try restarting transaction] in adodb_throw(INSERT INTO "view_rows_columns" ("view", "row", "columns") VALUES (64, 1, 3), ) Command was: INSERT INTO "view_rows_columns" ("view", "row", "columns") VALUES (?, ?, ?) and values was (64,1,3) Call stack (most recent first): log_message("Failed to get a recordset: mysqli error: [1213: De...", 8, true, true) at /home/aaronw/www/mahara/htdocs/lib/errors.php:97 log_warn("Failed to get a recordset: mysqli error: [1213: De...") at /home/aaronw/www/mahara/htdocs/lib/errors.php:747 SQLException->__construct("Failed to get a recordset: mysqli error: [1213: De...") at /home/aaronw/www/mahara/htdocs/lib/dml.php:1055 insert_record("view_rows_columns", object(stdClass)) at /home/aaronw/www/mahara/htdocs/lib/view.php:756 View->commit() at /home/aaronw/www/mahara/htdocs/lib/view.php:581 View::_create(array(size 5), "4") at /home/aaronw/www/mahara/htdocs/lib/view.php:377 View::create_from_template(array(size 5), "12", "4", true, false) at /home/aaronw/www/mahara/htdocs/lib/collection.php:286 Collection::create_from_template(array(size 3), 1) at /home/aaronw/www/mahara/htdocs/lib/view.php:6141 copyview("6", 0, null, 1) at /home/aaronw/www/mahara/htdocs/view/copy.php:32 [WAR] d9 (lib/errors.php:747) Failed to get a recordset: mysqli error: [1452: Cannot add or update a child row: a foreign key constraint fails ("mahara"."view_rows_columns", CONSTRAINT "viewrowscolu_vie_fk" FOREIGN KEY ("view") REFERENCES "view" ("id"))] in adodb_throw(INSERT INTO "view_rows_columns" ("view", "row", "columns") VALUES (64, 1, 3), ) Command was: INSERT INTO "view_rows_columns" ("view", "row", "columns") VALUES (?, ?, ?) and values was (64,1,3) Call stack (most recent first): log_message("Failed to get a recordset: mysqli error: [1452: Ca...", 8, true, true) at /home/aaronw/www/mahara/htdocs/lib/errors.php:97 log_warn("Failed to get a recordset: mysqli error: [1452: Ca...") at /home/aaronw/www/mahara/htdocs/lib/errors.php:747 SQLException->__construct("Failed to get a recordset: mysqli error: [1452: Ca...") at /home/aaronw/www/mahara/htdocs/lib/dml.php:1055 insert_record("view_rows_columns", object(stdClass)) at /home/aaronw/www/mahara/htdocs/lib/view.php:756 View->commit() at /home/aaronw/www/mahara/htdocs/lib/view.php:704 View->__destruct() at /home/aaronw/www/mahara/htdocs/lib/view.php:377 View::_create(array(size 5), "4") at /home/aaronw/www/mahara/htdocs/lib/view.php:377 View::create_from_template(array(size 5), "12", "4", true, false) at /home/aaronw/www/mahara/htdocs/lib/collection.php:286 Collection::create_from_template(array(size 3), 1) at /home/aaronw/www/mahara/htdocs/lib/view.php:6141 copyview("6", 0, null, 1) at /home/aaronw/www/mahara/htdocs/view/copy.php:32 [WAR] d9 (lib/dml.php:1055) Failed to get a recordset: mysqli error: [1452: Cannot add or update a child row: a foreign key constraint fails ("mahara"."view_rows_columns", CONSTRAINT "viewrowscolu_vie_fk" FOREIGN KEY ("view") REFERENCES "view" ("id"))] in adodb_throw(INSERT INTO "view_rows_columns" ("view", "row", "columns") VALUES (64, 1, 3), ) Command was: INSERT INTO "view_rows_columns" ("view", "row", "columns") VALUES (?, ?, ?) and values was (64,1,3) Call stack (most recent first): insert_record("view_rows_columns", object(stdClass)) at /home/aaronw/www/mahara/htdocs/lib/view.php:756 View->commit() at /home/aaronw/www/mahara/htdocs/lib/view.php:704 View->__destruct() at /home/aaronw/www/mahara/htdocs/lib/view.php:377 View::_create(array(size 5), "4") at /home/aaronw/www/mahara/htdocs/lib/view.php:377 View::create_from_template(array(size 5), "12", "4", true, false) at /home/aaronw/www/mahara/htdocs/lib/collection.php:286 Collection::create_fro
[Mahara-contributors] [Bug 1514608] Re: MySQL deadlock issues with simultaneous users
It sounds like multiple people copying a collection at the same time, is the most consistent cause of the problem. ** Description changed: The patch in Bug 1492919 resolved the deadlock issues for some users, but others are still reporting that they are getting deadlocks. This seems to be an issue unique to MySQL, and it can happen with as few as 2 or 3 concurrent users. It has been reported across all stable versions. Strangely, it seems to be a relatively recent issue (i.e. we never heard this with Mahara 1.8 or 1.7, etc), so this suggests it was triggered by something that changed fairly recently. One possible candidate is our switch to the mysqli driver (before that Mahara wasn't doing transactions at all, in mysql). + + See also + https://mahara.org/interaction/forum/topic.php?id=7309&offset=0&limit=10 ** Description changed: The patch in Bug 1492919 resolved the deadlock issues for some users, but others are still reporting that they are getting deadlocks. This seems to be an issue unique to MySQL, and it can happen with as few as 2 or 3 concurrent users. It has been reported across all stable versions. Strangely, it seems to be a relatively recent issue (i.e. we never heard this with Mahara 1.8 or 1.7, etc), so this suggests it was triggered by something that changed fairly recently. One possible candidate is our switch to the mysqli driver (before that Mahara wasn't doing transactions at all, in mysql). - See also - https://mahara.org/interaction/forum/topic.php?id=7309&offset=0&limit=10 + See also: + * https://mahara.org/interaction/forum/topic.php?id=7309 + * https://mahara.org/interaction/forum/topic.php?id=7432 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1514608 Title: MySQL deadlock issues with simultaneous users Status in Mahara: In Progress Bug description: The patch in Bug 1492919 resolved the deadlock issues for some users, but others are still reporting that they are getting deadlocks. This seems to be an issue unique to MySQL, and it can happen with as few as 2 or 3 concurrent users. It has been reported across all stable versions. Strangely, it seems to be a relatively recent issue (i.e. we never heard this with Mahara 1.8 or 1.7, etc), so this suggests it was triggered by something that changed fairly recently. One possible candidate is our switch to the mysqli driver (before that Mahara wasn't doing transactions at all, in mysql). See also: * https://mahara.org/interaction/forum/topic.php?id=7309 * https://mahara.org/interaction/forum/topic.php?id=7432 To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1514608/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1514674] [NEW] Embeding image in textbox results in javascript error
Public bug reported: Mahara 15.10 $config->version = 2015092910; $config->series = '15.10'; $config->release = '15.10.0'; Browser: Firefox 42.0 When embedding an image (doesn't matter what type) in a text box via the TinyMCE "Insert or select an image" icon, once the user has selected the image (from their list of files), upon saving, gets this javascript error: TypeError: newtitle is null http://d.acttqi.mahara/artefact/file/js/filebrowser.js?v=57 Line 695 A check needs to go in for newtitle - to make sure it actually exists. i.e. artefact/file/js/filebrowser.js :: line 694, add following check: if (filetitle && newtitle) { ... } ** Affects: mahara Importance: Undecided Status: New -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1514674 Title: Embeding image in textbox results in javascript error Status in Mahara: New Bug description: Mahara 15.10 $config->version = 2015092910; $config->series = '15.10'; $config->release = '15.10.0'; Browser: Firefox 42.0 When embedding an image (doesn't matter what type) in a text box via the TinyMCE "Insert or select an image" icon, once the user has selected the image (from their list of files), upon saving, gets this javascript error: TypeError: newtitle is null http://d.acttqi.mahara/artefact/file/js/filebrowser.js?v=57 Line 695 A check needs to go in for newtitle - to make sure it actually exists. i.e. artefact/file/js/filebrowser.js :: line 694, add following check: if (filetitle && newtitle) { ... } To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1514674/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1513306] A patch has been submitted for review
Patch for "master" branch: https://reviews.mahara.org/5688 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1513306 Title: "Share page" link doesn't work from pages in collections Status in Mahara: Fix Committed Status in Mahara 15.10 series: Fix Committed Status in Mahara 16.04 series: Fix Committed Bug description: To replicate: 1. Create a page 2. Put the page in a collection 3. Edit the page 4. On the edit screen, click the "Share page" link 5. You will be taken to the Edit access screen. 6. Share the page with Public 7. Click "Save" Expected result: You should now be on the "Shared by me" page, and see that the page has been shared with the Public, with the message "Access rules were updated for 1 page(s)" Actual result: On the Edit access screen, the "Collections" and "Pages" selectors will both be empty. When you hit save the message will say "Access rules were updated for 0 page(s)", and there will be no change to the permissions of the collection's page. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1513306/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1513306] A patch has been submitted for review
Patch for "15.10_STABLE" branch: https://reviews.mahara.org/5689 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1513306 Title: "Share page" link doesn't work from pages in collections Status in Mahara: Fix Committed Status in Mahara 15.10 series: Fix Committed Status in Mahara 16.04 series: Fix Committed Bug description: To replicate: 1. Create a page 2. Put the page in a collection 3. Edit the page 4. On the edit screen, click the "Share page" link 5. You will be taken to the Edit access screen. 6. Share the page with Public 7. Click "Save" Expected result: You should now be on the "Shared by me" page, and see that the page has been shared with the Public, with the message "Access rules were updated for 1 page(s)" Actual result: On the Edit access screen, the "Collections" and "Pages" selectors will both be empty. When you hit save the message will say "Access rules were updated for 0 page(s)", and there will be no change to the permissions of the collection's page. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1513306/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1513306] A change has been merged
Reviewed: https://reviews.mahara.org/5689 Committed: https://git.mahara.org/mahara/mahara/commit/68a3c75b8215d70a1f45660dc81dd0afc969482a Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:15.10_STABLE commit 68a3c75b8215d70a1f45660dc81dd0afc969482a Author: Robert Lyon Date: Tue Nov 10 15:59:36 2015 +1300 Bug 1513306: Removing a local tag from behat test Change-Id: Ide8a261a43ebce8abb953fe966c18ecb45e3029e Signed-off-by: Robert Lyon (cherry picked from commit 1d607058651f5dba7e1c6ea5bc18c49003daf973) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1513306 Title: "Share page" link doesn't work from pages in collections Status in Mahara: Fix Committed Status in Mahara 15.10 series: Fix Committed Status in Mahara 16.04 series: Fix Committed Bug description: To replicate: 1. Create a page 2. Put the page in a collection 3. Edit the page 4. On the edit screen, click the "Share page" link 5. You will be taken to the Edit access screen. 6. Share the page with Public 7. Click "Save" Expected result: You should now be on the "Shared by me" page, and see that the page has been shared with the Public, with the message "Access rules were updated for 1 page(s)" Actual result: On the Edit access screen, the "Collections" and "Pages" selectors will both be empty. When you hit save the message will say "Access rules were updated for 0 page(s)", and there will be no change to the permissions of the collection's page. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1513306/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1513306] A change has been merged
Reviewed: https://reviews.mahara.org/5688 Committed: https://git.mahara.org/mahara/mahara/commit/1d607058651f5dba7e1c6ea5bc18c49003daf973 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:master commit 1d607058651f5dba7e1c6ea5bc18c49003daf973 Author: Robert Lyon Date: Tue Nov 10 15:59:36 2015 +1300 Bug 1513306: Removing a local tag from behat test Change-Id: Ide8a261a43ebce8abb953fe966c18ecb45e3029e Signed-off-by: Robert Lyon -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1513306 Title: "Share page" link doesn't work from pages in collections Status in Mahara: Fix Committed Status in Mahara 15.10 series: Fix Committed Status in Mahara 16.04 series: Fix Committed Bug description: To replicate: 1. Create a page 2. Put the page in a collection 3. Edit the page 4. On the edit screen, click the "Share page" link 5. You will be taken to the Edit access screen. 6. Share the page with Public 7. Click "Save" Expected result: You should now be on the "Shared by me" page, and see that the page has been shared with the Public, with the message "Access rules were updated for 1 page(s)" Actual result: On the Edit access screen, the "Collections" and "Pages" selectors will both be empty. When you hit save the message will say "Access rules were updated for 0 page(s)", and there will be no change to the permissions of the collection's page. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1513306/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1514281] A patch has been submitted for review
Patch for "master" branch: https://reviews.mahara.org/5687 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1514281 Title: No .table-responsive added to 'admin/site/menu.php" Status in Mahara: Confirmed Status in Mahara 15.10 series: Confirmed Status in Mahara 16.04 series: Confirmed Bug description: Line #66 from 'admin/site/menu.php": Layout does not work with mobile breakpoints having a table without the .table-responsive added to the class. Maybe should be added to all tables within core. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1514281/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1514661] [NEW] Textbox blocktype raising error when configdata['artefactids'] is not set
Public bug reported: Mahara 15.10 version = 2015092910 release = 15.10.0 DB: postgresql (but shouldn't matter) Upgrading from Mahar 1.10 to 15.10, some textboxes give the following error: [WAR] 3b (artefact/internal/blocktype/textbox/lib.php:313) Undefined index: artefactids Call stack (most recent first): log_message("Undefined index: artefactids", 8, true, true, "/var/www/mahara-site-acttqi-1510/artefact/internal...", 313) at /var/www/mahara-site-acttqi-1510/lib/errors.php:441 error(8, "Undefined index: artefactids", "/var/www/mahara-site-acttqi-1510/artefact/internal...", 313, array(size 18)) at /var/www/mahara-site-acttqi-1510/artefact/internal/blocktype/textbox/lib.php:313 PluginBlocktypeTextbox::instance_config_form(object(BlockInstance), "0") at Unknown:0 call_user_func_array(array(size 2), array(size 2)) at /var/www/mahara-site-acttqi-1510/lib/mahara.php:1693 call_static_method("PluginBlocktypeTextbox", "instance_config_form", object(BlockInstance), "0") at /var/www/mahara-site-acttqi-1510/blocktype/lib.php:1017 BlockInstance->build_configure_form(false) at /var/www/mahara-site-acttqi-1510/blocktype/lib.php:817 BlockInstance->render_editing(true) at /var/www/mahara-site-acttqi-1510/lib/view.php:2445 View->configureblockinstance(array(size 2)) at /var/www/mahara-site-acttqi-1510/lib/view.php:1849 View->process_changes() at /var/www/mahara-site-acttqi-1510/view/blocks.json.php:30 The configdata['artefacids'] is not set. We should check for: && isset($configdata['artefactids']) on line 313 of artefact/internal/blocktype/textbox/lib.php as we do in other blocktypes. ** Affects: mahara Importance: Undecided Status: New -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1514661 Title: Textbox blocktype raising error when configdata['artefactids'] is not set Status in Mahara: New Bug description: Mahara 15.10 version = 2015092910 release = 15.10.0 DB: postgresql (but shouldn't matter) Upgrading from Mahar 1.10 to 15.10, some textboxes give the following error: [WAR] 3b (artefact/internal/blocktype/textbox/lib.php:313) Undefined index: artefactids Call stack (most recent first): log_message("Undefined index: artefactids", 8, true, true, "/var/www/mahara-site-acttqi-1510/artefact/internal...", 313) at /var/www/mahara-site-acttqi-1510/lib/errors.php:441 error(8, "Undefined index: artefactids", "/var/www/mahara-site-acttqi-1510/artefact/internal...", 313, array(size 18)) at /var/www/mahara-site-acttqi-1510/artefact/internal/blocktype/textbox/lib.php:313 PluginBlocktypeTextbox::instance_config_form(object(BlockInstance), "0") at Unknown:0 call_user_func_array(array(size 2), array(size 2)) at /var/www/mahara-site-acttqi-1510/lib/mahara.php:1693 call_static_method("PluginBlocktypeTextbox", "instance_config_form", object(BlockInstance), "0") at /var/www/mahara-site-acttqi-1510/blocktype/lib.php:1017 BlockInstance->build_configure_form(false) at /var/www/mahara-site-acttqi-1510/blocktype/lib.php:817 BlockInstance->render_editing(true) at /var/www/mahara-site-acttqi-1510/lib/view.php:2445 View->configureblockinstance(array(size 2)) at /var/www/mahara-site-acttqi-1510/lib/view.php:1849 View->process_changes() at /var/www/mahara-site-acttqi-1510/view/blocks.json.php:30 The configdata['artefacids'] is not set. We should check for: && isset($configdata['artefactids']) on line 313 of artefact/internal/blocktype/textbox/lib.php as we do in other blocktypes. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1514661/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1514641] Re: Blocktype rendering error when artefact is not found
Okay, since it's just a warning I'll mark this bug "Low" priority. Cheers, Aaron ** Changed in: mahara/15.10 Importance: Undecided => Low ** Changed in: mahara/16.04 Importance: Undecided => Low -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1514641 Title: Blocktype rendering error when artefact is not found Status in Mahara: Triaged Status in Mahara 15.10 series: Triaged Status in Mahara 16.04 series: Triaged Bug description: Mahara 15.10: version = 2015092910 release = 15.10.0 If an artefact is not found while rending a block instance, the try/catch catches the error - which is good. But, further down the page when it sets pieformcss => $css (on line 916): return array('html' => $smarty->fetch('view/blocktypecontainerediting.tpl'), 'javascript' => $js, 'pieformcss' => $css); the variable $css has not been declared - giving this error: [Tue Nov 10 11:47:20 2015] [error] [client 192.168.124.138] [WAR] 63 (blocktype/lib.php:913) Undefined variable: css, referer: http://d.acttqi.mahara/view/blocks.php?id=2149&; [Tue Nov 10 11:47:20 2015] [error] [client 192.168.124.138] Call stack (most recent first):, referer: http://d.acttqi.mahara/view/blocks.php?id=2149&; [Tue Nov 10 11:47:20 2015] [error] [client 192.168.124.138] * log_message("Undefined variable: css", 8, true, true, "/var/www/acttqi/mahara/htdocs/blocktype/lib.php", 913) at /var/www/acttqi/mahara/htdocs/lib/errors.php:441, referer: http://d.acttqi.mahara/view/blocks.php?id=2149&; [Tue Nov 10 11:47:20 2015] [error] [client 192.168.124.138] * error(8, "Undefined variable: css", "/var/www/acttqi/mahara/htdocs/blocktype/lib.php", 913, array(size 14)) at /var/www/acttqi/mahara/htdocs/blocktype/lib.php:913, referer: http://d.acttqi.mahara/view/blocks.php?id=2149&; [Tue Nov 10 11:47:20 2015] [error] [client 192.168.124.138] * BlockInstance->render_editing() at /var/www/acttqi/mahara/htdocs/lib/view.php:2082, referer: http://d.acttqi.mahara/view/blocks.php?id=2149&; [Tue Nov 10 11:47:20 2015] [error] [client 192.168.124.138] * View->build_column(1, 3, true, false) at /var/www/acttqi/mahara/htdocs/lib/view.php:2043, referer: http://d.acttqi.mahara/view/blocks.php?id=2149&; [Tue Nov 10 11:47:20 2015] [error] [client 192.168.124.138] * View->build_columns(1, true, false) at /var/www/acttqi/mahara/htdocs/lib/view.php:2028, referer: http://d.acttqi.mahara/view/blocks.php?id=2149&; [Tue Nov 10 11:47:20 2015] [error] [client 192.168.124.138] * View->build_rows(true) at /var/www/acttqi/mahara/htdocs/view/blocks.php:191, referer: http://d.acttqi.mahara/view/blocks.php?id=2149&; [Tue Nov 10 11:47:20 2015] [error] [client 192.168.124.138] , referer: http://d.acttqi.mahara/view/blocks.php?id=2149&; So, before calling the static methods (on lines 822+), we should instantiate the $css variable first. So when it does fail, $css has already been defined. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1514641/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1490569] Re: Sort submitted pages "Most recently submitted" doesn't work
** Changed in: mahara/15.10 Status: Confirmed => Fix Committed ** Changed in: mahara/16.04 Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1490569 Title: Sort submitted pages "Most recently submitted" doesn't work Status in Mahara: Fix Committed Status in Mahara 15.04 series: Fix Released Status in Mahara 15.10 series: Fix Committed Status in Mahara 16.04 series: Fix Committed Bug description: Hello, When adding a 'pages shared' block to a group, one of the settings is "Sort submitted pages and collections" by "Most recently updated". While trying to use this with a group (v15.04) I've found that the displayed sort order of the shared pages doesn't change from the default 'alphabetically'. Worth noting it would also be worth having the option to display pages in the order 'most recently shared' - subtly different from when they were updated but a useful feature if it could be added. Regards, Gordon. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1490569/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1514641] Re: Blocktype rendering error when artefact is not found
Hi Aaron, It's a warning in the log files (in 1.10). But, because we've got debugging on while upgrading (15.10), we just noticed it now. You can still edit the page. Ghada -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1514641 Title: Blocktype rendering error when artefact is not found Status in Mahara: Triaged Status in Mahara 15.10 series: Triaged Status in Mahara 16.04 series: Triaged Bug description: Mahara 15.10: version = 2015092910 release = 15.10.0 If an artefact is not found while rending a block instance, the try/catch catches the error - which is good. But, further down the page when it sets pieformcss => $css (on line 916): return array('html' => $smarty->fetch('view/blocktypecontainerediting.tpl'), 'javascript' => $js, 'pieformcss' => $css); the variable $css has not been declared - giving this error: [Tue Nov 10 11:47:20 2015] [error] [client 192.168.124.138] [WAR] 63 (blocktype/lib.php:913) Undefined variable: css, referer: http://d.acttqi.mahara/view/blocks.php?id=2149&; [Tue Nov 10 11:47:20 2015] [error] [client 192.168.124.138] Call stack (most recent first):, referer: http://d.acttqi.mahara/view/blocks.php?id=2149&; [Tue Nov 10 11:47:20 2015] [error] [client 192.168.124.138] * log_message("Undefined variable: css", 8, true, true, "/var/www/acttqi/mahara/htdocs/blocktype/lib.php", 913) at /var/www/acttqi/mahara/htdocs/lib/errors.php:441, referer: http://d.acttqi.mahara/view/blocks.php?id=2149&; [Tue Nov 10 11:47:20 2015] [error] [client 192.168.124.138] * error(8, "Undefined variable: css", "/var/www/acttqi/mahara/htdocs/blocktype/lib.php", 913, array(size 14)) at /var/www/acttqi/mahara/htdocs/blocktype/lib.php:913, referer: http://d.acttqi.mahara/view/blocks.php?id=2149&; [Tue Nov 10 11:47:20 2015] [error] [client 192.168.124.138] * BlockInstance->render_editing() at /var/www/acttqi/mahara/htdocs/lib/view.php:2082, referer: http://d.acttqi.mahara/view/blocks.php?id=2149&; [Tue Nov 10 11:47:20 2015] [error] [client 192.168.124.138] * View->build_column(1, 3, true, false) at /var/www/acttqi/mahara/htdocs/lib/view.php:2043, referer: http://d.acttqi.mahara/view/blocks.php?id=2149&; [Tue Nov 10 11:47:20 2015] [error] [client 192.168.124.138] * View->build_columns(1, true, false) at /var/www/acttqi/mahara/htdocs/lib/view.php:2028, referer: http://d.acttqi.mahara/view/blocks.php?id=2149&; [Tue Nov 10 11:47:20 2015] [error] [client 192.168.124.138] * View->build_rows(true) at /var/www/acttqi/mahara/htdocs/view/blocks.php:191, referer: http://d.acttqi.mahara/view/blocks.php?id=2149&; [Tue Nov 10 11:47:20 2015] [error] [client 192.168.124.138] , referer: http://d.acttqi.mahara/view/blocks.php?id=2149&; So, before calling the static methods (on lines 822+), we should instantiate the $css variable first. So when it does fail, $css has already been defined. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1514641/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1511536] Re: Deleting blocks from page fails in some cases in 15.10
** Changed in: mahara Status: In Progress => Fix Committed ** Changed in: mahara/15.10 Status: Confirmed => In Progress -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1511536 Title: Deleting blocks from page fails in some cases in 15.10 Status in Mahara: Fix Committed Status in Mahara 15.10 series: In Progress Bug description: The is an odd bug where the block being deleted doesn't remove itself from the edit screen. so when you try to delete it again you get an error message that the block doesn't exist any more. To replicate: Make a page and add some blocks to the page - preferably 3 or more (any type) Go to display page Go back to edit page and delete the blocks - the first will delete fine but then next ones will not disappear However if each block is edited and then deleted they are removed fine. So this sounds like there is a problem with initial setup of the js relating to the delete buttons but not when the buttons are rewritten after config changes To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1511536/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1511536] A patch has been submitted for review
Patch for "15.10_STABLE" branch: https://reviews.mahara.org/5686 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1511536 Title: Deleting blocks from page fails in some cases in 15.10 Status in Mahara: Fix Committed Status in Mahara 15.10 series: In Progress Bug description: The is an odd bug where the block being deleted doesn't remove itself from the edit screen. so when you try to delete it again you get an error message that the block doesn't exist any more. To replicate: Make a page and add some blocks to the page - preferably 3 or more (any type) Go to display page Go back to edit page and delete the blocks - the first will delete fine but then next ones will not disappear However if each block is edited and then deleted they are removed fine. So this sounds like there is a problem with initial setup of the js relating to the delete buttons but not when the buttons are rewritten after config changes To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1511536/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1511536] A change has been merged
Reviewed: https://reviews.mahara.org/5646 Committed: https://git.mahara.org/mahara/mahara/commit/52770f8baf2297d9cbf5506e2696b346fae8f419 Submitter: Aaron Wells (aar...@catalyst.net.nz) Branch:master commit 52770f8baf2297d9cbf5506e2696b346fae8f419 Author: Robert Lyon Date: Fri Oct 30 12:26:48 2015 +1300 Bug 1511536: problem with deleting blocks when edit page first loads The problem is due to the scope of the blockinstanceId variable being outside of the click handler function, which inadvertently makes it into a sort of static variable shared by all of the delete buttons. So the solution is to use a locally-scoped blockinstanceId button inside the click handler method. Change-Id: I3e8ffac31cc869c545e85c5f53c3e710e2e71243 Signed-off-by: Robert Lyon Signed-off-by: Aaron Wells -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1511536 Title: Deleting blocks from page fails in some cases in 15.10 Status in Mahara: Fix Committed Status in Mahara 15.10 series: In Progress Bug description: The is an odd bug where the block being deleted doesn't remove itself from the edit screen. so when you try to delete it again you get an error message that the block doesn't exist any more. To replicate: Make a page and add some blocks to the page - preferably 3 or more (any type) Go to display page Go back to edit page and delete the blocks - the first will delete fine but then next ones will not disappear However if each block is edited and then deleted they are removed fine. So this sounds like there is a problem with initial setup of the js relating to the delete buttons but not when the buttons are rewritten after config changes To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1511536/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1514641] Re: Blocktype rendering error when artefact is not found
Hm, that could be it. I think when you copy a page, in some cases it continues to point to the original artefacts instead of giving you a copy. (Specifically, some of the blog blocks can do this.) If that's the case, then perhaps there's a bug in the institution page delete code that fails to clean up those links. So, probably best to fix it on both sides. Correct the code that is failing to delete the link, and change the BlockInstance rendering methods to be more robust against missing artefacts. By the way, is that an actual error that crashes the page and makes it impossible to edit the block? Or is it just a warning message in the logs? Cheers, Aaron -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1514641 Title: Blocktype rendering error when artefact is not found Status in Mahara: Triaged Status in Mahara 15.10 series: Triaged Status in Mahara 16.04 series: Triaged Bug description: Mahara 15.10: version = 2015092910 release = 15.10.0 If an artefact is not found while rending a block instance, the try/catch catches the error - which is good. But, further down the page when it sets pieformcss => $css (on line 916): return array('html' => $smarty->fetch('view/blocktypecontainerediting.tpl'), 'javascript' => $js, 'pieformcss' => $css); the variable $css has not been declared - giving this error: [Tue Nov 10 11:47:20 2015] [error] [client 192.168.124.138] [WAR] 63 (blocktype/lib.php:913) Undefined variable: css, referer: http://d.acttqi.mahara/view/blocks.php?id=2149&; [Tue Nov 10 11:47:20 2015] [error] [client 192.168.124.138] Call stack (most recent first):, referer: http://d.acttqi.mahara/view/blocks.php?id=2149&; [Tue Nov 10 11:47:20 2015] [error] [client 192.168.124.138] * log_message("Undefined variable: css", 8, true, true, "/var/www/acttqi/mahara/htdocs/blocktype/lib.php", 913) at /var/www/acttqi/mahara/htdocs/lib/errors.php:441, referer: http://d.acttqi.mahara/view/blocks.php?id=2149&; [Tue Nov 10 11:47:20 2015] [error] [client 192.168.124.138] * error(8, "Undefined variable: css", "/var/www/acttqi/mahara/htdocs/blocktype/lib.php", 913, array(size 14)) at /var/www/acttqi/mahara/htdocs/blocktype/lib.php:913, referer: http://d.acttqi.mahara/view/blocks.php?id=2149&; [Tue Nov 10 11:47:20 2015] [error] [client 192.168.124.138] * BlockInstance->render_editing() at /var/www/acttqi/mahara/htdocs/lib/view.php:2082, referer: http://d.acttqi.mahara/view/blocks.php?id=2149&; [Tue Nov 10 11:47:20 2015] [error] [client 192.168.124.138] * View->build_column(1, 3, true, false) at /var/www/acttqi/mahara/htdocs/lib/view.php:2043, referer: http://d.acttqi.mahara/view/blocks.php?id=2149&; [Tue Nov 10 11:47:20 2015] [error] [client 192.168.124.138] * View->build_columns(1, true, false) at /var/www/acttqi/mahara/htdocs/lib/view.php:2028, referer: http://d.acttqi.mahara/view/blocks.php?id=2149&; [Tue Nov 10 11:47:20 2015] [error] [client 192.168.124.138] * View->build_rows(true) at /var/www/acttqi/mahara/htdocs/view/blocks.php:191, referer: http://d.acttqi.mahara/view/blocks.php?id=2149&; [Tue Nov 10 11:47:20 2015] [error] [client 192.168.124.138] , referer: http://d.acttqi.mahara/view/blocks.php?id=2149&; So, before calling the static methods (on lines 822+), we should instantiate the $css variable first. So when it does fail, $css has already been defined. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1514641/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1514281] Re: No .table-responsive added to 'admin/site/menu.php"
** Changed in: mahara/15.10 Assignee: (unassigned) => Pat (pat-kira) ** Changed in: mahara/16.04 Assignee: (unassigned) => Pat (pat-kira) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1514281 Title: No .table-responsive added to 'admin/site/menu.php" Status in Mahara: Confirmed Status in Mahara 15.10 series: Confirmed Status in Mahara 16.04 series: Confirmed Bug description: Line #66 from 'admin/site/menu.php": Layout does not work with mobile breakpoints having a table without the .table-responsive added to the class. Maybe should be added to all tables within core. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1514281/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1513306] Re: "Share page" link doesn't work from pages in collections
** Changed in: mahara/15.10 Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1513306 Title: "Share page" link doesn't work from pages in collections Status in Mahara: Fix Committed Status in Mahara 15.10 series: Fix Committed Status in Mahara 16.04 series: Fix Committed Bug description: To replicate: 1. Create a page 2. Put the page in a collection 3. Edit the page 4. On the edit screen, click the "Share page" link 5. You will be taken to the Edit access screen. 6. Share the page with Public 7. Click "Save" Expected result: You should now be on the "Shared by me" page, and see that the page has been shared with the Public, with the message "Access rules were updated for 1 page(s)" Actual result: On the Edit access screen, the "Collections" and "Pages" selectors will both be empty. When you hit save the message will say "Access rules were updated for 0 page(s)", and there will be no change to the permissions of the collection's page. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1513306/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1513306] A change has been merged
Reviewed: https://reviews.mahara.org/5680 Committed: https://git.mahara.org/mahara/mahara/commit/2d683027e34336fe97b36a40299ea9e77e3f8c17 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:15.10_STABLE commit 2d683027e34336fe97b36a40299ea9e77e3f8c17 Author: Robert Lyon Date: Mon Nov 9 10:41:32 2015 +1300 Bug 1513306: Add collection id to 'Share page' link So it can be passed to 'edit access' page from the 'edit page' page on the 'Share page' link Change-Id: I1968d205b12840cd3dcfbd80a6ffdd26a498361d Signed-off-by: Robert Lyon -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1513306 Title: "Share page" link doesn't work from pages in collections Status in Mahara: Fix Committed Status in Mahara 15.10 series: Fix Committed Status in Mahara 16.04 series: Fix Committed Bug description: To replicate: 1. Create a page 2. Put the page in a collection 3. Edit the page 4. On the edit screen, click the "Share page" link 5. You will be taken to the Edit access screen. 6. Share the page with Public 7. Click "Save" Expected result: You should now be on the "Shared by me" page, and see that the page has been shared with the Public, with the message "Access rules were updated for 1 page(s)" Actual result: On the Edit access screen, the "Collections" and "Pages" selectors will both be empty. When you hit save the message will say "Access rules were updated for 0 page(s)", and there will be no change to the permissions of the collection's page. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1513306/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1514647] A patch has been submitted for review
Patch for "master" branch: https://reviews.mahara.org/5685 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1514647 Title: Country dropdown list needs updating Status in Mahara: In Progress Bug description: According to the official list of recognised countries there has been some changes since this list was last updated. So I've made a patch to keep things up to date To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1514647/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1514647] [NEW] Country dropdown list needs updating
Public bug reported: According to the official list of recognised countries there has been some changes since this list was last updated. So I've made a patch to keep things up to date ** Affects: mahara Importance: Low Assignee: Robert Lyon (robertl-9) Status: In Progress -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1514647 Title: Country dropdown list needs updating Status in Mahara: In Progress Bug description: According to the official list of recognised countries there has been some changes since this list was last updated. So I've made a patch to keep things up to date To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1514647/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1514641] Re: Blocktype rendering error when artefact is not found
Hi Aaron, We're upgrading a Mahara site from 1.10 to 15.10. In 1.10, we are getting this: Nov 10 12:25:28 TQIDEB001 mahara-site-acttqi: [Tue Nov 10 12:25:28 2015] [error] [client 203.29.131.142] [DBG] 43 (blocktype/lib.php:692) Artefact not found when rendering a block instance. There might be a bug with deleting artefacts of this type? Original error follows:, referer: https://uatmahara.tqi.act.edu.au/view/index.php Nov 10 12:25:28 TQIDEB001 mahara-site-acttqi: [Tue Nov 10 12:25:28 2015] [error] [client 203.29.131.142] [DBG] 43 (blocktype/lib.php:693) Collection with id 1211 not found, referer: https://uatmahara.tqi.act.edu.au/view/index.php The page was originally copied from institution pages/collection. The institution pages and collection were then deleted. I think that's probably when it started to happen but I'm not 100% sure. I hope this helps. Thanks, Ghada -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1514641 Title: Blocktype rendering error when artefact is not found Status in Mahara: Triaged Status in Mahara 15.10 series: Triaged Status in Mahara 16.04 series: Triaged Bug description: Mahara 15.10: version = 2015092910 release = 15.10.0 If an artefact is not found while rending a block instance, the try/catch catches the error - which is good. But, further down the page when it sets pieformcss => $css (on line 916): return array('html' => $smarty->fetch('view/blocktypecontainerediting.tpl'), 'javascript' => $js, 'pieformcss' => $css); the variable $css has not been declared - giving this error: [Tue Nov 10 11:47:20 2015] [error] [client 192.168.124.138] [WAR] 63 (blocktype/lib.php:913) Undefined variable: css, referer: http://d.acttqi.mahara/view/blocks.php?id=2149&; [Tue Nov 10 11:47:20 2015] [error] [client 192.168.124.138] Call stack (most recent first):, referer: http://d.acttqi.mahara/view/blocks.php?id=2149&; [Tue Nov 10 11:47:20 2015] [error] [client 192.168.124.138] * log_message("Undefined variable: css", 8, true, true, "/var/www/acttqi/mahara/htdocs/blocktype/lib.php", 913) at /var/www/acttqi/mahara/htdocs/lib/errors.php:441, referer: http://d.acttqi.mahara/view/blocks.php?id=2149&; [Tue Nov 10 11:47:20 2015] [error] [client 192.168.124.138] * error(8, "Undefined variable: css", "/var/www/acttqi/mahara/htdocs/blocktype/lib.php", 913, array(size 14)) at /var/www/acttqi/mahara/htdocs/blocktype/lib.php:913, referer: http://d.acttqi.mahara/view/blocks.php?id=2149&; [Tue Nov 10 11:47:20 2015] [error] [client 192.168.124.138] * BlockInstance->render_editing() at /var/www/acttqi/mahara/htdocs/lib/view.php:2082, referer: http://d.acttqi.mahara/view/blocks.php?id=2149&; [Tue Nov 10 11:47:20 2015] [error] [client 192.168.124.138] * View->build_column(1, 3, true, false) at /var/www/acttqi/mahara/htdocs/lib/view.php:2043, referer: http://d.acttqi.mahara/view/blocks.php?id=2149&; [Tue Nov 10 11:47:20 2015] [error] [client 192.168.124.138] * View->build_columns(1, true, false) at /var/www/acttqi/mahara/htdocs/lib/view.php:2028, referer: http://d.acttqi.mahara/view/blocks.php?id=2149&; [Tue Nov 10 11:47:20 2015] [error] [client 192.168.124.138] * View->build_rows(true) at /var/www/acttqi/mahara/htdocs/view/blocks.php:191, referer: http://d.acttqi.mahara/view/blocks.php?id=2149&; [Tue Nov 10 11:47:20 2015] [error] [client 192.168.124.138] , referer: http://d.acttqi.mahara/view/blocks.php?id=2149&; So, before calling the static methods (on lines 822+), we should instantiate the $css variable first. So when it does fail, $css has already been defined. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1514641/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1514641] Re: Blocktype rendering error when artefact is not found
Hi Ghada, Do you have any instructions on how to replicate this error? I tried putting an image in an image block and then deleting the image, but it seems like that particular use case successfully unsets the block instance so this error doesn't happen. Cheers, Aaron ** Also affects: mahara/16.04 Importance: Undecided Status: New ** Also affects: mahara/15.10 Importance: Undecided Status: New ** Changed in: mahara/15.10 Status: New => Triaged ** Changed in: mahara/16.04 Status: New => Triaged ** Changed in: mahara/15.10 Milestone: None => 15.10.1 ** Changed in: mahara/16.04 Milestone: None => 16.04.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1514641 Title: Blocktype rendering error when artefact is not found Status in Mahara: Triaged Status in Mahara 15.10 series: Triaged Status in Mahara 16.04 series: Triaged Bug description: Mahara 15.10: version = 2015092910 release = 15.10.0 If an artefact is not found while rending a block instance, the try/catch catches the error - which is good. But, further down the page when it sets pieformcss => $css (on line 916): return array('html' => $smarty->fetch('view/blocktypecontainerediting.tpl'), 'javascript' => $js, 'pieformcss' => $css); the variable $css has not been declared - giving this error: [Tue Nov 10 11:47:20 2015] [error] [client 192.168.124.138] [WAR] 63 (blocktype/lib.php:913) Undefined variable: css, referer: http://d.acttqi.mahara/view/blocks.php?id=2149&; [Tue Nov 10 11:47:20 2015] [error] [client 192.168.124.138] Call stack (most recent first):, referer: http://d.acttqi.mahara/view/blocks.php?id=2149&; [Tue Nov 10 11:47:20 2015] [error] [client 192.168.124.138] * log_message("Undefined variable: css", 8, true, true, "/var/www/acttqi/mahara/htdocs/blocktype/lib.php", 913) at /var/www/acttqi/mahara/htdocs/lib/errors.php:441, referer: http://d.acttqi.mahara/view/blocks.php?id=2149&; [Tue Nov 10 11:47:20 2015] [error] [client 192.168.124.138] * error(8, "Undefined variable: css", "/var/www/acttqi/mahara/htdocs/blocktype/lib.php", 913, array(size 14)) at /var/www/acttqi/mahara/htdocs/blocktype/lib.php:913, referer: http://d.acttqi.mahara/view/blocks.php?id=2149&; [Tue Nov 10 11:47:20 2015] [error] [client 192.168.124.138] * BlockInstance->render_editing() at /var/www/acttqi/mahara/htdocs/lib/view.php:2082, referer: http://d.acttqi.mahara/view/blocks.php?id=2149&; [Tue Nov 10 11:47:20 2015] [error] [client 192.168.124.138] * View->build_column(1, 3, true, false) at /var/www/acttqi/mahara/htdocs/lib/view.php:2043, referer: http://d.acttqi.mahara/view/blocks.php?id=2149&; [Tue Nov 10 11:47:20 2015] [error] [client 192.168.124.138] * View->build_columns(1, true, false) at /var/www/acttqi/mahara/htdocs/lib/view.php:2028, referer: http://d.acttqi.mahara/view/blocks.php?id=2149&; [Tue Nov 10 11:47:20 2015] [error] [client 192.168.124.138] * View->build_rows(true) at /var/www/acttqi/mahara/htdocs/view/blocks.php:191, referer: http://d.acttqi.mahara/view/blocks.php?id=2149&; [Tue Nov 10 11:47:20 2015] [error] [client 192.168.124.138] , referer: http://d.acttqi.mahara/view/blocks.php?id=2149&; So, before calling the static methods (on lines 822+), we should instantiate the $css variable first. So when it does fail, $css has already been defined. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1514641/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1512897] A change has been merged
Reviewed: https://reviews.mahara.org/5674 Committed: https://git.mahara.org/mahara/mahara/commit/26deb57d76089ed6bdbb2863253b15c871b83f83 Submitter: Aaron Wells (aar...@catalyst.net.nz) Branch:master commit 26deb57d76089ed6bdbb2863253b15c871b83f83 Author: Robert Lyon Date: Mon Nov 9 11:26:13 2015 +1300 Bug 1512897: Allowing introtext blocktype to record embedded image data behatnotneeded: it deals with whether an image shows or not Change-Id: I3625f9d9948fd3c67f60657fbd3bc67644ae76e7 Signed-off-by: Robert Lyon -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1512897 Title: Embedded image in "Profile information" block's per-block introduction field, doesn't show after page is shared Status in Mahara: Fix Committed Status in Mahara 15.04 series: In Progress Status in Mahara 15.10 series: In Progress Status in Mahara 16.04 series: Fix Committed Bug description: This bug deals with a relatively obscure feature, which is the "Introduction" field of the "Profile information" block type. This is an optional wysiwyg text field that you can use to add an intro to the profile info displayed by the block. If filled in, it will be displayed instead of the "Introduction" artefact which is part of your Profile information artefacts. It's a bit confusing because they are both called "Introduction". This bug deals with the block config "introduction", *not* the artefact "introduction". To replicate: 1. Put a "Profile information" block in a page 2. In the block config, there's an "Introduction" text field. Embed an image there using the TinyMCE image plugin 3. Save the block config 4. Share the page with the Public 5. Log out 6. View the page Expected result: You should see the embedded image in the block Actual result: You see the alt text with the name of the image file I suspect the problem here is that this field is populating neither the view_artefact or nor the artefact_file_embedded tables. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1512897/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1512897] Re: Embedded image in "Profile information" block's per-block introduction field, doesn't show after page is shared
** Changed in: mahara/16.04 Status: In Progress => Fix Committed ** Changed in: mahara/15.10 Status: Confirmed => In Progress ** Changed in: mahara/15.04 Status: Confirmed => In Progress -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1512897 Title: Embedded image in "Profile information" block's per-block introduction field, doesn't show after page is shared Status in Mahara: Fix Committed Status in Mahara 15.04 series: In Progress Status in Mahara 15.10 series: In Progress Status in Mahara 16.04 series: Fix Committed Bug description: This bug deals with a relatively obscure feature, which is the "Introduction" field of the "Profile information" block type. This is an optional wysiwyg text field that you can use to add an intro to the profile info displayed by the block. If filled in, it will be displayed instead of the "Introduction" artefact which is part of your Profile information artefacts. It's a bit confusing because they are both called "Introduction". This bug deals with the block config "introduction", *not* the artefact "introduction". To replicate: 1. Put a "Profile information" block in a page 2. In the block config, there's an "Introduction" text field. Embed an image there using the TinyMCE image plugin 3. Save the block config 4. Share the page with the Public 5. Log out 6. View the page Expected result: You should see the embedded image in the block Actual result: You see the alt text with the name of the image file I suspect the problem here is that this field is populating neither the view_artefact or nor the artefact_file_embedded tables. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1512897/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1512897] A patch has been submitted for review
Patch for "15.10_STABLE" branch: https://reviews.mahara.org/5684 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1512897 Title: Embedded image in "Profile information" block's per-block introduction field, doesn't show after page is shared Status in Mahara: Fix Committed Status in Mahara 15.04 series: In Progress Status in Mahara 15.10 series: In Progress Status in Mahara 16.04 series: Fix Committed Bug description: This bug deals with a relatively obscure feature, which is the "Introduction" field of the "Profile information" block type. This is an optional wysiwyg text field that you can use to add an intro to the profile info displayed by the block. If filled in, it will be displayed instead of the "Introduction" artefact which is part of your Profile information artefacts. It's a bit confusing because they are both called "Introduction". This bug deals with the block config "introduction", *not* the artefact "introduction". To replicate: 1. Put a "Profile information" block in a page 2. In the block config, there's an "Introduction" text field. Embed an image there using the TinyMCE image plugin 3. Save the block config 4. Share the page with the Public 5. Log out 6. View the page Expected result: You should see the embedded image in the block Actual result: You see the alt text with the name of the image file I suspect the problem here is that this field is populating neither the view_artefact or nor the artefact_file_embedded tables. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1512897/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1512897] A patch has been submitted for review
Patch for "15.04_STABLE" branch: https://reviews.mahara.org/5683 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1512897 Title: Embedded image in "Profile information" block's per-block introduction field, doesn't show after page is shared Status in Mahara: Fix Committed Status in Mahara 15.04 series: In Progress Status in Mahara 15.10 series: In Progress Status in Mahara 16.04 series: Fix Committed Bug description: This bug deals with a relatively obscure feature, which is the "Introduction" field of the "Profile information" block type. This is an optional wysiwyg text field that you can use to add an intro to the profile info displayed by the block. If filled in, it will be displayed instead of the "Introduction" artefact which is part of your Profile information artefacts. It's a bit confusing because they are both called "Introduction". This bug deals with the block config "introduction", *not* the artefact "introduction". To replicate: 1. Put a "Profile information" block in a page 2. In the block config, there's an "Introduction" text field. Embed an image there using the TinyMCE image plugin 3. Save the block config 4. Share the page with the Public 5. Log out 6. View the page Expected result: You should see the embedded image in the block Actual result: You see the alt text with the name of the image file I suspect the problem here is that this field is populating neither the view_artefact or nor the artefact_file_embedded tables. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1512897/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1514641] [NEW] Blocktype rendering error when artefact is not found
Public bug reported: Mahara 15.10: version = 2015092910 release = 15.10.0 If an artefact is not found while rending a block instance, the try/catch catches the error - which is good. But, further down the page when it sets pieformcss => $css (on line 916): return array('html' => $smarty->fetch('view/blocktypecontainerediting.tpl'), 'javascript' => $js, 'pieformcss' => $css); the variable $css has not been declared - giving this error: [Tue Nov 10 11:47:20 2015] [error] [client 192.168.124.138] [WAR] 63 (blocktype/lib.php:913) Undefined variable: css, referer: http://d.acttqi.mahara/view/blocks.php?id=2149&; [Tue Nov 10 11:47:20 2015] [error] [client 192.168.124.138] Call stack (most recent first):, referer: http://d.acttqi.mahara/view/blocks.php?id=2149&; [Tue Nov 10 11:47:20 2015] [error] [client 192.168.124.138] * log_message("Undefined variable: css", 8, true, true, "/var/www/acttqi/mahara/htdocs/blocktype/lib.php", 913) at /var/www/acttqi/mahara/htdocs/lib/errors.php:441, referer: http://d.acttqi.mahara/view/blocks.php?id=2149&; [Tue Nov 10 11:47:20 2015] [error] [client 192.168.124.138] * error(8, "Undefined variable: css", "/var/www/acttqi/mahara/htdocs/blocktype/lib.php", 913, array(size 14)) at /var/www/acttqi/mahara/htdocs/blocktype/lib.php:913, referer: http://d.acttqi.mahara/view/blocks.php?id=2149&; [Tue Nov 10 11:47:20 2015] [error] [client 192.168.124.138] * BlockInstance->render_editing() at /var/www/acttqi/mahara/htdocs/lib/view.php:2082, referer: http://d.acttqi.mahara/view/blocks.php?id=2149&; [Tue Nov 10 11:47:20 2015] [error] [client 192.168.124.138] * View->build_column(1, 3, true, false) at /var/www/acttqi/mahara/htdocs/lib/view.php:2043, referer: http://d.acttqi.mahara/view/blocks.php?id=2149&; [Tue Nov 10 11:47:20 2015] [error] [client 192.168.124.138] * View->build_columns(1, true, false) at /var/www/acttqi/mahara/htdocs/lib/view.php:2028, referer: http://d.acttqi.mahara/view/blocks.php?id=2149&; [Tue Nov 10 11:47:20 2015] [error] [client 192.168.124.138] * View->build_rows(true) at /var/www/acttqi/mahara/htdocs/view/blocks.php:191, referer: http://d.acttqi.mahara/view/blocks.php?id=2149&; [Tue Nov 10 11:47:20 2015] [error] [client 192.168.124.138] , referer: http://d.acttqi.mahara/view/blocks.php?id=2149&; So, before calling the static methods (on lines 822+), we should instantiate the $css variable first. So when it does fail, $css has already been defined. ** Affects: mahara Importance: Undecided Status: New -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1514641 Title: Blocktype rendering error when artefact is not found Status in Mahara: New Bug description: Mahara 15.10: version = 2015092910 release = 15.10.0 If an artefact is not found while rending a block instance, the try/catch catches the error - which is good. But, further down the page when it sets pieformcss => $css (on line 916): return array('html' => $smarty->fetch('view/blocktypecontainerediting.tpl'), 'javascript' => $js, 'pieformcss' => $css); the variable $css has not been declared - giving this error: [Tue Nov 10 11:47:20 2015] [error] [client 192.168.124.138] [WAR] 63 (blocktype/lib.php:913) Undefined variable: css, referer: http://d.acttqi.mahara/view/blocks.php?id=2149&; [Tue Nov 10 11:47:20 2015] [error] [client 192.168.124.138] Call stack (most recent first):, referer: http://d.acttqi.mahara/view/blocks.php?id=2149&; [Tue Nov 10 11:47:20 2015] [error] [client 192.168.124.138] * log_message("Undefined variable: css", 8, true, true, "/var/www/acttqi/mahara/htdocs/blocktype/lib.php", 913) at /var/www/acttqi/mahara/htdocs/lib/errors.php:441, referer: http://d.acttqi.mahara/view/blocks.php?id=2149&; [Tue Nov 10 11:47:20 2015] [error] [client 192.168.124.138] * error(8, "Undefined variable: css", "/var/www/acttqi/mahara/htdocs/blocktype/lib.php", 913, array(size 14)) at /var/www/acttqi/mahara/htdocs/blocktype/lib.php:913, referer: http://d.acttqi.mahara/view/blocks.php?id=2149&; [Tue Nov 10 11:47:20 2015] [error] [client 192.168.124.138] * BlockInstance->render_editing() at /var/www/acttqi/mahara/htdocs/lib/view.php:2082, referer: http://d.acttqi.mahara/view/blocks.php?id=2149&; [Tue Nov 10 11:47:20 2015] [error] [client 192.168.124.138] * View->build_column(1, 3, true, false) at /var/www/acttqi/mahara/htdocs/lib/view.php:2043, referer: http://d.acttqi.mahara/view/blocks.php?id=2149&; [Tue Nov 10 11:47:20 2015] [error] [client 192.168.124.138] * View->build_columns(1, true, false) at /var/www/acttqi/mahara/htdocs/lib/view.php:2028, referer: http://d.acttqi.mahara/view/blocks.php?id=2149&; [Tue Nov 10 1
[Mahara-contributors] [Bug 1507865] A patch has been submitted for review
Patch for "master" branch: https://reviews.mahara.org/5682 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1507865 Title: Webservice create_users() has old social profile fields Status in Mahara: In Progress Bug description: The following fields are still implemented in the Webservice create_users: - aimscreenname - icqnumber - msnnumber - yahoochat - skypusername - jabberusername Which were all replaced by the new blocktype 'social profile' in the internal artefact. If someone were to create a user and specify one of these fields, the set_profile_field() will raise an error when generating the class name (generate_artefact_class_name()) for the field. I haven't actually tried to use the webservice but can see that it will cause an error. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1507865/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1514374] Re: "Groups -> Members" page shows only first 10 group members
While we're at it, we should probably check the other paginators to make sure none of them are broken, as well. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1514374 Title: "Groups -> Members" page shows only first 10 group members Status in Mahara: Confirmed Status in Mahara 15.10 series: Confirmed Status in Mahara 16.04 series: Confirmed Bug description: Mahara 15.10.0 linux mysql several browsers 1. login as an user 2. Select a group with more than 10 members 3. Show members list 4. Change results per page to 50 5. Navigate to the second page Expected result: after step 4: -The fist 50 members are shown -Number of pages in pageselector reduces after step5: The second page shows members 51 Actual result: after step4: The list shows the first 10 members The number of pages are reduced to the pages needed for 50 members after step5: The second page shows the first 10 results of the members list To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1514374/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1514374] Re: groups/members list shows only forst 10 results
Hi Christiana, Thanks for the bug report, and especially for the detailed bug reproduction instructions. :) Cheers, Aaron ** Also affects: mahara/16.04 Importance: Undecided Status: New ** Also affects: mahara/15.10 Importance: Undecided Status: New ** Changed in: mahara/15.10 Status: New => In Progress ** Changed in: mahara/15.10 Status: In Progress => Confirmed ** Changed in: mahara/16.04 Status: New => Confirmed ** Changed in: mahara/15.10 Importance: Undecided => High ** Changed in: mahara/16.04 Importance: Undecided => High ** Changed in: mahara/15.10 Milestone: None => 15.10.1 ** Changed in: mahara/16.04 Milestone: None => 16.04.0 ** Summary changed: - groups/members list shows only forst 10 results + "Groups -> Members" page shows only first 10 group members -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1514374 Title: "Groups -> Members" page shows only first 10 group members Status in Mahara: Confirmed Status in Mahara 15.10 series: Confirmed Status in Mahara 16.04 series: Confirmed Bug description: Mahara 15.10.0 linux mysql several browsers 1. login as an user 2. Select a group with more than 10 members 3. Show members list 4. Change results per page to 50 5. Navigate to the second page Expected result: after step 4: -The fist 50 members are shown -Number of pages in pageselector reduces after step5: The second page shows members 51 Actual result: after step4: The list shows the first 10 members The number of pages are reduced to the pages needed for 50 members after step5: The second page shows the first 10 results of the members list To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1514374/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1513665] Re: Replace zeroclipboard with a non-flash alternative
Lol, actually in all the modern browsers, clipboard.js actually *does* copy stuff to the clipboard! The miracles of HTML5. :) I even tried it out on my phone and it worked! I haven't tested it firsthand, but it says it works in all of Mahara's supported browsers, including IE9. Except for Safari, in which it just selects the text instead of copying it. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1513665 Title: Replace zeroclipboard with a non-flash alternative Status in Mahara: Confirmed Bug description: On the Secret URLs page, we added the zeroclipboard library to allow users to click a clipboard icon and have the URL copied to their clipboard. Unfortunately, since then Flash has started dying in a bad way, and now this sort of Flash-based clipboard widget is on the way out, and can cause browsers to pop up warning messages and such. Now, there is no way to accomplish exactly this same functionality (copy to clipboard) without Flash currently. But, there are some useable alternatives. The one that seems to be poised to replace the click-to-copy pattern, is that you click and it automatically selects the full text, so that you then just have to hit "control-C" instead of first dragging to select it all. Jen recently added this little clipboard library to the styleguide.php script. It works pretty good, so we may as well adopt it for the Secret URL screen as well. http://zenorocha.github.io/clipboard.js/ To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1513665/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1514608] Re: MySQL deadlock issues with simultaneous users
** Changed in: mahara Milestone: None => 15.04.5 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1514608 Title: MySQL deadlock issues with simultaneous users Status in Mahara: In Progress Bug description: The patch in Bug 1492919 resolved the deadlock issues for some users, but others are still reporting that they are getting deadlocks. This seems to be an issue unique to MySQL, and it can happen with as few as 2 or 3 concurrent users. It has been reported across all stable versions. Strangely, it seems to be a relatively recent issue (i.e. we never heard this with Mahara 1.8 or 1.7, etc), so this suggests it was triggered by something that changed fairly recently. One possible candidate is our switch to the mysqli driver (before that Mahara wasn't doing transactions at all, in mysql). To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1514608/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1514415] A patch has been submitted for review
Patch for "master" branch: https://reviews.mahara.org/5681 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1514415 Title: [MySQL] Index column size too large. The maximum column size is 767 bytes. Status in Mahara: In Progress Bug description: Hallo, I have tried to install Mahara with MySQL. I have installed it in the following way: 1. I cloned the git repository at https://git.mahara.org/mahara/mahara.git 2. I built mahara with make css to create all neccessary files 3. I started the installationn with php admin/cli/install.php --adminpassword='' --adminemail= After a while the following error appeared: "(lib/dml.php:150) mysqli error: [1709: Index column size too large. The maximum column size is 767 bytes.]" I did some research and found a potential solution for that: 1. Some entries in my.cnf, which I have already added: innodb_large_prefix=on innodb_file_format=barracuda innodb_file_per_table=true 2. To add "ROW_FORMAT=DYNAMIC;" when creating a table. But I have no idea how to do this. More information on this error can be found on: http://mechanics.flite.com/blog/2014/07/29/using-innodb-large-prefix-to-avoid-error-1071/ https://dev.mysql.com/doc/refman/5.5/en/innodb-restrictions.html https://dev.mysql.com/doc/refman/5.5/en/innodb-row-format-dynamic.html Here is the log-file [INF] 72 (admin/cli/install.php:74) Installing Mahara [INF] 72 (lib/mahara.php:228) Installing core [INF] 72 (lib/upgrade.php:1364) Enabled 2 HTML filters. [INF] 72 (lib/mahara.php:228) Installing firstcoredata [INF] 72 (lib/mahara.php:228) Installing localpreinst [INF] 72 (lib/mahara.php:228) Installing artefact.plans [INF] 72 (lib/mahara.php:228) Installing artefact.blog [INF] 72 (lib/mahara.php:228) Installing artefact.internal [INF] 72 (lib/mahara.php:228) Installing artefact.comment [INF] 72 (lib/mahara.php:228) Installing artefact.file [INF] 72 (artefact/file/lib.php:269) Updated filetype list: 142 added. [INF] 72 (lib/mahara.php:228) Installing artefact.annotation [INF] 72 (lib/mahara.php:228) Installing artefact.resume [INF] 72 (lib/mahara.php:228) Installing auth.saml [INF] 72 (lib/mahara.php:228) Installing auth.internal [INF] 72 (lib/mahara.php:228) Installing auth.ldap [INF] 72 (lib/mahara.php:228) Installing auth.browserid [INF] 72 (lib/mahara.php:228) Installing auth.none [INF] 72 (lib/mahara.php:228) Installing auth.imap [INF] 72 (lib/mahara.php:228) Installing auth.webservice [INF] 72 (lib/mahara.php:228) Installing auth.xmlrpc [INF] 72 (lib/mahara.php:228) Installing notification.email [INF] 72 (lib/mahara.php:228) Installing notification.emaildigest [INF] 72 (lib/mahara.php:228) Installing notification.internal [INF] 72 (lib/mahara.php:228) Installing search.elasticsearch [INF] 72 (lib/mahara.php:228) Installing search.internal [INF] 72 (lib/mahara.php:228) Installing blocktype.file/gallery [INF] 72 (lib/mahara.php:228) Installing blocktype.resume/entireresume [INF] 72 (lib/mahara.php:228) Installing blocktype.internal/profileinfo [INF] 72 (lib/mahara.php:228) Installing blocktype.file/image [INF] 72 (lib/mahara.php:228) Installing blocktype.internal/textbox [INF] 72 (lib/mahara.php:228) Installing blocktype.internal/socialprofile [INF] 72 (lib/mahara.php:228) Installing blocktype.file/pdf [INF] 72 (lib/mahara.php:228) Installing blocktype.file/html [INF] 72 (lib/mahara.php:228) Installing blocktype.blog/recentposts [INF] 72 (lib/mahara.php:228) Installing blocktype.file/filedownload [INF] 72 (lib/mahara.php:228) Installing blocktype.comment/comment [INF] 72 (lib/mahara.php:228) Installing blocktype.file/folder [INF] 72 (lib/mahara.php:228) Installing blocktype.blog/blog [INF] 72 (lib/mahara.php:228) Installing blocktype.resume/resumefield [INF] 72 (lib/mahara.php:228) Installing blocktype.blog/taggedposts [INF] 72 (lib/mahara.php:228) Installing blocktype.blog/blogpost [INF] 72 (lib/mahara.php:228) Installing blocktype.myfriends [INF] 72 (lib/mahara.php:228) Installing blocktype.externalvideo [INF] 72 (lib/mahara.php:228) Installing blocktype.inbox [INF] 72 (lib/mahara.php:228) Installing blocktype.recentforumposts [INF] 72 (lib/mahara.php:228) Installing blocktype.plans/plans [INF] 72 (lib/mahara.php:228) Installing blocktype.groupmembers [INF] 72 (lib/mahara.php:228) Installing blocktype.groupinfo [INF] 72 (lib/mahara.php:228) Installing blocktype.googleapps [INF] 72 (lib/mahara.php:228) Installing blocktype.file/internalmedia [INF] 72 (lib/mahara.php:228) Installing blocktype.text [INF] 72 (lib/mahara.php:228) Installing blocktype.externalfeed [INF] 72 (lib/mahara.php:228) Instal
[Mahara-contributors] [Bug 1514415] Re: [MySQL] Index column size too large. The maximum column size is 767 bytes.
Hi Andreas, Thanks for the bug report! That is an intriguing one, which I have never seen before. When I install Mahara, it looks like my mysql setup automatically puts a 255-character prefix on that index (i.e. only indexes the first 255 characters of the interaction_forum_post.path column). Now that I look into it, I think the particular prefix that is giving you problems is actually unnecessary anyway. It's an index on interaction_forum_post.path, which was added for bug 992905, to allow forum posts to be paginated but still sort correctly on each page, even if you're using nested replies. However, we only use interaction_forum_post.path in the "WHERE" section of a query twice. And in both those cases, we're also filtering by interaction_forum_post.topic. I think, in typical usage patterns, there will not be so many forum posts under a single topic, that having a separate index on the path column will actually improve performance by much. (You'd need to have a forum topic thousands of pages long for that to start happening.) So I'm going to look into just removing this index. ** Changed in: mahara Status: New => In Progress ** Changed in: mahara Importance: Undecided => Low ** Changed in: mahara Milestone: None => 16.04.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1514415 Title: [MySQL] Index column size too large. The maximum column size is 767 bytes. Status in Mahara: In Progress Bug description: Hallo, I have tried to install Mahara with MySQL. I have installed it in the following way: 1. I cloned the git repository at https://git.mahara.org/mahara/mahara.git 2. I built mahara with make css to create all neccessary files 3. I started the installationn with php admin/cli/install.php --adminpassword='' --adminemail= After a while the following error appeared: "(lib/dml.php:150) mysqli error: [1709: Index column size too large. The maximum column size is 767 bytes.]" I did some research and found a potential solution for that: 1. Some entries in my.cnf, which I have already added: innodb_large_prefix=on innodb_file_format=barracuda innodb_file_per_table=true 2. To add "ROW_FORMAT=DYNAMIC;" when creating a table. But I have no idea how to do this. More information on this error can be found on: http://mechanics.flite.com/blog/2014/07/29/using-innodb-large-prefix-to-avoid-error-1071/ https://dev.mysql.com/doc/refman/5.5/en/innodb-restrictions.html https://dev.mysql.com/doc/refman/5.5/en/innodb-row-format-dynamic.html Here is the log-file [INF] 72 (admin/cli/install.php:74) Installing Mahara [INF] 72 (lib/mahara.php:228) Installing core [INF] 72 (lib/upgrade.php:1364) Enabled 2 HTML filters. [INF] 72 (lib/mahara.php:228) Installing firstcoredata [INF] 72 (lib/mahara.php:228) Installing localpreinst [INF] 72 (lib/mahara.php:228) Installing artefact.plans [INF] 72 (lib/mahara.php:228) Installing artefact.blog [INF] 72 (lib/mahara.php:228) Installing artefact.internal [INF] 72 (lib/mahara.php:228) Installing artefact.comment [INF] 72 (lib/mahara.php:228) Installing artefact.file [INF] 72 (artefact/file/lib.php:269) Updated filetype list: 142 added. [INF] 72 (lib/mahara.php:228) Installing artefact.annotation [INF] 72 (lib/mahara.php:228) Installing artefact.resume [INF] 72 (lib/mahara.php:228) Installing auth.saml [INF] 72 (lib/mahara.php:228) Installing auth.internal [INF] 72 (lib/mahara.php:228) Installing auth.ldap [INF] 72 (lib/mahara.php:228) Installing auth.browserid [INF] 72 (lib/mahara.php:228) Installing auth.none [INF] 72 (lib/mahara.php:228) Installing auth.imap [INF] 72 (lib/mahara.php:228) Installing auth.webservice [INF] 72 (lib/mahara.php:228) Installing auth.xmlrpc [INF] 72 (lib/mahara.php:228) Installing notification.email [INF] 72 (lib/mahara.php:228) Installing notification.emaildigest [INF] 72 (lib/mahara.php:228) Installing notification.internal [INF] 72 (lib/mahara.php:228) Installing search.elasticsearch [INF] 72 (lib/mahara.php:228) Installing search.internal [INF] 72 (lib/mahara.php:228) Installing blocktype.file/gallery [INF] 72 (lib/mahara.php:228) Installing blocktype.resume/entireresume [INF] 72 (lib/mahara.php:228) Installing blocktype.internal/profileinfo [INF] 72 (lib/mahara.php:228) Installing blocktype.file/image [INF] 72 (lib/mahara.php:228) Installing blocktype.internal/textbox [INF] 72 (lib/mahara.php:228) Installing blocktype.internal/socialprofile [INF] 72 (lib/mahara.php:228) Installing blocktype.file/pdf [INF] 72 (lib/mahara.php:228) Installing blocktype.file/html [INF] 72 (lib/mahara.php:228) Installing blocktype.blog/recentposts [INF] 72 (lib/mahar
[Mahara-contributors] [Bug 1514608] Re: MySQL deadlock issues with simultaneous users
I have seen onesystem where a deadlock occurred even with the transaction isolation change. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1514608 Title: MySQL deadlock issues with simultaneous users Status in Mahara: In Progress Bug description: The patch in Bug 1492919 resolved the deadlock issues for some users, but others are still reporting that they are getting deadlocks. This seems to be an issue unique to MySQL, and it can happen with as few as 2 or 3 concurrent users. It has been reported across all stable versions. Strangely, it seems to be a relatively recent issue (i.e. we never heard this with Mahara 1.8 or 1.7, etc), so this suggests it was triggered by something that changed fairly recently. One possible candidate is our switch to the mysqli driver (before that Mahara wasn't doing transactions at all, in mysql). To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1514608/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1514608] Re: MySQL deadlock issues with simultaneous users
I have seen the error from one system where a deadlock occurred even with the transaction isolation change. That error was in a different part of the code and related to the triggers for quota checks. This had been where I had started to look again at the transaction behaviour in general with Mahara and mysql. Unfortunately I've not managed to replicate the deadlock error on a system I have access to. Does somebody have a reproducible case? -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1514608 Title: MySQL deadlock issues with simultaneous users Status in Mahara: In Progress Bug description: The patch in Bug 1492919 resolved the deadlock issues for some users, but others are still reporting that they are getting deadlocks. This seems to be an issue unique to MySQL, and it can happen with as few as 2 or 3 concurrent users. It has been reported across all stable versions. Strangely, it seems to be a relatively recent issue (i.e. we never heard this with Mahara 1.8 or 1.7, etc), so this suggests it was triggered by something that changed fairly recently. One possible candidate is our switch to the mysqli driver (before that Mahara wasn't doing transactions at all, in mysql). To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1514608/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1514281] Re: No .table-responsive added to 'admin/site/menu.php"
Hi Matt, Thanks for the bug report, and the suggested fix! We're going to look into implementing this. Cheers, Aaron ** Also affects: mahara/16.04 Importance: Undecided Status: New ** Also affects: mahara/15.10 Importance: Undecided Status: New ** Changed in: mahara/15.10 Status: New => Confirmed ** Changed in: mahara/16.04 Status: New => Confirmed ** Changed in: mahara/15.10 Importance: Undecided => Medium ** Changed in: mahara/16.04 Importance: Undecided => Medium ** Changed in: mahara/15.10 Milestone: None => 15.10.1 ** Changed in: mahara/16.04 Milestone: None => 16.04.0 ** Tags added: mobile -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1514281 Title: No .table-responsive added to 'admin/site/menu.php" Status in Mahara: Confirmed Status in Mahara 15.10 series: Confirmed Status in Mahara 16.04 series: Confirmed Bug description: Line #66 from 'admin/site/menu.php": Layout does not work with mobile breakpoints having a table without the .table-responsive added to the class. Maybe should be added to all tables within core. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1514281/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1513710] Re: Destructor methods that access global variables can cause crashes
I ran the Behat tests again, with the destructors changed to throw an exception if there were uncommitted changes. No problems at all. So, I think we should be fairly safe getting rid of them. However, rather than just deleting them, I'm first going to look into whether there's a safe way to make them log a warning or something if there are uncommitted changes. The tricky part there is that I'll need to see what kinds of things are safe to do during which states of garbage collection. For instance, I can't use the standard mahara log_warn() message or anything like that, because it depends on Mahara's global $SESSION variable, which may no longer be present by that point. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1513710 Title: Destructor methods that access global variables can cause crashes Status in Mahara: Confirmed Status in Mahara 15.04 series: Confirmed Status in Mahara 15.10 series: Confirmed Status in Mahara 16.04 series: Confirmed Bug description: See : https://mahara.org/interaction/forum/topic.php?id=7397 Here's the problem (which appears to be intermittent): 1. ArtefactType has a destructor method, which gets called when an artefact object is garbage-collected by PHP. 2. PHP runs destructor methods and garbage collects variables in no guaranteed order when exit() is called. 3. Sometimes the ArtefactType destructor method tries to call DML methods, which use the global variable $db 4. Apparently sometimes the $db global variable has already been garbage collected by the time the destructor runs 5. This causes a fatal "method on a non-object" crash. It's unclear why this error has only started happening recently. It might be due to a change in the behavior of PHP's garbage collector, or it might be from new Mahara code leaving some artefacts with their $dirty flag set (which triggers that artefact commit). In either case, both global variables and implicit destructor methods are considered harmful design practices, in part because of this particular thing. So it's high time we got rid of these __destruct() methods. Alternatively, as a workaround for older Mahara versions, we could add some code to the top of each __destruct() method that re-creates the global $db if it's not set. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1513710/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1514271] Re: Behat: Create a fixure for creating multiple journals and posts
** Changed in: mahara Status: New => Triaged -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1514271 Title: Behat: Create a fixure for creating multiple journals and posts Status in Mahara: Triaged Bug description: Hi, Can we please add a fixture to Behat for adding multiple Journals and journal posts. This will make for bulk testing. Cheers, Jinelle To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1514271/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1514608] Re: MySQL deadlock issues with simultaneous users
Most of our reports are for sites on 15.04, and it seems to get worse when there are more users. It's possible this was some sort of underlying deadlock potential in Mahara that was made worse by some low- level code change in 15.04, like something that gets triggered by init.php or some other frequent bit of code, which was not triggered as frequently before. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1514608 Title: MySQL deadlock issues with simultaneous users Status in Mahara: In Progress Bug description: The patch in Bug 1492919 resolved the deadlock issues for some users, but others are still reporting that they are getting deadlocks. This seems to be an issue unique to MySQL, and it can happen with as few as 2 or 3 concurrent users. It has been reported across all stable versions. Strangely, it seems to be a relatively recent issue (i.e. we never heard this with Mahara 1.8 or 1.7, etc), so this suggests it was triggered by something that changed fairly recently. One possible candidate is our switch to the mysqli driver (before that Mahara wasn't doing transactions at all, in mysql). To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1514608/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1514608] [NEW] MySQL deadlock issues with simultaneous users
Public bug reported: The patch in Bug 1492919 resolved the deadlock issues for some users, but others are still reporting that they are getting deadlocks. This seems to be an issue unique to MySQL, and it can happen with as few as 2 or 3 concurrent users. It has been reported across all stable versions. Strangely, it seems to be a relatively recent issue (i.e. we never heard this with Mahara 1.8 or 1.7, etc), so this suggests it was triggered by something that changed fairly recently. One possible candidate is our switch to the mysqli driver (before that Mahara wasn't doing transactions at all, in mysql). ** Affects: mahara Importance: High Assignee: Aaron Wells (u-aaronw) Status: In Progress ** Description changed: The patch in Bug 1492919 resolved the deadlock issues for some users, but others are still reporting that they are getting deadlocks. This seems to be an issue unique to MySQL, and it can happen with as few as 2 or 3 concurrent users. + + It has been reported across all stable versions. Strangely, it seems to + be a relatively recent issue (i.e. we never heard this with Mahara 1.8 + or 1.7, etc), so this suggests it was triggered by something that + changed fairly recently. One possible candidate is our switch to the + mysqli driver (before that Mahara wasn't doing transactions at all, in + mysql). ** Changed in: mahara Status: New => In Progress ** Changed in: mahara Importance: Undecided => High ** Changed in: mahara Assignee: (unassigned) => Aaron Wells (u-aaronw) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1514608 Title: MySQL deadlock issues with simultaneous users Status in Mahara: In Progress Bug description: The patch in Bug 1492919 resolved the deadlock issues for some users, but others are still reporting that they are getting deadlocks. This seems to be an issue unique to MySQL, and it can happen with as few as 2 or 3 concurrent users. It has been reported across all stable versions. Strangely, it seems to be a relatively recent issue (i.e. we never heard this with Mahara 1.8 or 1.7, etc), so this suggests it was triggered by something that changed fairly recently. One possible candidate is our switch to the mysqli driver (before that Mahara wasn't doing transactions at all, in mysql). To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1514608/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1492919] Re: Deadlock issues when 20-30 users copying collections & pages at the same time
Since this bug has still been reported even after the deployment of the patch 5366, I've opened a subsequent bug: https://bugs.launchpad.net/mahara/+bug/1514608 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1492919 Title: Deadlock issues when 20-30 users copying collections & pages at the same time Status in Mahara: Fix Released Status in Mahara 1.10 series: Fix Released Status in Mahara 1.9 series: Fix Released Status in Mahara 15.04 series: Fix Released Status in Mahara 15.10 series: Fix Released Bug description: Multiple users on the forum have reported deadlock issues when there are many users (20-30) copying pages & collections at the same time. See https://mahara.org/interaction/forum/topic.php?id=7309&offset=0&limit=10 Note that 20 to 30 users is around the number you'd hit if you're running a whole class of users through a training session at the same time. The three reported cases of this are all in 15.04, so it may be a problem introduced in that version. The problem has been reported in both Postgres & MySQL. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1492919/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1513400] Re: Checkboxes pieform element doesn't work properly
I will send the code. I just need to isolate the parts that are really necessary for you to see what is going on, since I am rewriting UI appearance of the plugin as well as the functionality to support latest Europass scheme (v3.3.0). -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1513400 Title: Checkboxes pieform element doesn't work properly Status in Mahara: Incomplete Bug description: In Administration -> Configure site -> Cookie Consent -> General options there is a "Types of cookies" checkboxes pieform element. If I want to select different types I am unable to do so. Only "Social media" option gets selected/checked even if I click on other options, which are not disabled. Mahara 15.10 To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1513400/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1514272] A change has been merged
Reviewed: https://reviews.mahara.org/5676 Committed: https://git.mahara.org/mahara/mahara/commit/58e3fd381621119c381f10de3b43c1ed265f9582 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:master commit 58e3fd381621119c381f10de3b43c1ed265f9582 Author: Robert Lyon Date: Mon Nov 9 13:01:29 2015 +1300 Bug 1514272: User search is failing when 'email address' option is on Need to pass the correct number of prepare statement values for the sql string. Change-Id: Ib3071b420e739292f089cd029fb9c7219a83bb3e Signed-off-by: Robert Lyon -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1514272 Title: Doing user search with 'email' option on breaks search Status in Mahara: Fix Committed Status in Mahara 15.10 series: Fix Committed Status in Mahara 16.04 series: Fix Committed Bug description: The fix for https://bugs.launchpad.net/mahara/+bug/150 broke the user search when a site has 'Email address' ticked for searchable fields under Administration -> Extensions -> Plugin type: artefact -> Internal -> configuration form. The problem being that there are now 2 extra values for the prepare string that are not being added to the $values array I'll fix up To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1514272/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1513306] A change has been merged
Reviewed: https://reviews.mahara.org/5673 Committed: https://git.mahara.org/mahara/mahara/commit/cd089eae11eddcfae76a1a388b8727b1eb43f698 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:master commit cd089eae11eddcfae76a1a388b8727b1eb43f698 Author: Robert Lyon Date: Mon Nov 9 10:41:32 2015 +1300 Bug 1513306: Add collection id to 'Share page' link So it can be passed to 'edit access' page from the 'edit page' page on the 'Share page' link Change-Id: I1968d205b12840cd3dcfbd80a6ffdd26a498361d Signed-off-by: Robert Lyon -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1513306 Title: "Share page" link doesn't work from pages in collections Status in Mahara: Fix Committed Status in Mahara 15.10 series: In Progress Status in Mahara 16.04 series: Fix Committed Bug description: To replicate: 1. Create a page 2. Put the page in a collection 3. Edit the page 4. On the edit screen, click the "Share page" link 5. You will be taken to the Edit access screen. 6. Share the page with Public 7. Click "Save" Expected result: You should now be on the "Shared by me" page, and see that the page has been shared with the Public, with the message "Access rules were updated for 1 page(s)" Actual result: On the Edit access screen, the "Collections" and "Pages" selectors will both be empty. When you hit save the message will say "Access rules were updated for 0 page(s)", and there will be no change to the permissions of the collection's page. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1513306/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1513306] A patch has been submitted for review
Patch for "15.10_STABLE" branch: https://reviews.mahara.org/5680 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1513306 Title: "Share page" link doesn't work from pages in collections Status in Mahara: Fix Committed Status in Mahara 15.10 series: In Progress Status in Mahara 16.04 series: Fix Committed Bug description: To replicate: 1. Create a page 2. Put the page in a collection 3. Edit the page 4. On the edit screen, click the "Share page" link 5. You will be taken to the Edit access screen. 6. Share the page with Public 7. Click "Save" Expected result: You should now be on the "Shared by me" page, and see that the page has been shared with the Public, with the message "Access rules were updated for 1 page(s)" Actual result: On the Edit access screen, the "Collections" and "Pages" selectors will both be empty. When you hit save the message will say "Access rules were updated for 0 page(s)", and there will be no change to the permissions of the collection's page. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1513306/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1467368] A change has been merged
Reviewed: https://reviews.mahara.org/4899 Committed: https://git.mahara.org/mahara/mahara/commit/a2459daa1240664a39a13edafbac625de3aae40b Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:master commit a2459daa1240664a39a13edafbac625de3aae40b Author: Jinelle Foley-Barnes Date: Tue Jun 23 17:40:08 2015 +1200 Behat Test: Menu navigation as different users (Bug 1467368). Change-Id: I520abf1434d464928bdafa4ebb49603212b707e0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1467368 Title: cache the main navigation menu Status in Mahara: Fix Committed Status in Mahara 15.10 series: Fix Released Bug description: Part of rendering the main navigation is it checks all the plugins to see if they want to add to the menu. This is not an ideal way of doing it. We should cache the main menu's $menu array in the database after first render and just use that. We should also have a clear_menu_cache($institution = null) function so that when the site or and institution updates it's config the related cached menus are cleared and able to generate again. We should also clear the menu cache when plugins are installed / removed / hidden / shown To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1467368/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1467368] Re: cache the main navigation menu
** Changed in: mahara/15.10 Milestone: None => 15.10.1 ** Changed in: mahara Milestone: 15.10.0 => 16.04.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1467368 Title: cache the main navigation menu Status in Mahara: Fix Committed Status in Mahara 15.10 series: Fix Released Bug description: Part of rendering the main navigation is it checks all the plugins to see if they want to add to the menu. This is not an ideal way of doing it. We should cache the main menu's $menu array in the database after first render and just use that. We should also have a clear_menu_cache($institution = null) function so that when the site or and institution updates it's config the related cached menus are cleared and able to generate again. We should also clear the menu cache when plugins are installed / removed / hidden / shown To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1467368/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1514272] Re: Doing user search with 'email' option on breaks search
** Changed in: mahara/16.04 Status: In Progress => Fix Committed ** Changed in: mahara/15.10 Status: Confirmed => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1514272 Title: Doing user search with 'email' option on breaks search Status in Mahara: Fix Committed Status in Mahara 15.10 series: Fix Committed Status in Mahara 16.04 series: Fix Committed Bug description: The fix for https://bugs.launchpad.net/mahara/+bug/150 broke the user search when a site has 'Email address' ticked for searchable fields under Administration -> Extensions -> Plugin type: artefact -> Internal -> configuration form. The problem being that there are now 2 extra values for the prepare string that are not being added to the $values array I'll fix up To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1514272/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1513306] Re: "Share page" link doesn't work from pages in collections
** Changed in: mahara/16.04 Status: In Progress => Fix Committed ** Changed in: mahara/15.10 Status: Confirmed => In Progress -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1513306 Title: "Share page" link doesn't work from pages in collections Status in Mahara: Fix Committed Status in Mahara 15.10 series: In Progress Status in Mahara 16.04 series: Fix Committed Bug description: To replicate: 1. Create a page 2. Put the page in a collection 3. Edit the page 4. On the edit screen, click the "Share page" link 5. You will be taken to the Edit access screen. 6. Share the page with Public 7. Click "Save" Expected result: You should now be on the "Shared by me" page, and see that the page has been shared with the Public, with the message "Access rules were updated for 1 page(s)" Actual result: On the Edit access screen, the "Collections" and "Pages" selectors will both be empty. When you hit save the message will say "Access rules were updated for 0 page(s)", and there will be no change to the permissions of the collection's page. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1513306/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1512901] Re: Share with page not showing correct information
** Changed in: mahara/15.10 Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1512901 Title: Share with page not showing correct information Status in Mahara: Fix Committed Status in Mahara 15.10 series: Fix Committed Status in Mahara 16.04 series: Fix Committed Bug description: In 15.10 If I share a page with users, friends where I pick the particular user/friend and save the page and then go back to edit the page the wrong things are selected in the dropdown To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1512901/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1513309] Re: Fix easily fixable plural strings
** Changed in: mahara Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1513309 Title: Fix easily fixable plural strings Status in Mahara: Fix Committed Bug description: When you make permission changes to a page, there's a confirmation message afterwards that tells you how many pages were changed. Apparently it was never made into a proper plural lang string, so it says e.g. "Access rules were updated for 2 page(s)". To replicate: 1. Create a page 2. Change the permissions on the page 3. Save the changed permissions Expected result: When you save the permissions, you should see the message "Access rules were updated for 1 page." Actual result: When you save the permissions, you see "Access rules were updated for 1 page(s)." To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1513309/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1513611] Re: Problem with artefactchooser and dwoo template
** Changed in: mahara/15.10 Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1513611 Title: Problem with artefactchooser and dwoo template Status in Mahara: Fix Committed Status in Mahara 15.10 series: Fix Committed Status in Mahara 16.04 series: Fix Committed Bug description: A couple of people have reported this problem, on of which is here: https://mahara.org/interaction/forum/topic.php?id=7426&offset=0&limit=10#post29848 The error they get is: PHP Parse error: syntax error, unexpected '(' in /path/to/dwoo/compile/raw/var/www/mahara-15.10.0/htdocs/theme/raw/templates/form/artefactchooser.tpl.d17.php on line 39 The line looks to be syntax correct and works fine on my machine (Ubuntu 14.04, firefox, PHP 5.5.9) But we could try and fix this issue by removing the empty() function from the template htdocs/theme/raw/templates/form/artefactchooser.tpl and place it in the htdocs/lib/form/elements/artefactchooser.php file instead to see if that makes a difference. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1513611/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1514272] A change has been merged
Reviewed: https://reviews.mahara.org/5675 Committed: https://git.mahara.org/mahara/mahara/commit/1140016609e2be2df3a315578fbf2b6b4c87aa78 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:15.10_STABLE commit 1140016609e2be2df3a315578fbf2b6b4c87aa78 Author: Robert Lyon Date: Mon Nov 9 13:01:29 2015 +1300 Bug 1514272: User search is failing when 'email address' option is on Need to pass the correct number of prepare statement values for the sql string. Change-Id: Ib3071b420e739292f089cd029fb9c7219a83bb3e Signed-off-by: Robert Lyon -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1514272 Title: Doing user search with 'email' option on breaks search Status in Mahara: Fix Committed Status in Mahara 15.10 series: Fix Committed Status in Mahara 16.04 series: Fix Committed Bug description: The fix for https://bugs.launchpad.net/mahara/+bug/150 broke the user search when a site has 'Email address' ticked for searchable fields under Administration -> Extensions -> Plugin type: artefact -> Internal -> configuration form. The problem being that there are now 2 extra values for the prepare string that are not being added to the $values array I'll fix up To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1514272/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1512901] A change has been merged
Reviewed: https://reviews.mahara.org/5672 Committed: https://git.mahara.org/mahara/mahara/commit/bdad61bce12e4ba5374d2124e987757249c48552 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:15.10_STABLE commit bdad61bce12e4ba5374d2124e987757249c48552 Author: Robert Lyon Date: Thu Nov 5 09:54:46 2015 +1300 Bug 1512901: getting the dropdowns to show correct info behatnotneeded: can't test a select2 that loads data via ajax yet Change-Id: Iae07e3d19b376acbbe4ca531bd8aebb555f6b377 Signed-off-by: Robert Lyon (cherry picked from commit 88ffbab9d4425660c1e045cbf38881ec4fdd803a) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1512901 Title: Share with page not showing correct information Status in Mahara: Fix Committed Status in Mahara 15.10 series: Fix Committed Status in Mahara 16.04 series: Fix Committed Bug description: In 15.10 If I share a page with users, friends where I pick the particular user/friend and save the page and then go back to edit the page the wrong things are selected in the dropdown To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1512901/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1513611] A change has been merged
Reviewed: https://reviews.mahara.org/5671 Committed: https://git.mahara.org/mahara/mahara/commit/f15b4e7d1866cdb84f0ee85a7b699fae3e120aa3 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:15.10_STABLE commit f15b4e7d1866cdb84f0ee85a7b699fae3e120aa3 Author: Robert Lyon Date: Fri Nov 6 09:34:37 2015 +1300 Bug 1513611: Artefactchooser template is broken for some systems I can't replicate but believe it's due to the .tpl file compiling to a call to empty() with an expression as the parameter (which is not supported by PHP prior to 5.5) behatnotneeded: covered by existing tests Change-Id: Ic44b89070de169790dbc5ab6d32a12484925c7e3 Signed-off-by: Robert Lyon (cherry picked from commit 6353a366818070114126e845a309a1b86a209164) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1513611 Title: Problem with artefactchooser and dwoo template Status in Mahara: Fix Committed Status in Mahara 15.10 series: Fix Committed Status in Mahara 16.04 series: Fix Committed Bug description: A couple of people have reported this problem, on of which is here: https://mahara.org/interaction/forum/topic.php?id=7426&offset=0&limit=10#post29848 The error they get is: PHP Parse error: syntax error, unexpected '(' in /path/to/dwoo/compile/raw/var/www/mahara-15.10.0/htdocs/theme/raw/templates/form/artefactchooser.tpl.d17.php on line 39 The line looks to be syntax correct and works fine on my machine (Ubuntu 14.04, firefox, PHP 5.5.9) But we could try and fix this issue by removing the empty() function from the template htdocs/theme/raw/templates/form/artefactchooser.tpl and place it in the htdocs/lib/form/elements/artefactchooser.php file instead to see if that makes a difference. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1513611/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1513309] A change has been merged
Reviewed: https://reviews.mahara.org/5663 Committed: https://git.mahara.org/mahara/mahara/commit/fa73315e80b796e8778746ea5a89a9006dbaea85 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:master commit fa73315e80b796e8778746ea5a89a9006dbaea85 Author: Aaron Wells Date: Thu Nov 5 18:29:54 2015 +1300 Pluralizing some old lang strings (Bug 1513309) behatnotneeded: Will be handled by existing test Change-Id: I476a3cc7ff1e791bc24a60986841ad92f57d7bb6 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1513309 Title: Fix easily fixable plural strings Status in Mahara: Fix Committed Bug description: When you make permission changes to a page, there's a confirmation message afterwards that tells you how many pages were changed. Apparently it was never made into a proper plural lang string, so it says e.g. "Access rules were updated for 2 page(s)". To replicate: 1. Create a page 2. Change the permissions on the page 3. Save the changed permissions Expected result: When you save the permissions, you should see the message "Access rules were updated for 1 page." Actual result: When you save the permissions, you see "Access rules were updated for 1 page(s)." To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1513309/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1514415] [NEW] [MySQL] Index column size too large. The maximum column size is 767 bytes.
Public bug reported: Hallo, I have tried to install Mahara with MySQL. I have installed it in the following way: 1. I cloned the git repository at https://git.mahara.org/mahara/mahara.git 2. I built mahara with make css to create all neccessary files 3. I started the installationn with php admin/cli/install.php --adminpassword='' --adminemail= After a while the following error appeared: "(lib/dml.php:150) mysqli error: [1709: Index column size too large. The maximum column size is 767 bytes.]" I did some research and found a potential solution for that: 1. Some entries in my.cnf, which I have already added: innodb_large_prefix=on innodb_file_format=barracuda innodb_file_per_table=true 2. To add "ROW_FORMAT=DYNAMIC;" when creating a table. But I have no idea how to do this. More information on this error can be found on: http://mechanics.flite.com/blog/2014/07/29/using-innodb-large-prefix-to-avoid-error-1071/ https://dev.mysql.com/doc/refman/5.5/en/innodb-restrictions.html https://dev.mysql.com/doc/refman/5.5/en/innodb-row-format-dynamic.html Here is the log-file [INF] 72 (admin/cli/install.php:74) Installing Mahara [INF] 72 (lib/mahara.php:228) Installing core [INF] 72 (lib/upgrade.php:1364) Enabled 2 HTML filters. [INF] 72 (lib/mahara.php:228) Installing firstcoredata [INF] 72 (lib/mahara.php:228) Installing localpreinst [INF] 72 (lib/mahara.php:228) Installing artefact.plans [INF] 72 (lib/mahara.php:228) Installing artefact.blog [INF] 72 (lib/mahara.php:228) Installing artefact.internal [INF] 72 (lib/mahara.php:228) Installing artefact.comment [INF] 72 (lib/mahara.php:228) Installing artefact.file [INF] 72 (artefact/file/lib.php:269) Updated filetype list: 142 added. [INF] 72 (lib/mahara.php:228) Installing artefact.annotation [INF] 72 (lib/mahara.php:228) Installing artefact.resume [INF] 72 (lib/mahara.php:228) Installing auth.saml [INF] 72 (lib/mahara.php:228) Installing auth.internal [INF] 72 (lib/mahara.php:228) Installing auth.ldap [INF] 72 (lib/mahara.php:228) Installing auth.browserid [INF] 72 (lib/mahara.php:228) Installing auth.none [INF] 72 (lib/mahara.php:228) Installing auth.imap [INF] 72 (lib/mahara.php:228) Installing auth.webservice [INF] 72 (lib/mahara.php:228) Installing auth.xmlrpc [INF] 72 (lib/mahara.php:228) Installing notification.email [INF] 72 (lib/mahara.php:228) Installing notification.emaildigest [INF] 72 (lib/mahara.php:228) Installing notification.internal [INF] 72 (lib/mahara.php:228) Installing search.elasticsearch [INF] 72 (lib/mahara.php:228) Installing search.internal [INF] 72 (lib/mahara.php:228) Installing blocktype.file/gallery [INF] 72 (lib/mahara.php:228) Installing blocktype.resume/entireresume [INF] 72 (lib/mahara.php:228) Installing blocktype.internal/profileinfo [INF] 72 (lib/mahara.php:228) Installing blocktype.file/image [INF] 72 (lib/mahara.php:228) Installing blocktype.internal/textbox [INF] 72 (lib/mahara.php:228) Installing blocktype.internal/socialprofile [INF] 72 (lib/mahara.php:228) Installing blocktype.file/pdf [INF] 72 (lib/mahara.php:228) Installing blocktype.file/html [INF] 72 (lib/mahara.php:228) Installing blocktype.blog/recentposts [INF] 72 (lib/mahara.php:228) Installing blocktype.file/filedownload [INF] 72 (lib/mahara.php:228) Installing blocktype.comment/comment [INF] 72 (lib/mahara.php:228) Installing blocktype.file/folder [INF] 72 (lib/mahara.php:228) Installing blocktype.blog/blog [INF] 72 (lib/mahara.php:228) Installing blocktype.resume/resumefield [INF] 72 (lib/mahara.php:228) Installing blocktype.blog/taggedposts [INF] 72 (lib/mahara.php:228) Installing blocktype.blog/blogpost [INF] 72 (lib/mahara.php:228) Installing blocktype.myfriends [INF] 72 (lib/mahara.php:228) Installing blocktype.externalvideo [INF] 72 (lib/mahara.php:228) Installing blocktype.inbox [INF] 72 (lib/mahara.php:228) Installing blocktype.recentforumposts [INF] 72 (lib/mahara.php:228) Installing blocktype.plans/plans [INF] 72 (lib/mahara.php:228) Installing blocktype.groupmembers [INF] 72 (lib/mahara.php:228) Installing blocktype.groupinfo [INF] 72 (lib/mahara.php:228) Installing blocktype.googleapps [INF] 72 (lib/mahara.php:228) Installing blocktype.file/internalmedia [INF] 72 (lib/mahara.php:228) Installing blocktype.text [INF] 72 (lib/mahara.php:228) Installing blocktype.externalfeed [INF] 72 (lib/mahara.php:228) Installing blocktype.wall [INF] 72 (lib/mahara.php:228) Installing blocktype.annotation/annotation [INF] 72 (lib/mahara.php:228) Installing blocktype.creativecommons [INF] 72 (lib/mahara.php:228) Installing blocktype.groupviews [INF] 72 (lib/mahara.php:228) Installing blocktype.myviews [INF] 72 (lib/mahara.php:228) Installing blocktype.navigation [INF] 72 (lib/mahara.php:228) Installing blocktype.mygroups [INF] 72 (lib/mahara.php:228) Installing blocktype.watchlist [INF] 72 (lib/mahara.php:228) Installing blocktype.newviews [INF] 72 (lib/mahara.php:228) Installing interaction.forum [DBG] 72 (lib/dml.php:150) mysqli error: [1709: Index colu
[Mahara-contributors] [Bug 1514374] [NEW] groups/members list shows only forst 10 results
Public bug reported: Mahara 15.10.0 linux mysql several browsers 1. login as an user 2. Select a group with more than 10 members 3. Show members list 4. Change results per page to 50 5. Navigate to the second page Expected result: after step 4: -The fist 50 members are shown -Number of pages in pageselector reduces after step5: The second page shows members 51 Actual result: after step4: The list shows the first 10 members The number of pages are reduced to the pages needed for 50 members after step5: The second page shows the first 10 results of the members list ** Affects: mahara Importance: Undecided Status: New -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1514374 Title: groups/members list shows only forst 10 results Status in Mahara: New Bug description: Mahara 15.10.0 linux mysql several browsers 1. login as an user 2. Select a group with more than 10 members 3. Show members list 4. Change results per page to 50 5. Navigate to the second page Expected result: after step 4: -The fist 50 members are shown -Number of pages in pageselector reduces after step5: The second page shows members 51 Actual result: after step4: The list shows the first 10 members The number of pages are reduced to the pages needed for 50 members after step5: The second page shows the first 10 results of the members list To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1514374/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp