[Mahara-contributors] [Bug 845948] A change has been merged
Reviewed: https://reviews.mahara.org/5869 Committed: https://git.mahara.org/mahara/mahara/commit/cd9247b48186eff962c3cd9b577790087c8ba24d Submitter: Aaron Wells (aar...@catalyst.net.nz) Branch:master commit cd9247b48186eff962c3cd9b577790087c8ba24d Author: Robert Lyon Date: Mon Dec 21 13:47:39 2015 +1300 Bug 845948: Add primary key to view_access table for better indexing Part of the change is to remove duplicate view access rows as there is no need to have duplicates of the exact same access for a view. Adding the id to view_access will allow us to have different view access for a view in multiple collections in the future behatnotneeded - should be covered by existing tests Change-Id: I8d3d6f0a011d0ed01a5ff2931e8e16d3000f4f16 Signed-off-by: Robert Lyon Signed-off-by: Aaron Wells -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/845948 Title: missing primary keys Status in Mahara: In Progress Bug description: It seems during the installation of Mahara several tables are created without primary keys. This caused a headache for us when restoring tables from a pg_dump script, duplicate records were created. Specifically the table 'blocktype_installed_category', caused duplicate block types in the UI (confusing some users). A further check revealed the following tables also missing primary keys: artefact_log view_access view_visit blocktype_installed_category Version: 1.4.0 Database: Postgres OS: Linux/RHEL To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/845948/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 845948] Re: Add "ID" surrogate key column to "view_access" table
** Summary changed: - missing primary keys + Add "ID" surrogate key column to "view_access" table ** Changed in: mahara Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/845948 Title: Add "ID" surrogate key column to "view_access" table Status in Mahara: Fix Committed Bug description: It seems during the installation of Mahara several tables are created without primary keys. This caused a headache for us when restoring tables from a pg_dump script, duplicate records were created. Specifically the table 'blocktype_installed_category', caused duplicate block types in the UI (confusing some users). A further check revealed the following tables also missing primary keys: artefact_log view_access view_visit blocktype_installed_category Version: 1.4.0 Database: Postgres OS: Linux/RHEL To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/845948/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1605072] Re: Attempting to upload a folder fails with the error
To expand on this little, it looks like drag-and-drop of a folder is not currently supported by all browsers. Chrome implemented it two years ago (see http://stackoverflow.com/questions/3590058/does-html5-allow-drag- drop-upload-of-folders-or-a-folder-tree ), but it's not yet in the standard. In other browsers, the browser tries to read the folder file itself (as a zero-byte file), rather than reading the folder's contents. I tested it out in Gmail on Firefox just now, and indeed got an error message about having uploaded a zero-byte file. So I think that further confirms that cross-browser folder upload support isn't yet available. So with that being the case, Dmitrii's idea of making a more polite error message, is a good improvement for the time being. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1605072 Title: Attempting to upload a folder fails with the error Status in Mahara: Confirmed Bug description: - exact version of Mahara - master - operating system - Linux, OSX - database - Postgres - browser and version - Safari (v. 9.1.1) and Firefox (v.47.0.1) Test scenario: 1. Login to ePortfolio, go to Content > Files 2. Drag a folder from your file manager to the ‘Drop files her to upload’ region Expected: all files in the folder uploaded Actual result: Error “Server responded with 0 code.[object XMLHttpRequest]” To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1605072/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1605072] Re: Attempting to upload a folder fails with the error
Regarding DropZone.js, the latest commit to master was April 14, 2016 (merging a pull request), not two years ago. There hasn't been a lot of activity on it in the last two years, but it looks like the project maintainer is still checking in on it from time to time at least. We probably should upgrade from our current 4.2.0 to the latest release 4.3.0, which came out in Feb 2016. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1605072 Title: Attempting to upload a folder fails with the error Status in Mahara: Confirmed Bug description: - exact version of Mahara - master - operating system - Linux, OSX - database - Postgres - browser and version - Safari (v. 9.1.1) and Firefox (v.47.0.1) Test scenario: 1. Login to ePortfolio, go to Content > Files 2. Drag a folder from your file manager to the ‘Drop files her to upload’ region Expected: all files in the folder uploaded Actual result: Error “Server responded with 0 code.[object XMLHttpRequest]” To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1605072/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1605127] Re: Mismatched function declaration, urdate_url() in lib/activity.php
Hi Howard, You are correct. The abstract "Activity" class defines update_url() with no parameters, but then calls it with one parameter a few lines later. The excess parameter itself actually doesn't cause any problems. If you're calling $this->update_url($something) on an Activity subclass that doesn't override update_url(), then PHP will silently accept it and assume you're doing a variable-length argument list ( http://php.net/manual/en/functions.arguments.php#functions.variable-arg- list ). In PHP 5.5 it won't even print an E_STRICT warning or anything. In PHP 5.6 and up, it might, since they've added the "..." syntax to explicitly indicate a variable-length argument list. The bigger problem here is the mismatch in the signature of the update_url() method between Activity and its subclasses. That will throw an E_STRICT warning in PHP 5, but it's a fatal error in PHP 7. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1605127 Title: Mismatched function declaration, urdate_url() in lib/activity.php Status in Mahara: In Progress Status in Mahara 15.04 series: In Progress Status in Mahara 15.10 series: In Progress Status in Mahara 16.04 series: In Progress Status in Mahara 16.10 series: In Progress Bug description: Branch 16.04 In lib/activity.php at approx line 710 the function update_url() is declared. It has no parameters. However, at approx line 750 it is called and a parameter ($userdata->internalid) is used. One of them must be wrong, surely? To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1605127/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1605127] Re: Mismatched function declaration, urdate_url() in lib/activity.php
** Tags added: php7 ** Also affects: mahara/15.04 Importance: Undecided Status: New ** Also affects: mahara/16.10 Importance: Undecided Status: New ** Also affects: mahara/16.04 Importance: Undecided Status: New ** Also affects: mahara/15.10 Importance: Undecided Status: New ** Changed in: mahara/15.04 Milestone: None => 15.04.9 ** Changed in: mahara/15.10 Milestone: None => 15.10.5 ** Changed in: mahara/16.04 Milestone: None => 16.04.3 ** Changed in: mahara/16.10 Milestone: None => 16.10.0 ** Changed in: mahara/15.04 Importance: Undecided => Medium ** Changed in: mahara/15.10 Importance: Undecided => Medium ** Changed in: mahara/16.04 Importance: Undecided => Medium ** Changed in: mahara/16.10 Importance: Undecided => Medium ** Changed in: mahara/16.10 Status: New => In Progress ** Changed in: mahara/16.04 Status: New => Confirmed ** Changed in: mahara/15.10 Status: New => Confirmed ** Changed in: mahara/15.04 Status: New => Confirmed ** Changed in: mahara/16.10 Assignee: (unassigned) => Aaron Wells (u-aaronw) ** Changed in: mahara/16.04 Assignee: (unassigned) => Aaron Wells (u-aaronw) ** Changed in: mahara/15.10 Assignee: (unassigned) => Aaron Wells (u-aaronw) ** Changed in: mahara/15.04 Assignee: (unassigned) => Aaron Wells (u-aaronw) ** Changed in: mahara/16.04 Status: Confirmed => In Progress ** Changed in: mahara/15.10 Status: Confirmed => In Progress ** Changed in: mahara/15.04 Status: Confirmed => In Progress -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1605127 Title: Mismatched function declaration, urdate_url() in lib/activity.php Status in Mahara: In Progress Status in Mahara 15.04 series: In Progress Status in Mahara 15.10 series: In Progress Status in Mahara 16.04 series: In Progress Status in Mahara 16.10 series: In Progress Bug description: Branch 16.04 In lib/activity.php at approx line 710 the function update_url() is declared. It has no parameters. However, at approx line 750 it is called and a parameter ($userdata->internalid) is used. One of them must be wrong, surely? To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1605127/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1605127] A patch has been submitted for review
Patch for "master" branch: https://reviews.mahara.org/6744 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1605127 Title: Mismatched function declaration, urdate_url() in lib/activity.php Status in Mahara: In Progress Status in Mahara 15.04 series: In Progress Status in Mahara 15.10 series: In Progress Status in Mahara 16.04 series: In Progress Status in Mahara 16.10 series: In Progress Bug description: Branch 16.04 In lib/activity.php at approx line 710 the function update_url() is declared. It has no parameters. However, at approx line 750 it is called and a parameter ($userdata->internalid) is used. One of them must be wrong, surely? To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1605127/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1605072] Re: Attempting to upload a folder fails with the error
Oh. Looks like i was looking at the wrong branch. I'm going to work on this bug. Do you think's a good idea to update the library first and then patch it to implement more polite error message? ** Changed in: mahara Assignee: (unassigned) => Dmitrii Metelkin (dmitriim) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1605072 Title: Attempting to upload a folder fails with the error Status in Mahara: Confirmed Bug description: - exact version of Mahara - master - operating system - Linux, OSX - database - Postgres - browser and version - Safari (v. 9.1.1) and Firefox (v.47.0.1) Test scenario: 1. Login to ePortfolio, go to Content > Files 2. Drag a folder from your file manager to the ‘Drop files her to upload’ region Expected: all files in the folder uploaded Actual result: Error “Server responded with 0 code.[object XMLHttpRequest]” To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1605072/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1594298] A patch has been submitted for review
Patch for "master" branch: https://reviews.mahara.org/6745 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1594298 Title: MNet site name is hidden behind profile icon Status in Mahara: Confirmed Bug description: When a site has a longer Moodle site name, then it is hidden behind the profile icon in the sidebar (see attached screenshot). To replicate: 1. Set up an institution with MNet. 2. Give the longer site name. 3. Log in from Moodle via MNet. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1594298/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1606086] [NEW] Upgrade dropzone.js to v.4.3.0
Public bug reported: Upgrade dropzone.js from the current 4.2.0 to the latest release 4.3.0, which came out in Feb 2016. https://github.com/enyo/dropzone ** Affects: mahara Importance: Undecided Assignee: Dmitrii Metelkin (dmitriim) Status: New ** Changed in: mahara Assignee: (unassigned) => Dmitrii Metelkin (dmitriim) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1606086 Title: Upgrade dropzone.js to v.4.3.0 Status in Mahara: New Bug description: Upgrade dropzone.js from the current 4.2.0 to the latest release 4.3.0, which came out in Feb 2016. https://github.com/enyo/dropzone To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1606086/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1605072] Re: Attempting to upload a folder fails with the error
This should be implemented after https://bugs.launchpad.net/mahara/+bug/1606086 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1605072 Title: Attempting to upload a folder fails with the error Status in Mahara: Confirmed Bug description: - exact version of Mahara - master - operating system - Linux, OSX - database - Postgres - browser and version - Safari (v. 9.1.1) and Firefox (v.47.0.1) Test scenario: 1. Login to ePortfolio, go to Content > Files 2. Drag a folder from your file manager to the ‘Drop files her to upload’ region Expected: all files in the folder uploaded Actual result: Error “Server responded with 0 code.[object XMLHttpRequest]” To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1605072/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1606086] Re: Upgrade dropzone.js to v.4.3.0
** Changed in: mahara Status: New => In Progress -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1606086 Title: Upgrade dropzone.js to v.4.3.0 Status in Mahara: In Progress Bug description: Upgrade dropzone.js from the current 4.2.0 to the latest release 4.3.0, which came out in Feb 2016. https://github.com/enyo/dropzone To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1606086/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1606086] A patch has been submitted for review
Patch for "master" branch: https://reviews.mahara.org/6746 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1606086 Title: Upgrade dropzone.js to v.4.3.0 Status in Mahara: In Progress Bug description: Upgrade dropzone.js from the current 4.2.0 to the latest release 4.3.0, which came out in Feb 2016. https://github.com/enyo/dropzone To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1606086/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1606094] [NEW] Changing the file quota for users in an institution, can send notifications to users in other institutions
Public bug reported: On the institution config screen, there's a setting called "Update user quotas" that will do a one-time application of the institution's current "default quota" value to all existing users of the institution. At the same time, if you're using the "quota almost exceeded" notification emails, it will check each user whose quota has just been changed and send them a notification if they're near the threshold. The first part of this works fine. It does indeed update the quota for members of the changed institution, and nobody else. But there's a bug in the second part, that sends out the notifications. Instead of only checking the users in the institution, it checks *every* user in the site, and sends a notification to any of them who are near the threshold for the changed institution. This is not only annoying to users who aren't in the institution, but also confusing, because the email will tell them that their quota is the size of the changed institution's quota, when in fact their quota has not changed. To replicate: 1. Clean Mahara install 2. Log in as admin 3. Upload a 1MB file into your File -> Contents area 4. Create an institution. Save the institution. 5. Click the "edit" link for the institution. 6. Set "Default quota" to 100 Kilobytes. 7. Set "Update user quotas" to "On" 8. Click "Submit" Expected result: The admin user should not receive a notification, because they're not in that institution and their quota has not changed. Actual result: The admin user receives a notification about being over their quota, but their quota has not actually changed from the default 50MB. ** Affects: mahara Importance: High Assignee: Aaron Wells (u-aaronw) Status: In Progress ** Affects: mahara/15.04 Importance: High Assignee: Aaron Wells (u-aaronw) Status: In Progress ** Affects: mahara/15.10 Importance: High Assignee: Aaron Wells (u-aaronw) Status: In Progress ** Affects: mahara/16.04 Importance: High Assignee: Aaron Wells (u-aaronw) Status: In Progress ** Affects: mahara/16.10 Importance: High Assignee: Aaron Wells (u-aaronw) Status: In Progress ** Also affects: mahara/15.10 Importance: Undecided Status: New ** Also affects: mahara/15.04 Importance: Undecided Status: New ** Also affects: mahara/16.10 Importance: Undecided Status: New ** Also affects: mahara/16.04 Importance: Undecided Status: New ** Changed in: mahara/15.04 Status: New => In Progress ** Changed in: mahara/15.10 Status: New => In Progress ** Changed in: mahara/16.04 Status: New => In Progress ** Changed in: mahara/16.10 Status: New => In Progress ** Changed in: mahara/15.04 Importance: Undecided => High ** Changed in: mahara/15.10 Importance: Undecided => High ** Changed in: mahara/16.04 Importance: Undecided => High ** Changed in: mahara/16.10 Importance: Undecided => High ** Changed in: mahara/15.04 Assignee: (unassigned) => Aaron Wells (u-aaronw) ** Changed in: mahara/15.10 Assignee: (unassigned) => Aaron Wells (u-aaronw) ** Changed in: mahara/16.04 Assignee: (unassigned) => Aaron Wells (u-aaronw) ** Changed in: mahara/16.10 Assignee: (unassigned) => Aaron Wells (u-aaronw) ** Changed in: mahara/16.10 Milestone: None => 16.10.0 ** Changed in: mahara/16.04 Milestone: None => 16.04.3 ** Changed in: mahara/15.10 Milestone: None => 15.10.5 ** Changed in: mahara/15.04 Milestone: None => 15.04.9 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1606094 Title: Changing the file quota for users in an institution, can send notifications to users in other institutions Status in Mahara: In Progress Status in Mahara 15.04 series: In Progress Status in Mahara 15.10 series: In Progress Status in Mahara 16.04 series: In Progress Status in Mahara 16.10 series: In Progress Bug description: On the institution config screen, there's a setting called "Update user quotas" that will do a one-time application of the institution's current "default quota" value to all existing users of the institution. At the same time, if you're using the "quota almost exceeded" notification emails, it will check each user whose quota has just been changed and send them a notification if they're near the threshold. The first part of this works fine. It does indeed update the quota for members of the changed institution, and nobody else. But there's a bug in the second part, that sends out the notifications. Instead of only checking the users in the institution, it checks *every* user in the site, and sends a notification to any of them wh
[Mahara-contributors] [Bug 1594081] A patch has been submitted for review
Patch for "master" branch: https://reviews.mahara.org/6747 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1594081 Title: Tag links in customizable theme have different link color Status in Mahara: Confirmed Bug description: When a page has tags, the link color is different to the normal link color in the customizable theme. See attachment: The link color in the customizable theme is blue, but the tag link color is default green. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1594081/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1606094] A patch has been submitted for review
Patch for "master" branch: https://reviews.mahara.org/6748 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1606094 Title: Changing the file quota for users in an institution, can send notifications to users in other institutions Status in Mahara: In Progress Status in Mahara 15.04 series: In Progress Status in Mahara 15.10 series: In Progress Status in Mahara 16.04 series: In Progress Status in Mahara 16.10 series: In Progress Bug description: On the institution config screen, there's a setting called "Update user quotas" that will do a one-time application of the institution's current "default quota" value to all existing users of the institution. At the same time, if you're using the "quota almost exceeded" notification emails, it will check each user whose quota has just been changed and send them a notification if they're near the threshold. The first part of this works fine. It does indeed update the quota for members of the changed institution, and nobody else. But there's a bug in the second part, that sends out the notifications. Instead of only checking the users in the institution, it checks *every* user in the site, and sends a notification to any of them who are near the threshold for the changed institution. This is not only annoying to users who aren't in the institution, but also confusing, because the email will tell them that their quota is the size of the changed institution's quota, when in fact their quota has not changed. To replicate: 1. Clean Mahara install 2. Log in as admin 3. Upload a 1MB file into your File -> Contents area 4. Create an institution. Save the institution. 5. Click the "edit" link for the institution. 6. Set "Default quota" to 100 Kilobytes. 7. Set "Update user quotas" to "On" 8. Click "Submit" Expected result: The admin user should not receive a notification, because they're not in that institution and their quota has not changed. Actual result: The admin user receives a notification about being over their quota, but their quota has not actually changed from the default 50MB. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1606094/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1605072] A patch has been submitted for review
Patch for "master" branch: https://reviews.mahara.org/6749 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1605072 Title: Attempting to upload a folder fails with the error Status in Mahara: In Progress Bug description: - exact version of Mahara - master - operating system - Linux, OSX - database - Postgres - browser and version - Safari (v. 9.1.1) and Firefox (v.47.0.1) Test scenario: 1. Login to ePortfolio, go to Content > Files 2. Drag a folder from your file manager to the ‘Drop files her to upload’ region Expected: all files in the folder uploaded Actual result: Error “Server responded with 0 code.[object XMLHttpRequest]” To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1605072/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1605072] Re: Attempting to upload a folder fails with the error
** Changed in: mahara Status: Confirmed => In Progress -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1605072 Title: Attempting to upload a folder fails with the error Status in Mahara: In Progress Bug description: - exact version of Mahara - master - operating system - Linux, OSX - database - Postgres - browser and version - Safari (v. 9.1.1) and Firefox (v.47.0.1) Test scenario: 1. Login to ePortfolio, go to Content > Files 2. Drag a folder from your file manager to the ‘Drop files her to upload’ region Expected: all files in the folder uploaded Actual result: Error “Server responded with 0 code.[object XMLHttpRequest]” To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1605072/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1606101] [NEW] LDAP user sync using root ID to suspend users
Public bug reported: Mahara: 16.04.2 DB: Postgres OS: Linux There is a bug with the LDAP sync when it is suspending users: htdocs/auth/ldap/cli/sync_users.php The user that is running the cron LDAP sync job is 'root' - has an ID of 0. Mahara updates the suspended user record with the userid that is doing the suspending (i.e. suspendedcusr = 0). When validating if a user record is suspended, we check if the suspending user id is empty. Because the suspending user ID is '0', it thinks that to the suspended user is not suspended - when they should be suspended. ** Affects: mahara Importance: Undecided Status: New -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1606101 Title: LDAP user sync using root ID to suspend users Status in Mahara: New Bug description: Mahara: 16.04.2 DB: Postgres OS: Linux There is a bug with the LDAP sync when it is suspending users: htdocs/auth/ldap/cli/sync_users.php The user that is running the cron LDAP sync job is 'root' - has an ID of 0. Mahara updates the suspended user record with the userid that is doing the suspending (i.e. suspendedcusr = 0). When validating if a user record is suspended, we check if the suspending user id is empty. Because the suspending user ID is '0', it thinks that to the suspended user is not suspended - when they should be suspended. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1606101/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1393552] Re: Simple text box doesn't show cursor in Chromium and Chrome
Hi, I did not see the issue on both Chrome(51.0.2704.106 (64-bit)) and Chromium(50.0.2661.102 Ubuntu 14.04 (64-bit)). -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1393552 Title: Simple text box doesn't show cursor in Chromium and Chrome Status in Mahara: Confirmed Status in Mahara 15.04 series: Confirmed Status in Mahara 15.10 series: Confirmed Status in Mahara 16.04 series: Confirmed Bug description: When having a simple text box, e.g. collection description, anonymous feedback, the cursor is not shown in Chrome and Chromium. I have it without problems in Firefox. You can still type in Chrome and Chromium, but just don't see the cursor. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1393552/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1606101] A patch has been submitted for review
Patch for "master" branch: https://reviews.mahara.org/6750 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1606101 Title: LDAP user sync using root ID to suspend users Status in Mahara: New Bug description: Mahara: 16.04.2 DB: Postgres OS: Linux There is a bug with the LDAP sync when it is suspending users: htdocs/auth/ldap/cli/sync_users.php The user that is running the cron LDAP sync job is 'root' - has an ID of 0. Mahara updates the suspended user record with the userid that is doing the suspending (i.e. suspendedcusr = 0). When validating if a user record is suspended, we check if the suspending user id is empty. Because the suspending user ID is '0', it thinks that to the suspended user is not suspended - when they should be suspended. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1606101/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1606101] Re: LDAP user sync using root ID to suspend users
To restate the problem here:
1. The LDAP sync cron task can be configured to suspend users. It does
so using the function "suspend_user()" in user.php
2. When you suspend a user, there's a column, "usr.suspendingcusr",
which is meant to record the user ID of the user who performed the
suspension.
3. If you don't provide the suspending user's ID when you call
suspend_user(), it defaults to $USER->get('id').
4. That's what happens when you run the LDAP sync cron. And since it
runs via CLI, $USER->get('id') is "0". So "usr.suspendingcusr" is set to
0.
5. A lot of existing code throughout Mahara checks to see whether a user
is suspended, by doing "if ($usr->suspendingcusr)" or "if
(!empty($usr->suspendingcusr))".
6. The value of 0 passes both those checks, hence that existing code
treats the user as if they were *not* suspended.
Now, we could go through the code and change all those places that check
whether a user is suspended, so that they use usr.suspendedctime instead. But I
think it will be less bug-prone if we instead change what we're storing from 0
to a negative number. That will pass the boolean checks, while still giving us
a way to see that someone was suspended by a cron task.
The one wrinkle there is that suspend_user(), in generating the
suspension notification message, runs display_name() on the suspending
user's ID. And display_name() throws an InvalidArgumentException if you
pass in the ID of a user who doesn't exist. But we can patch
suspend_user() to take care of that.
** Changed in: mahara
Importance: Undecided => Medium
** Changed in: mahara
Milestone: None => 16.10.0
** Changed in: mahara
Status: New => In Progress
** Changed in: mahara
Assignee: (unassigned) => Aaron Wells (u-aaronw)
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1606101
Title:
LDAP user sync using root ID to suspend users
Status in Mahara:
In Progress
Bug description:
Mahara: 16.04.2
DB: Postgres
OS: Linux
There is a bug with the LDAP sync when it is suspending users:
htdocs/auth/ldap/cli/sync_users.php
The user that is running the cron LDAP sync job is 'root' - has an ID
of 0.
Mahara updates the suspended user record with the userid that is doing
the suspending (i.e. suspendedcusr = 0).
When validating if a user record is suspended, we check if the
suspending user id is empty. Because the suspending user ID is '0', it
thinks that to the suspended user is not suspended - when they should
be suspended.
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1606101/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1393552] Re: Simple text box doesn't show cursor in Chromium and Chrome
I did not see the issue on both Google Chrome40 and 43 (tested via Saucelab) when I tested in Mahara 16.04 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1393552 Title: Simple text box doesn't show cursor in Chromium and Chrome Status in Mahara: Confirmed Status in Mahara 15.04 series: Confirmed Status in Mahara 15.10 series: Confirmed Status in Mahara 16.04 series: Confirmed Bug description: When having a simple text box, e.g. collection description, anonymous feedback, the cursor is not shown in Chrome and Chromium. I have it without problems in Firefox. You can still type in Chrome and Chromium, but just don't see the cursor. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1393552/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1606101] Re: LDAP user sync using root ID to suspend users
Abandoned patch 6750 after discussing it with Ghada, who has convinced me that putting an invalid user ID in that column creates too many potential bugs. So right now our options are: 1. Arbitrarily pick one of the site admin users, and use their ID as the suspendedcusr. 2. Locate every place that checks (bool) usr.suspendedcusr, and change it to check (bool) usr.suspendedctime instead. Option 1 is easier, but it has the nasty side effect that, well, we're arbitrarily picking one admin user and very rarely using them as the suspendedcusr. The name of that admin user is included in the message that gets sent to the suspended user, and so depending on how things are set up in that site, this could cause confusion. (Like, "Why did Tony suspend me?"). Option 2 would be cleaner. Or better yet, add a "usr.suspended" column, which is 0 or 1, and check that instead. That would prevent future devs from accidentally going back to relying on suspendedcusr. But the downside to 2, is that suspendedcusr shows up 27 different times throughout the code, and sometimes does double-duty as a boolean and as the ID of the suspending user, in ways that may be tricky to debug and test. So maybe, since the LDAP sync is the only way this situation comes up, it would be best to just stick with the low-effort Option 1? -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1606101 Title: LDAP user sync using root ID to suspend users Status in Mahara: In Progress Bug description: Mahara: 16.04.2 DB: Postgres OS: Linux There is a bug with the LDAP sync when it is suspending users: htdocs/auth/ldap/cli/sync_users.php The user that is running the cron LDAP sync job is 'root' - has an ID of 0. Mahara updates the suspended user record with the userid that is doing the suspending (i.e. suspendedcusr = 0). When validating if a user record is suspended, we check if the suspending user id is empty. Because the suspending user ID is '0', it thinks that to the suspended user is not suspended - when they should be suspended. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1606101/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
