[Mahara-contributors] [Bug 1605127] Re: Mismatched function declaration, urdate_url() in lib/activity.php

2016-07-29 Thread Kristina Hoeppner
Fantastic, Howard!

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1605127

Title:
  Mismatched function declaration, urdate_url() in lib/activity.php

Status in Mahara:
  In Progress
Status in Mahara 15.04 series:
  In Progress
Status in Mahara 15.10 series:
  In Progress
Status in Mahara 16.04 series:
  In Progress
Status in Mahara 16.10 series:
  In Progress

Bug description:
  Branch 16.04

  In lib/activity.php at approx line 710 the function update_url() is
  declared. It has no parameters.

  However, at approx line 750 it is called and a parameter
  ($userdata->internalid) is used. One of them must be wrong, surely?

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1605127/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1605127] Re: Mismatched function declaration, urdate_url() in lib/activity.php

2016-07-29 Thread Howard Miller
Ye-es but it might take me a few days to get to.

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1605127

Title:
  Mismatched function declaration, urdate_url() in lib/activity.php

Status in Mahara:
  In Progress
Status in Mahara 15.04 series:
  In Progress
Status in Mahara 15.10 series:
  In Progress
Status in Mahara 16.04 series:
  In Progress
Status in Mahara 16.10 series:
  In Progress

Bug description:
  Branch 16.04

  In lib/activity.php at approx line 710 the function update_url() is
  declared. It has no parameters.

  However, at approx line 750 it is called and a parameter
  ($userdata->internalid) is used. One of them must be wrong, surely?

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1605127/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1594298] Re: MNet site name is hidden behind profile icon

2016-07-29 Thread Kristina Hoeppner
** Changed in: mahara
 Assignee: Liam (liam-sharpe) => Pat (pat-kira)

** Changed in: mahara
   Status: Confirmed => In Progress

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1594298

Title:
  MNet site name is hidden behind profile icon

Status in Mahara:
  In Progress

Bug description:
  When a site has a longer Moodle site name, then it is hidden behind
  the profile icon in the sidebar (see attached screenshot).

  To replicate:
  1. Set up an institution with MNet.
  2. Give the longer site name.
  3. Log in from Moodle via MNet.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1594298/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1607745] [NEW] Choose page when uploading / creating evidence

2016-07-29 Thread Kristina Hoeppner
Public bug reported:

When users want to create a portfolio for assessment purposes for
example, and need to put all their evidence for 1 competency standard on
a page, it can be cumbersome to find that evidence. They can use the tag
search to find the evidence, but then need to go to the actual page in
order to add it to the page. Being able to specify the page directly
would help also for mobile uploads and streamline the portfolio creation
process.

The idea had come up to add all evidence tagged with a particular tag to
a specific page automatically. This could be problematic though because
at some point users may not want more evidence added, or they had
removed specific evidence explicitely from the page and don't want it to
come back. Also when the page has been layed out already, adding
evidence automatically wouldn't be so good.

There are a couple of other possibilities:

1. Have a bulk option in the tag search so you can select the artefacts
that you wish to add to a particular page.

2. Have a field similar to the tag search where you can select the
page(s) to which you want to add the evidence that you are currently
viewing.

** Affects: mahara
 Importance: Wishlist
 Status: Confirmed


** Tags: assessment usability

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1607745

Title:
  Choose page when uploading / creating evidence

Status in Mahara:
  Confirmed

Bug description:
  When users want to create a portfolio for assessment purposes for
  example, and need to put all their evidence for 1 competency standard
  on a page, it can be cumbersome to find that evidence. They can use
  the tag search to find the evidence, but then need to go to the actual
  page in order to add it to the page. Being able to specify the page
  directly would help also for mobile uploads and streamline the
  portfolio creation process.

  The idea had come up to add all evidence tagged with a particular tag
  to a specific page automatically. This could be problematic though
  because at some point users may not want more evidence added, or they
  had removed specific evidence explicitely from the page and don't want
  it to come back. Also when the page has been layed out already, adding
  evidence automatically wouldn't be so good.

  There are a couple of other possibilities:

  1. Have a bulk option in the tag search so you can select the
  artefacts that you wish to add to a particular page.

  2. Have a field similar to the tag search where you can select the
  page(s) to which you want to add the evidence that you are currently
  viewing.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1607745/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1605127] Re: Mismatched function declaration, urdate_url() in lib/activity.php

2016-07-29 Thread Kristina Hoeppner
Howard, would it be possible for you then to test and verify the patch?

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1605127

Title:
  Mismatched function declaration, urdate_url() in lib/activity.php

Status in Mahara:
  In Progress
Status in Mahara 15.04 series:
  In Progress
Status in Mahara 15.10 series:
  In Progress
Status in Mahara 16.04 series:
  In Progress
Status in Mahara 16.10 series:
  In Progress

Bug description:
  Branch 16.04

  In lib/activity.php at approx line 710 the function update_url() is
  declared. It has no parameters.

  However, at approx line 750 it is called and a parameter
  ($userdata->internalid) is used. One of them must be wrong, surely?

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1605127/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1603294] Re: Licenses: Once you've selected a license, you can't go back to "None"

2016-07-29 Thread Kristina Hoeppner
There is another scenario to test with the patch:

1. Set up an institution and select "Copyright"
Expected result now with the patch: You can select it.
Actual result: You can't select it.

now continuing with not having been able to choose "Copyright" as
institution license but just a CC license:

2. Log in as a user of that institution.
3. Go to your account settings and change your default license to "Copyright".
Expected result: You can see "Copyright" and select it.
Actual result: "Copyright" is not available as option.

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1603294

Title:
  Licenses: Once you've selected a license, you can't go back to "None"

Status in Mahara:
  In Progress

Bug description:
  While testing out Bug 1279526, I noticed that you can't change an
  uploaded file from a particular license to "No License". This may have
  been by design, with the idea that "No License" was a temporary thing
  until you pick a license. But with Bug 1279526 we're changing the
  wording of "No License" to make it clear that if you're not choosing a
  particular license, then the default copyright rules apply, so it
  becomes more necessary to be able to switch to that.

  To replicate:

  1. Go to "Administration -> Configure Site -> General Settings", and
  enable "License metadata"

  2. Go to "Content -> Files" and upload a file.

  3. Once the file is uploaded, click the pencil "edit" button to open
  its editing form. It should be at "No license" or the equivalent.
  Change it to "Creative Commons Attribution 4.0"

  4. Click "Save changes"

  5. Now click the pencil "edit" button again. Change the License back
  to "No license" or the equivalent.

  6. Again click "Save changes"

  7. Again click the pencil "edit" button.

  Expected result: You see "No license" or the equivalent as the license
  selection.

  Actual result: You see "Creative Commons Attribution 4.0" as the
  license selection.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1603294/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1605127] Re: Mismatched function declaration, urdate_url() in lib/activity.php

2016-07-29 Thread Howard Miller
We saw it upgrading (command line with debugging up full) from 15.04 to
16.04. Loads of warnings towards the start of the upgrade.

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1605127

Title:
  Mismatched function declaration, urdate_url() in lib/activity.php

Status in Mahara:
  In Progress
Status in Mahara 15.04 series:
  In Progress
Status in Mahara 15.10 series:
  In Progress
Status in Mahara 16.04 series:
  In Progress
Status in Mahara 16.10 series:
  In Progress

Bug description:
  Branch 16.04

  In lib/activity.php at approx line 710 the function update_url() is
  declared. It has no parameters.

  However, at approx line 750 it is called and a parameter
  ($userdata->internalid) is used. One of them must be wrong, surely?

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1605127/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1594298] Re: MNet site name is hidden behind profile icon

2016-07-29 Thread Kristina Hoeppner
The patch doesn't quite resolve it yet. There is still an issue when
viewed in Firefox.

** Attachment added: "mnet.png"
   
https://bugs.launchpad.net/mahara/+bug/1594298/+attachment/4709353/+files/mnet.png

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1594298

Title:
  MNet site name is hidden behind profile icon

Status in Mahara:
  In Progress

Bug description:
  When a site has a longer Moodle site name, then it is hidden behind
  the profile icon in the sidebar (see attached screenshot).

  To replicate:
  1. Set up an institution with MNet.
  2. Give the longer site name.
  3. Log in from Moodle via MNet.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1594298/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1605127] Re: Mismatched function declaration, urdate_url() in lib/activity.php

2016-07-29 Thread Kristina Hoeppner
Howe would I test this patch on the front-end, please?

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1605127

Title:
  Mismatched function declaration, urdate_url() in lib/activity.php

Status in Mahara:
  In Progress
Status in Mahara 15.04 series:
  In Progress
Status in Mahara 15.10 series:
  In Progress
Status in Mahara 16.04 series:
  In Progress
Status in Mahara 16.10 series:
  In Progress

Bug description:
  Branch 16.04

  In lib/activity.php at approx line 710 the function update_url() is
  declared. It has no parameters.

  However, at approx line 750 it is called and a parameter
  ($userdata->internalid) is used. One of them must be wrong, surely?

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1605127/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1607669] A patch has been submitted for review

2016-07-29 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/6758

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1607669

Title:
  LDAP user sync incorrectly proceeds when LDAP list or search fails

Status in Mahara:
  Confirmed

Bug description:
  Mahara: 16.04
  DB: Postgres
  OS: Linux

  The LDAP user sync is incorrectly continuing when the search in the
  context fails to contact the server.

  The following error is generated in the cron.log file:

  Jul 29 00:01:05 server mahara-site: [WAR] 29 (auth/ldap/lib.php:937) 
ldap_list(): Search: Can't contact LDAP server
  Jul 29 00:01:05 server mahara-site: Call stack (most recent first):
  Jul 29 00:01:05 server mahara-site:   * log_message("ldap_list(): Search: 
Can't contact LDAP server", 8, true, true, 
"/var/www/mahara-site/auth/ldap/lib.php", 937)
   at /var/www/mahara-site/lib/errors.php:489
  Jul 29 00:01:05 server mahara-site:   * error(2, "ldap_list(): Search: Can't 
contact LDAP server", "/var/www/mahara-site/auth/ldap/lib.php", 937, array(size 
11)) a
  t Unknown:0
  Jul 29 00:01:05 server mahara-site:   * ldap_list(resource(#87), 
"ou=people,o=ldapserver.xxx", "(uid=*)", array(size 5)) at 
/var/www/mahara-site/auth/ldap/lib.php:937
  Jul 29 00:01:05 server mahara-site:   * 
AuthLdap->ldap_get_users_scalable("auth_ldap_extusers_temp", "extusername", "") 
at /var/www/mahara-site/auth/ldap/lib.php:1
  121
  Jul 29 00:01:05 server mahara-site:   * AuthLdap->sync_users() at 
/var/www/mahara-site/auth/ldap/lib.php:1614
  Jul 29 00:01:05 server mahara-site:   * PluginAuthLdap::auth_ldap_sync_cron() 
at Unknown:0
  Jul 29 00:01:05 server mahara-site:   * call_user_func_array(array(size 2), 
array(size 0)) at /var/www/mahara-site/lib/mahara.php:1714
  Jul 29 00:01:05 server mahara-site:   * call_static_method("PluginAuthLdap", 
"auth_ldap_sync_cron") at /var/www/mahara-site/lib/cron.php:89


  It then proceeds to sync the users:

  Jul 29 00:01:05 server mahara-site: [WAR] 29 (auth/ldap/lib.php:940) 
ldap_first_entry() expects parameter 2 to be resource, boolean given
  Jul 29 00:01:05 server mahara-site: Call stack (most recent first):
  Jul 29 00:01:05 server mahara-site:   * log_message("ldap_first_entry() 
expects parameter 2 to be resou...", 8, true, true, 
"/var/www/mahara-site/auth/ldap/lib.php
  ", 940) at /var/www/mahara-site/lib/errors.php:489
  Jul 29 00:01:05 server mahara-site:   * error(2, "ldap_first_entry() expects 
parameter 2 to be resou...", "/var/www/mahara-site/auth/ldap/lib.php", 940, 
array(size
   12)) at Unknown:0
  Jul 29 00:01:05 server mahara-site:   * ldap_first_entry(resource(#87), 
false) at /var/www/mahara-site/auth/ldap/lib.php:940
  Jul 29 00:01:05 server mahara-site:   * 
AuthLdap->ldap_get_users_scalable("auth_ldap_extusers_temp", "extusername", "") 
at /var/www/mahara-site/auth/ldap/lib.php:1121
  Jul 29 00:01:05 server mahara-site:   * AuthLdap->sync_users() at 
/var/www/mahara-site/auth/ldap/lib.php:1614
  Jul 29 00:01:05 server mahara-site:   * PluginAuthLdap::auth_ldap_sync_cron() 
at Unknown:0
  Jul 29 00:01:05 server mahara-site:   * call_user_func_array(array(size 2), 
array(size 0)) at /var/www/mahara-site/lib/mahara.php:1714
  Jul 29 00:01:05 server mahara-site:   * call_static_method("PluginAuthLdap", 
"auth_ldap_sync_cron") at /var/www/mahara-site/lib/cron.php:89
  Jul 29 00:01:05 server mahara-site: 
  Jul 29 00:01:05 server mahara-site: [WAR] 29 (auth/ldap/lib.php:971) 
ldap_free_result() expects parameter 1 to be resource, boolean given
  Jul 29 00:01:05 server mahara-site: Call stack (most recent first):
  Jul 29 00:01:05 server mahara-site:   * log_message("ldap_free_result() 
expects parameter 1 to be resou...", 8, true, true, 
"/var/www/mahara-site/auth/ldap/lib.php", 971) at 
/var/www/mahara-site/lib/errors.php:489
  Jul 29 00:01:05 server mahara-site:   * error(2, "ldap_free_result() expects 
parameter 1 to be resou...", "/var/www/mahara-site/auth/ldap/lib.php", 971, 
array(size 13)) at Unknown:0
  Jul 29 00:01:05 server mahara-site:   * ldap_free_result(false) at 
/var/www/mahara-site/auth/ldap/lib.php:971
  Jul 29 00:01:05 server mahara-site:   * 
AuthLdap->ldap_get_users_scalable("auth_ldap_extusers_temp", "extusername", "") 
at /var/www/mahara-site/auth/ldap/lib.php:1121
  Jul 29 00:01:05 server mahara-site:   * AuthLdap->sync_users() at 
/var/www/mahara-site/auth/ldap/lib.php:1614
  Jul 29 00:01:05 server mahara-site:   * PluginAuthLdap::auth_ldap_sync_cron() 
at Unknown:0
  Jul 29 00:01:05 server mahara-site:   * call_user_func_array(array(size 2), 
array(size 0)) at /var/www/mahara-site/lib/mahara.php:1714
  Jul 29 00:01:05 server mahara-site:   * call_static_method("PluginAuthLdap", 
"auth_ldap_sync_cron") at 

[Mahara-contributors] [Bug 1606752] Re: Attempting to upload a folder fails with unclear error in Safari only

2016-07-29 Thread Kristina Hoeppner
** Tags added: usermanualupdate

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1606752

Title:
  Attempting to upload a folder fails with unclear error in Safari only

Status in Mahara:
  Fix Committed

Bug description:
  - exact version of Mahara - master
  - operating system - OSX
  - database - Postgres
  - browser and version - Safari (v. 9.1.1)

  Test scenario:

  1. Login to ePortfolio, go to Content > Files
  2. Drag a folder from your file manager to the ‘Drop files her to upload’ 
region

  Expected: "Folder" is a folder. To upload a folder, please create a
  zip archive, upload that, then use the decompress option below.

  Actual result: Error “Server responded with 0 code.[object
  XMLHttpRequest]”

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1606752/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1607538] Re: Can't choose group shortname that is different from group name

2016-07-29 Thread Kristina Hoeppner
This is somewhat related to bug #1603302. From that bug, items 2 and 3
move over here:

2. A common validation function needs to be created so the edit group,
upload csv, and webservice group creation are using the same rules.
Therefore, we won't have multiple validation functions for the same
thing throughout the code.

3. We can eliminate the 'retainshortname' flag as we would have already
validated the shortname if it got to the group_create() function.

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1607538

Title:
  Can't choose group shortname that is different from group name

Status in Mahara:
  Confirmed

Bug description:
  Only affects master 16.10 as it's related to new functionality

  When I try to upload the attached CSV file, I get error messages along
  the lines of the following on master:

  group_create: The supplied shortname 'open' is already taken. This
  shortname 'openmembershipgroup' is available.

  This is a double problem:

  1. The group shortname "open" does not yet exist as it's an empty Mahara site.
  2. I should be able to choose my own shortnames (as long as they really 
haven't been taken) no matter what the actual group name is. 

  Currently, the shortname is just the groupname without capital letters
  and spaces. Nobody would set that up without being given instructions.
  Institutions might choose to use course shortnames as group shortnames
  but have the group titles display something entirely differently, e.g.
  the actual title of the course.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1607538/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1607669] Re: LDAP user sync incorrectly proceeds when LDAP list or search fails

2016-07-29 Thread Kristina Hoeppner
** Changed in: mahara
   Importance: Undecided => Medium

** Changed in: mahara
   Status: New => Confirmed

** Changed in: mahara
Milestone: None => 16.10.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1607669

Title:
  LDAP user sync incorrectly proceeds when LDAP list or search fails

Status in Mahara:
  Confirmed

Bug description:
  Mahara: 16.04
  DB: Postgres
  OS: Linux

  The LDAP user sync is incorrectly continuing when the search in the
  context fails to contact the server.

  The following error is generated in the cron.log file:

  Jul 29 00:01:05 server mahara-site: [WAR] 29 (auth/ldap/lib.php:937) 
ldap_list(): Search: Can't contact LDAP server
  Jul 29 00:01:05 server mahara-site: Call stack (most recent first):
  Jul 29 00:01:05 server mahara-site:   * log_message("ldap_list(): Search: 
Can't contact LDAP server", 8, true, true, 
"/var/www/mahara-site/auth/ldap/lib.php", 937)
   at /var/www/mahara-site/lib/errors.php:489
  Jul 29 00:01:05 server mahara-site:   * error(2, "ldap_list(): Search: Can't 
contact LDAP server", "/var/www/mahara-site/auth/ldap/lib.php", 937, array(size 
11)) a
  t Unknown:0
  Jul 29 00:01:05 server mahara-site:   * ldap_list(resource(#87), 
"ou=people,o=ldapserver.xxx", "(uid=*)", array(size 5)) at 
/var/www/mahara-site/auth/ldap/lib.php:937
  Jul 29 00:01:05 server mahara-site:   * 
AuthLdap->ldap_get_users_scalable("auth_ldap_extusers_temp", "extusername", "") 
at /var/www/mahara-site/auth/ldap/lib.php:1
  121
  Jul 29 00:01:05 server mahara-site:   * AuthLdap->sync_users() at 
/var/www/mahara-site/auth/ldap/lib.php:1614
  Jul 29 00:01:05 server mahara-site:   * PluginAuthLdap::auth_ldap_sync_cron() 
at Unknown:0
  Jul 29 00:01:05 server mahara-site:   * call_user_func_array(array(size 2), 
array(size 0)) at /var/www/mahara-site/lib/mahara.php:1714
  Jul 29 00:01:05 server mahara-site:   * call_static_method("PluginAuthLdap", 
"auth_ldap_sync_cron") at /var/www/mahara-site/lib/cron.php:89


  It then proceeds to sync the users:

  Jul 29 00:01:05 server mahara-site: [WAR] 29 (auth/ldap/lib.php:940) 
ldap_first_entry() expects parameter 2 to be resource, boolean given
  Jul 29 00:01:05 server mahara-site: Call stack (most recent first):
  Jul 29 00:01:05 server mahara-site:   * log_message("ldap_first_entry() 
expects parameter 2 to be resou...", 8, true, true, 
"/var/www/mahara-site/auth/ldap/lib.php
  ", 940) at /var/www/mahara-site/lib/errors.php:489
  Jul 29 00:01:05 server mahara-site:   * error(2, "ldap_first_entry() expects 
parameter 2 to be resou...", "/var/www/mahara-site/auth/ldap/lib.php", 940, 
array(size
   12)) at Unknown:0
  Jul 29 00:01:05 server mahara-site:   * ldap_first_entry(resource(#87), 
false) at /var/www/mahara-site/auth/ldap/lib.php:940
  Jul 29 00:01:05 server mahara-site:   * 
AuthLdap->ldap_get_users_scalable("auth_ldap_extusers_temp", "extusername", "") 
at /var/www/mahara-site/auth/ldap/lib.php:1121
  Jul 29 00:01:05 server mahara-site:   * AuthLdap->sync_users() at 
/var/www/mahara-site/auth/ldap/lib.php:1614
  Jul 29 00:01:05 server mahara-site:   * PluginAuthLdap::auth_ldap_sync_cron() 
at Unknown:0
  Jul 29 00:01:05 server mahara-site:   * call_user_func_array(array(size 2), 
array(size 0)) at /var/www/mahara-site/lib/mahara.php:1714
  Jul 29 00:01:05 server mahara-site:   * call_static_method("PluginAuthLdap", 
"auth_ldap_sync_cron") at /var/www/mahara-site/lib/cron.php:89
  Jul 29 00:01:05 server mahara-site: 
  Jul 29 00:01:05 server mahara-site: [WAR] 29 (auth/ldap/lib.php:971) 
ldap_free_result() expects parameter 1 to be resource, boolean given
  Jul 29 00:01:05 server mahara-site: Call stack (most recent first):
  Jul 29 00:01:05 server mahara-site:   * log_message("ldap_free_result() 
expects parameter 1 to be resou...", 8, true, true, 
"/var/www/mahara-site/auth/ldap/lib.php", 971) at 
/var/www/mahara-site/lib/errors.php:489
  Jul 29 00:01:05 server mahara-site:   * error(2, "ldap_free_result() expects 
parameter 1 to be resou...", "/var/www/mahara-site/auth/ldap/lib.php", 971, 
array(size 13)) at Unknown:0
  Jul 29 00:01:05 server mahara-site:   * ldap_free_result(false) at 
/var/www/mahara-site/auth/ldap/lib.php:971
  Jul 29 00:01:05 server mahara-site:   * 
AuthLdap->ldap_get_users_scalable("auth_ldap_extusers_temp", "extusername", "") 
at /var/www/mahara-site/auth/ldap/lib.php:1121
  Jul 29 00:01:05 server mahara-site:   * AuthLdap->sync_users() at 
/var/www/mahara-site/auth/ldap/lib.php:1614
  Jul 29 00:01:05 server mahara-site:   * PluginAuthLdap::auth_ldap_sync_cron() 
at Unknown:0
  Jul 29 00:01:05 server mahara-site:   * call_user_func_array(array(size 2), 
array(size 0)) at /var/www/mahara-site/lib/mahara.php:1714
  Jul 29 00:01:05 server 

[Mahara-contributors] [Bug 1607669] Re: LDAP user sync incorrectly proceeds when LDAP list or search fails

2016-07-29 Thread Ghada El-Zoghbi
** Changed in: mahara
 Assignee: (unassigned) => Ghada El-Zoghbi (ghada-z)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1607669

Title:
  LDAP user sync incorrectly proceeds when LDAP list or search fails

Status in Mahara:
  New

Bug description:
  Mahara: 16.04
  DB: Postgres
  OS: Linux

  The LDAP user sync is incorrectly continuing when the search in the
  context fails to contact the server.

  The following error is generated in the cron.log file:

  Jul 29 00:01:05 server mahara-site: [WAR] 29 (auth/ldap/lib.php:937) 
ldap_list(): Search: Can't contact LDAP server
  Jul 29 00:01:05 server mahara-site: Call stack (most recent first):
  Jul 29 00:01:05 server mahara-site:   * log_message("ldap_list(): Search: 
Can't contact LDAP server", 8, true, true, 
"/var/www/mahara-site/auth/ldap/lib.php", 937)
   at /var/www/mahara-site/lib/errors.php:489
  Jul 29 00:01:05 server mahara-site:   * error(2, "ldap_list(): Search: Can't 
contact LDAP server", "/var/www/mahara-site/auth/ldap/lib.php", 937, array(size 
11)) a
  t Unknown:0
  Jul 29 00:01:05 server mahara-site:   * ldap_list(resource(#87), 
"ou=people,o=ldapserver.xxx", "(uid=*)", array(size 5)) at 
/var/www/mahara-site/auth/ldap/lib.php:937
  Jul 29 00:01:05 server mahara-site:   * 
AuthLdap->ldap_get_users_scalable("auth_ldap_extusers_temp", "extusername", "") 
at /var/www/mahara-site/auth/ldap/lib.php:1
  121
  Jul 29 00:01:05 server mahara-site:   * AuthLdap->sync_users() at 
/var/www/mahara-site/auth/ldap/lib.php:1614
  Jul 29 00:01:05 server mahara-site:   * PluginAuthLdap::auth_ldap_sync_cron() 
at Unknown:0
  Jul 29 00:01:05 server mahara-site:   * call_user_func_array(array(size 2), 
array(size 0)) at /var/www/mahara-site/lib/mahara.php:1714
  Jul 29 00:01:05 server mahara-site:   * call_static_method("PluginAuthLdap", 
"auth_ldap_sync_cron") at /var/www/mahara-site/lib/cron.php:89


  It then proceeds to sync the users:

  Jul 29 00:01:05 server mahara-site: [WAR] 29 (auth/ldap/lib.php:940) 
ldap_first_entry() expects parameter 2 to be resource, boolean given
  Jul 29 00:01:05 server mahara-site: Call stack (most recent first):
  Jul 29 00:01:05 server mahara-site:   * log_message("ldap_first_entry() 
expects parameter 2 to be resou...", 8, true, true, 
"/var/www/mahara-site/auth/ldap/lib.php
  ", 940) at /var/www/mahara-site/lib/errors.php:489
  Jul 29 00:01:05 server mahara-site:   * error(2, "ldap_first_entry() expects 
parameter 2 to be resou...", "/var/www/mahara-site/auth/ldap/lib.php", 940, 
array(size
   12)) at Unknown:0
  Jul 29 00:01:05 server mahara-site:   * ldap_first_entry(resource(#87), 
false) at /var/www/mahara-site/auth/ldap/lib.php:940
  Jul 29 00:01:05 server mahara-site:   * 
AuthLdap->ldap_get_users_scalable("auth_ldap_extusers_temp", "extusername", "") 
at /var/www/mahara-site/auth/ldap/lib.php:1121
  Jul 29 00:01:05 server mahara-site:   * AuthLdap->sync_users() at 
/var/www/mahara-site/auth/ldap/lib.php:1614
  Jul 29 00:01:05 server mahara-site:   * PluginAuthLdap::auth_ldap_sync_cron() 
at Unknown:0
  Jul 29 00:01:05 server mahara-site:   * call_user_func_array(array(size 2), 
array(size 0)) at /var/www/mahara-site/lib/mahara.php:1714
  Jul 29 00:01:05 server mahara-site:   * call_static_method("PluginAuthLdap", 
"auth_ldap_sync_cron") at /var/www/mahara-site/lib/cron.php:89
  Jul 29 00:01:05 server mahara-site: 
  Jul 29 00:01:05 server mahara-site: [WAR] 29 (auth/ldap/lib.php:971) 
ldap_free_result() expects parameter 1 to be resource, boolean given
  Jul 29 00:01:05 server mahara-site: Call stack (most recent first):
  Jul 29 00:01:05 server mahara-site:   * log_message("ldap_free_result() 
expects parameter 1 to be resou...", 8, true, true, 
"/var/www/mahara-site/auth/ldap/lib.php", 971) at 
/var/www/mahara-site/lib/errors.php:489
  Jul 29 00:01:05 server mahara-site:   * error(2, "ldap_free_result() expects 
parameter 1 to be resou...", "/var/www/mahara-site/auth/ldap/lib.php", 971, 
array(size 13)) at Unknown:0
  Jul 29 00:01:05 server mahara-site:   * ldap_free_result(false) at 
/var/www/mahara-site/auth/ldap/lib.php:971
  Jul 29 00:01:05 server mahara-site:   * 
AuthLdap->ldap_get_users_scalable("auth_ldap_extusers_temp", "extusername", "") 
at /var/www/mahara-site/auth/ldap/lib.php:1121
  Jul 29 00:01:05 server mahara-site:   * AuthLdap->sync_users() at 
/var/www/mahara-site/auth/ldap/lib.php:1614
  Jul 29 00:01:05 server mahara-site:   * PluginAuthLdap::auth_ldap_sync_cron() 
at Unknown:0
  Jul 29 00:01:05 server mahara-site:   * call_user_func_array(array(size 2), 
array(size 0)) at /var/www/mahara-site/lib/mahara.php:1714
  Jul 29 00:01:05 server mahara-site:   * call_static_method("PluginAuthLdap", 
"auth_ldap_sync_cron") at 

[Mahara-contributors] [Bug 1607669] [NEW] LDAP user sync incorrectly proceeds when LDAP list or search fails

2016-07-29 Thread Ghada El-Zoghbi
Public bug reported:

Mahara: 16.04
DB: Postgres
OS: Linux

The LDAP user sync is incorrectly continuing when the search in the
context fails to contact the server.

The following error is generated in the cron.log file:

Jul 29 00:01:05 server mahara-site: [WAR] 29 (auth/ldap/lib.php:937) 
ldap_list(): Search: Can't contact LDAP server
Jul 29 00:01:05 server mahara-site: Call stack (most recent first):
Jul 29 00:01:05 server mahara-site:   * log_message("ldap_list(): Search: Can't 
contact LDAP server", 8, true, true, "/var/www/mahara-site/auth/ldap/lib.php", 
937)
 at /var/www/mahara-site/lib/errors.php:489
Jul 29 00:01:05 server mahara-site:   * error(2, "ldap_list(): Search: Can't 
contact LDAP server", "/var/www/mahara-site/auth/ldap/lib.php", 937, array(size 
11)) a
t Unknown:0
Jul 29 00:01:05 server mahara-site:   * ldap_list(resource(#87), 
"ou=people,o=ldapserver.xxx", "(uid=*)", array(size 5)) at 
/var/www/mahara-site/auth/ldap/lib.php:937
Jul 29 00:01:05 server mahara-site:   * 
AuthLdap->ldap_get_users_scalable("auth_ldap_extusers_temp", "extusername", "") 
at /var/www/mahara-site/auth/ldap/lib.php:1
121
Jul 29 00:01:05 server mahara-site:   * AuthLdap->sync_users() at 
/var/www/mahara-site/auth/ldap/lib.php:1614
Jul 29 00:01:05 server mahara-site:   * PluginAuthLdap::auth_ldap_sync_cron() 
at Unknown:0
Jul 29 00:01:05 server mahara-site:   * call_user_func_array(array(size 2), 
array(size 0)) at /var/www/mahara-site/lib/mahara.php:1714
Jul 29 00:01:05 server mahara-site:   * call_static_method("PluginAuthLdap", 
"auth_ldap_sync_cron") at /var/www/mahara-site/lib/cron.php:89


It then proceeds to sync the users:

Jul 29 00:01:05 server mahara-site: [WAR] 29 (auth/ldap/lib.php:940) 
ldap_first_entry() expects parameter 2 to be resource, boolean given
Jul 29 00:01:05 server mahara-site: Call stack (most recent first):
Jul 29 00:01:05 server mahara-site:   * log_message("ldap_first_entry() expects 
parameter 2 to be resou...", 8, true, true, 
"/var/www/mahara-site/auth/ldap/lib.php
", 940) at /var/www/mahara-site/lib/errors.php:489
Jul 29 00:01:05 server mahara-site:   * error(2, "ldap_first_entry() expects 
parameter 2 to be resou...", "/var/www/mahara-site/auth/ldap/lib.php", 940, 
array(size
 12)) at Unknown:0
Jul 29 00:01:05 server mahara-site:   * ldap_first_entry(resource(#87), false) 
at /var/www/mahara-site/auth/ldap/lib.php:940
Jul 29 00:01:05 server mahara-site:   * 
AuthLdap->ldap_get_users_scalable("auth_ldap_extusers_temp", "extusername", "") 
at /var/www/mahara-site/auth/ldap/lib.php:1121
Jul 29 00:01:05 server mahara-site:   * AuthLdap->sync_users() at 
/var/www/mahara-site/auth/ldap/lib.php:1614
Jul 29 00:01:05 server mahara-site:   * PluginAuthLdap::auth_ldap_sync_cron() 
at Unknown:0
Jul 29 00:01:05 server mahara-site:   * call_user_func_array(array(size 2), 
array(size 0)) at /var/www/mahara-site/lib/mahara.php:1714
Jul 29 00:01:05 server mahara-site:   * call_static_method("PluginAuthLdap", 
"auth_ldap_sync_cron") at /var/www/mahara-site/lib/cron.php:89
Jul 29 00:01:05 server mahara-site: 
Jul 29 00:01:05 server mahara-site: [WAR] 29 (auth/ldap/lib.php:971) 
ldap_free_result() expects parameter 1 to be resource, boolean given
Jul 29 00:01:05 server mahara-site: Call stack (most recent first):
Jul 29 00:01:05 server mahara-site:   * log_message("ldap_free_result() expects 
parameter 1 to be resou...", 8, true, true, 
"/var/www/mahara-site/auth/ldap/lib.php", 971) at 
/var/www/mahara-site/lib/errors.php:489
Jul 29 00:01:05 server mahara-site:   * error(2, "ldap_free_result() expects 
parameter 1 to be resou...", "/var/www/mahara-site/auth/ldap/lib.php", 971, 
array(size 13)) at Unknown:0
Jul 29 00:01:05 server mahara-site:   * ldap_free_result(false) at 
/var/www/mahara-site/auth/ldap/lib.php:971
Jul 29 00:01:05 server mahara-site:   * 
AuthLdap->ldap_get_users_scalable("auth_ldap_extusers_temp", "extusername", "") 
at /var/www/mahara-site/auth/ldap/lib.php:1121
Jul 29 00:01:05 server mahara-site:   * AuthLdap->sync_users() at 
/var/www/mahara-site/auth/ldap/lib.php:1614
Jul 29 00:01:05 server mahara-site:   * PluginAuthLdap::auth_ldap_sync_cron() 
at Unknown:0
Jul 29 00:01:05 server mahara-site:   * call_user_func_array(array(size 2), 
array(size 0)) at /var/www/mahara-site/lib/mahara.php:1714
Jul 29 00:01:05 server mahara-site:   * call_static_method("PluginAuthLdap", 
"auth_ldap_sync_cron") at /var/www/mahara-site/lib/cron.php:89
Jul 29 00:01:05 server mahara-site: 
Jul 29 00:01:05 server mahara-site: [INF] 29 (auth/ldap/lib.php:1122) LDAP 
users found : 0
Jul 29 00:01:05 server mahara-site: [INF] 29 (auth/ldap/lib.php:1169) 0 users 
known to Mahara 
Jul 29 00:01:05 server mahara-site: [INF] 29 (auth/ldap/lib.php:1232) 45161 
users no longer in LDAP 


Because we've set the sync to suspend users, all LDAP users are then
suspended.

** Affects: mahara
 Importance: Undecided
 Assignee: Ghada El-Zoghbi (ghada-z)
 Status: New

-- 
You received this bug