[Mahara-contributors] [Bug 1457709] A change has been merged
Reviewed: https://reviews.mahara.org/6847 Committed: https://git.mahara.org/mahara/mahara/commit/3c7e24e7defe3c3d1a8ec59026d8d05e0cd026b8 Submitter: Aaron Wells (aar...@catalyst.net.nz) Branch:master commit 3c7e24e7defe3c3d1a8ec59026d8d05e0cd026b8 Author: Aaron Wells Date: Thu May 21 14:36:32 2015 +1200 elasticsearch: Add index name to _bulk command path Bug 1457709: We only do this when the command comes from an Index object itself, which means that all the data in the bulk request will have the same index anyway. You'll still need to set rest.action.multi.allow_explicit_index:false in your config.yml, or else the data will be able to override the index name in the URL. See https://www.elastic.co/guide/en/elasticsearch/reference/current/url- access-control.html Conflicts: htdocs/lib/elastica/README.Mahara htdocs/lib/elastica/lib/Elastica/Client.php behatnotneeded: Can't be tested in behat Change-Id: Ide22a0026aeb480a130e39c3ea2f327ef2de167f -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1457709 Title: Elasticsearch plugin doesn't work with URL-based access control Status in Mahara: Fix Committed Status in Mahara 15.10 series: Fix Released Bug description: We changed the Elasticsearch plugin to use the _bulk command to load data into Elasticsearch. But this poses problems for hosting setups that are using URL-based access control, as described here: https://www.elastic.co/guide/en/elasticsearch/reference/1.x/url- access-control.html This is because the way Elastica handles the _bulk command, it puts the index name into the request body: localhost/_bulk, instead of localhost/index/_bulk Elasticsearch *can* handle the indexname in the URL for _bulk commands. But we'll need to patch Elastica to handle it. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1457709/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1613478] A change has been merged
Reviewed: https://reviews.mahara.org/6846 Committed: https://git.mahara.org/mahara/mahara/commit/b47734b005c6bccb925d70929daccbefeb2d9524 Submitter: Aaron Wells (aar...@catalyst.net.nz) Branch:master commit b47734b005c6bccb925d70929daccbefeb2d9524 Author: Son Nguyen Date: Wed Aug 17 14:13:45 2016 +1200 Bug #1613478: Update Elastica library to 2.3.1 behatnotneeded Change-Id: Ieff16099da370e60c3b695c48e65c8282d5aa3c3 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1613478 Title: Update Elastica library to 2.3.1 Status in Mahara: Fix Committed Bug description: The current version of Elastica is 2.0.0, we should update it to 2.3.1 as it has lots of bug fixes and support for newer Elasticsearch 1.7.3+. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1613478/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1613478] Re: Update Elastica library to 2.3.1
** Changed in: mahara Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1613478 Title: Update Elastica library to 2.3.1 Status in Mahara: Fix Committed Bug description: The current version of Elastica is 2.0.0, we should update it to 2.3.1 as it has lots of bug fixes and support for newer Elasticsearch 1.7.3+. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1613478/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1613478] A patch has been submitted for review
Patch for "master" branch: https://reviews.mahara.org/6846 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1613478 Title: Update Elastica library to 2.3.1 Status in Mahara: In Progress Bug description: The current version of Elastica is 2.0.0, we should update it to 2.3.1 as it has lots of bug fixes and support for newer Elasticsearch 1.7.3+. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1613478/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1457709] A patch has been submitted for review
Patch for "master" branch: https://reviews.mahara.org/6847 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1457709 Title: Elasticsearch plugin doesn't work with URL-based access control Status in Mahara: Fix Committed Status in Mahara 15.10 series: Fix Released Bug description: We changed the Elasticsearch plugin to use the _bulk command to load data into Elasticsearch. But this poses problems for hosting setups that are using URL-based access control, as described here: https://www.elastic.co/guide/en/elasticsearch/reference/1.x/url- access-control.html This is because the way Elastica handles the _bulk command, it puts the index name into the request body: localhost/_bulk, instead of localhost/index/_bulk Elasticsearch *can* handle the indexname in the URL for _bulk commands. But we'll need to patch Elastica to handle it. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1457709/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1613480] Re: Update HTML Purifier to 4.8.0
** Changed in: mahara Assignee: (unassigned) => Son Nguyen (ngson2000) ** Changed in: mahara Status: Confirmed => In Progress -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1613480 Title: Update HTML Purifier to 4.8.0 Status in Mahara: In Progress Bug description: We need to update this library to 4.8.0 to compatible to PHP7 To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1613480/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1613483] Re: Update PDFjs to 1.4.20
** Changed in: mahara Assignee: (unassigned) => Son Nguyen (ngson2000) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1613483 Title: Update PDFjs to 1.4.20 Status in Mahara: Confirmed Bug description: Since 1.1.1040, there have been several bug fixes and few features. We would highly update this. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1613483/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1594615] A change has been merged
Reviewed: https://reviews.mahara.org/6674 Committed: https://git.mahara.org/mahara/mahara/commit/4210a108ca1442bfdc3aa2c1c91ec3f49a9d592c Submitter: Aaron Wells (aar...@catalyst.net.nz) Branch:master commit 4210a108ca1442bfdc3aa2c1c91ec3f49a9d592c Author: Son Nguyen Date: Fri Jun 24 09:14:12 2016 +1200 Bug 1594615: Replace PEAR::XML_Feed_Parser Add new class FeedReader Remove PEAR::XML_Feed_Parser Add behat tests for external blocks Change-Id: Idda5bff4624e8400340da22662e3e36296b52090 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1594615 Title: Replace PEAR::XML_Feed_Parser by the PHP XML standard library Status in Mahara: Fix Committed Bug description: Version master(16.10) It would be good to replace PEAR::XML_Feed_Parser by the PHP XML standard library Ref: http://www.the-art-of-web.com/php/feed-reader/ To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1594615/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1613478] Re: Update Elastica library to 2.3.1
** Changed in: mahara Status: Confirmed => In Progress -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1613478 Title: Update Elastica library to 2.3.1 Status in Mahara: In Progress Bug description: The current version of Elastica is 2.0.0, we should update it to 2.3.1 as it has lots of bug fixes and support for newer Elasticsearch 1.7.3+. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1613478/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1594615] Re: Replace PEAR::XML_Feed_Parser by the PHP XML standard library
** Changed in: mahara Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1594615 Title: Replace PEAR::XML_Feed_Parser by the PHP XML standard library Status in Mahara: Fix Committed Bug description: Version master(16.10) It would be good to replace PEAR::XML_Feed_Parser by the PHP XML standard library Ref: http://www.the-art-of-web.com/php/feed-reader/ To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1594615/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1613392] Re: PostgreSQL insert error into site_content with multibyte language packs.
I was finally able to replicate this! I had assumed the "\x..."
formatting in the original error stack was generated by var_dump(), but
then I realized, perhaps that was the actual content of the lang string.
And sure enough, copying the original string with all the "\x..."s in
it, instead of the decoded Japanese glyphs, replicated the error.
And I was able to minimize it down to that suspect \x81\xa7 character.
1. Modify htdocs/lang/en.utf8/install.php so that
'loggedouthomedefaultcontent' is this:
$string['loggedouthomedefaultcontent'] = "\x81\xa7";
2. Log in. Create a new institution.
Expected result: You create a new institution.
Actual result: Error stack containing this message: Failed to get a recordset:
postgres8 error: [-1: ERROR: invalid byte sequence for encoding "UTF8": 0x81]
The error went goes away if you do any of these:
- Replace with "\xe3\x81\xa7" (で) http://www.mclean.net.nz/ucf/?c=U+3067
- Replace with "で"
- Replace with "\xe8\x86\xa7" (膧) http://www.mclean.net.nz/ucf/?c=U+81A7
- Replace with "膧"
So it does seem to be an issue with the lang file itself, not with
Mahara. The code change shouldn't be necessary so long as lang files
contain only valid UTF-8. User input becomes UTF-8 encoded via the
browser, due to the "" tag we put on every page. I suppose there is still the
possibility of data from other sources having incompatible encoding,
like RSS feeds or Leap2a files. But we'll cross that bridge when we come
to it.
Cheers,
Aaron
** Changed in: mahara
Status: Incomplete => Invalid
** Changed in: mahara
Status: Invalid => Won't Fix
** Changed in: mahara
Status: Won't Fix => Invalid
** Changed in: mahara
Status: Invalid => Won't Fix
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1613392
Title:
PostgreSQL insert error into site_content with multibyte language
packs.
Status in Mahara:
Won't Fix
Bug description:
When we try to add a new institution using Japanese language menu, we
have an error message "Mahara: Site unavailable A nonrecoverable error
occurred. This probably means you have encountered a bug in the
system" and can't add the institution.
And Apache error log says as below:
[error] [client xxx.xxx.xxx.xxx] [WAR] 18 (lib/errors.php:820) HINT: This
error can also happen if the byte sequence does not match the encoding expected
by the server, which is controlled by "client_encoding".] in adodb_throw(INSERT
INTO "site_content" ("name", "content", "ctime", "mtime", "institution") VALUES
(?, ?, ?, ?, ?),
home,Mahara\xe3\x81\xab\xe3\x82\x88\xe3\x81\x86\xe3\x81\x93\xe3\x81\x9d[\xe3\x81\x82\xe3\x81\xaa\xe3\x81\x9f\xe3\x81\xae\xe7\xb5\x84\xe7\xb9\x94\xe5\x90\x8d]\xe3\x81\xaf\xe3\x82\xaa\xe3\x83\xb3\xe3\x83\xa9\xe3\x82\xa4\xe3\x83\xb3\xe3\x82\xb3\xe3\x83\x9f\xe3\x83\xa5\xe3\x83\x8b\xe3\x83\x86\xe3\x82\xa3\xe3\x82\x92\xe6\xa7\x8b\xe7\xaf\x89\xe3\x81\x99\xe3\x82\x8b\xe3\x81\x9f\xe3\x82\x81\xe3\x81\xae\xe5\x8d\x81\xe5\x88\x86\xe3\x81\xaa\xe6\xa9\x9f\xe8\x83\xbd\xe3\x82\x92\xe6\x9c\x89\xe3\x81\x99\xe3\x82\x8b\xe3\x82\xa4\xe3\x83\xb3\xe3\x82\xbf\xe3\x83\xbc\xe3\x83\x8d\xe3\x83\x83\xe3\x83\x88\xe4\xb8\x8a\xe3\x81\xae\xe3\x83\x9d\xe3\x83\xbc\xe3\x83\x88\xe3\x83\x95\xe3\x82\xa9\xe3\x83\xaa\xe3\x82\xaa\xe3\x82\xb7\xe3\x82\xb9\xe3\x83\x86\xe3\x83\xa0\xe3\x81\xa7\xe3\x81\x99\xe3\x80\x82Mahara\xe3\x81\xab\xe9\x96\xa2\xe3\x81\x99\xe3\x82\x8b\xe8\xa9\xb3\xe7\xb4\xb0\xe3\x81\xafAbout[\xe3\x81\x93\xe3\x81\xae\xe3\x83\x9a\xe3\x83\xbc\xe3\x82\xb8\xe3\x82\x92\xe5\xbf\x98\xe3\x82\x8c\xe3\x81\x9a\xe3\x81\xab\xe7\xb7\xa8\xe9\x9b\x86\xe3\x81\x97\xe3\x81\xa6\xe3\x81\x8f\xe3\x81\xa0\xe3\x81\x95\xe3\x81\x84]\xe3\x82\x92\xe3\x81\x8a\xe8\xaa\xad\xe3\x81\xbf\xe3\x81\x8f\xe3\x81\xa0\xe3\x81\x95\xe3\x81\x84\xe3\x80\x82\xe3\x81\xbe\xe3\x81\x9f\xe3\x80\x81\xe7\xa7\x81\xe3\x81\x9f\xe3\x81\xa1\xe3\x81\xab\xe3\x81\x8a\xe6\xb0\x97\xe8\xbb\xbd\xe3\x81\xab\xe3\x81\x8a\xe5\x95\x8f\xe3\x81\x84\xe5\x90\x88\xe3\x82\x8f\xe3\x81\x9b\xe3\x81\x8f\xe3\x81\xa0\xe3\x81\x95\xe3\x81\x84\xe3\x80\x82\xe3\x81\x82\xe3\x81\xaa\xe3\x81\x9f\xe3\x81\xaf\xe3\x81\x93\xe3\x81\xae\xe3\x83\x86\xe3\x82\xad\xe3\x82\xb9\xe3\x83\x88\xe3\x82\x92\x81\xa7\xe7\xb7\xa8\xe9\x9b\x86\xe3\x81\x99\xe3\x82\x8b\xe3\x81\x93\xe3\x81\xa8\xe3\x81\x8c\xe3\x81\xa7\xe3\x81\x8d\xe3\x81\xbe\xe3\x81\x99\xe3\x80\x82,2016-08-1512:50:39,2016-08-1512:50:39,inst),
referer: https://mahara.x.com/admin/users/institutions.php
To avoid this error, I would like to recommend to modify lib/dml.php
as below.
File:
lib/dml.php
Line:
1061
[ Before ]
// Pull out data matching these fields
$ddd = array();
foreach ($columns as $column) {
if (isset($data[$column->name])) {
if ($column->name == $primarykey && empty
[Mahara-contributors] [Bug 1612481] Re: "Exact user search" doesn't work intuitively with names containing spaces
Hm, just realize that I accidentally used "||" as both concatenation and OR in the above SQL snippet. What I meant to say was that if you wanted to compare the entire search query against the firstname, lastname, and a concatenation of them both (in both orders to account for internationalization), it'd be something like this: u.firstname = OR u.lastname = OR u.lastname || ' ' || u.firstname = OR u.firstname || ' ' || u.lastname = -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1612481 Title: "Exact user search" doesn't work intuitively with names containing spaces Status in Mahara: Confirmed Bug description: Steps to replicate: Make sure that the setting "Exact user searches" set to Yes on admin/extensions/pluginconfig.php?plugintype=search&pluginname=internal Create a user with multi word lastname, e.g Bla Bla Bla Navigate to /admin/users/search.php Type this in search form: Bla Bla Bla Expected result: User is in the search results, because you've typed their exact last name. Actual result: User is not in the search results Workaround: Enclose the firstname and/or lastname *by itself* in double quotes. e.g., for the user Aaron von Wells, search for: Aaron "von Wells" To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1612481/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1612481] Re: "Exact user search" doesn't work intuitively with names containing spaces
Hi Dmitri,
It worked for me on the admin page. I'll use [square brackets] to
enclose strings below, to try to avoid confusion when I'm talking about
strings that contain double quotes.
1. Clean install of Mahara
2. Log in as admin
3. Go to Content -> Profile and change my first name to: [Ad min]
4. Go to the Administration -> Extensions -> Search/Internal config page and
verify that exact search is on.
5. Go to Administration -> Users -> User search (admin/users/search.php) and
search for ["Ad min"]
Result: The admin user shows up in the search results.
I agree that it's still bad usability, though. I think many users would
expect [ad min user] or ["ad min user"] to work, but in fact you have to
enclose the first name and/or last name *by itself* in quote marks,
which I would probably not have thought of doing, and there isn't even a
help bubble on the page to explain that we support the quote mark search
operator.
Currently the behavior is this:
1. PluginSearchInternal::split_query_string() splits the search query
into search terms. Any quote-enclosed strings become a search term. The
remaining non-quoted text is split up by space characters into separate
search terms.
2. PluginSearchInternal::match_user_field_expression() writes a SQL
expression to compare each applicable database field to each search
term.
2a. If exact search is on, it does an exact match: lower() =
lower()
2b. If exact search is off, it does a wildcard match: lower()
like lower('%%')
So what Kristina said is not exactly true. An "exact search" for [Jon
Smith] will actually pull up Jon Paul, and Mike Smith. It just excludes
Jonathan Smithson.
That said, it's tricky to come up with a way to support [ad min user]
while still honoring the original exact search use case, which I guess
is roughly "Each part of the search query must be an exact match to a
part of the user's name". I can think of two ideas:
1. Robert's suggestion of adding search terms for all adjacent
combinations of space-separated unquoted elements in the query. So [a b
c] would yield these search terms: [a], [b], [c], [a b], [b c], and [a b
c]. The downside is that the number of search terms scales geometrically
with the number of spaces in the search query. Also, it may be tricky to
handle partly-quoted search queries such as [a "b c" d], although that's
a corner case.
2. Compare the entire search query against a concatenation of the
firstname and lastname fields. So the SQL would be something like
"u.firstname = || u.lastname = || u.firstname ||
u.lastname = || u.lastname || u.firstname = ". (For
quoted search terms, we could just remove the quote marks.) This would
be hard to fit into the existing code, though, which handles each search
field quite separately.
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1612481
Title:
"Exact user search" doesn't work intuitively with names containing
spaces
Status in Mahara:
Confirmed
Bug description:
Steps to replicate:
Make sure that the setting "Exact user searches" set to Yes on
admin/extensions/pluginconfig.php?plugintype=search&pluginname=internal
Create a user with multi word lastname, e.g Bla Bla Bla
Navigate to /admin/users/search.php
Type this in search form:
Bla Bla Bla
Expected result: User is in the search results, because you've typed their
exact last name.
Actual result: User is not in the search results
Workaround: Enclose the firstname and/or lastname *by itself* in
double quotes. e.g., for the user Aaron von Wells, search for:
Aaron "von Wells"
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1612481/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1606744] A change has been merged
Reviewed: https://reviews.mahara.org/6806 Committed: https://git.mahara.org/mahara/mahara/commit/cf42e66bb8464f181149165f81c24b8d57e0c45e Submitter: Son Nguyen (son.ngu...@catalyst.net.nz) Branch:master commit cf42e66bb8464f181149165f81c24b8d57e0c45e Author: Robert Lyon Date: Sat Aug 6 13:00:31 2016 +1200 Bug 1606744: Correcting linking 'other' label for pieform select The label tag had an incomplete 'for' attribute. Change-Id: I2879b032cb63a33bb4a5caf40c9c70b2eea55d78 Signed-off-by: Robert Lyon -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1606744 Title: Accessibility - Select 'other' text field label incorrect Status in Mahara: Fix Committed Status in Mahara 15.04 series: Confirmed Status in Mahara 15.10 series: Confirmed Status in Mahara 16.04 series: Confirmed Status in Mahara 16.10 series: Fix Committed Bug description: Mahara: master Input text fields should have a label and/or use the 'aria-labelled by' property to bind multiple inputs to a label. Please refer to: http://webaim.org/techniques/forms/controls#input An example where it is needed is in the screen (artefact/internal/socialprofile.php): * Social media > New social media account The input box (id=editprofileform_profiletype_other) next to "Other" is not linked to a label. Screen readers refer to it as "edit". To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1606744/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1606744] Re: Accessibility - Select 'other' text field label incorrect
** Changed in: mahara/16.10 Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1606744 Title: Accessibility - Select 'other' text field label incorrect Status in Mahara: Fix Committed Status in Mahara 15.04 series: Confirmed Status in Mahara 15.10 series: Confirmed Status in Mahara 16.04 series: Confirmed Status in Mahara 16.10 series: Fix Committed Bug description: Mahara: master Input text fields should have a label and/or use the 'aria-labelled by' property to bind multiple inputs to a label. Please refer to: http://webaim.org/techniques/forms/controls#input An example where it is needed is in the screen (artefact/internal/socialprofile.php): * Social media > New social media account The input box (id=editprofileform_profiletype_other) next to "Other" is not linked to a label. Screen readers refer to it as "edit". To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1606744/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1539346] A change has been merged
Reviewed: https://reviews.mahara.org/6841 Committed: https://git.mahara.org/mahara/mahara/commit/741aa7d2150d22e9206ffa1fd8a93e3f4d697324 Submitter: Son Nguyen (son.ngu...@catalyst.net.nz) Branch:master commit 741aa7d2150d22e9206ffa1fd8a93e3f4d697324 Author: Robert Lyon Date: Fri Jan 29 15:25:19 2016 +1300 Bug 1539346: Moving the define ADODB_ASSOC_CASE_* calls As they are needed by ADONewConnection even when ADODB_EXTENSION is above 4.0 behatnotneeded Change-Id: I63b90f47f5ec0f3ef00905c91f20f35a55e07885 Signed-off-by: Robert Lyon -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1539346 Title: Upgrade adodb to 5.20.5 Status in Mahara: Fix Committed Bug description: Updating the adodb library To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1539346/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1539346] A change has been merged
Reviewed: https://reviews.mahara.org/6837 Committed: https://git.mahara.org/mahara/mahara/commit/c81a1e1c92bdaf78748a943ab42b33bee727c7e8 Submitter: Son Nguyen (son.ngu...@catalyst.net.nz) Branch:master commit c81a1e1c92bdaf78748a943ab42b33bee727c7e8 Author: Francois Marier Date: Mon May 17 17:47:01 2010 +1200 adodb: check for Postgres 8.1 See Eduforge #2318 or LP #547951. Bug 1539346 (cherry picked from commit 4bdafccba511540e6db92277aa104a23f57209ac) Change-Id: I6dd4bdd484528a09b336efa241f0464136f5f7a0 Signed-off-by: Robert Lyon -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1539346 Title: Upgrade adodb to 5.20.5 Status in Mahara: Fix Committed Bug description: Updating the adodb library To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1539346/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1539346] Re: Upgrade adodb to 5.20.5
** Changed in: mahara Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1539346 Title: Upgrade adodb to 5.20.5 Status in Mahara: Fix Committed Bug description: Updating the adodb library To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1539346/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1539346] A change has been merged
Reviewed: https://reviews.mahara.org/6836
Committed:
https://git.mahara.org/mahara/mahara/commit/b79c042f150aba841c6f909f5bc9d34b4a6a9228
Submitter: Son Nguyen (son.ngu...@catalyst.net.nz)
Branch:master
commit b79c042f150aba841c6f909f5bc9d34b4a6a9228
Author: Martin Langhoff
Date: Sat Dec 1 23:54:23 2007 +1300
adodb: RecordSet_postgres7->MoveNext() - remove expensive is_array()
Bug 1539346
And implicit count() of the array keys/columns. This saves a good 5%
of the exec time of get_records('config')
(cherry picked from commit 4652e5617d9616e3f61e78df5a4c863e16ac5634)
Change-Id: I18aeb0d1635719bec5574005f2dd93e3db32b9e6
Signed-off-by: Robert Lyon
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1539346
Title:
Upgrade adodb to 5.20.5
Status in Mahara:
Fix Committed
Bug description:
Updating the adodb library
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1539346/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1539346] A change has been merged
Reviewed: https://reviews.mahara.org/6839 Committed: https://git.mahara.org/mahara/mahara/commit/c7ec603cc44ccba0ac7fa7d2891cbd597b44ac14 Submitter: Son Nguyen (son.ngu...@catalyst.net.nz) Branch:master commit c7ec603cc44ccba0ac7fa7d2891cbd597b44ac14 Author: Penny Leach Date: Sun Aug 23 14:54:23 2009 +0200 ADODB modification: add __wakeup to connection object Bug 1539346 This reconnects to the db after wakeup, as resource types cannot be serialized and unserialized. This is necessary for unit tests, phpunit backups and restore globals between each test. (cherry picked from commit 417077459037550239fe9b09bd20b50d4c19b57f) Change-Id: I1a007d0f56dc0e210c3f09e8445c0e56215b9545 Signed-off-by: Robert Lyon -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1539346 Title: Upgrade adodb to 5.20.5 Status in Mahara: Fix Committed Bug description: Updating the adodb library To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1539346/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1539346] A change has been merged
Reviewed: https://reviews.mahara.org/6840 Committed: https://git.mahara.org/mahara/mahara/commit/f9818ff606bbe6ec00b34eab23d1743870407b48 Submitter: Son Nguyen (son.ngu...@catalyst.net.nz) Branch:master commit f9818ff606bbe6ec00b34eab23d1743870407b48 Author: Robert Lyon Date: Mon Aug 15 12:27:03 2016 +1200 Modified session variable setting in ADOdb adodb-pager.inc.php Bug 1539346 Was originally part of commit 55a8deb8cbd2e1455c7af3a35c50b7cad76d63df but have moved it out to own patch for purposes of adodb version update Change-Id: Ifba78f8e1cd57d9489c737fd69ee45a8218d157b Signed-off-by: Robert Lyon -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1539346 Title: Upgrade adodb to 5.20.5 Status in Mahara: Fix Committed Bug description: Updating the adodb library To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1539346/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1539346] A change has been merged
Reviewed: https://reviews.mahara.org/6835 Committed: https://git.mahara.org/mahara/mahara/commit/737e9d317b64c3fd174008029de82a8c5bb7534b Submitter: Son Nguyen (son.ngu...@catalyst.net.nz) Branch:master commit 737e9d317b64c3fd174008029de82a8c5bb7534b Author: Robert Lyon Date: Mon Aug 15 12:03:46 2016 +1200 Bug 1539346: Upgrade ADODB to version 5.20.5 behatnotneeded Change-Id: I0ae73d8d82a386fb6ce3d0e544c4824ec3ed5860 Signed-off-by: Robert Lyon -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1539346 Title: Upgrade adodb to 5.20.5 Status in Mahara: Fix Committed Bug description: Updating the adodb library To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1539346/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1539346] A change has been merged
Reviewed: https://reviews.mahara.org/6838 Committed: https://git.mahara.org/mahara/mahara/commit/f4ab7790dcbad3919849c73a57b17423d1c476ad Submitter: Son Nguyen (son.ngu...@catalyst.net.nz) Branch:master commit f4ab7790dcbad3919849c73a57b17423d1c476ad Author: Robert Lyon Date: Mon Nov 10 08:04:59 2014 +1300 Check for valid columns in adodb postgres64 driver MetaIndexes fn Bug 1539346 Indexes on functions of columns have a 0 in the indkey column of pg_catalog.pg_index, which doesn't refer to a column. Don't return any columns for the index, rather than returning an empty column name. (cherry picked from commit b87d9961020a8d52a2eaf709a9197520b3c6b65b) Change-Id: I9854b99d4937b3fea1ebb44e3abed2e64446afdb Signed-off-by: Robert Lyon -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1539346 Title: Upgrade adodb to 5.20.5 Status in Mahara: Fix Committed Bug description: Updating the adodb library To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1539346/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1613503] Re: Can not add groups via CSV when shortname is not relied on displayname
** Changed in: mahara Status: New => Fix Committed ** Changed in: mahara Assignee: (unassigned) => Robert Lyon (robertl-9) ** Changed in: mahara Importance: Undecided => High -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1613503 Title: Can not add groups via CSV when shortname is not relied on displayname Status in Mahara: Fix Committed Bug description: version: master(16.10) I got the following message when adding groups via CSV Mahara: Site unavailable Something in the way you're interacting with Mahara is causing an error. Details if any, follow: group_create: The supplied shortname 'gc' is already taken. This shortname 'groupc' is available. The content of my CSV file: shortname,displayname,roles "gc","Group C","standard" I have to change the shortname to 'groupc' to make it work. Is it the new behaviour? To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1613503/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1612481] Re: In some cases users are out of the search result on admin page
** Description changed: Steps to replicate: Make sure that the setting "Exact user searches" set to Yes on admin/extensions/pluginconfig.php?plugintype=search&pluginname=internal Create a user with multi word lastname, e.g Bla Bla Bla Navigate to /admin/users/search.php - Type Bla in search form + Type this in search form: + Bla Bla Bla + + Expected result: User is in the search results, because you've typed their exact last name. Actual result: User is not in the search results - Expected result: User is in the search results ** Summary changed: - In some cases users are out of the search result on admin page + "Exact user search" doesn't work intuitively with names containing spaces ** Description changed: Steps to replicate: Make sure that the setting "Exact user searches" set to Yes on admin/extensions/pluginconfig.php?plugintype=search&pluginname=internal Create a user with multi word lastname, e.g Bla Bla Bla Navigate to /admin/users/search.php Type this in search form: - Bla Bla Bla + Bla Bla Bla Expected result: User is in the search results, because you've typed their exact last name. Actual result: User is not in the search results + + Workaround: Enclose the firstname and/or lastname *by itself* in double + quotes. e.g., for the user Aaron von Wells, search for: + + Aaron "von Wells" -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1612481 Title: "Exact user search" doesn't work intuitively with names containing spaces Status in Mahara: Confirmed Bug description: Steps to replicate: Make sure that the setting "Exact user searches" set to Yes on admin/extensions/pluginconfig.php?plugintype=search&pluginname=internal Create a user with multi word lastname, e.g Bla Bla Bla Navigate to /admin/users/search.php Type this in search form: Bla Bla Bla Expected result: User is in the search results, because you've typed their exact last name. Actual result: User is not in the search results Workaround: Enclose the firstname and/or lastname *by itself* in double quotes. e.g., for the user Aaron von Wells, search for: Aaron "von Wells" To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1612481/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1613392] Re: PostgreSQL insert error into site_content with multibyte language packs.
Hm, one more note on this. There was one character in the middle of that
block that originally didn't print. It's the "\x81\xa7" towards the end
of the text, which rendered as: ��.
In my copy-paste above, I replaced it with UTF-16 81a7: 膧
(http://www.mclean.net.nz/ucf/?c=U+81A7), but it was the one glyph in
the block that Google Translate didn't recognize as Japanese. Instead,
Google said it was Chinese.
Perhaps this glyph had something to do with the issue? I wonder if it's
meant to be the Hiragana で, which is UTF-8 E3 81 A7, i.e.
"\xe3\x81\xa7", and the "\xe3" was left out as a typo.
Cheers,
Aaron
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1613392
Title:
PostgreSQL insert error into site_content with multibyte language
packs.
Status in Mahara:
Incomplete
Bug description:
When we try to add a new institution using Japanese language menu, we
have an error message "Mahara: Site unavailable A nonrecoverable error
occurred. This probably means you have encountered a bug in the
system" and can't add the institution.
And Apache error log says as below:
[error] [client xxx.xxx.xxx.xxx] [WAR] 18 (lib/errors.php:820) HINT: This
error can also happen if the byte sequence does not match the encoding expected
by the server, which is controlled by "client_encoding".] in adodb_throw(INSERT
INTO "site_content" ("name", "content", "ctime", "mtime", "institution") VALUES
(?, ?, ?, ?, ?),
home,Mahara\xe3\x81\xab\xe3\x82\x88\xe3\x81\x86\xe3\x81\x93\xe3\x81\x9d[\xe3\x81\x82\xe3\x81\xaa\xe3\x81\x9f\xe3\x81\xae\xe7\xb5\x84\xe7\xb9\x94\xe5\x90\x8d]\xe3\x81\xaf\xe3\x82\xaa\xe3\x83\xb3\xe3\x83\xa9\xe3\x82\xa4\xe3\x83\xb3\xe3\x82\xb3\xe3\x83\x9f\xe3\x83\xa5\xe3\x83\x8b\xe3\x83\x86\xe3\x82\xa3\xe3\x82\x92\xe6\xa7\x8b\xe7\xaf\x89\xe3\x81\x99\xe3\x82\x8b\xe3\x81\x9f\xe3\x82\x81\xe3\x81\xae\xe5\x8d\x81\xe5\x88\x86\xe3\x81\xaa\xe6\xa9\x9f\xe8\x83\xbd\xe3\x82\x92\xe6\x9c\x89\xe3\x81\x99\xe3\x82\x8b\xe3\x82\xa4\xe3\x83\xb3\xe3\x82\xbf\xe3\x83\xbc\xe3\x83\x8d\xe3\x83\x83\xe3\x83\x88\xe4\xb8\x8a\xe3\x81\xae\xe3\x83\x9d\xe3\x83\xbc\xe3\x83\x88\xe3\x83\x95\xe3\x82\xa9\xe3\x83\xaa\xe3\x82\xaa\xe3\x82\xb7\xe3\x82\xb9\xe3\x83\x86\xe3\x83\xa0\xe3\x81\xa7\xe3\x81\x99\xe3\x80\x82Mahara\xe3\x81\xab\xe9\x96\xa2\xe3\x81\x99\xe3\x82\x8b\xe8\xa9\xb3\xe7\xb4\xb0\xe3\x81\xafAbout[\xe3\x81\x93\xe3\x81\xae\xe3\x83\x9a\xe3\x83\xbc\xe3\x82\xb8\xe3\x82\x92\xe5\xbf\x98\xe3\x82\x8c\xe3\x81\x9a\xe3\x81\xab\xe7\xb7\xa8\xe9\x9b\x86\xe3\x81\x97\xe3\x81\xa6\xe3\x81\x8f\xe3\x81\xa0\xe3\x81\x95\xe3\x81\x84]\xe3\x82\x92\xe3\x81\x8a\xe8\xaa\xad\xe3\x81\xbf\xe3\x81\x8f\xe3\x81\xa0\xe3\x81\x95\xe3\x81\x84\xe3\x80\x82\xe3\x81\xbe\xe3\x81\x9f\xe3\x80\x81\xe7\xa7\x81\xe3\x81\x9f\xe3\x81\xa1\xe3\x81\xab\xe3\x81\x8a\xe6\xb0\x97\xe8\xbb\xbd\xe3\x81\xab\xe3\x81\x8a\xe5\x95\x8f\xe3\x81\x84\xe5\x90\x88\xe3\x82\x8f\xe3\x81\x9b\xe3\x81\x8f\xe3\x81\xa0\xe3\x81\x95\xe3\x81\x84\xe3\x80\x82\xe3\x81\x82\xe3\x81\xaa\xe3\x81\x9f\xe3\x81\xaf\xe3\x81\x93\xe3\x81\xae\xe3\x83\x86\xe3\x82\xad\xe3\x82\xb9\xe3\x83\x88\xe3\x82\x92\x81\xa7\xe7\xb7\xa8\xe9\x9b\x86\xe3\x81\x99\xe3\x82\x8b\xe3\x81\x93\xe3\x81\xa8\xe3\x81\x8c\xe3\x81\xa7\xe3\x81\x8d\xe3\x81\xbe\xe3\x81\x99\xe3\x80\x82,2016-08-1512:50:39,2016-08-1512:50:39,inst),
referer: https://mahara.x.com/admin/users/institutions.php
To avoid this error, I would like to recommend to modify lib/dml.php
as below.
File:
lib/dml.php
Line:
1061
[ Before ]
// Pull out data matching these fields
$ddd = array();
foreach ($columns as $column) {
if (isset($data[$column->name])) {
if ($column->name == $primarykey && empty($setfromseq)) {
continue;
}
$ddd[$column->name] = $data[$column->name];
}
}
[ After ]
// Pull out data matching these fields
$ddd = array();
foreach ($columns as $column) {
if (isset($data[$column->name])) {
if ($column->name == $primarykey && empty($setfromseq)) {
continue;
}
if (function_exists('mb_convert_encoding')) {
$ddd[$column->name] =
mb_convert_encoding($data[$column->name], "UTF-8", "auto");
} else {
$ddd[$column->name] = $data[$column->name];
}
}
}
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1613392/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1613503] A change has been merged
Reviewed: https://reviews.mahara.org/6844 Committed: https://git.mahara.org/mahara/mahara/commit/258273c4209411d51814bd39f4251ea144e843eb Submitter: Son Nguyen (son.ngu...@catalyst.net.nz) Branch:master commit 258273c4209411d51814bd39f4251ea144e843eb Author: Robert Lyon Date: Tue Aug 16 15:00:14 2016 +1200 Bug 1613503: Validate the shortname generated from provided shortname in CSV not from displayname behatnotneeded Change-Id: If7134f6b97031fc848684b053795a02504b27316 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1613503 Title: Can not add groups via CSV when shortname is not relied on displayname Status in Mahara: New Bug description: version: master(16.10) I got the following message when adding groups via CSV Mahara: Site unavailable Something in the way you're interacting with Mahara is causing an error. Details if any, follow: group_create: The supplied shortname 'gc' is already taken. This shortname 'groupc' is available. The content of my CSV file: shortname,displayname,roles "gc","Group C","standard" I have to change the shortname to 'groupc' to make it work. Is it the new behaviour? To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1613503/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1612481] Re: In some cases users are out of the search result on admin page
** Changed in: mahara Importance: Undecided => Medium ** Changed in: mahara Status: New => Confirmed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1612481 Title: In some cases users are out of the search result on admin page Status in Mahara: Confirmed Bug description: Steps to replicate: Make sure that the setting "Exact user searches" set to Yes on admin/extensions/pluginconfig.php?plugintype=search&pluginname=internal Create a user with multi word lastname, e.g Bla Bla Bla Navigate to /admin/users/search.php Type Bla in search form Actual result: User is not in the search results Expected result: User is in the search results To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1612481/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
