[Mahara-contributors] [Bug 1613135] A patch has been submitted for review

2016-08-21 Thread Mahara Bot
Patch for "15.04_STABLE" branch: https://reviews.mahara.org/6879

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1613135

Title:
  Fix negative block_instance sortorders before running upgrade

Status in Mahara:
  In Progress
Status in Mahara 15.04 series:
  In Progress
Status in Mahara 15.10 series:
  In Progress
Status in Mahara 16.04 series:
  In Progress
Status in Mahara 16.10 series:
  In Progress

Bug description:
  See:
  
https://mahara.org/interaction/forum/topic.php?id=7687=0=10#post30945

  For Bug 1528351 we added an upgrade block that corrects the
  block_instance sortorder drift that had been created by Bug 1523719.
  As a workaround to the uniqueness constraint on that column, this
  block temporarily moves the sortorders into the negative integerspace,
  and then re-orders them as positive numbers.

  However, we've had multiple reports of sites that have somehow got
  negative numbers already in their block_instance.sortorder column.
  These sites then error out during the upgrade, because the extant
  negative numbers turn into positive numbers, and then there's a
  uniqueness violation if another block being re-ordered overlaps with
  it.

  Ghada has written up a block of code that can fix this, and we've
  shared it with some affected sites via the forum. It should be easy to
  add it to the basic upgrade script, though. In order to reduce
  complications, we could preface it with a check to see whether there
  are negative sortorders in the database, and only run this additional
  step if we find any negatives.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1613135/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1613135] A patch has been submitted for review

2016-08-21 Thread Mahara Bot
Patch for "15.10_STABLE" branch: https://reviews.mahara.org/6878

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1613135

Title:
  Fix negative block_instance sortorders before running upgrade

Status in Mahara:
  In Progress
Status in Mahara 15.04 series:
  In Progress
Status in Mahara 15.10 series:
  In Progress
Status in Mahara 16.04 series:
  In Progress
Status in Mahara 16.10 series:
  In Progress

Bug description:
  See:
  
https://mahara.org/interaction/forum/topic.php?id=7687=0=10#post30945

  For Bug 1528351 we added an upgrade block that corrects the
  block_instance sortorder drift that had been created by Bug 1523719.
  As a workaround to the uniqueness constraint on that column, this
  block temporarily moves the sortorders into the negative integerspace,
  and then re-orders them as positive numbers.

  However, we've had multiple reports of sites that have somehow got
  negative numbers already in their block_instance.sortorder column.
  These sites then error out during the upgrade, because the extant
  negative numbers turn into positive numbers, and then there's a
  uniqueness violation if another block being re-ordered overlaps with
  it.

  Ghada has written up a block of code that can fix this, and we've
  shared it with some affected sites via the forum. It should be easy to
  add it to the basic upgrade script, though. In order to reduce
  complications, we could preface it with a check to see whether there
  are negative sortorders in the database, and only run this additional
  step if we find any negatives.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1613135/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1613135] A patch has been submitted for review

2016-08-21 Thread Mahara Bot
Patch for "16.04_STABLE" branch: https://reviews.mahara.org/6877

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1613135

Title:
  Fix negative block_instance sortorders before running upgrade

Status in Mahara:
  In Progress
Status in Mahara 15.04 series:
  In Progress
Status in Mahara 15.10 series:
  In Progress
Status in Mahara 16.04 series:
  In Progress
Status in Mahara 16.10 series:
  In Progress

Bug description:
  See:
  
https://mahara.org/interaction/forum/topic.php?id=7687=0=10#post30945

  For Bug 1528351 we added an upgrade block that corrects the
  block_instance sortorder drift that had been created by Bug 1523719.
  As a workaround to the uniqueness constraint on that column, this
  block temporarily moves the sortorders into the negative integerspace,
  and then re-orders them as positive numbers.

  However, we've had multiple reports of sites that have somehow got
  negative numbers already in their block_instance.sortorder column.
  These sites then error out during the upgrade, because the extant
  negative numbers turn into positive numbers, and then there's a
  uniqueness violation if another block being re-ordered overlaps with
  it.

  Ghada has written up a block of code that can fix this, and we've
  shared it with some affected sites via the forum. It should be easy to
  add it to the basic upgrade script, though. In order to reduce
  complications, we could preface it with a check to see whether there
  are negative sortorders in the database, and only run this additional
  step if we find any negatives.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1613135/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1237137] A change has been merged

2016-08-21 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/6868
Committed: 
https://git.mahara.org/mahara/mahara/commit/6ef27c8c79279504bee31cce5762f0536f8d3c13
Submitter: Aaron Wells (aar...@catalyst.net.nz)
Branch:master

commit 6ef27c8c79279504bee31cce5762f0536f8d3c13
Author: Robert Lyon 
Date:   Wed Nov 13 16:13:14 2013 +1300

Embed pdf has horiz scrollbar on default 3 column layout (bug 1237137)

Seen as the 3 column layout is the default one the embed pdf view
should fit within it.

Currently if you have a browser windo open fully, a 3 column layout,
and a pdf embedded you get a horizontal scrollbar on the embed pdf.

A slight adjustment of the min-width and it goes away.

The scrollbar will be there for 4 or 5 column widths but that is ok as
they are quite thin columns.

Change-Id: Ib01118d9fffab14440308eaf04b5038fdfeca9c3

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1237137

Title:
  adding multiple PDF's at a time doesn't work

Status in Mahara:
  Fix Released

Bug description:
  Mahara 1.8 Testing 
  --
  Environment = linux / Firefox 
  URL = 
http://myportfolio-school2-mahara.testing.elearning.catalyst.net.nz/view/blocks.php?id=415490

  Logged in as authenticated user 
  --
  "1. adding PDF files to a portfolio page - adding multiple files in the edit 
mode seems to work but there is only one file displayed on the page 
  2. the PDF display box also contains 2 horizontal scroll bars 
  3. refreshing the page = only one horizontal scroll bar expected PDF to fit 
Display box "

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1237137/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1613483] A change has been merged

2016-08-21 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/6864
Committed: 
https://git.mahara.org/mahara/mahara/commit/925b59c3b7a2fe86852b67b0a012c3d404bf9af8
Submitter: Aaron Wells (aar...@catalyst.net.nz)
Branch:master

commit 925b59c3b7a2fe86852b67b0a012c3d404bf9af8
Author: Son Nguyen 
Date:   Fri Aug 19 11:27:33 2016 +1200

Bug 1613483: Update PDF.js to 1.4.20

Change-Id: Ic14ef28aeb95ac19e2c790f7ab26932d6c12bb4c

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1613483

Title:
  Update PDFjs to 1.4.20

Status in Mahara:
  Fix Committed

Bug description:
  Since 1.1.1040, there have been several bug fixes and few features. We
  would highly update this.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1613483/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1606744] Re: Accessibility - Select 'other' text field label incorrect

2016-08-21 Thread Ghada El-Zoghbi
Hi,

This covers some of the accessibility issues but it doesn't cover this
item:

* From/To date in the 'Shared by me' menu

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1606744

Title:
  Accessibility - Select 'other' text field label incorrect

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Confirmed
Status in Mahara 15.10 series:
  Confirmed
Status in Mahara 16.04 series:
  Confirmed
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  Mahara: master

  Input text fields should have a label and/or use the 'aria-labelled
  by' property to bind multiple inputs to a label.

  Please refer to: http://webaim.org/techniques/forms/controls#input

  An example where it is needed is in the screen
  (artefact/internal/socialprofile.php):

  * Social media > New social media account

  The input box (id=editprofileform_profiletype_other) next to "Other"
  is not linked to a label. Screen readers refer to it as "edit".

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1606744/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1240776] A change has been merged

2016-08-21 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/6867
Committed: 
https://git.mahara.org/mahara/mahara/commit/d09a09ab51e80c2383b8a47b746f068271396863
Submitter: Aaron Wells (aar...@catalyst.net.nz)
Branch:master

commit d09a09ab51e80c2383b8a47b746f068271396863
Author: Robert Lyon 
Date:   Fri Oct 18 12:54:47 2013 +1300

Getting the bottom of the pdf viewer to display (bug 1240776)

- change allows for a bit of the base of the display so it doesn't
look broken

Change-Id: Ie163f986a4c6abcf60cb26fc3b479122c119fc10

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1240776

Title:
  PDF media looks incomplete

Status in Mahara:
  Fix Released

Bug description:
  Mahara 1.8 Testing 
  -
  Environment = Linux / Chrome 
  URL = 
http://myportfolio-school2-mahara.testing.elearning.catalyst.net.nz/user/spintester/spinner-s-page-8
  

  The PDF block looks incomplete on a Profile page, it looks as though
  it needs a bottom.  The other problem is that the block only shows
  half of the first page.  I would have expected it to show the whole
  first page.

  See the attachment for more details

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1240776/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1613483] A change has been merged

2016-08-21 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/6865
Committed: 
https://git.mahara.org/mahara/mahara/commit/39154e686ea9de5c3bfcc194c417456b1aa184cf
Submitter: Aaron Wells (aar...@catalyst.net.nz)
Branch:master

commit 39154e686ea9de5c3bfcc194c417456b1aa184cf
Author: Son Nguyen 
Date:   Fri Aug 19 12:09:42 2016 +1200

Bug 1613483: Update mahara template for pdf block

* Remove sample pdf files
* Use absolute paths in viewer.js
* Open fileurl if defined

Change-Id: I99dc0f84e693c0ea1dc231814379a43297a57411

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1613483

Title:
  Update PDFjs to 1.4.20

Status in Mahara:
  Fix Committed

Bug description:
  Since 1.1.1040, there have been several bug fixes and few features. We
  would highly update this.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1613483/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1423435] A change has been merged

2016-08-21 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/6869
Committed: 
https://git.mahara.org/mahara/mahara/commit/9aaadf0a9ee3b4f4064b639b3beb2627625f0d89
Submitter: Aaron Wells (aar...@catalyst.net.nz)
Branch:master

commit 9aaadf0a9ee3b4f4064b639b3beb2627625f0d89
Author: Robert Lyon 
Date:   Thu Feb 19 16:46:17 2015 +1300

Allow the pdf viewer to display menu items in user's lang (Bug 1423435)

Change-Id: I0b13222887d66d174f5e12d037dda4594acc0512

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1423435

Title:
  pdf.js menu doesn't use current language

Status in Mahara:
  Fix Released

Bug description:
  If I'm using a browser set to English but am viewing a mahara page
  with user set to German I see the pdf viewer in English - But I would
  perfer to see it in the language I've chosen for mahara (German).

  As this is something we set for tinymce I'll take the code and use it
  for the pdf.js as well

  I feel this has been an oversight with our implementation of pdf
  viewer and should be fixed asap.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1423435/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1613483] A change has been merged

2016-08-21 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/6870
Committed: 
https://git.mahara.org/mahara/mahara/commit/9c02263d1370f4d13f64223a42c0636b4ac10dcb
Submitter: Aaron Wells (aar...@catalyst.net.nz)
Branch:master

commit 9c02263d1370f4d13f64223a42c0636b4ac10dcb
Author: Son Nguyen 
Date:   Mon Mar 9 14:31:16 2015 +1300

Bug 1613483: Hide "Open file" button in the toolbar

behatnotneeded

Change-Id: I3204369ec36bbfa01227f210e8fc79526679f660

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1613483

Title:
  Update PDFjs to 1.4.20

Status in Mahara:
  Fix Committed

Bug description:
  Since 1.1.1040, there have been several bug fixes and few features. We
  would highly update this.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1613483/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1613483] Re: Update PDFjs to 1.4.20

2016-08-21 Thread Aaron Wells
** Changed in: mahara
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1613483

Title:
  Update PDFjs to 1.4.20

Status in Mahara:
  Fix Committed

Bug description:
  Since 1.1.1040, there have been several bug fixes and few features. We
  would highly update this.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1613483/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1613483] Re: Update PDFjs to 1.4.20

2016-08-21 Thread LIsa
Tested in Chrome, Safari, IE Edge and Firefox

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1613483

Title:
  Update PDFjs to 1.4.20

Status in Mahara:
  In Progress

Bug description:
  Since 1.1.1040, there have been several bug fixes and few features. We
  would highly update this.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1613483/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1615280] Re: Email validation bug (long domains)

2016-08-21 Thread Aaron Wells
Hm, actually for constistency's sake, because all these email addresses
ultimately get validate by PHPMailer, we should probably validate them
via PHPMailer's validateAddress instead.

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1615280

Title:
  Email validation bug (long domains)

Status in Mahara:
  In Progress
Status in Mahara 15.04 series:
  In Progress
Status in Mahara 15.10 series:
  In Progress
Status in Mahara 16.04 series:
  In Progress
Status in Mahara 16.10 series:
  In Progress

Bug description:
  This one has existed since 2006, but only become an issue with the
  opening up of TLDs over the past few years.
  (https://en.wikipedia.org/wiki/List_of_Internet_top-level_domains)

  Currently the email validation in pieform limits the TLD to between 2-4 
characters (see pieform_rule_email() in 
htdocs/lib/pieforms/pieform/rules/email.php.)
  That means people from .horse, for example, can't register. Changing the 
regex fixed my immediate problem, haven't tested how the other email validation 
points react. They use FILTER_VALIDATE_EMAIL and PHPMailer::ValidateAddress, so 
might be better.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1615280/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1615280] Re: Email validation bug (long domains)

2016-08-21 Thread Aaron Wells
After doing a quick survey of what other PHP projects are doing
(including our own PHPMailer library), I think for now we should
probably just use FILTER_VALIDATE_EMAIL throughout. As mentioned above,
this is an improvement, but with the following known flaws:

1. No support for one-part domains (root@localhost)

2. No support for email addresses containing unicode characters (See
https://en.wikipedia.org/wiki/International_email )

PHPMailer now includes a function to punycode the domain-part of an
email address if it contains unicode, but it's not exposed as a static
function, apparently because it's reliant on knowing the character set
of the PHPMailer instance.

None of the big PHP projects currently support email addresses with
unicode in the local part (before the "@"), although there are bugs
raised with several of them, so we'll probably need to revisit this in a
few years.

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1615280

Title:
  Email validation bug (long domains)

Status in Mahara:
  In Progress
Status in Mahara 15.04 series:
  In Progress
Status in Mahara 15.10 series:
  In Progress
Status in Mahara 16.04 series:
  In Progress
Status in Mahara 16.10 series:
  In Progress

Bug description:
  This one has existed since 2006, but only become an issue with the
  opening up of TLDs over the past few years.
  (https://en.wikipedia.org/wiki/List_of_Internet_top-level_domains)

  Currently the email validation in pieform limits the TLD to between 2-4 
characters (see pieform_rule_email() in 
htdocs/lib/pieforms/pieform/rules/email.php.)
  That means people from .horse, for example, can't register. Changing the 
regex fixed my immediate problem, haven't tested how the other email validation 
points react. They use FILTER_VALIDATE_EMAIL and PHPMailer::ValidateAddress, so 
might be better.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1615280/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1615280] Re: Email validation bug (long domains)

2016-08-21 Thread Aaron Wells
Alternately, we could copy Moodle (again) and use a really liberal
regex. Moodle 3.1 uses this one, which is nearly unchanged from 2001!
The most recent functional update to it was in 2006, when it was changed
to reject email addresses where the alias ends in a ".".

Basically, this regex checks for a list of acceptable characters for the
alias, a "@", and a list of acceptable characters for the domain that
includes at least one "."

/**
 * Validates an email to make sure it makes sense.
 *
 * @param string $address The email address to validate.
 * @return boolean
 */
function validate_email($address) {
return (preg_match('#^[-!\#$%&\'*+\\/0-9=?A-Z^_`a-z{|}~]+'.
 '(\.[-!\#$%&\'*+\\/0-9=?A-Z^_`a-z{|}~]+)*'.
  '@'.
  '[-!\#$%&\'*+\\/0-9=?A-Z^_`a-z{|}~]+\.'.
  '[-!\#$%&\'*+\\./0-9=?A-Z^_`a-z{|}~]+$#',
  $address));
}

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1615280

Title:
  Email validation bug (long domains)

Status in Mahara:
  In Progress
Status in Mahara 15.04 series:
  In Progress
Status in Mahara 15.10 series:
  In Progress
Status in Mahara 16.04 series:
  In Progress
Status in Mahara 16.10 series:
  In Progress

Bug description:
  This one has existed since 2006, but only become an issue with the
  opening up of TLDs over the past few years.
  (https://en.wikipedia.org/wiki/List_of_Internet_top-level_domains)

  Currently the email validation in pieform limits the TLD to between 2-4 
characters (see pieform_rule_email() in 
htdocs/lib/pieforms/pieform/rules/email.php.)
  That means people from .horse, for example, can't register. Changing the 
regex fixed my immediate problem, haven't tested how the other email validation 
points react. They use FILTER_VALIDATE_EMAIL and PHPMailer::ValidateAddress, so 
might be better.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1615280/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1615280] Re: Email validation bug (long domains)

2016-08-21 Thread Aaron Wells
Thanks for reporting this! I wasn't even aware that Mahara had code that
was trying to validate email addresses via a simple regex like that. The
code in question is pretty old, originally written in 2007 and last
updated in 2009 (to allow a "+" sign in the alias part of the email
address.)

Of course since then, the number of top-level domain names has exploded.
There used to be only a few rare ones longer than four characters; now
there are dozens: https://en.wikipedia.org/wiki/List_of_Internet_top-
level_domains#ICANN-era_generic_top-level_domains.

I find a few issues mentioned with PHP's "FILTER_VALIDATE_EMAIL" option,
specifically:

1. Requires a "." in the domain name, so it fails on eg "root@localhost"
2. Doesn't work with emails containing non-ASCII characters. You can convert 
the domain part to punycode first, but I'm not sure if that works for the alias 
part.

On the other hand, both of those bugs are present in the current
implementation! So switching to FILTER_VALIDATE_EMAIL would at least be
an improvement.

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1615280

Title:
  Email validation bug (long domains)

Status in Mahara:
  In Progress
Status in Mahara 15.04 series:
  In Progress
Status in Mahara 15.10 series:
  In Progress
Status in Mahara 16.04 series:
  In Progress
Status in Mahara 16.10 series:
  In Progress

Bug description:
  This one has existed since 2006, but only become an issue with the
  opening up of TLDs over the past few years.
  (https://en.wikipedia.org/wiki/List_of_Internet_top-level_domains)

  Currently the email validation in pieform limits the TLD to between 2-4 
characters (see pieform_rule_email() in 
htdocs/lib/pieforms/pieform/rules/email.php.)
  That means people from .horse, for example, can't register. Changing the 
regex fixed my immediate problem, haven't tested how the other email validation 
points react. They use FILTER_VALIDATE_EMAIL and PHPMailer::ValidateAddress, so 
might be better.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1615280/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1614298] A change has been merged

2016-08-21 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/6874
Committed: 
https://git.mahara.org/mahara/mahara/commit/f8ff2dfa3dd8116e6b8d25d48d08c8dba62349cd
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:15.10_STABLE

commit f8ff2dfa3dd8116e6b8d25d48d08c8dba62349cd
Author: Robert Lyon 
Date:   Thu Aug 18 10:30:10 2016 +1200

Bug 1614298: Adjusting the upgrade process for webservices plugin

In case the site was using the old contrib plugin

behatnotneeded - upgrade issue

Change-Id: I96b20395e09699aa1775bc00339e6db63a10e235
Signed-off-by: Robert Lyon 
(cherry picked from commit b6ecbf9f21e4f737da83f48237c8cc46e4b04965)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1614298

Title:
  Unable to upgrade if webservices contrib plugin already installed

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  In Progress
Status in Mahara 15.10 series:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  If the mahara site is already using the webservices contributed plugin

  https://github.com/piersharding/mahara-contrib-auth-webservice

  in a site older than 15.04 and you try to upgrade - the upgrade
  process fails

  This is due to renaming some db fields

  Will add a patch to fix up the variances

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1614298/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1614298] Re: Unable to upgrade if webservices contrib plugin already installed

2016-08-21 Thread Robert Lyon
** Changed in: mahara/15.10
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1614298

Title:
  Unable to upgrade if webservices contrib plugin already installed

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  In Progress
Status in Mahara 15.10 series:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  If the mahara site is already using the webservices contributed plugin

  https://github.com/piersharding/mahara-contrib-auth-webservice

  in a site older than 15.04 and you try to upgrade - the upgrade
  process fails

  This is due to renaming some db fields

  Will add a patch to fix up the variances

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1614298/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1614645] Re: TinyMCE not showing on mobile in 16.04

2016-08-21 Thread Aaron Wells
*** This bug is a duplicate of bug 1576643 ***
https://bugs.launchpad.net/bugs/1576643

Hi Stephane,

Thanks for the follow-up! I'm glad to hear the problem was already
fixed. :)

Cheers,
Aaron

** Changed in: mahara
   Status: Incomplete => Invalid

** This bug has been marked a duplicate of bug 1576643
   TinyMCE is not available on the iPad

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1614645

Title:
  TinyMCE not showing on mobile in 16.04

Status in Mahara:
  Invalid

Bug description:
  This is a bug reported by a user.

  Tinymce does not show in mobile device browsers.

  It used to show if device detection was turned off. We upgraded to
  16.04 and now tinymce doesn't show anymore (on mobile device
  browsers).

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1614645/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1614298] A change has been merged

2016-08-21 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/6873
Committed: 
https://git.mahara.org/mahara/mahara/commit/ba589027e6cb0a541243a62efd6636b4d9d55d04
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:16.04_STABLE

commit ba589027e6cb0a541243a62efd6636b4d9d55d04
Author: Robert Lyon 
Date:   Thu Aug 18 10:30:10 2016 +1200

Bug 1614298: Adjusting the upgrade process for webservices plugin

In case the site was using the old contrib plugin

behatnotneeded - upgrade issue

Change-Id: I96b20395e09699aa1775bc00339e6db63a10e235
Signed-off-by: Robert Lyon 
(cherry picked from commit b6ecbf9f21e4f737da83f48237c8cc46e4b04965)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1614298

Title:
  Unable to upgrade if webservices contrib plugin already installed

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  In Progress
Status in Mahara 15.10 series:
  In Progress
Status in Mahara 16.04 series:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  If the mahara site is already using the webservices contributed plugin

  https://github.com/piersharding/mahara-contrib-auth-webservice

  in a site older than 15.04 and you try to upgrade - the upgrade
  process fails

  This is due to renaming some db fields

  Will add a patch to fix up the variances

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1614298/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1614298] Re: Unable to upgrade if webservices contrib plugin already installed

2016-08-21 Thread Robert Lyon
** Changed in: mahara/16.04
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1614298

Title:
  Unable to upgrade if webservices contrib plugin already installed

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  In Progress
Status in Mahara 15.10 series:
  In Progress
Status in Mahara 16.04 series:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  If the mahara site is already using the webservices contributed plugin

  https://github.com/piersharding/mahara-contrib-auth-webservice

  in a site older than 15.04 and you try to upgrade - the upgrade
  process fails

  This is due to renaming some db fields

  Will add a patch to fix up the variances

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1614298/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1554247] Re: comments with attachments - attachment titles and links display on main portfolio page

2016-08-21 Thread Robert Lyon
** Changed in: mahara/16.04
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1554247

Title:
  comments with attachments - attachment titles and links display on
  main portfolio page

Status in Mahara:
  Fix Committed
Status in Mahara 15.10 series:
  In Progress
Status in Mahara 16.04 series:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  I'm running 15.10.1 and have the following problem:

  We use the portfolios for a standard process that requires people to
  attach letters to note blocks on the page. When they do add the
  attachments, sometimes the attachment filenames (actually, links to
  the attachments) are visible on the main portfolio page, sometimes in
  a list and sometimes on top of one another. They "float" above the
  page, meaning that if I scroll the page up and down, the attachment
  filenames/links do not move up and down with the page.  This display
  bug is reproducible on multiple browsers (Safari, Chrome).

  I'd hoped that the 15.10.1 patch would resolve this issue, but it did
  not.

  thanks,
  Fran

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1554247/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1554247] A change has been merged

2016-08-21 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/6861
Committed: 
https://git.mahara.org/mahara/mahara/commit/ad370b9dd4a748a7f9a37adfc86513872e3bf9d5
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:16.04_STABLE

commit ad370b9dd4a748a7f9a37adfc86513872e3bf9d5
Author: Pat Kira 
Date:   Thu Aug 18 14:19:24 2016 +1200

Bug 1554247 - Fixed attachment file links showing up on fullwidth layout

behatnotneeded

Change-Id: I00da7d2a319dacabc802c09f1a668f0f37db7057
(cherry picked from commit 76fe713b7624ae49d789d45a1b874e40fc18d56f)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1554247

Title:
  comments with attachments - attachment titles and links display on
  main portfolio page

Status in Mahara:
  Fix Committed
Status in Mahara 15.10 series:
  In Progress
Status in Mahara 16.04 series:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  I'm running 15.10.1 and have the following problem:

  We use the portfolios for a standard process that requires people to
  attach letters to note blocks on the page. When they do add the
  attachments, sometimes the attachment filenames (actually, links to
  the attachments) are visible on the main portfolio page, sometimes in
  a list and sometimes on top of one another. They "float" above the
  page, meaning that if I scroll the page up and down, the attachment
  filenames/links do not move up and down with the page.  This display
  bug is reproducible on multiple browsers (Safari, Chrome).

  I'd hoped that the 15.10.1 patch would resolve this issue, but it did
  not.

  thanks,
  Fran

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1554247/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1554247] Re: comments with attachments - attachment titles and links display on main portfolio page

2016-08-21 Thread LIsa
Tested in CHrome and Safar

Test steps:

Create a page>Enter description and Save
Page created is displayed>Edit layout and click on 1 column then Save
Drag Text block>enter content and Save
Click General>Note and enter content the Save
Display page>Add comment and attachment>click Comment
>From Dashboard, click on the page
Page is displayed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1554247

Title:
  comments with attachments - attachment titles and links display on
  main portfolio page

Status in Mahara:
  Fix Committed
Status in Mahara 15.10 series:
  In Progress
Status in Mahara 16.04 series:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  I'm running 15.10.1 and have the following problem:

  We use the portfolios for a standard process that requires people to
  attach letters to note blocks on the page. When they do add the
  attachments, sometimes the attachment filenames (actually, links to
  the attachments) are visible on the main portfolio page, sometimes in
  a list and sometimes on top of one another. They "float" above the
  page, meaning that if I scroll the page up and down, the attachment
  filenames/links do not move up and down with the page.  This display
  bug is reproducible on multiple browsers (Safari, Chrome).

  I'd hoped that the 15.10.1 patch would resolve this issue, but it did
  not.

  thanks,
  Fran

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1554247/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1614298] Re: Unable to upgrade if webservices contrib plugin already installed

2016-08-21 Thread Robert Lyon
** Changed in: mahara/16.10
   Status: In Progress => Fix Committed

** Changed in: mahara/16.04
   Status: New => In Progress

** Changed in: mahara/15.10
   Status: New => In Progress

** Changed in: mahara/15.04
   Status: New => In Progress

** Changed in: mahara/16.04
   Importance: Undecided => Medium

** Changed in: mahara/15.10
   Importance: Undecided => Medium

** Changed in: mahara/15.04
   Importance: Undecided => Medium

** Changed in: mahara/16.10
Milestone: None => 16.10.0

** Changed in: mahara/16.04
Milestone: None => 16.04.4

** Changed in: mahara/15.10
Milestone: None => 15.10.6

** Changed in: mahara/15.04
Milestone: None => 15.04.10

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1614298

Title:
  Unable to upgrade if webservices contrib plugin already installed

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  In Progress
Status in Mahara 15.10 series:
  In Progress
Status in Mahara 16.04 series:
  In Progress
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  If the mahara site is already using the webservices contributed plugin

  https://github.com/piersharding/mahara-contrib-auth-webservice

  in a site older than 15.04 and you try to upgrade - the upgrade
  process fails

  This is due to renaming some db fields

  Will add a patch to fix up the variances

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1614298/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1614298] A patch has been submitted for review

2016-08-21 Thread Mahara Bot
Patch for "15.10_STABLE" branch: https://reviews.mahara.org/6874

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1614298

Title:
  Unable to upgrade if webservices contrib plugin already installed

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  In Progress
Status in Mahara 15.10 series:
  In Progress
Status in Mahara 16.04 series:
  In Progress
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  If the mahara site is already using the webservices contributed plugin

  https://github.com/piersharding/mahara-contrib-auth-webservice

  in a site older than 15.04 and you try to upgrade - the upgrade
  process fails

  This is due to renaming some db fields

  Will add a patch to fix up the variances

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1614298/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1614298] A patch has been submitted for review

2016-08-21 Thread Mahara Bot
Patch for "15.04_STABLE" branch: https://reviews.mahara.org/6875

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1614298

Title:
  Unable to upgrade if webservices contrib plugin already installed

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  In Progress
Status in Mahara 15.10 series:
  In Progress
Status in Mahara 16.04 series:
  In Progress
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  If the mahara site is already using the webservices contributed plugin

  https://github.com/piersharding/mahara-contrib-auth-webservice

  in a site older than 15.04 and you try to upgrade - the upgrade
  process fails

  This is due to renaming some db fields

  Will add a patch to fix up the variances

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1614298/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1614298] A change has been merged

2016-08-21 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/6855
Committed: 
https://git.mahara.org/mahara/mahara/commit/b6ecbf9f21e4f737da83f48237c8cc46e4b04965
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master

commit b6ecbf9f21e4f737da83f48237c8cc46e4b04965
Author: Robert Lyon 
Date:   Thu Aug 18 10:30:10 2016 +1200

Bug 1614298: Adjusting the upgrade process for webservices plugin

In case the site was using the old contrib plugin

behatnotneeded - upgrade issue

Change-Id: I96b20395e09699aa1775bc00339e6db63a10e235
Signed-off-by: Robert Lyon 

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1614298

Title:
  Unable to upgrade if webservices contrib plugin already installed

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  In Progress
Status in Mahara 15.10 series:
  In Progress
Status in Mahara 16.04 series:
  In Progress
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  If the mahara site is already using the webservices contributed plugin

  https://github.com/piersharding/mahara-contrib-auth-webservice

  in a site older than 15.04 and you try to upgrade - the upgrade
  process fails

  This is due to renaming some db fields

  Will add a patch to fix up the variances

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1614298/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1614298] A patch has been submitted for review

2016-08-21 Thread Mahara Bot
Patch for "16.04_STABLE" branch: https://reviews.mahara.org/6873

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1614298

Title:
  Unable to upgrade if webservices contrib plugin already installed

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  In Progress
Status in Mahara 15.10 series:
  In Progress
Status in Mahara 16.04 series:
  In Progress
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  If the mahara site is already using the webservices contributed plugin

  https://github.com/piersharding/mahara-contrib-auth-webservice

  in a site older than 15.04 and you try to upgrade - the upgrade
  process fails

  This is due to renaming some db fields

  Will add a patch to fix up the variances

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1614298/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp