[Mahara-contributors] [Bug 1533377] A change has been merged

2016-10-24 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/7179
Committed: 
https://git.mahara.org/mahara/mahara/commit/33275769e252a3113ce603427286d01ff0de9858
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:16.04_STABLE

commit 33275769e252a3113ce603427286d01ff0de9858
Author: Aaron Wells 
Date:   Tue Sep 27 01:47:03 2016 +1300

Bug 1533377: Browserid end-of-life migration script

This patch removes all authentication functionality
from the browserid auth plugin. It adds a script,
accessible through the plugin's configuration page,
to migrate user accounts from browserid to
internal auth.

Also includes changes to allow users to be searched
by authtype, and to prevent non-useable plugins
from being enabled on the plugin config page.

Change-Id: I4e8bd9fc4d2fb2ccaa1845fda533c9373ec251bd
behatnotneeded: Can't test with behat

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1533377

Title:
  Remove Persona (browserid) auth plugin by Nov 2016, because Mozilla is
  ending Persona support

Status in Mahara:
  Fix Released
Status in Mahara 15.04 series:
  Fix Released
Status in Mahara 15.10 series:
  Fix Released
Status in Mahara 16.04 series:
  Fix Committed

Bug description:
  Mozilla has recently announced that they're ending support for the
  Persona authentication service, in November 2016.:
  https://wiki.mozilla.org/Identity/Persona_Shutdown_Guidelines_for_Reliers

  Mahara has long shipped with a Persona (formerly "Browserid") auth
  plugin. We'll need to remove this plugin from the 16.10 release, and
  come up with a way to help existing sites migrate their users away
  from Persona.

  We should also consider how to help out the stable release sites in
  migrating users away from Persona. The Nov 2016 shutdown will be very
  close to the 16.10 release date, so asking sites to upgrade to 16.10
  to use any migration tool will be fairly demanding, particularly since
  15.04 will still be covered by its extended support lifetime. So for
  15.04, 15.10, and 16.04 sites, an optional Persona migration plugin is
  probably the best option. That way the functionality will be available
  to sites that need it, without shipping new features in minor
  upgrades.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1533377/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1533377] Re: Remove Persona (browserid) auth plugin by Nov 2016, because Mozilla is ending Persona support

2016-10-24 Thread Robert Lyon
** Changed in: mahara/16.04
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1533377

Title:
  Remove Persona (browserid) auth plugin by Nov 2016, because Mozilla is
  ending Persona support

Status in Mahara:
  Fix Released
Status in Mahara 15.04 series:
  Fix Released
Status in Mahara 15.10 series:
  Fix Released
Status in Mahara 16.04 series:
  Fix Committed

Bug description:
  Mozilla has recently announced that they're ending support for the
  Persona authentication service, in November 2016.:
  https://wiki.mozilla.org/Identity/Persona_Shutdown_Guidelines_for_Reliers

  Mahara has long shipped with a Persona (formerly "Browserid") auth
  plugin. We'll need to remove this plugin from the 16.10 release, and
  come up with a way to help existing sites migrate their users away
  from Persona.

  We should also consider how to help out the stable release sites in
  migrating users away from Persona. The Nov 2016 shutdown will be very
  close to the 16.10 release date, so asking sites to upgrade to 16.10
  to use any migration tool will be fairly demanding, particularly since
  15.04 will still be covered by its extended support lifetime. So for
  15.04, 15.10, and 16.04 sites, an optional Persona migration plugin is
  probably the best option. That way the functionality will be available
  to sites that need it, without shipping new features in minor
  upgrades.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1533377/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1626805] Re: Page becomes blank after a while

2016-10-24 Thread Robert Lyon
** Changed in: mahara/16.04
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1626805

Title:
  Page becomes blank after a while

Status in Mahara:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Released

Bug description:
  There is an issue with race conditions and copying pages in Mahara
  when using a MySQL database.

  What happens is the values in view_rows_columns for the view get
  deleted somehow and this ends up making the page look empty/page
  blocks 'look' deleted.

  They still exist but the system doesn't know how to display the page.

  Luckily we can work out what the rows were by looking at data from a
  number of other tables and repopulate the table.

  I'll add a fix for this.

  To test:
  before patch:
  1) Create a page and add some blocks to it
  2) create another page and set the layout to multiple rows and add some 
blocks on each row
  3) View the pages to make sure they look ok, open each in a new tab for ease 
of checking
  4) Go to the db and then run:
    SELECT FROM view_rows_columns WHERE view = [viewid];
  to see what rows it has
    DELETE FROM view_rows_columns WHERE view = [viewid];
  and get the [viewid] from the urls off the pages

  5) Refresh the pages they should be blank (and you will get a bunch of
  errors in debugging on)

  6) Checkout patch and refresh the pages again you should see the pages
  looking correct again

  7) Check the db again and see the rows have returned and should be the
  same as before

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1626805/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1537861] Re: View layout becomes corrupted when changed

2016-10-24 Thread Robert Lyon
** Changed in: mahara/16.04
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1537861

Title:
  View layout becomes corrupted when changed

Status in Mahara:
  Fix Released
Status in Mahara 16.04 series:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Released

Bug description:
  Version: Mahara 15.04.5 (only encountered on this version, after
  upgrading from 15.04.4)

  We have had 2 users (out of over a thousand) have this problem so far,
  and I've been unable reproduce it or trace a specific cause but we do
  know the order of events and the outcome:

  They copy a page from another user
  Change content or add some new content
  Attempt to change the layout (say from 3 columns to 2 columns)

  Something goes wrong while the layout is being changed and the data in
  the table view_rows_columns no longer matches what's in the view
  table, and the page won't load anymore.

  As more users encounter this problem (and I'm assuming they will) I
  will update this report.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1537861/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1626805] A change has been merged

2016-10-24 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/7185
Committed: 
https://git.mahara.org/mahara/mahara/commit/809d69550d884ed71d5e5b90a1b97f6d3fec35a4
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:16.04_STABLE

commit 809d69550d884ed71d5e5b90a1b97f6d3fec35a4
Author: Robert Lyon 
Date:   Fri Sep 23 13:44:42 2016 +1200

Bug 1626805: Allow the view constructor to fix missing layout info

Sometimes in MySql if many users are copying a page at once the
view_rows_columns information can get deleted.

As we can work out what the values should have been from other tables
we can regenerate it and add it back in.

If the view doesn't have a layout set it hasn't changed from when
first been made so we can make it the same as view type's template

To test: see bug report

behatnotneeded

Change-Id: I81c8e33dc1bc4121c1df97e1acbc981ad969271c
Signed-off-by: Robert Lyon 
(cherry picked from commit e95ebc66365b6e083d786600e0570bd652d3794f)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1626805

Title:
  Page becomes blank after a while

Status in Mahara:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Released

Bug description:
  There is an issue with race conditions and copying pages in Mahara
  when using a MySQL database.

  What happens is the values in view_rows_columns for the view get
  deleted somehow and this ends up making the page look empty/page
  blocks 'look' deleted.

  They still exist but the system doesn't know how to display the page.

  Luckily we can work out what the rows were by looking at data from a
  number of other tables and repopulate the table.

  I'll add a fix for this.

  To test:
  before patch:
  1) Create a page and add some blocks to it
  2) create another page and set the layout to multiple rows and add some 
blocks on each row
  3) View the pages to make sure they look ok, open each in a new tab for ease 
of checking
  4) Go to the db and then run:
    SELECT FROM view_rows_columns WHERE view = [viewid];
  to see what rows it has
    DELETE FROM view_rows_columns WHERE view = [viewid];
  and get the [viewid] from the urls off the pages

  5) Refresh the pages they should be blank (and you will get a bunch of
  errors in debugging on)

  6) Checkout patch and refresh the pages again you should see the pages
  looking correct again

  7) Check the db again and see the rows have returned and should be the
  same as before

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1626805/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1606744] A change has been merged

2016-10-24 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/7208
Committed: 
https://git.mahara.org/mahara/mahara/commit/a27a87a880d65f06001c20baa93f56571c960743
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:16.04_STABLE

commit a27a87a880d65f06001c20baa93f56571c960743
Author: Robert Lyon 
Date:   Sat Aug 6 13:00:31 2016 +1200

Bug 1606744: Correcting linking 'other' label for pieform select

The label tag had an incomplete 'for' attribute.

Change-Id: I2879b032cb63a33bb4a5caf40c9c70b2eea55d78
Signed-off-by: Robert Lyon 
(cherry picked from commit cf42e66bb8464f181149165f81c24b8d57e0c45e)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1606744

Title:
  Accessibility - Select 'other' text field label incorrect

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Released
Status in Mahara 15.10 series:
  Fix Released
Status in Mahara 16.04 series:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Released

Bug description:
  Mahara: master

  Input text fields should have a label and/or use the 'aria-labelled
  by' property to bind multiple inputs to a label.

  Please refer to: http://webaim.org/techniques/forms/controls#input

  An example where it is needed is in the screen
  (artefact/internal/socialprofile.php):

  * Social media > New social media account

  The input box (id=editprofileform_profiletype_other) next to "Other"
  is not linked to a label. Screen readers refer to it as "edit".

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1606744/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1606744] Re: Accessibility - Select 'other' text field label incorrect

2016-10-24 Thread Robert Lyon
** Changed in: mahara/16.04
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1606744

Title:
  Accessibility - Select 'other' text field label incorrect

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Released
Status in Mahara 15.10 series:
  Fix Released
Status in Mahara 16.04 series:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Released

Bug description:
  Mahara: master

  Input text fields should have a label and/or use the 'aria-labelled
  by' property to bind multiple inputs to a label.

  Please refer to: http://webaim.org/techniques/forms/controls#input

  An example where it is needed is in the screen
  (artefact/internal/socialprofile.php):

  * Social media > New social media account

  The input box (id=editprofileform_profiletype_other) next to "Other"
  is not linked to a label. Screen readers refer to it as "edit".

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1606744/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1544381] Re: "New views" block crashes after clearing Dwoo cache

2016-10-24 Thread Robert Lyon
** Changed in: mahara/15.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1544381

Title:
  "New views" block crashes after clearing Dwoo cache

Status in Mahara:
  Fix Released
Status in Mahara 15.10 series:
  Fix Released
Status in Mahara 16.04 series:
  Fix Released
Status in Mahara 16.10 series:
  Fix Released

Bug description:
  Sometimes when I'm testing things on my cleanurl https:// site I get
  this strange error where if I go to the homepage it tries to reload
  the page over and over.

  In the error logs I see:

  [WAR] b6 (lib/dwoo/dwoo/Dwoo/Loader.php:119) Plugin 
group_homepage_url can not be found, maybe you forgot to bind it if 
it's a custom plugin ?, referer: https://mahara-testing/
  Call stack (most recent first):, referer: https://mahara-testing/
 * Dwoo_Loader->loadPlugin("group_homepage_url", true) at 
/home/robertl/htdocs/mahara-testing/mahara/htdocs/lib/dwoo/dwoo/Dwoo/Compiler.php:2968,
 referer: https://mahara-testing/
 * Dwoo_Compiler->getPluginType("group_homepage_url") at 
/home/robertl/htdocs/mahara-testing/mahara/htdocs/lib/dwoo/dwoo/Dwoo/Compiler.php:1715,
 referer: https://mahara-testing/
 * Dwoo_Compiler->parseFunction("{if $views}, referer: 
https://mahara-testing/
   , referer: https://mahara-testing/
   {foreach ...", 500, 1902, false, "root", 535) at 
/home/robertl/htdocs/mahara-testing/mahara/htdocs/lib/dwoo/dwoo/Dwoo/Compiler.php:1365,
 referer: https://mahara-testing/
 * Dwoo_Compiler->parse("{if $views}, referer: https://mahara-testing/
   , referer: https://mahara-testing/
   {foreach ...", 500, null, false, "root", 535) at 
/home/robertl/htdocs/mahara-testing/mahara/htdocs/lib/dwoo/dwoo/Dwoo/Compiler.php:805,
 referer: https://mahara-testing/
 * Dwoo_Compiler->compile(object(Dwoo_Mahara), 
object(Dwoo_Template_Mahara)) at 
/home/robertl/htdocs/mahara-testing/mahara/htdocs/lib/dwoo/dwoo/Dwoo/Template/String.php:370,
 referer: https://mahara-testing/
 * Dwoo_Template_String->getCompiledTemplate(object(Dwoo_Mahara), null) at 
/home/robertl/htdocs/mahara-testing/mahara/htdocs/lib/dwoo/dwoo/Dwoo/Core.php:373,
 referer: https://mahara-testing/
 * Dwoo_Core->get(object(Dwoo_Template_Mahara), array(size 5)) at 
/home/robertl/htdocs/mahara-testing/mahara/htdocs/lib/dwoo/mahara/Dwoo_Mahara.php:123,
 referer: https://mahara-testing/
 * Dwoo_Mahara->fetch("blocktype:newviews:newviews.tpl") at 
/home/robertl/htdocs/mahara-testing/mahara/htdocs/blocktype/newviews/lib.php:59,
 referer: https://mahara-testing/
 * PluginBlocktypeNewViews::render_instance(object(BlockInstance)) at 
Unknown:0, referer: https://mahara-testing/

  
  If I make a dwoo plugin for group_homepage_url() the issue goes away

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1544381/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1386000] Re: Don't display submitted pages in "Pages / collections shared with this group"

2016-10-24 Thread Robert Lyon
** Changed in: mahara/15.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1386000

Title:
  Don't display submitted pages in "Pages / collections shared with this
  group"

Status in Mahara 15.10 series:
  Fix Released
Status in Mahara 16.04 series:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Released

Bug description:
  When a user submits a page / collection to a group, the group admin
  sees it both under "Pages / collections shared with this group" and
  "Submitted pages / collections". This is confusing as the pages /
  collections show up twice and it's not easy to see that they have
  actually been submitted only. I think it would be best to show
  submitted pages that have not been shared with the rest of the group
  only in "Submitted pages / collections".

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/15.10/+bug/1386000/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1533377] Re: Remove Persona (browserid) auth plugin by Nov 2016, because Mozilla is ending Persona support

2016-10-24 Thread Robert Lyon
** Changed in: mahara/15.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1533377

Title:
  Remove Persona (browserid) auth plugin by Nov 2016, because Mozilla is
  ending Persona support

Status in Mahara:
  Fix Released
Status in Mahara 15.04 series:
  Fix Released
Status in Mahara 15.10 series:
  Fix Released
Status in Mahara 16.04 series:
  In Progress

Bug description:
  Mozilla has recently announced that they're ending support for the
  Persona authentication service, in November 2016.:
  https://wiki.mozilla.org/Identity/Persona_Shutdown_Guidelines_for_Reliers

  Mahara has long shipped with a Persona (formerly "Browserid") auth
  plugin. We'll need to remove this plugin from the 16.10 release, and
  come up with a way to help existing sites migrate their users away
  from Persona.

  We should also consider how to help out the stable release sites in
  migrating users away from Persona. The Nov 2016 shutdown will be very
  close to the 16.10 release date, so asking sites to upgrade to 16.10
  to use any migration tool will be fairly demanding, particularly since
  15.04 will still be covered by its extended support lifetime. So for
  15.04, 15.10, and 16.04 sites, an optional Persona migration plugin is
  probably the best option. That way the functionality will be available
  to sites that need it, without shipping new features in minor
  upgrades.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1533377/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1595364] Re: Unable to remove first auth method via institution edit

2016-10-24 Thread Robert Lyon
** Changed in: mahara/15.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1595364

Title:
  Unable to remove first auth method via institution edit

Status in Mahara:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Released
Status in Mahara 16.04 series:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Released

Bug description:
  There is a bug in the code that stops one from removing the first
  option from auth methods for an institution

  This is due to the way we are using jQuery.remove()

  Get the console error:

  TypeError: elem is null
  while ((child = elem.firstChild)) {

  Due to: instances.remove(i)

  when i = 1 or above it removes the row relating to the count before
  rebuilding the rows but when i = 0 it removes all the rows and so
  nothing to rebuild

  Will fix this up so it actually removes the row relating to the id

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1595364/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1596809] Re: String missing in the Profile completion sidebar for annotation feedback

2016-10-24 Thread Robert Lyon
** Changed in: mahara/15.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1596809

Title:
  String missing in the Profile completion sidebar for annotation
  feedback

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Released
Status in Mahara 15.10 series:
  Fix Released
Status in Mahara 16.04 series:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Released

Bug description:
  After having set up a new Mahara and configured the Profile completion
  feature I noticed the following missing string in the Profile
  completion box :

  Add 3 audio files
  [[progress_annotation/artefact.annotation]] <
  Comment on 3 other users' pages

  Lastest version of Mahara 16.04_STABLE

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1596809/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1614805] Re: Make out-of-sequence plugin upgrades consistent in CLI upgrader & web upgrader

2016-10-24 Thread Robert Lyon
** Changed in: mahara/15.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1614805

Title:
  Make out-of-sequence plugin upgrades consistent in CLI upgrader & web
  upgrader

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Released
Status in Mahara 15.10 series:
  Fix Released
Status in Mahara 16.04 series:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Released

Bug description:
  In Bug 1614298 there were some differences of behavior between the CLI
  upgrader and the web upgrader, due to how they handled the out-of-
  sequence installation of the module/webservices plugin. This plugin is
  installed in the core lib/db/upgrade.php file, by a call to
  plugin_upgrade(), in order to make sure it gets installed instead of
  leaving it as an optional user-initiated installation.

  The CLI upgrader operates by running "check_upgrades()" at the
  beginning, which then looks at every component and plugin in Mahara to
  see which ones need to be upgraded. The return data includes the
  "installed" version number (retrieved from the database) and the "new"
  version number (from the version.php files on the filesystem). It then
  passes this data to "upgrade_mahara($data)", which loops over the
  array and runs the installer for each component.

  As a result, the webservices plugin was listed as needing upgrading,
  and then it got installed during the "core" upgrade step by the call
  to "upgrade_plugin()", and again by upgrade_mahara() when it looped
  through the listed plugins needing installation. The version number
  passed to the upgrade function by upgrade_mahara() was based on the
  initial call to check_upgrades() at the start of the script, causing
  the same upgrade block in the plugin's db/upgrade.php script to be
  executed twice.

  The AJAX upgrader didn't have this problem, because it re-checks the
  status of each plugin before running the upgrade function for that
  plugin. First the parent script calls "check_plugins()" to find all
  the plugins that need to be upgraded. Then it sends a request to
  upgrade.json.php for each upgrade component. And then upgrade.json.php
  calls check_plugins() again. It does this in order to retrieve the
  full data about the plugin; but it has the side effect of preventing
  the double-upgrading of plugins that were upgraded or installed out of
  order by core.

  It'd be best if both installation routes performed the same.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1614805/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1569121] Re: gulp-bless-css is deprecated

2016-10-24 Thread Robert Lyon
** Changed in: mahara/15.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1569121

Title:
  gulp-bless-css is deprecated

Status in Mahara:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Released
Status in Mahara 16.04 series:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Released

Bug description:
  One of the gulp packages we use in our theme build, "gulp-minify-css",
  is now deprecated and should be replaced with gulp-clean-css.

  https://www.npmjs.com/package/gulp-minify-css

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1569121/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1597117] Re: Can't save share access form on Windows in Edge

2016-10-24 Thread Robert Lyon
** Changed in: mahara/15.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1597117

Title:
  Can't save share access form on Windows in Edge

Status in Mahara:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Released
Status in Mahara 16.04 series:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Released

Bug description:
  https://mahara.org/interaction/forum/topic.php?id=7630

  I could replicate the issue in Windows 10 using Edge 13.

  Steps to replicate:

  1. Create a couple of user accounts and groups.
  2. Create a page as a user.
  3. Share the page with another user selecting the "Share -> Search for: 
Users" option so that you are prompted to search for a user's name. Select a 
name.
  4. Click the "Save" button.

  Repeat the same for "Groups" and "Friends".

  Expected result: The form saves properly.
  Actual result: You stay on the form.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1597117/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1560329] Re: The block config's "cancel" button breaks after a Pieform validation failure

2016-10-24 Thread Robert Lyon
** Changed in: mahara/15.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1560329

Title:
  The block config's "cancel" button breaks after a Pieform validation
  failure

Status in Mahara:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Released
Status in Mahara 16.04 series:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Released

Bug description:
  To replicate:

  1. Drag a new "external media" block into your page.
  2. In the block config modal that opens up, hit "submit" without filling in 
the required "URL or embed code" field
  3. Press "Submit"
  4. Wait for the form to reload and display the warning message telling you 
about the required field
  5. Once that loads up, press the "Cancel" or "Remove" button/link next to the 
"Submit" button.

  Expected result: The block config modal window closes, and the new
  external media block is no longer on your page

  Actual result: The screen reloads, and you now have an empty "external
  media" block on your page

  The reason this is happening, is because the Pieforms "cancel" button
  by default just reloads the form's action URL, or the cancel button's
  "goto" URL. When we load up the block config modal, we use Javascript
  code to rewire the cancel button so that it instead closes the modal
  and, if the block is new, deletes the block.

  However, when Pieforms fails validation, Pieforms actually removes the
  current form displayed on the page, and replaces it with a new form
  that contains the validation errors. Because this is a completely
  different form object, the "rewiring" that we did when we opened the
  modal no longer applies.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1560329/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1598962] Re: choose template .tpl needs styling

2016-10-24 Thread Robert Lyon
** Changed in: mahara/15.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1598962

Title:
  choose template .tpl needs styling

Status in Mahara:
  Fix Released
Status in Mahara 15.10 series:
  Fix Released
Status in Mahara 16.04 series:
  Fix Committed

Bug description:
  To test:

  1) On an installed site go to a page's edit screen, and make note if the id 
in the url eg id=50
  2) Via database set that view's theme to something non-existant, eg:

   UPDATE view SET theme = 'thundercats' WHERE id = 50;

  3) Reload the page - you should be taken to a 'choose theme' page

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1598962/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1613135] Re: Fix negative block_instance sortorders before running upgrade

2016-10-24 Thread Robert Lyon
** Changed in: mahara/15.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1613135

Title:
  Fix negative block_instance sortorders before running upgrade

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Released
Status in Mahara 15.10 series:
  Fix Released
Status in Mahara 16.04 series:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Released

Bug description:
  See:
  
https://mahara.org/interaction/forum/topic.php?id=7687&offset=0&limit=10#post30945

  For Bug 1528351 we added an upgrade block that corrects the
  block_instance sortorder drift that had been created by Bug 1523719.
  As a workaround to the uniqueness constraint on that column, this
  block temporarily moves the sortorders into the negative integerspace,
  and then re-orders them as positive numbers.

  However, we've had multiple reports of sites that have somehow got
  negative numbers already in their block_instance.sortorder column.
  These sites then error out during the upgrade, because the extant
  negative numbers turn into positive numbers, and then there's a
  uniqueness violation if another block being re-ordered overlaps with
  it.

  Ghada has written up a block of code that can fix this, and we've
  shared it with some affected sites via the forum. It should be easy to
  add it to the basic upgrade script, though. In order to reduce
  complications, we could preface it with a check to see whether there
  are negative sortorders in the database, and only run this additional
  step if we find any negatives.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1613135/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1611995] Re: Delete redundant profileicons.json.php file

2016-10-24 Thread Robert Lyon
** Changed in: mahara/15.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1611995

Title:
  Delete redundant profileicons.json.php file

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Released
Status in Mahara 15.10 series:
  Fix Released
Status in Mahara 16.04 series:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Released

Bug description:
  While code reviewing Bug 1590632, I noticed that there are two files
  named "profileicons.json.php" in the Mahara code base:

  htdocs/artefact/file/profileicons.json.php
  htdocs/artefact/internal/profileicons.json.php

  It looks like only the one under the "file" artefact is actually used
  (it's referenced in htdocs/artefact/file/profileicons.php). The other
  one was mistakenly left behind in commit
  c2356895f72ff2d9b7130084fc403ad1cd20d59a, when the profileicons were
  moved from being internal artefacts to file artefacts.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1611995/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1597536] Re: import_entry_requests table needs a ctime so we can clean up old partial requests

2016-10-24 Thread Robert Lyon
** Changed in: mahara/15.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1597536

Title:
  import_entry_requests table needs a ctime so we can clean up old
  partial requests

Status in Mahara:
  Fix Released
Status in Mahara 15.04 series:
  Fix Released
Status in Mahara 15.10 series:
  Fix Released
Status in Mahara 16.04 series:
  Fix Committed

Bug description:
  A ctime will allow us to clean up the old entries via a new (or
  possibly existing) cronjob

  And we need to make the stored path to the files be relative to
  dataroot rather than full path from '/' on server as we shouldn't be
  recording that info in the db.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1597536/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1534398] Re: Clean URLs created during user account creation, do not respect the "nousernames" setting

2016-10-24 Thread Robert Lyon
** Changed in: mahara/15.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1534398

Title:
  Clean URLs created during user account creation, do not respect the
  "nousernames" setting

Status in Mahara:
  Fix Committed
Status in Mahara 1.10 series:
  Won't Fix
Status in Mahara 15.04 series:
  Fix Released
Status in Mahara 15.10 series:
  Fix Released
Status in Mahara 16.04 series:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Released

Bug description:
  See: https://mahara.org/interaction/forum/topic.php?id=7479

  If you activate the "Never display usernames" site setting, and turn
  on clean URLs, the clean URL for new users' profile pages will still
  contain their username.

  If you do "regerenate clean URLs", however, the newly created clean
  URLs will *not* have the usernames.

  This is because the method regenerateurls_submit() in cleanurls.php
  respects the $CFG->nousernames setting, but the other places that
  generate clean URLs on account creation do not:

  - User->create() in auth/user.php
  - create_user() in lib/user.php

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1534398/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1614298] Re: Unable to upgrade if webservices contrib plugin already installed

2016-10-24 Thread Robert Lyon
** Changed in: mahara/15.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1614298

Title:
  Unable to upgrade if webservices contrib plugin already installed

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Released
Status in Mahara 15.10 series:
  Fix Released
Status in Mahara 16.04 series:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Released

Bug description:
  If the mahara site is already using the webservices contributed plugin

  https://github.com/piersharding/mahara-contrib-auth-webservice

  in a site older than 15.04 and you try to upgrade - the upgrade
  process fails

  This is due to renaming some db fields

  Will add a patch to fix up the variances

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1614298/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1594642] Re: missing sessionpath

2016-10-24 Thread Robert Lyon
** Changed in: mahara/15.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1594642

Title:
  missing sessionpath

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Released
Status in Mahara 15.10 series:
  Fix Released
Status in Mahara 16.04 series:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Released

Bug description:
  On latest master: commit 522312544d6a7e44ce83b37394db817df3c7d070

  I get this error when I try and close the site

  [WAR] 2c (lib/errors.php:508) An exception was thrown of class 
RuntimeException.
  THIS IS BAD and should be changed to something extending MaharaException,
  unless the exception is from a third party library.
  Original trace follows
  [WAR] 2c (auth/session.php:552) Directory name must not be empty.
  Call stack (most recent first):

  RecursiveDirectoryIterator->__construct("") at 
/home/robertl/htdocs/mahara-devel/mahara/htdocs/auth/session.php:552
  remove_all_sessions() at 
/home/robertl/htdocs/mahara-devel/mahara/htdocs/admin/index.php:106
  close_site_submit(object(Pieform), array(size 3)) at Unknown:0
  call_user_func_array("close_site_submit", array(size 2)) at 
/home/robertl/htdocs/mahara-devel/mahara/htdocs/lib/pieforms/pieform.php:540
  Pieform->__construct(array(size 3)) at 
/home/robertl/htdocs/mahara-devel/mahara/htdocs/lib/pieforms/pieform.php:161
  Pieform::process(array(size 3)) at 
/home/robertl/htdocs/mahara-devel/mahara/htdocs/lib/mahara.php:4494
  pieform(array(size 3)) at 
/home/robertl/htdocs/mahara-devel/mahara/htdocs/admin/index.php:61

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1594642/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1567152] Re: Undefined property warning on "Find groups" page

2016-10-24 Thread Robert Lyon
** Changed in: mahara/15.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1567152

Title:
  Undefined property warning on "Find groups" page

Status in Mahara:
  Fix Released
Status in Mahara 15.10 series:
  Fix Released
Status in Mahara 16.04 series:
  Fix Released
Status in Mahara 16.10 series:
  Fix Released

Bug description:
  I just noticed this warning when viewing the "Find groups" page:

  [WAR] 18 (lib/dwoo/dwoo/Dwoo/Core.php:1265) Undefined property: 
stdClass::$homeurl
  Call stack (most recent first):

  log_message("Undefined property: stdClass::$homeurl", 8, true, true, 
"/home/aaronw/www/mahara/htdocs/lib/dwoo/dwoo/Dwoo/...", 1265) at 
/home/aaronw/www/mahara/htdocs/lib/errors.php:439
  error(8, "Undefined property: stdClass::$homeurl", 
"/home/aaronw/www/mahara/htdocs/lib/dwoo/dwoo/Dwoo/...", 1265, array(size 5)) 
at /home/aaronw/www/mahara/htdocs/lib/dwoo/dwoo/Dwoo/Core.php:1265
  Dwoo_Core->readVarInto(array(size 3), object(stdClass), false) at 
/home/aaronw/dataroot/mahara/dwoo/compile/raw/home/aaronw/www/mahara/htdocs/theme/raw/templates/group/group.tpl.d17.php:12
  include("/home/aaronw/dataroot/mahara/dwoo/compile/raw/home...") at 
/home/aaronw/www/mahara/htdocs/lib/dwoo/dwoo/Dwoo/Core.php:374
  Dwoo_Core->get(object(Dwoo_Template_File), array(size 42)) at 
/home/aaronw/www/mahara/htdocs/lib/dwoo/dwoo/plugins/builtin/functions/include.php:66
  Dwoo_Plugin_include(object(Dwoo_Mahara), "group/group.tpl", null, null, 
null, "_root", null, array(size 2)) at 
/home/aaronw/dataroot/mahara/dwoo/compile/raw/home/aaronw/www/mahara/htdocs/theme/raw/templates/group/mygroupresults.tpl.d17.php:13
  include("/home/aaronw/dataroot/mahara/dwoo/compile/raw/home...") at 
/home/aaronw/www/mahara/htdocs/lib/dwoo/dwoo/Dwoo/Core.php:374
  Dwoo_Core->get(object(Dwoo_Template_File), array(size 40)) at 
/home/aaronw/www/mahara/htdocs/lib/dwoo/mahara/Dwoo_Mahara.php:123
  Dwoo_Mahara->fetch("group/mygroupresults.tpl") at 
/home/aaronw/www/mahara/htdocs/group/find.php:195

  To replicate:

  1. Clean Mahara install
  2. Create a group
  3. Create another user
  4. Log in as the other user
  5. Go to Groups -> Find groups

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1567152/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1612451] Re: Artefact blog upgrade gives error for embedded image

2016-10-24 Thread Robert Lyon
** Changed in: mahara/15.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1612451

Title:
  Artefact blog upgrade gives error for embedded image

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Released
Status in Mahara 15.10 series:
  Fix Released
Status in Mahara 16.04 series:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Released

Bug description:
  This error:

  Artefact with id 6 not found
  Call stack (most recent first):
  artefact_instance_from_id("6") at 
/home/robertl/htdocs/mahara-devel/mahara/htdocs/lib/embeddedimage.php:79
  EmbeddedImage::prepare_embedded_images(" This is  a test  tag
  in it but the underlying image itself has been deleted.

  We need to adjust EmbeddedImage::prepare_embedded_images() to check
  that the underlying image artefact still exists

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1612451/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1577251] Re: Should invalidate password reset links when a user changes their primary email address

2016-10-24 Thread Robert Lyon
** Changed in: mahara/15.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1577251

Title:
  Should invalidate password reset links when a user changes their
  primary email address

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Released
Status in Mahara 15.10 series:
  Fix Released
Status in Mahara 16.04 series:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Released

Bug description:
  As reported to us through the mahara.org security bug email address,
  by Sajibe kanti.

  When a user completes the "Forgot password?" password reset process,
  we delete any remaining password reset links for that user. However,
  we do not delete these if a user changes their primary email address.
  As the initial email points out, that could lead to an attack like
  this:

  1. Attacker compromises victim's Mahara account (without changing victim's 
password).
  2. Attacker changes their account's primary email address to the attacker's 
email address.
  3. Attacker uses "Forgot password" page to request a password reset email. 
They don't immediately use the link in the password reset email; instead they 
store it for later.
  4. Victim realizes their Mahara account is compromised, and logs in to their 
account.
  5. Victim attempts to secure their account by changing their password 
(through account settings page), and changing their primary email address back 
to their own.

  Expected result: The attacker is locked out of the victim's Mahara
  account

  Actual result: The attacker uses their stored password reset email to
  change the user's password and re-gain access to their account.

  
  We could help reduce this attack vector, by deleting any outstanding password 
reset emails for a user, when the user updates their account's primary email 
address. We should probably also delete any outstanding password reset emails 
for a user, when they change their account password through the account 
settings page. It may be worth considering other situations where password 
reset emails should be deleted, as well.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1577251/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1606744] Re: Accessibility - Select 'other' text field label incorrect

2016-10-24 Thread Robert Lyon
** Changed in: mahara/15.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1606744

Title:
  Accessibility - Select 'other' text field label incorrect

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Released
Status in Mahara 15.10 series:
  Fix Released
Status in Mahara 16.04 series:
  In Progress
Status in Mahara 16.10 series:
  Fix Released

Bug description:
  Mahara: master

  Input text fields should have a label and/or use the 'aria-labelled
  by' property to bind multiple inputs to a label.

  Please refer to: http://webaim.org/techniques/forms/controls#input

  An example where it is needed is in the screen
  (artefact/internal/socialprofile.php):

  * Social media > New social media account

  The input box (id=editprofileform_profiletype_other) next to "Other"
  is not linked to a label. Screen readers refer to it as "edit".

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1606744/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1527960] Re: Alphabetize the order of collections on the "Copy a page or collection" screen

2016-10-24 Thread Robert Lyon
** Changed in: mahara/15.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1527960

Title:
  Alphabetize the order of collections on the "Copy a page or
  collection" screen

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Released
Status in Mahara 15.10 series:
  Fix Released
Status in Mahara 16.04 series:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Released

Bug description:
  Mahara 15.10+

  On /view/choosetemplate.php?searchcollection=1 (when you click the
  "Copy a collection" button), the collection titles are supposed to be
  listed in alphabetical order, but they aren't. See the user manual at
  http://manual.mahara.org/en/15.10/portfolio/collections.html#copy-a
  -collection-by-searching-for-it (I left the sentence in for the
  collection titles to be listed in alphabetical order).

  On /view/choosetemplate.php (when you click the "Copy a page" button),
  the pages are correctly sorted in alphabetical order.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1527960/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1620394] Re: The institution static pages form is confusing

2016-10-24 Thread Robert Lyon
** Changed in: mahara/15.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1620394

Title:
  The institution static pages form is confusing

Status in Mahara:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Released
Status in Mahara 16.04 series:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Released

Bug description:
  In 15.04 the textarea/TinyMCE field was disabled if the 'Use site
  default' switch was set to 'Yes'

  This functionality was lost in later versions.

  It needs to be put back for UX experience.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1620394/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1626287] Re: default_notification_method function is missing in Multirecipient message system

2016-10-24 Thread Robert Lyon
** Changed in: mahara/15.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1626287

Title:
  default_notification_method function is missing in Multirecipient
  message system

Status in Mahara:
  Fix Released
Status in Mahara 15.04 series:
  Fix Released
Status in Mahara 15.10 series:
  Fix Released
Status in Mahara 16.04 series:
  Fix Committed

Bug description:
  The 'default_notification_method' function doesn't exist - so it is
  not callable by call_static_method() in
  ActivityTypeMultirecipientmessage.php

  
  There was a fix for this https://reviews.mahara.org/#/c/6520/2 as part of a 
bigger patch but this part needs to be backported to fix earlier branches

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1626287/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1631806] Re: Page descriptions not retained from group, institution and site pages

2016-10-24 Thread Robert Lyon
** Changed in: mahara/15.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1631806

Title:
  Page descriptions not retained from group, institution and site pages

Status in Mahara:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Released
Status in Mahara 16.04 series:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Released

Bug description:
  Reported at https://mahara.org/interaction/forum/topic.php?id=7731

  When copying a group, institution or site page, the page description
  is not copied, which makes it less useful for templates.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1631806/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1554247] Re: comments with attachments - attachment titles and links display on main portfolio page

2016-10-24 Thread Robert Lyon
** Changed in: mahara/15.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1554247

Title:
  comments with attachments - attachment titles and links display on
  main portfolio page

Status in Mahara:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Released
Status in Mahara 16.04 series:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Released

Bug description:
  I'm running 15.10.1 and have the following problem:

  We use the portfolios for a standard process that requires people to
  attach letters to note blocks on the page. When they do add the
  attachments, sometimes the attachment filenames (actually, links to
  the attachments) are visible on the main portfolio page, sometimes in
  a list and sometimes on top of one another. They "float" above the
  page, meaning that if I scroll the page up and down, the attachment
  filenames/links do not move up and down with the page.  This display
  bug is reproducible on multiple browsers (Safari, Chrome).

  I'd hoped that the 15.10.1 patch would resolve this issue, but it did
  not.

  thanks,
  Fran

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1554247/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1630753] Re: Webservices create user has problems with preferredname and studentid fields

2016-10-24 Thread Robert Lyon
** Changed in: mahara/15.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1630753

Title:
  Webservices create user has problems with preferredname and studentid
  fields

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Released
Status in Mahara 15.10 series:
  Fix Released

Bug description:
  This issue was fixed for 16.10+ but needs to be backported to earlier
  versions using webservices

  We need the studentid and preferredname parts of commit
  4bc12f6abbc832fbcd9766518796ae4a45351034

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1630753/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1630764] Re: Webservices update user has problems with preferredname and studentid fields

2016-10-24 Thread Robert Lyon
** Changed in: mahara/15.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1630764

Title:
  Webservices update user has problems with preferredname and studentid
  fields

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Released
Status in Mahara 15.10 series:
  Fix Released
Status in Mahara 16.04 series:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Released

Bug description:
  This is like bug 1630753 but this also needs to be fixed for 16.10+ as
  well

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1630764/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1587950] Re: Warning message not in a warning color

2016-10-24 Thread Robert Lyon
** Changed in: mahara/15.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1587950

Title:
  Warning message not in a warning color

Status in Mahara:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Released
Status in Mahara 16.04 series:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Released

Bug description:
  The warning message, that is intended to prevent users from
  accidentally editing/deleting a note in more than one place uses a
  color that does not convey the intent of a warning. This may lead to
  unintentional consequences, that might be prevented by a more suitable
  color[1].

  Mahara Version: 15.10.3

  [1]:https://infinum.co/the-capsized-eight/articles/ux-quick-tip-the-
  proper-way-of-handling-notifications

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1587950/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1577251] Re: Should invalidate password reset links when a user changes their primary email address

2016-10-24 Thread Robert Lyon
** Changed in: mahara/15.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1577251

Title:
  Should invalidate password reset links when a user changes their
  primary email address

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Released
Status in Mahara 15.10 series:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Released

Bug description:
  As reported to us through the mahara.org security bug email address,
  by Sajibe kanti.

  When a user completes the "Forgot password?" password reset process,
  we delete any remaining password reset links for that user. However,
  we do not delete these if a user changes their primary email address.
  As the initial email points out, that could lead to an attack like
  this:

  1. Attacker compromises victim's Mahara account (without changing victim's 
password).
  2. Attacker changes their account's primary email address to the attacker's 
email address.
  3. Attacker uses "Forgot password" page to request a password reset email. 
They don't immediately use the link in the password reset email; instead they 
store it for later.
  4. Victim realizes their Mahara account is compromised, and logs in to their 
account.
  5. Victim attempts to secure their account by changing their password 
(through account settings page), and changing their primary email address back 
to their own.

  Expected result: The attacker is locked out of the victim's Mahara
  account

  Actual result: The attacker uses their stored password reset email to
  change the user's password and re-gain access to their account.

  
  We could help reduce this attack vector, by deleting any outstanding password 
reset emails for a user, when the user updates their account's primary email 
address. We should probably also delete any outstanding password reset emails 
for a user, when they change their account password through the account 
settings page. It may be worth considering other situations where password 
reset emails should be deleted, as well.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1577251/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1606744] Re: Accessibility - Select 'other' text field label incorrect

2016-10-24 Thread Robert Lyon
** Changed in: mahara/15.04
   Status: Fix Committed => Fix Released

** Changed in: mahara/15.10
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1606744

Title:
  Accessibility - Select 'other' text field label incorrect

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Released
Status in Mahara 15.10 series:
  Fix Committed
Status in Mahara 16.04 series:
  In Progress
Status in Mahara 16.10 series:
  Fix Released

Bug description:
  Mahara: master

  Input text fields should have a label and/or use the 'aria-labelled
  by' property to bind multiple inputs to a label.

  Please refer to: http://webaim.org/techniques/forms/controls#input

  An example where it is needed is in the screen
  (artefact/internal/socialprofile.php):

  * Social media > New social media account

  The input box (id=editprofileform_profiletype_other) next to "Other"
  is not linked to a label. Screen readers refer to it as "edit".

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1606744/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1614805] Re: Make out-of-sequence plugin upgrades consistent in CLI upgrader & web upgrader

2016-10-24 Thread Robert Lyon
** Changed in: mahara/15.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1614805

Title:
  Make out-of-sequence plugin upgrades consistent in CLI upgrader & web
  upgrader

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Released
Status in Mahara 15.10 series:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Released

Bug description:
  In Bug 1614298 there were some differences of behavior between the CLI
  upgrader and the web upgrader, due to how they handled the out-of-
  sequence installation of the module/webservices plugin. This plugin is
  installed in the core lib/db/upgrade.php file, by a call to
  plugin_upgrade(), in order to make sure it gets installed instead of
  leaving it as an optional user-initiated installation.

  The CLI upgrader operates by running "check_upgrades()" at the
  beginning, which then looks at every component and plugin in Mahara to
  see which ones need to be upgraded. The return data includes the
  "installed" version number (retrieved from the database) and the "new"
  version number (from the version.php files on the filesystem). It then
  passes this data to "upgrade_mahara($data)", which loops over the
  array and runs the installer for each component.

  As a result, the webservices plugin was listed as needing upgrading,
  and then it got installed during the "core" upgrade step by the call
  to "upgrade_plugin()", and again by upgrade_mahara() when it looped
  through the listed plugins needing installation. The version number
  passed to the upgrade function by upgrade_mahara() was based on the
  initial call to check_upgrades() at the start of the script, causing
  the same upgrade block in the plugin's db/upgrade.php script to be
  executed twice.

  The AJAX upgrader didn't have this problem, because it re-checks the
  status of each plugin before running the upgrade function for that
  plugin. First the parent script calls "check_plugins()" to find all
  the plugins that need to be upgraded. Then it sends a request to
  upgrade.json.php for each upgrade component. And then upgrade.json.php
  calls check_plugins() again. It does this in order to retrieve the
  full data about the plugin; but it has the side effect of preventing
  the double-upgrading of plugins that were upgraded or installed out of
  order by core.

  It'd be best if both installation routes performed the same.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1614805/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1614298] Re: Unable to upgrade if webservices contrib plugin already installed

2016-10-24 Thread Robert Lyon
** Changed in: mahara/15.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1614298

Title:
  Unable to upgrade if webservices contrib plugin already installed

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Released
Status in Mahara 15.10 series:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Released

Bug description:
  If the mahara site is already using the webservices contributed plugin

  https://github.com/piersharding/mahara-contrib-auth-webservice

  in a site older than 15.04 and you try to upgrade - the upgrade
  process fails

  This is due to renaming some db fields

  Will add a patch to fix up the variances

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1614298/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1606744] A change has been merged

2016-10-24 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/7209
Committed: 
https://git.mahara.org/mahara/mahara/commit/9d845b54f757bd9ed06df3880676fd525b97afa5
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:15.10_STABLE

commit 9d845b54f757bd9ed06df3880676fd525b97afa5
Author: Robert Lyon 
Date:   Sat Aug 6 13:00:31 2016 +1200

Bug 1606744: Correcting linking 'other' label for pieform select

The label tag had an incomplete 'for' attribute.

Change-Id: I2879b032cb63a33bb4a5caf40c9c70b2eea55d78
Signed-off-by: Robert Lyon 
(cherry picked from commit cf42e66bb8464f181149165f81c24b8d57e0c45e)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1606744

Title:
  Accessibility - Select 'other' text field label incorrect

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Released
Status in Mahara 15.10 series:
  Fix Committed
Status in Mahara 16.04 series:
  In Progress
Status in Mahara 16.10 series:
  Fix Released

Bug description:
  Mahara: master

  Input text fields should have a label and/or use the 'aria-labelled
  by' property to bind multiple inputs to a label.

  Please refer to: http://webaim.org/techniques/forms/controls#input

  An example where it is needed is in the screen
  (artefact/internal/socialprofile.php):

  * Social media > New social media account

  The input box (id=editprofileform_profiletype_other) next to "Other"
  is not linked to a label. Screen readers refer to it as "edit".

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1606744/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1527960] Re: Alphabetize the order of collections on the "Copy a page or collection" screen

2016-10-24 Thread Robert Lyon
** Changed in: mahara/15.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1527960

Title:
  Alphabetize the order of collections on the "Copy a page or
  collection" screen

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Released
Status in Mahara 15.10 series:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Released

Bug description:
  Mahara 15.10+

  On /view/choosetemplate.php?searchcollection=1 (when you click the
  "Copy a collection" button), the collection titles are supposed to be
  listed in alphabetical order, but they aren't. See the user manual at
  http://manual.mahara.org/en/15.10/portfolio/collections.html#copy-a
  -collection-by-searching-for-it (I left the sentence in for the
  collection titles to be listed in alphabetical order).

  On /view/choosetemplate.php (when you click the "Copy a page" button),
  the pages are correctly sorted in alphabetical order.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1527960/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1611995] Re: Delete redundant profileicons.json.php file

2016-10-24 Thread Robert Lyon
** Changed in: mahara/15.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1611995

Title:
  Delete redundant profileicons.json.php file

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Released
Status in Mahara 15.10 series:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Released

Bug description:
  While code reviewing Bug 1590632, I noticed that there are two files
  named "profileicons.json.php" in the Mahara code base:

  htdocs/artefact/file/profileicons.json.php
  htdocs/artefact/internal/profileicons.json.php

  It looks like only the one under the "file" artefact is actually used
  (it's referenced in htdocs/artefact/file/profileicons.php). The other
  one was mistakenly left behind in commit
  c2356895f72ff2d9b7130084fc403ad1cd20d59a, when the profileicons were
  moved from being internal artefacts to file artefacts.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1611995/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1626287] Re: default_notification_method function is missing in Multirecipient message system

2016-10-24 Thread Robert Lyon
** Changed in: mahara/15.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1626287

Title:
  default_notification_method function is missing in Multirecipient
  message system

Status in Mahara:
  Fix Released
Status in Mahara 15.04 series:
  Fix Released
Status in Mahara 15.10 series:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed

Bug description:
  The 'default_notification_method' function doesn't exist - so it is
  not callable by call_static_method() in
  ActivityTypeMultirecipientmessage.php

  
  There was a fix for this https://reviews.mahara.org/#/c/6520/2 as part of a 
bigger patch but this part needs to be backported to fix earlier branches

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1626287/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1630764] Re: Webservices update user has problems with preferredname and studentid fields

2016-10-24 Thread Robert Lyon
** Changed in: mahara/15.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1630764

Title:
  Webservices update user has problems with preferredname and studentid
  fields

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Released
Status in Mahara 15.10 series:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Released

Bug description:
  This is like bug 1630753 but this also needs to be fixed for 16.10+ as
  well

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1630764/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1534398] Re: Clean URLs created during user account creation, do not respect the "nousernames" setting

2016-10-24 Thread Robert Lyon
** Changed in: mahara/15.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1534398

Title:
  Clean URLs created during user account creation, do not respect the
  "nousernames" setting

Status in Mahara:
  Fix Committed
Status in Mahara 1.10 series:
  Won't Fix
Status in Mahara 15.04 series:
  Fix Released
Status in Mahara 15.10 series:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Released

Bug description:
  See: https://mahara.org/interaction/forum/topic.php?id=7479

  If you activate the "Never display usernames" site setting, and turn
  on clean URLs, the clean URL for new users' profile pages will still
  contain their username.

  If you do "regerenate clean URLs", however, the newly created clean
  URLs will *not* have the usernames.

  This is because the method regenerateurls_submit() in cleanurls.php
  respects the $CFG->nousernames setting, but the other places that
  generate clean URLs on account creation do not:

  - User->create() in auth/user.php
  - create_user() in lib/user.php

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1534398/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1594642] Re: missing sessionpath

2016-10-24 Thread Robert Lyon
** Changed in: mahara/15.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1594642

Title:
  missing sessionpath

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Released
Status in Mahara 15.10 series:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Released

Bug description:
  On latest master: commit 522312544d6a7e44ce83b37394db817df3c7d070

  I get this error when I try and close the site

  [WAR] 2c (lib/errors.php:508) An exception was thrown of class 
RuntimeException.
  THIS IS BAD and should be changed to something extending MaharaException,
  unless the exception is from a third party library.
  Original trace follows
  [WAR] 2c (auth/session.php:552) Directory name must not be empty.
  Call stack (most recent first):

  RecursiveDirectoryIterator->__construct("") at 
/home/robertl/htdocs/mahara-devel/mahara/htdocs/auth/session.php:552
  remove_all_sessions() at 
/home/robertl/htdocs/mahara-devel/mahara/htdocs/admin/index.php:106
  close_site_submit(object(Pieform), array(size 3)) at Unknown:0
  call_user_func_array("close_site_submit", array(size 2)) at 
/home/robertl/htdocs/mahara-devel/mahara/htdocs/lib/pieforms/pieform.php:540
  Pieform->__construct(array(size 3)) at 
/home/robertl/htdocs/mahara-devel/mahara/htdocs/lib/pieforms/pieform.php:161
  Pieform::process(array(size 3)) at 
/home/robertl/htdocs/mahara-devel/mahara/htdocs/lib/mahara.php:4494
  pieform(array(size 3)) at 
/home/robertl/htdocs/mahara-devel/mahara/htdocs/admin/index.php:61

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1594642/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1596809] Re: String missing in the Profile completion sidebar for annotation feedback

2016-10-24 Thread Robert Lyon
** Changed in: mahara/15.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1596809

Title:
  String missing in the Profile completion sidebar for annotation
  feedback

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Released
Status in Mahara 15.10 series:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Released

Bug description:
  After having set up a new Mahara and configured the Profile completion
  feature I noticed the following missing string in the Profile
  completion box :

  Add 3 audio files
  [[progress_annotation/artefact.annotation]] <
  Comment on 3 other users' pages

  Lastest version of Mahara 16.04_STABLE

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1596809/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1533377] Re: Remove Persona (browserid) auth plugin by Nov 2016, because Mozilla is ending Persona support

2016-10-24 Thread Robert Lyon
** Changed in: mahara/15.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1533377

Title:
  Remove Persona (browserid) auth plugin by Nov 2016, because Mozilla is
  ending Persona support

Status in Mahara:
  Fix Released
Status in Mahara 15.04 series:
  Fix Released
Status in Mahara 15.10 series:
  Fix Committed
Status in Mahara 16.04 series:
  In Progress

Bug description:
  Mozilla has recently announced that they're ending support for the
  Persona authentication service, in November 2016.:
  https://wiki.mozilla.org/Identity/Persona_Shutdown_Guidelines_for_Reliers

  Mahara has long shipped with a Persona (formerly "Browserid") auth
  plugin. We'll need to remove this plugin from the 16.10 release, and
  come up with a way to help existing sites migrate their users away
  from Persona.

  We should also consider how to help out the stable release sites in
  migrating users away from Persona. The Nov 2016 shutdown will be very
  close to the 16.10 release date, so asking sites to upgrade to 16.10
  to use any migration tool will be fairly demanding, particularly since
  15.04 will still be covered by its extended support lifetime. So for
  15.04, 15.10, and 16.04 sites, an optional Persona migration plugin is
  probably the best option. That way the functionality will be available
  to sites that need it, without shipping new features in minor
  upgrades.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1533377/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1612451] Re: Artefact blog upgrade gives error for embedded image

2016-10-24 Thread Robert Lyon
** Changed in: mahara/15.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1612451

Title:
  Artefact blog upgrade gives error for embedded image

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Released
Status in Mahara 15.10 series:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Released

Bug description:
  This error:

  Artefact with id 6 not found
  Call stack (most recent first):
  artefact_instance_from_id("6") at 
/home/robertl/htdocs/mahara-devel/mahara/htdocs/lib/embeddedimage.php:79
  EmbeddedImage::prepare_embedded_images(" This is  a test  tag
  in it but the underlying image itself has been deleted.

  We need to adjust EmbeddedImage::prepare_embedded_images() to check
  that the underlying image artefact still exists

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1612451/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1597536] Re: import_entry_requests table needs a ctime so we can clean up old partial requests

2016-10-24 Thread Robert Lyon
** Changed in: mahara/15.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1597536

Title:
  import_entry_requests table needs a ctime so we can clean up old
  partial requests

Status in Mahara:
  Fix Released
Status in Mahara 15.04 series:
  Fix Released
Status in Mahara 15.10 series:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed

Bug description:
  A ctime will allow us to clean up the old entries via a new (or
  possibly existing) cronjob

  And we need to make the stored path to the files be relative to
  dataroot rather than full path from '/' on server as we shouldn't be
  recording that info in the db.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1597536/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1613135] Re: Fix negative block_instance sortorders before running upgrade

2016-10-24 Thread Robert Lyon
** Changed in: mahara/15.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1613135

Title:
  Fix negative block_instance sortorders before running upgrade

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Released
Status in Mahara 15.10 series:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Released

Bug description:
  See:
  
https://mahara.org/interaction/forum/topic.php?id=7687&offset=0&limit=10#post30945

  For Bug 1528351 we added an upgrade block that corrects the
  block_instance sortorder drift that had been created by Bug 1523719.
  As a workaround to the uniqueness constraint on that column, this
  block temporarily moves the sortorders into the negative integerspace,
  and then re-orders them as positive numbers.

  However, we've had multiple reports of sites that have somehow got
  negative numbers already in their block_instance.sortorder column.
  These sites then error out during the upgrade, because the extant
  negative numbers turn into positive numbers, and then there's a
  uniqueness violation if another block being re-ordered overlaps with
  it.

  Ghada has written up a block of code that can fix this, and we've
  shared it with some affected sites via the forum. It should be easy to
  add it to the basic upgrade script, though. In order to reduce
  complications, we could preface it with a check to see whether there
  are negative sortorders in the database, and only run this additional
  step if we find any negatives.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1613135/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1630753] Re: Webservices create user has problems with preferredname and studentid fields

2016-10-24 Thread Robert Lyon
** Changed in: mahara/15.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1630753

Title:
  Webservices create user has problems with preferredname and studentid
  fields

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Released
Status in Mahara 15.10 series:
  Fix Committed

Bug description:
  This issue was fixed for 16.10+ but needs to be backported to earlier
  versions using webservices

  We need the studentid and preferredname parts of commit
  4bc12f6abbc832fbcd9766518796ae4a45351034

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1630753/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1533377] Re: Remove Persona (browserid) auth plugin by Nov 2016, because Mozilla is ending Persona support

2016-10-24 Thread Robert Lyon
** Changed in: mahara/15.04
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1533377

Title:
  Remove Persona (browserid) auth plugin by Nov 2016, because Mozilla is
  ending Persona support

Status in Mahara:
  Fix Released
Status in Mahara 15.04 series:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Committed
Status in Mahara 16.04 series:
  In Progress

Bug description:
  Mozilla has recently announced that they're ending support for the
  Persona authentication service, in November 2016.:
  https://wiki.mozilla.org/Identity/Persona_Shutdown_Guidelines_for_Reliers

  Mahara has long shipped with a Persona (formerly "Browserid") auth
  plugin. We'll need to remove this plugin from the 16.10 release, and
  come up with a way to help existing sites migrate their users away
  from Persona.

  We should also consider how to help out the stable release sites in
  migrating users away from Persona. The Nov 2016 shutdown will be very
  close to the 16.10 release date, so asking sites to upgrade to 16.10
  to use any migration tool will be fairly demanding, particularly since
  15.04 will still be covered by its extended support lifetime. So for
  15.04, 15.10, and 16.04 sites, an optional Persona migration plugin is
  probably the best option. That way the functionality will be available
  to sites that need it, without shipping new features in minor
  upgrades.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1533377/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1606744] A change has been merged

2016-10-24 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/7210
Committed: 
https://git.mahara.org/mahara/mahara/commit/586dcf1a6af7bfcb4c7868be7e4044214887f407
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:15.04_STABLE

commit 586dcf1a6af7bfcb4c7868be7e4044214887f407
Author: Robert Lyon 
Date:   Sat Aug 6 13:00:31 2016 +1200

Bug 1606744: Correcting linking 'other' label for pieform select

The label tag had an incomplete 'for' attribute.

Change-Id: I2879b032cb63a33bb4a5caf40c9c70b2eea55d78
Signed-off-by: Robert Lyon 
(cherry picked from commit cf42e66bb8464f181149165f81c24b8d57e0c45e)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1606744

Title:
  Accessibility - Select 'other' text field label incorrect

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Committed
Status in Mahara 15.10 series:
  In Progress
Status in Mahara 16.04 series:
  In Progress
Status in Mahara 16.10 series:
  Fix Released

Bug description:
  Mahara: master

  Input text fields should have a label and/or use the 'aria-labelled
  by' property to bind multiple inputs to a label.

  Please refer to: http://webaim.org/techniques/forms/controls#input

  An example where it is needed is in the screen
  (artefact/internal/socialprofile.php):

  * Social media > New social media account

  The input box (id=editprofileform_profiletype_other) next to "Other"
  is not linked to a label. Screen readers refer to it as "edit".

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1606744/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1606744] Re: Accessibility - Select 'other' text field label incorrect

2016-10-24 Thread Robert Lyon
** Changed in: mahara/15.04
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1606744

Title:
  Accessibility - Select 'other' text field label incorrect

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Committed
Status in Mahara 15.10 series:
  In Progress
Status in Mahara 16.04 series:
  In Progress
Status in Mahara 16.10 series:
  Fix Released

Bug description:
  Mahara: master

  Input text fields should have a label and/or use the 'aria-labelled
  by' property to bind multiple inputs to a label.

  Please refer to: http://webaim.org/techniques/forms/controls#input

  An example where it is needed is in the screen
  (artefact/internal/socialprofile.php):

  * Social media > New social media account

  The input box (id=editprofileform_profiletype_other) next to "Other"
  is not linked to a label. Screen readers refer to it as "edit".

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1606744/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1533377] A change has been merged

2016-10-24 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/7177
Committed: 
https://git.mahara.org/mahara/mahara/commit/921bfa492962483264ebc5e4b993026f8750d7a8
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:15.04_STABLE

commit 921bfa492962483264ebc5e4b993026f8750d7a8
Author: Aaron Wells 
Date:   Tue Sep 27 01:47:03 2016 +1300

Bug 1533377: Browserid end-of-life migration script

This patch removes all authentication functionality
from the browserid auth plugin. It adds a script,
accessible through the plugin's configuration page,
to migrate user accounts from browserid to
internal auth.

Also includes changes to allow users to be searched
by authtype, and to prevent non-useable plugins
from being enabled on the plugin config page.

Change-Id: I4e8bd9fc4d2fb2ccaa1845fda533c9373ec251bd
behatnotneeded: Can't test with behat
Signed-off-by: Robert Lyon 

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1533377

Title:
  Remove Persona (browserid) auth plugin by Nov 2016, because Mozilla is
  ending Persona support

Status in Mahara:
  Fix Released
Status in Mahara 15.04 series:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Committed
Status in Mahara 16.04 series:
  In Progress

Bug description:
  Mozilla has recently announced that they're ending support for the
  Persona authentication service, in November 2016.:
  https://wiki.mozilla.org/Identity/Persona_Shutdown_Guidelines_for_Reliers

  Mahara has long shipped with a Persona (formerly "Browserid") auth
  plugin. We'll need to remove this plugin from the 16.10 release, and
  come up with a way to help existing sites migrate their users away
  from Persona.

  We should also consider how to help out the stable release sites in
  migrating users away from Persona. The Nov 2016 shutdown will be very
  close to the 16.10 release date, so asking sites to upgrade to 16.10
  to use any migration tool will be fairly demanding, particularly since
  15.04 will still be covered by its extended support lifetime. So for
  15.04, 15.10, and 16.04 sites, an optional Persona migration plugin is
  probably the best option. That way the functionality will be available
  to sites that need it, without shipping new features in minor
  upgrades.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1533377/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1636090] A change has been merged

2016-10-24 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/7205
Committed: 
https://git.mahara.org/mahara/mahara/commit/bd5e7de413f3c6062891bc583eefcc25e2dd7fa0
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:16.10_STABLE

commit bd5e7de413f3c6062891bc583eefcc25e2dd7fa0
Author: Ghada El-Zoghbi 
Date:   Mon Oct 24 17:59:09 2016 +1100

Bug #1636090: Increase execution time during fix for users during
upgrade.

Large Maharas with thousands of users run into max execution
time errors.

behatnotneeded

Change-Id: Ie9d5e9d1edb6cd3682afb93e435ebb2d01be355e

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1636090

Title:
   Execution timeout during 16.10 upgrade when fixing broken user data

Status in Mahara:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Committed
Status in Mahara 17.04 series:
  Fix Committed

Bug description:
  Mahara: 16.10.0
  DB: Postgres
  OS: Linux
  Browser: FF

  While upgrading from 16.04 to 16.10, we are getting the following
  error:

  PHP Fatal error:  Maximum execution time of 30 seconds exceeded in 
/var/www/clients/mahara/htdocs/lib/mahara.php on line 1569
  PHP Stack trace:
  PHP   1. {main}() /var/www/clients/mahara/htdocs/admin/cli/upgrade.php:0
  PHP   2. upgrade_mahara() 
/var/www/clients/mahara/htdocs/admin/cli/upgrade.php:53
  PHP   3. upgrade_core() /var/www/clients/mahara/htdocs/lib/mahara.php:265
  PHP   4. xmldb_core_upgrade() 
/var/www/clients/mahara/htdocs/lib/upgrade.php:347
  PHP   5. set_profile_field() 
/var/www/clients/mahara/htdocs/lib/db/upgrade.php:4733
  PHP   6. safe_require() /var/www/clients/mahara/htdocs/lib/user.php:536

  We have over 45K users in the DB and it's timing out.

  
  I've fixed it by adding the following immediately after 'if ($oldversion < 
2016090206) {':

  $cur_max_execution_time = @ini_get('max_execution_time');
  ini_set('max_execution_time', 0);

  
  And, at the end of the if statement (to set the time back to the original 
timeout):
  ini_set('max_execution_time', $cur_max_execution_time);


  I didn't use raise_time_limit(0) as it didn't seem to make a
  difference. It still timeout after 30 seconds.

  
  Thanks,
  Ghada

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1636090/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1636090] Re: Execution timeout during 16.10 upgrade when fixing broken user data

2016-10-24 Thread Robert Lyon
** Changed in: mahara/16.10
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1636090

Title:
   Execution timeout during 16.10 upgrade when fixing broken user data

Status in Mahara:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Committed
Status in Mahara 17.04 series:
  Fix Committed

Bug description:
  Mahara: 16.10.0
  DB: Postgres
  OS: Linux
  Browser: FF

  While upgrading from 16.04 to 16.10, we are getting the following
  error:

  PHP Fatal error:  Maximum execution time of 30 seconds exceeded in 
/var/www/clients/mahara/htdocs/lib/mahara.php on line 1569
  PHP Stack trace:
  PHP   1. {main}() /var/www/clients/mahara/htdocs/admin/cli/upgrade.php:0
  PHP   2. upgrade_mahara() 
/var/www/clients/mahara/htdocs/admin/cli/upgrade.php:53
  PHP   3. upgrade_core() /var/www/clients/mahara/htdocs/lib/mahara.php:265
  PHP   4. xmldb_core_upgrade() 
/var/www/clients/mahara/htdocs/lib/upgrade.php:347
  PHP   5. set_profile_field() 
/var/www/clients/mahara/htdocs/lib/db/upgrade.php:4733
  PHP   6. safe_require() /var/www/clients/mahara/htdocs/lib/user.php:536

  We have over 45K users in the DB and it's timing out.

  
  I've fixed it by adding the following immediately after 'if ($oldversion < 
2016090206) {':

  $cur_max_execution_time = @ini_get('max_execution_time');
  ini_set('max_execution_time', 0);

  
  And, at the end of the if statement (to set the time back to the original 
timeout):
  ini_set('max_execution_time', $cur_max_execution_time);


  I didn't use raise_time_limit(0) as it didn't seem to make a
  difference. It still timeout after 30 seconds.

  
  Thanks,
  Ghada

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1636090/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1563143] Re: Breakage around dropzone error hander callbacks

2016-10-24 Thread Robert Lyon
** Changed in: mahara/16.04
Milestone: 16.04.4 => 16.04.5

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1563143

Title:
  Breakage around dropzone error hander callbacks

Status in Mahara:
  In Progress
Status in Mahara 15.10 series:
  Fix Released
Status in Mahara 16.04 series:
  Triaged
Status in Mahara 16.10 series:
  Triaged

Bug description:
  Catalyst received a bug report from a customer who is using recent
  Mahara (15.10.1).

  The initial bug report is that if "Require agreement" is enabled in
  
admin/extensions/pluginconfig.php?plugintype=artefact&pluginname=file&type=file
  and a user attempts to upload a file without first ticking the
  agreement box, they get a message saying the box needs to be ticked
  but the preview of the file also has a green tick (implying it was
  actually uploaded).

  In my investigation of the issue, I found multiple issues:

  1) Dropzone's internal handling puts the green tick there on the basis of the 
server status. Setting the http response code to 403 (Forbidden) fixed that.
  2) Dropzone's internal handling assumes that any text returned when an error 
occurs is an HTML (not JSON) description of the error, and therefore puts the 
raw HTML in 'tooltip' for the red X. The raw HTML also ends up being displayed 
in the files_filebrowser_upload_messages div because the JSON.parse doesn't get 
called in the error handler function.

  I have prepared a patch that addresses both these issues, but I don't
  think it's the entire solution. I'd also suggest that beginning the
  upload should be rejected if the box hasn't been ticked. This would
  avoid the scenario wherein a user attempts to upload a large file on a
  slow connection, only to be told after the file has been sent that
  it's not been saved only because they didn't tick the box.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1563143/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1443239] Re: Warning in Mahara logs when a MaharaDroid user has no tags in their Mahara account

2016-10-24 Thread Robert Lyon
** Changed in: mahara/16.04
Milestone: 16.04.4 => 16.04.5

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1443239

Title:
  Warning in Mahara logs when a MaharaDroid user has no tags in their
  Mahara account

Status in Mahara:
  Confirmed
Status in Mahara 15.10 series:
  Won't Fix
Status in Mahara 16.04 series:
  Confirmed
Status in Mahara 16.10 series:
  Confirmed

Bug description:
  This is a bug in the Mahara PHP code which interfaces with the
  MaharaDroid android app. See
  https://github.com/MaharaProject/maharadroid/issues/6 for the
  MaharaDroid side of this bug.

  To replicate:

  1. Create a new Mahara account
  2. Connect it to MaharaDroid
  3. Try to upload a file via MaharaDroid

  Result: You see this warning in the Apache logs:

  
   [Tue Jan 14 11:07:18 2014] [error] [client 10.22.33.88] [WAR] 88 
(api/mobile/sync.php:77) Invalid argument supplied for foreach()
   [Tue Jan 14 11:07:18 2014] [error] [client 10.22.33.88] Call stack (most 
recent first):
   [Tue Jan 14 11:07:18 2014] [error] [client 10.22.33.88] * 
log_message("Invalid argument supplied for foreach()", 8, true, true, 
"/home/demo/code/mahara/htdocs/api/mobile/sync.php", 77) at 
/home/demo/code/mahara/htdocs/lib/errors.php:430
   [Tue Jan 14 11:07:18 2014] [error] [client 10.22.33.88] * error(2, "Invalid 
argument supplied for foreach()", 
"/home/demo/code/mahara/htdocs/api/mobile/sync.php", 77, array(size 59)) at 
/home/demo/code/mahara/htdocs/api/mobile/sync.php:77
   [Tue Jan 14 11:07:18 2014] [error] [client 10.22.33.88]

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1443239/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1513710] Re: Destructor methods that access global variables can cause crashes

2016-10-24 Thread Robert Lyon
** Changed in: mahara/16.04
Milestone: 16.04.4 => 16.04.5

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1513710

Title:
  Destructor methods that access global variables can cause crashes

Status in Mahara:
  Confirmed
Status in Mahara 16.04 series:
  Confirmed
Status in Mahara 16.10 series:
  Confirmed

Bug description:
  See : https://mahara.org/interaction/forum/topic.php?id=7397

  Here's the problem (which appears to be intermittent):

  1. ArtefactType has a destructor method, which gets called when an artefact 
object is garbage-collected by PHP.
  2. PHP runs destructor methods and garbage collects variables in no 
guaranteed order when exit() is called.
  3. Sometimes the ArtefactType destructor method tries to call DML methods, 
which use the global variable $db
  4. Apparently sometimes the $db global variable has already been garbage 
collected by the time the destructor runs
  5. This causes a fatal "method on a non-object" crash.

  It's unclear why this error has only started happening recently. It
  might be due to a change in the behavior of PHP's garbage collector,
  or it might be from new Mahara code leaving some artefacts with their
  $dirty flag set (which triggers that artefact commit).

  In either case, both global variables and implicit destructor methods
  are considered harmful design practices, in part because of this
  particular thing. So it's high time we got rid of these __destruct()
  methods.

  Alternatively, as a workaround for older Mahara versions, we could add
  some code to the top of each __destruct() method that re-creates the
  global $db if it's not set.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1513710/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1444182] Re: Leaving feedback on own page generates notification to self

2016-10-24 Thread Robert Lyon
** Changed in: mahara
Milestone: 16.04.4 => 16.04.5

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1444182

Title:
  Leaving feedback on own page generates notification to self

Status in Mahara:
  Confirmed

Bug description:
  We don't need to receive a notification when we comment on our own
  page as we already know we have done that.

  To test:

  1) Install fresh mahara
  2) Add a user: UserA
  3) Login as UserA and create a page
  4) Leave feedback on page (doesn't matter if first feeback or replying to 
other's feedback)
  5) Check inbox - there is a message both 'to' and 'from' UserA

  Will mark this as a low bug as it's more of an annoyance than the
  system being broken.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1444182/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1514275] Re: Add a minaccept to look for the "empty()" function called with a non-variable argument

2016-10-24 Thread Robert Lyon
** Changed in: mahara
Milestone: 16.04.4 => 16.04.5

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1514275

Title:
  Add a minaccept to look for the "empty()" function called with a non-
  variable argument

Status in Mahara:
  Confirmed

Bug description:
  We've had a few bugs now caused by people calling the PHP empty()
  function with a parameter that is not a single variable. (And at least
  one caused by putting empty() into a Dwoo template, where its argument
  was parsed by Dwoo into an expression.)

  This causes a problem because we support PHP 5.3+, and prior to PHP
  5.5 it causes a fatal exception if you try to call empty() with an
  argument that is not a single variable.

  I think this should actually be a pretty easy one to check for,
  fortunately. We just need to check for "empty(" followed by a
  character that isn't "$", so a regex like this: /\bempty\(\s*[^$]/i

  And in Dwoo templates, where empty() can't be used at all because
  there's no guarantee of what Dwoo will parse it into, we'd check for
  it in the form "empty()" or in the Dwoo tag pipe syntax "|empty":
  /(\bempty\(|\|empty\b)/i

  Note that any regex to check for this would need to be case-
  insensitive, because PHP function calls are not case sensitive.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1514275/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1626805] Re: Page becomes blank after a while

2016-10-24 Thread Robert Lyon
** Changed in: mahara/16.04
   Status: Confirmed => In Progress

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1626805

Title:
  Page becomes blank after a while

Status in Mahara:
  Fix Committed
Status in Mahara 16.04 series:
  In Progress
Status in Mahara 16.10 series:
  Fix Released

Bug description:
  There is an issue with race conditions and copying pages in Mahara
  when using a MySQL database.

  What happens is the values in view_rows_columns for the view get
  deleted somehow and this ends up making the page look empty/page
  blocks 'look' deleted.

  They still exist but the system doesn't know how to display the page.

  Luckily we can work out what the rows were by looking at data from a
  number of other tables and repopulate the table.

  I'll add a fix for this.

  To test:
  before patch:
  1) Create a page and add some blocks to it
  2) create another page and set the layout to multiple rows and add some 
blocks on each row
  3) View the pages to make sure they look ok, open each in a new tab for ease 
of checking
  4) Go to the db and then run:
    SELECT FROM view_rows_columns WHERE view = [viewid];
  to see what rows it has
    DELETE FROM view_rows_columns WHERE view = [viewid];
  and get the [viewid] from the urls off the pages

  5) Refresh the pages they should be blank (and you will get a bunch of
  errors in debugging on)

  6) Checkout patch and refresh the pages again you should see the pages
  looking correct again

  7) Check the db again and see the rows have returned and should be the
  same as before

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1626805/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1269170] Re: GD Image not being created during cron run

2016-10-24 Thread Robert Lyon
** Changed in: mahara/15.04
Milestone: 15.04.10 => None

** Changed in: mahara/15.04
   Status: Confirmed => Won't Fix

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1269170

Title:
  GD Image not being created during cron run

Status in Mahara:
  Invalid
Status in Mahara 15.04 series:
  Won't Fix
Status in Mahara 15.10 series:
  Invalid

Bug description:
  I get the following warnings when cron job 'cron_site_data_daily' runs
  - I'm not sure if it's specific to my data / machine / php version
  (which is 5.4) but I thought I'd mention them here in case others were
  having the same problems.

  The failure means that the statistic graphics are not generated.

  [WAR] 48 (lib/pear/Image/Canvas/GD/PNG.php:125) imagepng(): gd-png:  fatal 
libpng error: Wrote palette index exceeding num_palette
   Call stack (most recent first):
 * log_message("imagepng(): gd-png:  fatal libpng error: Wrote pal...", 8, 
true, true, "/mnt/data/s16/lib/pear/Image/Canvas/GD/PNG.php", 125) at 
/mnt/data/s16/lib/errors.php:430
 * error(2, "imagepng(): gd-png:  fatal libpng error: Wrote pal...", 
"/mnt/data/s16/lib/pear/Image/Canvas/GD/PNG.php", 125, array(size 1)) at 
Unknown:0
 * imagepng(resource(#8087), "/mnt/data/uploaddir/images/grouptypes.png") 
at /mnt/data/s16/lib/pear/Image/Canvas/GD/PNG.php:125
 * Image_Canvas_GD_PNG->save(array(size 1)) at 
/mnt/data/s16/lib/pear/Image/Graph.php:865
 * Image_Graph->_done(array(size 1)) at 
/mnt/data/s16/lib/pear/Image/Graph.php:787
 * Image_Graph->done(array(size 1)) at 
/mnt/data/s16/lib/registration.php:1164
 * group_type_graph() at /mnt/data/s16/lib/registration.php:2163
 * graph_site_data_daily() at /mnt/data/s16/lib/mahara.php:3009
 * cron_site_data_daily() at /mnt/data/s16/lib/cron.php:142
   
  [WAR] 48 (lib/pear/Image/Canvas/GD/PNG.php:125) imagepng(): gd-png error: 
setjmp returns error condition
   Call stack (most recent first):
 * log_message("imagepng(): gd-png error: setjmp returns error con...", 8, 
true, true, "/mnt/data/s16/lib/pear/Image/Canvas/GD/PNG.php", 125) at 
/mnt/data/s16/lib/errors.php:430
 * error(2, "imagepng(): gd-png error: setjmp returns error con...", 
"/mnt/data/s16/lib/pear/Image/Canvas/GD/PNG.php", 125, array(size 1)) at 
Unknown:0
 * imagepng(resource(#8087), "/mnt/data/uploaddir/images/grouptypes.png") 
at /mnt/data/s16/lib/pear/Image/Canvas/GD/PNG.php:125
 * Image_Canvas_GD_PNG->save(array(size 1)) at 
/mnt/data/s16/lib/pear/Image/Graph.php:865
 * Image_Graph->_done(array(size 1)) at 
/mnt/data/s16/lib/pear/Image/Graph.php:787
 * Image_Graph->done(array(size 1)) at 
/mnt/data/s16/lib/registration.php:1164
 * group_type_graph() at /mnt/data/s16/lib/registration.php:2163
 * graph_site_data_daily() at /mnt/data/s16/lib/mahara.php:3009
 * cron_site_data_daily() at /mnt/data/s16/lib/cron.php:142

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1269170/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1524581] Re: Extra spaces showing as  

2016-10-24 Thread Robert Lyon
** Changed in: mahara/15.04
Milestone: 15.04.10 => None

** Changed in: mahara/15.04
   Status: Confirmed => Won't Fix

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1524581

Title:
  Extra spaces showing as  

Status in Mahara:
  Invalid
Status in Mahara 15.04 series:
  Won't Fix
Status in Mahara 15.10 series:
  Invalid
Status in Mahara 16.04 series:
  Invalid

Bug description:
  Sending users messages with extra spaces between words displays weird
  in the "Message" section, couldn't produce in the subject field.

  Steps to reproduce:

  1) login to 15.04_STABLE
  2) create two users
  3) send message from one to the other with two or more spaces between words
  4) view the message

  Expected result:
  spaces within the text should not break and display weird

  Actual result:
  more than one space between a word or special char looks like this  

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1524581/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1499287] Re: Safari text box editing

2016-10-24 Thread Robert Lyon
** Changed in: mahara
Milestone: 15.04.10 => None

** Changed in: mahara
   Status: Triaged => Won't Fix

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1499287

Title:
  Safari text box editing

Status in Mahara:
  Won't Fix

Bug description:
  Hello,

  I've had several students with Macbooks and iPads raise an issue with
  being unable to save textboxes when editing pages using Safari. I
  don't think it's just a recent version issue (we're on Mahara
  15.04.2testing) but it came to my attention because I've had so many
  people ask about editing problems in the past couple of days - guess
  our newest student cohort are Mac fans!

  The pages they are specifically having trouble with are templates that they 
copy from a central location. The pages have multiple blocks of information on 
them, including several textboxes containing questions the students are asked 
to edit to provide answers for. Depending on the range of information the page 
layout can be complex but is usually two rows of 3-4 blocks of media & text.
  When they try to edit the textboxes at the bottom of the page, the editing 
box pops up at the bottom of the screen so that the 'Save' button is below the 
visible interface, and they don't seem to be able to move it to make the button 
visible on screen. They can scroll within the text editor a limited amount, but 
the save button is always below the screen.

  I've attached a screenshot example that a student sent me.
  Another student posted a workaround into our help forum - using the arrow 
keys to zoom the browser window to make contents smaller allowed the entire 
editor box to appear on screen - but I don't have a Mac device to verify that 
this works.

  Regards, Gordon.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1499287/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1533456] Re: (Non-flowplayer) embedded media overlaps over block config in Mahara 15.04

2016-10-24 Thread Robert Lyon
** Changed in: mahara
Milestone: 15.04.10 => None

** Changed in: mahara
   Status: In Progress => Won't Fix

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1533456

Title:
  (Non-flowplayer) embedded media overlaps over block config in Mahara
  15.04

Status in Mahara:
  Won't Fix

Bug description:
  This bug occurs only in Mahara 15.04. Not 1.10, not 15.10. I noticed
  it in Firefox. I haven't tried it in other browsers.

  The problem is that if you place a video file onto a page, and then
  you go to edit another block on the page, the video is displayed over
  the block config popup. This appears only to happen with the file
  types that are *not* handled by Flowplayer (.swf, .mpg, .avi)

  To replicate:

  1. Clean install of Mahara
  2. Go to 
/admin/extensions/pluginconfig.php?plugintype=blocktype&pluginname=file/internalmedia
 and activate all the media types
  3. Create a page
  4. On the page, place an "Embedded media" block, with an mpg file in it.
  5. Above the embedded media block, place a Text block

  Expected result: The block config for the Text block comes up and you can see 
it
  Actual result: The mpg file from the embedded media block, displays on top of 
the block config

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1533456/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1565197] Re: Selecting "Site journal" in "Recent journal entries" block in a group just spins

2016-10-24 Thread Robert Lyon
** Changed in: mahara/16.04
Milestone: 16.04.4 => 16.04.5

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1565197

Title:
  Selecting "Site journal" in "Recent journal entries" block in a group
  just spins

Status in Mahara:
  In Progress
Status in Mahara 16.04 series:
  Confirmed
Status in Mahara 16.10 series:
  Confirmed

Bug description:
  16.04.rc1

  How to test:

  1. Create a site journal as site admin and add 1 entry.
  2. Create a group as regular user
  3. Set up a group journal in that group and add 1 entry.
  4. Create a page.
  5. Place the "Recent journal entries" block onto the page and select the 
group and site journal.
  6. Expected result: The config is saved. Actual result: The config modal 
stays open and the spinning icon is displayed. If you only select the group 
journal everything is fine.

  Note: When you are the site admin and a member of the group, you can
  place the site journal onto the group page.

  There are other two related bugs that should be fixed at the same time:
  1. Bug #1565198: "Recent journal entries" block should mention journal 
context in config
  2. Bug #1565199: Journals that you can't add entries to appear in drop-down 
for "Add new entry" in "Recent journal entries" block

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1565197/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1189823] Re: Pieforms attempts to load renderer plugin even when already loaded

2016-10-24 Thread Robert Lyon
** Changed in: mahara/16.04
Milestone: 16.04.4 => 16.04.5

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1189823

Title:
  Pieforms attempts to load renderer plugin even when already loaded

Status in Mahara:
  Incomplete
Status in Mahara 16.04 series:
  Incomplete
Status in Mahara 16.10 series:
  Incomplete

Bug description:
  This prevents plugins from providing their own form renderers (useful
  for working around issues like #1181966 -- nested fieldsets are
  broken).

  I've attached a patch to the Pieforms library which changes the
  behaviour a little bit; if the renderer function already exists, we'll
  skip the loading process.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1189823/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1565199] Re: Journals that you can't add entries to appear in drop-down for "Add new entry" in "Recent journal entries" block

2016-10-24 Thread Robert Lyon
** Changed in: mahara/16.04
Milestone: 16.04.4 => 16.04.5

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1565199

Title:
  Journals that you can't add entries to appear in drop-down for "Add
  new entry" in "Recent journal entries" block

Status in Mahara:
  In Progress
Status in Mahara 16.04 series:
  Confirmed
Status in Mahara 16.10 series:
  Confirmed

Bug description:
  16.04.rc1

  You can place the "Recent journal entries" block on any page and when
  you place it on a personal or group page, you also see other journals,
  e.g. institution and site (on a personal page) and site (on a group
  page). However, when you include these journals in your block, they
  also appear in the drop-down menu where you can choose in which
  journal you want to create a new entry.

  When you choose an institution or site journal and are not an
  institution admin or site admin, you only see:

  Access denied
  You do not have access to view this page.

  [[youarenotasiteadmin/artefact.blog]]

  You should not be able to see the journals in the drop-down menu to
  which you cannot add an entry.

  There are other two related bugs that should be fixed at the same time:
  1. Bug #1565198: "Recent journal entries" block should mention journal 
context in config
  2. Bug #1565197: Selecting "Site journal" in "Recent journal entries" block 
in a group just spins

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1565199/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1614352] Re: "group_homepage_url() not defined" error on "Portfolio -> Pages" screen

2016-10-24 Thread Robert Lyon
** Changed in: mahara
Milestone: 16.04.4 => 16.04.5

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1614352

Title:
  "group_homepage_url() not defined" error on "Portfolio -> Pages"
  screen

Status in Mahara:
  Incomplete

Bug description:
  See
  https://mahara.org/interaction/forum/topic.php?id=7692&offset=0&limit=10

  This one's similar to bug 1544381, except the user reports that they
  experience it on the "Portfolio -> Pages" screen.

  I haven't been able to replicate the problem yet, though.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1614352/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1598962] Re: choose template .tpl needs styling

2016-10-24 Thread Robert Lyon
** Changed in: mahara/15.10
   Status: In Progress => Fix Committed

** Changed in: mahara/16.04
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1598962

Title:
  choose template .tpl needs styling

Status in Mahara:
  Fix Released
Status in Mahara 15.10 series:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed

Bug description:
  To test:

  1) On an installed site go to a page's edit screen, and make note if the id 
in the url eg id=50
  2) Via database set that view's theme to something non-existant, eg:

   UPDATE view SET theme = 'thundercats' WHERE id = 50;

  3) Reload the page - you should be taken to a 'choose theme' page

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1598962/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1598962] A change has been merged

2016-10-24 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/7199
Committed: 
https://git.mahara.org/mahara/mahara/commit/688b7b225d0277aede141a9fd9e79278f0709752
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:16.04_STABLE

commit 688b7b225d0277aede141a9fd9e79278f0709752
Author: Robert Lyon 
Date:   Tue Jul 5 11:09:43 2016 +1200

Bug 1598962: Styling the choose template .tpl

To be more inline with bootstrap stylings

Also passing in $view object so we can find the user's default theme
if the view's one doesn't exist rather than defaulting to 'default'

behatnotneeded

Change-Id: Ia4cc0552604698a1fd1aa2f6de666e82b6b86564
Signed-off-by: Robert Lyon 
(cherry picked from commit c021f20b0f692dcdd16c67f4237eb93fa58858f1)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1598962

Title:
  choose template .tpl needs styling

Status in Mahara:
  Fix Released
Status in Mahara 15.10 series:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed

Bug description:
  To test:

  1) On an installed site go to a page's edit screen, and make note if the id 
in the url eg id=50
  2) Via database set that view's theme to something non-existant, eg:

   UPDATE view SET theme = 'thundercats' WHERE id = 50;

  3) Reload the page - you should be taken to a 'choose theme' page

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1598962/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1598962] A change has been merged

2016-10-24 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/7200
Committed: 
https://git.mahara.org/mahara/mahara/commit/3c3e2a2822ceeb939856910ce6485028d7c10ff4
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:15.10_STABLE

commit 3c3e2a2822ceeb939856910ce6485028d7c10ff4
Author: Robert Lyon 
Date:   Tue Jul 5 11:09:43 2016 +1200

Bug 1598962: Styling the choose template .tpl

To be more inline with bootstrap stylings

Also passing in $view object so we can find the user's default theme
if the view's one doesn't exist rather than defaulting to 'default'

behatnotneeded

Change-Id: Ia4cc0552604698a1fd1aa2f6de666e82b6b86564
Signed-off-by: Robert Lyon 
(cherry picked from commit c021f20b0f692dcdd16c67f4237eb93fa58858f1)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1598962

Title:
  choose template .tpl needs styling

Status in Mahara:
  Fix Released
Status in Mahara 15.10 series:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed

Bug description:
  To test:

  1) On an installed site go to a page's edit screen, and make note if the id 
in the url eg id=50
  2) Via database set that view's theme to something non-existant, eg:

   UPDATE view SET theme = 'thundercats' WHERE id = 50;

  3) Reload the page - you should be taken to a 'choose theme' page

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1598962/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1533377] Re: Remove Persona (browserid) auth plugin by Nov 2016, because Mozilla is ending Persona support

2016-10-24 Thread Robert Lyon
** Changed in: mahara/15.10
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1533377

Title:
  Remove Persona (browserid) auth plugin by Nov 2016, because Mozilla is
  ending Persona support

Status in Mahara:
  Fix Released
Status in Mahara 15.04 series:
  In Progress
Status in Mahara 15.10 series:
  Fix Committed
Status in Mahara 16.04 series:
  In Progress

Bug description:
  Mozilla has recently announced that they're ending support for the
  Persona authentication service, in November 2016.:
  https://wiki.mozilla.org/Identity/Persona_Shutdown_Guidelines_for_Reliers

  Mahara has long shipped with a Persona (formerly "Browserid") auth
  plugin. We'll need to remove this plugin from the 16.10 release, and
  come up with a way to help existing sites migrate their users away
  from Persona.

  We should also consider how to help out the stable release sites in
  migrating users away from Persona. The Nov 2016 shutdown will be very
  close to the 16.10 release date, so asking sites to upgrade to 16.10
  to use any migration tool will be fairly demanding, particularly since
  15.04 will still be covered by its extended support lifetime. So for
  15.04, 15.10, and 16.04 sites, an optional Persona migration plugin is
  probably the best option. That way the functionality will be available
  to sites that need it, without shipping new features in minor
  upgrades.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1533377/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1533377] A change has been merged

2016-10-24 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/7178
Committed: 
https://git.mahara.org/mahara/mahara/commit/65261b076046d8ebb32f8b7923ece473a0686f9a
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:15.10_STABLE

commit 65261b076046d8ebb32f8b7923ece473a0686f9a
Author: Aaron Wells 
Date:   Tue Sep 27 01:47:03 2016 +1300

Bug 1533377: Browserid end-of-life migration script

This patch removes all authentication functionality
from the browserid auth plugin. It adds a script,
accessible through the plugin's configuration page,
to migrate user accounts from browserid to
internal auth.

Also includes changes to allow users to be searched
by authtype, and to prevent non-useable plugins
from being enabled on the plugin config page.

Change-Id: I4e8bd9fc4d2fb2ccaa1845fda533c9373ec251bd
behatnotneeded: Can't test with behat
Signed-off-by: Robert Lyon 

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1533377

Title:
  Remove Persona (browserid) auth plugin by Nov 2016, because Mozilla is
  ending Persona support

Status in Mahara:
  Fix Released
Status in Mahara 15.04 series:
  In Progress
Status in Mahara 15.10 series:
  Fix Committed
Status in Mahara 16.04 series:
  In Progress

Bug description:
  Mozilla has recently announced that they're ending support for the
  Persona authentication service, in November 2016.:
  https://wiki.mozilla.org/Identity/Persona_Shutdown_Guidelines_for_Reliers

  Mahara has long shipped with a Persona (formerly "Browserid") auth
  plugin. We'll need to remove this plugin from the 16.10 release, and
  come up with a way to help existing sites migrate their users away
  from Persona.

  We should also consider how to help out the stable release sites in
  migrating users away from Persona. The Nov 2016 shutdown will be very
  close to the 16.10 release date, so asking sites to upgrade to 16.10
  to use any migration tool will be fairly demanding, particularly since
  15.04 will still be covered by its extended support lifetime. So for
  15.04, 15.10, and 16.04 sites, an optional Persona migration plugin is
  probably the best option. That way the functionality will be available
  to sites that need it, without shipping new features in minor
  upgrades.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1533377/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1543403] Re: TinyMCE full screen not working in IE10 for 15.10.1

2016-10-24 Thread Robert Lyon
This looks to be a fixed by the fix for bug 1631807

** Changed in: mahara
   Status: Triaged => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1543403

Title:
  TinyMCE full screen not working in IE10 for 15.10.1

Status in Mahara:
  Fix Committed
Status in Mahara 15.10 series:
  Triaged
Status in Mahara 16.04 series:
  Triaged
Status in Mahara 16.10 series:
  Triaged

Bug description:
  In IE10 (win7), tinyMCE is not going full screen when clicking the expand 
button from the menu. 
  This problem occurs when editing a text box in the Portfolio - Pages. Assume 
this happens on all instances of TinyMCE and using the RAW theme (core issue 
with all themes that inherit RAW).

  Problem was found by a client using the Primary School theme.

  TinyMCE works correctly in IE11.

  
  May the force be with you for this one.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1543403/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1543403] Re: TinyMCE full screen not working in IE10 for 15.10.1

2016-10-24 Thread Robert Lyon
** Changed in: mahara/15.10
Milestone: 15.10.6 => 15.10.7

** Changed in: mahara/16.04
Milestone: 16.04.4 => 16.04.5

** Changed in: mahara
   Importance: High => Medium

** Changed in: mahara/15.10
   Importance: High => Medium

** Changed in: mahara/16.04
   Importance: High => Medium

** Changed in: mahara/16.10
   Importance: High => Medium

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1543403

Title:
  TinyMCE full screen not working in IE10 for 15.10.1

Status in Mahara:
  Fix Committed
Status in Mahara 15.10 series:
  Triaged
Status in Mahara 16.04 series:
  Triaged
Status in Mahara 16.10 series:
  Triaged

Bug description:
  In IE10 (win7), tinyMCE is not going full screen when clicking the expand 
button from the menu. 
  This problem occurs when editing a text box in the Portfolio - Pages. Assume 
this happens on all instances of TinyMCE and using the RAW theme (core issue 
with all themes that inherit RAW).

  Problem was found by a client using the Primary School theme.

  TinyMCE works correctly in IE11.

  
  May the force be with you for this one.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1543403/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1528991] Re: Indent second line of notification in Inbox

2016-10-24 Thread Robert Lyon
** Changed in: mahara/15.10
Milestone: 15.10.6 => 15.10.7

** Changed in: mahara/16.04
Milestone: 16.04.4 => 16.04.5

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1528991

Title:
  Indent second line of notification in Inbox

Status in Mahara:
  Confirmed
Status in Mahara 15.10 series:
  Confirmed
Status in Mahara 16.04 series:
  Confirmed
Status in Mahara 16.10 series:
  Confirmed

Bug description:
  Mahara 15.10+

  When the subject line of a notification is very long, the name pops to
  the second line when on a tablet for example. That second line is not
  indent, but should only start where the text starts on the first line
  (see attachment)

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1528991/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1606744] Re: Accessibility - Select 'other' text field label incorrect

2016-10-24 Thread Robert Lyon
** Changed in: mahara/16.04
   Status: Confirmed => In Progress

** Changed in: mahara/15.10
   Status: Confirmed => In Progress

** Changed in: mahara/15.04
   Status: Confirmed => In Progress

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1606744

Title:
  Accessibility - Select 'other' text field label incorrect

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  In Progress
Status in Mahara 15.10 series:
  In Progress
Status in Mahara 16.04 series:
  In Progress
Status in Mahara 16.10 series:
  Fix Released

Bug description:
  Mahara: master

  Input text fields should have a label and/or use the 'aria-labelled
  by' property to bind multiple inputs to a label.

  Please refer to: http://webaim.org/techniques/forms/controls#input

  An example where it is needed is in the screen
  (artefact/internal/socialprofile.php):

  * Social media > New social media account

  The input box (id=editprofileform_profiletype_other) next to "Other"
  is not linked to a label. Screen readers refer to it as "edit".

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1606744/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1487299] Re: All edit and delete buttons should contain the name of what they manage

2016-10-24 Thread Robert Lyon
** Changed in: mahara/15.10
Milestone: 15.10.6 => 15.10.7

** Changed in: mahara/16.04
Milestone: 16.04.4 => 16.04.5

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1487299

Title:
  All edit and delete buttons should contain the name of what they
  manage

Status in Mahara:
  Confirmed
Status in Mahara 15.10 series:
  Confirmed
Status in Mahara 16.04 series:
  Confirmed
Status in Mahara 16.10 series:
  Confirmed

Bug description:
  Reopening Bug #1276397 - in the new Bootstrap theme, all edit and
  delete buttons seem to have descriptive text attached to them ("Edit"
  and "Delete"), but it is sometimes ambiguous for screen reader users
  which list item they refer to. In particular:

  - On the My groups page, Settings and Delete buttons should contain the name 
of the group (see Bug #1482482)
  - In the Resume (Education and employment, Achievements) edit and delete 
buttons should contain some information about the row they are on
  - Under Journals, all Edit and Delete buttons should include the name of the 
journal (or entry) they control
  - Same for files in the file browser (eg. Content -> Files)

  For an example of how to include this text, see the edit and delete
  buttons in the list on Portfolio -> Pages.

  There are probably other examples - they should be added here and then
  could be spun off into separate bug reports for fixing.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1487299/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1482470] Re: Position and configure block dialogs no longer have focus management

2016-10-24 Thread Robert Lyon
** Changed in: mahara/15.10
Milestone: 15.10.6 => 15.10.7

** Changed in: mahara/15.10
   Status: In Progress => Confirmed

** Changed in: mahara
   Status: In Progress => Confirmed

** Changed in: mahara
 Assignee: Jono Mingard (mingard) => (unassigned)

** Changed in: mahara/15.10
 Assignee: Jono Mingard (mingard) => (unassigned)

** Changed in: mahara/16.04
Milestone: 16.04.4 => 16.04.5

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1482470

Title:
  Position and configure block dialogs no longer have focus management

Status in Mahara:
  Confirmed
Status in Mahara 15.10 series:
  Confirmed
Status in Mahara 16.04 series:
  Confirmed
Status in Mahara 16.10 series:
  Confirmed

Bug description:
  With the new Bootstrap theme, it is still possible to add blocks using
  the keyboard (by pressing Enter when focused on a block type in the
  accordion) but the dialogs that appear no longer have focus
  management, making it appear to screen reader users as if nothing has
  happened. The old behaviour (focusing the dialog close button when it
  opens) needs to be reimplemented or fixed.

  Affects latest master

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1482470/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1606744] A patch has been submitted for review

2016-10-24 Thread Mahara Bot
Patch for "15.04_STABLE" branch: https://reviews.mahara.org/7210

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1606744

Title:
  Accessibility - Select 'other' text field label incorrect

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Confirmed
Status in Mahara 15.10 series:
  Confirmed
Status in Mahara 16.04 series:
  Confirmed
Status in Mahara 16.10 series:
  Fix Released

Bug description:
  Mahara: master

  Input text fields should have a label and/or use the 'aria-labelled
  by' property to bind multiple inputs to a label.

  Please refer to: http://webaim.org/techniques/forms/controls#input

  An example where it is needed is in the screen
  (artefact/internal/socialprofile.php):

  * Social media > New social media account

  The input box (id=editprofileform_profiletype_other) next to "Other"
  is not linked to a label. Screen readers refer to it as "edit".

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1606744/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1606744] A patch has been submitted for review

2016-10-24 Thread Mahara Bot
Patch for "16.04_STABLE" branch: https://reviews.mahara.org/7208

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1606744

Title:
  Accessibility - Select 'other' text field label incorrect

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Confirmed
Status in Mahara 15.10 series:
  Confirmed
Status in Mahara 16.04 series:
  Confirmed
Status in Mahara 16.10 series:
  Fix Released

Bug description:
  Mahara: master

  Input text fields should have a label and/or use the 'aria-labelled
  by' property to bind multiple inputs to a label.

  Please refer to: http://webaim.org/techniques/forms/controls#input

  An example where it is needed is in the screen
  (artefact/internal/socialprofile.php):

  * Social media > New social media account

  The input box (id=editprofileform_profiletype_other) next to "Other"
  is not linked to a label. Screen readers refer to it as "edit".

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1606744/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1606744] A patch has been submitted for review

2016-10-24 Thread Mahara Bot
Patch for "15.10_STABLE" branch: https://reviews.mahara.org/7209

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1606744

Title:
  Accessibility - Select 'other' text field label incorrect

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Confirmed
Status in Mahara 15.10 series:
  Confirmed
Status in Mahara 16.04 series:
  Confirmed
Status in Mahara 16.10 series:
  Fix Released

Bug description:
  Mahara: master

  Input text fields should have a label and/or use the 'aria-labelled
  by' property to bind multiple inputs to a label.

  Please refer to: http://webaim.org/techniques/forms/controls#input

  An example where it is needed is in the screen
  (artefact/internal/socialprofile.php):

  * Social media > New social media account

  The input box (id=editprofileform_profiletype_other) next to "Other"
  is not linked to a label. Screen readers refer to it as "edit".

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1606744/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1575923] Re: Mathslate/MathJax fails to load on https

2016-10-24 Thread Robert Lyon
** Changed in: mahara/15.10
Milestone: 15.10.6 => 15.10.7

** Changed in: mahara/16.04
Milestone: 16.04.4 => 16.04.5

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1575923

Title:
  Mathslate/MathJax fails to load on https

Status in Mahara:
  Confirmed
Status in Mahara 15.10 series:
  Confirmed
Status in Mahara 16.04 series:
  Confirmed
Status in Mahara 16.10 series:
  Confirmed

Bug description:
  On HTTPS-enabled sites, the Mathslate tinymce plugin fails, due to
  loading http:// resources from yui.yahooapis.com and cdn.mathjax.org.

  The file htdocs/js/tinymce/plugins/mathslate/mathslate.html is
  hardcoded to pull http:// versions of these scripts (lines 11-12).

  Ultimately this is an upstream bug, but it's one that affects https-
  enabled Mahara sites.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1575923/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1554862] Re: Move testing infrastructure into a separate git submodule

2016-10-24 Thread Robert Lyon
** Changed in: mahara/15.04
Milestone: 15.04.10 => None

** Changed in: mahara/15.04
   Status: Confirmed => Won't Fix

** Changed in: mahara/15.10
Milestone: 15.10.6 => 15.10.7

** Changed in: mahara/16.04
Milestone: 16.04.4 => 16.04.5

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1554862

Title:
  Move testing infrastructure into a separate git submodule

Status in Mahara:
  In Progress
Status in Mahara 15.04 series:
  Won't Fix
Status in Mahara 15.10 series:
  Confirmed
Status in Mahara 16.04 series:
  Confirmed
Status in Mahara 16.10 series:
  Confirmed

Bug description:
  Currently we include all the Mahara testing code in the main Mahara
  branch. This would work fine, except that rapid changes in Firefox
  mean that we need to make rapid changes in our Selenium interface, and
  all of these need to be backported into the testing code for all
  branches that are still supported.

  Effectively, this means that *all* testing-related code needs to be
  synchronized across all supported branches.

  The easiest way to ensure that is to move the testing code out of the
  main Mahara branch. For the time being, a git submodule is probably
  the best approach.

  Because some of the Behat steps need to be different between the
  different Mahara versions (for instance, navigation steps need to take
  into account changes in the menu structure's HTML), the Behat
  subproject may need to have code that sniffs the Mahara version it's
  running against and makes changes accordingly.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1554862/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1425392] Re: Behat bug: Behat gets confused by the 2 different Groups in navigation

2016-10-24 Thread Robert Lyon
** Changed in: mahara/16.10
   Importance: Medium => Low

** Changed in: mahara/16.04
   Importance: Medium => Low

** Changed in: mahara/15.10
   Importance: Medium => Low

** Changed in: mahara/15.04
   Status: Confirmed => Won't Fix

** Changed in: mahara/15.04
Milestone: 15.04.10 => None

** Changed in: mahara/15.10
Milestone: 15.10.6 => 15.10.7

** Changed in: mahara/16.04
Milestone: 16.04.4 => 16.04.5

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1425392

Title:
  Behat bug: Behat gets confused by the 2 different Groups in navigation

Status in Mahara:
  In Progress
Status in Mahara 15.04 series:
  Won't Fix
Status in Mahara 15.10 series:
  Confirmed
Status in Mahara 16.04 series:
  Confirmed
Status in Mahara 16.10 series:
  Confirmed

Bug description:
  Hi,

  I have a attached a broken Behat test. When it clicks on the first "Groups" 
heading in the navigation it works fine.
  eg "Find friends" in "Groups"

  Then it fails when it tries selecting "Archived submissions" in
  "Groups" .

  It doesn’t like the fact that there are 2 of them.  What way do we
  have to work around this?

  Thanks,
  Jinelle

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1425392/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1500285] Re: Add path and update records slowness

2016-10-24 Thread Robert Lyon
** Changed in: mahara/16.04
Milestone: 16.04.4 => 16.04.5

** Changed in: mahara/15.10
Milestone: 15.10.6 => 15.10.7

** Changed in: mahara/15.04
Milestone: 15.04.10 => None

** Changed in: mahara/15.04
   Status: Confirmed => Won't Fix

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1500285

Title:
  Add path and update records slowness

Status in Mahara:
  Confirmed
Status in Mahara 15.04 series:
  Won't Fix
Status in Mahara 15.10 series:
  Confirmed
Status in Mahara 16.04 series:
  Confirmed
Status in Mahara 16.10 series:
  Confirmed

Bug description:
  Upgrade Issue 1 - Add path and update records :

  This adds a field 'path' to artefact table and thereafter runs a
  update query to add data. We have around 500K rows and this takes
  around 94 minutes to upgrade! This can be done in one go without the
  limit of 200 and it works very well taking around 2-3 minutes!

  Few times the upgrade failed due to "mysqli error: [1205: Lock wait
  timeout exceeded; try restarting transaction]".

  This is spun off from Bug #1499568

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1500285/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1603658] Re: "Other license (enter URL)" does not work

2016-10-24 Thread Robert Lyon
** Changed in: mahara/15.10
Milestone: 15.10.6 => 15.10.7

** Changed in: mahara/16.04
Milestone: 16.04.4 => 16.04.5

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1603658

Title:
  "Other license (enter URL)" does not work

Status in Mahara:
  In Progress
Status in Mahara 15.10 series:
  Confirmed
Status in Mahara 16.04 series:
  Confirmed
Status in Mahara 16.10 series:
  Confirmed

Bug description:
  When you choose the option "Other license (enter URL)" in your
  personal settings, file upload or other places, there is supposed to
  be a second field that comes up in which you can enter the URL for
  that new license. This isn't happening in Mahara 15.10+ and probably
  got lost during the Bootstrap conversion.

  To test:

  1. Go to "Administration -> Configure Site -> General Settings", and
  enable "License metadata" and "Custom licenses".

  2. Change your default license in your account settings
  /account/index.php to "Other license (enter URL)".

  Expected result: Another text field opens up where you can enter the
  URL for this new license.

  Actual result: Nothing happens.

  Other places where this happens: Any artefact where you can choose a
  license.

  It still works in Mahara 15.04 prior to the move to Bootstrap.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1603658/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1603206] Re: Anonymously placed comments end up with system user

2016-10-24 Thread Robert Lyon
** Changed in: mahara/15.04
Milestone: 15.04.10 => None

** Changed in: mahara/15.04
   Status: Confirmed => Won't Fix

** Changed in: mahara/15.10
Milestone: 15.10.6 => 15.10.7

** Changed in: mahara/16.04
Milestone: 16.04.4 => 16.04.5

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1603206

Title:
  Anonymously placed comments end up with system user

Status in Mahara:
  In Progress
Status in Mahara 15.04 series:
  Won't Fix
Status in Mahara 15.10 series:
  Confirmed
Status in Mahara 16.04 series:
  Confirmed
Status in Mahara 16.10 series:
  Confirmed

Bug description:
  Seen on a 15.10 site for example, but possibly also 15.04 on
  mahara.org

  
  Comments placed anonymously on a page send a notification to the "System 
User". The real person doesn't get notified and it's a way for spammers to 
leave comments that aren't seen.

  Gregor for example reported that he didn't get informed about spam
  comments on https://mahara.org/user/anzeljg/windowslive-blocktype (or
  the artefact) and thus couldn't remove them unless he was on the page
  and saw the comments. I don't get System User emails, but suspect that
  this might be a similar issue.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1603206/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1530611] Re: "Recent journal entries" displays group journal in private portfolio area

2016-10-24 Thread Robert Lyon
** Changed in: mahara/15.10
Milestone: 15.10.6 => 15.10.7

** Changed in: mahara/16.04
Milestone: 16.04.4 => 16.04.5

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1530611

Title:
  "Recent journal entries" displays group journal in private portfolio
  area

Status in Mahara:
  Confirmed
Status in Mahara 15.10 series:
  Confirmed
Status in Mahara 16.04 series:
  Confirmed
Status in Mahara 16.10 series:
  Confirmed

Bug description:
  Mahara 15.10+

  When you have a journal entry in a group forum and you select the
  "Recent journal entries" block on a personal portfolio page (not a
  group portfolio page), you see the group journal listed.

  This is not the case for the blocks "Journal" and "Journal entry". Th
  group journal should only be visible for a group page.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1530611/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1422264] Re: IPv6 Compliance

2016-10-24 Thread Robert Lyon
** Changed in: mahara/15.10
Milestone: 15.10.6 => 15.10.7

** Changed in: mahara/16.04
Milestone: 16.04.4 => 16.04.5

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1422264

Title:
  IPv6 Compliance

Status in Mahara:
  Confirmed
Status in Mahara 15.04 series:
  Won't Fix
Status in Mahara 15.10 series:
  Confirmed
Status in Mahara 16.04 series:
  Confirmed
Status in Mahara 16.10 series:
  Confirmed

Bug description:
  Mahara: 15.04
  DB: any
  Browser: any
  OS: any

  Currently, Mahara is not compliant with the IPv6 protocol.

  Some places that need to change (where IP addresses are
  validated/checked):

   - SAML auth - validate URL Syntax (preg_match for IPv6 also).

   - DB: table - host.ipaddress needs to cater for 128 bit address.

   - Peer bootstrap: 
   1) preg-match should also include IPv6 format;
   2) use of PHP function gethostbyname().

   - Zend third part library - current version only supports IPv4. We
  currently use version 1.10.6.

   MNET heavily relise on Zend.
   The latest Zend is on version 3. But there is a release for 1.12.11 - which 
still doesn't support IPv6 (as far as I can tell).

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1422264/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1540534] Re: Page comment moderation doesn't affect artefact comments

2016-10-24 Thread Robert Lyon
** Changed in: mahara/15.10
Milestone: 15.10.6 => 15.10.7

** Changed in: mahara/16.04
Milestone: 16.04.4 => 16.04.5

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1540534

Title:
  Page comment moderation doesn't affect artefact comments

Status in Mahara:
  In Progress
Status in Mahara 15.10 series:
  Confirmed
Status in Mahara 16.04 series:
  Confirmed
Status in Mahara 16.10 series:
  Confirmed

Bug description:
  Seen on mahara.org and tested on latest master (16.04).

  When you turn on comment moderation for a page, that moderation only
  goes for page comments but not artefact comments. Artefact comments
  should be treated the same in that regard as there is no separate
  moderation possibility. This loophole can be misused by anonymous
  people to post comments on an artefact that are immediately visible to
  everyone.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1540534/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1467252] Re: Display problem with Switchbox when label strings aren't the same length as "On" & "Off"

2016-10-24 Thread Robert Lyon
** Changed in: mahara/16.04
Milestone: 16.04.4 => 16.04.5

** Changed in: mahara/15.10
Milestone: 15.10.6 => 15.10.7

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1467252

Title:
  Display problem with Switchbox when label strings aren't the same
  length as "On" & "Off"

Status in Mahara:
  Incomplete
Status in Mahara 15.10 series:
  Incomplete
Status in Mahara 16.04 series:
  Incomplete
Status in Mahara 16.10 series:
  Incomplete

Bug description:
  It was ok in 15.04 but the the new interface of 15.10dev, the
  translated text for the "switch" options are not displayed correctly.

  1/ When "On", the translated text for "on" is displayed, with the text for 
"off" partially 
  2/ When "Off", the translated text for "off" is displayed centered below the 
the red bullet

  (see inclosed picture)

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1467252/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1487274] Re: Elasticsearch choking on non-ASCII characters

2016-10-24 Thread Robert Lyon
** Changed in: mahara/15.04
   Status: Confirmed => Won't Fix

** Changed in: mahara/15.04
Milestone: 15.04.10 => None

** Changed in: mahara/15.10
Milestone: 15.10.6 => 15.10.7

** Changed in: mahara/16.04
Milestone: 16.04.4 => 16.04.5

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1487274

Title:
  Elasticsearch choking on non-ASCII characters

Status in Mahara:
  Confirmed
Status in Mahara 1.10 series:
  Won't Fix
Status in Mahara 1.9 series:
  Won't Fix
Status in Mahara 15.04 series:
  Won't Fix
Status in Mahara 15.10 series:
  Confirmed
Status in Mahara 16.04 series:
  Confirmed
Status in Mahara 16.10 series:
  Confirmed

Bug description:
  In 15.10 I've added code to "quarantine" records that Elasticsearch
  won't index. That is, if Elasticsearch errors out while processing a
  batch of records, then I re-try each record individually. And if it
  errors out while processing one of those individual records, I mark
  the record as quarantined, and keep it in the
  search_elasticsearch_queue table.

  I've backported that to one of our large 15.04 sites, and since then
  I've taken a look at the data in the records that have caused
  Elasticsearch to choke. They all contain non-ASCII characters, i.e.
  Unicode characters. These can be as simple as "e with an accent over
  it", all the way up to exotic ones like emoji and the Unicode snowman.

  I was not able to replicate this when testing on my local machine, but
  it is certainly in place on our production servers, and bugs such as
  Bug 1408577 make me think it's probably also present on some other
  servers as well.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1487274/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1572825] Re: voki externalmedia embed code changed

2016-10-24 Thread Robert Lyon
** Changed in: mahara/16.04
Milestone: 16.04.4 => 16.04.5

** Changed in: mahara/15.10
Milestone: 15.10.6 => 15.10.7

** Changed in: mahara/15.04
Milestone: 15.04.10 => None

** Changed in: mahara/15.04
   Status: Incomplete => Won't Fix

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1572825

Title:
  voki externalmedia embed code changed

Status in Mahara:
  Incomplete
Status in Mahara 15.04 series:
  Won't Fix
Status in Mahara 15.10 series:
  Incomplete
Status in Mahara 16.04 series:
  Incomplete
Status in Mahara 16.10 series:
  Incomplete

Bug description:
  A recent support post on the Mahara forums has highlighted that the
  externalmedia flags the voki URL invalid:

  
https://mahara.org/interaction/forum/topic.php?id=4007&offset=0&limit=10#post30536

  It appears that the links have changed and will require an update in
  Mahara.

  Previous voki bug: https://bugs.launchpad.net/mahara/+bug/905097

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1572825/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1608305] Re: Can't delete a block in Safari

2016-10-24 Thread Robert Lyon
** Changed in: mahara/15.10
Milestone: 15.10.6 => 15.10.7

** Changed in: mahara/16.04
Milestone: 16.04.4 => 16.04.5

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1608305

Title:
  Can't delete a block in Safari

Status in Mahara:
  Confirmed
Status in Mahara 15.10 series:
  Confirmed
Status in Mahara 16.04 series:
  Confirmed
Status in Mahara 16.10 series:
  Confirmed

Bug description:
  OS: X El Capitan
  Browser: Safari 9
  Mahara: 16.10


  
  Not able to delete a block/content created from Page editor when delete 
button is click

  Test step:
  1. Log on as User
  2. From Profile>Page
  3. Click Edit on existing Page
  4. Click on a content from the side panel>Block is added on the page
  5. Edit and Delete button is displayed from the block
  6. Click Delete

  Result: Block is not deleted

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1608305/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1631807] A change has been merged

2016-10-24 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/7197
Committed: 
https://git.mahara.org/mahara/mahara/commit/33ecbec00c11d7325df917e9d88a7eb82f246374
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master

commit 33ecbec00c11d7325df917e9d88a7eb82f246374
Author: Pat Kira 
Date:   Fri Oct 21 14:09:17 2016 +1300

Bug 1631807 - Fix display issue on IE11 when tinyMce is on fullscreen
mode

Change-Id: I638ed4ad4992e92097275ded8c75cf035cfebb3b
behatnotneeded: styling only

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1631807

Title:
  Problem when editing the content on IE11

Status in Mahara:
  Fix Committed

Bug description:
  Version: 16.10
  Browser : IE11

  Steps to Reproduce:

  1) Login to Mahara and navigate to Portfolio>Pages
  2) Click on one of the existing pages and edit the page
  3) Add a text snippet to the page and enter some text into it
  4) Click on toggle tool bar to see all the buttons\
  5) click on Full-screen button

  Expected Result: It should switch to full screen

  Actual result:  The window that pops up only fills half of the screen
  (or less) and you lose the ability to scroll.( see screenshot)

  This is happening only on IE 11, tested it on IE edge, ff and chrome
  and it looks fine.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1631807/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


  1   2   >