[Mahara-contributors] [Bug 1650954] Re: New View() fails if called with deleted parameter set
** Changed in: mahara/16.10 Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1650954 Title: New View() fails if called with deleted parameter set Status in Mahara: Fix Committed Status in Mahara 16.10 series: Fix Committed Status in Mahara 17.04 series: Fix Committed Bug description: The doublecheck we added within View constructor for view_rows_columns to make sure the rows exist fails to take into account calling new View() with 'deleted' parameter set to true. This is used in Leap2A import to make a 'dummy' view to allow the adding of a new view layout type. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1650954/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1650954] A change has been merged
Reviewed: https://reviews.mahara.org/7388 Committed: https://git.mahara.org/mahara/mahara/commit/ba885abca500632720ecd4f6f8a370fb6e61e6ac Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:16.10_STABLE commit ba885abca500632720ecd4f6f8a370fb6e61e6ac Author: Robert Lyon Date: Mon Dec 19 09:09:47 2016 +1300 Bug 1650954: View Constructor to ignore trying to make view_rows_columns When it is set to be deleted straight away via parameter 'deleted' = true behatnotneeded Change-Id: I26204b8d358520c6acf3434531c06c4490152f47 Signed-off-by: Robert Lyon (cherry picked from commit 0e470890bf6be4791edf5e1267812dc0f53822dd) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1650954 Title: New View() fails if called with deleted parameter set Status in Mahara: Fix Committed Status in Mahara 16.10 series: Fix Committed Status in Mahara 17.04 series: Fix Committed Bug description: The doublecheck we added within View constructor for view_rows_columns to make sure the rows exist fails to take into account calling new View() with 'deleted' parameter set to true. This is used in Leap2A import to make a 'dummy' view to allow the adding of a new view layout type. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1650954/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1467252] Re: Display problem with Switchbox when label strings aren't the same length as "On" & "Off"
As the changes to switchbox / checkbox are significant we will not backport this fix ** Changed in: mahara Status: In Progress => Fix Committed ** No longer affects: mahara/15.10 ** No longer affects: mahara/16.04 ** No longer affects: mahara/16.10 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1467252 Title: Display problem with Switchbox when label strings aren't the same length as "On" & "Off" Status in Mahara: Fix Committed Bug description: It was ok in 15.04 but the the new interface of 15.10dev, the translated text for the "switch" options are not displayed correctly. 1/ When "On", the translated text for "on" is displayed, with the text for "off" partially 2/ When "Off", the translated text for "off" is displayed centered below the the red bullet (see inclosed picture) To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1467252/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1467252] A change has been merged
Reviewed: https://reviews.mahara.org/7392 Committed: https://git.mahara.org/mahara/mahara/commit/261d386dac6fe1349a3a7a6ec2ea65520fef5050 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:master commit 261d386dac6fe1349a3a7a6ec2ea65520fef5050 Author: Robert Lyon Date: Mon Jan 16 20:21:49 2017 +1300 Bug 1467252: Fix display problem with Switchbox When switchbox is outside pieforms behatnotneeded Change-Id: I5c8d53fba46267a16b70b7d288f18488cdd82b29 Signed-off-by: Robert Lyon -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1467252 Title: Display problem with Switchbox when label strings aren't the same length as "On" & "Off" Status in Mahara: Fix Committed Bug description: It was ok in 15.04 but the the new interface of 15.10dev, the translated text for the "switch" options are not displayed correctly. 1/ When "On", the translated text for "on" is displayed, with the text for "off" partially 2/ When "Off", the translated text for "off" is displayed centered below the the red bullet (see inclosed picture) To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1467252/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1467252] A change has been merged
Reviewed: https://reviews.mahara.org/7377 Committed: https://git.mahara.org/mahara/mahara/commit/a08f5a34bdbcc751a2327b1b8e4f513961a45d1e Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:master commit a08f5a34bdbcc751a2327b1b8e4f513961a45d1e Author: Gilles-Philippe Leblanc Date: Thu Dec 22 09:45:06 2016 -0500 Bug 1467252: Fix display problem with Switchbox with long width behatnotneeded: style change only Change-Id: Ic97afddfe84057e613e340598322cc2a51ec57b3 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1467252 Title: Display problem with Switchbox when label strings aren't the same length as "On" & "Off" Status in Mahara: Fix Committed Bug description: It was ok in 15.04 but the the new interface of 15.10dev, the translated text for the "switch" options are not displayed correctly. 1/ When "On", the translated text for "on" is displayed, with the text for "off" partially 2/ When "Off", the translated text for "off" is displayed centered below the the red bullet (see inclosed picture) To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1467252/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1648679] A patch has been submitted for review
Patch for "master" branch: https://reviews.mahara.org/7414 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1648679 Title: Find all Errors in code: Only variables should be passed by reference Status in Mahara: Fix Committed Status in Mahara 16.04 series: In Progress Status in Mahara 16.10 series: In Progress Status in Mahara 17.04 series: Fix Committed Bug description: Need to search and fix all lines of code that throw error: "Only variables should be passed by reference" this message is shown when a function is called that needs parameters passed by reference but instead of a variable, another function called is passed. In most cases it works, but as it says here https://bugs.php.net/bug.php?id=48937 this might lead to memory corruptions in some cases. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1648679/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1655150] A change has been merged
Reviewed: https://reviews.mahara.org/7385 Committed: https://git.mahara.org/mahara/mahara/commit/c4543848899972b776f5ec8d7086a8b2d4f74ec0 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:master commit c4543848899972b776f5ec8d7086a8b2d4f74ec0 Author: Cecilia Vela Gurovic Date: Tue Jan 10 10:16:46 2017 +1300 Bug 1655150: Removed file Mail.php in Zend folder File contains class Zend_Log_Writer_Mail that is not use in Mahara. behatnotneeded Change-Id: I53bb9a8e5ab1212a3bb1cf7016d0d3d64b3c4a07 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1655150 Title: remove Zend Mail class Zend_Log_Writer_Mail not used Status in Mahara: Fix Committed Bug description: We need to remove file htdocs/webservice/libs/zend/Zend/Log/Writer/Mail.php that contains class Zend_Log_Writer_Mail as it is not used. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1655150/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1655150] Re: remove Zend Mail class Zend_Log_Writer_Mail not used
** Changed in: mahara Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1655150 Title: remove Zend Mail class Zend_Log_Writer_Mail not used Status in Mahara: Fix Committed Bug description: We need to remove file htdocs/webservice/libs/zend/Zend/Log/Writer/Mail.php that contains class Zend_Log_Writer_Mail as it is not used. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1655150/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1648927] A patch has been submitted for review
Patch for "16.10_STABLE" branch: https://reviews.mahara.org/7413 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1648927 Title: Deleting an institution sets group shortname/institution to null Status in Mahara: Fix Committed Status in Mahara 16.10 series: In Progress Status in Mahara 17.04 series: Fix Committed Bug description: Now that we want every group to have a shortname we should not be setting it to NULL Need to update 'institution' to the default site name 'mahara' To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1648927/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1648679] A change has been merged
Reviewed: https://reviews.mahara.org/7387 Committed: https://git.mahara.org/mahara/mahara/commit/65f3a4ea04b3b3ef3d4806b60b91a43216de2798 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:16.04_STABLE commit 65f3a4ea04b3b3ef3d4806b60b91a43216de2798 Author: Cecilia Vela Gurovic Date: Fri Dec 9 16:11:16 2016 +1300 Bug 1648679: Avoiding "Passed by reference" error Fixed lines of code that threw the error "Only variables should be passed by reference" and other errors found. behatnotneeded Change-Id: I23e6a3c1b2ef97bf2cae29c15814fcdb79d5676f (cherry picked from commit c29f4ef478efd7af27680c4ad4b769f7c2e59fe7) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1648679 Title: Find all Errors in code: Only variables should be passed by reference Status in Mahara: Fix Committed Status in Mahara 16.04 series: In Progress Status in Mahara 16.10 series: In Progress Status in Mahara 17.04 series: Fix Committed Bug description: Need to search and fix all lines of code that throw error: "Only variables should be passed by reference" this message is shown when a function is called that needs parameters passed by reference but instead of a variable, another function called is passed. In most cases it works, but as it says here https://bugs.php.net/bug.php?id=48937 this might lead to memory corruptions in some cases. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1648679/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1648927] A change has been merged
Reviewed: https://reviews.mahara.org/7319 Committed: https://git.mahara.org/mahara/mahara/commit/cdc7c9492dad3c828690cf2177c229e19f9db4dc Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:master commit cdc7c9492dad3c828690cf2177c229e19f9db4dc Author: Robert Lyon Date: Sat Dec 10 16:28:30 2016 +1300 Bug 1648927: Set deleted institution's groups correctly Currently set the group shortname/institution to NULL but now we should leave shortname alone and change institution = 'mahara' behatnotneeded Change-Id: I390d5e8e17c3edca40a59438e5160db00fcc60fb Signed-off-by: Robert Lyon -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1648927 Title: Deleting an institution sets group shortname/institution to null Status in Mahara: Fix Committed Status in Mahara 16.10 series: In Progress Status in Mahara 17.04 series: Fix Committed Bug description: Now that we want every group to have a shortname we should not be setting it to NULL Need to update 'institution' to the default site name 'mahara' To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1648927/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1648927] Re: Deleting an institution sets group shortname/institution to null
** Changed in: mahara Status: In Progress => Fix Committed ** Also affects: mahara/17.04 Importance: High Status: Fix Committed ** Also affects: mahara/16.10 Importance: Undecided Status: New ** Changed in: mahara/16.10 Importance: Undecided => High ** Changed in: mahara/16.10 Status: New => In Progress ** Changed in: mahara/16.10 Milestone: None => 16.10.3 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1648927 Title: Deleting an institution sets group shortname/institution to null Status in Mahara: Fix Committed Status in Mahara 16.10 series: In Progress Status in Mahara 17.04 series: Fix Committed Bug description: Now that we want every group to have a shortname we should not be setting it to NULL Need to update 'institution' to the default site name 'mahara' To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1648927/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1655456] Re: Sharing collection with a group not showing on group homepage list
for testing - Create a group with 2 member - member 1 creates a collection with more than one page - as member 2, you should see the collection in - "shared with me" screen - In the group, the collection is in "collections shared with the group" section in About tab - as member 1, delete first page of collection expected result: member 2 can still see the collection in the screens actual result: Now member 2 can't see the collection in those screens -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1655456 Title: Sharing collection with a group not showing on group homepage list Status in Mahara: In Progress Bug description: Sometimes when a user shares a collection with a group they belong to that collection doesn't show in the list for 'Collections shared with this group' in the Group pages block. The reason for this is because the sql for the list only fetches the collection_view page with displayorder = 0 This is so it fetches the first page so can get the url for collection and also limit the results to once per collection. The problem occurs when one deletes the first page from a collection via the edit collections views page. It doesn't reset the collection views display order and so there is no displayorder = 0 A workaround for this could be to change the line in lib/view.php for get_sharedcollections_data() from AND (cv.displayorder = 0 OR cv.displayorder IS NULL) to AND (cv.displayorder = (SELECT MIN(displayorder) FROM collection_view WHERE collection = c.id) OR cv.displayorder IS NULL) where it fetches the minimum display order value Or fix up the deletion of views from collection so that the displayorder is reset correctly To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1655456/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1655456] A patch has been submitted for review
Patch for "master" branch: https://reviews.mahara.org/7411 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1655456 Title: Sharing collection with a group not showing on group homepage list Status in Mahara: In Progress Bug description: Sometimes when a user shares a collection with a group they belong to that collection doesn't show in the list for 'Collections shared with this group' in the Group pages block. The reason for this is because the sql for the list only fetches the collection_view page with displayorder = 0 This is so it fetches the first page so can get the url for collection and also limit the results to once per collection. The problem occurs when one deletes the first page from a collection via the edit collections views page. It doesn't reset the collection views display order and so there is no displayorder = 0 A workaround for this could be to change the line in lib/view.php for get_sharedcollections_data() from AND (cv.displayorder = 0 OR cv.displayorder IS NULL) to AND (cv.displayorder = (SELECT MIN(displayorder) FROM collection_view WHERE collection = c.id) OR cv.displayorder IS NULL) where it fetches the minimum display order value Or fix up the deletion of views from collection so that the displayorder is reset correctly To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1655456/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
