[Mahara-contributors] [Bug 1693063] Re: Remove "Results per page" option while editing "My portfolios" block
It's the "My portfolios" block that is in question here. ** Summary changed: - Remove Results per page option while editing the dashboard + Remove "Results per page" option while editing "My portfolios" block ** Changed in: mahara Importance: Undecided => Low ** Changed in: mahara Status: New => Confirmed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1693063 Title: Remove "Results per page" option while editing "My portfolios" block Status in Mahara: Confirmed Bug description: When we have more than 10 Results on the dashboard there is an option at the bottom of the home page to select 1, 10, 20, 50, 100 and 500 to choose from. when we select one of the option it displays the results accordingly, but in the similar way when we try to edit the dashboard we have results per page at the bottom of the page ( it is only visible if you have more than 10 results on the dashboard). I am able to choose results per page but it does nothing, when contacted Rob he suggested to remove the Results per page option while editing the dashboard( see screenshot ) To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1693063/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1693062] Re: Inactive message after turing off secret URl's is improper
This relates to the functionality currently in development at https://reviews.mahara.org/7763 The message should site closer to the heading for the secret URLs than to the section below so that it's not mistaken for a message relating to the second section on the page. ** Tags added: front-end ** Summary changed: - Inactive message after turing off secret URl's is improper + Placement of message when secret URLs are turned off needs correcting ** Changed in: mahara Status: New => Confirmed ** Changed in: mahara Importance: Undecided => Medium ** Changed in: mahara Milestone: None => 17.10.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1693062 Title: Placement of message when secret URLs are turned off needs correcting Status in Mahara: Confirmed Bug description: Steps to reproduce: 1) Turn off aloowing public pages be navigating to site options>General settings>Allow public pages to NO and save it. 2)Navigate to pages & collections> select a page> click on edit this page> share Result : You have to see this error message " Your institution or site administrator has disabled public pages and secret URLs. Any secret URLs you see listed here are currently inactive." The alignment of the above message is improper ( see attachemnet ) To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1693062/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1690631] Re: Ability to embed Media other than images to Journal Entries
** Attachment added: "embedded_content.png" https://bugs.launchpad.net/mahara/+bug/1690631/+attachment/4882875/+files/embedded_content.png -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1690631 Title: Ability to embed Media other than images to Journal Entries Status in Mahara: Triaged Bug description: The Journals currently allow only Text and Images to be posted as Entries. In Healthcare Education, Videos, Audio and other rich Media are required to capture and demonstrate learning. Therefore, this feature request is to ask for the ability to post more than Images to the Journal Entries. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1690631/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1690631] Re: Ability to embed Media other than images to Journal Entries
Hi Jagan, You can embed iframes into journal entries when they have been added to the "Allowed iframe sources". Please see the attached screenshot that I took on https://demo.mahara.org Can you please try it there with a YouTube video for example and if it doesn't work provide the steps that you were taking? It works for me without issues also when I added a custom site. Thanks Kristina -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1690631 Title: Ability to embed Media other than images to Journal Entries Status in Mahara: Triaged Bug description: The Journals currently allow only Text and Images to be posted as Entries. In Healthcare Education, Videos, Audio and other rich Media are required to capture and demonstrate learning. Therefore, this feature request is to ask for the ability to post more than Images to the Journal Entries. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1690631/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1692746] Re: Behat test for shared access to pages
** Changed in: mahara Importance: Undecided => Medium ** Changed in: mahara Milestone: None => 17.10.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1692746 Title: Behat test for shared access to pages Status in Mahara: In Progress Bug description: There isn't a good test for sharing page access. It would be good to have a test that creates a number of pages and users and confirms that the users whom the pages are shared with are the only ones that have access to them. So the test should go to pages and collections, set the access to a particular role, group or individual and confirm that the people shared with are the ones that have access. There are tests that start to test this function, but they don't comprehensively test it. /features/user/search_users_by_share_pages.feature /features/user/registered_users.feature To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1692746/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1676214] A patch has been submitted for review
Patch for "master" branch: https://reviews.mahara.org/ -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1676214 Title: Allow to upload 2nd logo for small devices Status in Mahara: In Progress Bug description: When you go into responsive mode on a small device, the logo disappears as there is not enough space. It would be beneficial to be able to upload a small (square) logo into the theme as well as on the front-end in Admin -> Institutions -> Settings -> Upload logo so that every theme can use a secondary logo when required. On the front-end, we'd have two logo uploads then: - The regular one - One for small device with size restrictions mentioned To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1676214/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1692360] A change has been merged
Reviewed: https://reviews.mahara.org/7774 Committed: https://git.mahara.org/mahara/mahara/commit/7531ebcd14dc1a2de7bae619cda17cc329eff483 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:master commit 7531ebcd14dc1a2de7bae619cda17cc329eff483 Author: Kristina D.C. Hoeppner Date: Tue May 23 08:52:15 2017 +1200 Bug 1692360: Re-iterate installation instructions State that the steps are more of a checklist to encourage readers to read the full installation instructions. Change-Id: Ia862a21a7ac30a1ff55c63f6fb261e86e9d5ea21 behatnotneeded: Just update to the Readme file -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1692360 Title: Add installation instructions for UTF-8 database requirement to README Status in Mahara: Fix Committed Bug description: README contains the instruction to install a MySQL or PostgreSQL database only, however after setting up a MySQL 5.7.18-0ubuntu0.17.04.1 scheme, I get the message `You are not using a UTF-8 database. Mahara stores all data as UTF-8 internally. Please drop and re-create your database using UTF-8 encoding.`. Both README and the message should contain information (text or a link) how to setup such an UTF-8 database. This is not a support request to fix this for me, but an improvement suggestion to get this fixed for anybody. experienced with 1.8RC2_RELEASE-4940-g8bd74fdbf on Ubuntu 17.04 To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1692360/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1693061] Re: Edit access screen needs to check if data is saved before leaving
** Changed in: mahara Status: New => In Progress -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1693061 Title: Edit access screen needs to check if data is saved before leaving Status in Mahara: In Progress Bug description: In the Share | Edit access screen (/view/accessurl.php) of a page, while we are working on it, we can leave the page at any time without being reminded that we have unsaved changes. This should not happen, a message needs to be display for us to confirm if we want to leave and lose the changes, or stay and continue working. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1693061/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1651592] Re: Navigating to fonts in admin throws an error
** Changed in: mahara/17.04
Status: Confirmed => Fix Committed
** Changed in: mahara/17.10
Status: In Progress => Fix Committed
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1651592
Title:
Navigating to fonts in admin throws an error
Status in Mahara:
Fix Committed
Status in Mahara 17.04 series:
Fix Committed
Status in Mahara 17.10 series:
Fix Committed
Bug description:
Version: 17:04
Browser: Chrome, FF
Steps to Reproduce:
1) Login as admin
2) Navigate to Administration> configure site> fonts
Result: Warning message is displayed as below but if the config file
has $cfg->skins = true; it doesnt throw an error and if set to false
it throws the same error.
[WAR] 39 (admin/site/fonts.php:25)
Call stack (most recent first):
log_message("", 8, true, true,
"/home/niranjanbandi/code/mahara/htdocs/admin/site/...", 25, array(size 0)) at
/home/niranjanbandi/code/mahara/htdocs/lib/errors.php:648
MaharaException->handle_exception() at
/home/niranjanbandi/code/mahara/htdocs/lib/errors.php:547
exception(object(FeatureNotEnabledException)) at Unknown:0
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1651592/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1651592] A change has been merged
Reviewed: https://reviews.mahara.org/7747
Committed:
https://git.mahara.org/mahara/mahara/commit/bba4789acaf16df78684d1a0c6ca9f1135a4a8ea
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master
commit bba4789acaf16df78684d1a0c6ca9f1135a4a8ea
Author: Robert Lyon
Date: Thu May 11 19:31:04 2017 +1200
Bug 1651592: Changing the error thrown if skins not enabled
When navigating to the admin/site/fonts.php page.
behatnotneeded
Change-Id: Id627b582b3a30598900ba3a7e9b486579a65d0f6
Signed-off-by: Robert Lyon
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1651592
Title:
Navigating to fonts in admin throws an error
Status in Mahara:
Fix Committed
Status in Mahara 17.04 series:
Fix Committed
Status in Mahara 17.10 series:
Fix Committed
Bug description:
Version: 17:04
Browser: Chrome, FF
Steps to Reproduce:
1) Login as admin
2) Navigate to Administration> configure site> fonts
Result: Warning message is displayed as below but if the config file
has $cfg->skins = true; it doesnt throw an error and if set to false
it throws the same error.
[WAR] 39 (admin/site/fonts.php:25)
Call stack (most recent first):
log_message("", 8, true, true,
"/home/niranjanbandi/code/mahara/htdocs/admin/site/...", 25, array(size 0)) at
/home/niranjanbandi/code/mahara/htdocs/lib/errors.php:648
MaharaException->handle_exception() at
/home/niranjanbandi/code/mahara/htdocs/lib/errors.php:547
exception(object(FeatureNotEnabledException)) at Unknown:0
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1651592/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1651592] A change has been merged
Reviewed: https://reviews.mahara.org/7778
Committed:
https://git.mahara.org/mahara/mahara/commit/497bbc836914d8a4a0552bd95a94d0c36ddf91a8
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:17.04_STABLE
commit 497bbc836914d8a4a0552bd95a94d0c36ddf91a8
Author: Robert Lyon
Date: Thu May 11 19:31:04 2017 +1200
Bug 1651592: Changing the error thrown if skins not enabled
When navigating to the admin/site/fonts.php page.
behatnotneeded
Change-Id: Id627b582b3a30598900ba3a7e9b486579a65d0f6
Signed-off-by: Robert Lyon
(cherry picked from commit bba4789acaf16df78684d1a0c6ca9f1135a4a8ea)
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1651592
Title:
Navigating to fonts in admin throws an error
Status in Mahara:
Fix Committed
Status in Mahara 17.04 series:
Fix Committed
Status in Mahara 17.10 series:
Fix Committed
Bug description:
Version: 17:04
Browser: Chrome, FF
Steps to Reproduce:
1) Login as admin
2) Navigate to Administration> configure site> fonts
Result: Warning message is displayed as below but if the config file
has $cfg->skins = true; it doesnt throw an error and if set to false
it throws the same error.
[WAR] 39 (admin/site/fonts.php:25)
Call stack (most recent first):
log_message("", 8, true, true,
"/home/niranjanbandi/code/mahara/htdocs/admin/site/...", 25, array(size 0)) at
/home/niranjanbandi/code/mahara/htdocs/lib/errors.php:648
MaharaException->handle_exception() at
/home/niranjanbandi/code/mahara/htdocs/lib/errors.php:547
exception(object(FeatureNotEnabledException)) at Unknown:0
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1651592/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1651592] A patch has been submitted for review
Patch for "17.04_STABLE" branch: https://reviews.mahara.org/7778
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1651592
Title:
Navigating to fonts in admin throws an error
Status in Mahara:
Fix Committed
Status in Mahara 17.04 series:
Fix Committed
Status in Mahara 17.10 series:
Fix Committed
Bug description:
Version: 17:04
Browser: Chrome, FF
Steps to Reproduce:
1) Login as admin
2) Navigate to Administration> configure site> fonts
Result: Warning message is displayed as below but if the config file
has $cfg->skins = true; it doesnt throw an error and if set to false
it throws the same error.
[WAR] 39 (admin/site/fonts.php:25)
Call stack (most recent first):
log_message("", 8, true, true,
"/home/niranjanbandi/code/mahara/htdocs/admin/site/...", 25, array(size 0)) at
/home/niranjanbandi/code/mahara/htdocs/lib/errors.php:648
MaharaException->handle_exception() at
/home/niranjanbandi/code/mahara/htdocs/lib/errors.php:547
exception(object(FeatureNotEnabledException)) at Unknown:0
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1651592/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1693388] [NEW] behat test disable_external_resources.feature failing
Public bug reported: test/behat/features/admin/disable_external_resources.feature failed on one of my patches automated as well as locally, and then I noticed it also fails on master. I discovered I could fix it by adding two wait steps, between lines 33/34 and lines 54/55: 33 And I press "Select \"Image2.png\"" 34 And I press "Submit" 54 And I enable the switch "Disable external resources in user HTML" 55 And I press "Update site options" I see that bug 1575512 is supposed to remove the need for wait steps, but that patch is not the cause of this failure as I checked the history for the disable_external_resources.feature which shows it didn't have wait steps originally. So I'm confused. ** Affects: mahara Importance: Undecided Status: New ** Tags: behat -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1693388 Title: behat test disable_external_resources.feature failing Status in Mahara: New Bug description: test/behat/features/admin/disable_external_resources.feature failed on one of my patches automated as well as locally, and then I noticed it also fails on master. I discovered I could fix it by adding two wait steps, between lines 33/34 and lines 54/55: 33 And I press "Select \"Image2.png\"" 34 And I press "Submit" 54 And I enable the switch "Disable external resources in user HTML" 55 And I press "Update site options" I see that bug 1575512 is supposed to remove the need for wait steps, but that patch is not the cause of this failure as I checked the history for the disable_external_resources.feature which shows it didn't have wait steps originally. So I'm confused. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1693388/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1690232] Re: Can't click the "Comments" link in a retractable block
** Changed in: mahara/17.10 Status: In Progress => Fix Committed ** Changed in: mahara/17.04 Status: Confirmed => In Progress -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1690232 Title: Can't click the "Comments" link in a retractable block Status in Mahara: Fix Committed Status in Mahara 16.04 series: Confirmed Status in Mahara 16.10 series: Confirmed Status in Mahara 17.04 series: In Progress Status in Mahara 17.10 series: Fix Committed Bug description: Mahara 16.04+ You can't click on "Comments" in a retractable block. It just loads the page again but doesn't open the modal. It works fine when the block is not retracted. To replicate: 1. Create a page with a block that can have comments, e.g. "Note". 2. Set the page to auto-retract 3. View the page, add a comment and go back to the page. 4. Click the "Comments" button. Expected result: The comments modal pops in. Actual result: Nothing happens. When you test it, also make sure to test all retractable settings: No, Yes, auto-retract. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1690232/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1690232] A change has been merged
Reviewed: https://reviews.mahara.org/7759 Committed: https://git.mahara.org/mahara/mahara/commit/5ce66781dfa1bd23f1bb632b9e61e68677259358 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:master commit 5ce66781dfa1bd23f1bb632b9e61e68677259358 Author: Robert Lyon Date: Sun May 14 16:09:28 2017 +1200 Bug 1690232: Comments link on retractable block failing to open modal Actually the modal is opening and closing in the same instant. This is caused by some code dealing with collapsible blocks making sure modals are closed if outside certain rules. This change checks what modal we are wanting and closing all but the one are targeting when clicking the 'comments' link behatnotneeded Sponsored by SWITCH Change-Id: Idb5165bdc8349f77286aa776ff75d152968aefda Signed-off-by: Robert Lyon -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1690232 Title: Can't click the "Comments" link in a retractable block Status in Mahara: Fix Committed Status in Mahara 16.04 series: Confirmed Status in Mahara 16.10 series: Confirmed Status in Mahara 17.04 series: In Progress Status in Mahara 17.10 series: Fix Committed Bug description: Mahara 16.04+ You can't click on "Comments" in a retractable block. It just loads the page again but doesn't open the modal. It works fine when the block is not retracted. To replicate: 1. Create a page with a block that can have comments, e.g. "Note". 2. Set the page to auto-retract 3. View the page, add a comment and go back to the page. 4. Click the "Comments" button. Expected result: The comments modal pops in. Actual result: Nothing happens. When you test it, also make sure to test all retractable settings: No, Yes, auto-retract. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1690232/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1690232] A change has been merged
Reviewed: https://reviews.mahara.org/7780 Committed: https://git.mahara.org/mahara/mahara/commit/b2858fcf96d80809b8a9d6af4a85a9fc8d7fc392 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:17.04_STABLE commit b2858fcf96d80809b8a9d6af4a85a9fc8d7fc392 Author: Robert Lyon Date: Sun May 14 16:09:28 2017 +1200 Bug 1690232: Comments link on retractable block failing to open modal Actually the modal is opening and closing in the same instant. This is caused by some code dealing with collapsible blocks making sure modals are closed if outside certain rules. This change checks what modal we are wanting and closing all but the one are targeting when clicking the 'comments' link behatnotneeded Sponsored by SWITCH Change-Id: Idb5165bdc8349f77286aa776ff75d152968aefda Signed-off-by: Robert Lyon (cherry picked from commit 5ce66781dfa1bd23f1bb632b9e61e68677259358) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1690232 Title: Can't click the "Comments" link in a retractable block Status in Mahara: Fix Committed Status in Mahara 16.04 series: Confirmed Status in Mahara 16.10 series: Confirmed Status in Mahara 17.04 series: In Progress Status in Mahara 17.10 series: Fix Committed Bug description: Mahara 16.04+ You can't click on "Comments" in a retractable block. It just loads the page again but doesn't open the modal. It works fine when the block is not retracted. To replicate: 1. Create a page with a block that can have comments, e.g. "Note". 2. Set the page to auto-retract 3. View the page, add a comment and go back to the page. 4. Click the "Comments" button. Expected result: The comments modal pops in. Actual result: Nothing happens. When you test it, also make sure to test all retractable settings: No, Yes, auto-retract. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1690232/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1690232] A patch has been submitted for review
Patch for "16.10_STABLE" branch: https://reviews.mahara.org/7781 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1690232 Title: Can't click the "Comments" link in a retractable block Status in Mahara: Fix Committed Status in Mahara 16.04 series: Confirmed Status in Mahara 16.10 series: Confirmed Status in Mahara 17.04 series: In Progress Status in Mahara 17.10 series: Fix Committed Bug description: Mahara 16.04+ You can't click on "Comments" in a retractable block. It just loads the page again but doesn't open the modal. It works fine when the block is not retracted. To replicate: 1. Create a page with a block that can have comments, e.g. "Note". 2. Set the page to auto-retract 3. View the page, add a comment and go back to the page. 4. Click the "Comments" button. Expected result: The comments modal pops in. Actual result: Nothing happens. When you test it, also make sure to test all retractable settings: No, Yes, auto-retract. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1690232/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1690232] A patch has been submitted for review
Patch for "16.04_STABLE" branch: https://reviews.mahara.org/7782 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1690232 Title: Can't click the "Comments" link in a retractable block Status in Mahara: Fix Committed Status in Mahara 16.04 series: Confirmed Status in Mahara 16.10 series: Confirmed Status in Mahara 17.04 series: In Progress Status in Mahara 17.10 series: Fix Committed Bug description: Mahara 16.04+ You can't click on "Comments" in a retractable block. It just loads the page again but doesn't open the modal. It works fine when the block is not retracted. To replicate: 1. Create a page with a block that can have comments, e.g. "Note". 2. Set the page to auto-retract 3. View the page, add a comment and go back to the page. 4. Click the "Comments" button. Expected result: The comments modal pops in. Actual result: Nothing happens. When you test it, also make sure to test all retractable settings: No, Yes, auto-retract. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1690232/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1690232] A patch has been submitted for review
Patch for "17.04_STABLE" branch: https://reviews.mahara.org/7780 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1690232 Title: Can't click the "Comments" link in a retractable block Status in Mahara: Fix Committed Status in Mahara 16.04 series: Confirmed Status in Mahara 16.10 series: Confirmed Status in Mahara 17.04 series: In Progress Status in Mahara 17.10 series: Fix Committed Bug description: Mahara 16.04+ You can't click on "Comments" in a retractable block. It just loads the page again but doesn't open the modal. It works fine when the block is not retracted. To replicate: 1. Create a page with a block that can have comments, e.g. "Note". 2. Set the page to auto-retract 3. View the page, add a comment and go back to the page. 4. Click the "Comments" button. Expected result: The comments modal pops in. Actual result: Nothing happens. When you test it, also make sure to test all retractable settings: No, Yes, auto-retract. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1690232/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1625389] Re: Error message when sharing profile page with public
** Changed in: mahara/17.10
Status: In Progress => Fix Committed
** Changed in: mahara/17.04
Status: Confirmed => Fix Committed
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1625389
Title:
Error message when sharing profile page with public
Status in Mahara:
Fix Committed
Status in Mahara 17.04 series:
Fix Committed
Status in Mahara 17.10 series:
Fix Committed
Bug description:
Mahara master (16.10dev)
When I share my profile page with "Public", I get the following error
message after I saved the form and access rules have been applied.
[WAR] 0b (view/access.php:415) Undefined index: startdate
Call stack (most recent first):
log_message("Undefined index: startdate", 8, true, true,
"/home/kristina/code/mahara/htdocs/view/access.php", 415) at
/home/kristina/code/mahara/htdocs/lib/errors.php:513
error(8, "Undefined index: startdate",
"/home/kristina/code/mahara/htdocs/view/access.php", 415, array(size 10)) at
/home/kristina/code/mahara/htdocs/view/access.php:415
editaccess_validate(object(Pieform), array(size 11)) at Unknown:0
call_user_func_array("editaccess_validate", array(size 2)) at
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:1449
Pieform->validate(array(size 11)) at
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:521
Pieform->__construct(array(size 8)) at
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:164
Pieform::process(array(size 8)) at
/home/kristina/code/mahara/htdocs/lib/mahara.php:4764
pieform(array(size 8)) at
/home/kristina/code/mahara/htdocs/view/access.php:555
[WAR] 0b (view/access.php:415) Undefined index: stopdate
Call stack (most recent first):
log_message("Undefined index: stopdate", 8, true, true,
"/home/kristina/code/mahara/htdocs/view/access.php", 415) at
/home/kristina/code/mahara/htdocs/lib/errors.php:513
error(8, "Undefined index: stopdate",
"/home/kristina/code/mahara/htdocs/view/access.php", 415, array(size 10)) at
/home/kristina/code/mahara/htdocs/view/access.php:415
editaccess_validate(object(Pieform), array(size 11)) at Unknown:0
call_user_func_array("editaccess_validate", array(size 2)) at
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:1449
Pieform->validate(array(size 11)) at
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:521
Pieform->__construct(array(size 8)) at
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:164
Pieform::process(array(size 8)) at
/home/kristina/code/mahara/htdocs/lib/mahara.php:4764
pieform(array(size 8)) at
/home/kristina/code/mahara/htdocs/view/access.php:555
[WAR] 0b (view/access.php:420) Undefined index: stopdate
Call stack (most recent first):
log_message("Undefined index: stopdate", 8, true, true,
"/home/kristina/code/mahara/htdocs/view/access.php", 420) at
/home/kristina/code/mahara/htdocs/lib/errors.php:513
error(8, "Undefined index: stopdate",
"/home/kristina/code/mahara/htdocs/view/access.php", 420, array(size 11)) at
/home/kristina/code/mahara/htdocs/view/access.php:420
editaccess_validate(object(Pieform), array(size 11)) at Unknown:0
call_user_func_array("editaccess_validate", array(size 2)) at
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:1449
Pieform->validate(array(size 11)) at
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:521
Pieform->__construct(array(size 8)) at
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:164
Pieform::process(array(size 8)) at
/home/kristina/code/mahara/htdocs/lib/mahara.php:4764
pieform(array(size 8)) at
/home/kristina/code/mahara/htdocs/view/access.php:555
[WAR] 0b (view/access.php:425) Undefined index: startdate
Call stack (most recent first):
log_message("Undefined index: startdate", 8, true, true,
"/home/kristina/code/mahara/htdocs/view/access.php", 425) at
/home/kristina/code/mahara/htdocs/lib/errors.php:513
error(8, "Undefined index: startdate",
"/home/kristina/code/mahara/htdocs/view/access.php", 425, array(size 11)) at
/home/kristina/code/mahara/htdocs/view/access.php:425
editaccess_validate(object(Pieform), array(size 11)) at Unknown:0
call_user_func_array("editaccess_validate", array(size 2)) at
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:1449
Pieform->validate(array(size 11)) at
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:521
Pieform->__construct(array(size 8)) at
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:164
Pieform::process(array(size 8)) at
/home/kristina/code/mahara/htdocs/lib/mahara.php:4764
pieform(array(size 8)) at
[Mahara-contributors] [Bug 1625389] A change has been merged
Reviewed: https://reviews.mahara.org/7748
Committed:
https://git.mahara.org/mahara/mahara/commit/c277d5d41607c8f0a9ccfa30e85ecd3139615b9a
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master
commit c277d5d41607c8f0a9ccfa30e85ecd3139615b9a
Author: Robert Lyon
Date: Thu May 11 19:48:02 2017 +1200
Bug 1625389: Proper checking of view access start/stop date values
As profile page can have the fields disabled and so don't get passed
to the saving part causing errors before
behatnotneeded
Change-Id: I1a48c5cdf93a20abb69630e6d1e52aaef701eee5
Signed-off-by: Robert Lyon
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1625389
Title:
Error message when sharing profile page with public
Status in Mahara:
Fix Committed
Status in Mahara 17.04 series:
Fix Committed
Status in Mahara 17.10 series:
Fix Committed
Bug description:
Mahara master (16.10dev)
When I share my profile page with "Public", I get the following error
message after I saved the form and access rules have been applied.
[WAR] 0b (view/access.php:415) Undefined index: startdate
Call stack (most recent first):
log_message("Undefined index: startdate", 8, true, true,
"/home/kristina/code/mahara/htdocs/view/access.php", 415) at
/home/kristina/code/mahara/htdocs/lib/errors.php:513
error(8, "Undefined index: startdate",
"/home/kristina/code/mahara/htdocs/view/access.php", 415, array(size 10)) at
/home/kristina/code/mahara/htdocs/view/access.php:415
editaccess_validate(object(Pieform), array(size 11)) at Unknown:0
call_user_func_array("editaccess_validate", array(size 2)) at
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:1449
Pieform->validate(array(size 11)) at
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:521
Pieform->__construct(array(size 8)) at
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:164
Pieform::process(array(size 8)) at
/home/kristina/code/mahara/htdocs/lib/mahara.php:4764
pieform(array(size 8)) at
/home/kristina/code/mahara/htdocs/view/access.php:555
[WAR] 0b (view/access.php:415) Undefined index: stopdate
Call stack (most recent first):
log_message("Undefined index: stopdate", 8, true, true,
"/home/kristina/code/mahara/htdocs/view/access.php", 415) at
/home/kristina/code/mahara/htdocs/lib/errors.php:513
error(8, "Undefined index: stopdate",
"/home/kristina/code/mahara/htdocs/view/access.php", 415, array(size 10)) at
/home/kristina/code/mahara/htdocs/view/access.php:415
editaccess_validate(object(Pieform), array(size 11)) at Unknown:0
call_user_func_array("editaccess_validate", array(size 2)) at
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:1449
Pieform->validate(array(size 11)) at
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:521
Pieform->__construct(array(size 8)) at
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:164
Pieform::process(array(size 8)) at
/home/kristina/code/mahara/htdocs/lib/mahara.php:4764
pieform(array(size 8)) at
/home/kristina/code/mahara/htdocs/view/access.php:555
[WAR] 0b (view/access.php:420) Undefined index: stopdate
Call stack (most recent first):
log_message("Undefined index: stopdate", 8, true, true,
"/home/kristina/code/mahara/htdocs/view/access.php", 420) at
/home/kristina/code/mahara/htdocs/lib/errors.php:513
error(8, "Undefined index: stopdate",
"/home/kristina/code/mahara/htdocs/view/access.php", 420, array(size 11)) at
/home/kristina/code/mahara/htdocs/view/access.php:420
editaccess_validate(object(Pieform), array(size 11)) at Unknown:0
call_user_func_array("editaccess_validate", array(size 2)) at
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:1449
Pieform->validate(array(size 11)) at
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:521
Pieform->__construct(array(size 8)) at
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:164
Pieform::process(array(size 8)) at
/home/kristina/code/mahara/htdocs/lib/mahara.php:4764
pieform(array(size 8)) at
/home/kristina/code/mahara/htdocs/view/access.php:555
[WAR] 0b (view/access.php:425) Undefined index: startdate
Call stack (most recent first):
log_message("Undefined index: startdate", 8, true, true,
"/home/kristina/code/mahara/htdocs/view/access.php", 425) at
/home/kristina/code/mahara/htdocs/lib/errors.php:513
error(8, "Undefined index: startdate",
"/home/kristina/code/mahara/htdocs/view/access.php", 425, array(size 11)) at
/home/kristina/code/mahara/htdocs/view/access.php:425
editaccess_validate(object(Pieform), array(size 11)) at Unknown:0
call_user_func_array(
[Mahara-contributors] [Bug 1625389] A change has been merged
Reviewed: https://reviews.mahara.org/7779
Committed:
https://git.mahara.org/mahara/mahara/commit/0b26386688cc8d0b42d40fc0d1b995b7cb3782f9
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:17.04_STABLE
commit 0b26386688cc8d0b42d40fc0d1b995b7cb3782f9
Author: Robert Lyon
Date: Thu May 11 19:48:02 2017 +1200
Bug 1625389: Proper checking of view access start/stop date values
As profile page can have the fields disabled and so don't get passed
to the saving part causing errors before
behatnotneeded
Change-Id: I1a48c5cdf93a20abb69630e6d1e52aaef701eee5
Signed-off-by: Robert Lyon
(cherry picked from commit c277d5d41607c8f0a9ccfa30e85ecd3139615b9a)
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1625389
Title:
Error message when sharing profile page with public
Status in Mahara:
Fix Committed
Status in Mahara 17.04 series:
Fix Committed
Status in Mahara 17.10 series:
Fix Committed
Bug description:
Mahara master (16.10dev)
When I share my profile page with "Public", I get the following error
message after I saved the form and access rules have been applied.
[WAR] 0b (view/access.php:415) Undefined index: startdate
Call stack (most recent first):
log_message("Undefined index: startdate", 8, true, true,
"/home/kristina/code/mahara/htdocs/view/access.php", 415) at
/home/kristina/code/mahara/htdocs/lib/errors.php:513
error(8, "Undefined index: startdate",
"/home/kristina/code/mahara/htdocs/view/access.php", 415, array(size 10)) at
/home/kristina/code/mahara/htdocs/view/access.php:415
editaccess_validate(object(Pieform), array(size 11)) at Unknown:0
call_user_func_array("editaccess_validate", array(size 2)) at
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:1449
Pieform->validate(array(size 11)) at
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:521
Pieform->__construct(array(size 8)) at
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:164
Pieform::process(array(size 8)) at
/home/kristina/code/mahara/htdocs/lib/mahara.php:4764
pieform(array(size 8)) at
/home/kristina/code/mahara/htdocs/view/access.php:555
[WAR] 0b (view/access.php:415) Undefined index: stopdate
Call stack (most recent first):
log_message("Undefined index: stopdate", 8, true, true,
"/home/kristina/code/mahara/htdocs/view/access.php", 415) at
/home/kristina/code/mahara/htdocs/lib/errors.php:513
error(8, "Undefined index: stopdate",
"/home/kristina/code/mahara/htdocs/view/access.php", 415, array(size 10)) at
/home/kristina/code/mahara/htdocs/view/access.php:415
editaccess_validate(object(Pieform), array(size 11)) at Unknown:0
call_user_func_array("editaccess_validate", array(size 2)) at
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:1449
Pieform->validate(array(size 11)) at
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:521
Pieform->__construct(array(size 8)) at
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:164
Pieform::process(array(size 8)) at
/home/kristina/code/mahara/htdocs/lib/mahara.php:4764
pieform(array(size 8)) at
/home/kristina/code/mahara/htdocs/view/access.php:555
[WAR] 0b (view/access.php:420) Undefined index: stopdate
Call stack (most recent first):
log_message("Undefined index: stopdate", 8, true, true,
"/home/kristina/code/mahara/htdocs/view/access.php", 420) at
/home/kristina/code/mahara/htdocs/lib/errors.php:513
error(8, "Undefined index: stopdate",
"/home/kristina/code/mahara/htdocs/view/access.php", 420, array(size 11)) at
/home/kristina/code/mahara/htdocs/view/access.php:420
editaccess_validate(object(Pieform), array(size 11)) at Unknown:0
call_user_func_array("editaccess_validate", array(size 2)) at
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:1449
Pieform->validate(array(size 11)) at
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:521
Pieform->__construct(array(size 8)) at
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:164
Pieform::process(array(size 8)) at
/home/kristina/code/mahara/htdocs/lib/mahara.php:4764
pieform(array(size 8)) at
/home/kristina/code/mahara/htdocs/view/access.php:555
[WAR] 0b (view/access.php:425) Undefined index: startdate
Call stack (most recent first):
log_message("Undefined index: startdate", 8, true, true,
"/home/kristina/code/mahara/htdocs/view/access.php", 425) at
/home/kristina/code/mahara/htdocs/lib/errors.php:513
error(8, "Undefined index: startdate",
"/home/kristina/code/mahara/htdocs/view/access.php", 425, array(size 11)) at
/home/kristina/code/mahara/htdocs/view/access.php:425
editaccess_validat
[Mahara-contributors] [Bug 1625389] A patch has been submitted for review
Patch for "17.04_STABLE" branch: https://reviews.mahara.org/7779
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1625389
Title:
Error message when sharing profile page with public
Status in Mahara:
Fix Committed
Status in Mahara 17.04 series:
Fix Committed
Status in Mahara 17.10 series:
Fix Committed
Bug description:
Mahara master (16.10dev)
When I share my profile page with "Public", I get the following error
message after I saved the form and access rules have been applied.
[WAR] 0b (view/access.php:415) Undefined index: startdate
Call stack (most recent first):
log_message("Undefined index: startdate", 8, true, true,
"/home/kristina/code/mahara/htdocs/view/access.php", 415) at
/home/kristina/code/mahara/htdocs/lib/errors.php:513
error(8, "Undefined index: startdate",
"/home/kristina/code/mahara/htdocs/view/access.php", 415, array(size 10)) at
/home/kristina/code/mahara/htdocs/view/access.php:415
editaccess_validate(object(Pieform), array(size 11)) at Unknown:0
call_user_func_array("editaccess_validate", array(size 2)) at
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:1449
Pieform->validate(array(size 11)) at
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:521
Pieform->__construct(array(size 8)) at
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:164
Pieform::process(array(size 8)) at
/home/kristina/code/mahara/htdocs/lib/mahara.php:4764
pieform(array(size 8)) at
/home/kristina/code/mahara/htdocs/view/access.php:555
[WAR] 0b (view/access.php:415) Undefined index: stopdate
Call stack (most recent first):
log_message("Undefined index: stopdate", 8, true, true,
"/home/kristina/code/mahara/htdocs/view/access.php", 415) at
/home/kristina/code/mahara/htdocs/lib/errors.php:513
error(8, "Undefined index: stopdate",
"/home/kristina/code/mahara/htdocs/view/access.php", 415, array(size 10)) at
/home/kristina/code/mahara/htdocs/view/access.php:415
editaccess_validate(object(Pieform), array(size 11)) at Unknown:0
call_user_func_array("editaccess_validate", array(size 2)) at
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:1449
Pieform->validate(array(size 11)) at
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:521
Pieform->__construct(array(size 8)) at
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:164
Pieform::process(array(size 8)) at
/home/kristina/code/mahara/htdocs/lib/mahara.php:4764
pieform(array(size 8)) at
/home/kristina/code/mahara/htdocs/view/access.php:555
[WAR] 0b (view/access.php:420) Undefined index: stopdate
Call stack (most recent first):
log_message("Undefined index: stopdate", 8, true, true,
"/home/kristina/code/mahara/htdocs/view/access.php", 420) at
/home/kristina/code/mahara/htdocs/lib/errors.php:513
error(8, "Undefined index: stopdate",
"/home/kristina/code/mahara/htdocs/view/access.php", 420, array(size 11)) at
/home/kristina/code/mahara/htdocs/view/access.php:420
editaccess_validate(object(Pieform), array(size 11)) at Unknown:0
call_user_func_array("editaccess_validate", array(size 2)) at
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:1449
Pieform->validate(array(size 11)) at
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:521
Pieform->__construct(array(size 8)) at
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:164
Pieform::process(array(size 8)) at
/home/kristina/code/mahara/htdocs/lib/mahara.php:4764
pieform(array(size 8)) at
/home/kristina/code/mahara/htdocs/view/access.php:555
[WAR] 0b (view/access.php:425) Undefined index: startdate
Call stack (most recent first):
log_message("Undefined index: startdate", 8, true, true,
"/home/kristina/code/mahara/htdocs/view/access.php", 425) at
/home/kristina/code/mahara/htdocs/lib/errors.php:513
error(8, "Undefined index: startdate",
"/home/kristina/code/mahara/htdocs/view/access.php", 425, array(size 11)) at
/home/kristina/code/mahara/htdocs/view/access.php:425
editaccess_validate(object(Pieform), array(size 11)) at Unknown:0
call_user_func_array("editaccess_validate", array(size 2)) at
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:1449
Pieform->validate(array(size 11)) at
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:521
Pieform->__construct(array(size 8)) at
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:164
Pieform::process(array(size 8)) at
/home/kristina/code/mahara/htdocs/lib/mahara.php:4764
pieform(array(size 8)) at
/home/kristina/code/mahara/htdocs/view/access.php:555
To manage notification
[Mahara-contributors] [Bug 1690232] Re: Can't click the "Comments" link in a retractable block
** Changed in: mahara/17.04 Status: In Progress => Fix Committed ** Changed in: mahara/16.10 Status: Confirmed => In Progress ** Changed in: mahara/16.04 Status: Confirmed => In Progress -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1690232 Title: Can't click the "Comments" link in a retractable block Status in Mahara: Fix Committed Status in Mahara 16.04 series: In Progress Status in Mahara 16.10 series: In Progress Status in Mahara 17.04 series: Fix Committed Status in Mahara 17.10 series: Fix Committed Bug description: Mahara 16.04+ You can't click on "Comments" in a retractable block. It just loads the page again but doesn't open the modal. It works fine when the block is not retracted. To replicate: 1. Create a page with a block that can have comments, e.g. "Note". 2. Set the page to auto-retract 3. View the page, add a comment and go back to the page. 4. Click the "Comments" button. Expected result: The comments modal pops in. Actual result: Nothing happens. When you test it, also make sure to test all retractable settings: No, Yes, auto-retract. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1690232/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1687343] Re: Embeldy discontinued free API tiers
** Changed in: mahara/16.04 Milestone: 16.04.7 => None ** Changed in: mahara/16.10 Milestone: 16.10.4 => None ** Changed in: mahara/17.04 Milestone: 17.04.2 => None ** Changed in: mahara/17.10 Milestone: 17.10.0 => None -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1687343 Title: Embeldy discontinued free API tiers Status in Mahara: Invalid Status in Mahara 16.04 series: Invalid Status in Mahara 16.10 series: Invalid Status in Mahara 17.04 series: Invalid Status in Mahara 17.10 series: Invalid Bug description: https://mahara.org/interaction/forum/topic.php?id=7716&post=31858 Embedly discontinued its free API tiers and only paid subscriptions are available. Cards doesn't seem to work properly when viewing a Mahara page (it is OK in edit mode). So we'll need to take a look at what to do with embedly and if we can still provide it to some degree. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1687343/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1687499] Re: Missing simplasamlphp memcached files to all working with memcached
** Changed in: mahara/17.04 Milestone: 17.04.2 => 17.04.3 ** Changed in: mahara/16.10 Milestone: 16.10.4 => 16.10.5 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1687499 Title: Missing simplasamlphp memcached files to all working with memcached Status in Mahara: In Progress Status in Mahara 16.10 series: Confirmed Status in Mahara 17.04 series: Confirmed Status in Mahara 17.10 series: In Progress Bug description: This is an oversight from bug 1631808 To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1687499/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1680644] Re: unable to drop files to upload
** Changed in: mahara/17.04 Milestone: 17.04.2 => 17.04.3 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1680644 Title: unable to drop files to upload Status in Mahara: Confirmed Status in Mahara 17.04 series: Confirmed Status in Mahara 17.10 series: Confirmed Bug description: Tested on Site: https://master-mahara.catalystdemo.net.nz Browser: Safari 10.0.3 Device: MacBook Pro Steps to Reproduce: 1) Navigate to Groups> Select a group>Journals 2) Create a journal 3) Add a new entry to the jounal 4) While giving the details to add the entry for the journal try to attach a file by clicking on "Add a file" Expected Result: A pop up should be displayed with an option to upload a file and an option to drop files to upload ( see screenshot 1) Actual Result: Drop files here to upload doesnt show up on safari ( see screenshot 2) To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1680644/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1644386] Re: Submitted portfolios don't appear in group pages block automatically after editing group config
** Changed in: mahara/17.04 Milestone: 17.04.2 => 17.04.3 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1644386 Title: Submitted portfolios don't appear in group pages block automatically after editing group config Status in Mahara: Confirmed Status in Mahara 17.04 series: Confirmed Status in Mahara 17.10 series: Confirmed Bug description: When we fixed bug 1582039 we forgot to handle the case when one is switching a group from one we can't submit to to now allow submissions. This needs to be added - the fix will be similar to how we handle this when creating the group but in the group_update function To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1644386/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1184465] Re: Add version numbers to language packs
** Changed in: mahara/17.04 Milestone: 17.04.2 => 17.04.3 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1184465 Title: Add version numbers to language packs Status in Mahara: Confirmed Status in Mahara 17.04 series: Confirmed Status in Mahara 17.10 series: Confirmed Bug description: As I touched on in https://bugs.launchpad.net/mahara/+bug/1180544 , there's currently no way for a user looking at the langpacks site ( http://langpacks.mahara.org/ ) to tell whether there's been an update to their language pack. Therefore, it would be useful if we added version numbers to the language packs. These could be placed in lang/langconfig.php, something like this: $string['release'] = '1.7.1'; // The Mahara release number this langpack was created for $string['version'] = '2013052700'; // Incremented on each new release of the langpack, using the current date. And the name of the langpack file could be changed to something along the lines of "vi-1.7_STABLE-2013052700.tar.gz". A related idea would be to have specific langpack releases tied to Mahara minor version releases, to support the case where a language string's name is changed in a minor version. In that case, you wouldn't want to upgrade your langpacks before your Mahara version has been upgraded. In that case you'd want langpack releases for each minor version, as well as maybe a "nightly" langpack release. vi-1.7.3.tar.tgz vi-1.7.4.tar.tgz vi-1.7_STABLE-2013052700.tar.gz To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1184465/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1599414] Re: New composer-managed SimpleSAML breaks PHPUnit tests.
** Changed in: mahara/17.04
Milestone: 17.04.2 => 17.04.3
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1599414
Title:
New composer-managed SimpleSAML breaks PHPUnit tests.
Status in Mahara:
Confirmed
Status in Mahara 17.04 series:
Confirmed
Status in Mahara 17.10 series:
Confirmed
Bug description:
While writing a PHPUnit test for one of my patches, I noticed that the
new composer-managed SimpleSAML, if present, breaks "make phpunit",
because it contains some phpunit tests that get detected but are
lacking the proper stuff to make them run correctly.
To replicate:
1. Install the SimpleSAMLPHP library by doing "make ssphp"
2. Run phpunit tests by doing "make phpunit"
Expected result: tests run with no failures
Actual result: Tests fail out with this error message
PHP Fatal error: Class 'SimpleSAML_Auth_ProcessingFilter' not found in
/home/aaronw/www/mahara/htdocs/auth/saml/extlib/simplesamlphp/modules/exampleauth/lib/Auth/Process/RedirectTest.php
on line 7
PHP Stack trace:
PHP 1. {main}()
/home/aaronw/www/mahara/external/vendor/phpunit/phpunit/composer/bin/phpunit:0
PHP 2. PHPUnit_TextUI_Command::main()
/home/aaronw/www/mahara/external/vendor/phpunit/phpunit/composer/bin/phpunit:63
PHP 3. PHPUnit_TextUI_Command->run()
/home/aaronw/www/mahara/external/vendor/phpunit/phpunit/PHPUnit/TextUI/Command.php:129
PHP 4. PHPUnit_Runner_BaseTestRunner->getTest()
/home/aaronw/www/mahara/external/vendor/phpunit/phpunit/PHPUnit/TextUI/Command.php:150
PHP 5. PHPUnit_Framework_TestSuite->addTestFiles()
/home/aaronw/www/mahara/external/vendor/phpunit/phpunit/PHPUnit/Runner/BaseTestRunner.php:96
PHP 6. PHPUnit_Framework_TestSuite->addTestFile()
/home/aaronw/www/mahara/external/vendor/phpunit/phpunit/PHPUnit/Framework/TestSuite.php:416
PHP 7. PHPUnit_Util_Fileloader::checkAndLoad()
/home/aaronw/www/mahara/external/vendor/phpunit/phpunit/PHPUnit/Framework/TestSuite.php:355
PHP 8. PHPUnit_Util_Fileloader::load()
/home/aaronw/www/mahara/external/vendor/phpunit/phpunit/PHPUnit/Util/Fileloader.php:76
PHP 9. include_once()
/home/aaronw/www/mahara/external/vendor/phpunit/phpunit/PHPUnit/Util/Fileloader.php:92
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1599414/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1608305] Re: Can't delete a block in Safari
** Changed in: mahara/16.04 Status: Confirmed => Incomplete ** Changed in: mahara/16.10 Status: Confirmed => Incomplete ** Changed in: mahara Milestone: 17.04.2 => 17.04.3 ** Changed in: mahara/16.04 Milestone: 16.04.7 => 16.04.8 ** Changed in: mahara/16.10 Milestone: 16.10.4 => 16.10.5 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1608305 Title: Can't delete a block in Safari Status in Mahara: Incomplete Status in Mahara 16.04 series: Incomplete Status in Mahara 16.10 series: Incomplete Bug description: OS: X El Capitan Browser: Safari 9 Mahara: 16.10 Not able to delete a block/content created from Page editor when delete button is click Test step: 1. Log on as User 2. From Profile>Page 3. Click Edit on existing Page 4. Click on a content from the side panel>Block is added on the page 5. Edit and Delete button is displayed from the block 6. Click Delete Result: Block is not deleted To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1608305/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1514275] Re: Add a minaccept to look for the "empty()" function called with a non-variable argument
** Changed in: mahara
Milestone: 16.04.7 => 17.10.0
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1514275
Title:
Add a minaccept to look for the "empty()" function called with a non-
variable argument
Status in Mahara:
Confirmed
Bug description:
We've had a few bugs now caused by people calling the PHP empty()
function with a parameter that is not a single variable. (And at least
one caused by putting empty() into a Dwoo template, where its argument
was parsed by Dwoo into an expression.)
This causes a problem because we support PHP 5.3+, and prior to PHP
5.5 it causes a fatal exception if you try to call empty() with an
argument that is not a single variable.
I think this should actually be a pretty easy one to check for,
fortunately. We just need to check for "empty(" followed by a
character that isn't "$", so a regex like this: /\bempty\(\s*[^$]/i
And in Dwoo templates, where empty() can't be used at all because
there's no guarantee of what Dwoo will parse it into, we'd check for
it in the form "empty()" or in the Dwoo tag pipe syntax "|empty":
/(\bempty\(|\|empty\b)/i
Note that any regex to check for this would need to be case-
insensitive, because PHP function calls are not case sensitive.
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1514275/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1622771] Re: Bulk delete doesnt work on safari
** Changed in: mahara/17.04 Milestone: 17.04.2 => 17.04.3 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1622771 Title: Bulk delete doesnt work on safari Status in Mahara: Confirmed Status in Mahara 17.04 series: Confirmed Status in Mahara 17.10 series: Confirmed Bug description: Version 16.04 and 16.10 Browser : safari Steps to reproduce: 1) Add few users as site administrators 2) Login as site administrator 3) Try to self-delete(site-administrator) the along with another users Expected Result: An error message should be displayed. Related to https://bugs.launchpad.net/mahara/+bug/1574941 Actual result: When trying to delete the users it stays on the page and does nothing Note: This also happens when an institution admin logs in and tries to self-delete with other users To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1622771/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1444182] Re: Leaving feedback on own page generates notification to self
** Changed in: mahara Milestone: 16.04.7 => 17.10.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1444182 Title: Leaving feedback on own page generates notification to self Status in Mahara: Confirmed Bug description: We don't need to receive a notification when we comment on our own page as we already know we have done that. To test: 1) Install fresh mahara 2) Add a user: UserA 3) Login as UserA and create a page 4) Leave feedback on page (doesn't matter if first feeback or replying to other's feedback) 5) Check inbox - there is a message both 'to' and 'from' UserA Will mark this as a low bug as it's more of an annoyance than the system being broken. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1444182/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1393620] Re: webservices: get_groups_by_id requires institution
** Changed in: mahara/17.04 Milestone: 17.04.2 => 17.04.3 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1393620 Title: webservices: get_groups_by_id requires institution Status in Mahara: Confirmed Status in Mahara 17.04 series: Confirmed Status in Mahara 17.10 series: Confirmed Bug description: Currently the webservices method to fetch group information by id requires the group to have institution set. Will need to be adjusted to allow for groups not attached to an institution. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1393620/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1572825] Re: voki externalmedia embed code changed
** Also affects: mahara/17.04 Importance: Undecided Status: New ** Also affects: mahara/17.10 Importance: High Assignee: Cecilia Vela Gurovic (ceciliavg) Status: In Progress ** Changed in: mahara/17.04 Importance: Undecided => High ** Changed in: mahara/17.04 Status: New => Confirmed ** Changed in: mahara/16.04 Milestone: 16.04.7 => 16.04.8 ** Changed in: mahara/16.10 Milestone: 16.10.4 => 16.10.5 ** Changed in: mahara/17.04 Milestone: None => 17.04.3 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1572825 Title: voki externalmedia embed code changed Status in Mahara: In Progress Status in Mahara 16.04 series: Confirmed Status in Mahara 16.10 series: Confirmed Status in Mahara 17.04 series: Confirmed Status in Mahara 17.10 series: In Progress Bug description: A recent support post on the Mahara forums has highlighted that the externalmedia flags the voki URL invalid: https://mahara.org/interaction/forum/topic.php?id=4007&offset=0&limit=10#post30536 It appears that the links have changed and will require an update in Mahara. Previous voki bug: https://bugs.launchpad.net/mahara/+bug/905097 To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1572825/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1681569] Re: Error from rmdirr() function - PHP dir() failed to open dir
** Changed in: mahara/17.04 Milestone: 17.04.2 => 17.04.3 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1681569 Title: Error from rmdirr() function - PHP dir() failed to open dir Status in Mahara: In Progress Status in Mahara 17.04 series: In Progress Status in Mahara 17.10 series: In Progress Bug description: Getting this error when trying to clear cache on paired server deployment. The cache clears fine on one server but fails on the other. I suspect it's due to one server replicating to the other and locking the dir from being deleted. The rmdirr() function needs to make sure the dir is readable before trying to iterate thru it To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1681569/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1693061] A patch has been submitted for review
Patch for "master" branch: https://reviews.mahara.org/7783 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1693061 Title: Edit access screen needs to check if data is saved before leaving Status in Mahara: In Progress Bug description: In the Share | Edit access screen (/view/accessurl.php) of a page, while we are working on it, we can leave the page at any time without being reminded that we have unsaved changes. This should not happen, a message needs to be display for us to confirm if we want to leave and lose the changes, or stay and continue working. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1693061/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1690232] Re: Can't click the "Comments" link in a retractable block
** Changed in: mahara/16.04 Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1690232 Title: Can't click the "Comments" link in a retractable block Status in Mahara: Fix Committed Status in Mahara 16.04 series: Fix Committed Status in Mahara 16.10 series: In Progress Status in Mahara 17.04 series: Fix Committed Status in Mahara 17.10 series: Fix Committed Bug description: Mahara 16.04+ You can't click on "Comments" in a retractable block. It just loads the page again but doesn't open the modal. It works fine when the block is not retracted. To replicate: 1. Create a page with a block that can have comments, e.g. "Note". 2. Set the page to auto-retract 3. View the page, add a comment and go back to the page. 4. Click the "Comments" button. Expected result: The comments modal pops in. Actual result: Nothing happens. When you test it, also make sure to test all retractable settings: No, Yes, auto-retract. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1690232/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1690232] A change has been merged
Reviewed: https://reviews.mahara.org/7782 Committed: https://git.mahara.org/mahara/mahara/commit/a4577946c3d7b8a62aafcbc3c8cf4d5f91e7cc78 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:16.04_STABLE commit a4577946c3d7b8a62aafcbc3c8cf4d5f91e7cc78 Author: Robert Lyon Date: Sun May 14 16:09:28 2017 +1200 Bug 1690232: Comments link on retractable block failing to open modal Actually the modal is opening and closing in the same instant. This is caused by some code dealing with collapsible blocks making sure modals are closed if outside certain rules. This change checks what modal we are wanting and closing all but the one are targeting when clicking the 'comments' link behatnotneeded Sponsored by SWITCH Change-Id: Idb5165bdc8349f77286aa776ff75d152968aefda Signed-off-by: Robert Lyon (cherry picked from commit 5ce66781dfa1bd23f1bb632b9e61e68677259358) (cherry picked from commit b2858fcf96d80809b8a9d6af4a85a9fc8d7fc392) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1690232 Title: Can't click the "Comments" link in a retractable block Status in Mahara: Fix Committed Status in Mahara 16.04 series: Fix Committed Status in Mahara 16.10 series: In Progress Status in Mahara 17.04 series: Fix Committed Status in Mahara 17.10 series: Fix Committed Bug description: Mahara 16.04+ You can't click on "Comments" in a retractable block. It just loads the page again but doesn't open the modal. It works fine when the block is not retracted. To replicate: 1. Create a page with a block that can have comments, e.g. "Note". 2. Set the page to auto-retract 3. View the page, add a comment and go back to the page. 4. Click the "Comments" button. Expected result: The comments modal pops in. Actual result: Nothing happens. When you test it, also make sure to test all retractable settings: No, Yes, auto-retract. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1690232/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1690232] A change has been merged
Reviewed: https://reviews.mahara.org/7781 Committed: https://git.mahara.org/mahara/mahara/commit/84a76f608d089e2cf1de395eda1d17a7a77ce4b6 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:16.10_STABLE commit 84a76f608d089e2cf1de395eda1d17a7a77ce4b6 Author: Robert Lyon Date: Sun May 14 16:09:28 2017 +1200 Bug 1690232: Comments link on retractable block failing to open modal Actually the modal is opening and closing in the same instant. This is caused by some code dealing with collapsible blocks making sure modals are closed if outside certain rules. This change checks what modal we are wanting and closing all but the one are targeting when clicking the 'comments' link behatnotneeded Sponsored by SWITCH Change-Id: Idb5165bdc8349f77286aa776ff75d152968aefda Signed-off-by: Robert Lyon (cherry picked from commit 5ce66781dfa1bd23f1bb632b9e61e68677259358) (cherry picked from commit b2858fcf96d80809b8a9d6af4a85a9fc8d7fc392) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1690232 Title: Can't click the "Comments" link in a retractable block Status in Mahara: Fix Committed Status in Mahara 16.04 series: Fix Committed Status in Mahara 16.10 series: Fix Committed Status in Mahara 17.04 series: Fix Committed Status in Mahara 17.10 series: Fix Committed Bug description: Mahara 16.04+ You can't click on "Comments" in a retractable block. It just loads the page again but doesn't open the modal. It works fine when the block is not retracted. To replicate: 1. Create a page with a block that can have comments, e.g. "Note". 2. Set the page to auto-retract 3. View the page, add a comment and go back to the page. 4. Click the "Comments" button. Expected result: The comments modal pops in. Actual result: Nothing happens. When you test it, also make sure to test all retractable settings: No, Yes, auto-retract. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1690232/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1690232] Re: Can't click the "Comments" link in a retractable block
** Changed in: mahara/16.10 Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1690232 Title: Can't click the "Comments" link in a retractable block Status in Mahara: Fix Committed Status in Mahara 16.04 series: Fix Committed Status in Mahara 16.10 series: Fix Committed Status in Mahara 17.04 series: Fix Committed Status in Mahara 17.10 series: Fix Committed Bug description: Mahara 16.04+ You can't click on "Comments" in a retractable block. It just loads the page again but doesn't open the modal. It works fine when the block is not retracted. To replicate: 1. Create a page with a block that can have comments, e.g. "Note". 2. Set the page to auto-retract 3. View the page, add a comment and go back to the page. 4. Click the "Comments" button. Expected result: The comments modal pops in. Actual result: Nothing happens. When you test it, also make sure to test all retractable settings: No, Yes, auto-retract. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1690232/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1686539] Re: The pages/collections list access dropdown on last panel goes too far to the right
** Changed in: mahara/17.04 Milestone: 17.04.2 => 17.04.3 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1686539 Title: The pages/collections list access dropdown on last panel goes too far to the right Status in Mahara: Confirmed Status in Mahara 17.04 series: Confirmed Status in Mahara 17.10 series: Confirmed Bug description: This used to align right for the last cell but the patch https://reviews.mahara.org/#/c/7671/ broke this To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1686539/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1692385] A change has been merged
Reviewed: https://reviews.mahara.org/7776 Committed: https://git.mahara.org/mahara/mahara/commit/433ab8e6d309a2174c5b523f3a6c354f14f61587 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:master commit 433ab8e6d309a2174c5b523f3a6c354f14f61587 Author: Robert Lyon Date: Tue May 23 14:12:50 2017 +1200 Bug 1692749: Security: Stop event log having plain text passwords This patch only deals with: 1) removing passwords from existing event_log table data 2) stopping the recording of passwords into the event_log table 3) sets the reset password on next login for those users It doesn't deal with removing the unnecessary cruft information that will be handled by the bug 1692385 behatnotneeded Change-Id: Id29148f78fa6918f5f5afcb89d211ccb3b60c95b Signed-off-by: Robert Lyon -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1692385 Title: Adjust the event_log table to facilitate logging of more chronological information Status in Mahara: In Progress Bug description: Currently for a number of things we only record the creation time (ctime) and last time they were interacted with (mtime). For views we also record last accessed time (atime). It would be better if we recorded the changes over time for things. So will add some _logging tables to record this info To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1692385/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1683582] Re: Don't show journal entry author when viewing page anonymously
** Changed in: mahara/17.04 Milestone: 17.04.2 => 17.04.3 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1683582 Title: Don't show journal entry author when viewing page anonymously Status in Mahara: In Progress Status in Mahara 17.04 series: Confirmed Status in Mahara 17.10 series: In Progress Bug description: This is a follow-on bug from bug #1681987. When you have journal entries on a page, they still display the "Posted by Person on" rather than just "Posted on" to anonymize it when you are not supposed to see someone's name. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1683582/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1693388] Re: behat test disable_external_resources.feature failing
** Changed in: mahara Status: New => Incomplete -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1693388 Title: behat test disable_external_resources.feature failing Status in Mahara: Incomplete Bug description: test/behat/features/admin/disable_external_resources.feature failed on one of my patches automated as well as locally, and then I noticed it also fails on master. I discovered I could fix it by adding two wait steps, between lines 33/34 and lines 54/55: 33 And I press "Select \"Image2.png\"" 34 And I press "Submit" 54 And I enable the switch "Disable external resources in user HTML" 55 And I press "Update site options" I see that bug 1575512 is supposed to remove the need for wait steps, but that patch is not the cause of this failure as I checked the history for the disable_external_resources.feature which shows it didn't have wait steps originally. So I'm confused. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1693388/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1672932] Re: Group member not allowed creating/editing groups can create collections
Hi Kristina,
I was planning to recreate the issue so I can apply a patch, and was
unable to recreate the issue on 17.10-dev branch.
Every time the group admin not allow the group members to edit/ create
content, the regular member loose the ability to add a page/ collection.
Have I missed a step or was this fixed elsewhere, please let me know.
Thanks,
Pramith.
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1672932
Title:
Group member not allowed creating/editing groups can create
collections
Status in Mahara:
Confirmed
Bug description:
Tested on Mahara 16.10 and preview 17.04
1. Group admin does not allow regular group members to edit / create content.
2. Group admin creates a couple of pages.
3. Regular group member logs in and creates a collection. They do get an
error message:
[WAR] 50 (lib/dml.php:277) reset() expects parameter 1 to be array, boolean
given
Call stack (most recent first):
log_message("reset() expects parameter 1 to be array, boolean g...", 8,
true, true, "/home/kristina/code/1610stable/htdocs/lib/dml.php", 277) at
/home/kristina/code/1610stable/htdocs/lib/errors.php:521
error(2, "reset() expects parameter 1 to be array, boolean g...",
"/home/kristina/code/1610stable/htdocs/lib/dml.php", 277, array(size 3)) at
Unknown:0
reset(false) at /home/kristina/code/1610stable/htdocs/lib/dml.php:277
count_records_sql("SELECT token FROM {view_access} WHERE view IN
(45)...") at /home/kristina/code/1610stable/htdocs/collection/views.json.php:106
Expected result though: Regular group member should not be able to
create a collection as they aren't allowed to create / edit pages.
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1672932/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1692385] A change has been merged
Reviewed: https://reviews.mahara.org/7784 Committed: https://git.mahara.org/mahara/mahara/commit/fd71dd6d3165a9670f6b1672e9c2056bff1a70f5 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:15.04_STABLE commit fd71dd6d3165a9670f6b1672e9c2056bff1a70f5 Author: Robert Lyon Date: Tue May 23 14:12:50 2017 +1200 Bug 1692749: Security: Stop event log having plain text passwords This patch only deals with: 1) removing passwords from existing event_log table data 2) stopping the recording of passwords into the event_log table 3) sets the reset password on next login for those users It doesn't deal with removing the unnecessary cruft information that will be handled by the bug 1692385 behatnotneeded Change-Id: Id29148f78fa6918f5f5afcb89d211ccb3b60c95b Signed-off-by: Robert Lyon -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1692385 Title: Adjust the event_log table to facilitate logging of more chronological information Status in Mahara: In Progress Bug description: Currently for a number of things we only record the creation time (ctime) and last time they were interacted with (mtime). For views we also record last accessed time (atime). It would be better if we recorded the changes over time for things. So will add some _logging tables to record this info To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1692385/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1692385] A change has been merged
Reviewed: https://reviews.mahara.org/7785 Committed: https://git.mahara.org/mahara/mahara/commit/8a5b12e380ed2cfb4203c16838aced0d40e80c10 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:16.04_STABLE commit 8a5b12e380ed2cfb4203c16838aced0d40e80c10 Author: Robert Lyon Date: Tue May 23 14:12:50 2017 +1200 Bug 1692749: Security: Stop event log having plain text passwords This patch only deals with: 1) removing passwords from existing event_log table data 2) stopping the recording of passwords into the event_log table 3) sets the reset password on next login for those users It doesn't deal with removing the unnecessary cruft information that will be handled by the bug 1692385 behatnotneeded Change-Id: Id29148f78fa6918f5f5afcb89d211ccb3b60c95b Signed-off-by: Robert Lyon -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1692385 Title: Adjust the event_log table to facilitate logging of more chronological information Status in Mahara: In Progress Bug description: Currently for a number of things we only record the creation time (ctime) and last time they were interacted with (mtime). For views we also record last accessed time (atime). It would be better if we recorded the changes over time for things. So will add some _logging tables to record this info To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1692385/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1692385] A change has been merged
Reviewed: https://reviews.mahara.org/7786 Committed: https://git.mahara.org/mahara/mahara/commit/bd4941ba5ed622a8d66a201a5de515ad09fc42f5 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:16.10_STABLE commit bd4941ba5ed622a8d66a201a5de515ad09fc42f5 Author: Robert Lyon Date: Tue May 23 14:12:50 2017 +1200 Bug 1692749: Security: Stop event log having plain text passwords This patch only deals with: 1) removing passwords from existing event_log table data 2) stopping the recording of passwords into the event_log table 3) sets the reset password on next login for those users It doesn't deal with removing the unnecessary cruft information that will be handled by the bug 1692385 behatnotneeded Change-Id: Id29148f78fa6918f5f5afcb89d211ccb3b60c95b Signed-off-by: Robert Lyon -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1692385 Title: Adjust the event_log table to facilitate logging of more chronological information Status in Mahara: In Progress Bug description: Currently for a number of things we only record the creation time (ctime) and last time they were interacted with (mtime). For views we also record last accessed time (atime). It would be better if we recorded the changes over time for things. So will add some _logging tables to record this info To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1692385/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1692385] A change has been merged
Reviewed: https://reviews.mahara.org/7787 Committed: https://git.mahara.org/mahara/mahara/commit/e73331901ea8f6527ebc4cdda86285ef6325f285 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:17.04_STABLE commit e73331901ea8f6527ebc4cdda86285ef6325f285 Author: Robert Lyon Date: Tue May 23 14:12:50 2017 +1200 Bug 1692749: Security: Stop event log having plain text passwords This patch only deals with: 1) removing passwords from existing event_log table data 2) stopping the recording of passwords into the event_log table 3) sets the reset password on next login for those users It doesn't deal with removing the unnecessary cruft information that will be handled by the bug 1692385 behatnotneeded Change-Id: Id29148f78fa6918f5f5afcb89d211ccb3b60c95b Signed-off-by: Robert Lyon -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1692385 Title: Adjust the event_log table to facilitate logging of more chronological information Status in Mahara: In Progress Bug description: Currently for a number of things we only record the creation time (ctime) and last time they were interacted with (mtime). For views we also record last accessed time (atime). It would be better if we recorded the changes over time for things. So will add some _logging tables to record this info To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1692385/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1692749] Re: User passwords being saved in database event_log as plain text
** Changed in: mahara/16.10
Status: Confirmed => Fix Committed
** Changed in: mahara/17.04
Status: Confirmed => Fix Committed
** Information type changed from Private Security to Public Security
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1692749
Title:
User passwords being saved in database event_log as plain text
Status in Mahara:
Fix Committed
Status in Mahara 15.04 series:
Fix Committed
Status in Mahara 16.04 series:
Fix Committed
Status in Mahara 16.10 series:
Fix Committed
Status in Mahara 17.04 series:
Fix Committed
Status in Mahara 17.10 series:
Fix Committed
Bug description:
If you turn full logging for you site via:
Admin -> Configure site -> Logging settings -> Log events
Then whenever a user is created via:
Admin -> Users -> Add user
Admin -> Users -> Add users by CSV
Or in fact any place where we create a user with the create_user()
function we end up calling
handle_event('createuser', $user);
And if the $user object has password set then that is saved to
event_log table
We need to:
1) stop that from happening - in fact only save to event_log only the
bits of objects that make sense rather than everything, eg I notice
that there are a lot of "dirty":true and things who's value is null
(we can assume if key doesn't exist then it would be null rather than
explicitly record that)
2) clean up existing data and at very least remove the saved passwords
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1692749/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1649433] Re: Consolidate "Add file" buttons
** Changed in: mahara Assignee: (unassigned) => Pramith Dayananda (pramithkm) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1649433 Title: Consolidate "Add file" buttons Status in Mahara: Confirmed Bug description: We use two different ways of adding files to a text box / resume sections etc.: One, which allows you to add files from both your Mahara storage and computer and another one only from the computer. The latter one is the older one and can still be found in certain places. We should consolidate the occurances to always use the new way of adding files to be more consistent. Best case in point: When you add a file to your education history, you get the old button. However, when you edit that entry, you get the new button (see attachment). To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1649433/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1692749] Re: User passwords being saved in database event_log as plain text
** Changed in: mahara/15.04
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1692749
Title:
User passwords being saved in database event_log as plain text
Status in Mahara:
Fix Committed
Status in Mahara 15.04 series:
Fix Released
Status in Mahara 16.04 series:
Fix Committed
Status in Mahara 16.10 series:
Fix Committed
Status in Mahara 17.04 series:
Fix Committed
Status in Mahara 17.10 series:
Fix Committed
Bug description:
If you turn full logging for you site via:
Admin -> Configure site -> Logging settings -> Log events
Then whenever a user is created via:
Admin -> Users -> Add user
Admin -> Users -> Add users by CSV
Or in fact any place where we create a user with the create_user()
function we end up calling
handle_event('createuser', $user);
And if the $user object has password set then that is saved to
event_log table
We need to:
1) stop that from happening - in fact only save to event_log only the
bits of objects that make sense rather than everything, eg I notice
that there are a lot of "dirty":true and things who's value is null
(we can assume if key doesn't exist then it would be null rather than
explicitly record that)
2) clean up existing data and at very least remove the saved passwords
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1692749/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 920242] Re: Allow the sorting of the columns on /admin/groups/groups.php
This has been tagged as snack-sized, but I assume there's more work involved in this one than I first anticipated. I will talk to a Mahara - Dev to get a better idea. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/920242 Title: Allow the sorting of the columns on /admin/groups/groups.php Status in Mahara: Triaged Bug description: affects all Mahara versions On "Administer Groups" /admin/groups/groups.php a table is displayed which currently lists all groups alphabetically. It would be good to be able to sort by the other columns as well esp. when a site admin wants to get an overview of largest, smallest groups, number of admins in a group, group types used, visibility and number of groups / groups within a category. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/920242/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1686860] Re: Account settings sub menus not shown in mobile in 16.10
** Changed in: mahara/15.10 Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1686860 Title: Account settings sub menus not shown in mobile in 16.10 Status in Mahara: Fix Committed Status in Mahara 15.10 series: Fix Released Status in Mahara 16.04 series: Fix Committed Bug description: This is due to their submenu not being part of the normal menu/submenu system I've added a check for menus that begin with 'settings/' and add a class related to this so the submenu does not get hidden on small screens To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1686860/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1693426] [NEW] Destroy mahara session when Single Logout is initiated by IdP
Public bug reported: For our Single Sign-on implementation, we encountered this bug where Mahara session is not destroyed for another SP initiated logouts. For example, consider a scenario where two applications Mahara (SP1) and Moodle (SP2) are setups as service providers and connected with IdP. When a user logs out from Moodle (SP2) it sends a logout request to IDP and from there IDP sends a logout request to Mahara (SP2) which supports SLO. After receiving logout request from IDP, Mahara destroys simplesamlphp session but not Mahara session. As a result, a user is still logged on to Mahara even local simplesamlphp session and IdP sessions are destroyed! We investigated this issue and fixed it using a hack which destroys Mahara session also. We will be submitting a patch to via Gerrit for review. This is not a perfect solution as believing there should be other ways to do this perfectly e.g. first destroy simplesamlphp session, confirm that we are logged out from IdP and then destroy Mahara session. This doesn't happen when logout is initiated from Mahara (SP2) as it first destroys Mahara session and thereafter simplesamlphp session. ** Affects: mahara Importance: Undecided Status: New ** Description changed: -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1693426 Title: Destroy mahara session when Single Logout is initiated by IdP Status in Mahara: New Bug description: For our Single Sign-on implementation, we encountered this bug where Mahara session is not destroyed for another SP initiated logouts. For example, consider a scenario where two applications Mahara (SP1) and Moodle (SP2) are setups as service providers and connected with IdP. When a user logs out from Moodle (SP2) it sends a logout request to IDP and from there IDP sends a logout request to Mahara (SP2) which supports SLO. After receiving logout request from IDP, Mahara destroys simplesamlphp session but not Mahara session. As a result, a user is still logged on to Mahara even local simplesamlphp session and IdP sessions are destroyed! We investigated this issue and fixed it using a hack which destroys Mahara session also. We will be submitting a patch to via Gerrit for review. This is not a perfect solution as believing there should be other ways to do this perfectly e.g. first destroy simplesamlphp session, confirm that we are logged out from IdP and then destroy Mahara session. This doesn't happen when logout is initiated from Mahara (SP2) as it first destroys Mahara session and thereafter simplesamlphp session. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1693426/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
