[Mahara-contributors] [Bug 1706263] A patch has been submitted for review
Patch for "master" branch: https://reviews.mahara.org/7912
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1706263
Title:
Mahara17.04.2 fails to install when deployed against MariaDB v10.2.4
or higher
Status in Mahara:
New
Bug description:
During the installation process the installation is halted due to an
error. As a result further deploy+ent of the Mahara server is not
possible.
Used configuration Ubuntu 16.4LTS, Moodle 3.3.1, Mahara 17.04.2,
MariaDB 10.2.6
Consulting the apache error log files gives back following information
[Mon Jul 24 10:06:57.616387 2017] [:error] [pid 38507] [client
81.165.22.67:55069] [INF] 2a (admin/upgrade.php:49) Starting Mahara
installation..., referer: http://mahara.syntra-cloud.be/admin/index.php
[Mon Jul 24 10:07:11.571057 2017] [:error] [pid 38507] [client
81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) mysqli error: [1064: You have an
error in your SQL syntax; check the manual that corresponds to your MariaDB
server version for the right syntax to use near 'rows BIGINT(10) NOT NULL
DEFAULT 1,, referer: http://mahara.syntra-cloud.be/admin/upgrade.php
[Mon Jul 24 10:07:11.571082 2017] [:error] [pid 38507] [client
81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) iscustom TINYINT(1) NOT NULL
DEFAULT 0,, referer: http://mahara.syntra-cloud.be/admin/upgrade.php
[Mon Jul 24 10:07:11.571094 2017] [:error] [pid 38507] [client
81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) ' at line 3] in EXECUTE("CREATE
TABLE view_layout (, referer: http://mahara.syntra-cloud.be/admin/upgrade.php
[Mon Jul 24 10:07:11.571096 2017] [:error] [pid 38507] [client
81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) id BIGINT(10) NOT NULL
auto_increment,, referer: http://mahara.syntra-cloud.be/admin/upgrade.php
[Mon Jul 24 10:07:11.571097 2017] [:error] [pid 38507] [client
81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) rows BIGINT(10) NOT NULL
DEFAULT 1,, referer: http://mahara.syntra-cloud.be/admin/upgrade.php
[Mon Jul 24 10:07:11.571099 2017] [:error] [pid 38507] [client
81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) iscustom TINYINT(1) NOT NULL
DEFAULT 0,, referer: http://mahara.syntra-cloud.be/admin/upgrade.php
[Mon Jul 24 10:07:11.571101 2017] [:error] [pid 38507] [client
81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) layoutmenuorder BIGINT(10)
NOT NULL DEFAULT 0,, referer: http://mahara.syntra-cloud.be/admin/upgrade.php
[Mon Jul 24 10:07:11.571102 2017] [:error] [pid 38507] [client
81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) CONSTRAINT PRIMARY KEY (id),
referer: http://mahara.syntra-cloud.be/admin/upgrade.php
[Mon Jul 24 10:07:11.571104 2017] [:error] [pid 38507] [client
81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) )ENGINE=innodb")Command was:
CREATE TABLE view_layout (, referer:
http://mahara.syntra-cloud.be/admin/upgrade.php
[Mon Jul 24 10:07:11.571106 2017] [:error] [pid 38507] [client
81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) id BIGINT(10) NOT NULL
auto_increment,, referer: http://mahara.syntra-cloud.be/admin/upgrade.php
[Mon Jul 24 10:07:11.571108 2017] [:error] [pid 38507] [client
81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) rows BIGINT(10) NOT NULL
DEFAULT 1,, referer: http://mahara.syntra-cloud.be/admin/upgrade.php
[Mon Jul 24 10:07:11.571109 2017] [:error] [pid 38507] [client
81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) iscustom TINYINT(1) NOT NULL
DEFAULT 0,, referer: http://mahara.syntra-cloud.be/admin/upgrade.php
[Mon Jul 24 10:07:11.57 2017] [:error] [pid 38507] [client
81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) layoutmenuorder BIGINT(10)
NOT NULL DEFAULT 0,, referer: http://mahara.syntra-cloud.be/admin/upgrade.php
[Mon Jul 24 10:07:11.571112 2017] [:error] [pid 38507] [client
81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) CONSTRAINT PRIMARY KEY (id),
referer: http://mahara.syntra-cloud.be/admin/upgrade.php
Looking into file htdocs/lib/db/install.xml (line726) – table view_layout
A Quick analysis of the problem indicated the following
The column rows in the table view_layout is causing a problem (as of MariaDB
10.2.4 rows is now a reserved keyword
(https://mariadb.com/kb/en/mariadb/reserved-words/)
To hotfix the issue I´ve updated the column rows to numrows in the
following files after which the installation continues as expected and
Mahara functioned properly.
htdocs/lib/db/install.xml (line726) rename ´rows´ column to ´numrows´
htdocs/lib/db/upgrade.php (line2407) rename ´rows´ column to ´numrows´
[Mahara-contributors] [Bug 1694171] A patch has been submitted for review
Patch for "master" branch: https://reviews.mahara.org/7913 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1694171 Title: Upgrade Elasticsearch to Elasticsearch 5 Status in Mahara: In Progress Bug description: Upgrade to latest version of Elasticsearch To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1694171/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1706263] Re: Mahara17.04.2 fails to install when deployed against MariaDB v10.2.4 or higher
I updated the patch to include latest new keywords for versions
PostgresSQL 10
MySQL 8.0.3
MariaDB 10.2.7
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1706263
Title:
Mahara17.04.2 fails to install when deployed against MariaDB v10.2.4
or higher
Status in Mahara:
New
Bug description:
During the installation process the installation is halted due to an
error. As a result further deploy+ent of the Mahara server is not
possible.
Used configuration Ubuntu 16.4LTS, Moodle 3.3.1, Mahara 17.04.2,
MariaDB 10.2.6
Consulting the apache error log files gives back following information
[Mon Jul 24 10:06:57.616387 2017] [:error] [pid 38507] [client
81.165.22.67:55069] [INF] 2a (admin/upgrade.php:49) Starting Mahara
installation..., referer: http://mahara.syntra-cloud.be/admin/index.php
[Mon Jul 24 10:07:11.571057 2017] [:error] [pid 38507] [client
81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) mysqli error: [1064: You have an
error in your SQL syntax; check the manual that corresponds to your MariaDB
server version for the right syntax to use near 'rows BIGINT(10) NOT NULL
DEFAULT 1,, referer: http://mahara.syntra-cloud.be/admin/upgrade.php
[Mon Jul 24 10:07:11.571082 2017] [:error] [pid 38507] [client
81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) iscustom TINYINT(1) NOT NULL
DEFAULT 0,, referer: http://mahara.syntra-cloud.be/admin/upgrade.php
[Mon Jul 24 10:07:11.571094 2017] [:error] [pid 38507] [client
81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) ' at line 3] in EXECUTE("CREATE
TABLE view_layout (, referer: http://mahara.syntra-cloud.be/admin/upgrade.php
[Mon Jul 24 10:07:11.571096 2017] [:error] [pid 38507] [client
81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) id BIGINT(10) NOT NULL
auto_increment,, referer: http://mahara.syntra-cloud.be/admin/upgrade.php
[Mon Jul 24 10:07:11.571097 2017] [:error] [pid 38507] [client
81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) rows BIGINT(10) NOT NULL
DEFAULT 1,, referer: http://mahara.syntra-cloud.be/admin/upgrade.php
[Mon Jul 24 10:07:11.571099 2017] [:error] [pid 38507] [client
81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) iscustom TINYINT(1) NOT NULL
DEFAULT 0,, referer: http://mahara.syntra-cloud.be/admin/upgrade.php
[Mon Jul 24 10:07:11.571101 2017] [:error] [pid 38507] [client
81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) layoutmenuorder BIGINT(10)
NOT NULL DEFAULT 0,, referer: http://mahara.syntra-cloud.be/admin/upgrade.php
[Mon Jul 24 10:07:11.571102 2017] [:error] [pid 38507] [client
81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) CONSTRAINT PRIMARY KEY (id),
referer: http://mahara.syntra-cloud.be/admin/upgrade.php
[Mon Jul 24 10:07:11.571104 2017] [:error] [pid 38507] [client
81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) )ENGINE=innodb")Command was:
CREATE TABLE view_layout (, referer:
http://mahara.syntra-cloud.be/admin/upgrade.php
[Mon Jul 24 10:07:11.571106 2017] [:error] [pid 38507] [client
81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) id BIGINT(10) NOT NULL
auto_increment,, referer: http://mahara.syntra-cloud.be/admin/upgrade.php
[Mon Jul 24 10:07:11.571108 2017] [:error] [pid 38507] [client
81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) rows BIGINT(10) NOT NULL
DEFAULT 1,, referer: http://mahara.syntra-cloud.be/admin/upgrade.php
[Mon Jul 24 10:07:11.571109 2017] [:error] [pid 38507] [client
81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) iscustom TINYINT(1) NOT NULL
DEFAULT 0,, referer: http://mahara.syntra-cloud.be/admin/upgrade.php
[Mon Jul 24 10:07:11.57 2017] [:error] [pid 38507] [client
81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) layoutmenuorder BIGINT(10)
NOT NULL DEFAULT 0,, referer: http://mahara.syntra-cloud.be/admin/upgrade.php
[Mon Jul 24 10:07:11.571112 2017] [:error] [pid 38507] [client
81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) CONSTRAINT PRIMARY KEY (id),
referer: http://mahara.syntra-cloud.be/admin/upgrade.php
Looking into file htdocs/lib/db/install.xml (line726) – table view_layout
A Quick analysis of the problem indicated the following
The column rows in the table view_layout is causing a problem (as of MariaDB
10.2.4 rows is now a reserved keyword
(https://mariadb.com/kb/en/mariadb/reserved-words/)
To hotfix the issue I´ve updated the column rows to numrows in the
following files after which the installation continues as expected and
Mahara functioned properly.
htdocs/lib/db/install.xml (line726) rename ´rows´ column to ´numrows´
htdocs/lib/db/upgrade.ph
[Mahara-contributors] [Bug 1708335] [NEW] false fails in behat tests occuring after "I scroll to" steps?
Public bug reported: I noticed that the automated tests often flake out at the same lines: 98/179 of resume_page.feature 37/49 of social_media_buttons.feature What these lines have in common is that they follow an "I scroll to..." step in the test. I wondered whether this was because the next step was trying to execute before the scroll finished, and from looking at the code, the scroll step doesn't run through the spin function, so maybe that's why we get fails?? Anyway to test that theory, I did some digging into implementing a wait in that scenario and discovered Mink has a wait function that takes a timeout and a javascript function. I've tested it and it seems to work, so will push up changes for other people to try out to see if it makes the scroll step more robust. ** Affects: mahara Importance: Undecided Assignee: Rebecca Blundell (rjb-dev) Status: In Progress ** Tags: behat ** Changed in: mahara Status: New => In Progress ** Changed in: mahara Assignee: (unassigned) => Rebecca Blundell (rjb-dev) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1708335 Title: false fails in behat tests occuring after "I scroll to" steps? Status in Mahara: In Progress Bug description: I noticed that the automated tests often flake out at the same lines: 98/179 of resume_page.feature 37/49 of social_media_buttons.feature What these lines have in common is that they follow an "I scroll to..." step in the test. I wondered whether this was because the next step was trying to execute before the scroll finished, and from looking at the code, the scroll step doesn't run through the spin function, so maybe that's why we get fails?? Anyway to test that theory, I did some digging into implementing a wait in that scenario and discovered Mink has a wait function that takes a timeout and a javascript function. I've tested it and it seems to work, so will push up changes for other people to try out to see if it makes the scroll step more robust. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1708335/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1708335] Re: false fails in behat tests occuring after "I scroll to" steps?
Link to desc of wait function: https://knpuniversity.com/screencast/behat/javascript-waiting -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1708335 Title: false fails in behat tests occuring after "I scroll to" steps? Status in Mahara: In Progress Bug description: I noticed that the automated tests often flake out at the same lines: 98/179 of resume_page.feature 37/49 of social_media_buttons.feature What these lines have in common is that they follow an "I scroll to..." step in the test. I wondered whether this was because the next step was trying to execute before the scroll finished, and from looking at the code, the scroll step doesn't run through the spin function, so maybe that's why we get fails?? Anyway to test that theory, I did some digging into implementing a wait in that scenario and discovered Mink has a wait function that takes a timeout and a javascript function. I've tested it and it seems to work, so will push up changes for other people to try out to see if it makes the scroll step more robust. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1708335/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1708335] A patch has been submitted for review
Patch for "master" branch: https://reviews.mahara.org/7914 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1708335 Title: false fails in behat tests occuring after "I scroll to" steps? Status in Mahara: In Progress Bug description: I noticed that the automated tests often flake out at the same lines: 98/179 of resume_page.feature 37/49 of social_media_buttons.feature What these lines have in common is that they follow an "I scroll to..." step in the test. I wondered whether this was because the next step was trying to execute before the scroll finished, and from looking at the code, the scroll step doesn't run through the spin function, so maybe that's why we get fails?? Anyway to test that theory, I did some digging into implementing a wait in that scenario and discovered Mink has a wait function that takes a timeout and a javascript function. I've tested it and it seems to work, so will push up changes for other people to try out to see if it makes the scroll step more robust. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1708335/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1708335] A patch has been submitted for review
Patch for "master" branch: https://reviews.mahara.org/7915 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1708335 Title: false fails in behat tests occuring after "I scroll to" steps? Status in Mahara: In Progress Bug description: I noticed that the automated tests often flake out at the same lines: 98/179 of resume_page.feature 37/49 of social_media_buttons.feature What these lines have in common is that they follow an "I scroll to..." step in the test. I wondered whether this was because the next step was trying to execute before the scroll finished, and from looking at the code, the scroll step doesn't run through the spin function, so maybe that's why we get fails?? Anyway to test that theory, I did some digging into implementing a wait in that scenario and discovered Mink has a wait function that takes a timeout and a javascript function. I've tested it and it seems to work, so will push up changes for other people to try out to see if it makes the scroll step more robust. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1708335/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1197197] A patch has been submitted for review
Patch for "master" branch: https://reviews.mahara.org/7916 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1197197 Title: No comment modification notification for group view Status in Mahara: Confirmed Bug description: Following on from https://bugs.launchpad.net/mahara/+bug/1171310 The patch mentioned there does not allow for group administrators to be alerted when a comment is modified from private to public with activate comments & comment moderation turned on for the page To test: get patch from https://bugs.launchpad.net/mahara/+bug/1171310 (if not already merged into master) 1. Create a Group and make a page for it - take note of the url for the page 2. Make the page accessible to the public, and activate comments & comment moderation for the page (this is all under the Sharing tab) 3. Log in as a user not in the group and go to the page 4. Place a comment on the Page, making sure to untick the "Make public" box so that the comment is private. 5. Click the "edit" icon next to the newly created comment. 6. On the edit page, tick the "Make public" box, and click Save. Expected result: The comment's status should be "This comment is private | You have requested that this comment be made public" and that the administrator of the group gets an email. Outcome: no email to group administrator To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1197197/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
