[Mahara-contributors] [Bug 1714868] [NEW] mysql special characters. utf8mb4 collation

2017-09-03 Thread Cecilia Vela Gurovic 
Public bug reported:

Bug reported in forum post 
https://mahara.org/interaction/forum/topic.php?id=8034=0=10#post32267

MySQL database as we have in Mahara does not support special characters.

In master branch and mysql DB, I added a text block to a page with text 
"Some characters, like '푅' or emoticons '', produce the error."

when displaying the page I had this error: 
[WAR] 72 (blocktype/lib.php:685) unserialize(): Error at offset 18 of 
48 bytes
(complete error log in 
http://paste.wgtn.cat-it.co.nz/15069e#JTBigIqmZagCFwOVF58qww)

in the DB block_instance table, the data it is trying to unserialize
"a:5:{s:4:"text";s:74:"Some characters, like '"
looks like the it ets cut off on the special character position when is saved 
in the DB


Moodle has a fix for same problem:

"UTF-8 is a character encoding that most websites use. It encodes each of the 
1,112,064 valid code points. To store all of this information, four bytes is 
required. The most popular values are in the three byte region. MySQL by 
default only uses a three byte encoding and so values in the four byte range 
(eg. Asian characters and Emojis) can not be stored. 
MySQL does provide full four byte UTF-8 support, but it requires certain 
database settings to be configured."

https://docs.moodle.org/31/en/MySQL_full_unicode_support#Steps_to_upgrade
https://github.com/moodle/moodle/blob/master/admin/cli/mysql_collation.php


I tried using this approach by installing Mahara with utf8mb4

create database `mahara-master` character set utf8mb4 collate
utf8mb4_unicode_ci

If we create the database with this char set, we wont be able to install
Mahara, as it only supports utf8. Even if we remove this restriction, we
will have this error:

mysqli error: [1071: Specified key was too long; max key length is 3072
bytes]

could be similar to this bug:
https://bugs.launchpad.net/mahara/+bug/547437

** Affects: mahara
 Importance: Undecided
 Status: New

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1714868

Title:
  mysql special characters. utf8mb4 collation

Status in Mahara:
  New

Bug description:
  Bug reported in forum post 
  
https://mahara.org/interaction/forum/topic.php?id=8034=0=10#post32267

  MySQL database as we have in Mahara does not support special
  characters.

  In master branch and mysql DB, I added a text block to a page with text 
"Some characters, like '푅' or emoticons '', produce the error."

  when displaying the page I had this error: 
[WAR] 72 (blocktype/lib.php:685) unserialize(): Error at offset 18 of 
48 bytes
(complete error log in 
http://paste.wgtn.cat-it.co.nz/15069e#JTBigIqmZagCFwOVF58qww)

  in the DB block_instance table, the data it is trying to unserialize
  "a:5:{s:4:"text";s:74:"Some characters, like '"
  looks like the it ets cut off on the special character position when is saved 
in the DB

  
  Moodle has a fix for same problem:

  "UTF-8 is a character encoding that most websites use. It encodes each of the 
1,112,064 valid code points. To store all of this information, four bytes is 
required. The most popular values are in the three byte region. MySQL by 
default only uses a three byte encoding and so values in the four byte range 
(eg. Asian characters and Emojis) can not be stored. 
  MySQL does provide full four byte UTF-8 support, but it requires certain 
database settings to be configured."

  https://docs.moodle.org/31/en/MySQL_full_unicode_support#Steps_to_upgrade
  https://github.com/moodle/moodle/blob/master/admin/cli/mysql_collation.php


  I tried using this approach by installing Mahara with utf8mb4

  create database `mahara-master` character set utf8mb4 collate
  utf8mb4_unicode_ci

  If we create the database with this char set, we wont be able to
  install Mahara, as it only supports utf8. Even if we remove this
  restriction, we will have this error:

  mysqli error: [1071: Specified key was too long; max key length is
  3072 bytes]

  could be similar to this bug:
  https://bugs.launchpad.net/mahara/+bug/547437

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1714868/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1707076] A change has been merged

2017-09-03 Thread Mahara Bot 
Reviewed:  https://reviews.mahara.org/7973
Committed: 
https://git.mahara.org/mahara/mahara/commit/356c8f1c10b0257459ccb1723c15dd6114141fa2
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:17.04_STABLE

commit 356c8f1c10b0257459ccb1723c15dd6114141fa2
Author: Cecilia Vela Gurovic 
Date:   Mon Jul 31 17:02:36 2017 +1200

Bug 1707076: escape skin titles to display

behatnotneeded

Change-Id: I469f8136e287bb86eb17a32dbed48dec05b87969

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1707076

Title:
   Skin title not escaped in page settings form

Status in Mahara:
  Fix Committed
Status in Mahara 16.04 series:
  In Progress
Status in Mahara 16.10 series:
  In Progress
Status in Mahara 17.04 series:
  Fix Committed
Status in Mahara 17.10 series:
  Fix Committed

Bug description:
  When testing https://bugs.launchpad.net/mahara/+bug/1706536 I noticed
  there was a problem on the page settings form where skin title was not
  being escaped.

  To test:
  1) Set up a skin with the title:

  It's all alert(1);good!

  2a) If the patch for bug 1706536 is in play it should show the title as 
inputed but not execute the js
  2b) If the patch for bug 1706536 is not present it should show the title with 
special characters escaped but not execute the js

  3) Go to pages and collections and edit a page
  4) Click on settings

  You get an alert box with '1' in it

  The title for the skin needs to be escaped/made safe

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1707076/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1694342] Re: Eventlog update in upgrade taking hours to process

2017-09-03 Thread Robert Lyon 
** Changed in: mahara/16.10
   Status: In Progress => Fix Committed

** Changed in: mahara/17.04
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1694342

Title:
  Eventlog update in upgrade taking hours to process

Status in Mahara:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Committed
Status in Mahara 17.04 series:
  Fix Committed
Status in Mahara 17.10 series:
  Fix Committed

Bug description:
  OS: Linux
  DB: Postgres
  Mahara: 16.10.4
  Browser: N/A

  With the latest security release for 16.10.4, the upgrade to clean the
  eventlog of sensitive data can take hours to process.

  We have over 56K records for the 'createuser' event. Most of them are
  LDAP accounts so the data looks like this:

  
  
"{"username":"abc","authinstance":"3","firstname":"first","lastname":"last","password":"","email":"myem...@nowhere.com","studentid":"1234","ctime":"2016-07-05
 11:29:21","urlid":"1234","quota":"524288000","id":85}"

  The upgrade updates these records to remove the '"password":""' data.

  I'll try to improve on this.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1694342/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1694342] A change has been merged

2017-09-03 Thread Mahara Bot 
Reviewed:  https://reviews.mahara.org/7862
Committed: 
https://git.mahara.org/mahara/mahara/commit/6e8fbeea486d7c10524dfc1c273b3e531c0e5f4d
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:17.04_STABLE

commit 6e8fbeea486d7c10524dfc1c273b3e531c0e5f4d
Author: Ilya Tregubov 
Date:   Thu Jun 1 15:34:10 2017 +1000

Bug #1694342: clean password from event_log takes long time

behatnotneeded

Change-Id: I26a13d2ef060078abd14bb21a61db147112a4100

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1694342

Title:
  Eventlog update in upgrade taking hours to process

Status in Mahara:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Committed
Status in Mahara 17.04 series:
  Fix Committed
Status in Mahara 17.10 series:
  Fix Committed

Bug description:
  OS: Linux
  DB: Postgres
  Mahara: 16.10.4
  Browser: N/A

  With the latest security release for 16.10.4, the upgrade to clean the
  eventlog of sensitive data can take hours to process.

  We have over 56K records for the 'createuser' event. Most of them are
  LDAP accounts so the data looks like this:

  
  
"{"username":"abc","authinstance":"3","firstname":"first","lastname":"last","password":"","email":"myem...@nowhere.com","studentid":"1234","ctime":"2016-07-05
 11:29:21","urlid":"1234","quota":"524288000","id":85}"

  The upgrade updates these records to remove the '"password":""' data.

  I'll try to improve on this.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1694342/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1694342] A change has been merged

2017-09-03 Thread Mahara Bot 
Reviewed:  https://reviews.mahara.org/7799
Committed: 
https://git.mahara.org/mahara/mahara/commit/b13178e7c737c7b10eb68570fd1adf533dfcb065
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:16.10_STABLE

commit b13178e7c737c7b10eb68570fd1adf533dfcb065
Author: Ilya Tregubov 
Date:   Thu Jun 1 13:37:49 2017 +1000

Bug #1694342: clean password from event_log takes long time

behatnotneeded

Change-Id: Ic511e25066ebd84b80118e71f70c6f867a3564b4

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1694342

Title:
  Eventlog update in upgrade taking hours to process

Status in Mahara:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Committed
Status in Mahara 17.04 series:
  Fix Committed
Status in Mahara 17.10 series:
  Fix Committed

Bug description:
  OS: Linux
  DB: Postgres
  Mahara: 16.10.4
  Browser: N/A

  With the latest security release for 16.10.4, the upgrade to clean the
  eventlog of sensitive data can take hours to process.

  We have over 56K records for the 'createuser' event. Most of them are
  LDAP accounts so the data looks like this:

  
  
"{"username":"abc","authinstance":"3","firstname":"first","lastname":"last","password":"","email":"myem...@nowhere.com","studentid":"1234","ctime":"2016-07-05
 11:29:21","urlid":"1234","quota":"524288000","id":85}"

  The upgrade updates these records to remove the '"password":""' data.

  I'll try to improve on this.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1694342/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1707076] Re: Skin title not escaped in page settings form

2017-09-03 Thread Robert Lyon 
** Changed in: mahara/17.04
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1707076

Title:
   Skin title not escaped in page settings form

Status in Mahara:
  Fix Committed
Status in Mahara 16.04 series:
  In Progress
Status in Mahara 16.10 series:
  In Progress
Status in Mahara 17.04 series:
  Fix Committed
Status in Mahara 17.10 series:
  Fix Committed

Bug description:
  When testing https://bugs.launchpad.net/mahara/+bug/1706536 I noticed
  there was a problem on the page settings form where skin title was not
  being escaped.

  To test:
  1) Set up a skin with the title:

  It's all alert(1);good!

  2a) If the patch for bug 1706536 is in play it should show the title as 
inputed but not execute the js
  2b) If the patch for bug 1706536 is not present it should show the title with 
special characters escaped but not execute the js

  3) Go to pages and collections and edit a page
  4) Click on settings

  You get an alert box with '1' in it

  The title for the skin needs to be escaped/made safe

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1707076/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1710988] A patch has been submitted for review

2017-09-03 Thread Mahara Bot 
Patch for "17.04_STABLE" branch: https://reviews.mahara.org/7974

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1710988

Title:
  broken js when using pagination in a list of radio buttons

Status in Mahara:
  Fix Committed
Status in Mahara 17.04 series:
  Fix Committed
Status in Mahara 17.10 series:
  Fix Committed

Bug description:
  affects 17.04 and master

  Cases where the js is broken:

  1. Notes: When setting the content of a note with the  'Use content
  from another note' button

  Steps to reproduce:

  - Edit a page
  - add a note to it with text 'Test' and save
  - add another note to the page
  - in the configuration, press 'Use content from another note'
  - Select the note with text 'Test' and save

  Result expected: We have two notes with text 'Test' in the page
  Actual result: We have two empty notes in the page

  2. In the personal email inbox:

  - have more than 10 unread messages in the inbox
  - go to a page different than the first one
  - Select an unread message, choosing 'Mark as read' from the Bulk options at 
the top

  Expected result: show the message as read automatically
  Actual result: will not show the message as read automatically. We need to 
refresh the page to see it.

  - have more that 10 messages
  - go to a different page than the first one
  - Select one message and choose 'delete' in the Bulk options at the top. 

  Expected result: The messages we want to delete are removed from the list
  Actual result: All messages will disappear and we have to refresh the page to 
see the changes.

  3. In outbox (messages Sent)
  Same as inbox for deleting a message

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1710988/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1710988] Re: broken js when using pagination in a list of radio buttons

2017-09-03 Thread Robert Lyon 
** Changed in: mahara/17.10
   Status: In Progress => Fix Committed

** Changed in: mahara/17.04
   Status: Confirmed => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1710988

Title:
  broken js when using pagination in a list of radio buttons

Status in Mahara:
  Fix Committed
Status in Mahara 17.04 series:
  Fix Committed
Status in Mahara 17.10 series:
  Fix Committed

Bug description:
  affects 17.04 and master

  Cases where the js is broken:

  1. Notes: When setting the content of a note with the  'Use content
  from another note' button

  Steps to reproduce:

  - Edit a page
  - add a note to it with text 'Test' and save
  - add another note to the page
  - in the configuration, press 'Use content from another note'
  - Select the note with text 'Test' and save

  Result expected: We have two notes with text 'Test' in the page
  Actual result: We have two empty notes in the page

  2. In the personal email inbox:

  - have more than 10 unread messages in the inbox
  - go to a page different than the first one
  - Select an unread message, choosing 'Mark as read' from the Bulk options at 
the top

  Expected result: show the message as read automatically
  Actual result: will not show the message as read automatically. We need to 
refresh the page to see it.

  - have more that 10 messages
  - go to a different page than the first one
  - Select one message and choose 'delete' in the Bulk options at the top. 

  Expected result: The messages we want to delete are removed from the list
  Actual result: All messages will disappear and we have to refresh the page to 
see the changes.

  3. In outbox (messages Sent)
  Same as inbox for deleting a message

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1710988/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1710988] A change has been merged

2017-09-03 Thread Mahara Bot 
Reviewed:  https://reviews.mahara.org/7934
Committed: 
https://git.mahara.org/mahara/mahara/commit/e7ed751fa4924e761a9d7f5c39084ea521fd8836
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master

commit e7ed751fa4924e761a9d7f5c39084ea521fd8836
Author: Cecilia Vela Gurovic 
Date:   Thu Aug 17 09:10:00 2017 +1200

Bug 1710988: fix js when catching 'pagechanged' event

Fix for broken function calls when selecting a
radio button in a list of notes, deleting and
marking as read messages in the inbox/outbox

Change-Id: Ia5f4b2a1f977d319ccd813a2499b29c98b15f6a0
behatnotneeded: adding a behat test later

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1710988

Title:
  broken js when using pagination in a list of radio buttons

Status in Mahara:
  Fix Committed
Status in Mahara 17.04 series:
  Fix Committed
Status in Mahara 17.10 series:
  Fix Committed

Bug description:
  affects 17.04 and master

  Cases where the js is broken:

  1. Notes: When setting the content of a note with the  'Use content
  from another note' button

  Steps to reproduce:

  - Edit a page
  - add a note to it with text 'Test' and save
  - add another note to the page
  - in the configuration, press 'Use content from another note'
  - Select the note with text 'Test' and save

  Result expected: We have two notes with text 'Test' in the page
  Actual result: We have two empty notes in the page

  2. In the personal email inbox:

  - have more than 10 unread messages in the inbox
  - go to a page different than the first one
  - Select an unread message, choosing 'Mark as read' from the Bulk options at 
the top

  Expected result: show the message as read automatically
  Actual result: will not show the message as read automatically. We need to 
refresh the page to see it.

  - have more that 10 messages
  - go to a different page than the first one
  - Select one message and choose 'delete' in the Bulk options at the top. 

  Expected result: The messages we want to delete are removed from the list
  Actual result: All messages will disappear and we have to refresh the page to 
see the changes.

  3. In outbox (messages Sent)
  Same as inbox for deleting a message

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1710988/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1710988] A change has been merged

2017-09-03 Thread Mahara Bot 
Reviewed:  https://reviews.mahara.org/7974
Committed: 
https://git.mahara.org/mahara/mahara/commit/fb7cca51283a332d851109776d1eb8c7b1a99414
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:17.04_STABLE

commit fb7cca51283a332d851109776d1eb8c7b1a99414
Author: Cecilia Vela Gurovic 
Date:   Thu Aug 17 09:10:00 2017 +1200

Bug 1710988: fix js when catching 'pagechanged' event

Fix for broken function calls when selecting a
radio button in a list of notes, deleting and
marking as read messages in the inbox/outbox

Change-Id: Ia5f4b2a1f977d319ccd813a2499b29c98b15f6a0
behatnotneeded: adding a behat test later
(cherry picked from commit e7ed751fa4924e761a9d7f5c39084ea521fd8836)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1710988

Title:
  broken js when using pagination in a list of radio buttons

Status in Mahara:
  Fix Committed
Status in Mahara 17.04 series:
  Fix Committed
Status in Mahara 17.10 series:
  Fix Committed

Bug description:
  affects 17.04 and master

  Cases where the js is broken:

  1. Notes: When setting the content of a note with the  'Use content
  from another note' button

  Steps to reproduce:

  - Edit a page
  - add a note to it with text 'Test' and save
  - add another note to the page
  - in the configuration, press 'Use content from another note'
  - Select the note with text 'Test' and save

  Result expected: We have two notes with text 'Test' in the page
  Actual result: We have two empty notes in the page

  2. In the personal email inbox:

  - have more than 10 unread messages in the inbox
  - go to a page different than the first one
  - Select an unread message, choosing 'Mark as read' from the Bulk options at 
the top

  Expected result: show the message as read automatically
  Actual result: will not show the message as read automatically. We need to 
refresh the page to see it.

  - have more that 10 messages
  - go to a different page than the first one
  - Select one message and choose 'delete' in the Bulk options at the top. 

  Expected result: The messages we want to delete are removed from the list
  Actual result: All messages will disappear and we have to refresh the page to 
see the changes.

  3. In outbox (messages Sent)
  Same as inbox for deleting a message

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1710988/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1711443] Re: "Show more" button on "Pages and collections" doesn't work in a group

2017-09-03 Thread Robert Lyon 
** Changed in: mahara/17.04
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1711443

Title:
  "Show more" button on "Pages and collections" doesn't work in a group

Status in Mahara:
  Fix Committed
Status in Mahara 17.04 series:
  Fix Committed
Status in Mahara 17.10 series:
  Fix Committed

Bug description:
  originally mentioned in
  https://mahara.org/interaction/forum/topic.php?id=8021

  To replicate:

  1. Create more than 12 pages / collections in a group.
  2. Click the "Show more" button.

  Expected result: See more pages / collections.
  Actual result: Nothing happens and the "Show more" button just disappears.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1711443/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1711443] A change has been merged

2017-09-03 Thread Mahara Bot 
Reviewed:  https://reviews.mahara.org/7955
Committed: 
https://git.mahara.org/mahara/mahara/commit/57487f149dea839776b05efc5c8a293d010cf930
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:17.04_STABLE

commit 57487f149dea839776b05efc5c8a293d010cf930
Author: Cecilia Vela Gurovic 
Date:   Tue Aug 22 16:45:01 2017 +1200

Bug 1711443: 'Show more' button in group P screen

In pagination.js, pagination_showmore function was
expecting the group value from the button clicked
to be a string, but it is a number.

.data() from jQuery converts a string representing
a number to an actual number.

behatnotneeded

Change-Id: If66231211c229f1cf18a5efb35236c2f90ad5a44
(cherry picked from commit e470bc633bd45c8ff68c9ed569c6ccd99d3024ed)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1711443

Title:
  "Show more" button on "Pages and collections" doesn't work in a group

Status in Mahara:
  Fix Committed
Status in Mahara 17.04 series:
  Fix Committed
Status in Mahara 17.10 series:
  Fix Committed

Bug description:
  originally mentioned in
  https://mahara.org/interaction/forum/topic.php?id=8021

  To replicate:

  1. Create more than 12 pages / collections in a group.
  2. Click the "Show more" button.

  Expected result: See more pages / collections.
  Actual result: Nothing happens and the "Show more" button just disappears.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1711443/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1613503] Re: Can not add groups via CSV when shortname is not relied on displayname

2017-09-03 Thread Robert Lyon 
** Changed in: mahara
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1613503

Title:
  Can not add groups via CSV when shortname is not relied on displayname

Status in Mahara:
  Fix Released

Bug description:
  version: master(16.10)

  I got the following message when adding groups via CSV

  Mahara: Site unavailable
  Something in the way you're interacting with Mahara is causing an error.
  Details if any, follow:

  group_create: The supplied shortname 'gc' is already taken. This
  shortname 'groupc' is available.

  The content of my CSV file:
  shortname,displayname,roles
  "gc","Group C","standard"

  I have to change the shortname to 'groupc' to make it work.
  Is it the new behaviour?

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1613503/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1546769] Re: The 'None' auth needs to be locked down or removed to avoid troubles with multi institutions

2017-09-03 Thread Robert Lyon 
** Changed in: mahara
   Status: In Progress => Confirmed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1546769

Title:
  The 'None' auth needs to be locked down or removed to avoid troubles
  with multi institutions

Status in Mahara:
  Confirmed

Bug description:
  When there are multiple institutions/tenants on a mahara and one of
  the tenants decides to add the 'None' auth method to their institution
  it causes havoc for users on all institutions as if they accidentally
  enter their login details wrong they get logged in to institution with
  'None' set as a new user rather than their normal institution/account.

  Things that need to be changed to avoid this problem:

  1) When an institution tries to add the 'None' auth option it needs to
  check to see if there are any other institutions present and only
  allow it if institution count = 1

  2) Conversely if the only institution uses 'None' auth then you
  shouldn't be allowed to add a new institution until that auth is
  removed

  3) And when you are able to add "None" you should probably get some
  prominent message with "Do you really want to do this? You know, it
  means that anybody will be able to log in without any authorization"

  Also as part of this change it would be very good to add a ctime (and
  maybe userid) field to the auth_instance table to record when one
  adds/edits auth details to see when things changed as this human error
  can cause big problems for users.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1546769/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1707076] A patch has been submitted for review

2017-09-03 Thread Mahara Bot 
Patch for "17.04_STABLE" branch: https://reviews.mahara.org/7973

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1707076

Title:
   Skin title not escaped in page settings form

Status in Mahara:
  Fix Committed
Status in Mahara 16.04 series:
  In Progress
Status in Mahara 16.10 series:
  In Progress
Status in Mahara 17.04 series:
  In Progress
Status in Mahara 17.10 series:
  Fix Committed

Bug description:
  When testing https://bugs.launchpad.net/mahara/+bug/1706536 I noticed
  there was a problem on the page settings form where skin title was not
  being escaped.

  To test:
  1) Set up a skin with the title:

  It's all alert(1);good!

  2a) If the patch for bug 1706536 is in play it should show the title as 
inputed but not execute the js
  2b) If the patch for bug 1706536 is not present it should show the title with 
special characters escaped but not execute the js

  3) Go to pages and collections and edit a page
  4) Click on settings

  You get an alert box with '1' in it

  The title for the skin needs to be escaped/made safe

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1707076/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1707076] A patch has been submitted for review

2017-09-03 Thread Mahara Bot 
Patch for "16.10_STABLE" branch: https://reviews.mahara.org/7972

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1707076

Title:
   Skin title not escaped in page settings form

Status in Mahara:
  Fix Committed
Status in Mahara 16.04 series:
  In Progress
Status in Mahara 16.10 series:
  In Progress
Status in Mahara 17.04 series:
  In Progress
Status in Mahara 17.10 series:
  Fix Committed

Bug description:
  When testing https://bugs.launchpad.net/mahara/+bug/1706536 I noticed
  there was a problem on the page settings form where skin title was not
  being escaped.

  To test:
  1) Set up a skin with the title:

  It's all alert(1);good!

  2a) If the patch for bug 1706536 is in play it should show the title as 
inputed but not execute the js
  2b) If the patch for bug 1706536 is not present it should show the title with 
special characters escaped but not execute the js

  3) Go to pages and collections and edit a page
  4) Click on settings

  You get an alert box with '1' in it

  The title for the skin needs to be escaped/made safe

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1707076/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1707076] A patch has been submitted for review

2017-09-03 Thread Mahara Bot 
Patch for "16.04_STABLE" branch: https://reviews.mahara.org/7971

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1707076

Title:
   Skin title not escaped in page settings form

Status in Mahara:
  Fix Committed
Status in Mahara 16.04 series:
  In Progress
Status in Mahara 16.10 series:
  In Progress
Status in Mahara 17.04 series:
  In Progress
Status in Mahara 17.10 series:
  Fix Committed

Bug description:
  When testing https://bugs.launchpad.net/mahara/+bug/1706536 I noticed
  there was a problem on the page settings form where skin title was not
  being escaped.

  To test:
  1) Set up a skin with the title:

  It's all alert(1);good!

  2a) If the patch for bug 1706536 is in play it should show the title as 
inputed but not execute the js
  2b) If the patch for bug 1706536 is not present it should show the title with 
special characters escaped but not execute the js

  3) Go to pages and collections and edit a page
  4) Click on settings

  You get an alert box with '1' in it

  The title for the skin needs to be escaped/made safe

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1707076/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1707076] Re: Skin title not escaped in page settings form

2017-09-03 Thread Robert Lyon 
** Also affects: mahara/17.04
   Importance: Undecided
   Status: New

** Also affects: mahara/16.04
   Importance: Undecided
   Status: New

** Also affects: mahara/16.10
   Importance: Undecided
   Status: New

** Changed in: mahara/17.04
   Status: New => In Progress

** Changed in: mahara/16.10
   Status: New => In Progress

** Changed in: mahara/16.04
   Status: New => In Progress

** Changed in: mahara/17.04
   Importance: Undecided => High

** Changed in: mahara/16.10
   Importance: Undecided => High

** Changed in: mahara/16.04
   Importance: Undecided => High

** Changed in: mahara/17.04
Milestone: None => 17.04.3

** Changed in: mahara/16.10
Milestone: None => 16.10.5

** Changed in: mahara/16.04
Milestone: None => 16.04.8

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1707076

Title:
   Skin title not escaped in page settings form

Status in Mahara:
  Fix Committed
Status in Mahara 16.04 series:
  In Progress
Status in Mahara 16.10 series:
  In Progress
Status in Mahara 17.04 series:
  In Progress
Status in Mahara 17.10 series:
  Fix Committed

Bug description:
  When testing https://bugs.launchpad.net/mahara/+bug/1706536 I noticed
  there was a problem on the page settings form where skin title was not
  being escaped.

  To test:
  1) Set up a skin with the title:

  It's all alert(1);good!

  2a) If the patch for bug 1706536 is in play it should show the title as 
inputed but not execute the js
  2b) If the patch for bug 1706536 is not present it should show the title with 
special characters escaped but not execute the js

  3) Go to pages and collections and edit a page
  4) Click on settings

  You get an alert box with '1' in it

  The title for the skin needs to be escaped/made safe

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1707076/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1712454] Re: Create group via webservices also creates group category if not existing

2017-09-03 Thread Robert Lyon 
** Changed in: mahara
   Status: New => In Progress

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1712454

Title:
  Create group via webservices also creates group category if not
  existing

Status in Mahara:
  In Progress

Bug description:
  Currently when one creates a group via webservices they can pass in a
  group category and if the category exists in Mahara the group is made.

  But if the group category does not exist then webservices throws an
  error

  As it's pretty safe to create missing group categories we should just
  make it if missing

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1712454/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1714830] Re: Display group portfolios instead of group pages in group homepage

2017-09-03 Thread Cecilia Vela Gurovic 
https://reviews.mahara.org/#/c/7970/

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1714830

Title:
  Display group portfolios instead of group pages in group homepage

Status in Mahara:
  In Progress
Status in Mahara 17.04 series:
  In Progress
Status in Mahara 17.10 series:
  In Progress

Bug description:
  Display group portfolios instead of group pages as the latter are
  currently ignored on the group homepage.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1714830/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 604839] A change has been merged

2017-09-03 Thread Mahara Bot 
Reviewed:  https://reviews.mahara.org/7572
Committed: 
https://git.mahara.org/mahara/mahara/commit/0b30a77a001eb49ec8338ee368811ef88577d1a2
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master

commit 0b30a77a001eb49ec8338ee368811ef88577d1a2
Author: Robert Lyon 
Date:   Wed Mar 29 11:36:10 2017 +1300

Bug 604839: Removing support for embedding .swf objects

behatnotneeded - to come later

Change-Id: I42f40d997559c4fda132e9c36dc8e2c9d016c61e
Signed-off-by: Robert Lyon 

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/604839

Title:
  Deprecate swf embedded objects

Status in Mahara:
  Fix Committed

Bug description:
  The SWFObject detection script we used in the internal media blocktype
  is using this upstream code:

http://blog.deconcept.com/swfobject/

  but it has now been replaced by this one, which is up to version 2.2:

http://code.google.com/p/swfobject/

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/604839/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 604839] Re: Deprecate swf embedded objects

2017-09-03 Thread Robert Lyon 
** Changed in: mahara
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/604839

Title:
  Deprecate swf embedded objects

Status in Mahara:
  Fix Committed

Bug description:
  The SWFObject detection script we used in the internal media blocktype
  is using this upstream code:

http://blog.deconcept.com/swfobject/

  but it has now been replaced by this one, which is up to version 2.2:

http://code.google.com/p/swfobject/

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/604839/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1714830] [NEW] Display group portfolios instead of group pages in group homepage

2017-09-03 Thread Cecilia Vela Gurovic 
Public bug reported:

Display group portfolios instead of group pages as the latter are
currently ignored on the group homepage.

** Affects: mahara
 Importance: Undecided
 Assignee: Cecilia Vela Gurovic (ceciliavg)
 Status: In Progress

** Affects: mahara/17.04
 Importance: Undecided
 Assignee: Cecilia Vela Gurovic (ceciliavg)
 Status: In Progress

** Affects: mahara/17.10
 Importance: Undecided
 Assignee: Cecilia Vela Gurovic (ceciliavg)
 Status: In Progress

** Also affects: mahara/17.04
   Importance: Undecided
   Status: New

** Also affects: mahara/17.10
   Importance: Undecided
   Status: New

** Changed in: mahara/17.04
 Assignee: (unassigned) => Cecilia Vela Gurovic (ceciliavg)

** Changed in: mahara/17.10
 Assignee: (unassigned) => Cecilia Vela Gurovic (ceciliavg)

** Changed in: mahara/17.04
   Status: New => Confirmed

** Changed in: mahara/17.10
   Status: New => In Progress

** Changed in: mahara/17.04
   Status: Confirmed => In Progress

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1714830

Title:
  Display group portfolios instead of group pages in group homepage

Status in Mahara:
  In Progress
Status in Mahara 17.04 series:
  In Progress
Status in Mahara 17.10 series:
  In Progress

Bug description:
  Display group portfolios instead of group pages as the latter are
  currently ignored on the group homepage.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1714830/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp