[Mahara-contributors] [Bug 1717861] [NEW] Redirect to incorrect port when sslproxy is on and wwwroot is set
Public bug reported: When you have your mahara behind SSL proxy and have sslproxy enabled, it redirects to incorrect port when you try to access pages which require login. When you get your mahara behind load balancer and nginx proxy on port 81 you get redirected to https://mahara.com:81/user/admin?login when try to access https://mahara.com/user/admin as not logged in user. Looks like function get_full_script_path tries to get a port even if $CFG->wwwroot is set. ** Affects: mahara Importance: Undecided Assignee: Dmitrii Metelkin (dmitriim) Status: New ** Changed in: mahara Assignee: (unassigned) => Dmitrii Metelkin (dmitriim) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1717861 Title: Redirect to incorrect port when sslproxy is on and wwwroot is set Status in Mahara: New Bug description: When you have your mahara behind SSL proxy and have sslproxy enabled, it redirects to incorrect port when you try to access pages which require login. When you get your mahara behind load balancer and nginx proxy on port 81 you get redirected to https://mahara.com:81/user/admin?login when try to access https://mahara.com/user/admin as not logged in user. Looks like function get_full_script_path tries to get a port even if $CFG->wwwroot is set. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1717861/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1434312] Re: Pieform elements/renderers documentation
** Changed in: mahara Milestone: 17.10.0 => 18.04.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1434312 Title: Pieform elements/renderers documentation Status in Mahara: Confirmed Bug description: Need to develop some useful documentation for the pieform elements/renderers Each element need to include at the top of the file a comment about what settings it uses and whether they are optional or not. Once we get each element/renderer file updated then we can collate the information on the wiki page: https://wiki.mahara.org/index.php/Developer_Area/Core_Subsystems/Form_API To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1434312/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1682349] Re: Import other fields of the user's profile when LTI creates a new user from LMS
** Changed in: mahara Milestone: 17.10.0 => 18.04.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1682349 Title: Import other fields of the user's profile when LTI creates a new user from LMS Status in Mahara: Triaged Bug description: With Mahara 17.04, LTI is a possible way of linking user accounts from a LMS to Mahara. Between Moodle and Mahara, with the LTI option "We create users" activated, a user is created when jumping for the first time from the LMS to Mahara. At the moment only the email, first name, last name are pushed from Moodle into the user's Mahara profile. I wish other information from the Moodle profile could be pushed such as the profile picture, address,… as long as the LTI protocole allows to do this. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1682349/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1600101] Re: Examples of how we can utilise the connection manager
** Changed in: mahara
Milestone: 17.10.0 => 18.04.0
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1600101
Title:
Examples of how we can utilise the connection manager
Status in Mahara:
In Progress
Bug description:
There are two example plugins called 'notification/redirect' and
'module/syncprofile' that use different ways to connect sites together
notification/redirect shows how we can use an existing api hook - in
this case the notification hook called notify_user()
module/syncprofile works by exposing it's hook via the following code,
which looks to see if there is a 'sync_profile' function in any of the
plugins:
if ($connections = Plugin::get_webservice_connections($USER, 'sync_profile'))
{
foreach ($connections as $connection) {
call_static_method($connection->connection->class, 'sync_profile',
$connection, $USER, $values);
}
}
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1600101/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1287344] Re: artefact installed upgrade problem
** Changed in: mahara
Milestone: 17.10.0 => 18.04.0
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1287344
Title:
artefact installed upgrade problem
Status in Mahara:
In Progress
Bug description:
When there is an artefact plugin missing and one tries to upgrade
another artefact plugin there is an error:
[WAR] cb (lib/errors.php:739) Failed to get a recordset: postgres7 error:
[-1: ERROR: update or delete on table "artefact_installed_type" violates
foreign key constraint "arte_art_fk" on table "artefact", referer:
https://mahara-testing/admin/upgrade.php
[Tue Mar 04 08:52:46 2014] [error] [client 127.0.0.1] [WAR] cb
(lib/errors.php:739) DETAIL: Key (name)=(socialprofile) is still referenced
from table "artefact".] in adodb_throw(DELETE FROM "artefact_installed_type"
WHERE (plugin = ? AND name NOT IN
(?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?)), Array), referer:
https://mahara-testing/admin/upgrade.php
This is due to the fact the missing plugin has artefacts in the
artefact table.
This line in lib/upgrade.php (approx line 500)
delete_records_select('artefact_installed_type', $select,
array_merge(array($pluginname),$types));
needs to have some sort of checking if associated items exist for the
plugin being removed and remove them first (or have some try { } catch
(Exception $e) {} to let the user know that there was an issue with
plugin A but still allow plugin B to be upgraded.
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1287344/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1427885] Re: Change "artefact.path" column to use the "nested set" technique for managing hierarchical data
** Changed in: mahara Milestone: 17.10.0 => 18.04.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1427885 Title: Change "artefact.path" column to use the "nested set" technique for managing hierarchical data Status in Mahara: Triaged Bug description: Originally, we just had each artefact store its parent ID. This is slow because it requires running multiple queries to find all the descendants of a node. Then, we added a "path" element to each artefact. This is better, but you can't get a performance improvement by indexing the column, because most of the queries rely on the "LIKE" operator. (See https://bugs.launchpad.net/mahara/+bug/1423700 ) So if we want to squeeze more performance out of this, I think the one remaining thing to look into is the "nested set" technique. This technique results in very fast searches for descendants, with the cost of somewhat slower writes. http://mikehillyer.com/articles/managing- hierarchical-data-in-mysql/ There are even existing PHP libraries for using the technique, such as this one: http://www.sideralis.org/baobab/ To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1427885/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1560778] Re: Convert institution auth manager from pop-up window to modal
** Changed in: mahara Milestone: 17.10.0 => 18.04.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1560778 Title: Convert institution auth manager from pop-up window to modal Status in Mahara: In Progress Bug description: On the institution config screen, one of the things you can do is manage the list of authentication methods configured for the institution. This is quite old code, and it uses a pop-up window. Now that we've got better control of modal windows (as on the block config screen) we should use a modal for this instead of a pop-up. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1560778/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1194853] Re: OpenGraph (Facebook preview) tags for the images shown on a Page
** Changed in: mahara Milestone: 17.10.0 => 18.04.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1194853 Title: OpenGraph (Facebook preview) tags for the images shown on a Page Status in Mahara: Triaged Bug description: While trying to share my own delightful endless loop of a kākā at a feeding station with a Facebook friend, I realized that Mahara doesn't provide the OpenGraph tags necessary for Facebook to show the images on a Page in its preview. So, we should add those. The most important page to do this on is the main Page display, /view/view.php . It would also make sense to do it on /artefact/view.php (for image artefacts), and possibly on the Profile page, and any other pages that can be publicly accessible which I may have forgotten (perhaps the Site home page for logged-out users?) Probably the cleanest way to do this is to add a function to the artefact API (and/or the block API?), which asks each one whether it wants to post any OpenGraph tags. It would also make sense for the Images to use their "preview" image (the one you see on artefact/view.php) rather than the image itself. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1194853/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1660237] Re: Remove "Mobile access token" from account settings
Actually we should remove the code that dealt with the old mobile upload file way and leave the files the apps hit to return a JSON message about installing Mahara mobile app instead ** Changed in: mahara Milestone: 17.10.0 => 18.04.0 ** Changed in: mahara Importance: Medium => High ** Changed in: mahara Status: Triaged => Confirmed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1660237 Title: Remove "Mobile access token" from account settings Status in Mahara: Confirmed Bug description: With Mahara 16.10 we introduced Mahara Mobile, the new mobile app for Mahara and with it the "App" settings that are managed on /module/mobileapi/apps.php We still show the "Mobile access tokens" on /account/index.php though and on /admin/site/options.php when a site has been upgraded to 16.10. These settings should be removed as they are confusing. Both MaharaDroid and Portfolio Up are not in active development and do not necessarily work with modern devices. Mahara Mobile allows any user to connect, not just with internal accounts. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1660237/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1716279] Re: Pagination on "My portfolios" doesn't work when profile page is shared publicly
** Changed in: mahara/17.10 Status: Confirmed => In Progress -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1716279 Title: Pagination on "My portfolios" doesn't work when profile page is shared publicly Status in Mahara: In Progress Status in Mahara 16.10 series: Confirmed Status in Mahara 17.04 series: Confirmed Status in Mahara 17.10 series: In Progress Bug description: When your portfolio page and a minimum of 11 of your portfolios are shared publicly, the pagination on the "My portfolios" block on the profile page doesn't take you to the second page, but only gives the message "Reload to log in". The pagination works fine when the user is logged in and navigates through the pagination. To replicate: 1. Create 12 pages and set them as well as your profile page to "Public". 2. Copy the link to your profile page. 3. Log out or open a private browser window and go to the profile page. 4. Click the "2" in the pagination. Expected result: You get to the remaining portfolios. Actual result: The pagination doesn't change the pages and you stay on the first page. Once a fix has been implemented, you'll also need to check the pagination when logged in (with another user) and confirm that it still works. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1716279/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1716279] A patch has been submitted for review
Patch for "master" branch: https://reviews.mahara.org/8026 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1716279 Title: Pagination on "My portfolios" doesn't work when profile page is shared publicly Status in Mahara: In Progress Status in Mahara 16.10 series: Confirmed Status in Mahara 17.04 series: Confirmed Status in Mahara 17.10 series: In Progress Bug description: When your portfolio page and a minimum of 11 of your portfolios are shared publicly, the pagination on the "My portfolios" block on the profile page doesn't take you to the second page, but only gives the message "Reload to log in". The pagination works fine when the user is logged in and navigates through the pagination. To replicate: 1. Create 12 pages and set them as well as your profile page to "Public". 2. Copy the link to your profile page. 3. Log out or open a private browser window and go to the profile page. 4. Click the "2" in the pagination. Expected result: You get to the remaining portfolios. Actual result: The pagination doesn't change the pages and you stay on the first page. Once a fix has been implemented, you'll also need to check the pagination when logged in (with another user) and confirm that it still works. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1716279/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1539322] Re: Do we still need device detection?
** Changed in: mahara Milestone: 17.10.0 => 18.04.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1539322 Title: Do we still need device detection? Status in Mahara: Triaged Bug description: Mahara 15.10 introduced Bootstrap. All themes are now responsive. When I tested the "Deactivate device detection" functionality, I couldn't see much of a difference when using the site. I did notice the content chooser was displayed the start of the words instead of only showing the icon on the "Edit page" screen. I wonder if we can remove the custom device detection. You can enable the user turning off device detection in Admin -> Config site -> User settings -> Users can disable device detection. That then happens on the account settings page. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1539322/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1681573] Re: Allow inline SVG support
** Changed in: mahara Milestone: 17.10.0 => 18.04.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1681573 Title: Allow inline SVG support Status in Mahara: Confirmed Bug description: In bug #1681571 the support for uploading of SVG is going to be implemented. This is a follow-on wishlist item to also allow inline SVG so the SVG properties can be changed directly in Mahara. This can take a couple of different forms: 1. In a text box (anywhere there is TinyMCE): Tick a box / flip a switch to activate inline SVG and then see the SVG properties in the pop-up so people don't have to go to the text box source. 2. If we also allow the manipulation in an image block add the SVG properties there once inline SVG is activated. I would think that the SVG properties manipulation should probably not happen in the file browser itself as you could upload a black SVG and then use it as a white one in one page and a red one in another. If we allow for the changing of the SVG properties in the file browser, we could only save one version rather than use both. In reveal.js (at least via slides.com) I can activate the inline SVG version for images directly on a slide and then go into the source to make changes, but I'm not saving those changes with the file itself, but just in the slide properties so I'm more flexible with the file in other contexts. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1681573/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1681571] Re: Allow upload of SVG to use in portfolio pages
To handle this we will need to recognise the .svg as an 'image' file but will need to handle slightly differently as we won't need to make thumbnails of it as we can just supply it with dimensions to achieve that. So bits that will need to change include (but not limited to) - Code that handles the upload / saving of the file - Code that displays it in filebrowser / aretefactchooser - code that displays it via artefact/file/download.php so we display the file rather than prompt download ** Changed in: mahara Milestone: 17.10.0 => 18.04.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1681571 Title: Allow upload of SVG to use in portfolio pages Status in Mahara: Confirmed Bug description: All modern browsers support SVG and so should we in Mahara. Currently, you can't upload them to an image block because the format is not recognized. Bug #1681573 deals with the support for inline SVG for easy manipulation as a follow-on wishlist item. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1681571/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1700879] Re: Allow the upload of a logo as SVG file
** Changed in: mahara Milestone: 17.10.0 => 18.04.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1700879 Title: Allow the upload of a logo as SVG file Status in Mahara: Confirmed Bug description: In bug #1681579 we allow the use of an SVG file as logo in a Mahara theme. It should also be possible to upload an SVG file as logo through the front-end. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1700879/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1638128] Re: Delete the "resized" dataroot dirs on clear_all_caches()
There is a fix for this as part of Bug 1272122 - see patch https://reviews.mahara.org/#/c/7587/12 ** Changed in: mahara Milestone: 17.10.0 => 18.04.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1638128 Title: Delete the "resized" dataroot dirs on clear_all_caches() Status in Mahara: Confirmed Bug description: We have a form on admin index page to clear caches within Mahara system. It would be nice to be able to add the clearing of file/resized/ and file/profileicons/resized/ from the dataroot as well. This would be useful for testing / debugging purposes when one is chopping and changing databases To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1638128/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1423411] Re: Combine the "secret URL" screen and the "Sharing" screen.
*** This bug is a duplicate of bug 166 *** https://bugs.launchpad.net/bugs/166 This has been achieved as part of Bug 166 ** This bug has been marked a duplicate of bug 166 Keep page editing buttons on all editing screens of a page -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1423411 Title: Combine the "secret URL" screen and the "Sharing" screen. Status in Mahara: Confirmed Bug description: Once we've implemented Bug 1423410, which will "individualize" the "Sharing" screen, we should combine the Secret URL screen and the Sharing screen in some way. The easiest thing would probably be to make it a separate tab, because secret URLs cannot be created in bulk, while the other permissions can be done in bulk. But it would be really nice if we could do it all on one screen. Maybe gray out the Secret URL section if you select some other pages to bulk sync? To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1423411/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1576074] Re: Adopt PSR-2 for our PHP code format
** Changed in: mahara Milestone: 17.10.0 => 18.04.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1576074 Title: Adopt PSR-2 for our PHP code format Status in Mahara: Confirmed Bug description: Currently Mahara has its own idiosyncratic code formatting guidelines: https://wiki.mahara.org/wiki/Developer_Area/Coding_guidelines It would make things easier for new devs, and improve tool support, if we switched to the industry standard PSR-2: http://www.php- fig.org/psr/psr-2/ It would also be good to decide on a Javascript coding standard. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1576074/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1396321] Re: Allow certain registration information to be public
** Changed in: mahara Milestone: 17.10.0 => 18.04.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1396321 Title: Allow certain registration information to be public Status in Mahara: Confirmed Bug description: Mahara instances can decide whether they want to register with the Mahara project or not. Currently, the stats that are collected are only visible to the Mahara core project team as we do not ask site admins permission to make them available more widely to the community like for example Moodle: http://moodle.net/stats/ We should be changing that with the next release and ask permission to make certain information available anonymously to the entire community. We shouldn't make all the information available that we collect, but just the most high level ones like - Geographical location of the registered site - The site name and URL itself like on http://moodle.net/sites/ - Number of registered users - Version of Mahara used (unless we decide it's a security risk) - Number of pages created (could be beneficial to see how active users are on the site; ideally excl. dashboards, profile pages and group homepages) The information that is shared publicly anonymously with others should be highlighted when you review what information is sent when registering the site. When we make that change, I think we should reset the registration checkbox for sites that had it set to give them the chance to review the setting and make a conscious decision about registering as it's kinda like accepting new Terms and Conditions. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1396321/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1691313] Re: Using 'No title' for new page is not needed now that we create the page before displaying config form
** Changed in: mahara Milestone: 17.10.0 => 18.04.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1691313 Title: Using 'No title' for new page is not needed now that we create the page before displaying config form Status in Mahara: Confirmed Bug description: Way back when in Mahara when a user wanted to create a page they needed to fill in details first before saving the page title/metadata. So a $new var was passed about so we knew we were in this state. Also the page was called 'No title' to be shown in browser titlebar. But then things changed and a new page was created/saved on clicking the 'add' button - then the config form shown with 'page title' already populated in form, eg 'Untitled v.2' So we don't need to pass about the $new variable when creating/editing a page nor use the 'No title' string as the page will have a title. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1691313/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1612464] Re: Cleanup of embedded images code
** Changed in: mahara Milestone: 17.10.0 => 18.04.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1612464 Title: Cleanup of embedded images code Status in Mahara: Confirmed Bug description: While working on Bug 1612451 I noticed some brittle code in the embedded images library, that could use a reworking. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1612464/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1517729] Re: Better documentation of the compatible Elasticsearch version
In the 17.10+ versions of Mahara we specify the versions needed in elasticsearch/lib.php /** * The version of elasticsearch this plugin is compatible with. */ const elasticsearch_version = '5.0'; /** * The version of elasticsearch-php this plugin is compatible with. */ const elasticsearchphp_version = '5.0'; ** Changed in: mahara Status: Confirmed => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1517729 Title: Better documentation of the compatible Elasticsearch version Status in Mahara: Fix Committed Bug description: See the discussion at the bottom of Bug 1389446. Currently, Mahara is using Elastica version 2.0 for our Elasticsearch PHP library. The Elastica project uncoupled their version numbers from Elasticsearch's version numbers with the 2.0 release, so Elastica 2.0 was written to support Elasticsearch 1.5. However, there doesn't seem to be anywhere in the Mahara documentation that specifies *which* version of Elasticsearch we support. Even the README.Mahara file in htdocs/lib/elastica doesn't say it! So, we should really document that somewhere. Possibly in Mahara's main README, and/or the Elastica README, maybe even on the elasticsearch plugin's config page. In fact... maybe it would be a good idea if the elasticsearch plugin was able to sniff the elasticsearch version and tell you that it's not a compatible version? Of course, that does rely on the version detection system of Elasticsearch being backwards compatible. On a related note, we should also upgrade our Elastica version. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1517729/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1519989] Re: Refactor duplicate collections access code in index.php & index.json.php
** Changed in: mahara Milestone: 17.10.0 => 18.04.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1519989 Title: Refactor duplicate collections access code in index.php & index.json.php Status in Mahara: Confirmed Bug description: After patch https://reviews.mahara.org/#/c/5695/6 for Bug1514374, we've now got duplicate code it htdocs/collection/index.php and htdocs/collection/index.json.php, for checking whether the user has access to the particular collections they're trying to look at. This kind of duplication stands a high likelihood of falling out of sync if changes are made to the access code in the future, so we should abstract it out into a common access method that gets called by both scripts. The code is not *exactly* the same in both places. index.php intersperses it with code to set the menu headers, and index.json.php sends an error via json_reply on failure, while index.php throws an AccessDeniedException(). So it will require a little bit of thinking to do it. But it's not impossible. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1519989/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1489258] Re: Unnecessary labels on buttons in Plugin administration
Actually the screen reader text contains more info than just the name. The row may say 'Leap' but the button says 'hide import leap' to differentiate this 'Leap' from the 'Leap' in the export section. I feel the extra info is needed so will mark as won't fix ** Changed in: mahara Status: Confirmed => Won't Fix ** Changed in: mahara Milestone: 17.10.0 => None -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1489258 Title: Unnecessary labels on buttons in Plugin administration Status in Mahara: Won't Fix Bug description: In Administration -> Plugin administration, each "Show" and "Hide" button has a hidden label associated with it. This isn't actually necessary and is confusing for screen reader users since it appears that there is plain text in front of each button with the same text as the button. In this case the label should be removed and hidden text saying the same thing should be added to the button. Affects latest master To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1489258/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1394082] A patch has been submitted for review
Patch for "master" branch: https://reviews.mahara.org/8027 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1394082 Title: Can create a URL that takes you to a different page depending on whether you're logged in to MNet or not. Status in Mahara: In Progress Bug description: As reported on the mahara.org forum: https://mahara.org/interaction/forum/topic.php?id=6549 To replicate: 1. Set up a Moodle instance with the Mahara assignment submission plugin and connect it up to your Mahara instance. 2. Create a view with ID 1000. 3. Create another view with ID 1001. 4. Make both these pages accessible to the public. 5. Set up an Mahara assignment in Moodle. 6. Submit the view with ID 1000 to Moodle as an assignment submission. 7. Note the access URL that gets generated, which will contain an MNet access token, i.e. /view/view.php?mt=abcd1234 8. Add the ID of page 1001 to this URL: /view/view.php?id=1001&mt=abcd1234 Expected Result: This URL should either display page 1000 every time, or an "access denied" message Actual Result: If you're logged in to Mahara via MNet, you see page 1000. If you're not, you see page 1001. The cause of this problem, is that /view/view.php completely ignores the "mt=" tag if you're not logged in via MNet. In which case, if an ID is also supplied, it falls back to that. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1394082/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1394082] Re: Can create a URL that takes you to a different page depending on whether you're logged in to MNet or not.
** Changed in: mahara Milestone: 17.10.0 => 18.04.0 ** Changed in: mahara Status: Confirmed => In Progress -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1394082 Title: Can create a URL that takes you to a different page depending on whether you're logged in to MNet or not. Status in Mahara: In Progress Bug description: As reported on the mahara.org forum: https://mahara.org/interaction/forum/topic.php?id=6549 To replicate: 1. Set up a Moodle instance with the Mahara assignment submission plugin and connect it up to your Mahara instance. 2. Create a view with ID 1000. 3. Create another view with ID 1001. 4. Make both these pages accessible to the public. 5. Set up an Mahara assignment in Moodle. 6. Submit the view with ID 1000 to Moodle as an assignment submission. 7. Note the access URL that gets generated, which will contain an MNet access token, i.e. /view/view.php?mt=abcd1234 8. Add the ID of page 1001 to this URL: /view/view.php?id=1001&mt=abcd1234 Expected Result: This URL should either display page 1000 every time, or an "access denied" message Actual Result: If you're logged in to Mahara via MNet, you see page 1000. If you're not, you see page 1001. The cause of this problem, is that /view/view.php completely ignores the "mt=" tag if you're not logged in via MNet. In which case, if an ID is also supplied, it falls back to that. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1394082/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1434316] Re: Why two pieform directories?
** Changed in: mahara Milestone: 17.10.0 => 18.04.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1434316 Title: Why two pieform directories? Status in Mahara: Confirmed Bug description: Currently the basic pieform elements information lives in: htdocs/lib/pieforms/pieform/ but there are also pieform elements that live in htdocs/lib/forms/ Why do we need to have them in two places? I can imagine that there might have been a reason to keep the pieform plugin separate from custom pieform elements but seeing as mahara pieform is really a fork of the original this seperation is not needed within mahara. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1434316/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1381184] Re: need to drop old default email option
** Changed in: mahara Status: Confirmed => In Progress -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1381184 Title: need to drop old default email option Status in Mahara: In Progress Bug description: Now that we use individual default email options for each activity type we need a patch to remove the 'defaultnotificationmethod' from config table. But the problem is we can't add it to the lib/db/upgrade.php as that is run before the upgrade on plugins - nor can we put it in the postinst of a plugin because we don't know which plugins will need to be updated last post 1.9 - eg if we go from 1.9 -> 1.10 or even 1.9 -> 1.15 we will need to know the old defaultmethod. But after the initial jump we will not need to know about it. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1381184/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1381184] Re: need to drop old default email option
Can fix this easily now as we recommend upgrading to 15.04 from older sites before upgrading to 17.10+ -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1381184 Title: need to drop old default email option Status in Mahara: In Progress Bug description: Now that we use individual default email options for each activity type we need a patch to remove the 'defaultnotificationmethod' from config table. But the problem is we can't add it to the lib/db/upgrade.php as that is run before the upgrade on plugins - nor can we put it in the postinst of a plugin because we don't know which plugins will need to be updated last post 1.9 - eg if we go from 1.9 -> 1.10 or even 1.9 -> 1.15 we will need to know the old defaultmethod. But after the initial jump we will not need to know about it. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1381184/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1381184] A patch has been submitted for review
Patch for "master" branch: https://reviews.mahara.org/8028 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1381184 Title: need to drop old default email option Status in Mahara: In Progress Bug description: Now that we use individual default email options for each activity type we need a patch to remove the 'defaultnotificationmethod' from config table. But the problem is we can't add it to the lib/db/upgrade.php as that is run before the upgrade on plugins - nor can we put it in the postinst of a plugin because we don't know which plugins will need to be updated last post 1.9 - eg if we go from 1.9 -> 1.10 or even 1.9 -> 1.15 we will need to know the old defaultmethod. But after the initial jump we will not need to know about it. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1381184/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1262040] Re: Problems with group artefact permissions due to misuse of $USER->can_view_artefact and $USER->can_edit_artefact
This doesn't seem to be the case now - a group member does not see the 'select' tick when trying to add a group image to their personal page. I set up a group with 2 images, one with full permission and one with view only permission for group members. both images could be added by a member to a group page but only the one with full perms could be added to their personal page ** Changed in: mahara Status: Confirmed => Invalid ** Changed in: mahara Milestone: 17.10.0 => None -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1262040 Title: Problems with group artefact permissions due to misuse of $USER->can_view_artefact and $USER->can_edit_artefact Status in Mahara: Invalid Bug description: While discussing the export to ZIP bug ( Bug 1013022 ) I realized that $USER->can_view_artefact() does not do what I thought it did. I thought that it was like can_view_view(), i.e. it was an easy way to tell whether a particular user is allowed to see the contents of a particular artefact. But it does not mean that, as evidenced by the fact that it's not accessed at all on the artefact detail page, view/artefact.php. Instead, this function refers to whether or not the user should be able to see the artefact in their own or a group's Content area. The reason it exists and has this name, is because of the group files permissions system (see http://manual.mahara.org/en/1.8/groups/inside_group.html#index-16 ). This defines three permission levels for a file: "View" lets you see the page in Contents and use it in Group pages, "Edit" lets you change the file's metadata, and "Publish" lets you use the file in your own Portfolio pages. Anyway, I misunderstood it as doing the same thing as can_view_view(), which checks whether a particular user can see a particular Page in display-mode. The similar functionality for artefacts, as seen on view/artefact.php, is to provide an artefact ID & a page ID, and to check whether the artefact is in the page and the user can view the page. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1262040/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1238373] Re: Mahara sites that have been around since before 1.2 have unique indexes where they should have unique keys
Point 3 has been fixed by https://reviews.mahara.org/#/c/3443/ As for point 1 and 2 - we don't support direct upgrade from anything lower than 1.6 (currently) and will soon be 15.04 So anyone needing to upgrade from before 1.2 will need to specialist help and can read this bug report for advice. So will not fix as part of core code ** Changed in: mahara Status: Confirmed => Won't Fix ** Changed in: mahara/17.04 Status: Confirmed => Won't Fix ** Changed in: mahara Milestone: 17.10.0 => None ** Changed in: mahara/17.04 Milestone: 17.10.0 => None -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1238373 Title: Mahara sites that have been around since before 1.2 have unique indexes where they should have unique keys Status in Mahara: Won't Fix Status in Mahara 17.04 series: Won't Fix Bug description: See https://bugs.launchpad.net/mahara/+bug/1238363 In the run-up to 1.2.0, we changed the XMLDB library so that it created proper unique keys. Prior to that, whenever you told it to create a unique key, it actually created a unique index. Normally this doesn't cause any noticeable difference in behavior. But in bug 1238363 it caused upgrade to crash, because the drop_key() method didn't find the key that was expected. Instead, there was an index. Potential fixes for this may include: 1. Investigate the difference between a unique key and unique index in MySQL and Postgres to make sure that they really are 100% identical in behavior 2. A one-off upgrade in lib/db/upgrade.php that finds all the "legacy" indexes and drops them and recreates them as keys. However, since sites that have been around since 1.2 tend to be rather large, this might be a slow process. 3. Make drop_key() more robust, so that if there is no key by that name on that table, it just looks for an index by that name on that table. This has the potential to be an unexpected side effect and thus cause problems of its own, but I think it'd be pretty rare for someone to create a key and an index with the same name, on the same table. It could also print a debug() message when silently doing this substitution. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1238373/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 784341] Re: Fix xmldb postgres generator to preserve unique keys during alter table
** Changed in: mahara Milestone: 17.10.0 => None ** Changed in: mahara Status: Confirmed => Won't Fix -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/784341 Title: Fix xmldb postgres generator to preserve unique keys during alter table Status in Mahara: Won't Fix Bug description: See bug #784322. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/784341/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1037365] Re: some third party libraries do not respect the directorypermissions config setting
** Changed in: mahara Milestone: 17.10.0 => 18.04.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1037365 Title: some third party libraries do not respect the directorypermissions config setting Status in Mahara: Confirmed Bug description: one example is htmlpurifier, from a git grep mkdir, i see that pear, dwoo, adobdb, and flowplayer may also be culprits Also, the internal examples - extract function in artefact/file.lib.php - copyr function in lib/file.php - there is one instance in lib/db/upgrade.php To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1037365/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1690709] Re: Look at consolidating tests related to group membership and settings
** Changed in: mahara Importance: Undecided => Medium -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1690709 Title: Look at consolidating tests related to group membership and settings Status in Mahara: Fix Committed Bug description: The following tests all have functionality related to creating/deleting groups, adding members and checking sort order: create_group.feature delete_groups.feature displaying_groups_on_page.feature group.feature group_view_block.feature edit_group_membership.feature edit_group.feature group_members_sortedby.feature They should be looked at to see if we're testing the same things more than once; to see if we can reduce the number of tests looking at similar functions; also to make sure the testing is covering the features in a meaningful way. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1690709/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1356638] Re: Can not see the image in the static page "Home" for logged-in users
** Changed in: mahara Importance: Medium => High ** Changed in: mahara Status: Confirmed => In Progress ** Changed in: mahara Assignee: (unassigned) => Robert Lyon (robertl-9) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1356638 Title: Can not see the image in the static page "Home" for logged-in users Status in Mahara: In Progress Bug description: Version: master(1.10), 1.9, 1.8 Platform: any Browser: any Steps to reproduce the issue 1. Login as a site admin, add a site image file out of the 'public' folder 2. Add the image into the static page Home (Dashboard) 3. Logout and login as a normal user Expected result: the image should display in my dashboard Actual result: the image is not accessible To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1356638/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1717822] Re: Spelling mistake in code for denying user login to expired institution
** No longer affects: mahara/18.04 ** Changed in: mahara/17.10 Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1717822 Title: Spelling mistake in code for denying user login to expired institution Status in Mahara: Fix Committed Status in Mahara 15.04 series: New Status in Mahara 16.04 series: New Status in Mahara 16.10 series: New Status in Mahara 17.04 series: New Status in Mahara 17.10 series: Fix Committed Bug description: To test: 1) Set up a new institution and set the expiry of institution in the past 2) Add 1 user to the institution - making sure the user is using the auth method 'internal' for that institution 3) Logout and login as that user You should see error: [WAR] a0 (auth/lib.php:1716) Undefined variable: authinstane To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1717822/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1717822] A change has been merged
Reviewed: https://reviews.mahara.org/8021 Committed: https://git.mahara.org/mahara/mahara/commit/d4c3c66b7cf3ffabfcb9d3320ae5ee91e94b3710 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:master commit d4c3c66b7cf3ffabfcb9d3320ae5ee91e94b3710 Author: Robert Lyon Date: Mon Sep 18 11:15:47 2017 +1200 Bug 1717822: Fixing spelling mistake in expired institution code and fixing some issues with behat Change-Id: Id08ec6a7c8ed62e42235e5eaa28012165c2fa4f7 Signed-off-by: Robert Lyon -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1717822 Title: Spelling mistake in code for denying user login to expired institution Status in Mahara: Fix Committed Status in Mahara 15.04 series: New Status in Mahara 16.04 series: New Status in Mahara 16.10 series: New Status in Mahara 17.04 series: New Status in Mahara 17.10 series: Fix Committed Bug description: To test: 1) Set up a new institution and set the expiry of institution in the past 2) Add 1 user to the institution - making sure the user is using the auth method 'internal' for that institution 3) Logout and login as that user You should see error: [WAR] a0 (auth/lib.php:1716) Undefined variable: authinstane To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1717822/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1356638] A patch has been submitted for review
Patch for "master" branch: https://reviews.mahara.org/8029 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1356638 Title: Can not see the image in the static page "Home" for logged-in users Status in Mahara: In Progress Bug description: Version: master(1.10), 1.9, 1.8 Platform: any Browser: any Steps to reproduce the issue 1. Login as a site admin, add a site image file out of the 'public' folder 2. Add the image into the static page Home (Dashboard) 3. Logout and login as a normal user Expected result: the image should display in my dashboard Actual result: the image is not accessible To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1356638/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
