[Mahara-contributors] [Bug 1719736] Re: Webservices - manage access tokens - broken style

2017-09-27 Thread Robert Lyon 
** Changed in: mahara
Milestone: None => 17.10.0

** Changed in: mahara
   Importance: Undecided => Medium

** Changed in: mahara
   Status: New => In Progress

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1719736

Title:
  Webservices -  manage access tokens - broken style

Status in Mahara:
  In Progress

Bug description:
  In Web services -> configuration -> Manage access service tokens

  the style gets broken when the list is populated. See image.

  Steps to reproduce:

  In Web services -> configuration

  - Go to Manage service groups
  - type mahara_group_external and press Add
  - Edit the service just added
  - Enable any function
  - Save & Back

  - Go to Manage service access tokens
  - add username
  - press Generate token
  - set Service to "mahara_group_external"
  - Save & Back

  Result: the lines separating the rows of the table in Manage service
  access tokens are too long and are displayed outside the main content

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1719736/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1719736] A patch has been submitted for review

2017-09-27 Thread Mahara Bot 
Patch for "master" branch: https://reviews.mahara.org/8060

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1719736

Title:
  Webservices -  manage access tokens - broken style

Status in Mahara:
  In Progress

Bug description:
  In Web services -> configuration -> Manage access service tokens

  the style gets broken when the list is populated. See image.

  Steps to reproduce:

  In Web services -> configuration

  - Go to Manage service groups
  - type mahara_group_external and press Add
  - Edit the service just added
  - Enable any function
  - Save & Back

  - Go to Manage service access tokens
  - add username
  - press Generate token
  - set Service to "mahara_group_external"
  - Save & Back

  Result: the lines separating the rows of the table in Manage service
  access tokens are too long and are displayed outside the main content

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1719736/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1356638] A change has been merged

2017-09-27 Thread Mahara Bot 
Reviewed:  https://reviews.mahara.org/8029
Committed: 
https://git.mahara.org/mahara/mahara/commit/29556c4d29bc866de04fcb159a49f060d404515a
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master

commit 29556c4d29bc866de04fcb159a49f060d404515a
Author: Robert Lyon 
Date:   Tue Sep 19 14:15:17 2017 +1200

Bug 1356638: Allow images to be embedded in static pages

So that they have artefact_file_embedded rows associated with them and
can display to non-admins

behatnotneeded

Change-Id: I477a910637ffc53e0e5be9ed44d0188f49b61bad
Signed-off-by: Robert Lyon 

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1356638

Title:
  Can not see the image in the static page "Home" for logged-in users

Status in Mahara:
  Fix Committed

Bug description:
  Version: master(1.10), 1.9, 1.8
  Platform: any
  Browser: any

  Steps to reproduce the issue

  1. Login as a site admin, add a site image file out of the 'public' folder
  2. Add the image into the static page Home (Dashboard)
  3. Logout and login as a normal user

  Expected result: the image should display in my dashboard
  Actual result: the image is not accessible

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1356638/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1356638] Re: Can not see the image in the static page "Home" for logged-in users

2017-09-27 Thread Robert Lyon 
** Changed in: mahara
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1356638

Title:
  Can not see the image in the static page "Home" for logged-in users

Status in Mahara:
  Fix Committed

Bug description:
  Version: master(1.10), 1.9, 1.8
  Platform: any
  Browser: any

  Steps to reproduce the issue

  1. Login as a site admin, add a site image file out of the 'public' folder
  2. Add the image into the static page Home (Dashboard)
  3. Logout and login as a normal user

  Expected result: the image should display in my dashboard
  Actual result: the image is not accessible

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1356638/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1444182] Re: Leaving feedback on own page generates notification to self

2017-09-27 Thread Robert Lyon 
** Changed in: mahara
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1444182

Title:
  Leaving feedback on own page generates notification to self

Status in Mahara:
  Fix Committed

Bug description:
  We don't need to receive a notification when we comment on our own
  page as we already know we have done that.

  To test:

  1) Install fresh mahara
  2) Add a user: UserA
  3) Login as UserA and create a page
  4) Leave feedback on page (doesn't matter if first feeback or replying to 
other's feedback)
  5) Check inbox - there is a message both 'to' and 'from' UserA

  Will mark this as a low bug as it's more of an annoyance than the
  system being broken.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1444182/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1444182] A change has been merged

2017-09-27 Thread Mahara Bot 
Reviewed:  https://reviews.mahara.org/8036
Committed: 
https://git.mahara.org/mahara/mahara/commit/e9075aa3a07d9d785e1e3f56cebd402e045186b9
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master

commit e9075aa3a07d9d785e1e3f56cebd402e045186b9
Author: Robert Lyon 
Date:   Wed Sep 20 09:54:42 2017 +1200

Bug 1444182: Stop sending self notifications

Stop sending comment notifications to page owner when
page owner is the commentor

behatnotneeded

Change-Id: Ibfe80b7bb57855592e7d04cc653c649b7d08a148
Signed-off-by: Robert Lyon 

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1444182

Title:
  Leaving feedback on own page generates notification to self

Status in Mahara:
  Fix Committed

Bug description:
  We don't need to receive a notification when we comment on our own
  page as we already know we have done that.

  To test:

  1) Install fresh mahara
  2) Add a user: UserA
  3) Login as UserA and create a page
  4) Leave feedback on page (doesn't matter if first feeback or replying to 
other's feedback)
  5) Check inbox - there is a message both 'to' and 'from' UserA

  Will mark this as a low bug as it's more of an annoyance than the
  system being broken.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1444182/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1356638] Re: Can not see the image in the static page "Home" for logged-in users

2017-09-27 Thread Niranjan 
URL :https://bugs.launchpad.net/mahara/+bug/1356638

Bug description:Can not see the image in the static page ‘Home’ for
logged-in users.

Environment to be tested: Master
Browser to be tested: Chrome, Firefox, Safari, IE  (Latest version) 

Precondition: 
1. A user ‘Admin’ with ‘Site admin’ privileges should be set up.
2. The institution 'Institution One' should be set up.
3. A normal user ‘User one’ and an institution admin ‘Inst admin’ should be set 
up.

Steps to reproduce:

1. Login as a ‘Admin’.
2. Navigate to Administration menu > Configure site > Files.
3. Click the ‘Browse’ button and upload an image. Do not add the image to the 
folder ‘public’.
4. Navigate to Administration menu > Configure site > Static pages.
5. Select ‘Home (Dashboard)’ from the ‘Page name’ drop down.
6. Click the ‘Insert/edit image’ icon from the menu bar under ‘Page text’.
7. Click the ‘Image’ panel.
8. Select the ‘Site files’ tab.
9. Select the image you uploaded in step 3.
10. Click the ‘Save changes’ button.
11. Navigate to the homepage.

Expected result: You should see the image as part of the text, and the
text with the image shall not overlap the side blocks or the blocks
below the text.

12. Log out of ‘Admin’ user.
13. Login as ‘User one’.

Expected result: You should see the image as part of the text, and the
text with the image shall not overlap the side blocks or the blocks
below the text.

14. Login as ‘Inst admin’.
15. Navigate to Administration menu > Institutions > Files
16. Click the ‘Browse’ button and upload an image. Make sure the image file is 
different from step 3.
17. Navigate to Administration menu > Institutions > Static pages.
18. Switch ‘Use site default’ to ‘No’.
19. Click the ‘Insert/edit image’ icon from the menu7 bar under ‘Page text’.
21. Click the ‘Image’ panel.
22. Select the ‘Institution files’ tab.
23. Select one of the image and click the ‘Submit’ button.
24. Click the ‘Save changes’ button.
25. Navigate to the homepage.

Expected result: You should see the image as part of the text, and the
text with the image shall not overlap the side blocks or the blocks
below the text.

24. Log out as ‘Inst admin’ user.
25. Log in as ‘User one’.
 
Expected result: You should see the image as part of the text, and the text 
with the image shall not overlap the side blocks or the blocks below the text.

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1356638

Title:
  Can not see the image in the static page "Home" for logged-in users

Status in Mahara:
  In Progress

Bug description:
  Version: master(1.10), 1.9, 1.8
  Platform: any
  Browser: any

  Steps to reproduce the issue

  1. Login as a site admin, add a site image file out of the 'public' folder
  2. Add the image into the static page Home (Dashboard)
  3. Logout and login as a normal user

  Expected result: the image should display in my dashboard
  Actual result: the image is not accessible

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1356638/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1513276] A change has been merged

2017-09-27 Thread Mahara Bot 
Reviewed:  https://reviews.mahara.org/8037
Committed: 
https://git.mahara.org/mahara/mahara/commit/943ce498fb9884be0f66343a35e8a8924d5d4fb5
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master

commit 943ce498fb9884be0f66343a35e8a8924d5d4fb5
Author: Robert Lyon 
Date:   Wed Sep 20 11:38:16 2017 +1200

Bug 1513276: Fixing iframe source mistake

And adding info to help developers

behatnotneeded

Change-Id: Idebbf277cd37f4406874bddb66b4ffef71088750
Signed-off-by: Robert Lyon 

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1513276

Title:
  Consolidate the iframe sources code

Status in Mahara:
  Fix Committed

Bug description:
  Currently we do a bunch of different things to add allowed iframe
  sources code to the system when we install/upgrade a site

  We need to make it one way only

  Notes:
  lib/upgrade.php, core_postinst(), has a hard-coded list of allowed iframe 
sources
  if you add the youtube-no-iframes one there, can you also move the prezi one 
there, and take it out from blocktype/externalvideo::postinst() ?

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1513276/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1513276] Re: Consolidate the iframe sources code

2017-09-27 Thread Robert Lyon 
** Changed in: mahara
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1513276

Title:
  Consolidate the iframe sources code

Status in Mahara:
  Fix Committed

Bug description:
  Currently we do a bunch of different things to add allowed iframe
  sources code to the system when we install/upgrade a site

  We need to make it one way only

  Notes:
  lib/upgrade.php, core_postinst(), has a hard-coded list of allowed iframe 
sources
  if you add the youtube-no-iframes one there, can you also move the prezi one 
there, and take it out from blocktype/externalvideo::postinst() ?

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1513276/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1703608] Re: Institution addUserAsMember lang logic is flawed

2017-09-27 Thread Robert Lyon 
** Changed in: mahara
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1703608

Title:
  Institution addUserAsMember lang logic is flawed

Status in Mahara:
  Fix Committed

Bug description:
  The logic in charge of selecting the lang for the message does not work as 
expected.
  The condition:

  if ($lang = get_account_preference($user->id, 'lang')) {
  // The user has a preset lang preference so we will use this
  }
  else if ($this->lang != 'default') {
  // The user hasn't been added yet, so we have to manually use 
this institution's lang
  $lang = $this->lang;
  }
  else {
  $lang = get_user_language($user->id);
  }

  gets always sent in english if the site default lang is french.

  To reproduce it:
  You set another language than english as default language. You an institution 
with default lang and then you add a user (his lang preference is not setting) 
into this institution. He is going to receive an english message in that case 
and also in the case that the institution language is explicitly set to the 
additional lang.

  That is corrected with the following:

  $lang = get_account_preference($user->id, 'lang');

  if ($lang == 'default') {
  // The user has not a preset lang preference so we will use the 
institution if it has one.
  $institution_lang = get_record_sql(
"SELECT value FROM {institution_config} ic where 
ic.institution= ? and ic.field = 'lang' ",
[$this->name],
IGNORE_MULTIPLE
  );
  $this->lang = $institution_lang->value? $institution_lang->value: 
'default';
  if ($this->lang != 'default') {
  // The user hasn't been added yet, so we have to manually use 
this institution's lang
  $lang = $this->lang;
  }
  else {
  $lang = get_config('lang')? get_config('lang'): '';
  }
  }

  We have also opened a PR in github:
  https://github.com/MaharaProject/mahara/pull/7

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1703608/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1705162] Re: Send institution messages for new users in the correct language

2017-09-27 Thread Robert Lyon 
** Changed in: mahara
   Status: Confirmed => Fix Committed

** Changed in: mahara
Milestone: None => 17.10.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1705162

Title:
  Send institution messages for new users in the correct language

Status in Mahara:
  Fix Committed

Bug description:
  1. When a site admin registers a new user, the account information
  message, i.e. the one that contains the username and password, is sent
  in the language of the admin but should be sent in the institution's
  language (as the user doesn't yet exist and therefore doesn't yet have
  a language preference).

  2. When a site admin or institution admin invites a user to another
  institution, that message should be sent in the language of the user
  that is being invited rather than the admin's language or the site
  language.

  If the user hasn't set a language specifically, the new institution's
  language should be used (See bug 1703608).

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1705162/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1705162] A change has been merged

2017-09-27 Thread Mahara Bot 
Reviewed:  https://reviews.mahara.org/7881
Committed: 
https://git.mahara.org/mahara/mahara/commit/bf501442d37ccb862b7868426b2f15a8d81262b7
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master

commit bf501442d37ccb862b7868426b2f15a8d81262b7
Author: Nelson Moller 
Date:   Wed Jul 19 12:59:40 2017 -0400

Bug #1705162 Send institution invitations in correct language.

A new method is added to treat the institution lang when an
invitation is sent to the user.

behatnotneeded

Change-Id: I0da8d8341f0dc15f13db9f80dc6f560ca924df3c

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1705162

Title:
  Send institution messages for new users in the correct language

Status in Mahara:
  Fix Committed

Bug description:
  1. When a site admin registers a new user, the account information
  message, i.e. the one that contains the username and password, is sent
  in the language of the admin but should be sent in the institution's
  language (as the user doesn't yet exist and therefore doesn't yet have
  a language preference).

  2. When a site admin or institution admin invites a user to another
  institution, that message should be sent in the language of the user
  that is being invited rather than the admin's language or the site
  language.

  If the user hasn't set a language specifically, the new institution's
  language should be used (See bug 1703608).

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1705162/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1703608] A change has been merged

2017-09-27 Thread Mahara Bot 
Reviewed:  https://reviews.mahara.org/7877
Committed: 
https://git.mahara.org/mahara/mahara/commit/4078222d49fca56c359f1640a608265380f5872a
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master

commit 4078222d49fca56c359f1640a608265380f5872a
Author: Nelson Moller 
Date:   Mon Jul 17 15:12:05 2017 +1200

Bug 1703608: Selecting the lang for inst membership confirmation
messages

Choosing the correct language for the confirmation message sent when
a user is added to an institution that has a different language than
the site default.

behatnotneeded

Change-Id: I832a18777654dc82d506e3d3a1238a74c6a6bdd7

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1703608

Title:
  Institution addUserAsMember lang logic is flawed

Status in Mahara:
  Fix Committed

Bug description:
  The logic in charge of selecting the lang for the message does not work as 
expected.
  The condition:

  if ($lang = get_account_preference($user->id, 'lang')) {
  // The user has a preset lang preference so we will use this
  }
  else if ($this->lang != 'default') {
  // The user hasn't been added yet, so we have to manually use 
this institution's lang
  $lang = $this->lang;
  }
  else {
  $lang = get_user_language($user->id);
  }

  gets always sent in english if the site default lang is french.

  To reproduce it:
  You set another language than english as default language. You an institution 
with default lang and then you add a user (his lang preference is not setting) 
into this institution. He is going to receive an english message in that case 
and also in the case that the institution language is explicitly set to the 
additional lang.

  That is corrected with the following:

  $lang = get_account_preference($user->id, 'lang');

  if ($lang == 'default') {
  // The user has not a preset lang preference so we will use the 
institution if it has one.
  $institution_lang = get_record_sql(
"SELECT value FROM {institution_config} ic where 
ic.institution= ? and ic.field = 'lang' ",
[$this->name],
IGNORE_MULTIPLE
  );
  $this->lang = $institution_lang->value? $institution_lang->value: 
'default';
  if ($this->lang != 'default') {
  // The user hasn't been added yet, so we have to manually use 
this institution's lang
  $lang = $this->lang;
  }
  else {
  $lang = get_config('lang')? get_config('lang'): '';
  }
  }

  We have also opened a PR in github:
  https://github.com/MaharaProject/mahara/pull/7

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1703608/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1719987] [NEW] Blocked account after entering the wrong password

2017-09-27 Thread Dominika Czyszczoń 
Public bug reported:


After entering five incorrect passwords, the account is reportedly blocked for 
five minutes.
In fact, after five minutes, the account is still blocked.


I found two solutions

1.Change variable MAXLOGINTRIES; from 5 to (for example) 10 in 
htdocs/auth/user.php
define('MAXLOGINTRIES', 10);

2.Change variable LOGINTRIES in database; from 5 to 0.

But apparently it should not work this way.
Can I change or add something in user.php or somewhere else?

** Affects: mahara
 Importance: Undecided
 Status: New


** Tags: blocked logintries passwords

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1719987

Title:
   Blocked account after entering the wrong password

Status in Mahara:
  New

Bug description:
  
  After entering five incorrect passwords, the account is reportedly blocked 
for five minutes.
  In fact, after five minutes, the account is still blocked.

  
  I found two solutions

  1.Change variable MAXLOGINTRIES; from 5 to (for example) 10 in 
htdocs/auth/user.php
  define('MAXLOGINTRIES', 10);

  2.Change variable LOGINTRIES in database; from 5 to 0.

  But apparently it should not work this way.
  Can I change or add something in user.php or somewhere else?

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1719987/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1719824] A patch has been submitted for review

2017-09-27 Thread Mahara Bot 
Patch for "master" branch: https://reviews.mahara.org/8058

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1719824

Title:
  Minor lang string fixes for Mahara 17.10

Status in Mahara:
  In Progress

Bug description:
  Go through the new strings for Mahara 17.10 and fix them up where
  needed.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1719824/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1719824] [NEW] Minor lang string fixes for Mahara 17.10

2017-09-27 Thread Kristina Hoeppner 
Public bug reported:

Go through the new strings for Mahara 17.10 and fix them up where
needed.

** Affects: mahara
 Importance: High
 Assignee: Kristina Hoeppner (kris-hoeppner)
 Status: In Progress

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1719824

Title:
  Minor lang string fixes for Mahara 17.10

Status in Mahara:
  In Progress

Bug description:
  Go through the new strings for Mahara 17.10 and fix them up where
  needed.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1719824/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp