[Mahara-contributors] [Bug 1724968] Re: SmartEvidence matrix headers jump when collapsed

2017-10-19 Thread Kristina Hoeppner
** Attachment added: "SE_collapsed_not_collapsed.png"
   
https://bugs.launchpad.net/mahara/+bug/1724968/+attachment/4976792/+files/SE_collapsed_not_collapsed.png

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1724968

Title:
  SmartEvidence matrix headers jump when collapsed

Status in Mahara:
  Confirmed

Bug description:
  When you have pages in a SmartEvicende collection (any framework will
  do) and collapse the headers, the pages jump to the left. That should
  not happen and they should stay put.

  See the attached screenshot to illustrate the issue.

  How to replicate:

  1. Create 5 pages.
  2. Create a SmartEvidence collection and choose any framework adding the 5 
pages to the collection.
  3. View the SmartEvidence matrix page and collapse the / one of the headers 
(depending on the framework you selected)

  Expected result: Page title stay where they were in uncollapsed state.
  Actual result: The page titles jump to the left and then back when you 
uncollapse the standard header.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1724968/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1724968] [NEW] SmartEvidence matrix headers jump when collapsed

2017-10-19 Thread Kristina Hoeppner
Public bug reported:

When you have pages in a SmartEvicende collection (any framework will
do) and collapse the headers, the pages jump to the left. That should
not happen and they should stay put.

See the attached screenshot to illustrate the issue.

How to replicate:

1. Create 5 pages.
2. Create a SmartEvidence collection and choose any framework adding the 5 
pages to the collection.
3. View the SmartEvidence matrix page and collapse the / one of the headers 
(depending on the framework you selected)

Expected result: Page title stay where they were in uncollapsed state.
Actual result: The page titles jump to the left and then back when you 
uncollapse the standard header.

** Affects: mahara
 Importance: Medium
 Status: Confirmed


** Tags: front-end smartevidence

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1724968

Title:
  SmartEvidence matrix headers jump when collapsed

Status in Mahara:
  Confirmed

Bug description:
  When you have pages in a SmartEvicende collection (any framework will
  do) and collapse the headers, the pages jump to the left. That should
  not happen and they should stay put.

  See the attached screenshot to illustrate the issue.

  How to replicate:

  1. Create 5 pages.
  2. Create a SmartEvidence collection and choose any framework adding the 5 
pages to the collection.
  3. View the SmartEvidence matrix page and collapse the / one of the headers 
(depending on the framework you selected)

  Expected result: Page title stay where they were in uncollapsed state.
  Actual result: The page titles jump to the left and then back when you 
uncollapse the standard header.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1724968/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1724950] [NEW] Broken link checker

2017-10-19 Thread Kristina Hoeppner
*** This bug is a security vulnerability ***

Public security bug reported:

Implement a broken link checker to prevent people going to web sites
that may be up for grabs and thus exposing them to phishing, serving
malware, impersonation.

Thanks to Vineet Kumar for reporting this.

I think it concerns primarily links in the editor (TinyMCE and plain
text) as well as any field where you can enter a URL. External media
should be fairly safe as domains need to be whitelisted in the "Allowed
iframes". So having a check for them rather than when a block is on a
page might suffice.

Before implementing a solution, the following should be discussed:
- What do current link checkers offer?
- Unlink automatically or require admin intervention? If admin intervention, 
will there be a weekly / daily email?
- If admin intervention, most links will be in user created content though to 
which admin doesn't have direct access.
- Should links be crossed out and unlinked automatically? That would also 
resolve the issue with posting direct links rather than linking text.

** Affects: mahara
 Importance: Wishlist
 Status: Confirmed

** Description changed:

  Implement a broken link checker to prevent people going to web sites
  that may be up for grabs and thus exposing them to phishing, serving
  malware, impersonation.
  
  Thanks to Vineet Kumar for reporting this.
  
  I think it concerns primarily links in the editor (TinyMCE and plain
  text) as well as any field where you can enter a URL. External media
  should be fairly safe as domains need to be whitelisted in the "Allowed
  iframes". So having a check for them rather than when a block is on a
  page might suffice.
+ 
+ Before implementing a solution, the following should be discussed:
+ - What do current link checkers offer?
+ - Unlink automatically or require admin intervention? If admin intervention, 
will there be a weekly / daily email?
+ - If admin intervention, most links will be in user created content though to 
which admin doesn't have direct access.
+ - Should links be crossed out and unlinked automatically? That would also 
resolve the issue with posting direct links rather than linking text.

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1724950

Title:
  Broken link checker

Status in Mahara:
  Confirmed

Bug description:
  Implement a broken link checker to prevent people going to web sites
  that may be up for grabs and thus exposing them to phishing, serving
  malware, impersonation.

  Thanks to Vineet Kumar for reporting this.

  I think it concerns primarily links in the editor (TinyMCE and plain
  text) as well as any field where you can enter a URL. External media
  should be fairly safe as domains need to be whitelisted in the
  "Allowed iframes". So having a check for them rather than when a block
  is on a page might suffice.

  Before implementing a solution, the following should be discussed:
  - What do current link checkers offer?
  - Unlink automatically or require admin intervention? If admin intervention, 
will there be a weekly / daily email?
  - If admin intervention, most links will be in user created content though to 
which admin doesn't have direct access.
  - Should links be crossed out and unlinked automatically? That would also 
resolve the issue with posting direct links rather than linking text.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1724950/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1724846] [NEW] Add userchangegrouprole event trigger

2017-10-19 Thread Stacey Walker
Public bug reported:

We have a client who has a requirement to trigger additional
functionality when a users role within a group changes.

The event trigger userchangegrouprole should be added to the system.

** Affects: mahara
 Importance: Wishlist
 Assignee: Stacey Walker (stacey)
 Status: New

** Changed in: mahara
 Assignee: (unassigned) => Stacey Walker (stacey)

** Changed in: mahara
   Importance: Undecided => Wishlist

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1724846

Title:
  Add userchangegrouprole event trigger

Status in Mahara:
  New

Bug description:
  We have a client who has a requirement to trigger additional
  functionality when a users role within a group changes.

  The event trigger userchangegrouprole should be added to the system.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1724846/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1724797] [NEW] Add all assessment statuses to the SmartEvidence matrix

2017-10-19 Thread Kristina Hoeppner
Public bug reported:

Instead of only having the number of "Standard completed" items
available in the SmartEvidence map, we should be able to show all
statuses if wanted.

For that purpose, a configuration screen is available for each framework
in Extensions -> SmartEvidence in which the statuses can be selected.
The "Standard completed" item is always available.

Sponsored by SWITCHportfolio

** Affects: mahara
 Importance: Wishlist
 Assignee: Cecilia Vela Gurovic (ceciliavg)
 Status: In Progress


** Tags: smartevidence

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1724797

Title:
  Add all assessment statuses to the SmartEvidence matrix

Status in Mahara:
  In Progress

Bug description:
  Instead of only having the number of "Standard completed" items
  available in the SmartEvidence map, we should be able to show all
  statuses if wanted.

  For that purpose, a configuration screen is available for each
  framework in Extensions -> SmartEvidence in which the statuses can be
  selected. The "Standard completed" item is always available.

  Sponsored by SWITCHportfolio

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1724797/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1724797] Re: Add all assessment statuses to the SmartEvidence matrix

2017-10-19 Thread Kristina Hoeppner
https://reviews.mahara.org/#/c/8152/

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1724797

Title:
  Add all assessment statuses to the SmartEvidence matrix

Status in Mahara:
  In Progress

Bug description:
  Instead of only having the number of "Standard completed" items
  available in the SmartEvidence map, we should be able to show all
  statuses if wanted.

  For that purpose, a configuration screen is available for each
  framework in Extensions -> SmartEvidence in which the statuses can be
  selected. The "Standard completed" item is always available.

  Sponsored by SWITCHportfolio

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1724797/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1724769] [NEW] Cancel butt on "Edit access" doesn't do anything

2017-10-19 Thread Kristina Hoeppner
Public bug reported:

When you are on "Edit access" for a page coming from "Shared by me" and
click the "Cancel" button, you are not returned to "Shared by me" but
stay on the page.

** Affects: mahara
 Importance: Medium
 Assignee: Cecilia Vela Gurovic (ceciliavg)
 Status: Confirmed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1724769

Title:
  Cancel butt on "Edit access" doesn't do anything

Status in Mahara:
  Confirmed

Bug description:
  When you are on "Edit access" for a page coming from "Shared by me"
  and click the "Cancel" button, you are not returned to "Shared by me"
  but stay on the page.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1724769/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1717861] Re: Redirect to incorrect port when sslproxy is on and wwwroot is set

2017-10-19 Thread Kristina Hoeppner
Hi Ghada,

It's not backported as it is not high priority or a security issue. You
can backport it yourself though.

Cheers
Kristina

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1717861

Title:
  Redirect to incorrect port when sslproxy is on and wwwroot is set

Status in Mahara:
  Fix Committed
Status in Mahara 17.10 series:
  Fix Committed
Status in Mahara 18.04 series:
  Fix Committed

Bug description:
  When you have your mahara behind SSL proxy and have sslproxy enabled,
  it redirects to incorrect port when you try to access pages which
  require login.

  When you get your mahara behind load balancer and nginx proxy on port
  81 you get redirected to https://mahara.com:81/user/admin?login when
  try to access https://mahara.com/user/admin as not logged in user.

  Looks like function get_full_script_path tries to get a port even if
  $CFG->wwwroot is set.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1717861/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1715288] Re: Failed to Import Custom Layout Porfolio

2017-10-19 Thread Bambang Hidayanto
Dear Cecilia,

Thank you for your respond. I already apply and test the patch and it solves 
the problem for now. 
It's just like you said, the bug comes from an unknown view id because the user 
didn't created it yet. It surprises me that this bug wasn't show up in older 
version.

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1715288

Title:
  Failed to Import Custom Layout Porfolio

Status in Mahara:
  Incomplete

Bug description:
  Hello,

  I'm using Mahara 16.10 in my Centos server using PHP 5.6.30. I
  encountered a bug while I'm importing Portfolio which I created using
  custom layout (6 rows 1 column) and I also attach some files inside
  the portfolio. I suspect the error occurred because of log below :

  [WAR] ff (lib/errors.php:859) Failed to get a recordset: mysqli error: [1452: 
Cannot add or update a child row: a foreign key constraint fails 
("mahoodle"."view_rows_columns", CONSTRAINT "viewrowscolu_vie_fk" FOREIGN KEY 
("view") REFERENCES "view" ("id"))] in EXECUTE("INSERT INTO "view_rows_columns" 
("row", "columns") VALUES (1, 3)"), referer: 
http://elearning.telkomuniversity.ac.id/mahara/import/index.php
  [Wed Sep 06 10:14:36 2017] [error] [client 10.40.1.46] [WAR] ff 
(lib/errors.php:859) Command was: INSERT INTO "view_rows_columns" ("row", 
"columns") VALUES (?, ?) and values was (row:1,columns:3), referer: 
http://elearning.telkomuniversity.ac.id/mahara/import/index.php

  This isn't happening in my older version mahara (15.10).

  Thank you.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1715288/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1724724] Re: Clear cache inside the upgrade process

2017-10-19 Thread Dmitrii Metelkin
** Changed in: mahara
   Status: New => In Progress

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1724724

Title:
  Clear cache inside the upgrade process

Status in Mahara:
  In Progress

Bug description:
  Mahara should clear cache every time we upgrade.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1724724/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1724724] A patch has been submitted for review

2017-10-19 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/8164

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1724724

Title:
  Clear cache inside the upgrade process

Status in Mahara:
  In Progress

Bug description:
  Mahara should clear cache every time we upgrade.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1724724/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1723286] A patch has been submitted for review

2017-10-19 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/8163

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1723286

Title:
  Rerunning unit tests fails with DB error

Status in Mahara:
  In Progress

Bug description:
  On master.

  When you rerun unit tests they fail with:

  [DBG] 9d (lib/dml.php:157) postgres8 error: [-1: ERROR:  cannot drop 
constraint tst_fram_id_pk on table tst_framework because other objects depend 
on it
  [DBG] 9d (lib/dml.php:157) DETAIL:  constraint tst_coll_fra_fk on table 
tst_collection depends on index tst_fram_id_pk
  [DBG] 9d (lib/dml.php:157) HINT:  Use DROP ... CASCADE to drop the dependent 
objects too.] in EXECUTE("ALTER TABLE tst_framework DROP CONSTRAINT 
tst_fram_id_pk")Command was: ALTER TABLE tst_framework DROP CONSTRAINT 
tst_fram_id_pk
  [DBG] 9d (lib/dml.php:157) postgres8 error: [-1: ERROR:  cannot drop table 
tst_framework because other objects depend on it
  [DBG] 9d (lib/dml.php:157) DETAIL:  constraint tst_coll_fra_fk on table 
tst_collection depends on table tst_framework
  [DBG] 9d (lib/dml.php:157) HINT:  Use DROP ... CASCADE to drop the dependent 
objects too.] in EXECUTE("DROP TABLE tst_framework")Command was: DROP TABLE 
tst_framework

  This happens because we don't clean up coll_fra_fk index on {collection} 
table when uninstalling.
  The proper fix would be to use the same set of functions for behat and unit 
tests when we drop a site.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1723286/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1723286] Re: Rerunning unit tests fails with DB error

2017-10-19 Thread Dmitrii Metelkin
** Changed in: mahara
   Status: Confirmed => In Progress

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1723286

Title:
  Rerunning unit tests fails with DB error

Status in Mahara:
  In Progress

Bug description:
  On master.

  When you rerun unit tests they fail with:

  [DBG] 9d (lib/dml.php:157) postgres8 error: [-1: ERROR:  cannot drop 
constraint tst_fram_id_pk on table tst_framework because other objects depend 
on it
  [DBG] 9d (lib/dml.php:157) DETAIL:  constraint tst_coll_fra_fk on table 
tst_collection depends on index tst_fram_id_pk
  [DBG] 9d (lib/dml.php:157) HINT:  Use DROP ... CASCADE to drop the dependent 
objects too.] in EXECUTE("ALTER TABLE tst_framework DROP CONSTRAINT 
tst_fram_id_pk")Command was: ALTER TABLE tst_framework DROP CONSTRAINT 
tst_fram_id_pk
  [DBG] 9d (lib/dml.php:157) postgres8 error: [-1: ERROR:  cannot drop table 
tst_framework because other objects depend on it
  [DBG] 9d (lib/dml.php:157) DETAIL:  constraint tst_coll_fra_fk on table 
tst_collection depends on table tst_framework
  [DBG] 9d (lib/dml.php:157) HINT:  Use DROP ... CASCADE to drop the dependent 
objects too.] in EXECUTE("DROP TABLE tst_framework")Command was: DROP TABLE 
tst_framework

  This happens because we don't clean up coll_fra_fk index on {collection} 
table when uninstalling.
  The proper fix would be to use the same set of functions for behat and unit 
tests when we drop a site.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1723286/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp