[Mahara-contributors] [Bug 1722435] A change has been merged

2018-03-07 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/8122
Committed: 
https://git.mahara.org/mahara/mahara/commit/eee3f965fc8ba9cd469c6e6c5afbe3cb91dc9e24
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master

commit eee3f965fc8ba9cd469c6e6c5afbe3cb91dc9e24
Author: Francis Devine 
Date:   Tue Oct 10 14:59:46 2017 +1300

Bug 1722435: Add support for refreshing SAML metadata regularly

We utilise the simplesamlphp metarefresh plugin, and hook it into the
mahara cron for the auth plugin.

This adds a new field to each instance configuration form that allows
the user to specify a url that metadata should be fetched from.

This information is fed into the metarefresh plugin's config and a cron
hook is run every hour that triggers the plugin.

The simplesamlphp configuration is updated to read both the metarefresh
target location and the normal xml config file location, with the
metarefresh config files taking precedence.

NB: because of the way that the auth/saml plugin stores the idp entity
ids you are still required to present an XML file at least once, with
the metadata refresh config only taking over once it's fetched in the
next run.

This gives a smooth upgrade path for all existing mahara instances,
where they should continue to operate as normal, and then an
administrator can add the metadata refresh url at their leisure and have
it take precedence as soon as the metadata is available

behatnotneeded

Change-Id: Ib5733f7526a1c19d3150b45d90c9b675d4dd7ad2

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1722435

Title:
  SAML plugin automatic refresh of metadata support

Status in Mahara:
  Fix Committed

Bug description:
  The SAML plugin currently supports the addition of multiple IDP
  providers and a one time upload of the XML for that IDP, however it
  would be useful to provide it with the link to the IDP providers
  metadata (in xml form) and have it automatically fetch the metadata
  for the site on a regular basis, so if the IDP changes it's metadata
  SSO will automatically repair itself on the next fetch.

  We can do this by integrating the MetaData refresh plugin from the
  embedded simplesamlphp in the Mahara saml plugin and triggering it
  from the Mahara cron.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1722435/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1754208] A change has been merged

2018-03-07 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/8595
Committed: 
https://git.mahara.org/mahara/mahara/commit/425628b9a864031bfea690a6d4b79fd8f6241180
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master

commit 425628b9a864031bfea690a6d4b79fd8f6241180
Author: Kristina D.C. Hoeppner 
Date:   Thu Mar 8 15:33:40 2018 +1300

Bug 1754208: Language string review of new / changes strings

Change-Id: I7b04f12de8d896c56c81bfeb5d53a7bd91003b0e

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1754208

Title:
  Review lang strings for Mahara 18.04.0 release

Status in Mahara:
  In Progress

Bug description:
  Bulk review of the changed lang strings since the last review for
  17.10.0 to catch any that were missed during the bug fixing / feature
  development.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1754208/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1742354] Re: missing help file Site options/Account settings

2018-03-07 Thread Robert Lyon
** Changed in: mahara
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1742354

Title:
  missing help file Site options/Account settings

Status in Mahara:
  Fix Committed

Bug description:
  As a site admin user, in Site options-> account settings -> Override user 
account lifetime
  when clicking the 'i' icon to get help info, we get an error "An error 
occurred trying to retrieve the help page."

  This happens because the
  htdocs/lang/en.utf8/help/forms/siteoptions.defaultaccountlifetimeupdate.html
  that contains the help description is missing.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1742354/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1724743] Re: SAML metadata page shouldn't redirect to main page when a site is in maintenance mode

2018-03-07 Thread Robert Lyon
** Changed in: mahara
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1724743

Title:
  SAML metadata page shouldn't redirect to main page when a site is in
  maintenance mode

Status in Mahara:
  Fix Committed

Bug description:
  SAML metadata page  /auth/saml/sp/metadata.php shouldn't redirect to
  main page when a site is in maintenance mode. Ideally, it should send
  503 HTTP response to let systems who read the metadata know, that the
  file is not accessible.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1724743/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1724743] A change has been merged

2018-03-07 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/8593
Committed: 
https://git.mahara.org/mahara/mahara/commit/ea596952b4e28d573aa6e41919f326954045e991
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master

commit ea596952b4e28d573aa6e41919f326954045e991
Author: Robert Lyon 
Date:   Thu Mar 8 11:55:05 2018 +1300

Bug 1724743: Allow pages to ignore maintenance mode

by defining IGNOREMAINTENANCE in the php file

Useful to allow certain public pages to still be accessible to outside
world, eg the SAML metadata

behatnotneeded

Change-Id: If5e5e7520917c3128571537c5d50ed3fdd4add04
Signed-off-by: Robert Lyon 

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1724743

Title:
  SAML metadata page shouldn't redirect to main page when a site is in
  maintenance mode

Status in Mahara:
  Fix Committed

Bug description:
  SAML metadata page  /auth/saml/sp/metadata.php shouldn't redirect to
  main page when a site is in maintenance mode. Ideally, it should send
  503 HTTP response to let systems who read the metadata know, that the
  file is not accessible.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1724743/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1742354] A change has been merged

2018-03-07 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/8594
Committed: 
https://git.mahara.org/mahara/mahara/commit/cdc14d8839b07eafd33fe08e37a4b9ce7de80507
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master

commit cdc14d8839b07eafd33fe08e37a4b9ce7de80507
Author: Robert Lyon 
Date:   Thu Mar 8 12:05:36 2018 +1300

Bug 1742354: removing help icon for Override user account lifetime

In Admin -> Site options-> account settings

As the description is enough

behatnotneeded

Change-Id: Ib50d328c5f127f7f0f816392b21e2e490fd410e6
Signed-off-by: Robert Lyon 

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1742354

Title:
  missing help file Site options/Account settings

Status in Mahara:
  Fix Committed

Bug description:
  As a site admin user, in Site options-> account settings -> Override user 
account lifetime
  when clicking the 'i' icon to get help info, we get an error "An error 
occurred trying to retrieve the help page."

  This happens because the
  htdocs/lang/en.utf8/help/forms/siteoptions.defaultaccountlifetimeupdate.html
  that contains the help description is missing.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1742354/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1754239] A patch has been submitted for review

2018-03-07 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/8596

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1754239

Title:
  Behat: Embedded Media test

Status in Mahara:
  In Progress

Bug description:
  We need a test for the Embedded media block.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1754239/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1745278] A change has been merged

2018-03-07 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/8578
Committed: 
https://git.mahara.org/mahara/mahara/commit/65f6e575b43023461772ec344b71a2efe67840ee
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master

commit 65f6e575b43023461772ec344b71a2efe67840ee
Author: Ghada El-Zoghbi 
Date:   Thu Jan 25 14:15:15 2018 +1100

Bug 1745278: check user is logged in for publicly viewable groups

When a group is public and allows submissions, we need to check
that the user is logged in before retrieving the list of
sumibtted pages/collections to the group.

Sponsored by The Australian National University
behatnotneeded

Change-Id: Id8aeffea12aa36f27122069f9372fcb7b9ed95c5

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1745278

Title:
  Publicaly viewable group with submissions

Status in Mahara:
  Fix Committed

Bug description:
  Mahara: 17.10.2 (2017092611)
  OS: Linux 16.04 (php 7)
  DB: Postgres
  Browser: FF && Chrome (any)

  
  When a group is created with the following settings:

  * Allow submissions = Yes
  * Publicly viewable group = Yes

  When a user who is not logged in tries to view this group (i.e.
  because they know the URL), they get the following error:

  [WAR] 75 (lib/user.php:1943) Undefined variable: id

  Call stack (most recent first):
  log_message("Undefined variable: id", 8, true, true, 
"/var/www/clients/mahara/htdocs/lib/user.php", 1943) at 
/var/www/clients/mahara/htdocs/lib/errors.php:521
  error(8, "Undefined variable: id", 
"/var/www/clients/mahara/htdocs/lib/user.php", 1943, array(size 4)) at 
/var/www/clients/mahara/htdocs/lib/user.php:1943
  profile_url(false, false) at /var/www/clients/mahara/htdocs/lib/view.php:6164
  View->get_url(false) at /var/www/clients/mahara/htdocs/lib/view.php:5571
  View::get_extra_view_info(array(size 1), false, false) at 
/var/www/clients/mahara/htdocs/lib/view.php:6388
  View::get_views_and_collections(0) at 
/var/www/clients/mahara/htdocs/lib/group.php:1496
  group_view_submission_form("50") at 
/var/www/clients/mahara/htdocs/blocktype/groupviews/lib.php:424
  PluginBlocktypeGroupViews::get_data("50", false) at 
/var/www/clients/mahara/htdocs/blocktype/groupviews/lib.php:104
  PluginBlocktypeGroupViews::render_instance(object(BlockInstance)) at 
/var/www/clients/mahara/htdocs/lib/mahara.php:1789
  call_static_method("PluginBlocktypeGroupviews", "render_instance", 
object(BlockInstance)) at /var/www/clients/mahara/htdocs/blocktype/lib.php:1041
  BlockInstance->render_viewing(false) at 
/var/www/clients/mahara/htdocs/lib/view.php:2159
  View->build_column(1, 1, false, false) at 
/var/www/clients/mahara/htdocs/lib/view.php:2113
  View->build_columns(1, false, false) at 
/var/www/clients/mahara/htdocs/lib/view.php:2098
  View->build_rows() at /var/www/clients/mahara/htdocs/group/view.php:68

  [WAR] 75 (lib/user.php:1947) profile_url called with no user id
  Call stack (most recent first):
  profile_url(false, false) at /var/www/clients/mahara/htdocs/lib/view.php:6164
  View->get_url(false) at /var/www/clients/mahara/htdocs/lib/view.php:5571
  View::get_extra_view_info(array(size 1), false, false) at 
/var/www/clients/mahara/htdocs/lib/view.php:6388
  View::get_views_and_collections(0) at 
/var/www/clients/mahara/htdocs/lib/group.php:1496
  group_view_submission_form("50") at 
/var/www/clients/mahara/htdocs/blocktype/groupviews/lib.php:424
  PluginBlocktypeGroupViews::get_data("50", false) at 
/var/www/clients/mahara/htdocs/blocktype/groupviews/lib.php:104
  PluginBlocktypeGroupViews::render_instance(object(BlockInstance)) at 
/var/www/clients/mahara/htdocs/lib/mahara.php:1789
  call_static_method("PluginBlocktypeGroupviews", "render_instance", 
object(BlockInstance)) at /var/www/clients/mahara/htdocs/blocktype/lib.php:1041
  BlockInstance->render_viewing(false) at 
/var/www/clients/mahara/htdocs/lib/view.php:2159
  View->build_column(1, 1, false, false) at 
/var/www/clients/mahara/htdocs/lib/view.php:2113
  View->build_columns(1, false, false) at 
/var/www/clients/mahara/htdocs/lib/view.php:2098
  View->build_rows() at /var/www/clients/mahara/htdocs/group/view.php:68


  Because the group is submittable, the application is trying to
  retrieve a list of submitted pages/collections to this group.

  A check is required to ensure the user is logged in before it
  retrieves this data.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1745278/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1745278] Re: Publicaly viewable group with submissions

2018-03-07 Thread Robert Lyon
** Changed in: mahara
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1745278

Title:
  Publicaly viewable group with submissions

Status in Mahara:
  Fix Committed

Bug description:
  Mahara: 17.10.2 (2017092611)
  OS: Linux 16.04 (php 7)
  DB: Postgres
  Browser: FF && Chrome (any)

  
  When a group is created with the following settings:

  * Allow submissions = Yes
  * Publicly viewable group = Yes

  When a user who is not logged in tries to view this group (i.e.
  because they know the URL), they get the following error:

  [WAR] 75 (lib/user.php:1943) Undefined variable: id

  Call stack (most recent first):
  log_message("Undefined variable: id", 8, true, true, 
"/var/www/clients/mahara/htdocs/lib/user.php", 1943) at 
/var/www/clients/mahara/htdocs/lib/errors.php:521
  error(8, "Undefined variable: id", 
"/var/www/clients/mahara/htdocs/lib/user.php", 1943, array(size 4)) at 
/var/www/clients/mahara/htdocs/lib/user.php:1943
  profile_url(false, false) at /var/www/clients/mahara/htdocs/lib/view.php:6164
  View->get_url(false) at /var/www/clients/mahara/htdocs/lib/view.php:5571
  View::get_extra_view_info(array(size 1), false, false) at 
/var/www/clients/mahara/htdocs/lib/view.php:6388
  View::get_views_and_collections(0) at 
/var/www/clients/mahara/htdocs/lib/group.php:1496
  group_view_submission_form("50") at 
/var/www/clients/mahara/htdocs/blocktype/groupviews/lib.php:424
  PluginBlocktypeGroupViews::get_data("50", false) at 
/var/www/clients/mahara/htdocs/blocktype/groupviews/lib.php:104
  PluginBlocktypeGroupViews::render_instance(object(BlockInstance)) at 
/var/www/clients/mahara/htdocs/lib/mahara.php:1789
  call_static_method("PluginBlocktypeGroupviews", "render_instance", 
object(BlockInstance)) at /var/www/clients/mahara/htdocs/blocktype/lib.php:1041
  BlockInstance->render_viewing(false) at 
/var/www/clients/mahara/htdocs/lib/view.php:2159
  View->build_column(1, 1, false, false) at 
/var/www/clients/mahara/htdocs/lib/view.php:2113
  View->build_columns(1, false, false) at 
/var/www/clients/mahara/htdocs/lib/view.php:2098
  View->build_rows() at /var/www/clients/mahara/htdocs/group/view.php:68

  [WAR] 75 (lib/user.php:1947) profile_url called with no user id
  Call stack (most recent first):
  profile_url(false, false) at /var/www/clients/mahara/htdocs/lib/view.php:6164
  View->get_url(false) at /var/www/clients/mahara/htdocs/lib/view.php:5571
  View::get_extra_view_info(array(size 1), false, false) at 
/var/www/clients/mahara/htdocs/lib/view.php:6388
  View::get_views_and_collections(0) at 
/var/www/clients/mahara/htdocs/lib/group.php:1496
  group_view_submission_form("50") at 
/var/www/clients/mahara/htdocs/blocktype/groupviews/lib.php:424
  PluginBlocktypeGroupViews::get_data("50", false) at 
/var/www/clients/mahara/htdocs/blocktype/groupviews/lib.php:104
  PluginBlocktypeGroupViews::render_instance(object(BlockInstance)) at 
/var/www/clients/mahara/htdocs/lib/mahara.php:1789
  call_static_method("PluginBlocktypeGroupviews", "render_instance", 
object(BlockInstance)) at /var/www/clients/mahara/htdocs/blocktype/lib.php:1041
  BlockInstance->render_viewing(false) at 
/var/www/clients/mahara/htdocs/lib/view.php:2159
  View->build_column(1, 1, false, false) at 
/var/www/clients/mahara/htdocs/lib/view.php:2113
  View->build_columns(1, false, false) at 
/var/www/clients/mahara/htdocs/lib/view.php:2098
  View->build_rows() at /var/www/clients/mahara/htdocs/group/view.php:68


  Because the group is submittable, the application is trying to
  retrieve a list of submitted pages/collections to this group.

  A check is required to ensure the user is logged in before it
  retrieves this data.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1745278/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1731067] A change has been merged

2018-03-07 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/8591
Committed: 
https://git.mahara.org/mahara/mahara/commit/358070bdf49a73472064a179a68f7b1c004eac1b
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master

commit 358070bdf49a73472064a179a68f7b1c004eac1b
Author: Cecilia Vela Gurovic 
Date:   Thu Mar 8 09:14:09 2018 +1300

Bug 1731067: drop elasticsearch triggers for some cron jobs

behatnotneeded

Change-Id: I63b953b3a31f38c96f66d602e67622b62cdb0b01

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1731067

Title:
  Some cron jobs cause elasticsearch queue to populate when it doesn't
  need to

Status in Mahara:
  Fix Committed

Bug description:
  We only record certain information in elasticsearch but we queue
  things even if unrecorded information changes because we use
  triggers/procedures on the tables

  Example, when the recalculate_quota cron runs it works out what the
  user quota should be and then updates all the users in usr table that
  need fixing. This table has a trigger on it so all users needing
  updating are added to queue to be indexed.

  On a big site that can mean thousands of users being indexed. But we
  don't record quota in elasticsearch so we don't need to index this
  change.

  It would be good to be able to drop/add elasticsearch triggers during
  cron process for certain cron jobs like we do in upgrade.php script

  eg:
drop_elasticsearch_triggers();
... do cron job ...
create_elasticsearch_triggers();

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1731067/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1731067] Re: Some cron jobs cause elasticsearch queue to populate when it doesn't need to

2018-03-07 Thread Robert Lyon
** Changed in: mahara
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1731067

Title:
  Some cron jobs cause elasticsearch queue to populate when it doesn't
  need to

Status in Mahara:
  Fix Committed

Bug description:
  We only record certain information in elasticsearch but we queue
  things even if unrecorded information changes because we use
  triggers/procedures on the tables

  Example, when the recalculate_quota cron runs it works out what the
  user quota should be and then updates all the users in usr table that
  need fixing. This table has a trigger on it so all users needing
  updating are added to queue to be indexed.

  On a big site that can mean thousands of users being indexed. But we
  don't record quota in elasticsearch so we don't need to index this
  change.

  It would be good to be able to drop/add elasticsearch triggers during
  cron process for certain cron jobs like we do in upgrade.php script

  eg:
drop_elasticsearch_triggers();
... do cron job ...
create_elasticsearch_triggers();

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1731067/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1754239] [NEW] Behat: Embedded Media test

2018-03-07 Thread Rebecca Blundell
Public bug reported:

We need a test for the Embedded media block.

** Affects: mahara
 Importance: Undecided
 Assignee: Rebecca Blundell (rjb-dev)
 Status: In Progress


** Tags: behat

** Changed in: mahara
 Assignee: (unassigned) => Rebecca Blundell (rjb-dev)

** Changed in: mahara
   Status: New => In Progress

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1754239

Title:
  Behat: Embedded Media test

Status in Mahara:
  In Progress

Bug description:
  We need a test for the Embedded media block.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1754239/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1528117] Re: Collection export options need bulk options

2018-03-07 Thread Robert Lyon
See also https://bugs.launchpad.net/mahara/+bug/1528118

** Changed in: mahara
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1528117

Title:
  Collection export options need bulk options

Status in Mahara:
  Fix Committed

Bug description:
  Mahara 16.04

  When you export a portfolio, you can choose to select pages or
  collections. The "Pages" screen has bulk options of selecting all or
  reversing the selection facilitating the selection of multiple pages.
  The collection screen doesn't have these options yet.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1528117/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1528117] A change has been merged

2018-03-07 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/8476
Committed: 
https://git.mahara.org/mahara/mahara/commit/c03f28c3db089f854ec8069937442d9c04d76f86
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master

commit c03f28c3db089f854ec8069937442d9c04d76f86
Author: Liam 
Date:   Fri Jan 26 15:43:48 2018 +1300

Bug #1528117: Collection export needs bulk options

behatnotneeded

Change-Id: Id82b367fc0da1b935efbcdf43a892eff9114a9a8

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1528117

Title:
  Collection export options need bulk options

Status in Mahara:
  Fix Committed

Bug description:
  Mahara 16.04

  When you export a portfolio, you can choose to select pages or
  collections. The "Pages" screen has bulk options of selecting all or
  reversing the selection facilitating the selection of multiple pages.
  The collection screen doesn't have these options yet.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1528117/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1528118] Re: Preview collections on Export screen

2018-03-07 Thread Robert Lyon
htdocs/theme/raw/pieforms/export.php

Line 76:

This needs to be changed to
 export_form_cell_html($element);

Will need to add the id of the collection or first view held within to the 
preview link 
If we want to have the 'preview' link (like we do with views)

** Changed in: mahara
Milestone: None => 18.10.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1528118

Title:
  Preview collections on Export screen

Status in Mahara:
  Confirmed

Bug description:
  When you export pages, you can preview them. But you don't have that
  option for collections. There should be a collection preview link
  which takes you to the first page of the collection and ideally you
  can navigate through the other pages.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1528118/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1754237] [NEW] SimpleSAML_Logger is deprecated warning

2018-03-07 Thread Robert Lyon
Public bug reported:

There is a warning about:
ssphp- WARNING [CL05234431] The class or interface 'SimpleSAML_Logger' is now 
using namespaces, please use 'SimpleSAML\Logger'.

We need to update the config etc to use the new style of calling the
logger

** Affects: mahara
 Importance: Low
 Status: Confirmed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1754237

Title:
  SimpleSAML_Logger is deprecated warning

Status in Mahara:
  Confirmed

Bug description:
  There is a warning about:
  ssphp- WARNING [CL05234431] The class or interface 'SimpleSAML_Logger' is now 
using namespaces, please use 'SimpleSAML\Logger'.

  We need to update the config etc to use the new style of calling the
  logger

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1754237/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1744191] Re: Changing Datepicker

2018-03-07 Thread Robert Lyon
** Changed in: mahara
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1744191

Title:
  Changing Datepicker

Status in Mahara:
  Fix Committed

Bug description:
  A new datepicker may be available to use to bring Mahara more up to
  date with current styling standards

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1744191/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1744191] A change has been merged

2018-03-07 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/8469
Committed: 
https://git.mahara.org/mahara/mahara/commit/8d796e7ca04b6df776b5deeb07cf38b9c7b037c0
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master

commit 8d796e7ca04b6df776b5deeb07cf38b9c7b037c0
Author: Liam 
Date:   Tue Jan 23 17:03:15 2018 +1300

Bug #1744191: Updated the datepicker to use the bootstrap one

Includes accessibility features
Includes ability to translate tooltips
Have picker div appear inside a  rather than  for valid
markup

behatnotneeded

Change-Id: I7e4dfb5026cfa579145ca4c932ad673690a8c55a

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1744191

Title:
  Changing Datepicker

Status in Mahara:
  Fix Committed

Bug description:
  A new datepicker may be available to use to bring Mahara more up to
  date with current styling standards

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1744191/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1744191] A change has been merged

2018-03-07 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/8472
Committed: 
https://git.mahara.org/mahara/mahara/commit/5044c25d991cde6aafc1e838d25f5116eb7accdd
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master

commit 5044c25d991cde6aafc1e838d25f5116eb7accdd
Author: Liam 
Date:   Fri Jan 26 10:18:06 2018 +1300

Bug #1744191: Changing date inputs to datepicker on group, user, and
institution settings

behatnotneeded

Change-Id: I76365ac480d5d74d974c7776f738788710bc7cca

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1744191

Title:
  Changing Datepicker

Status in Mahara:
  Fix Committed

Bug description:
  A new datepicker may be available to use to bring Mahara more up to
  date with current styling standards

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1744191/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1754208] A patch has been submitted for review

2018-03-07 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/8595

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1754208

Title:
  Review lang strings for Mahara 18.04.0 release

Status in Mahara:
  In Progress

Bug description:
  Bulk review of the changed lang strings since the last review for
  17.10.0 to catch any that were missed during the bug fixing / feature
  development.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1754208/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1754208] [NEW] Review lang strings for Mahara 18.04.0 release

2018-03-07 Thread Kristina Hoeppner
Public bug reported:

Bulk review of the changed lang strings since the last review for
17.10.0 to catch any that were missed during the bug fixing / feature
development.

** Affects: mahara
 Importance: High
 Assignee: Kristina Hoeppner (kris-hoeppner)
 Status: In Progress

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1754208

Title:
  Review lang strings for Mahara 18.04.0 release

Status in Mahara:
  In Progress

Bug description:
  Bulk review of the changed lang strings since the last review for
  17.10.0 to catch any that were missed during the bug fixing / feature
  development.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1754208/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1754207] [NEW] Make SmartEvidence strings for statuses configurable

2018-03-07 Thread Kristina Hoeppner
Public bug reported:

Mahara 18.04.RC1:

/module/framework/lang/en.utf8/module.framework.php contains the
following lang strings:

$string['readyforassessmentcount'] = 'Number of pages that contain the standard 
element "Ready for assessment":';
$string['dontmatchcount'] = 'Number of pages that contain the standard element 
"Does not meet the standard":';
$string['partiallycompletecount'] = 'Number of pages that contain the standard 
element "Partially meets the standard":';
$string['completedcount'] = 'Number of pages that contain the standard element 
"Meets the standard":';


The text in the quotation marks should be configurable so that it pulls in the 
string that is used in the particular SmartEvidence framework.

** Affects: mahara
 Importance: Medium
 Status: Confirmed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1754207

Title:
  Make SmartEvidence strings for statuses configurable

Status in Mahara:
  Confirmed

Bug description:
  Mahara 18.04.RC1:

  /module/framework/lang/en.utf8/module.framework.php contains the
  following lang strings:

  $string['readyforassessmentcount'] = 'Number of pages that contain the 
standard element "Ready for assessment":';
  $string['dontmatchcount'] = 'Number of pages that contain the standard 
element "Does not meet the standard":';
  $string['partiallycompletecount'] = 'Number of pages that contain the 
standard element "Partially meets the standard":';
  $string['completedcount'] = 'Number of pages that contain the standard 
element "Meets the standard":';

  
  The text in the quotation marks should be configurable so that it pulls in 
the string that is used in the particular SmartEvidence framework.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1754207/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1733995] Re: Issue targeting a select2 tag in behat test

2018-03-07 Thread Robert Lyon
We have a couple of ways of accessing select2 in behat

And I set the select2 value "Collection UserA_05" for "editaccess_collections"
- used when the select2 is pre-populated with data

And I fill in select2 input "sendmessage_recipients" with "UserA" and select 
"Angela User (UserA)"
- used when the select2 needs to fetch data via ajax

In the case of the access list page we should be able to target the
select id, eg: accesslist[0][id]


** Changed in: mahara
   Status: In Progress => Incomplete

** Changed in: mahara
Milestone: 18.04.0 => None

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1733995

Title:
  Issue targeting a select2 tag in behat test

Status in Mahara:
  Incomplete

Bug description:
  When sharing a page with another user, it is not possible to target
  the drop-down box with 'Search' placeholder text using css id. Is this
  an issue with the way select2 search works in Behat? Or something
  else?

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1733995/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1690273] Re: Test for footer headings display

2018-03-07 Thread Robert Lyon
** Changed in: mahara
Milestone: 18.04.0 => 18.10.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1690273

Title:
  Test for footer headings display

Status in Mahara:
  In Progress

Bug description:
  The current behat test admin/create_and_delete_menu_item.feature has a
  partial test for showing and hiding elements of the footer:

  And I enable the switch "Terms and conditions"
  And I disable the following switches:
   | Privacy statement |
   | About |
   | Contact us |
  And I press "Save changes"
# Checking the switches held the setting
  And the following fields match these values:
   | Terms and conditions | 1 |
   | Privacy statement | 0 |
   | About | 0 |
   | Contact us | 0 |

  As part of the process of tidying up the behat tests, this
  functionality should be removed from this test and a new test created
  called footer_settings.feature.

  The new test should have 2 scenarios, one to check the settings as
  above as admin, but also to check that the selected footer settings
  are displayed on the homepage to a user.

  The second scenario should check that when the user clicks on the
  footer links, correct content is displayed, specifically that the
  headings are not repeated (Bug #1683551)

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1690273/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1732302] Re: fix secret_url behat test

2018-03-07 Thread Robert Lyon
** Changed in: mahara
Milestone: 18.04.0 => 18.10.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1732302

Title:
  fix secret_url behat test

Status in Mahara:
  In Progress

Bug description:
  This test doesn't do what it says it does - i.e. it says it checks the
  secret url can be reliably copied. All it currently does is check that
  a 1 appears after the url is created.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1732302/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1603294] Re: Licenses: Once you've selected a license, you can't go back to "None"

2018-03-07 Thread Robert Lyon
** Changed in: mahara
   Status: In Progress => Confirmed

** Changed in: mahara
Milestone: 18.04.0 => 18.10.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1603294

Title:
  Licenses: Once you've selected a license, you can't go back to "None"

Status in Mahara:
  Confirmed

Bug description:
  While testing out Bug 1279526, I noticed that you can't change an
  uploaded file from a particular license to "No License". This may have
  been by design, with the idea that "No License" was a temporary thing
  until you pick a license. But with Bug 1279526 we're changing the
  wording of "No License" to make it clear that if you're not choosing a
  particular license, then the default copyright rules apply, so it
  becomes more necessary to be able to switch to that.

  To replicate:

  1. Go to "Administration -> Configure Site -> General Settings", and
  enable "License metadata"

  2. Go to "Content -> Files" and upload a file.

  3. Once the file is uploaded, click the pencil "edit" button to open
  its editing form. It should be at "No license" or the equivalent.
  Change it to "Creative Commons Attribution 4.0"

  4. Click "Save changes"

  5. Now click the pencil "edit" button again. Change the License back
  to "No license" or the equivalent.

  6. Again click "Save changes"

  7. Again click the pencil "edit" button.

  Expected result: You see "No license" or the equivalent as the license
  selection.

  Actual result: You see "Creative Commons Attribution 4.0" as the
  license selection.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1603294/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1690291] Re: Combine multiple tests for webservices into one

2018-03-07 Thread Robert Lyon
** Changed in: mahara
Milestone: 18.04.0 => 18.10.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1690291

Title:
  Combine multiple tests for webservices into one

Status in Mahara:
  In Progress

Bug description:
  webservices_master_switch.feature and
  webservices_switch_dependencies.feature can be combined into one test.
  It would be good to explore testing the functionality as well as
  whether the switches work too.

  To do:
  Enable/disable toggles at the beginning are a bit pointless. Just enable both 
switches.
  Figure out best way to test functionality.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1690291/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1649433] Re: Consolidate "Add file" buttons

2018-03-07 Thread Robert Lyon
** Changed in: mahara
Milestone: 18.04.0 => 18.10.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1649433

Title:
  Consolidate "Add file" buttons

Status in Mahara:
  In Progress

Bug description:
  We use two different ways of adding files to a text box / resume
  sections etc.: One, which allows you to add files from both your
  Mahara storage and computer and another one only from the computer.
  The latter one is the older one and can still be found in certain
  places.

  We should consolidate the occurances to always use the new way of
  adding files to be more consistent.

  Best case in point:

  When you add a file to your education history, you get the old button.
  However, when you edit that entry, you get the new button (see
  attachment).

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1649433/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1733769] Re: behat test for 1729423 - can't choose comment to make public

2018-03-07 Thread Robert Lyon
** Changed in: mahara
Milestone: 18.04.0 => 18.10.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1733769

Title:
  behat test for 1729423 - can't choose comment to make public

Status in Mahara:
  In Progress

Bug description:
  adding a test that one out a list of private comments can be made
  public

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1733769/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1692755] Re: Move focus to first item in menu list

2018-03-07 Thread Robert Lyon
** Changed in: mahara
Milestone: 18.04.0 => 18.10.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1692755

Title:
  Move focus to first item in menu list

Status in Mahara:
  In Progress

Bug description:
  Mahara 17.04+

  When user presses Enter on Show Main Menu button, focus should move to
  the first item on the menu list. This also applies to Show User Menu
  button and the "Show Admin Menu" button.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1692755/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1741987] Re: Update jquery to version 3.2.1

2018-03-07 Thread Robert Lyon
** Changed in: mahara
Milestone: 18.04.0 => 18.10.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1741987

Title:
  Update jquery to version 3.2.1

Status in Mahara:
  In Progress

Bug description:
  jQuery 3.2.1 is available

  http://jquery.com/download/

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1741987/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1742304] Re: Remove duplicate language strings

2018-03-07 Thread Robert Lyon
** Changed in: mahara
Milestone: 18.04.0 => 18.10.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1742304

Title:
  Remove duplicate language strings

Status in Mahara:
  In Progress

Bug description:
  There are quite a few instances where the same language string is repeated in 
different files.
  The duplicates should be removed.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1742304/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1600101] Re: Examples of how we can utilise the connection manager

2018-03-07 Thread Robert Lyon
** Changed in: mahara
Milestone: 18.04.0 => None

** Changed in: mahara
   Status: In Progress => Invalid

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1600101

Title:
  Examples of how we can utilise the connection manager

Status in Mahara:
  Invalid

Bug description:
  There are two example plugins called 'notification/redirect' and
  'module/syncprofile' that use different ways to connect sites together

  notification/redirect shows how we can use an existing api hook - in
  this case the notification hook called notify_user()

  module/syncprofile works by exposing it's hook via the following code,
  which looks to see if there is a 'sync_profile' function in any of the
  plugins:

  if ($connections = Plugin::get_webservice_connections($USER, 'sync_profile')) 
{
foreach ($connections as $connection) {
  call_static_method($connection->connection->class, 'sync_profile', 
$connection, $USER, $values);
}
  }

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1600101/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1560778] Re: Convert institution auth manager from pop-up window to modal

2018-03-07 Thread Robert Lyon
** Changed in: mahara
Milestone: 18.04.0 => None

** Changed in: mahara
   Status: In Progress => Won't Fix

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1560778

Title:
  Convert institution auth manager from pop-up window to modal

Status in Mahara:
  Won't Fix

Bug description:
  On the institution config screen, one of the things you can do is
  manage the list of authentication methods configured for the
  institution. This is quite old code, and it uses a pop-up window. Now
  that we've got better control of modal windows (as on the block config
  screen) we should use a modal for this instead of a pop-up.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1560778/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1681591] Re: Reorganise where we have the profile links/information

2018-03-07 Thread Robert Lyon
** Changed in: mahara
Milestone: 18.04.0 => 18.10.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1681591

Title:
  Reorganise where we have the profile links/information

Status in Mahara:
  In Progress

Bug description:
  I am thinking of reorganising the placement of profile things.

  Ideas:
  - Move the navigation 'Profile' and 'Profile image' options from 'Main menu' 
(content section) to 'User menu'
  - Merge 'Profile' and 'Profile image' options into one 'Profile settings' 
page/link
  - Remove the profile page/dashboard page from list of 'Pages and collections' 
list

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1681591/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1691957] Re: Allow SQL as the datastore for SimpleSAMLphp

2018-03-07 Thread Robert Lyon
** Changed in: mahara
Milestone: 18.04.0 => 18.10.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1691957

Title:
  Allow SQL as the datastore for SimpleSAMLphp

Status in Mahara:
  In Progress

Bug description:
  SimpleSAMLphp library allows memcache, phpsession and sql for storing
  sessions and Mahara only allows memcache and phpsession!

  It would be really useful for some if Mahara could allow usage of SQL
  also. We have provided a working patch (mahara side) with this
  bug/feature request to allow SQL as session storage for SimpleSAMLphp.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1691957/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1667522] Re: Separate account registration and institution joining requests

2018-03-07 Thread Robert Lyon
** Changed in: mahara
Milestone: 18.04.0 => 18.10.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1667522

Title:
  Separate account registration and institution joining requests

Status in Mahara:
  In Progress

Bug description:
  When you allow registration in an institution, two actions are
  allowed:

  1. New users can register on the site for that institution.
  2. Existing users can request membership in the institution.

  These two actions should be separated as they are two very different
  actions. While an institution may allow the registration of new
  accounts, they may not allow the switching of institutions by simply
  contacting another institution.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1667522/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1696291] Re: Allow the splitting of Behat tests

2018-03-07 Thread Robert Lyon
** Changed in: mahara
Milestone: 18.04.0 => 18.10.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1696291

Title:
  Allow the splitting of Behat tests

Status in Mahara:
  In Progress

Bug description:
  https://reviews.mahara.org/#/c/7811/

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1696291/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1716820] Re: Delete SAML IdP in the admin area

2018-03-07 Thread Robert Lyon
** Changed in: mahara
Milestone: 18.04.0 => 18.10.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1716820

Title:
  Delete SAML IdP in the admin area

Status in Mahara:
  In Progress

Bug description:
  When you add an IdP to a SAML auth for an institution, you can add new
  metadata, but you cannot remove metadata that you don't want to use
  anymore. There should be a way of doing that.

  We need to keep in mind that multiple institutions can use the same
  base metadata but have different values in their specific setup. Thus,
  a simple "Delete this" wouldn't work as the metadata would then also
  be deleted for other institutions.

  Possible solutions that I can see:

  1. Display a list of all metadata providers on Plugins -> SAML and
  include which institutions use a particular metadata. If none use it,
  display the "Delete" icon and allow it to be deleted (similar to the
  SmartEvidence page under Extensions -> SmartEvidence). When clicking
  "Delete", a confirmation step should be there though before
  permanently deleting the metadata.

  2. If a certain metadata is not used anymore, remove it automatically
  via cron after a few minutes.

  I prefer 1 as that gives more control to a site admin and also quickly
  shows her in which institutions which SAML metadata is used, which we
  currently don't have.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1716820/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1718480] Re: Allow modules to extend group menu items

2018-03-07 Thread Robert Lyon
** Changed in: mahara
Milestone: 18.04.0 => 18.10.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1718480

Title:
  Allow modules to extend group menu items

Status in Mahara:
  In Progress

Bug description:
  Similar to the interaction plugin types allow modules to
  add/edit/remove items within group instance navigations.

  This is a useful extension for adding contributed modules.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1718480/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1717744] Re: Allow LTI to be a child auth of LDAP

2018-03-07 Thread Robert Lyon
** Changed in: mahara
Milestone: 18.04.0 => 18.10.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1717744

Title:
  Allow LTI to be a child auth of LDAP

Status in Mahara:
  In Progress

Bug description:
  This will be similar to Bug 1691317 but for LDAP instead of SAML

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1717744/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1724846] Re: Add userchangegrouprole event trigger

2018-03-07 Thread Robert Lyon
** Changed in: mahara
Milestone: 18.04.0 => 18.10.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1724846

Title:
  Add userchangegrouprole event trigger

Status in Mahara:
  In Progress

Bug description:
  We have a client who has a requirement to trigger additional
  functionality when a users role within a group changes.

  The event trigger userchangegrouprole should be added to the system.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1724846/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1743870] Re: Moderate portfolios of regular users

2018-03-07 Thread Robert Lyon
** Changed in: mahara
Milestone: 18.04.0 => 18.10.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1743870

Title:
  Moderate portfolios of regular users

Status in Mahara:
  In Progress

Bug description:
  Allow institution admins and site admins to immediately remove all
  sharing options from a page (or collection if the page is within a
  collection) that is deemed objectionable.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1743870/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1738686] A change has been merged

2018-03-07 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/8365
Committed: 
https://git.mahara.org/mahara/mahara/commit/9b135c06958cc164974087b71b6a6ae31438803d
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master

commit 9b135c06958cc164974087b71b6a6ae31438803d
Author: Robert Lyon 
Date:   Mon Dec 18 11:40:37 2017 +1300

Bug 1738686: Adding generic blog/blogpost webservice

To allow
- an external resource to get a list of blogs/blogposts for a user
- external resource to add new blogpost to a blog based on userid and
blog id

behatnotneeded

Change-Id: I63a003a74a685f2cd2d8b6e3eb0bf941f422a49f
Signed-off-by: Robert Lyon 

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1738686

Title:
  Need a generic create blogpost for webservices

Status in Mahara:
  Fix Committed

Bug description:
  Need a simple way to add content from an external app to a user's
  account via web services.

  We just want to do 2 things:

  1) supply user credentials, eg id or username or email and get a list
  of blogs + blogposts returned

  2) using the id of a blog and user's id be able to crate a simple blogpost 
against the blog by setting the 
  - title
  - description
  - tags
  - published
  - allowcomments

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1738686/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1723961] Re: Edit plans more easily from a page

2018-03-07 Thread Robert Lyon
** Changed in: mahara
Milestone: 18.04.0 => 18.10.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1723961

Title:
  Edit plans more easily from a page

Status in Mahara:
  In Progress

Bug description:
  We have a client who has identified that end users of their Mahara
  installation need to be able to update a plan or task from within a
  blocktype instance and return to the page that they were on for more
  consistent experience.

  Finding their way to the plan or task itself in their portfolio
  content can be several clicks to get to and then several more to
  return to the page or dashboard they were reviewing. This can also be
  exacerbated if the user has a high number of instances of each content
  or page type.

  Because of the above they have required the following enhancements
  added to the Plans blocktype to improve user experience:

  1. a link to edit a plan instance (description, title, tags etc)
  2. a link to add a new task to a plan instance
  3. the ability to edit a task instance (description, title, tags, completion 
date etc)
  4. the ability to mark a task as complete or incomplete from 

  Requirements 1-3, upon save or cancel, will redirect back to the page
  the user was on before entering these pages.

  All editing functionality will only be available to the page owner and
  when in the editing page mode.

  In addition they have also requested the following functionality:
  - the ability to select more than one plan instance per blocktype

  to reduce the unique number of blocktypes required on the page.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1723961/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1738686] Re: Need a generic create blogpost for webservices

2018-03-07 Thread Robert Lyon
https://reviews.mahara.org/#/c/8365/

** Changed in: mahara
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1738686

Title:
  Need a generic create blogpost for webservices

Status in Mahara:
  Fix Committed

Bug description:
  Need a simple way to add content from an external app to a user's
  account via web services.

  We just want to do 2 things:

  1) supply user credentials, eg id or username or email and get a list
  of blogs + blogposts returned

  2) using the id of a blog and user's id be able to crate a simple blogpost 
against the blog by setting the 
  - title
  - description
  - tags
  - published
  - allowcomments

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1738686/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1184465] Re: Add version numbers to language packs

2018-03-07 Thread Robert Lyon
** Changed in: mahara
Milestone: 18.04.0 => 18.10.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1184465

Title:
  Add version numbers to language packs

Status in Mahara:
  Triaged

Bug description:
  As I touched on in https://bugs.launchpad.net/mahara/+bug/1180544 ,
  there's currently no way for a user looking at the langpacks site (
  http://langpacks.mahara.org/ ) to tell whether there's been an update
  to their language pack.

  Therefore, it would be useful if we added version numbers to the
  language packs. These could be placed in lang/langconfig.php,
  something like this:

  $string['release'] = '1.7.1'; // The Mahara release number this langpack was 
created for
  $string['version'] = '2013052700'; // Incremented on each new release of the 
langpack, using the current date.

  And the name of the langpack file could be changed to something along
  the lines of "vi-1.7_STABLE-2013052700.tar.gz".

  A related idea would be to have specific langpack releases tied to
  Mahara minor version releases, to support the case where a language
  string's name is changed in a minor version. In that case, you
  wouldn't want to upgrade your langpacks before your Mahara version has
  been upgraded. In that case you'd want langpack releases for each
  minor version, as well as maybe a "nightly" langpack release.

  vi-1.7.3.tar.tgz
  vi-1.7.4.tar.tgz
  vi-1.7_STABLE-2013052700.tar.gz

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1184465/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1427885] Re: Change "artefact.path" column to use the "nested set" technique for managing hierarchical data

2018-03-07 Thread Robert Lyon
** Changed in: mahara
Milestone: 18.04.0 => 18.10.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1427885

Title:
  Change "artefact.path" column to use the "nested set" technique for
  managing hierarchical data

Status in Mahara:
  Triaged

Bug description:
  Originally, we just had each artefact store its parent ID. This is
  slow because it requires running multiple queries to find all the
  descendants of a node.

  Then, we added a "path" element to each artefact. This is better, but
  you can't get a performance improvement by indexing the column,
  because most of the queries rely on the "LIKE" operator. (See
  https://bugs.launchpad.net/mahara/+bug/1423700 )

  So if we want to squeeze more performance out of this, I think the one
  remaining thing to look into is the "nested set" technique. This
  technique results in very fast searches for descendants, with the cost
  of somewhat slower writes. http://mikehillyer.com/articles/managing-
  hierarchical-data-in-mysql/

  There are even existing PHP libraries for using the technique, such as
  this one: http://www.sideralis.org/baobab/

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1427885/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1194853] Re: OpenGraph (Facebook preview) tags for the images shown on a Page

2018-03-07 Thread Robert Lyon
** Changed in: mahara
Milestone: 18.04.0 => None

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1194853

Title:
  OpenGraph (Facebook preview) tags for the images shown on a Page

Status in Mahara:
  Triaged

Bug description:
  While trying to share my own delightful endless loop of a kākā at a
  feeding station with a Facebook friend, I realized that Mahara doesn't
  provide the OpenGraph tags necessary for Facebook to show the images
  on a Page in its preview.

  So, we should add those.

  The most important page to do this on is the main Page display,
  /view/view.php . It would also make sense to do it on
  /artefact/view.php (for image artefacts), and possibly on the Profile
  page, and any other pages that can be publicly accessible which I may
  have forgotten (perhaps the Site home page for logged-out users?)

  Probably the cleanest way to do this is to add a function to the
  artefact API (and/or the block API?), which asks each one whether it
  wants to post any OpenGraph tags. It would also make sense for the
  Images to use their "preview" image (the one you see on
  artefact/view.php) rather than the image itself.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1194853/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1539322] Re: Do we still need device detection?

2018-03-07 Thread Robert Lyon
** Changed in: mahara
Milestone: 18.04.0 => 18.10.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1539322

Title:
  Do we still need device detection?

Status in Mahara:
  Triaged

Bug description:
  Mahara 15.10 introduced Bootstrap. All themes are now responsive. When
  I tested the "Deactivate device detection" functionality, I couldn't
  see much of a difference when using the site. I did notice the content
  chooser was displayed the start of the words instead of only showing
  the icon on the "Edit page" screen.

  I wonder if we can remove the custom device detection. You can enable
  the user turning off device detection in Admin -> Config site -> User
  settings -> Users can disable device detection. That then happens on
  the account settings page.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1539322/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1737995] Re: Image description not showing when image is added to a text block

2018-03-07 Thread Robert Lyon
** Changed in: mahara
Milestone: 18.04.0 => 18.10.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1737995

Title:
  Image description not showing when image is added to a text block

Status in Mahara:
  Confirmed

Bug description:
  When adding an image to Mahara there is the option to include a description. 
  When the image is added to a text block there is no way for the image 
description to made available either as text under the image, or when you hover 
over the image.

  
  I'm on version 17.04 using Chrome.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1737995/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1749308] Re: Collection navigation triggering swiperight event on mouse click

2018-03-07 Thread Robert Lyon
** Changed in: mahara
Milestone: None => 18.10.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1749308

Title:
  Collection navigation triggering swiperight event on mouse click

Status in Mahara:
  Confirmed

Bug description:
  Mahara: 17.10.3
  OS: Linux 16.04
  DB: Postgres (not relevant)
  Browser: Firefox and Chrome

  
  In a collection on a view with the 'Previous page' displayed, the swiperight 
event is getting triggered on a mouse click. 

  When a user tries to select some text (i.e. click mouse, hold it down,
  and select text), this action is interpreted as a swipe action. And,
  the swiperight event is triggered.

  I've come across this stackoverflow discussion:

  https://stackoverflow.com/questions/36317660/jquery-mobile-swipe-
  gesture-for-touch-screen-only-and-not-for-mouse

  Bascially, the swiperight and swipeleft events should be disabled on
  the mousedown event and enabled on the touchstart event.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1749308/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1724950] Re: Broken link checker

2018-03-07 Thread Robert Lyon
** Changed in: mahara
Milestone: 18.04.0 => 18.10.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1724950

Title:
  Broken link checker

Status in Mahara:
  Confirmed

Bug description:
  Implement a broken link checker to prevent people going to web sites
  that may be up for grabs and thus exposing them to phishing, serving
  malware, impersonation.

  Thanks to Vineet Kumar for reporting this.

  I think it concerns primarily links in the editor (TinyMCE and plain
  text) as well as any field where you can enter a URL. External media
  should be fairly safe as domains need to be whitelisted in the
  "Allowed iframes". So having a check for them rather than when a block
  is on a page might suffice.

  Before implementing a solution, the following should be discussed:
  - What do current link checkers offer?
  - Unlink automatically or require admin intervention? If admin intervention, 
will there be a weekly / daily email?
  - If admin intervention, most links will be in user created content though to 
which admin doesn't have direct access.
  - Should links be crossed out and unlinked automatically? That would also 
resolve the issue with posting direct links rather than linking text.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1724950/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1727532] Re: Allow SmartEvidence use custom status icons

2018-03-07 Thread Robert Lyon
** Changed in: mahara
Milestone: 18.04.0 => 18.10.0

** Changed in: mahara
Milestone: 18.10.0 => 18.04.0

** Changed in: mahara
Milestone: 18.04.0 => 18.10.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1727532

Title:
  Allow SmartEvidence use custom status icons

Status in Mahara:
  Confirmed

Bug description:
  Currently we allow SmartEvidence matrix files to define custom status
  settings for the 4 statuses

  But we don't allow for custom icons relating to those statuses.

  It would be good if we also allowed / recorded what icon to use for
  the status

  This would entail
  1) being able to define it in the matrix file, eg

   "evidencestatusesicons":
[
  {"begun":"icon-square"},
  {"incomplete":"icon-triangle"},
  {"partialcomplete":""},
  {"completed":"icon-star"}
], 

  We'd also need to handle stacked icons, where we can stack icons on top of 
each other
  See http://fontawesome.io/examples/ the stacked icon section

  So we could do this by allowing an array {"completed":["icon-circle
  ","icon-star"]}

  2) Save the icon info in the framework_evidence_statuses table by
  adding a icon column. We can save the data in json format to make
  things easier to keep the 1 to 1 connection between status and the
  icon(s) to use.

  3) Being able to define the icon in html by using a matrix-icon.tpl
  file where we can define the markup allowing if/else checks so we
  return the correct markup for normal vs stacked icons and fetch it via
  smarty

  4) In get_statuses_to_display() we fetch the html via template and add
  the html to the array. So rather that setting 'classes' we set
  'iconhtml' and pass that to the matrix template.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1727532/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1717379] Re: Tool to update URLs to internal artefacts etc. in text boxes

2018-03-07 Thread Robert Lyon
** Changed in: mahara
Milestone: 18.04.0 => 18.10.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1717379

Title:
  Tool to update URLs to internal artefacts etc. in text boxes

Status in Mahara:
  Confirmed

Bug description:
  Data in text boxes is stored serialized. Thus, when wanting to make
  changes, it's not as straight forward as simply replacing an old URL
  with a new URL. Changes are necessary when an institution moves to a
  new URL for its Mahara site. Any images that have been placed into
  text boxes, description fields, journal entries, i.e. anything with
  TinMCE will have full URLs listed. The wwwroot part of them will need
  to be changed for the new URL. However, since the image was not
  embedded via the image block but as an image within text, Mahara
  doesn't re-write the URL automatically.

  The same applies to links to other artefacts, pages or collections in
  a text box.

  Thus, a tool would be nice in for the "text" plugin where an admin can
  provide the old wwwroot and the new one - the latter already pre-
  filled - and can then automatically convert all serialized data in one
  go rather than needing to adapt an upgrade script.

  An easy site admin tool would be beneficial as this query had come up
  recently a few times and many Mahara instances will need to move from
  http to https and change links so that there aren't any mixed-content
  warnings.

  For more info, please see
  https://mahara.org/interaction/forum/topic.php?id=8031#post32261

  See bug #1717380 for the query around relative vs. absolute paths.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1717379/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1714432] Re: Display group files of active group first when adding blocks in group page

2018-03-07 Thread Robert Lyon
>From looking at the code / testing - the selected tab corresponds to the owner 
>of the page, eg:
- owned by group the 'group' tab is selected.
- owned by a user the user tab is selected.

Also according to the code / testing one can only select which group to
get a file from, eg populates the $selectedsubtab variable, if the page
is owned by a user

I suspect this original reporter may have been editing a user's page and
not a group page

** Changed in: mahara
Milestone: 18.04.0 => None

** Changed in: mahara
   Status: Confirmed => Incomplete

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1714432

Title:
  Display group files of active group first when adding blocks in group
  page

Status in Mahara:
  Incomplete

Bug description:
  When adding an existing image (or file) to a group page the default
  workflow has poor usability.

  Actual:
  The file browser starts at the user's own personal files. Once this is 
switched to group files it even more confusingly defaults to the first group 
alphabetically that they user is a member of, but that isn't clear - you then 
need to click on the groups dropdown menu to select which group you want to 
choose a file from.

  Expected:
  When browsing for a file to add to a group page the initial default should be 
the file repository for that group - the user can then change this if they want 
to use a file from elsewhere but this should be the starting point.

  Tested on 17.04.3testing but exists in earlier versions.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1714432/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1722861] Re: Institution tags

2018-03-07 Thread Robert Lyon
** Changed in: mahara
Milestone: 18.04.0 => 18.10.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1722861

Title:
  Institution tags

Status in Mahara:
  Confirmed

Bug description:
  We have a client who has a requirement to define and manage a set of
  institutional tags which members can use for tagging portfolio
  content.

  These tags must be:
  - configured disabled per institution by default with the ability to enable
  - only visible and selectable by institutional members
  - clearly identifiable as institutional tags when selecting and filtering
  -- and which institution if the user belongs to multiple using this feature
  - non-editable by members outside of the institutional tag management screens

  It is believed that this feature would make a good addition to Mahara
  core and could be extended in the future to helping with other
  features such as SmartEvidence classifications etc.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1722861/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1272122] A change has been merged

2018-03-07 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/7587
Committed: 
https://git.mahara.org/mahara/mahara/commit/353e4105625ebe188ab17c7c207264b972f17e71
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master

commit 353e4105625ebe188ab17c7c207264b972f17e71
Author: Robert Lyon 
Date:   Fri Dec 23 15:33:22 2016 +1300

Bug 1272122: Add image rotator to the filebrowser edit item form

behatnotneeded

Change-Id: I7fb2fa618719dd12d6b77177a9e1ad127ea175d2
Signed-off-by: Robert Lyon 

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1272122

Title:
  Rotate images

Status in Mahara:
  Fix Committed

Bug description:
  A teacher on MyPortfolio.school.nz said it would be great to be able
  to rotate images once uploaded to Mahara because when kids upload
  photos from mobile devices, they may not have the correct orientation.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1272122/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1272122] Re: Rotate images

2018-03-07 Thread Robert Lyon
** Changed in: mahara
   Status: In Progress => Fix Committed

** Changed in: mahara
Milestone: None => 18.10.0

** Changed in: mahara
Milestone: 18.10.0 => 18.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1272122

Title:
  Rotate images

Status in Mahara:
  Fix Committed

Bug description:
  A teacher on MyPortfolio.school.nz said it would be great to be able
  to rotate images once uploaded to Mahara because when kids upload
  photos from mobile devices, they may not have the correct orientation.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1272122/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1396321] Re: Allow certain registration information to be public

2018-03-07 Thread Robert Lyon
** Changed in: mahara
Milestone: 18.04.0 => 18.10.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1396321

Title:
  Allow certain registration information to be public

Status in Mahara:
  Confirmed

Bug description:
  Mahara instances can decide whether they want to register with the
  Mahara project or not. Currently, the stats that are collected are
  only visible to the Mahara core project team as we do not ask site
  admins permission to make them available more widely to the community
  like for example Moodle: http://moodle.net/stats/

  We should be changing that with the next release and ask permission to
  make certain information available anonymously to the entire
  community. We shouldn't make all the information available that we
  collect, but just the most high level ones like

  - Geographical location of the registered site
  - The site name and URL itself like on http://moodle.net/sites/
  - Number of registered users
  - Version of Mahara used (unless we decide it's a security risk)
  - Number of pages created (could be beneficial to see how active users are on 
the site; ideally excl. dashboards, profile pages and group homepages)

  The information that is shared publicly anonymously with others should
  be highlighted when you review what information is sent when
  registering the site.

  When we make that change, I think we should reset the registration
  checkbox for sites that had it set to give them the chance to review
  the setting and make a conscious decision about registering as it's
  kinda like accepting new Terms and Conditions.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1396321/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1576074] Re: Adopt PSR-2 for our PHP code format

2018-03-07 Thread Robert Lyon
** Changed in: mahara
Milestone: 18.04.0 => None

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1576074

Title:
  Adopt PSR-2 for our PHP code format

Status in Mahara:
  Confirmed

Bug description:
  Currently Mahara has its own idiosyncratic code formatting guidelines:
  https://wiki.mahara.org/wiki/Developer_Area/Coding_guidelines

  It would make things easier for new devs, and improve tool support, if
  we switched to the industry standard PSR-2: http://www.php-
  fig.org/psr/psr-2/

  It would also be good to decide on a Javascript coding standard.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1576074/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1638128] Re: Delete the "resized" dataroot dirs on clear_all_caches()

2018-03-07 Thread Robert Lyon
** Changed in: mahara
   Status: Confirmed => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1638128

Title:
  Delete the "resized" dataroot dirs on clear_all_caches()

Status in Mahara:
  Fix Committed

Bug description:
  We have a form on admin index page to clear caches within Mahara
  system.

  It would be nice to be able to add the clearing of file/resized/ and
  file/profileicons/resized/ from the dataroot as well.

  This would be useful for testing / debugging purposes when one is
  chopping and changing databases

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1638128/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1681573] Re: Allow inline SVG support

2018-03-07 Thread Robert Lyon
** Changed in: mahara
Milestone: 18.04.0 => 18.10.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1681573

Title:
  Allow inline SVG support

Status in Mahara:
  Confirmed

Bug description:
  In bug #1681571 the support for uploading of SVG is going to be
  implemented. This is a follow-on wishlist item to also allow inline
  SVG so the SVG properties can be changed directly in Mahara.

  This can take a couple of different forms:

  1. In a text box (anywhere there is TinyMCE): Tick a box / flip a
  switch to activate inline SVG and then see the SVG properties in the
  pop-up so  people don't have to go to the text box source.

  2. If we also allow the manipulation in an image block add the SVG
  properties there once inline SVG is activated.

  I would think that the SVG properties manipulation should probably not
  happen in the file browser itself as you could upload a black SVG and
  then use it as a white one in one page and a red one in another. If we
  allow for the changing of the SVG properties in the file browser, we
  could only save one version rather than use both.

  In reveal.js (at least via slides.com) I can activate the inline SVG
  version for images directly on a slide and then go into the source to
  make changes, but I'm not saving those changes with the file itself,
  but just in the slide properties so I'm more flexible with the file in
  other contexts.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1681573/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1681571] Re: Allow upload of SVG to use in portfolio pages

2018-03-07 Thread Robert Lyon
** Changed in: mahara
Milestone: 18.04.0 => 18.10.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1681571

Title:
  Allow upload of SVG to use in portfolio pages

Status in Mahara:
  Confirmed

Bug description:
  All modern browsers support SVG and so should we in Mahara. Currently,
  you can't upload them to an image block because the format is not
  recognized.

  Bug #1681573 deals with the support for inline SVG for easy
  manipulation as a follow-on wishlist item.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1681571/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1700879] Re: Allow the upload of a logo as SVG file

2018-03-07 Thread Robert Lyon
** Changed in: mahara
Milestone: 18.04.0 => 18.10.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1700879

Title:
  Allow the upload of a logo as SVG file

Status in Mahara:
  Confirmed

Bug description:
  In bug #1681579 we allow the use of an SVG file as logo in a Mahara
  theme. It should also be possible to upload an SVG file as logo
  through the front-end.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1700879/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1711497] Re: Is htdocs/view/urls.php still needed?

2018-03-07 Thread Robert Lyon
The short answer is yes it is - when one is coming from the "Shared by
me" page

** Changed in: mahara
Milestone: 18.04.0 => None

** Changed in: mahara
   Status: Confirmed => Invalid

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1711497

Title:
  Is htdocs/view/urls.php still needed?

Status in Mahara:
  Invalid

Bug description:
  When we added the patch https://reviews.mahara.org/#/c/7453/11 we
  added a new file called htdocs/view/accessurl.php which seems very
  similar to htdocs/view/urls.php

  And from my initial looking it doesn't seem to be used anymore
  Do we still need it?

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1711497/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1434316] Re: Why two pieform directories?

2018-03-07 Thread Robert Lyon
** Changed in: mahara
Milestone: 18.04.0 => 18.10.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1434316

Title:
  Why two pieform directories?

Status in Mahara:
  Confirmed

Bug description:
  Currently the basic pieform elements information lives in:

  htdocs/lib/pieforms/pieform/

  but there are also pieform elements that live in
  htdocs/lib/forms/

  Why do we need to have them in two places?

  I can imagine that there might have been a reason to keep the pieform
  plugin separate from custom pieform elements but seeing as mahara
  pieform is really a fork of the original this seperation is not needed
  within mahara.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1434316/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1037365] Re: some third party libraries do not respect the directorypermissions config setting

2018-03-07 Thread Robert Lyon
** Changed in: mahara
Milestone: 18.04.0 => 18.10.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1037365

Title:
  some third party libraries do not respect the directorypermissions
  config setting

Status in Mahara:
  Confirmed

Bug description:
  one example is htmlpurifier, from a git grep mkdir, i see that pear,
  dwoo, adobdb, and flowplayer may also be culprits

  Also, the internal examples
  - extract function in artefact/file.lib.php
  - copyr function in lib/file.php
  - there is one instance in lib/db/upgrade.php

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1037365/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1519989] Re: Refactor duplicate collections access code in index.php & index.json.php

2018-03-07 Thread Robert Lyon
** Changed in: mahara
Milestone: 18.04.0 => 18.10.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1519989

Title:
  Refactor duplicate collections access code in index.php &
  index.json.php

Status in Mahara:
  Confirmed

Bug description:
  After patch https://reviews.mahara.org/#/c/5695/6 for Bug1514374,
  we've now got duplicate code it htdocs/collection/index.php and
  htdocs/collection/index.json.php, for checking whether the user has
  access to the particular collections they're trying to look at.

  This kind of duplication stands a high likelihood of falling out of
  sync if changes are made to the access code in the future, so we
  should abstract it out into a common access method that gets called by
  both scripts.

  The code is not *exactly* the same in both places. index.php
  intersperses it with code to set the menu headers, and index.json.php
  sends an error via json_reply on failure, while index.php throws an
  AccessDeniedException(). So it will require a little bit of thinking
  to do it. But it's not impossible.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1519989/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1612464] Re: Cleanup of embedded images code

2018-03-07 Thread Robert Lyon
As there is no info about what is brittle I will mark won't fix

** Changed in: mahara
   Status: Confirmed => Won't Fix

** Changed in: mahara
Milestone: 18.04.0 => None

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1612464

Title:
  Cleanup of embedded images code

Status in Mahara:
  Won't Fix

Bug description:
  While working on Bug 1612451 I noticed some brittle code in the
  embedded images library, that could use a reworking.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1612464/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1713976] Re: Page edit not work on php7.1.8, need to downgrade to php7.0.22

2018-03-07 Thread Robert Lyon
** Changed in: mahara
Milestone: 18.04.0 => 18.10.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1713976

Title:
  Page edit not work on php7.1.8, need to downgrade to php7.0.22

Status in Mahara:
  Incomplete

Bug description:
  Page edit function is not work on php7.1.8,

  the edit function work again after I change to php7.0.22.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1713976/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1742354] A patch has been submitted for review

2018-03-07 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/8594

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1742354

Title:
  missing help file Site options/Account settings

Status in Mahara:
  In Progress

Bug description:
  As a site admin user, in Site options-> account settings -> Override user 
account lifetime
  when clicking the 'i' icon to get help info, we get an error "An error 
occurred trying to retrieve the help page."

  This happens because the
  htdocs/lang/en.utf8/help/forms/siteoptions.defaultaccountlifetimeupdate.html
  that contains the help description is missing.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1742354/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1742354] Re: missing help file Site options/Account settings

2018-03-07 Thread Robert Lyon
Yeah it was an oversight when I made the patch - I suspect I
copied/pasted from another setting that had help = true

It doesn't need the help icon so will remove

** Changed in: mahara
   Status: Confirmed => In Progress

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1742354

Title:
  missing help file Site options/Account settings

Status in Mahara:
  In Progress

Bug description:
  As a site admin user, in Site options-> account settings -> Override user 
account lifetime
  when clicking the 'i' icon to get help info, we get an error "An error 
occurred trying to retrieve the help page."

  This happens because the
  htdocs/lang/en.utf8/help/forms/siteoptions.defaultaccountlifetimeupdate.html
  that contains the help description is missing.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1742354/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1742590] Re: Text/Note/Annotation Maxlength rule is unnecessary

2018-03-07 Thread Robert Lyon
** Changed in: mahara
Milestone: 18.04.0 => 18.10.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1742590

Title:
  Text/Note/Annotation Maxlength rule is unnecessary

Status in Mahara:
  Confirmed

Bug description:
  Mahara: 17.10.1
  OS: Ubuntu 16.04
  DB: Postgres
  Browser: FF

  When inserting a base-64 encoded image into a comment on a form, the
  user is presented with the following error:

  'This field must be 8192 characters long.'

  This rule validation is not really required because the DB field that
  it inserting into is a 'Text' type. Which basically means it's almost
  unlimited.

  Postgres 7.1+ does have an upper limit at 1 Gb for a Text field.
  Mahara supports Postgres 9+.

  I do think it's safe to remove the maxlength rule for the Text, Note
  and Annoation fields.

  Please let me know your thoughts.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1742590/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1724743] Re: SAML metadata page shouldn't redirect to main page when a site is in maintenance mode

2018-03-07 Thread Robert Lyon
Actually we should just allow the public metadata page to be accessible
when in maintenance mode as that will be the easier fix

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1724743

Title:
  SAML metadata page shouldn't redirect to main page when a site is in
  maintenance mode

Status in Mahara:
  In Progress

Bug description:
  SAML metadata page  /auth/saml/sp/metadata.php shouldn't redirect to
  main page when a site is in maintenance mode. Ideally, it should send
  503 HTTP response to let systems who read the metadata know, that the
  file is not accessible.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1724743/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1737451] Re: Files to download block has files link to metadata page causing confusion

2018-03-07 Thread Robert Lyon
** Changed in: mahara
   Status: Confirmed => Won't Fix

** Changed in: mahara
Milestone: 18.04.0 => None

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1737451

Title:
  Files to download block has files link to metadata page causing
  confusion

Status in Mahara:
  Won't Fix

Bug description:
  A row in the files to download block have both

  Reasons to allow link to metadata page:
  - Show user what metadata exists for this item, including license info

  Reasons not to allow link to metadata page:
  - Avoid confusion
  - Stop one commenting on artefact outside normal context

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1737451/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1724743] A patch has been submitted for review

2018-03-07 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/8593

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1724743

Title:
  SAML metadata page shouldn't redirect to main page when a site is in
  maintenance mode

Status in Mahara:
  In Progress

Bug description:
  SAML metadata page  /auth/saml/sp/metadata.php shouldn't redirect to
  main page when a site is in maintenance mode. Ideally, it should send
  503 HTTP response to let systems who read the metadata know, that the
  file is not accessible.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1724743/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1724743] Re: SAML metadata page shouldn't redirect to main page when a site is in maintenance mode

2018-03-07 Thread Robert Lyon
** Changed in: mahara
   Status: Confirmed => In Progress

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1724743

Title:
  SAML metadata page shouldn't redirect to main page when a site is in
  maintenance mode

Status in Mahara:
  In Progress

Bug description:
  SAML metadata page  /auth/saml/sp/metadata.php shouldn't redirect to
  main page when a site is in maintenance mode. Ideally, it should send
  503 HTTP response to let systems who read the metadata know, that the
  file is not accessible.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1724743/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1714082] Re: The user's primary email address is not checked in a case insensitive way

2018-03-07 Thread Robert Lyon
** Changed in: mahara
Milestone: 18.04.0 => 18.10.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1714082

Title:
  The user's primary email address is not checked in a case insensitive
  way

Status in Mahara:
  Confirmed

Bug description:
  Currently you can create 2 users, via the Admin -> Users -> Add user
  screen, with this:

  username: Test one   email: us...@example.com
  username: Test two   email: us...@example.com

  but not another user with

  username: Test three   email: us...@example.com

  As it complains the email address 'us...@example.com' is used

  However, with email addresses the domain part is case insensitive and
  only the username part is case sensitive - yet saying that most email
  servers treat the username part also as case insensitive to avoid
  email delivery confusion - see https://www.lifewire.com/are-email-
  addresses-case-sensitive-117

  To also avoid confusion within Mahara we should limit the primary
  email address to be case insensitive unique.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1714082/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1703262] Re: Deleting group journal entry for non-admin users

2018-03-07 Thread Robert Lyon
*** This bug is a duplicate of bug 1752442 ***
https://bugs.launchpad.net/bugs/1752442

Fix in 1752442

** This bug has been marked a duplicate of bug 1752442
   Problems with group forums / topics

** Changed in: mahara
Milestone: 18.04.0 => None

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1703262

Title:
  Deleting group journal entry for non-admin users

Status in Mahara:
  Confirmed

Bug description:
  Mahara: 16.10.4
  DB: Postgres
  OS: Linux
  Browser: any

  Related to bug #1666102 (group member can delete journal).

  When a non-admin group member tries to delete a group journal's
  entries (i.e. not the whole journal), the page displays delete buttons
  next to the entry. But, in actual fact, the entries cannot be deleted
  (which is correct behaviour). This could make users confused. Please
  see attached screen shot.

  Perhaps don't display the delete button for users who cannot perform
  this action. Or, display page "Access denied... You do not have
  access" (as currently happens when trying to delete the whole
  journal).

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1703262/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1689312] Re: New username isn't checked for spaces when added to LDAP

2018-03-07 Thread Robert Lyon
** Changed in: mahara
Milestone: 18.04.0 => 18.10.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1689312

Title:
  New username isn't checked for spaces when added to LDAP

Status in Mahara:
  Confirmed

Bug description:
  Mahara version: 16.10.3

  When adding a new user, if you select an institution/authentication
  method with LDAP, the usersame is not being checked for
  leading/trailing spaces, and it isn't trimmed before being added to
  the database. Users can be created with usernames like " newuser ".

  If you try to do this with a non LDAP authentication method, it thows
  an error and will not continue (although the error message does not
  highlight the username field as the source of the error in this case).

  I've fixed it locally with trim() around the username value before
  it's put into the databse.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1689312/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1599414] Re: New composer-managed SimpleSAML breaks PHPUnit tests.

2018-03-07 Thread Robert Lyon
** Changed in: mahara
Milestone: 18.04.0 => 18.10.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1599414

Title:
  New composer-managed SimpleSAML breaks PHPUnit tests.

Status in Mahara:
  Confirmed

Bug description:
  While writing a PHPUnit test for one of my patches, I noticed that the
  new composer-managed SimpleSAML, if present, breaks "make phpunit",
  because it contains some phpunit tests that get detected but are
  lacking the proper stuff to make them run correctly.

  To replicate:

  1. Install the SimpleSAMLPHP library by doing "make ssphp"
  2. Run phpunit tests by doing "make phpunit"

  Expected result: tests run with no failures
  Actual result: Tests fail out with this error message

  PHP Fatal error:  Class 'SimpleSAML_Auth_ProcessingFilter' not found in 
/home/aaronw/www/mahara/htdocs/auth/saml/extlib/simplesamlphp/modules/exampleauth/lib/Auth/Process/RedirectTest.php
 on line 7
  PHP Stack trace:
  PHP   1. {main}() 
/home/aaronw/www/mahara/external/vendor/phpunit/phpunit/composer/bin/phpunit:0
  PHP   2. PHPUnit_TextUI_Command::main() 
/home/aaronw/www/mahara/external/vendor/phpunit/phpunit/composer/bin/phpunit:63
  PHP   3. PHPUnit_TextUI_Command->run() 
/home/aaronw/www/mahara/external/vendor/phpunit/phpunit/PHPUnit/TextUI/Command.php:129
  PHP   4. PHPUnit_Runner_BaseTestRunner->getTest() 
/home/aaronw/www/mahara/external/vendor/phpunit/phpunit/PHPUnit/TextUI/Command.php:150
  PHP   5. PHPUnit_Framework_TestSuite->addTestFiles() 
/home/aaronw/www/mahara/external/vendor/phpunit/phpunit/PHPUnit/Runner/BaseTestRunner.php:96
  PHP   6. PHPUnit_Framework_TestSuite->addTestFile() 
/home/aaronw/www/mahara/external/vendor/phpunit/phpunit/PHPUnit/Framework/TestSuite.php:416
  PHP   7. PHPUnit_Util_Fileloader::checkAndLoad() 
/home/aaronw/www/mahara/external/vendor/phpunit/phpunit/PHPUnit/Framework/TestSuite.php:355
  PHP   8. PHPUnit_Util_Fileloader::load() 
/home/aaronw/www/mahara/external/vendor/phpunit/phpunit/PHPUnit/Util/Fileloader.php:76
  PHP   9. include_once() 
/home/aaronw/www/mahara/external/vendor/phpunit/phpunit/PHPUnit/Util/Fileloader.php:92

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1599414/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1680633] Re: Cron job metadata

2018-03-07 Thread Robert Lyon
** Changed in: mahara
Milestone: 18.04.0 => 18.10.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1680633

Title:
  Cron job metadata

Status in Mahara:
  Confirmed

Bug description:
  Hello,

  Currently the meta data stored for cron jobs is fairly limited having only 
the following fields:
  
  
  
  
  
  
  
  
  
  
  

  We are implementing a plugin for Mahara that will mirror the cron
  check functionality present in this Moodle plugin:
  https://github.com/brendanheywood/moodle-tool_heartbeat.

  It would be beneficial if Mahara included two new fields in the cron
  and the plugintype_cron tables:

  1. lastruntime - the last runtime of the cron job.

  Currently on /admin/statistics.php the following sql is used to determine if 
cron has run.
  record_exists_select('cron', 'nextrun IS NULL OR nextrun < CURRENT_DATE') - 
from a monitoring standpoint this is not acceptable as it will give false 
positives/negatives depending on the situation. With this change, the max 
lastruntime could be used to determine if cron had run recently.

  2. faildelay - An Exponentially increasing fail delay that is updated
  when the cron job fails (if it throws an exception). This way if there
  is a consistently failing cron job its execution is throttled and its
  failure is being tracked in some way aside from just logging an error.
  The heartbeat plugin above uses this to help us to identify and fix
  issues that would otherwise go undetected.

  Aside from the benefits from a monitoring perspective, these fields
  provide useful information when it comes to debugging anything cron
  related.

  I'm happy to discuss at any time and more than happy to do the dev on
  this. Ill be floating around the Mahara IRC under the kenH handle if
  you would like to talk at any time.

  Thanks,
  Kenneth

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1680633/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1731067] A patch has been submitted for review

2018-03-07 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/8591

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1731067

Title:
  Some cron jobs cause elasticsearch queue to populate when it doesn't
  need to

Status in Mahara:
  In Progress

Bug description:
  We only record certain information in elasticsearch but we queue
  things even if unrecorded information changes because we use
  triggers/procedures on the tables

  Example, when the recalculate_quota cron runs it works out what the
  user quota should be and then updates all the users in usr table that
  need fixing. This table has a trigger on it so all users needing
  updating are added to queue to be indexed.

  On a big site that can mean thousands of users being indexed. But we
  don't record quota in elasticsearch so we don't need to index this
  change.

  It would be good to be able to drop/add elasticsearch triggers during
  cron process for certain cron jobs like we do in upgrade.php script

  eg:
drop_elasticsearch_triggers();
... do cron job ...
create_elasticsearch_triggers();

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1731067/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1594192] Re: Leap2a: Importing a file artefact has failed

2018-03-07 Thread Robert Lyon
** Changed in: mahara
   Status: Confirmed => In Progress

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1594192

Title:
  Leap2a: Importing a file artefact has failed

Status in Mahara:
  In Progress

Bug description:
  Version: master (16.10), 16.04, 15.10

  For some reasons, the attribute mtime of a file artefact in a leap2a
  file is empty. This cause the following error when import it.

  [WAR] fc (lib/errors.php:796) Failed to get a recordset: postgres8 error: 
[-1: ERROR:  invalid input syntax for type timestamp: ""] in adodb_throw(UPDATE 
"artefact" SET "artefacttype" = ? , "container" = ? , "parent" = ? , "owner" = 
? , "institution" = ? , "group" = ? , "ctime" = ? , "mtime" = ? , "atime" = ? , 
"locked" = ? , "title" = ? , "description" = ? , "note" = ? , "author" = ? , 
"authorname" = ? , "allowcomments" = ? , "approvecomments" = ? , "license" = ? 
, "licensor" = ? , "licensorurl" = ? , "path" = ?  WHERE "id" = ? , 
file,0,60,1,,,2016-06-2010:17:24,,2016-06-2010:17:24,0,MasterofEducationtranscript,,,1,,0,0/60/61,61),
 referer: 
http://192.168.2.47:8080/mahara/master/htdocs/import/index.php?action=1
  [Mon Jun 20 10:17:24.948612 2016] [:error] [pid 11881] [client 
192.168.2.47:33369] [WAR] fc (lib/errors.php:796) Command was: UPDATE 
"artefact" SET "artefacttype" = ? , "container" = ? , "parent" = ? , "owner" = 
? , "institution" = ? , "group" = ? , "ctime" = ? , "mtime" = ? , "atime" = ? , 
"locked" = ? , "title" = ? , "description" = ? , "note" = ? , "author" = ? , 
"authorname" = ? , "allowcomments" = ? , "approvecomments" = ? , "license" = ? 
, "licensor" = ? , "licensorurl" = ? , "path" = ?  WHERE "id" = ?  and values 
was 
(0:file,1:0,2:60,3:1,4:,5:,6:2016-06-2010:17:24,7:,8:2016-06-2010:17:24,9:0,10:MasterofEducationtranscript,11:,12:,13:1,14:,15:0,16:0,17:,18:,19:,20:/60/61,21:61),
 referer: 
http://192.168.2.47:8080/mahara/master/htdocs/import/index.php?action=1
  [Mon Jun 20 10:17:24.948629 2016] [:error] [pid 11881] [client 
192.168.2.47:33369] Call stack (most recent first):, referer: 
http://192.168.2.47:8080/mahara/master/htdocs/import/index.php?action=1
  [Mon Jun 20 10:17:24.948633 2016] [:error] [pid 11881] [client 
192.168.2.47:33369]   * log_message("Failed to get a recordset: postgres8 
error: [-1: E...", 8, true, true) at 
/var/www/html/mahara/master/htdocs/lib/errors.php:95, referer: 
http://192.168.2.47:8080/mahara/master/htdocs/import/index.php?action=1
  [Mon Jun 20 10:17:24.948638 2016] [:error] [pid 11881] [client 
192.168.2.47:33369]   * log_warn("Failed to get a recordset: postgres8 error: 
[-1: E...") at /var/www/html/mahara/master/htdocs/lib/errors.php:796, referer: 
http://192.168.2.47:8080/mahara/master/htdocs/import/index.php?action=1
  [Mon Jun 20 10:17:24.948642 2016] [:error] [pid 11881] [client 
192.168.2.47:33369]   * SQLException->__construct("Failed to get a recordset: 
postgres8 error: [-1: E...") at 
/var/www/html/mahara/master/htdocs/lib/dml.php:1302, referer: 
http://192.168.2.47:8080/mahara/master/htdocs/import/index.php?action=1
  [Mon Jun 20 10:17:24.948646 2016] [:error] [pid 11881] [client 
192.168.2.47:33369]   * update_record("artefact", object(stdClass), "id") at 
/var/www/html/mahara/master/htdocs/artefact/lib.php:628, referer: 
http://192.168.2.47:8080/mahara/master/htdocs/import/index.php?action=1
  [Mon Jun 20 10:17:24.948649 2016] [:error] [pid 11881] [client 
192.168.2.47:33369]   * ArtefactType->commit() at 
/var/www/html/mahara/master/htdocs/artefact/file/lib.php:1062, referer: 
http://192.168.2.47:8080/mahara/master/htdocs/import/index.php?action=1
  [Mon Jun 20 10:17:24.948653 2016] [:error] [pid 11881] [client 
192.168.2.47:33369]   * ArtefactTypeFile->commit() at 
/var/www/html/mahara/master/htdocs/artefact/file/import/leap/lib.php:499, 
referer: http://192.168.2.47:8080/mahara/master/htdocs/import/index.php?action=1
  [Mon Jun 20 10:17:24.948657 2016] [:error] [pid 11881] [client 
192.168.2.47:33369]   * 
LeapImportFile::create_file_from_entry_data(object(stdClass), 
object(PluginImportLeap), "portfolio:artefact148") at 
/var/www/html/mahara/master/htdocs/artefact/file/import/leap/lib.php:421, 
referer: http://192.168.2.47:8080/mahara/master/htdocs/import/index.php?action=1
  [Mon Jun 20 10:17:24.948661 2016] [:error] [pid 11881] [client 
192.168.2.47:33369]   * 
LeapImportFile::create_file_from_request(object(PluginImportLeap), 
object(stdClass), 60) at 
/var/www/html/mahara/master/htdocs/artefact/file/import/leap/lib.php:94, 
referer: http://192.168.2.47:8080/mahara/master/htdocs/import/index.php?action=1
  [Mon Jun 20 10:17:24.948667 2016] [:error] [pid 11881] [client 
192.168.2.47:33369]   * 
LeapImportFile::import_from_requests(object(PluginImportLeap)) at 

[Mahara-contributors] [Bug 1594192] A patch has been submitted for review

2018-03-07 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/8590

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1594192

Title:
  Leap2a: Importing a file artefact has failed

Status in Mahara:
  In Progress

Bug description:
  Version: master (16.10), 16.04, 15.10

  For some reasons, the attribute mtime of a file artefact in a leap2a
  file is empty. This cause the following error when import it.

  [WAR] fc (lib/errors.php:796) Failed to get a recordset: postgres8 error: 
[-1: ERROR:  invalid input syntax for type timestamp: ""] in adodb_throw(UPDATE 
"artefact" SET "artefacttype" = ? , "container" = ? , "parent" = ? , "owner" = 
? , "institution" = ? , "group" = ? , "ctime" = ? , "mtime" = ? , "atime" = ? , 
"locked" = ? , "title" = ? , "description" = ? , "note" = ? , "author" = ? , 
"authorname" = ? , "allowcomments" = ? , "approvecomments" = ? , "license" = ? 
, "licensor" = ? , "licensorurl" = ? , "path" = ?  WHERE "id" = ? , 
file,0,60,1,,,2016-06-2010:17:24,,2016-06-2010:17:24,0,MasterofEducationtranscript,,,1,,0,0/60/61,61),
 referer: 
http://192.168.2.47:8080/mahara/master/htdocs/import/index.php?action=1
  [Mon Jun 20 10:17:24.948612 2016] [:error] [pid 11881] [client 
192.168.2.47:33369] [WAR] fc (lib/errors.php:796) Command was: UPDATE 
"artefact" SET "artefacttype" = ? , "container" = ? , "parent" = ? , "owner" = 
? , "institution" = ? , "group" = ? , "ctime" = ? , "mtime" = ? , "atime" = ? , 
"locked" = ? , "title" = ? , "description" = ? , "note" = ? , "author" = ? , 
"authorname" = ? , "allowcomments" = ? , "approvecomments" = ? , "license" = ? 
, "licensor" = ? , "licensorurl" = ? , "path" = ?  WHERE "id" = ?  and values 
was 
(0:file,1:0,2:60,3:1,4:,5:,6:2016-06-2010:17:24,7:,8:2016-06-2010:17:24,9:0,10:MasterofEducationtranscript,11:,12:,13:1,14:,15:0,16:0,17:,18:,19:,20:/60/61,21:61),
 referer: 
http://192.168.2.47:8080/mahara/master/htdocs/import/index.php?action=1
  [Mon Jun 20 10:17:24.948629 2016] [:error] [pid 11881] [client 
192.168.2.47:33369] Call stack (most recent first):, referer: 
http://192.168.2.47:8080/mahara/master/htdocs/import/index.php?action=1
  [Mon Jun 20 10:17:24.948633 2016] [:error] [pid 11881] [client 
192.168.2.47:33369]   * log_message("Failed to get a recordset: postgres8 
error: [-1: E...", 8, true, true) at 
/var/www/html/mahara/master/htdocs/lib/errors.php:95, referer: 
http://192.168.2.47:8080/mahara/master/htdocs/import/index.php?action=1
  [Mon Jun 20 10:17:24.948638 2016] [:error] [pid 11881] [client 
192.168.2.47:33369]   * log_warn("Failed to get a recordset: postgres8 error: 
[-1: E...") at /var/www/html/mahara/master/htdocs/lib/errors.php:796, referer: 
http://192.168.2.47:8080/mahara/master/htdocs/import/index.php?action=1
  [Mon Jun 20 10:17:24.948642 2016] [:error] [pid 11881] [client 
192.168.2.47:33369]   * SQLException->__construct("Failed to get a recordset: 
postgres8 error: [-1: E...") at 
/var/www/html/mahara/master/htdocs/lib/dml.php:1302, referer: 
http://192.168.2.47:8080/mahara/master/htdocs/import/index.php?action=1
  [Mon Jun 20 10:17:24.948646 2016] [:error] [pid 11881] [client 
192.168.2.47:33369]   * update_record("artefact", object(stdClass), "id") at 
/var/www/html/mahara/master/htdocs/artefact/lib.php:628, referer: 
http://192.168.2.47:8080/mahara/master/htdocs/import/index.php?action=1
  [Mon Jun 20 10:17:24.948649 2016] [:error] [pid 11881] [client 
192.168.2.47:33369]   * ArtefactType->commit() at 
/var/www/html/mahara/master/htdocs/artefact/file/lib.php:1062, referer: 
http://192.168.2.47:8080/mahara/master/htdocs/import/index.php?action=1
  [Mon Jun 20 10:17:24.948653 2016] [:error] [pid 11881] [client 
192.168.2.47:33369]   * ArtefactTypeFile->commit() at 
/var/www/html/mahara/master/htdocs/artefact/file/import/leap/lib.php:499, 
referer: http://192.168.2.47:8080/mahara/master/htdocs/import/index.php?action=1
  [Mon Jun 20 10:17:24.948657 2016] [:error] [pid 11881] [client 
192.168.2.47:33369]   * 
LeapImportFile::create_file_from_entry_data(object(stdClass), 
object(PluginImportLeap), "portfolio:artefact148") at 
/var/www/html/mahara/master/htdocs/artefact/file/import/leap/lib.php:421, 
referer: http://192.168.2.47:8080/mahara/master/htdocs/import/index.php?action=1
  [Mon Jun 20 10:17:24.948661 2016] [:error] [pid 11881] [client 
192.168.2.47:33369]   * 
LeapImportFile::create_file_from_request(object(PluginImportLeap), 
object(stdClass), 60) at 
/var/www/html/mahara/master/htdocs/artefact/file/import/leap/lib.php:94, 
referer: http://192.168.2.47:8080/mahara/master/htdocs/import/index.php?action=1
  [Mon Jun 20 10:17:24.948667 2016] [:error] [pid 11881] [client 
192.168.2.47:33369]   * 
LeapImportFile::import_from_requests(object(PluginImportLeap)) at Unknown:0, 

[Mahara-contributors] [Bug 1606738] Re: Accessibility - Information icon and navigation to content in information overlay

2018-03-07 Thread Robert Lyon
** Changed in: mahara
Milestone: 18.04.0 => 18.10.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1606738

Title:
  Accessibility - Information icon and navigation to content in
  information overlay

Status in Mahara:
  Confirmed

Bug description:
  Mahara: master

  Information icons are appearing as h1 headers.

  Also, screen readers can't get to the content in the pop up dialog.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1606738/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1675233] Re: Youtube fullscreen not working in 'automatically retract' mode

2018-03-07 Thread Robert Lyon
** Changed in: mahara
Milestone: 18.04.0 => 18.10.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1675233

Title:
  Youtube fullscreen not working in 'automatically retract' mode

Status in Mahara:
  Confirmed

Bug description:
  Embedded Youtube videos with allowfullscreen etc. in the embed code
  work fine in fullscreen when retractable is set to 'No' or 'Yes',
  however, fullstreen is not available (allowed) if option
  'Automatically Retract' is chosen.

  I assume that this feature changes the wrapping code around the
  embedded content and disallows fullscreen somehow.

  Mahara version: 16.10
  Tested on Windows and Linux laptops with Firefox and Chrome.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1675233/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1574952] Re: Error with LEAP2A import

2018-03-07 Thread Robert Lyon
The error messages mentioned in this bug relate to the missing index 'error' - 
this problem was fixed as part of the bug 1684267
https://reviews.mahara.org/#/c/7656/5/htdocs/theme/raw/pieforms/adduser.php

As there is no other info / test leap2A file provided I'll close the bug

** Changed in: mahara
Milestone: 18.04.0 => None

** Changed in: mahara
   Status: Confirmed => Won't Fix

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1574952

Title:
  Error with LEAP2A import

Status in Mahara:
  Won't Fix

Bug description:
  I have a Mahara 15.10.1 installation running on php-5.3.5 and
  mysql-5.5.9 on a windows system  (its a demonstration/experimental
  system, not a production system)

  Creation of a user works OK.  I have had success with importing LEAP2A
  into an existing user.

  But I have another (larger) LEAP2A file which DOES NOT work, though
  the same LEAP2A file works find on a (Linux) production system.

  Partial error log of two scenarios are as follows ... suggestions
  welcome.

  Attempting to add user via LEAP2A import

  [Mon Apr 25 21:29:06 2016] [error] [client 127.0.0.1] [WAR] 2a 
(theme\\raw\\pieforms\\adduser.php:19) Undefined index: error, referer: 
http://localhost/mahara/admin/users/search.php
  [Mon Apr 25 21:29:06 2016] [error] [client 127.0.0.1] Call stack (most recent 
first):, referer: http://localhost/mahara/admin/users/search.php
  [Mon Apr 25 21:29:06 2016] [error] [client 127.0.0.1]   * 
log_message("Undefined index: error", 8, true, true, 
"C:\\ePortfolio\\www\\mahara\\theme\\raw\\pieforms\\adduse...", 19) at 
C:\\ePortfolio\\www\\mahara\\lib\\errors.php:441, referer: 
http://localhost/mahara/admin/users/search.php
  [Mon Apr 25 21:29:06 2016] [error] [client 127.0.0.1]   * error(8, "Undefined 
index: error", "C:\\ePortfolio\\www\\mahara\\theme\\raw\\pieforms\\adduse...", 
19, array(size 10)) at 
C:\\ePortfolio\\www\\mahara\\theme\\raw\\pieforms\\adduser.php:19, referer: 
http://localhost/mahara/admin/users/search.php
  [Mon Apr 25 21:29:06 2016] [error] [client 127.0.0.1]   * 
require("C:\\ePortfolio\\www\\mahara\\theme\\raw\\pieforms\\adduse...") at 
C:\\ePortfolio\\www\\mahara\\lib\\pieforms\\pieform.php:756, referer: 
http://localhost/mahara/admin/users/search.php
  [Mon Apr 25 21:29:06 2016] [error] [client 127.0.0.1]   * Pieform->build() at 
C:\\ePortfolio\\www\\mahara\\lib\\pieforms\\pieform.php:169, referer: 
http://localhost/mahara/admin/users/search.php
  [Mon Apr 25 21:29:06 2016] [error] [client 127.0.0.1]   * 
Pieform::process(array(size 8)) at 
C:\\ePortfolio\\www\\mahara\\lib\\pieforms\\pieform.php:71, referer: 
http://localhost/mahara/admin/users/search.php
  [Mon Apr 25 21:29:06 2016] [error] [client 127.0.0.1]   * pieform(array(size 
8)) at C:\\ePortfolio\\www\\mahara\\admin\\users\\add.php:156, referer: 
http://localhost/mahara/admin/users/search.php
  [Mon Apr 25 21:29:06 2016] [error] [client 127.0.0.1] , referer: 
http://localhost/mahara/admin/users/search.php

  
  User added manually, LEAP2A then attempted to be imported

  [Mon Apr 25 21:35:14 2016] [error] [client 127.0.0.1] [WAR] 70 
(theme\\raw\\pieforms\\adduser.php:19) Undefined index: error, referer: 
http://localhost/mahara/admin/users/search.php
  [Mon Apr 25 21:35:14 2016] [error] [client 127.0.0.1] Call stack (most recent 
first):, referer: http://localhost/mahara/admin/users/search.php
  [Mon Apr 25 21:35:14 2016] [error] [client 127.0.0.1]   * 
log_message("Undefined index: error", 8, true, true, 
"C:\\ePortfolio\\www\\mahara\\theme\\raw\\pieforms\\adduse...", 19) at 
C:\\ePortfolio\\www\\mahara\\lib\\errors.php:441, referer: 
http://localhost/mahara/admin/users/search.php
  [Mon Apr 25 21:35:14 2016] [error] [client 127.0.0.1]   * error(8, "Undefined 
index: error", "C:\\ePortfolio\\www\\mahara\\theme\\raw\\pieforms\\adduse...", 
19, array(size 10)) at 
C:\\ePortfolio\\www\\mahara\\theme\\raw\\pieforms\\adduser.php:19, referer: 
http://localhost/mahara/admin/users/search.php
  [Mon Apr 25 21:35:14 2016] [error] [client 127.0.0.1]   * 
require("C:\\ePortfolio\\www\\mahara\\theme\\raw\\pieforms\\adduse...") at 
C:\\ePortfolio\\www\\mahara\\lib\\pieforms\\pieform.php:756, referer: 
http://localhost/mahara/admin/users/search.php
  [Mon Apr 25 21:35:14 2016] [error] [client 127.0.0.1]   * Pieform->build() at 
C:\\ePortfolio\\www\\mahara\\lib\\pieforms\\pieform.php:169, referer: 
http://localhost/mahara/admin/users/search.php
  [Mon Apr 25 21:35:14 2016] [error] [client 127.0.0.1]   * 
Pieform::process(array(size 8)) at 
C:\\ePortfolio\\www\\mahara\\lib\\pieforms\\pieform.php:71, referer: 
http://localhost/mahara/admin/users/search.php
  [Mon Apr 25 21:35:14 2016] [error] [client 127.0.0.1]   * pieform(array(size 
8)) at 

[Mahara-contributors] [Bug 1576075] Re: Namespaces and Autoloader

2018-03-07 Thread Robert Lyon
** Changed in: mahara
Milestone: 18.04.0 => 18.10.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1576075

Title:
  Namespaces and Autoloader

Status in Mahara:
  Confirmed

Bug description:
  Discussed at the 52nd developer meeting:
  https://wiki.mahara.org/wiki/Developer_Area/Developer_Meetings/52

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1576075/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1564715] Re: Change Mahara's content-sniffing to match the WHATWG standard

2018-03-07 Thread Robert Lyon
** Changed in: mahara
Milestone: 18.04.0 => 18.10.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1564715

Title:
  Change Mahara's content-sniffing to match the WHATWG standard

Status in Mahara:
  Confirmed

Bug description:
  WHATWG (Web Hypertext Application Technology Working Group) is
  basically the official specification organization for HTML5. They've
  written up some specifications about the correct & secure way that
  HTTP clients & servers ought to deal with file content types aka MIME
  types: https://mimesniff.spec.whatwg.org

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1564715/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1563641] Re: Rewrite "mixed content" URLs via an HTMLPurifier custom filter

2018-03-07 Thread Robert Lyon
** Changed in: mahara
Milestone: 18.04.0 => 18.10.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1563641

Title:
  Rewrite "mixed content" URLs via an HTMLPurifier custom filter

Status in Mahara:
  Confirmed

Bug description:
  "Mixed content" refers to the scenario where a web page is served via
  HTTPS, but it includes assets that are served via an HTTP URL. See
  https://developer.mozilla.org/en-US/docs/Security/Mixed_content for
  some discussion of this.

  In Bug 1463629 we fixed this issue for embedded iframes, by patching
  the HTMLPurifier core class HTMLPurifier_URIFilter_SafeIframe so that,
  in addition to filtering iframes for an allowed set of URLs, it also
  transformed them from HTTPS to HTTP if needed.

  After having recently done some work on HTMLPurifier for other bugs,
  and becoming more familiar with their API, it now becomes apparent to
  me that this was a bit of a hack (patching core code should have told
  me this anyway). What we should have done is, instead, write up a new
  custom URIFilter specifically for rewriting URI's from HTTP to HTTPS
  in this way, and used that instead.

  Doing it that way will make future HTMLPurifier upgrades easier, by
  eliminating the need to patch that file.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1563641/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1564117] Re: Refactor blocktype JS methods

2018-03-07 Thread Robert Lyon
** Changed in: mahara
Milestone: 18.04.0 => 18.10.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1564117

Title:
  Refactor blocktype JS methods

Status in Mahara:
  Confirmed

Bug description:
  Currently the PluginBlocktype abstract class has three methods for
  loading Javascript libraries, and invoking Javascript code to run when
  a block is loaded:

  1. PluginBlocktype::get_instance_javascript(BlockInstance $instance):
  Called when a block instance is displayed (either on the page in view
  mode, or the page in edit mode). Expects to return an array of sub-
  arrays where each sub-array has a "file" item, which is the relative
  path to a JS file (relative to the blocktype's root), and an optional
  "init" item, which is a snippet of code that gets executed once the
  "file" library has loaded. (It currently uses jQuery.getScript() to do
  this).

  2. PluginBlocktype::get_instance_inline_javascript(BlockInstance
  $instance): Called when a block instance is displayed (either on the
  page in view mode, or the page in edit mode). The code here is
  inserted into a 

[Mahara-contributors] [Bug 1450677] Re: A db_begin() db_commit() within lib/db/upgrade.php

2018-03-07 Thread Robert Lyon
** Changed in: mahara
   Status: Confirmed => Won't Fix

** Changed in: mahara
Milestone: 18.04.0 => None

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1450677

Title:
  A db_begin() db_commit() within lib/db/upgrade.php

Status in Mahara:
  Won't Fix

Bug description:
  But it should not be needed as the upgrade itself is wrapped in a
  db_begin / db_commit

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1450677/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1434312] Re: Pieform elements/renderers documentation

2018-03-07 Thread Robert Lyon
** Changed in: mahara
Milestone: 18.04.0 => 18.10.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1434312

Title:
  Pieform elements/renderers documentation

Status in Mahara:
  Confirmed

Bug description:
  Need to develop some useful documentation for the pieform
  elements/renderers

  Each element need to include at the top of the file a comment about
  what settings it uses and whether they are optional or not.

  Once we get each element/renderer file updated then we can collate the
  information on the wiki page:
  https://wiki.mahara.org/index.php/Developer_Area/Core_Subsystems/Form_API

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1434312/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1558830] Re: Set "URI.DefinitionID" and "URI.DefinitionRev" in HTMLPurifier

2018-03-07 Thread Robert Lyon
** Changed in: mahara
Milestone: 18.04.0 => 18.10.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1558830

Title:
  Set "URI.DefinitionID" and "URI.DefinitionRev" in HTMLPurifier

Status in Mahara:
  Confirmed

Bug description:
  While working on https://bugs.launchpad.net/mahara/+bug/1558387,
  Robert pointed out to me that we don't set URI.DefinitionRev. We also
  don't set URI.DefinitionID. Although the HTMLPurifier docs say that
  URI.DefinitionID is required if you have custom URIFilters (and our
  allowed iframe list is a custom URIFilter), it looks like the fallback
  behavior is that it generates a URI.DefinitionID based on a hash of
  the config. This has the effect that a new "Revision 1" URI config
  file is generated each time the allowed iframes list changes. It also
  results in an accumulation of old URI cache files in the
  dataroot/htmlpurifier directory, since they're all Revision 1, and all
  have different IDs.

  I think the best approach here is to give the URI.DefinitionRev its
  own revision number, stored in the database, and increment it every
  time we change the allowed iframe list.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1558830/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1422492] Re: Mahara doesn't ask you for your password before deleting your account or changing your username

2018-03-07 Thread Robert Lyon
** Changed in: mahara
   Status: Confirmed => In Progress

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1422492

Title:
  Mahara doesn't ask you for your password before deleting your account
  or changing your username

Status in Mahara:
  In Progress

Bug description:
  These, especially the first, seem like dangerous operations.

  Expected behavior is that Mahara would prompt for my current password
  to prevent someone deleting my user account if I left my account
  logged in.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1422492/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1528122] Re: Be able to decide whether to include or not feedback in Leap2A

2018-03-07 Thread Robert Lyon
** Changed in: mahara
Milestone: 18.04.0 => 18.10.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1528122

Title:
  Be able to decide whether to include or not feedback in Leap2A

Status in Mahara:
  Confirmed

Bug description:
  When you create an HTML export, you can decide whether to include
  feedback or not. However, when you create a Leap2A export, you do not
  have that option and feedback is now always included. Users should be
  able to have the choice like for HTML. At some point, feedback was
  added to the Leap2A export but without providing the option.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1528122/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1422492] A patch has been submitted for review

2018-03-07 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/8589

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1422492

Title:
  Mahara doesn't ask you for your password before deleting your account
  or changing your username

Status in Mahara:
  In Progress

Bug description:
  These, especially the first, seem like dangerous operations.

  Expected behavior is that Mahara would prompt for my current password
  to prevent someone deleting my user account if I left my account
  logged in.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1422492/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1513710] Re: Destructor methods that access global variables can cause crashes

2018-03-07 Thread Robert Lyon
** Changed in: mahara
Milestone: 18.04.0 => 18.10.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1513710

Title:
  Destructor methods that access global variables can cause crashes

Status in Mahara:
  Confirmed

Bug description:
  See : https://mahara.org/interaction/forum/topic.php?id=7397

  Here's the problem (which appears to be intermittent):

  1. ArtefactType has a destructor method, which gets called when an artefact 
object is garbage-collected by PHP.
  2. PHP runs destructor methods and garbage collects variables in no 
guaranteed order when exit() is called.
  3. Sometimes the ArtefactType destructor method tries to call DML methods, 
which use the global variable $db
  4. Apparently sometimes the $db global variable has already been garbage 
collected by the time the destructor runs
  5. This causes a fatal "method on a non-object" crash.

  It's unclear why this error has only started happening recently. It
  might be due to a change in the behavior of PHP's garbage collector,
  or it might be from new Mahara code leaving some artefacts with their
  $dirty flag set (which triggers that artefact commit).

  In either case, both global variables and implicit destructor methods
  are considered harmful design practices, in part because of this
  particular thing. So it's high time we got rid of these __destruct()
  methods.

  Alternatively, as a workaround for older Mahara versions, we could add
  some code to the top of each __destruct() method that re-creates the
  global $db if it's not set.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1513710/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


  1   2   >