[Mahara-contributors] [Bug 1826474] Re: langpack sync not working
** Changed in: mahara/19.04 Status: In Progress => Fix Committed ** Changed in: mahara/18.10 Status: In Progress => Fix Committed ** Changed in: mahara/18.04 Status: In Progress => Fix Committed ** Changed in: mahara/17.10 Status: In Progress => Fix Committed ** Changed in: mahara/18.10 Milestone: None => 18.10.1 ** Changed in: mahara/18.04 Milestone: None => 18.04.4 ** Changed in: mahara/17.10 Milestone: None => 17.10.8 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1826474 Title: langpack sync not working Status in Mahara: Fix Committed Status in Mahara 17.10 series: Fix Committed Status in Mahara 18.04 series: Fix Committed Status in Mahara 18.10 series: Fix Committed Status in Mahara 19.04 series: Fix Committed Bug description: Now we have a newer naming convention To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1826474/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1825617] A change has been merged
Reviewed: https://reviews.mahara.org/9892 Committed: https://git.mahara.org/mahara/mahara/commit/bc1fb0f28b6f10a0205d634fc57c861ee06d94c0 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:master commit bc1fb0f28b6f10a0205d634fc57c861ee06d94c0 Author: Rebecca Blundell Date: Mon Apr 29 11:03:08 2019 +1200 Bug 1825617: Add subheading to title of "Connected apps" page Under the arrow bar nav it should read: Sub-heading | Arrow-bar title behatnotneeded Change-Id: Iab104cdcffe92f57aff25eab5165d02be0419584 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1825617 Title: The "Connected apps" arrow bar should not change title Status in Mahara: Fix Committed Bug description: This is a follow-on from bug #1825616. Currently, the 3rd level navigation title, the arrow bar on User menu -> Settings -> Connected apps /account/apps.php changes depending on the area you are in, either Mahara Mobile or Badgr. That is a little confusing as you don't consistently see that you are still in the section "Connected apps". It would be better to always show "Connected apps" in the 3rd level navigation "arrow" no matter whether you are on the "Mahara Mobile" or "Badgr" pages. The page titles themselves though should change according to to page selected. Furthermore, an "Overview" navigation element would allow people to go back to the overview page. Thus, the arrow bar should always have the following elements, no matter whether you are on: - /account/apps.php - /module/mobileapi/apps.php - /blocktype/openbadgedisplayer/badgrtoken.php Connected apps - Overview - Mahara Mobile - Badgr (of course, depending on the availability of Mahara Mobile and Badgr in the configuration of the site). To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1825617/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1825617] A change has been merged
Reviewed: https://reviews.mahara.org/9903 Committed: https://git.mahara.org/mahara/mahara/commit/74adcd7ddcb7e7aa97f926a615e06e2cd1841698 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:19.04_STABLE commit 74adcd7ddcb7e7aa97f926a615e06e2cd1841698 Author: Rebecca Blundell Date: Mon Apr 29 11:03:08 2019 +1200 Bug 1825617: Add subheading to title of "Connected apps" page Under the arrow bar nav it should read: Sub-heading | Arrow-bar title behatnotneeded Change-Id: Iab104cdcffe92f57aff25eab5165d02be0419584 (cherry picked from commit bc1fb0f28b6f10a0205d634fc57c861ee06d94c0) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1825617 Title: The "Connected apps" arrow bar should not change title Status in Mahara: Fix Committed Bug description: This is a follow-on from bug #1825616. Currently, the 3rd level navigation title, the arrow bar on User menu -> Settings -> Connected apps /account/apps.php changes depending on the area you are in, either Mahara Mobile or Badgr. That is a little confusing as you don't consistently see that you are still in the section "Connected apps". It would be better to always show "Connected apps" in the 3rd level navigation "arrow" no matter whether you are on the "Mahara Mobile" or "Badgr" pages. The page titles themselves though should change according to to page selected. Furthermore, an "Overview" navigation element would allow people to go back to the overview page. Thus, the arrow bar should always have the following elements, no matter whether you are on: - /account/apps.php - /module/mobileapi/apps.php - /blocktype/openbadgedisplayer/badgrtoken.php Connected apps - Overview - Mahara Mobile - Badgr (of course, depending on the availability of Mahara Mobile and Badgr in the configuration of the site). To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1825617/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1825617] A patch has been submitted for review
Patch for "19.04_STABLE" branch: https://reviews.mahara.org/9903 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1825617 Title: The "Connected apps" arrow bar should not change title Status in Mahara: Fix Committed Bug description: This is a follow-on from bug #1825616. Currently, the 3rd level navigation title, the arrow bar on User menu -> Settings -> Connected apps /account/apps.php changes depending on the area you are in, either Mahara Mobile or Badgr. That is a little confusing as you don't consistently see that you are still in the section "Connected apps". It would be better to always show "Connected apps" in the 3rd level navigation "arrow" no matter whether you are on the "Mahara Mobile" or "Badgr" pages. The page titles themselves though should change according to to page selected. Furthermore, an "Overview" navigation element would allow people to go back to the overview page. Thus, the arrow bar should always have the following elements, no matter whether you are on: - /account/apps.php - /module/mobileapi/apps.php - /blocktype/openbadgedisplayer/badgrtoken.php Connected apps - Overview - Mahara Mobile - Badgr (of course, depending on the availability of Mahara Mobile and Badgr in the configuration of the site). To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1825617/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826795] Re: group/institution page error when rendering a block
** Changed in: mahara Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1826795 Title: group/institution page error when rendering a block Status in Mahara: Fix Committed Bug description: steps: 1. Create a group / institution / site page 2. Add a block 3. Make it copyable. 4. Log in as another user 5. Click the page title Expected result: Page is shown./ Actual result: Error is shown. Error message: [WAR] 9f (auth/user.php:849) Invalid argument pass to is_admin_for_user method Call stack (most recent first): User->is_admin_for_user(null) at /home/kristina/code/mahara/htdocs/blocktype/lib.php:1182 BlockInstance->render_viewing(false, false) at /home/kristina/code/mahara/htdocs/lib/view.php:2330 View->build_column(1, 2, false, false, false) at /home/kristina/code/mahara/htdocs/lib/view.php:2280 View->build_columns(1, false, false, false) at /home/kristina/code/mahara/htdocs/lib/view.php:2265 View->build_rows() at /home/kristina/code/mahara/htdocs/view/view.php:338 To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1826795/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826795] A change has been merged
Reviewed: https://reviews.mahara.org/9895 Committed: https://git.mahara.org/mahara/mahara/commit/59cf4d2417478be886a8f750c12fff7d710110eb Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:master commit 59cf4d2417478be886a8f750c12fff7d710110eb Author: Cecilia Vela Gurovic Date: Mon Apr 29 13:13:47 2019 +1200 Bug 1826795: block content in group/institution pages should always be displayed behatnotneeded Change-Id: I0ad0e632dbb3a2cf26cda321d0ec0a550b579d02 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1826795 Title: group/institution page error when rendering a block Status in Mahara: Fix Committed Bug description: steps: 1. Create a group / institution / site page 2. Add a block 3. Make it copyable. 4. Log in as another user 5. Click the page title Expected result: Page is shown./ Actual result: Error is shown. Error message: [WAR] 9f (auth/user.php:849) Invalid argument pass to is_admin_for_user method Call stack (most recent first): User->is_admin_for_user(null) at /home/kristina/code/mahara/htdocs/blocktype/lib.php:1182 BlockInstance->render_viewing(false, false) at /home/kristina/code/mahara/htdocs/lib/view.php:2330 View->build_column(1, 2, false, false, false) at /home/kristina/code/mahara/htdocs/lib/view.php:2280 View->build_columns(1, false, false, false) at /home/kristina/code/mahara/htdocs/lib/view.php:2265 View->build_rows() at /home/kristina/code/mahara/htdocs/view/view.php:338 To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1826795/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826795] A patch has been submitted for review
Patch for "19.04_STABLE" branch: https://reviews.mahara.org/9904 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1826795 Title: group/institution page error when rendering a block Status in Mahara: Fix Committed Bug description: steps: 1. Create a group / institution / site page 2. Add a block 3. Make it copyable. 4. Log in as another user 5. Click the page title Expected result: Page is shown./ Actual result: Error is shown. Error message: [WAR] 9f (auth/user.php:849) Invalid argument pass to is_admin_for_user method Call stack (most recent first): User->is_admin_for_user(null) at /home/kristina/code/mahara/htdocs/blocktype/lib.php:1182 BlockInstance->render_viewing(false, false) at /home/kristina/code/mahara/htdocs/lib/view.php:2330 View->build_column(1, 2, false, false, false) at /home/kristina/code/mahara/htdocs/lib/view.php:2280 View->build_columns(1, false, false, false) at /home/kristina/code/mahara/htdocs/lib/view.php:2265 View->build_rows() at /home/kristina/code/mahara/htdocs/view/view.php:338 To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1826795/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826795] A change has been merged
Reviewed: https://reviews.mahara.org/9904 Committed: https://git.mahara.org/mahara/mahara/commit/345d6e348c2bee4ab5e80e585c27970164fea4eb Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:19.04_STABLE commit 345d6e348c2bee4ab5e80e585c27970164fea4eb Author: Cecilia Vela Gurovic Date: Mon Apr 29 13:13:47 2019 +1200 Bug 1826795: block content in group/institution pages should always be displayed behatnotneeded Change-Id: I0ad0e632dbb3a2cf26cda321d0ec0a550b579d02 (cherry picked from commit 59cf4d2417478be886a8f750c12fff7d710110eb) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1826795 Title: group/institution page error when rendering a block Status in Mahara: Fix Committed Bug description: steps: 1. Create a group / institution / site page 2. Add a block 3. Make it copyable. 4. Log in as another user 5. Click the page title Expected result: Page is shown./ Actual result: Error is shown. Error message: [WAR] 9f (auth/user.php:849) Invalid argument pass to is_admin_for_user method Call stack (most recent first): User->is_admin_for_user(null) at /home/kristina/code/mahara/htdocs/blocktype/lib.php:1182 BlockInstance->render_viewing(false, false) at /home/kristina/code/mahara/htdocs/lib/view.php:2330 View->build_column(1, 2, false, false, false) at /home/kristina/code/mahara/htdocs/lib/view.php:2280 View->build_columns(1, false, false, false) at /home/kristina/code/mahara/htdocs/lib/view.php:2265 View->build_rows() at /home/kristina/code/mahara/htdocs/view/view.php:338 To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1826795/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826814] Re: Border around blocks on institution and site pages
** Changed in: mahara Status: Confirmed => In Progress -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1826814 Title: Border around blocks on institution and site pages Status in Mahara: In Progress Bug description: Follow-on report from the Bootstrap 4 upgrade. When you create a site and institution page, there is a border around the blocks in display and edit mode where there shouldn't be one. The screenshot is using the Default theme, but other themes have the same issue. The problem does not occur in personal and group pages that have blocks. To replicate: 1. Log in as site admin and create an institution. 2. Create a page in Admin menu -> Configure site -> Pages and collections. 3. Add a block to the page. Expected result: There is no extra border around the blocks. Actual result: There is a border around each block. Blocks shouldn't have a block border in edit or display mode. 4. Create a page in Admin menu -> Institutions -> Pages and collections. 5. Add a block to the page. Expected result: There is no extra border around the blocks. Actual result: There is a border around each block. Blocks shouldn't have a block border in edit or display mode. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1826814/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826814] A patch has been submitted for review
Patch for "master" branch: https://reviews.mahara.org/9905 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1826814 Title: Border around blocks on institution and site pages Status in Mahara: In Progress Bug description: Follow-on report from the Bootstrap 4 upgrade. When you create a site and institution page, there is a border around the blocks in display and edit mode where there shouldn't be one. The screenshot is using the Default theme, but other themes have the same issue. The problem does not occur in personal and group pages that have blocks. To replicate: 1. Log in as site admin and create an institution. 2. Create a page in Admin menu -> Configure site -> Pages and collections. 3. Add a block to the page. Expected result: There is no extra border around the blocks. Actual result: There is a border around each block. Blocks shouldn't have a block border in edit or display mode. 4. Create a page in Admin menu -> Institutions -> Pages and collections. 5. Add a block to the page. Expected result: There is no extra border around the blocks. Actual result: There is a border around each block. Blocks shouldn't have a block border in edit or display mode. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1826814/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826937] [NEW] Deleting comment in artefact view causes undefined property error
Public bug reported:
[WAR] 7e (artefact/comment/lib.php:1465) Trying to get property of non-object
Call stack (most recent first):
log_message("Trying to get property of non-object", 8, true, true,
"/home/robertl/code/mahara-devel/mahara/htdocs/arte...", 1465) at
/home/robertl/code/mahara-devel/mahara/htdocs/lib/errors.php:520
error(8, "Trying to get property of non-object",
"/home/robertl/code/mahara-devel/mahara/htdocs/arte...", 1465, array(size 13))
at /home/robertl/code/mahara-devel/mahara/htdocs/artefact/comment/lib.php:1465
delete_comment_submit(object(Pieform), array(size 3)) at
/home/robertl/code/mahara-devel/mahara/htdocs/lib/pieforms/pieform.php:544
This is because we are checking the view id rather than the artefact id
the comment is attached to
To replicate:
1. Create 2 users.
2. Log in as user A and create a page containing an image block
3. Shared page with user B.
4. Log in as user B and comment on the image block.
5. Delete the comment.
** Affects: mahara
Importance: Undecided
Status: New
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1826937
Title:
Deleting comment in artefact view causes undefined property error
Status in Mahara:
New
Bug description:
[WAR] 7e (artefact/comment/lib.php:1465) Trying to get property of non-object
Call stack (most recent first):
log_message("Trying to get property of non-object", 8, true, true,
"/home/robertl/code/mahara-devel/mahara/htdocs/arte...", 1465) at
/home/robertl/code/mahara-devel/mahara/htdocs/lib/errors.php:520
error(8, "Trying to get property of non-object",
"/home/robertl/code/mahara-devel/mahara/htdocs/arte...", 1465, array(size 13))
at /home/robertl/code/mahara-devel/mahara/htdocs/artefact/comment/lib.php:1465
delete_comment_submit(object(Pieform), array(size 3)) at
/home/robertl/code/mahara-devel/mahara/htdocs/lib/pieforms/pieform.php:544
This is because we are checking the view id rather than the artefact
id the comment is attached to
To replicate:
1. Create 2 users.
2. Log in as user A and create a page containing an image block
3. Shared page with user B.
4. Log in as user B and comment on the image block.
5. Delete the comment.
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1826937/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826937] A patch has been submitted for review
Patch for "master" branch: https://reviews.mahara.org/9906
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1826937
Title:
Deleting comment in artefact view causes undefined property error
Status in Mahara:
New
Bug description:
[WAR] 7e (artefact/comment/lib.php:1465) Trying to get property of non-object
Call stack (most recent first):
log_message("Trying to get property of non-object", 8, true, true,
"/home/robertl/code/mahara-devel/mahara/htdocs/arte...", 1465) at
/home/robertl/code/mahara-devel/mahara/htdocs/lib/errors.php:520
error(8, "Trying to get property of non-object",
"/home/robertl/code/mahara-devel/mahara/htdocs/arte...", 1465, array(size 13))
at /home/robertl/code/mahara-devel/mahara/htdocs/artefact/comment/lib.php:1465
delete_comment_submit(object(Pieform), array(size 3)) at
/home/robertl/code/mahara-devel/mahara/htdocs/lib/pieforms/pieform.php:544
This is because we are checking the view id rather than the artefact
id the comment is attached to
To replicate:
1. Create 2 users.
2. Log in as user A and create a page containing an image block
3. Shared page with user B.
4. Log in as user B and comment on the image block.
5. Delete the comment.
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1826937/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826940] [NEW] Problem saving info to external_services_logs table
Public bug reported:
The 'auth' column is only 10 chars (as it expects one of OTHER, OAUTH,
TOKEN, TOKEN_USER, USER) and fails when it tries to save the wstoken
value string instead:
[DBG] bb (webservice/lib.php:1512) executing: mahara_user_external/update_users
[WAR] bb (lib/errors.php:858) Failed to get a recordset: postgres8 error: [-1:
ERROR: value too long for type character varying(10)] in EXECUTE("INSERT INTO
"external_services_logs" ("id", "timelogged", "userid", "externalserviceid",
"institution", "protocol", "auth", "functionname", "timetaken", "uri", "info",
"ip") VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)")Command was: INSERT INTO
"external_services_logs" ("id", "timelogged", "userid", "externalserviceid",
"institution", "protocol", "auth", "functionname", "timetaken", "uri", "info",
"ip") VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?) and values was
(id:16877,timelogged:1556571027,userid:8,externalserviceid:3,institution:wdhb,protocol:REST,auth:1234a2fcc061b24432191a1295958600,functionname:mahara_user_update_users,timetaken:0.26598191261292,uri:/webservice/rest/server.php?wstoken=1234a2fcc061b24432191a1295958600,info:exception:WebserviceInvalidParameterExceptionmessage:Invalidparametervaluedetected;executioncannotcontinue.:update_users|in...
Call stack (most recent first):
* insert_record(string(size 22), object(stdClass), string(size 2), true) at
//webservice/lib.php:1441
*
webservice_base_server->exception_handler(object(WebserviceInvalidParameterException))
at Unknown:
** Affects: mahara
Importance: Undecided
Status: New
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1826940
Title:
Problem saving info to external_services_logs table
Status in Mahara:
New
Bug description:
The 'auth' column is only 10 chars (as it expects one of OTHER, OAUTH,
TOKEN, TOKEN_USER, USER) and fails when it tries to save the wstoken
value string instead:
[DBG] bb (webservice/lib.php:1512) executing:
mahara_user_external/update_users
[WAR] bb (lib/errors.php:858) Failed to get a recordset: postgres8 error:
[-1: ERROR: value too long for type character varying(10)] in EXECUTE("INSERT
INTO "external_services_logs" ("id", "timelogged", "userid",
"externalserviceid", "institution", "protocol", "auth", "functionname",
"timetaken", "uri", "info", "ip") VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?,
?)")Command was: INSERT INTO "external_services_logs" ("id", "timelogged",
"userid", "externalserviceid", "institution", "protocol", "auth",
"functionname", "timetaken", "uri", "info", "ip") VALUES (?, ?, ?, ?, ?, ?, ?,
?, ?, ?, ?, ?) and values was
(id:16877,timelogged:1556571027,userid:8,externalserviceid:3,institution:wdhb,protocol:REST,auth:1234a2fcc061b24432191a1295958600,functionname:mahara_user_update_users,timetaken:0.26598191261292,uri:/webservice/rest/server.php?wstoken=1234a2fcc061b24432191a1295958600,info:exception:WebserviceInvalidParameterExceptionmessage:Invalidparametervaluedetected;executioncannotcontinue.:update_users|in...
Call stack (most recent first):
* insert_record(string(size 22), object(stdClass), string(size 2), true)
at //webservice/lib.php:1441
*
webservice_base_server->exception_handler(object(WebserviceInvalidParameterException))
at Unknown:
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1826940/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826940] A patch has been submitted for review
Patch for "master" branch: https://reviews.mahara.org/9907
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1826940
Title:
Problem saving info to external_services_logs table
Status in Mahara:
New
Bug description:
The 'auth' column is only 10 chars (as it expects one of OTHER, OAUTH,
TOKEN, TOKEN_USER, USER) and fails when it tries to save the wstoken
value string instead:
[DBG] bb (webservice/lib.php:1512) executing:
mahara_user_external/update_users
[WAR] bb (lib/errors.php:858) Failed to get a recordset: postgres8 error:
[-1: ERROR: value too long for type character varying(10)] in EXECUTE("INSERT
INTO "external_services_logs" ("id", "timelogged", "userid",
"externalserviceid", "institution", "protocol", "auth", "functionname",
"timetaken", "uri", "info", "ip") VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?,
?)")Command was: INSERT INTO "external_services_logs" ("id", "timelogged",
"userid", "externalserviceid", "institution", "protocol", "auth",
"functionname", "timetaken", "uri", "info", "ip") VALUES (?, ?, ?, ?, ?, ?, ?,
?, ?, ?, ?, ?) and values was
(id:16877,timelogged:1556571027,userid:8,externalserviceid:3,institution:wdhb,protocol:REST,auth:1234a2fcc061b24432191a1295958600,functionname:mahara_user_update_users,timetaken:0.26598191261292,uri:/webservice/rest/server.php?wstoken=1234a2fcc061b24432191a1295958600,info:exception:WebserviceInvalidParameterExceptionmessage:Invalidparametervaluedetected;executioncannotcontinue.:update_users|in...
Call stack (most recent first):
* insert_record(string(size 22), object(stdClass), string(size 2), true)
at //webservice/lib.php:1441
*
webservice_base_server->exception_handler(object(WebserviceInvalidParameterException))
at Unknown:
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1826940/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826048] Re: "Remove from watchlist" icon is missing
Commit hash: cfeac8220a39dc016fda35554df1f0fd01853d12 Environment tested: Master Browser tested: Chrome Theme used: Raw PRECONDITIONS: 1) 2 Users exist (UserA and UserB) TEST STEPS: 1) Log in as user A and create a page that is shared with user B. 2) Log in as user B and comment on the page of user A. 3) Click the "More options" button on the page. 4) Confirm user can see "Remove page from watchlist" with the "eye-slash" FontAwesome icon like in 18.10 https://manual.mahara.org/en/18.10/_images/3_dots_expanded.png Catalyst QA Approved ✔ -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1826048 Title: "Remove from watchlist" icon is missing Status in Mahara: In Progress Bug description: When you added a page to your watchlist and you want to remove it, you don't see the icon next to "Remove page from watchlist". To replicate: 1. Create 2 users. 2. Log in as user A and create a page that is shared with user B. 3. Log in as user B and comment on the page of user A. 4. Click the "More options" button on the page. Expected result: You can see "Remove page from watchlist" with the "eye-slash" FontAwesome icon like in 18.10 https://manual.mahara.org/en/18.10/_images/3_dots_expanded.png Actual result: The icon is missing (see attached screenshot). To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1826048/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1635503] A patch has been submitted for review
Patch for "19.04_STABLE" branch: https://reviews.mahara.org/9909 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1635503 Title: Set up a SmartEvidence framework in the admin interface Status in Mahara: Fix Committed Bug description: Currently (in 16.10) we can upload a .matrix file containing a Smart Evidence framework But once it is uploaded we are unable to alter it via the web interface (only through the database). What would be good is an admin interface that at least allowed for the editing of the field names and the re-ordering of evidence elements as well as adding new elements A thing to take into account is should one be allowed to edit a Smart Evidence framework once it is already being used and if so what things are ok to edit at that point and what things can be edited before it is in use. I'm thinking order and field values can be edited before it is in use. Once someone is using it then the order / fields for current framework should be set - but maybe possible to add new standard elements to framework. Also it would be good to have a 'copy framework' option to be able to duplicate a framework To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1635503/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1635503] A change has been merged
Reviewed: https://reviews.mahara.org/9908 Committed: https://git.mahara.org/mahara/mahara/commit/717a3191a7870292bb29cb097fd70cf3be6f37d4 Submitter: Cecilia Vela Gurovic (cecili...@catalyst.net.nz) Branch:19.04_STABLE commit 717a3191a7870292bb29cb097fd70cf3be6f37d4 Author: Cecilia Vela Gurovic Date: Mon Apr 29 12:27:52 2019 +1200 Bug 1635503: SE editor- stop fetching a framework when clearing the edit/copy dropdowns + removed "upload" variable not being used behatnotneeded Change-Id: I8622538bc1ad1ca91ba8a8140742a086bfa11b1e (cherry picked from commit b91aad3842c8a8a25607ae514bb1ad05cd3deb6f) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1635503 Title: Set up a SmartEvidence framework in the admin interface Status in Mahara: Fix Committed Bug description: Currently (in 16.10) we can upload a .matrix file containing a Smart Evidence framework But once it is uploaded we are unable to alter it via the web interface (only through the database). What would be good is an admin interface that at least allowed for the editing of the field names and the re-ordering of evidence elements as well as adding new elements A thing to take into account is should one be allowed to edit a Smart Evidence framework once it is already being used and if so what things are ok to edit at that point and what things can be edited before it is in use. I'm thinking order and field values can be edited before it is in use. Once someone is using it then the order / fields for current framework should be set - but maybe possible to add new standard elements to framework. Also it would be good to have a 'copy framework' option to be able to duplicate a framework To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1635503/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1635503] A patch has been submitted for review
Patch for "19.04_STABLE" branch: https://reviews.mahara.org/9908 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1635503 Title: Set up a SmartEvidence framework in the admin interface Status in Mahara: Fix Committed Bug description: Currently (in 16.10) we can upload a .matrix file containing a Smart Evidence framework But once it is uploaded we are unable to alter it via the web interface (only through the database). What would be good is an admin interface that at least allowed for the editing of the field names and the re-ordering of evidence elements as well as adding new elements A thing to take into account is should one be allowed to edit a Smart Evidence framework once it is already being used and if so what things are ok to edit at that point and what things can be edited before it is in use. I'm thinking order and field values can be edited before it is in use. Once someone is using it then the order / fields for current framework should be set - but maybe possible to add new standard elements to framework. Also it would be good to have a 'copy framework' option to be able to duplicate a framework To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1635503/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1635503] A change has been merged
Reviewed: https://reviews.mahara.org/9896 Committed: https://git.mahara.org/mahara/mahara/commit/36c330fb4bb398c6fd035423f2e7917a7ae850d0 Submitter: Cecilia Vela Gurovic (cecili...@catalyst.net.nz) Branch:master commit 36c330fb4bb398c6fd035423f2e7917a7ae850d0 Author: Cecilia Vela Gurovic Date: Mon Apr 29 15:22:08 2019 +1200 Bug 1635503: SE editor- get correct index value when loading framework - to know if we already loaded element 1.1 or not (otherwise, for a matrix with only one element for the first standard, the 1.1 get deleted) - also removed an unnecessary line behatnotneeded Change-Id: I8c7ab84e3ce4794823069593547f0e33647227d1 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1635503 Title: Set up a SmartEvidence framework in the admin interface Status in Mahara: Fix Committed Bug description: Currently (in 16.10) we can upload a .matrix file containing a Smart Evidence framework But once it is uploaded we are unable to alter it via the web interface (only through the database). What would be good is an admin interface that at least allowed for the editing of the field names and the re-ordering of evidence elements as well as adding new elements A thing to take into account is should one be allowed to edit a Smart Evidence framework once it is already being used and if so what things are ok to edit at that point and what things can be edited before it is in use. I'm thinking order and field values can be edited before it is in use. Once someone is using it then the order / fields for current framework should be set - but maybe possible to add new standard elements to framework. Also it would be good to have a 'copy framework' option to be able to duplicate a framework To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1635503/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1635503] A change has been merged
Reviewed: https://reviews.mahara.org/9893 Committed: https://git.mahara.org/mahara/mahara/commit/b91aad3842c8a8a25607ae514bb1ad05cd3deb6f Submitter: Cecilia Vela Gurovic (cecili...@catalyst.net.nz) Branch:master commit b91aad3842c8a8a25607ae514bb1ad05cd3deb6f Author: Cecilia Vela Gurovic Date: Mon Apr 29 12:27:52 2019 +1200 Bug 1635503: SE editor- stop fetching a framework when clearing the edit/copy dropdowns + removed "upload" variable not being used behatnotneeded Change-Id: I8622538bc1ad1ca91ba8a8140742a086bfa11b1e -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1635503 Title: Set up a SmartEvidence framework in the admin interface Status in Mahara: Fix Committed Bug description: Currently (in 16.10) we can upload a .matrix file containing a Smart Evidence framework But once it is uploaded we are unable to alter it via the web interface (only through the database). What would be good is an admin interface that at least allowed for the editing of the field names and the re-ordering of evidence elements as well as adding new elements A thing to take into account is should one be allowed to edit a Smart Evidence framework once it is already being used and if so what things are ok to edit at that point and what things can be edited before it is in use. I'm thinking order and field values can be edited before it is in use. Once someone is using it then the order / fields for current framework should be set - but maybe possible to add new standard elements to framework. Also it would be good to have a 'copy framework' option to be able to duplicate a framework To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1635503/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1635503] A change has been merged
Reviewed: https://reviews.mahara.org/9909 Committed: https://git.mahara.org/mahara/mahara/commit/ce0fa0d31719cc86c768fa01a2b5d73948776ba9 Submitter: Cecilia Vela Gurovic (cecili...@catalyst.net.nz) Branch:19.04_STABLE commit ce0fa0d31719cc86c768fa01a2b5d73948776ba9 Author: Cecilia Vela Gurovic Date: Mon Apr 29 15:22:08 2019 +1200 Bug 1635503: SE editor- get correct index value when loading framework - to know if we already loaded element 1.1 or not (otherwise, for a matrix with only one element for the first standard, the 1.1 get deleted) - also removed an unnecessary line behatnotneeded Change-Id: I8c7ab84e3ce4794823069593547f0e33647227d1 (cherry picked from commit 36c330fb4bb398c6fd035423f2e7917a7ae850d0) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1635503 Title: Set up a SmartEvidence framework in the admin interface Status in Mahara: Fix Committed Bug description: Currently (in 16.10) we can upload a .matrix file containing a Smart Evidence framework But once it is uploaded we are unable to alter it via the web interface (only through the database). What would be good is an admin interface that at least allowed for the editing of the field names and the re-ordering of evidence elements as well as adding new elements A thing to take into account is should one be allowed to edit a Smart Evidence framework once it is already being used and if so what things are ok to edit at that point and what things can be edited before it is in use. I'm thinking order and field values can be edited before it is in use. Once someone is using it then the order / fields for current framework should be set - but maybe possible to add new standard elements to framework. Also it would be good to have a 'copy framework' option to be able to duplicate a framework To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1635503/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826814] A change has been merged
Reviewed: https://reviews.mahara.org/9905 Committed: https://git.mahara.org/mahara/mahara/commit/6a615b82f8ef883827fc3f97a28e024ff2eddfbc Submitter: Cecilia Vela Gurovic (cecili...@catalyst.net.nz) Branch:master commit 6a615b82f8ef883827fc3f97a28e024ff2eddfbc Author: Robert Lyon Date: Tue Apr 30 07:52:30 2019 +1200 Bug 1826814: Removing border from blocks on site/institution pages behatnotneeded Change-Id: I2e31e7e83a0cb1825b1e0d3e9f79badcc36fb7fd Signed-off-by: Robert Lyon -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1826814 Title: Border around blocks on institution and site pages Status in Mahara: Fix Committed Bug description: Follow-on report from the Bootstrap 4 upgrade. When you create a site and institution page, there is a border around the blocks in display and edit mode where there shouldn't be one. The screenshot is using the Default theme, but other themes have the same issue. The problem does not occur in personal and group pages that have blocks. To replicate: 1. Log in as site admin and create an institution. 2. Create a page in Admin menu -> Configure site -> Pages and collections. 3. Add a block to the page. Expected result: There is no extra border around the blocks. Actual result: There is a border around each block. Blocks shouldn't have a block border in edit or display mode. 4. Create a page in Admin menu -> Institutions -> Pages and collections. 5. Add a block to the page. Expected result: There is no extra border around the blocks. Actual result: There is a border around each block. Blocks shouldn't have a block border in edit or display mode. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1826814/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826814] A patch has been submitted for review
Patch for "19.04_STABLE" branch: https://reviews.mahara.org/9910 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1826814 Title: Border around blocks on institution and site pages Status in Mahara: Fix Committed Bug description: Follow-on report from the Bootstrap 4 upgrade. When you create a site and institution page, there is a border around the blocks in display and edit mode where there shouldn't be one. The screenshot is using the Default theme, but other themes have the same issue. The problem does not occur in personal and group pages that have blocks. To replicate: 1. Log in as site admin and create an institution. 2. Create a page in Admin menu -> Configure site -> Pages and collections. 3. Add a block to the page. Expected result: There is no extra border around the blocks. Actual result: There is a border around each block. Blocks shouldn't have a block border in edit or display mode. 4. Create a page in Admin menu -> Institutions -> Pages and collections. 5. Add a block to the page. Expected result: There is no extra border around the blocks. Actual result: There is a border around each block. Blocks shouldn't have a block border in edit or display mode. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1826814/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826814] A change has been merged
Reviewed: https://reviews.mahara.org/9910 Committed: https://git.mahara.org/mahara/mahara/commit/274f6bbd472b0730a44b9755bcac48e208d6d2b0 Submitter: Cecilia Vela Gurovic (cecili...@catalyst.net.nz) Branch:19.04_STABLE commit 274f6bbd472b0730a44b9755bcac48e208d6d2b0 Author: Robert Lyon Date: Tue Apr 30 07:52:30 2019 +1200 Bug 1826814: Removing border from blocks on site/institution pages behatnotneeded Change-Id: I2e31e7e83a0cb1825b1e0d3e9f79badcc36fb7fd Signed-off-by: Robert Lyon (cherry picked from commit 6a615b82f8ef883827fc3f97a28e024ff2eddfbc) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1826814 Title: Border around blocks on institution and site pages Status in Mahara: Fix Committed Bug description: Follow-on report from the Bootstrap 4 upgrade. When you create a site and institution page, there is a border around the blocks in display and edit mode where there shouldn't be one. The screenshot is using the Default theme, but other themes have the same issue. The problem does not occur in personal and group pages that have blocks. To replicate: 1. Log in as site admin and create an institution. 2. Create a page in Admin menu -> Configure site -> Pages and collections. 3. Add a block to the page. Expected result: There is no extra border around the blocks. Actual result: There is a border around each block. Blocks shouldn't have a block border in edit or display mode. 4. Create a page in Admin menu -> Institutions -> Pages and collections. 5. Add a block to the page. Expected result: There is no extra border around the blocks. Actual result: There is a border around each block. Blocks shouldn't have a block border in edit or display mode. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1826814/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826766] A change has been merged
Reviewed: https://reviews.mahara.org/9886 Committed: https://git.mahara.org/mahara/mahara/commit/4f2187880d2f19ddbec071c3bf235fccbcb52ea6 Submitter: Cecilia Vela Gurovic (cecili...@catalyst.net.nz) Branch:master commit 4f2187880d2f19ddbec071c3bf235fccbcb52ea6 Author: Robert Lyon Date: Mon Apr 29 10:03:10 2019 +1200 Bug 1826766: Only show 'uploaded by' if the viewer is not owner behatnotneeded Change-Id: I299b411bd3d5368ce11997bc6390a04ddc121279 Signed-off-by: Robert Lyon -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1826766 Title: The "Uploaded by" option should only be visible in the group file area but not others Status in Mahara: Fix Committed Bug description: In bug #1815807 we added the person's name to the file properties to see who uploaded a file. This information should not be visible in the personal files area as it is superfluous. It can stay available in the group, institution, and site files areas as there are multiple people who could potentially upload files and thus differentiating who did would be a good thing for transparency. To replicate: 1. Log in as site admin. 2. Upload a file to your personal files area and click the "Edit" button. Expected result: There is no mention of "Uploaded by" Actual result: "Uploaded by ..." is displayed. 3. Add the file to a page. 4. Click the file to view its details page. Expected result: There is no mention of "Uploaded by" Actual result: "Uploaded by ..." is displayed. 5. Upload a file to a group. 6. Click the "Edit" button to view the file properties. Expected and actual result: "Uploaded by ..." is displayed. 7. Add the group file to a group page. 8. Click the file to view its details page. Expected and actual result: "Uploaded by ..." is displayed. Repeat 5-8 for institution and site files with the same results. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1826766/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826814] Re: Border around blocks on institution and site pages
** Changed in: mahara Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1826814 Title: Border around blocks on institution and site pages Status in Mahara: Fix Committed Bug description: Follow-on report from the Bootstrap 4 upgrade. When you create a site and institution page, there is a border around the blocks in display and edit mode where there shouldn't be one. The screenshot is using the Default theme, but other themes have the same issue. The problem does not occur in personal and group pages that have blocks. To replicate: 1. Log in as site admin and create an institution. 2. Create a page in Admin menu -> Configure site -> Pages and collections. 3. Add a block to the page. Expected result: There is no extra border around the blocks. Actual result: There is a border around each block. Blocks shouldn't have a block border in edit or display mode. 4. Create a page in Admin menu -> Institutions -> Pages and collections. 5. Add a block to the page. Expected result: There is no extra border around the blocks. Actual result: There is a border around each block. Blocks shouldn't have a block border in edit or display mode. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1826814/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826766] A change has been merged
Reviewed: https://reviews.mahara.org/9911 Committed: https://git.mahara.org/mahara/mahara/commit/056be41a34fa06404609054bc650eecc28d0f37a Submitter: Cecilia Vela Gurovic (cecili...@catalyst.net.nz) Branch:19.04_STABLE commit 056be41a34fa06404609054bc650eecc28d0f37a Author: Robert Lyon Date: Mon Apr 29 10:03:10 2019 +1200 Bug 1826766: Only show 'uploaded by' if the viewer is not owner behatnotneeded Change-Id: I299b411bd3d5368ce11997bc6390a04ddc121279 Signed-off-by: Robert Lyon (cherry picked from commit 4f2187880d2f19ddbec071c3bf235fccbcb52ea6) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1826766 Title: The "Uploaded by" option should only be visible in the group file area but not others Status in Mahara: Fix Committed Bug description: In bug #1815807 we added the person's name to the file properties to see who uploaded a file. This information should not be visible in the personal files area as it is superfluous. It can stay available in the group, institution, and site files areas as there are multiple people who could potentially upload files and thus differentiating who did would be a good thing for transparency. To replicate: 1. Log in as site admin. 2. Upload a file to your personal files area and click the "Edit" button. Expected result: There is no mention of "Uploaded by" Actual result: "Uploaded by ..." is displayed. 3. Add the file to a page. 4. Click the file to view its details page. Expected result: There is no mention of "Uploaded by" Actual result: "Uploaded by ..." is displayed. 5. Upload a file to a group. 6. Click the "Edit" button to view the file properties. Expected and actual result: "Uploaded by ..." is displayed. 7. Add the group file to a group page. 8. Click the file to view its details page. Expected and actual result: "Uploaded by ..." is displayed. Repeat 5-8 for institution and site files with the same results. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1826766/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826766] A patch has been submitted for review
Patch for "19.04_STABLE" branch: https://reviews.mahara.org/9911 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1826766 Title: The "Uploaded by" option should only be visible in the group file area but not others Status in Mahara: Fix Committed Bug description: In bug #1815807 we added the person's name to the file properties to see who uploaded a file. This information should not be visible in the personal files area as it is superfluous. It can stay available in the group, institution, and site files areas as there are multiple people who could potentially upload files and thus differentiating who did would be a good thing for transparency. To replicate: 1. Log in as site admin. 2. Upload a file to your personal files area and click the "Edit" button. Expected result: There is no mention of "Uploaded by" Actual result: "Uploaded by ..." is displayed. 3. Add the file to a page. 4. Click the file to view its details page. Expected result: There is no mention of "Uploaded by" Actual result: "Uploaded by ..." is displayed. 5. Upload a file to a group. 6. Click the "Edit" button to view the file properties. Expected and actual result: "Uploaded by ..." is displayed. 7. Add the group file to a group page. 8. Click the file to view its details page. Expected and actual result: "Uploaded by ..." is displayed. Repeat 5-8 for institution and site files with the same results. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1826766/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826766] Re: The "Uploaded by" option should only be visible in the group file area but not others
** Changed in: mahara Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1826766 Title: The "Uploaded by" option should only be visible in the group file area but not others Status in Mahara: Fix Committed Bug description: In bug #1815807 we added the person's name to the file properties to see who uploaded a file. This information should not be visible in the personal files area as it is superfluous. It can stay available in the group, institution, and site files areas as there are multiple people who could potentially upload files and thus differentiating who did would be a good thing for transparency. To replicate: 1. Log in as site admin. 2. Upload a file to your personal files area and click the "Edit" button. Expected result: There is no mention of "Uploaded by" Actual result: "Uploaded by ..." is displayed. 3. Add the file to a page. 4. Click the file to view its details page. Expected result: There is no mention of "Uploaded by" Actual result: "Uploaded by ..." is displayed. 5. Upload a file to a group. 6. Click the "Edit" button to view the file properties. Expected and actual result: "Uploaded by ..." is displayed. 7. Add the group file to a group page. 8. Click the file to view its details page. Expected and actual result: "Uploaded by ..." is displayed. Repeat 5-8 for institution and site files with the same results. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1826766/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826940] Re: Problem saving info to external_services_logs table
Ok it looks like the problem is based around this:
In webservice_base_server::run() there is the following:
// init all properties from the request data
$this->parse_request();
// authenticate user, this has to be done after the request parsing
// this also sets up $USER and $SESSION
$this->authenticate_user();
The authenticate_user() method sets $this->auth to be a string like
'TOKEN'
But there is also the webservice_rest_client that set an 'auth'
variable for it's own use
So if using REST auth and the parse_request() fails then we have the
wrong $this->auth value set by the looks of things
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1826940
Title:
Problem saving info to external_services_logs table
Status in Mahara:
New
Bug description:
The 'auth' column is only 10 chars (as it expects one of OTHER, OAUTH,
TOKEN, TOKEN_USER, USER) and fails when it tries to save the wstoken
value string instead:
[DBG] bb (webservice/lib.php:1512) executing:
mahara_user_external/update_users
[WAR] bb (lib/errors.php:858) Failed to get a recordset: postgres8 error:
[-1: ERROR: value too long for type character varying(10)] in EXECUTE("INSERT
INTO "external_services_logs" ("id", "timelogged", "userid",
"externalserviceid", "institution", "protocol", "auth", "functionname",
"timetaken", "uri", "info", "ip") VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?,
?)")Command was: INSERT INTO "external_services_logs" ("id", "timelogged",
"userid", "externalserviceid", "institution", "protocol", "auth",
"functionname", "timetaken", "uri", "info", "ip") VALUES (?, ?, ?, ?, ?, ?, ?,
?, ?, ?, ?, ?) and values was
(id:16877,timelogged:1556571027,userid:8,externalserviceid:3,institution:wdhb,protocol:REST,auth:1234a2fcc061b24432191a1295958600,functionname:mahara_user_update_users,timetaken:0.26598191261292,uri:/webservice/rest/server.php?wstoken=1234a2fcc061b24432191a1295958600,info:exception:WebserviceInvalidParameterExceptionmessage:Invalidparametervaluedetected;executioncannotcontinue.:update_users|in...
Call stack (most recent first):
* insert_record(string(size 22), object(stdClass), string(size 2), true)
at //webservice/lib.php:1441
*
webservice_base_server->exception_handler(object(WebserviceInvalidParameterException))
at Unknown:
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1826940/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826948] [NEW] Comment text being saved with extra HTML tags
Public bug reported: In 18.04 we made a change which meant we inadvertently started saving comment text like this: http://www.w3.org/TR/REC-html40/loose.dtd";> comment text instead of like this: comment text this is because a call to loadHTML() adds the extra tags unless passed in flags tell it not to. As well as fixing this problem, we need to check that other places in the code that use loadHTML() are not also adding extra tags. Steps to reproduce: 1. Add a comment 2. Check the database and check what is stored in the artefact table for the text of that comment What you should see: The text of the comment you added inside tags What you currently see: The text of the comment you added inside the doctype and body tags as well. ** Affects: mahara Importance: Undecided Status: New -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1826948 Title: Comment text being saved with extra HTML tags Status in Mahara: New Bug description: In 18.04 we made a change which meant we inadvertently started saving comment text like this: http://www.w3.org/TR/REC-html40/loose.dtd";> comment text instead of like this: comment text this is because a call to loadHTML() adds the extra tags unless passed in flags tell it not to. As well as fixing this problem, we need to check that other places in the code that use loadHTML() are not also adding extra tags. Steps to reproduce: 1. Add a comment 2. Check the database and check what is stored in the artefact table for the text of that comment What you should see: The text of the comment you added inside tags What you currently see: The text of the comment you added inside the doctype and body tags as well. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1826948/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826948] A patch has been submitted for review
Patch for "master" branch: https://reviews.mahara.org/9912 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1826948 Title: Comment text being saved with extra HTML tags Status in Mahara: New Bug description: In 18.04 we made a change which meant we inadvertently started saving comment text like this: http://www.w3.org/TR/REC-html40/loose.dtd";> comment text instead of like this: comment text this is because a call to loadHTML() adds the extra tags unless passed in flags tell it not to. As well as fixing this problem, we need to check that other places in the code that use loadHTML() are not also adding extra tags. Steps to reproduce: 1. Add a comment 2. Check the database and check what is stored in the artefact table for the text of that comment What you should see: The text of the comment you added inside tags What you currently see: The text of the comment you added inside the doctype and body tags as well. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1826948/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826951] Re: Style conflict issues in html blocks in Portfolio pages
** Attachment added: "HTML block not displaying correctly.png" https://bugs.launchpad.net/mahara/+bug/1826951/+attachment/5260170/+files/HTML%20block%20not%20displaying%20correctly.png -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1826951 Title: Style conflict issues in html blocks in Portfolio pages Status in Mahara: New Bug description: TITLE: Style conflict issues in html blocks in Portfolio pages BUG SUMMARY: There seems to be a conflict with inline styles in an html document and the portfolio page styling. == Environment tested: Master Browser tested: Chrome PRECONDITIONS: 1) HTML document exists (created by using ODT document and saving as html) a) Heading tags b) bullet list with nested items c) numbered list with nested items d) Paragraph text e) Image f) table g) embedded Excel spreadsheet: TEST STEPS: 1) Log in as mahara user 2) create a portfolio page with a 3 column layout (default) 3) add an html block using the html file mentioned in preconditions Expected Result: The html should respect the portfolio page layout - so if a table is larger than the column, then scroll bars should be used. The Portfolio page should also respect the HTML file (if the file has bullet and numbered lists, they should be displayed correctly Actual Result: The portfolio page is displaying lists and tables incorrectly - see screenshot attached To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1826951/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826951] [NEW] Style conflict issues in html blocks in Portfolio pages
Public bug reported: TITLE: Style conflict issues in html blocks in Portfolio pages BUG SUMMARY: There seems to be a conflict with inline styles in an html document and the portfolio page styling. == Environment tested: Master Browser tested: Chrome PRECONDITIONS: 1) HTML document exists (created by using ODT document and saving as html) a) Heading tags b) bullet list with nested items c) numbered list with nested items d) Paragraph text e) Image f) table g) embedded Excel spreadsheet: TEST STEPS: 1) Log in as mahara user 2) create a portfolio page with a 3 column layout (default) 3) add an html block using the html file mentioned in preconditions Expected Result: The html should respect the portfolio page layout - so if a table is larger than the column, then scroll bars should be used. The Portfolio page should also respect the HTML file (if the file has bullet and numbered lists, they should be displayed correctly Actual Result: The portfolio page is displaying lists and tables incorrectly - see screenshot attached ** Affects: mahara Importance: Undecided Status: New -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1826951 Title: Style conflict issues in html blocks in Portfolio pages Status in Mahara: New Bug description: TITLE: Style conflict issues in html blocks in Portfolio pages BUG SUMMARY: There seems to be a conflict with inline styles in an html document and the portfolio page styling. == Environment tested: Master Browser tested: Chrome PRECONDITIONS: 1) HTML document exists (created by using ODT document and saving as html) a) Heading tags b) bullet list with nested items c) numbered list with nested items d) Paragraph text e) Image f) table g) embedded Excel spreadsheet: TEST STEPS: 1) Log in as mahara user 2) create a portfolio page with a 3 column layout (default) 3) add an html block using the html file mentioned in preconditions Expected Result: The html should respect the portfolio page layout - so if a table is larger than the column, then scroll bars should be used. The Portfolio page should also respect the HTML file (if the file has bullet and numbered lists, they should be displayed correctly Actual Result: The portfolio page is displaying lists and tables incorrectly - see screenshot attached To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1826951/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826951] Re: Style conflict issues in html blocks in Portfolio pages
** Attachment added: "Page elements in HTML document.html" https://bugs.launchpad.net/mahara/+bug/1826951/+attachment/5260171/+files/Page%20elements%20in%20HTML%20document.html -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1826951 Title: Style conflict issues in html blocks in Portfolio pages Status in Mahara: New Bug description: TITLE: Style conflict issues in html blocks in Portfolio pages BUG SUMMARY: There seems to be a conflict with inline styles in an html document and the portfolio page styling. == Environment tested: Master Browser tested: Chrome PRECONDITIONS: 1) HTML document exists (created by using ODT document and saving as html) a) Heading tags b) bullet list with nested items c) numbered list with nested items d) Paragraph text e) Image f) table g) embedded Excel spreadsheet: TEST STEPS: 1) Log in as mahara user 2) create a portfolio page with a 3 column layout (default) 3) add an html block using the html file mentioned in preconditions Expected Result: The html should respect the portfolio page layout - so if a table is larger than the column, then scroll bars should be used. The Portfolio page should also respect the HTML file (if the file has bullet and numbered lists, they should be displayed correctly Actual Result: The portfolio page is displaying lists and tables incorrectly - see screenshot attached To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1826951/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826954] [NEW] Pending friends card has extra white space under request message
Public bug reported: The pending friends card seems to have excess white space underneath the request message (please see attached screenshot). To replicate: Have two users. 1. Log in as user A and send a friendship request to user B. 2. Log in as user B and navigate to pending friend request (either via People -> friendship requests, or via Dashboard notifications. 3. Click on the pending request to be taken to the user A profile (click on their user name) 4. Observe the pending friend request card Expected results: All elements display correctly Actual results: There is extra white space underneath the friendship request message. Testing in themes: raw, default, modern on Firefox. ** Affects: mahara Importance: Undecided Assignee: Evonne Cheung (evonne) Status: Fix Committed ** Attachment added: "Screenshot_2019-04-30 Cherry Watson (test0027) - Mahara.png" https://bugs.launchpad.net/bugs/1826954/+attachment/5260176/+files/Screenshot_2019-04-30%20Cherry%20Watson%20%28test0027%29%20-%20Mahara.png -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1826954 Title: Pending friends card has extra white space under request message Status in Mahara: Fix Committed Bug description: The pending friends card seems to have excess white space underneath the request message (please see attached screenshot). To replicate: Have two users. 1. Log in as user A and send a friendship request to user B. 2. Log in as user B and navigate to pending friend request (either via People -> friendship requests, or via Dashboard notifications. 3. Click on the pending request to be taken to the user A profile (click on their user name) 4. Observe the pending friend request card Expected results: All elements display correctly Actual results: There is extra white space underneath the friendship request message. Testing in themes: raw, default, modern on Firefox. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1826954/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826948] A patch has been submitted for review
Patch for "master" branch: https://reviews.mahara.org/9913 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1826948 Title: Comment text being saved with extra HTML tags Status in Mahara: New Bug description: In 18.04 we made a change which meant we inadvertently started saving comment text like this: http://www.w3.org/TR/REC-html40/loose.dtd";> comment text instead of like this: comment text this is because a call to loadHTML() adds the extra tags unless passed in flags tell it not to. As well as fixing this problem, we need to check that other places in the code that use loadHTML() are not also adding extra tags. Steps to reproduce: 1. Add a comment 2. Check the database and check what is stored in the artefact table for the text of that comment What you should see: The text of the comment you added inside tags What you currently see: The text of the comment you added inside the doctype and body tags as well. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1826948/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826954] Re: Pending friends card has extra white space under request message
** Changed in: mahara Status: New => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1826954 Title: Pending friends card has extra white space under request message Status in Mahara: Fix Committed Bug description: The pending friends card seems to have excess white space underneath the request message (please see attached screenshot). To replicate: Have two users. 1. Log in as user A and send a friendship request to user B. 2. Log in as user B and navigate to pending friend request (either via People -> friendship requests, or via Dashboard notifications. 3. Click on the pending request to be taken to the user A profile (click on their user name) 4. Observe the pending friend request card Expected results: All elements display correctly Actual results: There is extra white space underneath the friendship request message. Testing in themes: raw, default, modern on Firefox. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1826954/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826954] A patch has been submitted for review
Patch for "master" branch: https://reviews.mahara.org/9914 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1826954 Title: Pending friends card has extra white space under request message Status in Mahara: Fix Committed Bug description: The pending friends card seems to have excess white space underneath the request message (please see attached screenshot). To replicate: Have two users. 1. Log in as user A and send a friendship request to user B. 2. Log in as user B and navigate to pending friend request (either via People -> friendship requests, or via Dashboard notifications. 3. Click on the pending request to be taken to the user A profile (click on their user name) 4. Observe the pending friend request card Expected results: All elements display correctly Actual results: There is extra white space underneath the friendship request message. Testing in themes: raw, default, modern on Firefox. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1826954/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826954] Re: Pending friends card has extra white space under request message
** Changed in: mahara Status: Fix Committed => In Progress ** Changed in: mahara Milestone: None => 19.04.0 ** Changed in: mahara Importance: Undecided => Medium -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1826954 Title: Pending friends card has extra white space under request message Status in Mahara: In Progress Bug description: The pending friends card seems to have excess white space underneath the request message (please see attached screenshot). To replicate: Have two users. 1. Log in as user A and send a friendship request to user B. 2. Log in as user B and navigate to pending friend request (either via People -> friendship requests, or via Dashboard notifications. 3. Click on the pending request to be taken to the user A profile (click on their user name) 4. Observe the pending friend request card Expected results: All elements display correctly Actual results: There is extra white space underneath the friendship request message. Testing in themes: raw, default, modern on Firefox. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1826954/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826956] [NEW] Reading unread emails not marking them as read
Public bug reported: This is caused by changes with bootstrap going from panels to cards ** Affects: mahara Importance: High Assignee: Robert Lyon (robertl-9) Status: In Progress ** Changed in: mahara Status: New => In Progress ** Changed in: mahara Importance: Undecided => Medium ** Changed in: mahara Importance: Medium => High ** Changed in: mahara Milestone: None => 19.04.0 ** Changed in: mahara Assignee: (unassigned) => Robert Lyon (robertl-9) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1826956 Title: Reading unread emails not marking them as read Status in Mahara: In Progress Bug description: This is caused by changes with bootstrap going from panels to cards To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1826956/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826956] A patch has been submitted for review
Patch for "master" branch: https://reviews.mahara.org/9915 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1826956 Title: Reading unread emails not marking them as read Status in Mahara: In Progress Bug description: This is caused by changes with bootstrap going from panels to cards To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1826956/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826956] Re: Reading unread emails not marking them as read
To test: Have a user with notifications set to 'inbox' Send them some emails (as another user) Try reading email in inbox block on homepage Try reading email in inbox box -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1826956 Title: Reading unread emails not marking them as read Status in Mahara: In Progress Bug description: This is caused by changes with bootstrap going from panels to cards To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1826956/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826940] Re: Problem saving info to external_services_logs table
** Changed in: mahara
Status: New => In Progress
** Changed in: mahara
Importance: Undecided => Medium
** Changed in: mahara
Assignee: (unassigned) => Robert Lyon (robertl-9)
** Changed in: mahara
Milestone: None => 19.04.1
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1826940
Title:
Problem saving info to external_services_logs table
Status in Mahara:
In Progress
Bug description:
The 'auth' column is only 10 chars (as it expects one of OTHER, OAUTH,
TOKEN, TOKEN_USER, USER) and fails when it tries to save the wstoken
value string instead:
[DBG] bb (webservice/lib.php:1512) executing:
mahara_user_external/update_users
[WAR] bb (lib/errors.php:858) Failed to get a recordset: postgres8 error:
[-1: ERROR: value too long for type character varying(10)] in EXECUTE("INSERT
INTO "external_services_logs" ("id", "timelogged", "userid",
"externalserviceid", "institution", "protocol", "auth", "functionname",
"timetaken", "uri", "info", "ip") VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?,
?)")Command was: INSERT INTO "external_services_logs" ("id", "timelogged",
"userid", "externalserviceid", "institution", "protocol", "auth",
"functionname", "timetaken", "uri", "info", "ip") VALUES (?, ?, ?, ?, ?, ?, ?,
?, ?, ?, ?, ?) and values was
(id:16877,timelogged:1556571027,userid:8,externalserviceid:3,institution:wdhb,protocol:REST,auth:1234a2fcc061b24432191a1295958600,functionname:mahara_user_update_users,timetaken:0.26598191261292,uri:/webservice/rest/server.php?wstoken=1234a2fcc061b24432191a1295958600,info:exception:WebserviceInvalidParameterExceptionmessage:Invalidparametervaluedetected;executioncannotcontinue.:update_users|in...
Call stack (most recent first):
* insert_record(string(size 22), object(stdClass), string(size 2), true)
at //webservice/lib.php:1441
*
webservice_base_server->exception_handler(object(WebserviceInvalidParameterException))
at Unknown:
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1826940/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826951] Re: Style conflict issues in html blocks in Portfolio pages
** Changed in: mahara Status: New => Confirmed ** Changed in: mahara Importance: Undecided => Medium -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1826951 Title: Style conflict issues in html blocks in Portfolio pages Status in Mahara: Confirmed Bug description: TITLE: Style conflict issues in html blocks in Portfolio pages BUG SUMMARY: There seems to be a conflict with inline styles in an html document and the portfolio page styling. == Environment tested: Master Browser tested: Chrome PRECONDITIONS: 1) HTML document exists (created by using ODT document and saving as html) a) Heading tags b) bullet list with nested items c) numbered list with nested items d) Paragraph text e) Image f) table g) embedded Excel spreadsheet: TEST STEPS: 1) Log in as mahara user 2) create a portfolio page with a 3 column layout (default) 3) add an html block using the html file mentioned in preconditions Expected Result: The html should respect the portfolio page layout - so if a table is larger than the column, then scroll bars should be used. The Portfolio page should also respect the HTML file (if the file has bullet and numbered lists, they should be displayed correctly Actual Result: The portfolio page is displaying lists and tables incorrectly - see screenshot attached To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1826951/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826948] Re: Comment text being saved with extra HTML tags
** Changed in: mahara Status: New => In Progress ** Changed in: mahara Importance: Undecided => High ** Changed in: mahara Milestone: None => 19.04.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1826948 Title: Comment text being saved with extra HTML tags Status in Mahara: In Progress Bug description: In 18.04 we made a change which meant we inadvertently started saving comment text like this: http://www.w3.org/TR/REC-html40/loose.dtd";> comment text instead of like this: comment text this is because a call to loadHTML() adds the extra tags unless passed in flags tell it not to. As well as fixing this problem, we need to check that other places in the code that use loadHTML() are not also adding extra tags. Steps to reproduce: 1. Add a comment 2. Check the database and check what is stored in the artefact table for the text of that comment What you should see: The text of the comment you added inside tags What you currently see: The text of the comment you added inside the doctype and body tags as well. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1826948/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826788] A change has been merged
Reviewed: https://reviews.mahara.org/9894
Committed:
https://git.mahara.org/mahara/mahara/commit/a4a8e6ae5426c4d5eb100bc57ebd3d64096f4178
Submitter: Cecilia Vela Gurovic (cecili...@catalyst.net.nz)
Branch:master
commit a4a8e6ae5426c4d5eb100bc57ebd3d64096f4178
Author: Robert Lyon
Date: Mon Apr 29 12:55:16 2019 +1200
Bug 1826788: Allow tags on institutions / group items still show
When tags on an artefact / view / collection / blocktype not owned
by a user, but rather a group or institution we should still display
it for a user who belongs to that group / institution
behatnotneeded
Change-Id: I798f56826e1b285b54b8c430f6f7b89fac9b752e
Signed-off-by: Robert Lyon
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1826788
Title:
Tags under institutions cause error
Status in Mahara:
Fix Committed
Bug description:
We now have a system where we can use special 'Institution tags' but
we also allow institution admins to tag things in the normal was as
well. The following case causes the error:
[WAR] 9e (lib/form/elements/tags.php:100) Trying to get property of non-object
Call stack (most recent first):
log_message("Trying to get property of non-object", 8, true, true,
"/home/robertl/code/mahara-testing/mahara/htdocs/li...", 100) at
/home/robertl/code/mahara-testing/mahara/htdocs/lib/errors.php:520
error(8, "Trying to get property of non-object",
"/home/robertl/code/mahara-testing/mahara/htdocs/li...", 100, array(size 3)) at
/home/robertl/code/mahara-testing/mahara/htdocs/lib/form/elements/tags.php:100
display_tag("fats", array(size 2)) at
/home/robertl/code/mahara-testing/mahara/htdocs/artefact/file/lib.php:729
ArtefactTypeFileBase::get_my_files_data(0null, null, "insttwo", null) at
/home/robertl/code/mahara-testing/mahara/htdocs/lib/form/elements/filebrowser.php:164
Steps to reproduce:
1) Have a site with an institution (Institution A) that contains 2
institution admins
2) Institution admin A logs in and uploads a file to the Admin -> Institution
-> Files section
3) They then edit the file metadata and add a tag 'Cats'
4) They log out
5) Institution admin B logs in and goes to the Admin -> Institution -> Files
section
They see the error
6) They then edit the file metadata and instead of seeing 'Cats' they
see 'null'
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1826788/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826788] Re: Tags under institutions cause error
** Changed in: mahara
Status: In Progress => Fix Committed
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1826788
Title:
Tags under institutions cause error
Status in Mahara:
Fix Committed
Bug description:
We now have a system where we can use special 'Institution tags' but
we also allow institution admins to tag things in the normal was as
well. The following case causes the error:
[WAR] 9e (lib/form/elements/tags.php:100) Trying to get property of non-object
Call stack (most recent first):
log_message("Trying to get property of non-object", 8, true, true,
"/home/robertl/code/mahara-testing/mahara/htdocs/li...", 100) at
/home/robertl/code/mahara-testing/mahara/htdocs/lib/errors.php:520
error(8, "Trying to get property of non-object",
"/home/robertl/code/mahara-testing/mahara/htdocs/li...", 100, array(size 3)) at
/home/robertl/code/mahara-testing/mahara/htdocs/lib/form/elements/tags.php:100
display_tag("fats", array(size 2)) at
/home/robertl/code/mahara-testing/mahara/htdocs/artefact/file/lib.php:729
ArtefactTypeFileBase::get_my_files_data(0null, null, "insttwo", null) at
/home/robertl/code/mahara-testing/mahara/htdocs/lib/form/elements/filebrowser.php:164
Steps to reproduce:
1) Have a site with an institution (Institution A) that contains 2
institution admins
2) Institution admin A logs in and uploads a file to the Admin -> Institution
-> Files section
3) They then edit the file metadata and add a tag 'Cats'
4) They log out
5) Institution admin B logs in and goes to the Admin -> Institution -> Files
section
They see the error
6) They then edit the file metadata and instead of seeing 'Cats' they
see 'null'
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1826788/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826788] A change has been merged
Reviewed: https://reviews.mahara.org/9916
Committed:
https://git.mahara.org/mahara/mahara/commit/9c7f25de2c2185bbeb94302a1f5c2225f81dd2df
Submitter: Cecilia Vela Gurovic (cecili...@catalyst.net.nz)
Branch:19.04_STABLE
commit 9c7f25de2c2185bbeb94302a1f5c2225f81dd2df
Author: Robert Lyon
Date: Mon Apr 29 12:55:16 2019 +1200
Bug 1826788: Allow tags on institutions / group items still show
When tags on an artefact / view / collection / blocktype not owned
by a user, but rather a group or institution we should still display
it for a user who belongs to that group / institution
behatnotneeded
Change-Id: I798f56826e1b285b54b8c430f6f7b89fac9b752e
Signed-off-by: Robert Lyon
(cherry picked from commit a4a8e6ae5426c4d5eb100bc57ebd3d64096f4178)
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1826788
Title:
Tags under institutions cause error
Status in Mahara:
Fix Committed
Bug description:
We now have a system where we can use special 'Institution tags' but
we also allow institution admins to tag things in the normal was as
well. The following case causes the error:
[WAR] 9e (lib/form/elements/tags.php:100) Trying to get property of non-object
Call stack (most recent first):
log_message("Trying to get property of non-object", 8, true, true,
"/home/robertl/code/mahara-testing/mahara/htdocs/li...", 100) at
/home/robertl/code/mahara-testing/mahara/htdocs/lib/errors.php:520
error(8, "Trying to get property of non-object",
"/home/robertl/code/mahara-testing/mahara/htdocs/li...", 100, array(size 3)) at
/home/robertl/code/mahara-testing/mahara/htdocs/lib/form/elements/tags.php:100
display_tag("fats", array(size 2)) at
/home/robertl/code/mahara-testing/mahara/htdocs/artefact/file/lib.php:729
ArtefactTypeFileBase::get_my_files_data(0null, null, "insttwo", null) at
/home/robertl/code/mahara-testing/mahara/htdocs/lib/form/elements/filebrowser.php:164
Steps to reproduce:
1) Have a site with an institution (Institution A) that contains 2
institution admins
2) Institution admin A logs in and uploads a file to the Admin -> Institution
-> Files section
3) They then edit the file metadata and add a tag 'Cats'
4) They log out
5) Institution admin B logs in and goes to the Admin -> Institution -> Files
section
They see the error
6) They then edit the file metadata and instead of seeing 'Cats' they
see 'null'
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1826788/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826788] A patch has been submitted for review
Patch for "19.04_STABLE" branch: https://reviews.mahara.org/9916
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1826788
Title:
Tags under institutions cause error
Status in Mahara:
Fix Committed
Bug description:
We now have a system where we can use special 'Institution tags' but
we also allow institution admins to tag things in the normal was as
well. The following case causes the error:
[WAR] 9e (lib/form/elements/tags.php:100) Trying to get property of non-object
Call stack (most recent first):
log_message("Trying to get property of non-object", 8, true, true,
"/home/robertl/code/mahara-testing/mahara/htdocs/li...", 100) at
/home/robertl/code/mahara-testing/mahara/htdocs/lib/errors.php:520
error(8, "Trying to get property of non-object",
"/home/robertl/code/mahara-testing/mahara/htdocs/li...", 100, array(size 3)) at
/home/robertl/code/mahara-testing/mahara/htdocs/lib/form/elements/tags.php:100
display_tag("fats", array(size 2)) at
/home/robertl/code/mahara-testing/mahara/htdocs/artefact/file/lib.php:729
ArtefactTypeFileBase::get_my_files_data(0null, null, "insttwo", null) at
/home/robertl/code/mahara-testing/mahara/htdocs/lib/form/elements/filebrowser.php:164
Steps to reproduce:
1) Have a site with an institution (Institution A) that contains 2
institution admins
2) Institution admin A logs in and uploads a file to the Admin -> Institution
-> Files section
3) They then edit the file metadata and add a tag 'Cats'
4) They log out
5) Institution admin B logs in and goes to the Admin -> Institution -> Files
section
They see the error
6) They then edit the file metadata and instead of seeing 'Cats' they
see 'null'
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1826788/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826788] Re: Tags under institutions cause error
Commit hash: a4a8e6ae5426c4d5eb100bc57ebd3d64096f4178
Environment tested: Master
Browser tested: Chrome
Theme used: Raw
PRECONDITIONS:
1) Institution One exists
2) 2 Institution admins exist (UserA & UserB)
TEST STEPS:
1) Log in as Inst admin UserA
2) Browse to Admin -> Institution -> Files section and upload an image file
3) Edit the file metadata and add a tag 'Cats'
4) User log out and Log in as Inst admin UserB
5) Browse to Admin -> Institution -> Files section
6) Verify that there is no Error message displayed ✔
7) Edit the file metadata
8) Verify that the Tags Field displays the tag 'Cats' ✔
Catalyst QA Approved ✔
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1826788
Title:
Tags under institutions cause error
Status in Mahara:
Fix Committed
Bug description:
We now have a system where we can use special 'Institution tags' but
we also allow institution admins to tag things in the normal was as
well. The following case causes the error:
[WAR] 9e (lib/form/elements/tags.php:100) Trying to get property of non-object
Call stack (most recent first):
log_message("Trying to get property of non-object", 8, true, true,
"/home/robertl/code/mahara-testing/mahara/htdocs/li...", 100) at
/home/robertl/code/mahara-testing/mahara/htdocs/lib/errors.php:520
error(8, "Trying to get property of non-object",
"/home/robertl/code/mahara-testing/mahara/htdocs/li...", 100, array(size 3)) at
/home/robertl/code/mahara-testing/mahara/htdocs/lib/form/elements/tags.php:100
display_tag("fats", array(size 2)) at
/home/robertl/code/mahara-testing/mahara/htdocs/artefact/file/lib.php:729
ArtefactTypeFileBase::get_my_files_data(0null, null, "insttwo", null) at
/home/robertl/code/mahara-testing/mahara/htdocs/lib/form/elements/filebrowser.php:164
Steps to reproduce:
1) Have a site with an institution (Institution A) that contains 2
institution admins
2) Institution admin A logs in and uploads a file to the Admin -> Institution
-> Files section
3) They then edit the file metadata and add a tag 'Cats'
4) They log out
5) Institution admin B logs in and goes to the Admin -> Institution -> Files
section
They see the error
6) They then edit the file metadata and instead of seeing 'Cats' they
see 'null'
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1826788/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826048] A patch has been submitted for review
Patch for "19.04_STABLE" branch: https://reviews.mahara.org/9917 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1826048 Title: "Remove from watchlist" icon is missing Status in Mahara: Fix Committed Bug description: When you added a page to your watchlist and you want to remove it, you don't see the icon next to "Remove page from watchlist". To replicate: 1. Create 2 users. 2. Log in as user A and create a page that is shared with user B. 3. Log in as user B and comment on the page of user A. 4. Click the "More options" button on the page. Expected result: You can see "Remove page from watchlist" with the "eye-slash" FontAwesome icon like in 18.10 https://manual.mahara.org/en/18.10/_images/3_dots_expanded.png Actual result: The icon is missing (see attached screenshot). To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1826048/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826048] A change has been merged
Reviewed: https://reviews.mahara.org/9846 Committed: https://git.mahara.org/mahara/mahara/commit/cfeac8220a39dc016fda35554df1f0fd01853d12 Submitter: Cecilia Vela Gurovic (cecili...@catalyst.net.nz) Branch:master commit cfeac8220a39dc016fda35554df1f0fd01853d12 Author: Liam Date: Wed Apr 24 15:00:29 2019 +1200 Bug #1826048: "Remove from watchlist" icon is missing behatnotneeded Change-Id: I0d2291035d3f8873f30e0adfe769ecd54b3f874e -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1826048 Title: "Remove from watchlist" icon is missing Status in Mahara: Fix Committed Bug description: When you added a page to your watchlist and you want to remove it, you don't see the icon next to "Remove page from watchlist". To replicate: 1. Create 2 users. 2. Log in as user A and create a page that is shared with user B. 3. Log in as user B and comment on the page of user A. 4. Click the "More options" button on the page. Expected result: You can see "Remove page from watchlist" with the "eye-slash" FontAwesome icon like in 18.10 https://manual.mahara.org/en/18.10/_images/3_dots_expanded.png Actual result: The icon is missing (see attached screenshot). To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1826048/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826048] A change has been merged
Reviewed: https://reviews.mahara.org/9917 Committed: https://git.mahara.org/mahara/mahara/commit/360566d2bc3499ad85d863b08112d15c38646032 Submitter: Cecilia Vela Gurovic (cecili...@catalyst.net.nz) Branch:19.04_STABLE commit 360566d2bc3499ad85d863b08112d15c38646032 Author: Liam Date: Wed Apr 24 15:00:29 2019 +1200 Bug #1826048: "Remove from watchlist" icon is missing behatnotneeded Change-Id: I0d2291035d3f8873f30e0adfe769ecd54b3f874e (cherry picked from commit cfeac8220a39dc016fda35554df1f0fd01853d12) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1826048 Title: "Remove from watchlist" icon is missing Status in Mahara: Fix Committed Bug description: When you added a page to your watchlist and you want to remove it, you don't see the icon next to "Remove page from watchlist". To replicate: 1. Create 2 users. 2. Log in as user A and create a page that is shared with user B. 3. Log in as user B and comment on the page of user A. 4. Click the "More options" button on the page. Expected result: You can see "Remove page from watchlist" with the "eye-slash" FontAwesome icon like in 18.10 https://manual.mahara.org/en/18.10/_images/3_dots_expanded.png Actual result: The icon is missing (see attached screenshot). To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1826048/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826048] Re: "Remove from watchlist" icon is missing
** Changed in: mahara Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1826048 Title: "Remove from watchlist" icon is missing Status in Mahara: Fix Committed Bug description: When you added a page to your watchlist and you want to remove it, you don't see the icon next to "Remove page from watchlist". To replicate: 1. Create 2 users. 2. Log in as user A and create a page that is shared with user B. 3. Log in as user B and comment on the page of user A. 4. Click the "More options" button on the page. Expected result: You can see "Remove page from watchlist" with the "eye-slash" FontAwesome icon like in 18.10 https://manual.mahara.org/en/18.10/_images/3_dots_expanded.png Actual result: The icon is missing (see attached screenshot). To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1826048/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826788] Re: Tags under institutions cause error
PRECONDITIONS:
1) Group One exists
2) 2 group admins exist (UserA & UserB)
TEST STEPS: Group file tags
1) Log in as Group admin UserA
2) Browse to Group One -> Files section and upload an image file
3) Edit the file metadata and add a tag 'Cats'
4) User log out and Log in as Inst admin UserB
5) Browse to Group One -> Files section
6) Verify that there is no Error message displayed ✔
7) Edit the file metadata
8) Verify that the Tags Field displays the tag 'Cats' ✔
Catalyst QA Approved ✔
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1826788
Title:
Tags under institutions cause error
Status in Mahara:
Fix Committed
Bug description:
We now have a system where we can use special 'Institution tags' but
we also allow institution admins to tag things in the normal was as
well. The following case causes the error:
[WAR] 9e (lib/form/elements/tags.php:100) Trying to get property of non-object
Call stack (most recent first):
log_message("Trying to get property of non-object", 8, true, true,
"/home/robertl/code/mahara-testing/mahara/htdocs/li...", 100) at
/home/robertl/code/mahara-testing/mahara/htdocs/lib/errors.php:520
error(8, "Trying to get property of non-object",
"/home/robertl/code/mahara-testing/mahara/htdocs/li...", 100, array(size 3)) at
/home/robertl/code/mahara-testing/mahara/htdocs/lib/form/elements/tags.php:100
display_tag("fats", array(size 2)) at
/home/robertl/code/mahara-testing/mahara/htdocs/artefact/file/lib.php:729
ArtefactTypeFileBase::get_my_files_data(0null, null, "insttwo", null) at
/home/robertl/code/mahara-testing/mahara/htdocs/lib/form/elements/filebrowser.php:164
Steps to reproduce:
1) Have a site with an institution (Institution A) that contains 2
institution admins
2) Institution admin A logs in and uploads a file to the Admin -> Institution
-> Files section
3) They then edit the file metadata and add a tag 'Cats'
4) They log out
5) Institution admin B logs in and goes to the Admin -> Institution -> Files
section
They see the error
6) They then edit the file metadata and instead of seeing 'Cats' they
see 'null'
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1826788/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826954] A change has been merged
Reviewed: https://reviews.mahara.org/9918 Committed: https://git.mahara.org/mahara/mahara/commit/f69d794145b4505ed2400fdc3df6b5d0416898f6 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:19.04_STABLE commit f69d794145b4505ed2400fdc3df6b5d0416898f6 Author: Evonne Cheung Date: Tue Apr 30 12:33:16 2019 +1200 Bug #1826954 Pending friends card has extra white space under request message Fixed warning status card-body to white, also fixed the warning footer which was wrongly inheriting info color. behatnotneeded Change-Id: Ib8407b65d963bca2e637c296e2c6c23f1e4da645 (cherry picked from commit 6cc2ccd036aa91ffdfad0889ad5de47153fde74e) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1826954 Title: Pending friends card has extra white space under request message Status in Mahara: Fix Committed Bug description: The pending friends card seems to have excess white space underneath the request message (please see attached screenshot). To replicate: Have two users. 1. Log in as user A and send a friendship request to user B. 2. Log in as user B and navigate to pending friend request (either via People -> friendship requests, or via Dashboard notifications. 3. Click on the pending request to be taken to the user A profile (click on their user name) 4. Observe the pending friend request card Expected results: All elements display correctly Actual results: There is extra white space underneath the friendship request message. Testing in themes: raw, default, modern on Firefox. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1826954/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826954] A change has been merged
Reviewed: https://reviews.mahara.org/9914 Committed: https://git.mahara.org/mahara/mahara/commit/6cc2ccd036aa91ffdfad0889ad5de47153fde74e Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:master commit 6cc2ccd036aa91ffdfad0889ad5de47153fde74e Author: Evonne Cheung Date: Tue Apr 30 12:33:16 2019 +1200 Bug #1826954 Pending friends card has extra white space under request message Fixed warning status card-body to white, also fixed the warning footer which was wrongly inheriting info color. behatnotneeded Change-Id: Ib8407b65d963bca2e637c296e2c6c23f1e4da645 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1826954 Title: Pending friends card has extra white space under request message Status in Mahara: Fix Committed Bug description: The pending friends card seems to have excess white space underneath the request message (please see attached screenshot). To replicate: Have two users. 1. Log in as user A and send a friendship request to user B. 2. Log in as user B and navigate to pending friend request (either via People -> friendship requests, or via Dashboard notifications. 3. Click on the pending request to be taken to the user A profile (click on their user name) 4. Observe the pending friend request card Expected results: All elements display correctly Actual results: There is extra white space underneath the friendship request message. Testing in themes: raw, default, modern on Firefox. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1826954/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826954] Re: Pending friends card has extra white space under request message
** Changed in: mahara Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1826954 Title: Pending friends card has extra white space under request message Status in Mahara: Fix Committed Bug description: The pending friends card seems to have excess white space underneath the request message (please see attached screenshot). To replicate: Have two users. 1. Log in as user A and send a friendship request to user B. 2. Log in as user B and navigate to pending friend request (either via People -> friendship requests, or via Dashboard notifications. 3. Click on the pending request to be taken to the user A profile (click on their user name) 4. Observe the pending friend request card Expected results: All elements display correctly Actual results: There is extra white space underneath the friendship request message. Testing in themes: raw, default, modern on Firefox. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1826954/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826954] A patch has been submitted for review
Patch for "19.04_STABLE" branch: https://reviews.mahara.org/9918 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1826954 Title: Pending friends card has extra white space under request message Status in Mahara: Fix Committed Bug description: The pending friends card seems to have excess white space underneath the request message (please see attached screenshot). To replicate: Have two users. 1. Log in as user A and send a friendship request to user B. 2. Log in as user B and navigate to pending friend request (either via People -> friendship requests, or via Dashboard notifications. 3. Click on the pending request to be taken to the user A profile (click on their user name) 4. Observe the pending friend request card Expected results: All elements display correctly Actual results: There is extra white space underneath the friendship request message. Testing in themes: raw, default, modern on Firefox. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1826954/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826937] Re: Deleting comment in artefact view causes undefined property error
** Changed in: mahara
Milestone: None => 19.04.0
** Changed in: mahara
Importance: Undecided => Medium
** Changed in: mahara
Status: New => Fix Committed
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1826937
Title:
Deleting comment in artefact view causes undefined property error
Status in Mahara:
Fix Committed
Bug description:
[WAR] 7e (artefact/comment/lib.php:1465) Trying to get property of non-object
Call stack (most recent first):
log_message("Trying to get property of non-object", 8, true, true,
"/home/robertl/code/mahara-devel/mahara/htdocs/arte...", 1465) at
/home/robertl/code/mahara-devel/mahara/htdocs/lib/errors.php:520
error(8, "Trying to get property of non-object",
"/home/robertl/code/mahara-devel/mahara/htdocs/arte...", 1465, array(size 13))
at /home/robertl/code/mahara-devel/mahara/htdocs/artefact/comment/lib.php:1465
delete_comment_submit(object(Pieform), array(size 3)) at
/home/robertl/code/mahara-devel/mahara/htdocs/lib/pieforms/pieform.php:544
This is because we are checking the view id rather than the artefact
id the comment is attached to
To replicate:
1. Create 2 users.
2. Log in as user A and create a page containing an image block
3. Shared page with user B.
4. Log in as user B and comment on the image block.
5. Delete the comment.
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1826937/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826937] A change has been merged
Reviewed: https://reviews.mahara.org/9906
Committed:
https://git.mahara.org/mahara/mahara/commit/751e070180d9a489e7b346adf60760215cb090ef
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master
commit 751e070180d9a489e7b346adf60760215cb090ef
Author: Robert Lyon
Date: Tue Apr 30 09:09:42 2019 +1200
Bug 1826937: Check correct id when deleting the comment from artefact
behatnotneeded
Change-Id: Ibe357e17ac9b37380cb4fc6c9c21615db9137ac6
Signed-off-by: Robert Lyon
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1826937
Title:
Deleting comment in artefact view causes undefined property error
Status in Mahara:
Fix Committed
Bug description:
[WAR] 7e (artefact/comment/lib.php:1465) Trying to get property of non-object
Call stack (most recent first):
log_message("Trying to get property of non-object", 8, true, true,
"/home/robertl/code/mahara-devel/mahara/htdocs/arte...", 1465) at
/home/robertl/code/mahara-devel/mahara/htdocs/lib/errors.php:520
error(8, "Trying to get property of non-object",
"/home/robertl/code/mahara-devel/mahara/htdocs/arte...", 1465, array(size 13))
at /home/robertl/code/mahara-devel/mahara/htdocs/artefact/comment/lib.php:1465
delete_comment_submit(object(Pieform), array(size 3)) at
/home/robertl/code/mahara-devel/mahara/htdocs/lib/pieforms/pieform.php:544
This is because we are checking the view id rather than the artefact
id the comment is attached to
To replicate:
1. Create 2 users.
2. Log in as user A and create a page containing an image block
3. Shared page with user B.
4. Log in as user B and comment on the image block.
5. Delete the comment.
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1826937/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826937] A change has been merged
Reviewed: https://reviews.mahara.org/9919
Committed:
https://git.mahara.org/mahara/mahara/commit/7f688075e93cd7550360b8d27f40ebfd078ce6dd
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:19.04_STABLE
commit 7f688075e93cd7550360b8d27f40ebfd078ce6dd
Author: Robert Lyon
Date: Tue Apr 30 09:09:42 2019 +1200
Bug 1826937: Check correct id when deleting the comment from artefact
behatnotneeded
Change-Id: Ibe357e17ac9b37380cb4fc6c9c21615db9137ac6
Signed-off-by: Robert Lyon
(cherry picked from commit 751e070180d9a489e7b346adf60760215cb090ef)
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1826937
Title:
Deleting comment in artefact view causes undefined property error
Status in Mahara:
Fix Committed
Bug description:
[WAR] 7e (artefact/comment/lib.php:1465) Trying to get property of non-object
Call stack (most recent first):
log_message("Trying to get property of non-object", 8, true, true,
"/home/robertl/code/mahara-devel/mahara/htdocs/arte...", 1465) at
/home/robertl/code/mahara-devel/mahara/htdocs/lib/errors.php:520
error(8, "Trying to get property of non-object",
"/home/robertl/code/mahara-devel/mahara/htdocs/arte...", 1465, array(size 13))
at /home/robertl/code/mahara-devel/mahara/htdocs/artefact/comment/lib.php:1465
delete_comment_submit(object(Pieform), array(size 3)) at
/home/robertl/code/mahara-devel/mahara/htdocs/lib/pieforms/pieform.php:544
This is because we are checking the view id rather than the artefact
id the comment is attached to
To replicate:
1. Create 2 users.
2. Log in as user A and create a page containing an image block
3. Shared page with user B.
4. Log in as user B and comment on the image block.
5. Delete the comment.
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1826937/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826937] A patch has been submitted for review
Patch for "19.04_STABLE" branch: https://reviews.mahara.org/9919
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1826937
Title:
Deleting comment in artefact view causes undefined property error
Status in Mahara:
Fix Committed
Bug description:
[WAR] 7e (artefact/comment/lib.php:1465) Trying to get property of non-object
Call stack (most recent first):
log_message("Trying to get property of non-object", 8, true, true,
"/home/robertl/code/mahara-devel/mahara/htdocs/arte...", 1465) at
/home/robertl/code/mahara-devel/mahara/htdocs/lib/errors.php:520
error(8, "Trying to get property of non-object",
"/home/robertl/code/mahara-devel/mahara/htdocs/arte...", 1465, array(size 13))
at /home/robertl/code/mahara-devel/mahara/htdocs/artefact/comment/lib.php:1465
delete_comment_submit(object(Pieform), array(size 3)) at
/home/robertl/code/mahara-devel/mahara/htdocs/lib/pieforms/pieform.php:544
This is because we are checking the view id rather than the artefact
id the comment is attached to
To replicate:
1. Create 2 users.
2. Log in as user A and create a page containing an image block
3. Shared page with user B.
4. Log in as user B and comment on the image block.
5. Delete the comment.
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1826937/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826960] [NEW] On import of a Leap2A file, some import questions out of alignment
Public bug reported: When you import a Leap2A file, you get a list of questions for whether you want to "Add new" or "Ignore" certain items. There are some alignment issues on that page, particularly with the Journals (See screenshot) Steps to reproduce: 1. Upload a Leap2A file including one or more journals Expected result: The questions/ radio buttons should all be in alignment. The text should be in alignment. Actual result: The journals' radio buttons appear underneath the heading instead of in the right-hand column There are inconsistencies in the font sizes and alignment of text. ** Affects: mahara Importance: Undecided Status: New ** Attachment added: "Screenshot from 2019-04-30 14-13-07.png" https://bugs.launchpad.net/bugs/1826960/+attachment/5260186/+files/Screenshot%20from%202019-04-30%2014-13-07.png -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1826960 Title: On import of a Leap2A file, some import questions out of alignment Status in Mahara: New Bug description: When you import a Leap2A file, you get a list of questions for whether you want to "Add new" or "Ignore" certain items. There are some alignment issues on that page, particularly with the Journals (See screenshot) Steps to reproduce: 1. Upload a Leap2A file including one or more journals Expected result: The questions/ radio buttons should all be in alignment. The text should be in alignment. Actual result: The journals' radio buttons appear underneath the heading instead of in the right-hand column There are inconsistencies in the font sizes and alignment of text. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1826960/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826960] Re: On import of a Leap2A file, some import questions out of alignment
Example of mis-aligned text ** Attachment added: "Screenshot from 2019-04-30 14-29-18.png" https://bugs.launchpad.net/mahara/+bug/1826960/+attachment/5260187/+files/Screenshot%20from%202019-04-30%2014-29-18.png -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1826960 Title: On import of a Leap2A file, some import questions out of alignment Status in Mahara: New Bug description: When you import a Leap2A file, you get a list of questions for whether you want to "Add new" or "Ignore" certain items. There are some alignment issues on that page, particularly with the Journals (See screenshot) Steps to reproduce: 1. Upload a Leap2A file including one or more journals Expected result: The questions/ radio buttons should all be in alignment. The text should be in alignment. Actual result: The journals' radio buttons appear underneath the heading instead of in the right-hand column There are inconsistencies in the font sizes and alignment of text. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1826960/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826956] Re: Reading unread emails not marking them as read
Commit hash: 6b74e621d3f43fa54a01f7f7413bce226e7bab4e Environment tested: Master Browser tested: Chrome Theme used: Raw PRECONDITIONS: 1) Mahara user exists (no roles User3) a) notifications set to 'inbox' 2) User has unread notifications in their inbox TEST STEPS: 1) Log in as Mahara User1 2) Verify that user has unread notifications (Subject text is bold & Inbox unread notification counter will indicate how many) 3) Click on the notification 4) Verify that the Subject text is now displayed as regular text 5) Verify that the unread notification counter indicates one less for the count) Catalyst QA Approved ✔ -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1826956 Title: Reading unread emails not marking them as read Status in Mahara: In Progress Bug description: This is caused by changes with bootstrap going from panels to cards To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1826956/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826961] [NEW] Edit group membership modal checkboxes out of alignment
Public bug reported: As admin: Create a group go to People page and click on edit group membership link ** Affects: mahara Importance: Undecided Status: New -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1826961 Title: Edit group membership modal checkboxes out of alignment Status in Mahara: New Bug description: As admin: Create a group go to People page and click on edit group membership link To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1826961/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826961] A patch has been submitted for review
Patch for "master" branch: https://reviews.mahara.org/9920 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1826961 Title: Edit group membership modal checkboxes out of alignment Status in Mahara: New Bug description: As admin: Create a group go to People page and click on edit group membership link To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1826961/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826974] [NEW] Deleting non-institutional tag from file produces a warning
Public bug reported: Adding a tag that isn't an institutional tag to a file and saving but then later removing that tag is producing a warning message (see screenshot attached). To replicate: 1/ Upload a file 2/ Edit the file and enter a non-institutional tag (can be a new one), Save changes 4/ Edit the file again and delete the tag, Save changes 5/ Refresh the page Expected result: No warnings are displayed Actual result: Warning is displayed ** Affects: mahara Importance: Undecided Assignee: Lisa Seeto (lisaseeto) Status: In Progress ** Attachment added: "Screenshot_2019-04-30 Files - Mahara.png" https://bugs.launchpad.net/bugs/1826974/+attachment/5260205/+files/Screenshot_2019-04-30%20Files%20-%20Mahara.png ** Changed in: mahara Status: New => In Progress -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1826974 Title: Deleting non-institutional tag from file produces a warning Status in Mahara: In Progress Bug description: Adding a tag that isn't an institutional tag to a file and saving but then later removing that tag is producing a warning message (see screenshot attached). To replicate: 1/ Upload a file 2/ Edit the file and enter a non-institutional tag (can be a new one), Save changes 4/ Edit the file again and delete the tag, Save changes 5/ Refresh the page Expected result: No warnings are displayed Actual result: Warning is displayed To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1826974/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826974] A patch has been submitted for review
Patch for "master" branch: https://reviews.mahara.org/9921 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1826974 Title: Deleting non-institutional tag from file produces a warning Status in Mahara: In Progress Bug description: Adding a tag that isn't an institutional tag to a file and saving but then later removing that tag is producing a warning message (see screenshot attached). To replicate: 1/ Upload a file 2/ Edit the file and enter a non-institutional tag (can be a new one), Save changes 4/ Edit the file again and delete the tag, Save changes 5/ Refresh the page Expected result: No warnings are displayed Actual result: Warning is displayed To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1826974/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826974] Re: Deleting non-institutional tag from file produces a warning
** Changed in: mahara Importance: Undecided => Medium -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1826974 Title: Deleting non-institutional tag from file produces a warning Status in Mahara: In Progress Bug description: Adding a tag that isn't an institutional tag to a file and saving but then later removing that tag is producing a warning message (see screenshot attached). To replicate: 1/ Upload a file 2/ Edit the file and enter a non-institutional tag (can be a new one), Save changes 4/ Edit the file again and delete the tag, Save changes 5/ Refresh the page Expected result: No warnings are displayed Actual result: Warning is displayed To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1826974/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826961] Re: Edit group membership modal checkboxes out of alignment
** Changed in: mahara Status: New => In Progress ** Changed in: mahara Importance: Undecided => Medium -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1826961 Title: Edit group membership modal checkboxes out of alignment Status in Mahara: In Progress Bug description: As admin: Create a group go to People page and click on edit group membership link To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1826961/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826961] A change has been merged
Reviewed: https://reviews.mahara.org/9920 Committed: https://git.mahara.org/mahara/mahara/commit/506ad095c05748bed5f108689629f5336b0c5db9 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:master commit 506ad095c05748bed5f108689629f5336b0c5db9 Author: Robert Lyon Date: Tue Apr 30 14:32:57 2019 +1200 Bug 1826961: Aligning text boxes better behatnotneeded Change-Id: If6ff16c294dd1b43624eec2ebee211fb5aebcf31 Signed-off-by: Robert Lyon -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1826961 Title: Edit group membership modal checkboxes out of alignment Status in Mahara: Fix Committed Bug description: As admin: Create a group go to People page and click on edit group membership link To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1826961/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826961] Re: Edit group membership modal checkboxes out of alignment
** Changed in: mahara Status: In Progress => Fix Committed ** Changed in: mahara Milestone: None => 19.04.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1826961 Title: Edit group membership modal checkboxes out of alignment Status in Mahara: Fix Committed Bug description: As admin: Create a group go to People page and click on edit group membership link To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1826961/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826961] A patch has been submitted for review
Patch for "19.04_STABLE" branch: https://reviews.mahara.org/9924 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1826961 Title: Edit group membership modal checkboxes out of alignment Status in Mahara: Fix Committed Bug description: As admin: Create a group go to People page and click on edit group membership link To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1826961/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826960] Re: On import of a Leap2A file, some import questions out of alignment
** Changed in: mahara Status: New => In Progress ** Changed in: mahara Importance: Undecided => Medium ** Changed in: mahara Assignee: (unassigned) => Robert Lyon (robertl-9) ** Changed in: mahara Status: In Progress => Fix Committed ** Changed in: mahara Milestone: None => 19.04.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1826960 Title: On import of a Leap2A file, some import questions out of alignment Status in Mahara: Fix Committed Bug description: When you import a Leap2A file, you get a list of questions for whether you want to "Add new" or "Ignore" certain items. There are some alignment issues on that page, particularly with the Journals (See screenshot) Steps to reproduce: 1. Upload a Leap2A file including one or more journals Expected result: The questions/ radio buttons should all be in alignment. The text should be in alignment. Actual result: The journals' radio buttons appear underneath the heading instead of in the right-hand column There are inconsistencies in the font sizes and alignment of text. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1826960/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826960] A patch has been submitted for review
Patch for "19.04_STABLE" branch: https://reviews.mahara.org/9923 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1826960 Title: On import of a Leap2A file, some import questions out of alignment Status in Mahara: Fix Committed Bug description: When you import a Leap2A file, you get a list of questions for whether you want to "Add new" or "Ignore" certain items. There are some alignment issues on that page, particularly with the Journals (See screenshot) Steps to reproduce: 1. Upload a Leap2A file including one or more journals Expected result: The questions/ radio buttons should all be in alignment. The text should be in alignment. Actual result: The journals' radio buttons appear underneath the heading instead of in the right-hand column There are inconsistencies in the font sizes and alignment of text. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1826960/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826960] A change has been merged
Reviewed: https://reviews.mahara.org/9922 Committed: https://git.mahara.org/mahara/mahara/commit/9ec6646bb4460fcc29b25bd16851095ac26a4569 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:master commit 9ec6646bb4460fcc29b25bd16851095ac26a4569 Author: Robert Lyon Date: Tue Apr 30 15:51:58 2019 +1200 Bug 1826960: Import choosing screen alignment fix Allow the journal / plan headers to not be floated behatnotneeded Change-Id: Icf1552e2c4c1c62e48c5109e0ea27b3770de3608 Signed-off-by: Robert Lyon -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1826960 Title: On import of a Leap2A file, some import questions out of alignment Status in Mahara: Fix Committed Bug description: When you import a Leap2A file, you get a list of questions for whether you want to "Add new" or "Ignore" certain items. There are some alignment issues on that page, particularly with the Journals (See screenshot) Steps to reproduce: 1. Upload a Leap2A file including one or more journals Expected result: The questions/ radio buttons should all be in alignment. The text should be in alignment. Actual result: The journals' radio buttons appear underneath the heading instead of in the right-hand column There are inconsistencies in the font sizes and alignment of text. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1826960/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826961] A change has been merged
Reviewed: https://reviews.mahara.org/9924 Committed: https://git.mahara.org/mahara/mahara/commit/a3f6836de6c9cf116f47a1ee35648a228af103ff Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:19.04_STABLE commit a3f6836de6c9cf116f47a1ee35648a228af103ff Author: Robert Lyon Date: Tue Apr 30 14:32:57 2019 +1200 Bug 1826961: Aligning text boxes better behatnotneeded Change-Id: If6ff16c294dd1b43624eec2ebee211fb5aebcf31 Signed-off-by: Robert Lyon (cherry picked from commit 506ad095c05748bed5f108689629f5336b0c5db9) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1826961 Title: Edit group membership modal checkboxes out of alignment Status in Mahara: Fix Committed Bug description: As admin: Create a group go to People page and click on edit group membership link To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1826961/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826960] A change has been merged
Reviewed: https://reviews.mahara.org/9923 Committed: https://git.mahara.org/mahara/mahara/commit/a2b936339abd9c33c976c56c86b7c26a6836f894 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:19.04_STABLE commit a2b936339abd9c33c976c56c86b7c26a6836f894 Author: Robert Lyon Date: Tue Apr 30 15:51:58 2019 +1200 Bug 1826960: Import choosing screen alignment fix Allow the journal / plan headers to not be floated behatnotneeded Change-Id: Icf1552e2c4c1c62e48c5109e0ea27b3770de3608 Signed-off-by: Robert Lyon (cherry picked from commit 9ec6646bb4460fcc29b25bd16851095ac26a4569) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1826960 Title: On import of a Leap2A file, some import questions out of alignment Status in Mahara: Fix Committed Bug description: When you import a Leap2A file, you get a list of questions for whether you want to "Add new" or "Ignore" certain items. There are some alignment issues on that page, particularly with the Journals (See screenshot) Steps to reproduce: 1. Upload a Leap2A file including one or more journals Expected result: The questions/ radio buttons should all be in alignment. The text should be in alignment. Actual result: The journals' radio buttons appear underneath the heading instead of in the right-hand column There are inconsistencies in the font sizes and alignment of text. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1826960/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826960] A patch has been submitted for review
Patch for "master" branch: https://reviews.mahara.org/9922 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1826960 Title: On import of a Leap2A file, some import questions out of alignment Status in Mahara: Fix Committed Bug description: When you import a Leap2A file, you get a list of questions for whether you want to "Add new" or "Ignore" certain items. There are some alignment issues on that page, particularly with the Journals (See screenshot) Steps to reproduce: 1. Upload a Leap2A file including one or more journals Expected result: The questions/ radio buttons should all be in alignment. The text should be in alignment. Actual result: The journals' radio buttons appear underneath the heading instead of in the right-hand column There are inconsistencies in the font sizes and alignment of text. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1826960/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826974] A change has been merged
Reviewed: https://reviews.mahara.org/9921 Committed: https://git.mahara.org/mahara/mahara/commit/9cfe3bb987c4bc270ec865f1e6f84a12246d26bf Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:master commit 9cfe3bb987c4bc270ec865f1e6f84a12246d26bf Author: Lisa Seeto Date: Tue Apr 30 15:11:12 2019 +1200 Bug 1826974: Deleting a non-instiutional tag from file produces a warning remove_prefix from newtag only if it's not empty behatnotneeded Change-Id: I7605e1bdf05b8f2238d2fba2e95b1f9919e899a0 Signed-off-by: Lisa Seeto -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1826974 Title: Deleting non-institutional tag from file produces a warning Status in Mahara: Fix Committed Bug description: Adding a tag that isn't an institutional tag to a file and saving but then later removing that tag is producing a warning message (see screenshot attached). To replicate: 1/ Upload a file 2/ Edit the file and enter a non-institutional tag (can be a new one), Save changes 4/ Edit the file again and delete the tag, Save changes 5/ Refresh the page Expected result: No warnings are displayed Actual result: Warning is displayed To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1826974/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826974] Re: Deleting non-institutional tag from file produces a warning
** Changed in: mahara Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1826974 Title: Deleting non-institutional tag from file produces a warning Status in Mahara: Fix Committed Bug description: Adding a tag that isn't an institutional tag to a file and saving but then later removing that tag is producing a warning message (see screenshot attached). To replicate: 1/ Upload a file 2/ Edit the file and enter a non-institutional tag (can be a new one), Save changes 4/ Edit the file again and delete the tag, Save changes 5/ Refresh the page Expected result: No warnings are displayed Actual result: Warning is displayed To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1826974/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826974] A patch has been submitted for review
Patch for "19.04_STABLE" branch: https://reviews.mahara.org/9925 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1826974 Title: Deleting non-institutional tag from file produces a warning Status in Mahara: Fix Committed Bug description: Adding a tag that isn't an institutional tag to a file and saving but then later removing that tag is producing a warning message (see screenshot attached). To replicate: 1/ Upload a file 2/ Edit the file and enter a non-institutional tag (can be a new one), Save changes 4/ Edit the file again and delete the tag, Save changes 5/ Refresh the page Expected result: No warnings are displayed Actual result: Warning is displayed To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1826974/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826974] Re: Deleting non-institutional tag from file produces a warning
** Changed in: mahara Milestone: None => 19.04.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1826974 Title: Deleting non-institutional tag from file produces a warning Status in Mahara: Fix Committed Bug description: Adding a tag that isn't an institutional tag to a file and saving but then later removing that tag is producing a warning message (see screenshot attached). To replicate: 1/ Upload a file 2/ Edit the file and enter a non-institutional tag (can be a new one), Save changes 4/ Edit the file again and delete the tag, Save changes 5/ Refresh the page Expected result: No warnings are displayed Actual result: Warning is displayed To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1826974/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826974] A change has been merged
Reviewed: https://reviews.mahara.org/9925 Committed: https://git.mahara.org/mahara/mahara/commit/6b56f52dce9fbe5c6b585dc7801c005e5ebd6d57 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:19.04_STABLE commit 6b56f52dce9fbe5c6b585dc7801c005e5ebd6d57 Author: Lisa Seeto Date: Tue Apr 30 15:11:12 2019 +1200 Bug 1826974: Deleting a non-instiutional tag from file produces a warning remove_prefix from newtag only if it's not empty behatnotneeded Change-Id: I7605e1bdf05b8f2238d2fba2e95b1f9919e899a0 Signed-off-by: Lisa Seeto (cherry picked from commit 9cfe3bb987c4bc270ec865f1e6f84a12246d26bf) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1826974 Title: Deleting non-institutional tag from file produces a warning Status in Mahara: Fix Committed Bug description: Adding a tag that isn't an institutional tag to a file and saving but then later removing that tag is producing a warning message (see screenshot attached). To replicate: 1/ Upload a file 2/ Edit the file and enter a non-institutional tag (can be a new one), Save changes 4/ Edit the file again and delete the tag, Save changes 5/ Refresh the page Expected result: No warnings are displayed Actual result: Warning is displayed To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1826974/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826948] A change has been merged
Reviewed: https://reviews.mahara.org/9913 Committed: https://git.mahara.org/mahara/mahara/commit/9a42c68064f7c3293677d3ca5f5a5d8cf89d498a Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:master commit 9a42c68064f7c3293677d3ca5f5a5d8cf89d498a Author: Cecilia Vela Gurovic Date: Tue Apr 30 12:32:20 2019 +1200 Bug 1826948: update existing comments behatnotneeded Change-Id: I71bcdb6c98aa1382692a93db2399547e71838f19 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1826948 Title: Comment text being saved with extra HTML tags Status in Mahara: Fix Committed Bug description: In 18.04 we made a change which meant we inadvertently started saving comment text like this: http://www.w3.org/TR/REC-html40/loose.dtd";> comment text instead of like this: comment text this is because a call to loadHTML() adds the extra tags unless passed in flags tell it not to. As well as fixing this problem, we need to check that other places in the code that use loadHTML() are not also adding extra tags. Steps to reproduce: 1. Add a comment 2. Check the database and check what is stored in the artefact table for the text of that comment What you should see: The text of the comment you added inside tags What you currently see: The text of the comment you added inside the doctype and body tags as well. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1826948/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826948] A patch has been submitted for review
Patch for "19.04_STABLE" branch: https://reviews.mahara.org/9927 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1826948 Title: Comment text being saved with extra HTML tags Status in Mahara: Fix Committed Bug description: In 18.04 we made a change which meant we inadvertently started saving comment text like this: http://www.w3.org/TR/REC-html40/loose.dtd";> comment text instead of like this: comment text this is because a call to loadHTML() adds the extra tags unless passed in flags tell it not to. As well as fixing this problem, we need to check that other places in the code that use loadHTML() are not also adding extra tags. Steps to reproduce: 1. Add a comment 2. Check the database and check what is stored in the artefact table for the text of that comment What you should see: The text of the comment you added inside tags What you currently see: The text of the comment you added inside the doctype and body tags as well. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1826948/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826948] A change has been merged
Reviewed: https://reviews.mahara.org/9912 Committed: https://git.mahara.org/mahara/mahara/commit/8a9170d8a6af3e008846ab02e43924f3f9fe6d45 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:master commit 8a9170d8a6af3e008846ab02e43924f3f9fe6d45 Author: Rebecca Blundell Date: Tue Apr 30 12:03:42 2019 +1200 Bug 1826948: Stop comment text being saved with extra tags added flags to loadHTML to stop it adding doctype and body tags to the comment. behatnotneeded Change-Id: I9c9b7fd7f58a6db793212e6f82be56d3d46f3eeb -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1826948 Title: Comment text being saved with extra HTML tags Status in Mahara: Fix Committed Bug description: In 18.04 we made a change which meant we inadvertently started saving comment text like this: http://www.w3.org/TR/REC-html40/loose.dtd";> comment text instead of like this: comment text this is because a call to loadHTML() adds the extra tags unless passed in flags tell it not to. As well as fixing this problem, we need to check that other places in the code that use loadHTML() are not also adding extra tags. Steps to reproduce: 1. Add a comment 2. Check the database and check what is stored in the artefact table for the text of that comment What you should see: The text of the comment you added inside tags What you currently see: The text of the comment you added inside the doctype and body tags as well. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1826948/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826948] A patch has been submitted for review
Patch for "19.04_STABLE" branch: https://reviews.mahara.org/9926 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1826948 Title: Comment text being saved with extra HTML tags Status in Mahara: Fix Committed Bug description: In 18.04 we made a change which meant we inadvertently started saving comment text like this: http://www.w3.org/TR/REC-html40/loose.dtd";> comment text instead of like this: comment text this is because a call to loadHTML() adds the extra tags unless passed in flags tell it not to. As well as fixing this problem, we need to check that other places in the code that use loadHTML() are not also adding extra tags. Steps to reproduce: 1. Add a comment 2. Check the database and check what is stored in the artefact table for the text of that comment What you should see: The text of the comment you added inside tags What you currently see: The text of the comment you added inside the doctype and body tags as well. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1826948/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826948] A change has been merged
Reviewed: https://reviews.mahara.org/9926 Committed: https://git.mahara.org/mahara/mahara/commit/6e4540101a32293cd12197d0babc0144ed429410 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:19.04_STABLE commit 6e4540101a32293cd12197d0babc0144ed429410 Author: Rebecca Blundell Date: Tue Apr 30 12:03:42 2019 +1200 Bug 1826948: Stop comment text being saved with extra tags added flags to loadHTML to stop it adding doctype and body tags to the comment. behatnotneeded Change-Id: I9c9b7fd7f58a6db793212e6f82be56d3d46f3eeb (cherry picked from commit 8a9170d8a6af3e008846ab02e43924f3f9fe6d45) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1826948 Title: Comment text being saved with extra HTML tags Status in Mahara: Fix Committed Bug description: In 18.04 we made a change which meant we inadvertently started saving comment text like this: http://www.w3.org/TR/REC-html40/loose.dtd";> comment text instead of like this: comment text this is because a call to loadHTML() adds the extra tags unless passed in flags tell it not to. As well as fixing this problem, we need to check that other places in the code that use loadHTML() are not also adding extra tags. Steps to reproduce: 1. Add a comment 2. Check the database and check what is stored in the artefact table for the text of that comment What you should see: The text of the comment you added inside tags What you currently see: The text of the comment you added inside the doctype and body tags as well. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1826948/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826948] Re: Comment text being saved with extra HTML tags
** Changed in: mahara Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1826948 Title: Comment text being saved with extra HTML tags Status in Mahara: Fix Committed Bug description: In 18.04 we made a change which meant we inadvertently started saving comment text like this: http://www.w3.org/TR/REC-html40/loose.dtd";> comment text instead of like this: comment text this is because a call to loadHTML() adds the extra tags unless passed in flags tell it not to. As well as fixing this problem, we need to check that other places in the code that use loadHTML() are not also adding extra tags. Steps to reproduce: 1. Add a comment 2. Check the database and check what is stored in the artefact table for the text of that comment What you should see: The text of the comment you added inside tags What you currently see: The text of the comment you added inside the doctype and body tags as well. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1826948/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826948] A change has been merged
Reviewed: https://reviews.mahara.org/9927 Committed: https://git.mahara.org/mahara/mahara/commit/3d5e8862ba30f066e689ba40820b169b43af6a3c Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:19.04_STABLE commit 3d5e8862ba30f066e689ba40820b169b43af6a3c Author: Cecilia Vela Gurovic Date: Tue Apr 30 12:32:20 2019 +1200 Bug 1826948: update existing comments behatnotneeded Change-Id: I71bcdb6c98aa1382692a93db2399547e71838f19 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1826948 Title: Comment text being saved with extra HTML tags Status in Mahara: Fix Committed Bug description: In 18.04 we made a change which meant we inadvertently started saving comment text like this: http://www.w3.org/TR/REC-html40/loose.dtd";> comment text instead of like this: comment text this is because a call to loadHTML() adds the extra tags unless passed in flags tell it not to. As well as fixing this problem, we need to check that other places in the code that use loadHTML() are not also adding extra tags. Steps to reproduce: 1. Add a comment 2. Check the database and check what is stored in the artefact table for the text of that comment What you should see: The text of the comment you added inside tags What you currently see: The text of the comment you added inside the doctype and body tags as well. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1826948/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1817326] Re: Goals and skills - add file - after preview focus lost on the pop-up with my files
Modal in a Modal popup: This issue does not affect 19.04. In 18.10 the modal of the image preview is appearing inside another Modal. Clicking "Close" on the popup closes all Modals. The second Modal inherits the size of the first modal box (rather than sitting on the viewport) creating incorrect heights on the image that appears - meaning that scrolling needs to occur to view the image if scrolled down the page. The fix would be to add the modal template call to the bottom of the modal page for viewing files. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1817326 Title: Goals and skills - add file - after preview focus lost on the pop-up with my files Status in Mahara: New Bug description: I'am in Goals and skills. I add file, a new window open with my files, if i click of one of them a preview pop-up open. If a click on the side, this pop close, but the focus was lost on the windows who display my files. The scrolling it's on the main page not on the first open pop-up (list of my files). If you want to reproduice the bug, you should have many files (+ 10) in your bank. I hope to be clear to explain the bug. Thank you - Mahara 18.10 - Windows 10 (web server on linux) - Mysql Database - Google Chrome To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1817326/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826956] Re: Reading unread emails not marking them as read
** Changed in: mahara Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1826956 Title: Reading unread emails not marking them as read Status in Mahara: Fix Committed Bug description: This is caused by changes with bootstrap going from panels to cards To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1826956/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826956] A change has been merged
Reviewed: https://reviews.mahara.org/9928 Committed: https://git.mahara.org/mahara/mahara/commit/61c4d4090dd63902926135f8ab56486f3761ddf4 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:19.04_STABLE commit 61c4d4090dd63902926135f8ab56486f3761ddf4 Author: Robert Lyon Date: Tue Apr 30 12:41:24 2019 +1200 Bug 1826956: Problem with unread mails This patch fixes the js problem: - Marking read emails in inbox was not updating the status - Marking read emails in inbox block was not updating the status Also fixes php problem: - Marking read user messages in the inbox block behatnotneeded Change-Id: Icba09033812a6dbdaf017561a11cb40cad5dc782 Signed-off-by: Robert Lyon (cherry picked from commit d6ffd9b19c199f250768c6e2058c987ed5b300cd) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1826956 Title: Reading unread emails not marking them as read Status in Mahara: Fix Committed Bug description: This is caused by changes with bootstrap going from panels to cards To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1826956/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826956] A change has been merged
Reviewed: https://reviews.mahara.org/9915 Committed: https://git.mahara.org/mahara/mahara/commit/d6ffd9b19c199f250768c6e2058c987ed5b300cd Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:master commit d6ffd9b19c199f250768c6e2058c987ed5b300cd Author: Robert Lyon Date: Tue Apr 30 12:41:24 2019 +1200 Bug 1826956: Problem with unread mails This patch fixes the js problem: - Marking read emails in inbox was not updating the status - Marking read emails in inbox block was not updating the status Also fixes php problem: - Marking read user messages in the inbox block behatnotneeded Change-Id: Icba09033812a6dbdaf017561a11cb40cad5dc782 Signed-off-by: Robert Lyon -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1826956 Title: Reading unread emails not marking them as read Status in Mahara: Fix Committed Bug description: This is caused by changes with bootstrap going from panels to cards To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1826956/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826956] A patch has been submitted for review
Patch for "19.04_STABLE" branch: https://reviews.mahara.org/9928 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1826956 Title: Reading unread emails not marking them as read Status in Mahara: Fix Committed Bug description: This is caused by changes with bootstrap going from panels to cards To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1826956/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1820912] Re: HTML export dos not display retracted block content
** Changed in: mahara/18.10 Importance: Undecided => Medium ** Changed in: mahara/18.04 Importance: Undecided => Medium ** Changed in: mahara/17.10 Importance: Undecided => Medium -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1820912 Title: HTML export dos not display retracted block content Status in Mahara: Fix Committed Status in Mahara 17.10 series: Fix Committed Status in Mahara 18.04 series: Fix Committed Status in Mahara 18.10 series: Fix Committed Status in Mahara 19.04 series: Fix Committed Bug description: This is most likely due to the javascript needed being not available But when it comes to HTML export it would make better sense to not allow retractable-ness and just display the block as a non-retractable block To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1820912/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
