[Mahara-contributors] [Bug 1767933] A patch has been submitted for review

2020-01-14 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/10718

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1767933

Title:
  Behat copies html styling regardless of whether the option for an html
  report is passed in

Status in Mahara:
  In Progress

Bug description:
  When running behat tests with the html flag as in:
  ./test/behat/mahara_behat.sh run test.feature html
  the styling needs to be copied over to the plugin folder to make the report 
display correctly.

  If the test is being run without 'html', there is no need for the
  styling to be copied over. Currently this happens regardless.

  Currently the function set_report_styling is called during behat setup
  from /htdocs/testing/frameworks/behat/cli/util.php. In order to fix
  this there should be an if statement around that call.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1767933/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1767933] Re: Behat copies html styling regardless of whether the option for an html report is passed in

2020-01-14 Thread Rebecca Blundell
** Changed in: mahara
 Assignee: (unassigned) => Rebecca Blundell (rjb-dev)

** Changed in: mahara
   Status: Confirmed => In Progress

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1767933

Title:
  Behat copies html styling regardless of whether the option for an html
  report is passed in

Status in Mahara:
  In Progress

Bug description:
  When running behat tests with the html flag as in:
  ./test/behat/mahara_behat.sh run test.feature html
  the styling needs to be copied over to the plugin folder to make the report 
display correctly.

  If the test is being run without 'html', there is no need for the
  styling to be copied over. Currently this happens regardless.

  Currently the function set_report_styling is called during behat setup
  from /htdocs/testing/frameworks/behat/cli/util.php. In order to fix
  this there should be an if statement around that call.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1767933/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1859605] Re: Mahara portfolio as Moodle assignment cannot be previewed

2020-01-14 Thread Kristina Hoeppner
** Changed in: mahara
   Status: New => In Progress

** Also affects: mahara/20.04
   Importance: Undecided
   Status: In Progress

** Also affects: mahara/19.04
   Importance: Undecided
   Status: New

** Also affects: mahara/18.10
   Importance: Undecided
   Status: New

** Also affects: mahara/19.10
   Importance: Undecided
   Status: New

** Changed in: mahara/19.10
   Status: New => In Progress

** Changed in: mahara/19.04
   Status: New => In Progress

** Changed in: mahara/18.10
   Status: New => In Progress

** Changed in: mahara/20.04
   Importance: Undecided => Medium

** Changed in: mahara/19.04
   Importance: Undecided => Medium

** Changed in: mahara/18.10
   Importance: Undecided => Medium

** Changed in: mahara/20.04
Milestone: None => 20.04.0

** Changed in: mahara/19.10
   Importance: Undecided => Medium

** Changed in: mahara/19.10
Milestone: None => 19.10.2

** Changed in: mahara/19.04
Milestone: None => 19.04.4

** Changed in: mahara/18.10
Milestone: None => 18.10.5

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1859605

Title:
  Mahara portfolio as Moodle assignment cannot be previewed

Status in Mahara:
  In Progress
Status in Mahara 18.10 series:
  In Progress
Status in Mahara 19.04 series:
  In Progress
Status in Mahara 19.10 series:
  In Progress
Status in Mahara 20.04 series:
  In Progress

Bug description:
  When using the assignsubmission_mahara plugin to connect Moodle
  assignments to Mahara, the link to view the portfolio works fine to
  open Mahara, but the preview iframe in Moodle doesn't.

  This is because MNET auth doesn't set up the session in the same way
  as LTI does with the CSP being set to allow such things. Fixing this
  is mostly a matter of copying the setup code into the MNET landing
  page:

  $parts = parse_url($remotewwwroot);
  $cspurl = $parts['scheme'] . '://' . $parts['host'];
  $SESSION->set('csp-ancestor-exemption', $cspurl);

  I am mindful that LTI is considered the future direction of Mahara,
  but we have customers who use MNET and can't move to LTI because it
  does not meet their needs at this time, and this improves the workflow
  a tiny bit for them without a significant overhaul of anything.

  Happy to submit as a formal patch for all currently supported versions
  of Mahara if that would help.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1859605/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1859118] Re: Gridstack layout conversion error during new user creation

2020-01-14 Thread Kristina Hoeppner
** Summary changed:

- Gridstack Layout Converstion Error During New User Creation
+ Gridstack layout conversion error during new user creation

** Also affects: mahara/19.10
   Importance: Undecided
   Status: New

** Also affects: mahara/20.04
   Importance: Undecided
   Status: New

** Changed in: mahara/20.04
   Status: New => In Progress

** Changed in: mahara/19.10
   Status: New => Confirmed

** Changed in: mahara/20.04
   Importance: Undecided => High

** Changed in: mahara/19.10
   Importance: Undecided => High

** Changed in: mahara/20.04
Milestone: None => 20.04.0

** Changed in: mahara/19.10
Milestone: None => 19.10.2

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1859118

Title:
  Gridstack layout conversion error during new user creation

Status in Mahara:
  In Progress
Status in Mahara 19.10 series:
  Confirmed
Status in Mahara 20.04 series:
  In Progress

Bug description:
  Mahara: 19.10.1 (2019093009)
  OS: Linux 18.04
  DB: Postgres
  Browser: FF

  If an institution has pages to be copied to users upon creation and
  those pages are of the old format, an error is generated when trying
  to copy the page to the new user:

  Jan 10 14:12:34 prod: 2020/01/10 14:12:34 [error] 227
  #227: *389810 FastCGI sent in stderr: "PHP message: [WAR] 3e 
(lib/gridstacklayout.php:60) Undefined index: width
  #012PHP message: Call stack (most recent first):
  #012PHP message: * log_message(string(size 22), integer, true, true, 
string(size 37), integer) at /var/www/site/lib/errors.php:521
  #012PHP message: * error(integer, string(size 22), string(size 37), integer, 
array(size 9)) at /var/www/site/lib/gridstacklayout.php:60
  #012PHP message: * translate_to_new_layout(array(size 4)) at 
/var/www/site/lib/view.php:5929
  #012PHP message: * View->copy_contents(object(View), array(size 0)) at 
/var/www/site/lib/view.php:458
  #012PHP message: * View::create_from_template(array(size 5), string(size 5), 
string(size 5), false, false, array(size 0)) at 
/var/www/site/lib/collection.php:349
  #012PHP message: * Collection::create_from_template(array(size 2), 
string(size 5), string(size 5), false) at /var/www/site/auth/user.php:1540
  #012PHP message: * User->copy_collections(array(size 8), false) at 
/var/www/site/auth/user.php:1602
  #012PHP message: * 
User->copy_institution_views_collections_to_new_member(string(size 16)) at 
/var/www/site/lib/institution.php:360
  #012PHP message: * Institution->addUserAsMember(object(stdClass), null, null) 
at /var/www/site/lib/user.php:2622
  #012PHP message: * create_user(object(stdClass), array(size 0), 
object(Institution), false, null, array(size 27)) at 
/var/www/site/admin/users/add.php:320
  #012PHP message: * adduser_submit(object(Pieform), array(size 27)) at 
/var/www/site/lib/pieforms/pieform.php:546
  #012PHP message: * Pieform->__construct(array(size 8)) at 
/var/www/site/lib/pieforms/pieform.php:168
  #012PHP message: * Pieform::process(array(size 8)) at 
/var/www/site/lib/mahara.php:5432
  #012PHP message: * pieform(array(size 8)) at 
/var/www/site/admin/users/add.php:156
  #012PHP message:
  #012PHP message: [WAR] 3e (lib/gridstacklayout.php:73) Undefined index: width
  #012PHP message: Call stack (most recent first):
  #012PHP message: * log_message(string(size 22), integer, true, true, 
string(size 37), integer) at /var/w


  The issue is:

  (lib/gridstacklayout.php:60) Undefined index: width  <-
  translate_to_new_layout() doesn't find a relevant column in the row
  (i.e. that column is empty) and is trying to add the width of that
  column.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1859118/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1859364] Re: The gridstack drag icon is showing on the display page as well as edit page

2020-01-14 Thread Kristina Hoeppner
** Changed in: mahara
 Assignee: (unassigned) => Evonne Cheung (evonne)

** Tags added: front-end

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1859364

Title:
  The gridstack drag icon is showing on the display page as well as edit
  page

Status in Mahara:
  Confirmed

Bug description:
  It makes sense on the edit page but not on the display page

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1859364/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1859127] Re: When having restricted file uploading it fails to restrict list on subsequent upload

2020-01-14 Thread Kristina Hoeppner
** Also affects: mahara/19.10
   Importance: Undecided
   Status: New

** Also affects: mahara/20.04
   Importance: High
 Assignee: Robert Lyon (robertl-9)
   Status: Fix Committed

** Changed in: mahara/19.10
   Status: New => Confirmed

** Changed in: mahara/19.10
   Importance: Undecided => High

** Changed in: mahara/19.10
Milestone: None => 19.10.2

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1859127

Title:
  When having restricted file uploading it fails to restrict list on
  subsequent  upload

Status in Mahara:
  Fix Committed
Status in Mahara 19.10 series:
  Confirmed
Status in Mahara 20.04 series:
  Fix Committed

Bug description:
  To Test:

  Set in your config.php:

   $cfg->validfiletypes = 'jpeg,jpg';

  Then upload a file from a directory on your system contaning many
  types of files (inc jpg files)

  On first upload you can only see a list of .jpg files
  But on second upload you see all files

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1859127/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1859528] Re: Update adodb to version 5.21.0 (due 31/1/2020)

2020-01-14 Thread Kristina Hoeppner
** Changed in: mahara
   Status: New => Confirmed

** Changed in: mahara
   Importance: Undecided => Medium

** Changed in: mahara
Milestone: None => 20.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1859528

Title:
  Update adodb to version 5.21.0 (due 31/1/2020)

Status in Mahara:
  Confirmed

Bug description:
  Adodb requires some changes to work with PHP 7.4. The January 31 2020
  release includes fixes for all of the current issues:
  https://github.com/ADOdb/ADOdb/milestone/2

  We should update our version when it is released.
  We are currently on 5.20.14.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1859528/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1856506] Re: gridstack - too much recursion error when translating from old layout

2020-01-14 Thread Cecilia Vela Gurovic
** Changed in: mahara/20.04
   Status: Fix Committed => In Progress

** Changed in: mahara/19.10
   Status: Fix Committed => In Progress

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1856506

Title:
  gridstack - too much recursion error when translating from old layout

Status in Mahara:
  In Progress
Status in Mahara 19.10 series:
  In Progress
Status in Mahara 20.04 series:
  In Progress

Bug description:
  If there is an old layout page with empty rows (no blocks in that
  row), when translating to new gridstack layout there will be a
  javascript error "too much recursion". This error will make the script
  fail and the process of translating will never be completed.

  
  To test:

  - have a Mahara site version 19.04 or older
  - make a page and set the layout to one that has more than 3 rows. It should 
have at least one block in row 1 and row 3. No blocks in row 2
  - upgrade the site to 19.10 or newer
  - go to the page and edit it

  expected result: the page is translated and there a message to show the 
process was successful
  actual result: there is a "too much recursion" error in the browsers console 
and the translation process is interrupted

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1856506/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1856506] A patch has been submitted for review

2020-01-14 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/10717

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1856506

Title:
  gridstack - too much recursion error when translating from old layout

Status in Mahara:
  In Progress
Status in Mahara 19.10 series:
  In Progress
Status in Mahara 20.04 series:
  In Progress

Bug description:
  If there is an old layout page with empty rows (no blocks in that
  row), when translating to new gridstack layout there will be a
  javascript error "too much recursion". This error will make the script
  fail and the process of translating will never be completed.

  
  To test:

  - have a Mahara site version 19.04 or older
  - make a page and set the layout to one that has more than 3 rows. It should 
have at least one block in row 1 and row 3. No blocks in row 2
  - upgrade the site to 19.10 or newer
  - go to the page and edit it

  expected result: the page is translated and there a message to show the 
process was successful
  actual result: there is a "too much recursion" error in the browsers console 
and the translation process is interrupted

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1856506/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1857929] Re: Add sign-off and verification details

2020-01-14 Thread Lisa Seeto
** Changed in: mahara
   Status: Confirmed => In Progress

** Changed in: mahara
 Assignee: (unassigned) => Lisa Seeto (lisaseeto)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1857929

Title:
  Add sign-off and verification details

Status in Mahara:
  In Progress

Bug description:
  At the moment, there is no trace of who verified the page when, which
  is not good, esp. if a third-party needs to assess the portfolio as
  they may not necessarily know who the manager was.

  Proposal:

  When a learner signs off her page, the information is stored in the
  database. When a manager verifies the page, the information (name of
  verifier and date) is also stored in the database, and both are
  displayed in a modal coming from the top of the page when clicking the
  “i” icon in the “Sign off and Verify” block.

  The "i" icon only shows up when the page author signed off the page as
  it is not needed before then. When a page is not yet verified, the
  text reads "This page is ready for verification." in the modal that
  comes up when the “i” is clicked.

  When a page gets the verification revoked (page author removes sign-
  off), then that information is reset. When it is verified next, it
  contains the name and date of the current verifier. Only the most
  recent sign-off and verifications are displayed. A history of them
  does not need to be shown.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1857929/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1857929] Re: Add sign-off and verification details

2020-01-14 Thread Lisa Seeto
** Changed in: mahara
Milestone: None => 20.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1857929

Title:
  Add sign-off and verification details

Status in Mahara:
  Confirmed

Bug description:
  At the moment, there is no trace of who verified the page when, which
  is not good, esp. if a third-party needs to assess the portfolio as
  they may not necessarily know who the manager was.

  Proposal:

  When a learner signs off her page, the information is stored in the
  database. When a manager verifies the page, the information (name of
  verifier and date) is also stored in the database, and both are
  displayed in a modal coming from the top of the page when clicking the
  “i” icon in the “Sign off and Verify” block.

  The "i" icon only shows up when the page author signed off the page as
  it is not needed before then. When a page is not yet verified, the
  text reads "This page is ready for verification." in the modal that
  comes up when the “i” is clicked.

  When a page gets the verification revoked (page author removes sign-
  off), then that information is reset. When it is verified next, it
  contains the name and date of the current verifier. Only the most
  recent sign-off and verifications are displayed. A history of them
  does not need to be shown.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1857929/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1859605] A patch has been submitted for review

2020-01-14 Thread Mahara Bot
Patch for "19.10_STABLE" branch: https://reviews.mahara.org/10714

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1859605

Title:
  Mahara portfolio as Moodle assignment cannot be previewed

Status in Mahara:
  New

Bug description:
  When using the assignsubmission_mahara plugin to connect Moodle
  assignments to Mahara, the link to view the portfolio works fine to
  open Mahara, but the preview iframe in Moodle doesn't.

  This is because MNET auth doesn't set up the session in the same way
  as LTI does with the CSP being set to allow such things. Fixing this
  is mostly a matter of copying the setup code into the MNET landing
  page:

  $parts = parse_url($remotewwwroot);
  $cspurl = $parts['scheme'] . '://' . $parts['host'];
  $SESSION->set('csp-ancestor-exemption', $cspurl);

  I am mindful that LTI is considered the future direction of Mahara,
  but we have customers who use MNET and can't move to LTI because it
  does not meet their needs at this time, and this improves the workflow
  a tiny bit for them without a significant overhaul of anything.

  Happy to submit as a formal patch for all currently supported versions
  of Mahara if that would help.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1859605/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1859605] Re: Mahara portfolio as Moodle assignment cannot be previewed

2020-01-14 Thread Peter Spicer
On reflection, I've just pushed the changes for review as-is for 18.10,
19.04, 19.10 and master.

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1859605

Title:
  Mahara portfolio as Moodle assignment cannot be previewed

Status in Mahara:
  New

Bug description:
  When using the assignsubmission_mahara plugin to connect Moodle
  assignments to Mahara, the link to view the portfolio works fine to
  open Mahara, but the preview iframe in Moodle doesn't.

  This is because MNET auth doesn't set up the session in the same way
  as LTI does with the CSP being set to allow such things. Fixing this
  is mostly a matter of copying the setup code into the MNET landing
  page:

  $parts = parse_url($remotewwwroot);
  $cspurl = $parts['scheme'] . '://' . $parts['host'];
  $SESSION->set('csp-ancestor-exemption', $cspurl);

  I am mindful that LTI is considered the future direction of Mahara,
  but we have customers who use MNET and can't move to LTI because it
  does not meet their needs at this time, and this improves the workflow
  a tiny bit for them without a significant overhaul of anything.

  Happy to submit as a formal patch for all currently supported versions
  of Mahara if that would help.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1859605/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1859605] A patch has been submitted for review

2020-01-14 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/10713

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1859605

Title:
  Mahara portfolio as Moodle assignment cannot be previewed

Status in Mahara:
  New

Bug description:
  When using the assignsubmission_mahara plugin to connect Moodle
  assignments to Mahara, the link to view the portfolio works fine to
  open Mahara, but the preview iframe in Moodle doesn't.

  This is because MNET auth doesn't set up the session in the same way
  as LTI does with the CSP being set to allow such things. Fixing this
  is mostly a matter of copying the setup code into the MNET landing
  page:

  $parts = parse_url($remotewwwroot);
  $cspurl = $parts['scheme'] . '://' . $parts['host'];
  $SESSION->set('csp-ancestor-exemption', $cspurl);

  I am mindful that LTI is considered the future direction of Mahara,
  but we have customers who use MNET and can't move to LTI because it
  does not meet their needs at this time, and this improves the workflow
  a tiny bit for them without a significant overhaul of anything.

  Happy to submit as a formal patch for all currently supported versions
  of Mahara if that would help.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1859605/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1859605] A patch has been submitted for review

2020-01-14 Thread Mahara Bot
Patch for "18.10_STABLE" branch: https://reviews.mahara.org/10716

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1859605

Title:
  Mahara portfolio as Moodle assignment cannot be previewed

Status in Mahara:
  New

Bug description:
  When using the assignsubmission_mahara plugin to connect Moodle
  assignments to Mahara, the link to view the portfolio works fine to
  open Mahara, but the preview iframe in Moodle doesn't.

  This is because MNET auth doesn't set up the session in the same way
  as LTI does with the CSP being set to allow such things. Fixing this
  is mostly a matter of copying the setup code into the MNET landing
  page:

  $parts = parse_url($remotewwwroot);
  $cspurl = $parts['scheme'] . '://' . $parts['host'];
  $SESSION->set('csp-ancestor-exemption', $cspurl);

  I am mindful that LTI is considered the future direction of Mahara,
  but we have customers who use MNET and can't move to LTI because it
  does not meet their needs at this time, and this improves the workflow
  a tiny bit for them without a significant overhaul of anything.

  Happy to submit as a formal patch for all currently supported versions
  of Mahara if that would help.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1859605/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1859605] A patch has been submitted for review

2020-01-14 Thread Mahara Bot
Patch for "19.04_STABLE" branch: https://reviews.mahara.org/10715

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1859605

Title:
  Mahara portfolio as Moodle assignment cannot be previewed

Status in Mahara:
  New

Bug description:
  When using the assignsubmission_mahara plugin to connect Moodle
  assignments to Mahara, the link to view the portfolio works fine to
  open Mahara, but the preview iframe in Moodle doesn't.

  This is because MNET auth doesn't set up the session in the same way
  as LTI does with the CSP being set to allow such things. Fixing this
  is mostly a matter of copying the setup code into the MNET landing
  page:

  $parts = parse_url($remotewwwroot);
  $cspurl = $parts['scheme'] . '://' . $parts['host'];
  $SESSION->set('csp-ancestor-exemption', $cspurl);

  I am mindful that LTI is considered the future direction of Mahara,
  but we have customers who use MNET and can't move to LTI because it
  does not meet their needs at this time, and this improves the workflow
  a tiny bit for them without a significant overhaul of anything.

  Happy to submit as a formal patch for all currently supported versions
  of Mahara if that would help.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1859605/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1859605] [NEW] Mahara portfolio as Moodle assignment cannot be previewed

2020-01-14 Thread Peter Spicer
Public bug reported:

When using the assignsubmission_mahara plugin to connect Moodle
assignments to Mahara, the link to view the portfolio works fine to open
Mahara, but the preview iframe in Moodle doesn't.

This is because MNET auth doesn't set up the session in the same way as
LTI does with the CSP being set to allow such things. Fixing this is
mostly a matter of copying the setup code into the MNET landing page:

$parts = parse_url($remotewwwroot);
$cspurl = $parts['scheme'] . '://' . $parts['host'];
$SESSION->set('csp-ancestor-exemption', $cspurl);

I am mindful that LTI is considered the future direction of Mahara, but
we have customers who use MNET and can't move to LTI because it does not
meet their needs at this time, and this improves the workflow a tiny bit
for them without a significant overhaul of anything.

Happy to submit as a formal patch for all currently supported versions
of Mahara if that would help.

** Affects: mahara
 Importance: Undecided
 Status: New


** Tags: mnet

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1859605

Title:
  Mahara portfolio as Moodle assignment cannot be previewed

Status in Mahara:
  New

Bug description:
  When using the assignsubmission_mahara plugin to connect Moodle
  assignments to Mahara, the link to view the portfolio works fine to
  open Mahara, but the preview iframe in Moodle doesn't.

  This is because MNET auth doesn't set up the session in the same way
  as LTI does with the CSP being set to allow such things. Fixing this
  is mostly a matter of copying the setup code into the MNET landing
  page:

  $parts = parse_url($remotewwwroot);
  $cspurl = $parts['scheme'] . '://' . $parts['host'];
  $SESSION->set('csp-ancestor-exemption', $cspurl);

  I am mindful that LTI is considered the future direction of Mahara,
  but we have customers who use MNET and can't move to LTI because it
  does not meet their needs at this time, and this improves the workflow
  a tiny bit for them without a significant overhaul of anything.

  Happy to submit as a formal patch for all currently supported versions
  of Mahara if that would help.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1859605/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp