[Mahara-contributors] [Bug 1889507] [NEW] Library Upgrade: Gridstack.js 0.4.0 to 1.1.2

2020-07-29 Thread Lisa Seeto
Public bug reported:

 gridstack.js is a JS/Typescript library designed to help developers
create beautiful draggable, resizable, responsive bootstrap-friendly
layouts with just a few lines of code.

We are currently on version 0.4.0 for gridstack and there has seen been
many changes including no longer needing lodash as a requirement (0.5+)
and jquery (1.0.0+).

https://github.com/gridstack/gridstack.js

We will endeavour to upgrade to version 1.1.2

** Affects: mahara
 Importance: Undecided
 Status: New

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1889507

Title:
  Library Upgrade: Gridstack.js 0.4.0 to 1.1.2

Status in Mahara:
  New

Bug description:
   gridstack.js is a JS/Typescript library designed to help developers
  create beautiful draggable, resizable, responsive bootstrap-friendly
  layouts with just a few lines of code.

  We are currently on version 0.4.0 for gridstack and there has seen
  been many changes including no longer needing lodash as a requirement
  (0.5+) and jquery (1.0.0+).

  https://github.com/gridstack/gridstack.js

  We will endeavour to upgrade to version 1.1.2

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1889507/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1886614] A patch has been submitted for review

2020-07-29 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/11097

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1886614

Title:
  SmartEvidence framework editor improvements

Status in Mahara:
  In Progress

Bug description:
  There are still some improvements to do on the SmartEvidence framework
  editor

  So far we could be fixing the layout so we don't have a huge form to
  edit the framework, that makes it confusing and too hard to handle

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1886614/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1889340] Re: Adding indexes to tag table to speed things up

2020-07-29 Thread Robert Lyon
To test:

Go to a big site and find a view with some tags on it - make a note of
the view id and plug that into the SQL above in place of the '123'

Run that 'explain  ...' sql and make a note of the "Planning time" and
"Execution time" - run it a few time to get an average

Then add the unique index
ALTER TABLE tag ADD CONSTRAINT tag_unique UNIQUE (tag, resourcetype, 
resourceid, ownertype, ownerid);

Run that 'explain  ...' sql and make a note of the "Planning time" and
"Execution time" - run it a few time to get an average

It should be way faster

Then drop the index so you can add it back with upgrade of the site

ALTER TABLE tag
DROP CONSTRAINT tag_unique;

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1889340

Title:
  Adding indexes to tag table to speed things up

Status in Mahara:
  Confirmed
Status in Mahara 19.04 series:
  Confirmed
Status in Mahara 19.10 series:
  Confirmed
Status in Mahara 20.04 series:
  Confirmed
Status in Mahara 20.10 series:
  Confirmed

Bug description:
  To make requests to tags table faster

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1889340/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1889340] A patch has been submitted for review

2020-07-29 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/11096

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1889340

Title:
  Adding indexes to tag table to speed things up

Status in Mahara:
  Confirmed
Status in Mahara 19.04 series:
  Confirmed
Status in Mahara 19.10 series:
  Confirmed
Status in Mahara 20.04 series:
  Confirmed
Status in Mahara 20.10 series:
  Confirmed

Bug description:
  To make requests to tags table faster

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1889340/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1889505] [NEW] Behat: create import_export_skins feature

2020-07-29 Thread Rangi Daymond
Public bug reported:

Create a new behat feature file to provide some automated test coverage
for Bug 1877497 Sorting out problems with skin export/import

** Affects: mahara
 Importance: Undecided
 Status: New

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1889505

Title:
  Behat: create import_export_skins feature

Status in Mahara:
  New

Bug description:
  Create a new behat feature file to provide some automated test
  coverage for Bug 1877497 Sorting out problems with skin export/import

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1889505/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1886614] A patch has been submitted for review

2020-07-29 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/11095

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1886614

Title:
  SmartEvidence framework editor improvements

Status in Mahara:
  In Progress

Bug description:
  There are still some improvements to do on the SmartEvidence framework
  editor

  So far we could be fixing the layout so we don't have a huge form to
  edit the framework, that makes it confusing and too hard to handle

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1886614/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1886614] Re: SmartEvidence framework editor improvements

2020-07-29 Thread Cecilia Vela Gurovic
The code of the following files will need to be tidy up:

framework.json.php:
 this file saves a framework to the DB
frameworks.php:
 This file contains the forms that are displayed when we go to Admin
menu-> Extensions-> SmartEvidence
getframework.json.php:
 This file gets a framework from the DB

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1886614

Title:
  SmartEvidence framework editor improvements

Status in Mahara:
  In Progress

Bug description:
  There are still some improvements to do on the SmartEvidence framework
  editor

  So far we could be fixing the layout so we don't have a huge form to
  edit the framework, that makes it confusing and too hard to handle

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1886614/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1877001] A change has been merged

2020-07-29 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/10964
Committed: 
https://git.mahara.org/mahara/mahara/commit/04382251a5e08325835be3b747dfa35b2f9ba5cc
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master

commit 04382251a5e08325835be3b747dfa35b2f9ba5cc
Author: Robert Lyon 
Date:   Fri May 8 14:00:09 2020 +1200

Bug 1877497: Sorting out problems with skin export / import

This is a follow on for Bug 1877001

Fixed:
- using a defaultviewskin array so tha
1) all options are in one place
2) when importing older skins it sets missing values
3) when editing an older skin it only saves keys for what we have
defined in default options

- adding header_background_image to the export

Change-Id: I5a3d82f656f465e74551349fcbf9d76f22ba59bf
Signed-off-by: Robert Lyon 

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1877001

Title:
  Skins not showing after upgrade

Status in Mahara:
  Fix Committed
Status in Mahara 19.10 series:
  Fix Committed
Status in Mahara 20.04 series:
  Fix Committed
Status in Mahara 20.10 series:
  Fix Committed

Bug description:
  When upgrading from an older site to 19.10+ site the skins stop
  showing on pages

  and there are error messages in the logs regarding this

  * error(8, "Undefined index: view_block_header_font",
  "/var/www/skin/style.php", 82, array(size 68)) at
  /var/www/skin/style.php:82

  We need an upgrade step to add in blank values for the 2 new fields

  view_block_header_font
  view_block_header_font_color

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1877001/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1877497] A change has been merged

2020-07-29 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/10964
Committed: 
https://git.mahara.org/mahara/mahara/commit/04382251a5e08325835be3b747dfa35b2f9ba5cc
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master

commit 04382251a5e08325835be3b747dfa35b2f9ba5cc
Author: Robert Lyon 
Date:   Fri May 8 14:00:09 2020 +1200

Bug 1877497: Sorting out problems with skin export / import

This is a follow on for Bug 1877001

Fixed:
- using a defaultviewskin array so tha
1) all options are in one place
2) when importing older skins it sets missing values
3) when editing an older skin it only saves keys for what we have
defined in default options

- adding header_background_image to the export

Change-Id: I5a3d82f656f465e74551349fcbf9d76f22ba59bf
Signed-off-by: Robert Lyon 

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1877497

Title:
  Skins not exporting / importing header image

Status in Mahara:
  Fix Committed

Bug description:
  Problems being fixed under this bug report are

  Use the central default viewskin array from lib/skin.php when creating
  / updating / importing a skin so that any missing info can be supplied
  by default array

  Exporting a skin with a header_background_image doesn't get added to
  the export and therefore not imported either

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1877497/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1877497] Re: Skins not exporting / importing header image

2020-07-29 Thread Robert Lyon
** Changed in: mahara
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1877497

Title:
  Skins not exporting / importing header image

Status in Mahara:
  Fix Committed

Bug description:
  Problems being fixed under this bug report are

  Use the central default viewskin array from lib/skin.php when creating
  / updating / importing a skin so that any missing info can be supplied
  by default array

  Exporting a skin with a header_background_image doesn't get added to
  the export and therefore not imported either

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1877497/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1889369] Re: Language menu shows when there's only one language

2020-07-29 Thread Cecilia Vela Gurovic
** Changed in: mahara
   Status: New => Confirmed

** Changed in: mahara
   Importance: Undecided => Low

** Changed in: mahara
Milestone: None => 20.10.0

** Also affects: mahara/19.10
   Importance: Undecided
   Status: New

** Also affects: mahara/20.04
   Importance: Undecided
   Status: New

** Also affects: mahara/20.10
   Importance: Low
   Status: Confirmed

** Changed in: mahara/20.04
   Status: New => Confirmed

** Changed in: mahara/19.10
   Status: New => Confirmed

** Changed in: mahara/20.04
   Importance: Undecided => High

** Changed in: mahara/20.04
   Importance: High => Low

** Changed in: mahara/19.10
   Importance: Undecided => Low

** Tags added: bite

** Tags removed: bite
** Tags added: bite-sized

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1889369

Title:
  Language menu shows when there's only one language

Status in Mahara:
  Confirmed
Status in Mahara 19.10 series:
  Confirmed
Status in Mahara 20.04 series:
  Confirmed
Status in Mahara 20.10 series:
  Confirmed

Bug description:
  On a fresh 20.04, we've seen cases of the language menu showing up
  even when only one language is actually present.

  The reason is that LANGCHOICES is an array of all possible languages
  that can be selected, and the test in the template to show/hide the
  language selector is whether LANGCHOICES is empty or not.

  There should be an additional flag for 'show language selector' which
  is true/false based on whether LANGCHOICES has > 1 entry or not in it.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1889369/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1889492] [NEW] remove Mahara keyboard short keys

2020-07-29 Thread Lisa Seeto
Public bug reported:

It has been decided that the Mahara character short keys will be removed
from the code.  Often, the key mapping short cuts may interfere with
assistive technologies rather than offer more convenience especially if
a person cannot re-map the keys to those of their own choosing.

The requirement for WCAG2.1 A 2.1.4 Character Shortcuts (if present) is
a new addition but we will not be implementing the support needed to
keep compliance for this feature and will thus remove it.

The key mappings can be found here:
/js/keyboardNavigation.js with reference to the file in /lib/web.php.  Please 
remove this feature and clean up any references to it.

https://www.w3.org/WAI/WCAG21/quickref/?showtechniques=144#character-
key-shortcuts

** Affects: mahara
 Importance: Undecided
 Status: Triaged


** Tags: accessibility

** Description changed:

  It has been decided that the Mahara character short keys will be removed
- from the code  Often, the key mapping short cuts may interfere with
+ from the code.  Often, the key mapping short cuts may interfere with
  assistive technologies rather than offer more convenience especially if
  a person cannot re-map the keys to those of their own choosing.
  
  The requirement for WCAG2.1 A 2.1.4 Character Shortcuts (if present) is
  a new addition but we will not be implementing the support needed to
  keep compliance for this feature and will thus remove it.
  
  The key mappings can be found here:
- /js/keyboardNavigation.js with reference to the file in /lib/web.php.  Please 
remove this feature and clean up any references to it.  
+ /js/keyboardNavigation.js with reference to the file in /lib/web.php.  Please 
remove this feature and clean up any references to it.
  
  https://www.w3.org/WAI/WCAG21/quickref/?showtechniques=144#character-
  key-shortcuts

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1889492

Title:
  remove Mahara keyboard short keys

Status in Mahara:
  Triaged

Bug description:
  It has been decided that the Mahara character short keys will be
  removed from the code.  Often, the key mapping short cuts may
  interfere with assistive technologies rather than offer more
  convenience especially if a person cannot re-map the keys to those of
  their own choosing.

  The requirement for WCAG2.1 A 2.1.4 Character Shortcuts (if present)
  is a new addition but we will not be implementing the support needed
  to keep compliance for this feature and will thus remove it.

  The key mappings can be found here:
  /js/keyboardNavigation.js with reference to the file in /lib/web.php.  Please 
remove this feature and clean up any references to it.

  https://www.w3.org/WAI/WCAG21/quickref/?showtechniques=144#character-
  key-shortcuts

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1889492/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1889490] [NEW] wcag2.1 compliance: text must be able to resize to 200%

2020-07-29 Thread Lisa Seeto
Public bug reported:

Success Criterion 1.4.4 Resize text (Level AA): Except for captions and
images of text, text can be resized without assistive technology up to
200 percent without loss of content or functionality.

https://www.w3.org/WAI/WCAG21/quickref/?showtechniques=144#resize-text
https://www.w3.org/WAI/WCAG21/Understanding/resize-text.html

A test was performed in FireFox:
>From the toolbars select view -> zoom -> zoom text only then increase the 
>percentage to 200%

Currently, many of the content is pushed out of alignment etc... site-wide.
Please see the attached screen shots as an example of the some of the results.

** Affects: mahara
 Importance: Undecided
 Status: Triaged


** Tags: accessibility

** Attachment added: "dashboard-at-200.png"
   
https://bugs.launchpad.net/bugs/1889490/+attachment/5397102/+files/dashboard-at-200.png

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1889490

Title:
  wcag2.1 compliance: text must be able to resize to 200%

Status in Mahara:
  Triaged

Bug description:
  Success Criterion 1.4.4 Resize text (Level AA): Except for captions
  and images of text, text can be resized without assistive technology
  up to 200 percent without loss of content or functionality.

  https://www.w3.org/WAI/WCAG21/quickref/?showtechniques=144#resize-text
  https://www.w3.org/WAI/WCAG21/Understanding/resize-text.html

  A test was performed in FireFox:
  From the toolbars select view -> zoom -> zoom text only then increase the 
percentage to 200%

  Currently, many of the content is pushed out of alignment etc... site-wide.
  Please see the attached screen shots as an example of the some of the results.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1889490/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1889490] Re: wcag2.1 compliance: text must be able to resize to 200%

2020-07-29 Thread Lisa Seeto
** Attachment added: "pages-and-collections-200.png"
   
https://bugs.launchpad.net/mahara/+bug/1889490/+attachment/5397103/+files/pages-and-collections-200.png

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1889490

Title:
  wcag2.1 compliance: text must be able to resize to 200%

Status in Mahara:
  Triaged

Bug description:
  Success Criterion 1.4.4 Resize text (Level AA): Except for captions
  and images of text, text can be resized without assistive technology
  up to 200 percent without loss of content or functionality.

  https://www.w3.org/WAI/WCAG21/quickref/?showtechniques=144#resize-text
  https://www.w3.org/WAI/WCAG21/Understanding/resize-text.html

  A test was performed in FireFox:
  From the toolbars select view -> zoom -> zoom text only then increase the 
percentage to 200%

  Currently, many of the content is pushed out of alignment etc... site-wide.
  Please see the attached screen shots as an example of the some of the results.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1889490/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1888743] A patch has been submitted for review

2020-07-29 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/11094

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1888743

Title:
  clean up references to old menu structure

Status in Mahara:
  In Progress

Bug description:
  Currently we still have some references to the old menu structure within 
Mahara.
  'myportfolio' and 'content' should both be updated to 'create'.

  Change: define(MENUITEM', 'myportfolio');
  To: define('MENUITEM', 'create');

  In the following files:
  relatedtags.php
  artefact/annotation/edit.php
  artefact/comment/edit.php
  artefact/peerassessment/edit.php

  In artefact/internal/socialprofile.php:
  Change: define('MENUITEM', 'content/profile');
  To: define('MENUITEM', 'create/files');

  In htdocs/lib/web.php:
  Change (ln 1476 in a comment): in_array(MENUITEM, array('myportfolio/view'))),
  To: in_array(MENUITEM, array('create/view'))),

  The old code was discovered when upgrading a site from 18.10 to 20.04.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1888743/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1889485] Re: Security Upgrade SimpleSAML 1.18.4 to 1.18.7

2020-07-29 Thread Lisa Seeto
This patch introduces an error, currently produces the following while
trying to log in via saml login:

[WAR] 84 
(auth/saml/extlib/simplesamlphp/vendor/robrichards/xmlseclibs/src/XMLSecurityKey.php:499)
 openssl_sign(): supplied key param cannot be coerced into a private key
Call stack (most recent first):

log_message("openssl_sign(): supplied key param cannot be coerc...", 8, 
true, true, "/home/lisaseeto/code/mahara/htdocs/auth/saml/extli...", 499) at 
/home/lisaseeto/code/mahara/htdocs/lib/errors.php:521
error(2, "openssl_sign(): supplied key param cannot be coerc...", 
"/home/lisaseeto/code/mahara/htdocs/auth/saml/extli...", 499, array(size 3)) at 
Unknown:0
openssl_sign("SAMLRequest=fVJdb8IgFP0rDe%2BVWr9aoiZOs8zETbO6Pexl...", null, 
false, "SHA256") at 
/home/lisaseeto/code/mahara/htdocs/auth/saml/extlib/simplesamlphp/vendor/robrichards/xmlseclibs/src/XMLSecurityKey.php:499

RobRichards\XMLSecLibs\XMLSecurityKey->signOpenSSL("SAMLRequest=fVJdb8IgFP0rDe%2BVWr9aoiZOs8zETbO6Pexl...")
 at 
/home/lisaseeto/code/mahara/htdocs/auth/saml/extlib/simplesamlphp/vendor/robrichards/xmlseclibs/src/XMLSecurityKey.php:580

RobRichards\XMLSecLibs\XMLSecurityKey->signData("SAMLRequest=fVJdb8IgFP0rDe%2BVWr9aoiZOs8zETbO6Pexl...")
 at 
/home/lisaseeto/code/mahara/htdocs/auth/saml/extlib/simplesamlphp/vendor/simplesamlphp/saml2/src/SAML2/HTTPRedirect.php:61
SAML2\HTTPRedirect->getRedirectURL(object(SAML2\AuthnRequest)) at 
/home/lisaseeto/code/mahara/htdocs/auth/saml/extlib/simplesamlphp/vendor/simplesamlphp/saml2/src/SAML2/HTTPRedirect.php:84
SAML2\HTTPRedirect->send(object(SAML2\AuthnRequest)) at 
/home/lisaseeto/code/mahara/htdocs/auth/saml/extlib/simplesamlphp/modules/saml/lib/Auth/Source/SP.php:704
SimpleSAML\Module\saml\Auth\Source\SP->sendSAML2AuthnRequest(array(size 
18), object(SAML2\HTTPRedirect), object(SAML2\AuthnRequest)) at 
/home/lisaseeto/code/mahara/htdocs/auth/saml/extlib/simplesamlphp/modules/saml/lib/Auth/Source/SP.php:686

SimpleSAML\Module\saml\Auth\Source\SP->startSSO2(object(SimpleSAML\Configuration),
 array(size 18)) at 
/home/lisaseeto/code/mahara/htdocs/auth/saml/extlib/simplesamlphp/modules/saml/lib/Auth/Source/SP.php:728

SimpleSAML\Module\saml\Auth\Source\SP->startSSO("http://idp1:8084/simplesaml/saml2/idp/metadata.php;,
 array(size 15)) at 
/home/lisaseeto/code/mahara/htdocs/auth/saml/extlib/simplesamlphp/modules/saml/lib/Auth/Source/SP.php:826
SimpleSAML\Module\saml\Auth\Source\SP->authenticate(array(size 15)) at 
/home/lisaseeto/code/mahara/htdocs/auth/saml/extlib/simplesamlphp/lib/SimpleSAML/Auth/Source.php:208
SimpleSAML\Auth\Source->initLogin("http://mahara/auth/saml/index.php;, 
null, array(size 3)) at 
/home/lisaseeto/code/mahara/htdocs/auth/saml/extlib/simplesamlphp/lib/SimpleSAML/Auth/Simple.php:167
SimpleSAML\Auth\Simple->login(array(size 3)) at 
/home/lisaseeto/code/mahara/htdocs/auth/saml/extlib/simplesamlphp/lib/SimpleSAML/Auth/Simple.php:109
SimpleSAML\Auth\Simple->requireAuth(array(size 2)) at 
/home/lisaseeto/code/mahara/htdocs/auth/saml/index.php:127

[WAR] 84 (lib/errors.php:536) [SimpleSAML\Error\UnserializableException]: 
Failure Signing Data: error:23077074:PKCS12 routines:PKCS12_pbe_crypt:pkcs12 
cipherfinal error - SHA256 at 
/home/lisaseeto/code/mahara/htdocs/auth/saml/extlib/simplesamlphp/lib/SimpleSAML/Auth/Source.php:212
Call stack (most recent first):

exception(object(SimpleSAML\Error\UnserializableException)) at
Unknown:0

Mahara: Site unavailable
A nonrecoverable error occurred. This probably means you have encountered a bug 
in the system

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1889485

Title:
  Security Upgrade SimpleSAML 1.18.4 to 1.18.7

Status in Mahara:
  Confirmed
Status in Mahara 19.04 series:
  Confirmed
Status in Mahara 19.10 series:
  Confirmed
Status in Mahara 20.04 series:
  Confirmed
Status in Mahara 20.10 series:
  Confirmed

Bug description:
  From https://simplesamlphp.org/security/202004-01:

  Date
  April 03, 2020
  Affected versions
  SimpleSAMLphp 1.18.5 and older
  Severity
  Low

  Background

  The module controller in SimpleSAML\Module that processes requests for pages 
hosted by modules, has code to identify paths ending with .php and process 
those as PHP code. If no other suitable way of handling the given path exists 
it presents the file to the browser.
  Description

  The check to identify paths ending with .php does not account for uppercase 
letters. If someone requests a path ending with e.g. .PHP and the server is 
serving the code from a case-insensitive file system, such as on Windows, the 
processing of the PHP code does not occur, and the source code is instead 
presented to the browser.
  Affected 

[Mahara-contributors] [Bug 1889487] [NEW] Remove the 'subject' line in the notification body

2020-07-29 Thread Kristina Hoeppner
Public bug reported:

When you receive an email notification (only tested with the plain text
message), e.g. from the LTI activity or when an admin logged in as you
(probably also others), a subject line is written in the body of the
email message you receive:

===


You have been sent a notification from Mahara Site Name. Message follows:


Subject: Assessment submission to "course" - "assignment"

Student's Name has submitted "Untitled v.2" to "course" - "assignment"

Please grade this submission by clicking on the activity "assignment" in
your LMS



This is an auto-generated notification from MyPortfolio Tertiary. To update
your notification preferences, visit
https://myportfolio.ac.nz/account/activity/preferences/index.php

Please do not reply to this message.


===


However, the subject is already mentioned in the proper subject line of the 
email notification and thus shouldn't have to be repeated in the body of the 
message.

** Affects: mahara
 Importance: Medium
 Status: Triaged

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1889487

Title:
  Remove the 'subject' line in the notification body

Status in Mahara:
  Triaged

Bug description:
  When you receive an email notification (only tested with the plain
  text message), e.g. from the LTI activity or when an admin logged in
  as you (probably also others), a subject line is written in the body
  of the email message you receive:

  ===


  You have been sent a notification from Mahara Site Name. Message follows:
  

  Subject: Assessment submission to "course" - "assignment"

  Student's Name has submitted "Untitled v.2" to "course" - "assignment"

  Please grade this submission by clicking on the activity "assignment"
  in your LMS

  

  This is an auto-generated notification from MyPortfolio Tertiary. To update
  your notification preferences, visit
  https://myportfolio.ac.nz/account/activity/preferences/index.php

  Please do not reply to this message.


  ===

  
  However, the subject is already mentioned in the proper subject line of the 
email notification and thus shouldn't have to be repeated in the body of the 
message.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1889487/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1889485] [NEW] Security Upgrade SimpleSAML 1.18.4 to 1.18.7

2020-07-29 Thread Lisa Seeto
*** This bug is a security vulnerability ***

Public security bug reported:

>From https://simplesamlphp.org/security/202004-01:

Date
April 03, 2020
Affected versions
SimpleSAMLphp 1.18.5 and older
Severity
Low

Background

The module controller in SimpleSAML\Module that processes requests for pages 
hosted by modules, has code to identify paths ending with .php and process 
those as PHP code. If no other suitable way of handling the given path exists 
it presents the file to the browser.
Description

The check to identify paths ending with .php does not account for uppercase 
letters. If someone requests a path ending with e.g. .PHP and the server is 
serving the code from a case-insensitive file system, such as on Windows, the 
processing of the PHP code does not occur, and the source code is instead 
presented to the browser.
Affected versions

SimpleSAMLphp versions 1.18.5 and older.

We will upgrade to version 1.18.7

** Affects: mahara
 Importance: High
 Assignee: Lisa Seeto (lisaseeto)
 Status: Confirmed

** Affects: mahara/19.04
 Importance: High
 Status: Confirmed

** Affects: mahara/19.10
 Importance: High
 Status: Confirmed

** Affects: mahara/20.04
 Importance: High
 Status: Confirmed

** Affects: mahara/20.10
 Importance: High
 Assignee: Lisa Seeto (lisaseeto)
 Status: Confirmed

** Changed in: mahara
Milestone: None => 19.10.4

** Changed in: mahara
Milestone: 19.10.4 => None

** Changed in: mahara
Milestone: None => 19.04.6

** Also affects: mahara/19.10
   Importance: Undecided
   Status: New

** Also affects: mahara/19.04
   Importance: Undecided
   Status: New

** Also affects: mahara/20.10
   Importance: High
   Status: New

** Also affects: mahara/20.04
   Importance: Undecided
   Status: New

** Changed in: mahara/20.10
Milestone: 19.04.6 => 20.10.0

** Changed in: mahara/20.04
Milestone: None => 20.04.1

** Changed in: mahara/20.10
Milestone: 20.10.0 => None

** Changed in: mahara/20.10
Milestone: None => 20.10.0

** Changed in: mahara/19.10
Milestone: None => 19.10.4

** Changed in: mahara/19.04
Milestone: None => 19.04.6

** Changed in: mahara/20.10
   Status: New => In Progress

** Changed in: mahara/20.10
 Assignee: (unassigned) => Lisa Seeto (lisaseeto)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1889485

Title:
  Security Upgrade SimpleSAML 1.18.4 to 1.18.7

Status in Mahara:
  Confirmed
Status in Mahara 19.04 series:
  Confirmed
Status in Mahara 19.10 series:
  Confirmed
Status in Mahara 20.04 series:
  Confirmed
Status in Mahara 20.10 series:
  Confirmed

Bug description:
  From https://simplesamlphp.org/security/202004-01:

  Date
  April 03, 2020
  Affected versions
  SimpleSAMLphp 1.18.5 and older
  Severity
  Low

  Background

  The module controller in SimpleSAML\Module that processes requests for pages 
hosted by modules, has code to identify paths ending with .php and process 
those as PHP code. If no other suitable way of handling the given path exists 
it presents the file to the browser.
  Description

  The check to identify paths ending with .php does not account for uppercase 
letters. If someone requests a path ending with e.g. .PHP and the server is 
serving the code from a case-insensitive file system, such as on Windows, the 
processing of the PHP code does not occur, and the source code is instead 
presented to the browser.
  Affected versions

  SimpleSAMLphp versions 1.18.5 and older.

  We will upgrade to version 1.18.7

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1889485/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1889485] Re: Security Upgrade SimpleSAML 1.18.4 to 1.18.7

2020-07-29 Thread Robert Lyon
** Changed in: mahara/20.04
   Importance: Undecided => High

** Changed in: mahara/19.10
   Importance: Undecided => High

** Changed in: mahara/19.04
   Importance: Undecided => High

** Changed in: mahara/20.10
   Status: In Progress => Confirmed

** Changed in: mahara/20.04
   Status: New => Confirmed

** Changed in: mahara/19.10
   Status: New => Confirmed

** Changed in: mahara/19.04
   Status: New => Confirmed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1889485

Title:
  Security Upgrade SimpleSAML 1.18.4 to 1.18.7

Status in Mahara:
  Confirmed
Status in Mahara 19.04 series:
  Confirmed
Status in Mahara 19.10 series:
  Confirmed
Status in Mahara 20.04 series:
  Confirmed
Status in Mahara 20.10 series:
  Confirmed

Bug description:
  From https://simplesamlphp.org/security/202004-01:

  Date
  April 03, 2020
  Affected versions
  SimpleSAMLphp 1.18.5 and older
  Severity
  Low

  Background

  The module controller in SimpleSAML\Module that processes requests for pages 
hosted by modules, has code to identify paths ending with .php and process 
those as PHP code. If no other suitable way of handling the given path exists 
it presents the file to the browser.
  Description

  The check to identify paths ending with .php does not account for uppercase 
letters. If someone requests a path ending with e.g. .PHP and the server is 
serving the code from a case-insensitive file system, such as on Windows, the 
processing of the PHP code does not occur, and the source code is instead 
presented to the browser.
  Affected versions

  SimpleSAMLphp versions 1.18.5 and older.

  We will upgrade to version 1.18.7

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1889485/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1888743] Re: clean up references to old menu structure

2020-07-29 Thread Lisa Seeto
** Changed in: mahara
   Status: New => In Progress

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1888743

Title:
  clean up references to old menu structure

Status in Mahara:
  In Progress

Bug description:
  Currently we still have some references to the old menu structure within 
Mahara.
  'myportfolio' and 'content' should both be updated to 'create'.

  Change: define(MENUITEM', 'myportfolio');
  To: define('MENUITEM', 'create');

  In the following files:
  relatedtags.php
  artefact/annotation/edit.php
  artefact/comment/edit.php
  artefact/peerassessment/edit.php

  In artefact/internal/socialprofile.php:
  Change: define('MENUITEM', 'content/profile');
  To: define('MENUITEM', 'create/files');

  In htdocs/lib/web.php:
  Change (ln 1476 in a comment): in_array(MENUITEM, array('myportfolio/view'))),
  To: in_array(MENUITEM, array('create/view'))),

  The old code was discovered when upgrading a site from 18.10 to 20.04.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1888743/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1889480] Re: Adding new Maroon theme

2020-07-29 Thread Robert Lyon
Adding some fixes for the new theme and existing theme fonts

1) Install the new Alegreya / AlegreyaSans fonts to database so they can
be used in skins

2) The Admin -> Configure site -> Fonts page was not displaying the new fonts
- needed to update the theme's font paths to be lowercase

3) Added missing README.Mahara files for fonts in themes (except raw as
it had one already)

4) Fixed problem where 'shadow into light two' font has wrong path when
building skin thumbnails

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1889480

Title:
  Adding new Maroon theme

Status in Mahara:
  In Progress

Bug description:
  Adding a new theme called Maroon

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1889480/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1889480] Re: Adding new Maroon theme

2020-07-29 Thread Robert Lyon
https://reviews.mahara.org/#/c/11048

Patch for new theme

** Changed in: mahara
Milestone: None => 20.10.0

** Changed in: mahara
   Importance: Undecided => High

** Changed in: mahara
   Importance: High => Wishlist

** Changed in: mahara
   Status: New => In Progress

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1889480

Title:
  Adding new Maroon theme

Status in Mahara:
  In Progress

Bug description:
  Adding a new theme called Maroon

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1889480/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1889480] [NEW] Adding new Maroon theme

2020-07-29 Thread Robert Lyon
Public bug reported:

Adding a new theme called Maroon

** Affects: mahara
 Importance: Wishlist
 Status: In Progress

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1889480

Title:
  Adding new Maroon theme

Status in Mahara:
  In Progress

Bug description:
  Adding a new theme called Maroon

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1889480/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1888743] Re: clean up references to old menu structure

2020-07-29 Thread Robert Lyon
** Changed in: mahara
 Assignee: (unassigned) => Lisa Seeto (lisaseeto)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1888743

Title:
  clean up references to old menu structure

Status in Mahara:
  New

Bug description:
  Currently we still have some references to the old menu structure within 
Mahara.
  'myportfolio' and 'content' should both be updated to 'create'.

  Change: define(MENUITEM', 'myportfolio');
  To: define('MENUITEM', 'create');

  In the following files:
  relatedtags.php
  artefact/annotation/edit.php
  artefact/comment/edit.php
  artefact/peerassessment/edit.php

  In artefact/internal/socialprofile.php:
  Change: define('MENUITEM', 'content/profile');
  To: define('MENUITEM', 'create/files');

  In htdocs/lib/web.php:
  Change (ln 1476 in a comment): in_array(MENUITEM, array('myportfolio/view'))),
  To: in_array(MENUITEM, array('create/view'))),

  The old code was discovered when upgrading a site from 18.10 to 20.04.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1888743/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1889369] [NEW] Language menu shows when there's only one language

2020-07-29 Thread Peter Spicer
Public bug reported:

On a fresh 20.04, we've seen cases of the language menu showing up even
when only one language is actually present.

The reason is that LANGCHOICES is an array of all possible languages
that can be selected, and the test in the template to show/hide the
language selector is whether LANGCHOICES is empty or not.

There should be an additional flag for 'show language selector' which is
true/false based on whether LANGCHOICES has > 1 entry or not in it.

** Affects: mahara
 Importance: Undecided
 Status: New

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1889369

Title:
  Language menu shows when there's only one language

Status in Mahara:
  New

Bug description:
  On a fresh 20.04, we've seen cases of the language menu showing up
  even when only one language is actually present.

  The reason is that LANGCHOICES is an array of all possible languages
  that can be selected, and the test in the template to show/hide the
  language selector is whether LANGCHOICES is empty or not.

  There should be an additional flag for 'show language selector' which
  is true/false based on whether LANGCHOICES has > 1 entry or not in it.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1889369/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp