[Mahara-contributors] [Bug 1890238] [NEW] Text block 'Quick edit' retract and double bar display issues

2020-08-03 Thread Rangi Daymond
Public bug reported:

Test environment: current master
Browser: Chrome (latest)

Test steps:
1. As a logged in person, create a new page "Test page".
2. Add a text block as follows:
   - block title "Text Block"
   - leave the instructions blank
   - insert some content in the text block
   - set retractable to "Yes"
   - Save the block.
3. Select to view/display the page.
   Expected result: ✔ The page is displayed with the "Quick edit" bar, 
 the content is NOT retracted.
   Actual result: as expected.
4. Select to retract the block content then expand it.
   Expected result: X The block content is retracted then expanded correctly.
   Actual result: The block content is retracted but so is most of the "Quick 
edit" bar.
   The page must be reloaded to display correctly.
5. (Reload the page) Select the "Quick edit" bar, the 'Text Block" edit panel 
is displayed,
   update the block content then Save.
   Expected result: ✔ The content change is displayed.
   Actual result: as expected.
6. Select the "Details" icon (top right of screen).
   Expected result: The 'Text Block" edit panel is displayed.
   Actual result: X The "Quick edit" bar disappears.
7. Select the "Details" icon again (top right of screen).
   Actual result: X Two "Quick edit" bars are displayed.
   
Please see attached mp4 video file

** Affects: mahara
 Importance: Undecided
 Status: New

** Attachment added: "QuickEditBugs.mp4"
   
https://bugs.launchpad.net/bugs/1890238/+attachment/5398595/+files/QuickEditBugs.mp4

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1890238

Title:
  Text block 'Quick edit' retract and double bar display issues

Status in Mahara:
  New

Bug description:
  Test environment: current master
  Browser: Chrome (latest)

  Test steps:
  1. As a logged in person, create a new page "Test page".
  2. Add a text block as follows:
 - block title "Text Block"
 - leave the instructions blank
 - insert some content in the text block
 - set retractable to "Yes"
 - Save the block.
  3. Select to view/display the page.
 Expected result: ✔ The page is displayed with the "Quick edit" bar, 
   the content is NOT retracted.
 Actual result: as expected.
  4. Select to retract the block content then expand it.
 Expected result: X The block content is retracted then expanded correctly.
 Actual result: The block content is retracted but so is most of the "Quick 
edit" bar.
 The page must be reloaded to display correctly.
  5. (Reload the page) Select the "Quick edit" bar, the 'Text Block" edit panel 
is displayed,
 update the block content then Save.
 Expected result: ✔ The content change is displayed.
 Actual result: as expected.
  6. Select the "Details" icon (top right of screen).
 Expected result: The 'Text Block" edit panel is displayed.
 Actual result: X The "Quick edit" bar disappears.
  7. Select the "Details" icon again (top right of screen).
 Actual result: X Two "Quick edit" bars are displayed.
 
  Please see attached mp4 video file

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1890238/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1888163] Re: Security issue: File / folder name not being escaped correctly in filebrowser

2020-08-03 Thread Robert Lyon
** Information type changed from Private Security to Public Security

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1888163

Title:
  Security issue: File / folder name not being escaped correctly in
  filebrowser

Status in Mahara:
  Fix Committed
Status in Mahara 19.04 series:
  Fix Released
Status in Mahara 19.10 series:
  Fix Released
Status in Mahara 20.04 series:
  Fix Released
Status in Mahara 20.10 series:
  Fix Committed

Bug description:
  In your browser with the debug console visible to see javascript
  output

  Have a site and go to the Create -> Files page

  Upload an image and then edit it and change the
  name: Imageconsole.log('bad name!');one
  description: This is Imageconsole.log('bad 
description!');one description

  Create a new folder called:
  Folderconsole.log('bad folder!');one

  Go into the new folder and upload another file

  Problem 1 you see 'bad folder!' in the console bar

  Create a page and add an image block to the page and select the image
  with bad name

  Problem 2 you see 'bad name!' in console bar

  Save block and then edit it again

  Problem 3 you see 'bad name!' in console bar again

  Add the folder block to the page

  Problem 4 you see 'bad folder!' in the console bar

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1888163/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1871280] Re: Allow grouproles to be reset for users when roles updated via webservices

2020-08-03 Thread Lisa Seeto
** Changed in: mahara/20.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1871280

Title:
  Allow grouproles to be reset for users when roles updated via
  webservices

Status in Mahara:
  Fix Committed
Status in Mahara 19.04 series:
  Won't Fix
Status in Mahara 19.10 series:
  Won't Fix
Status in Mahara 20.04 series:
  Fix Released
Status in Mahara 20.10 series:
  Fix Committed

Bug description:
  When creating new groups via webservices while the user is logged in.

  The "group/find.php" search works with a user's grouproles and when a
  group is created via webservice the grouproles are not reset for the
  session. So only after the user logged out and logged in again, the
  group is found with "group/find.php".

  We need to set a flag so that when a person loads anything in mahara
  (eg calls the $user->renew() function) that it resets the group roles
  for the user so they don't have to logout and login again.

  Added from discussion with Robert (2020-05-08):
  The group_add_user() and group_remove_user() functions already call the 
$USER->reset_grouproles() function - so this patch is only fixing the problem 
when group_create() is called. In 'normal' Mahara we can't create a group with 
more than the current user, but via webservice we can create a group with many 
members at once and that causes this problem.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1871280/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1876625] Re: Date picker not working for Admin -> People when selecting a date to filter users

2020-08-03 Thread Lisa Seeto
** Changed in: mahara/20.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1876625

Title:
  Date picker not working for Admin -> People when selecting a date to
  filter users

Status in Mahara:
  Fix Committed
Status in Mahara 19.04 series:
  Fix Released
Status in Mahara 19.10 series:
  Fix Released
Status in Mahara 20.04 series:
  Fix Released
Status in Mahara 20.10 series:
  Fix Committed

Bug description:
  To test:

  Go to Admin -> People -> Search Users
  Click on Advanced options and select 'People have not logged since' from the 
'Last login' dropdown

  The results should change

  Note: for good testing you will need to update some users to have varying 
'lastlogin' values 
  - you can do this by going, eg:
   UPDATE usr SET lastlogin = '2020-01-01 12:12:12' WHERE id = 2;
   UPDATE usr SET lastlogin = '2020-02-02 12:12:12' WHERE id = 3;
  etc

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1876625/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1880803] Re: errors when copying a page after editing column widths manually

2020-08-03 Thread Lisa Seeto
** Changed in: mahara/20.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1880803

Title:
  errors when copying a page after editing column widths manually

Status in Mahara:
  Fix Committed
Status in Mahara 19.04 series:
  Fix Released
Status in Mahara 19.10 series:
  Fix Released
Status in Mahara 20.04 series:
  Fix Released
Status in Mahara 20.10 series:
  Fix Committed

Bug description:
  For any version newer than 19.04, follow the steps below and then
  upgrade. It will display the same errors when trying to copy or
  translate the view with the old layout.

  On 19.04

  to replicate:
  - go to User menu-> Preferences -> Settigns
  - set 'Show controls to add and remove columns when editing a page' to yes 
and save
  - create a view
  - set a custom layout e.g. 3 rows with 3 columns and 1 row with 1 column
  - play with the column changing the widths
  - display the page and make a copy and try to edit the view

  the following errors are displayed

  [WAR] 28 (lib/view.php:2994) Undefined offset: 4
  Call stack (most recent first):

  log_message("Undefined offset: 4", 8, true, true, 
"/home/ceciliavg/maharacode/mahara/htdocs/lib/view", 2994) at 
/home/ceciliavg/maharacode/mahara/htdocs/lib/errors.php:520
  error(8, "Undefined offset: 4", 
"/home/ceciliavg/maharacode/mahara/htdocs/lib/view", 2994, array(size 4)) 
at /home/ceciliavg/maharacode/mahara/htdocs/lib/view.php:2994
  View->removerow(array(size 2)) at 
/home/ceciliavg/maharacode/mahara/htdocs/view/editlayout.php:701
  set_view_layout(object(Pieform), array(size 16)) at 
/home/ceciliavg/maharacode/mahara/htdocs/view/editlayout.php:643
  settings_submit(object(Pieform), array(size 16)) at 
/home/ceciliavg/maharacode/mahara/htdocs/lib/pieforms/pieform.php:544
  Pieform->__construct(array(size 5)) at 
/home/ceciliavg/maharacode/mahara/htdocs/lib/pieforms/pieform.php:166
  Pieform::process(array(size 5)) at 
/home/ceciliavg/maharacode/mahara/htdocs/lib/mahara.php:5445
  pieform(array(size 5)) at 
/home/ceciliavg/maharacode/mahara/htdocs/view/editlayout.php:222
  create_settings_pieform() at 
/home/ceciliavg/maharacode/mahara/htdocs/view/editlayout.php:106

  [WAR] 28 (lib/view.php:2994) Undefined offset: 3
  Call stack (most recent first):

  log_message("Undefined offset: 3", 8, true, true, 
"/home/ceciliavg/maharacode/mahara/htdocs/lib/view", 2994) at 
/home/ceciliavg/maharacode/mahara/htdocs/lib/errors.php:520
  error(8, "Undefined offset: 3", 
"/home/ceciliavg/maharacode/mahara/htdocs/lib/view", 2994, array(size 4)) 
at /home/ceciliavg/maharacode/mahara/htdocs/lib/view.php:2994
  View->removerow(array(size 2)) at 
/home/ceciliavg/maharacode/mahara/htdocs/view/editlayout.php:701
  set_view_layout(object(Pieform), array(size 16)) at 
/home/ceciliavg/maharacode/mahara/htdocs/view/editlayout.php:643
  settings_submit(object(Pieform), array(size 16)) at 
/home/ceciliavg/maharacode/mahara/htdocs/lib/pieforms/pieform.php:544
  Pieform->__construct(array(size 5)) at 
/home/ceciliavg/maharacode/mahara/htdocs/lib/pieforms/pieform.php:166
  Pieform::process(array(size 5)) at 
/home/ceciliavg/maharacode/mahara/htdocs/lib/mahara.php:5445
  pieform(array(size 5)) at 
/home/ceciliavg/maharacode/mahara/htdocs/view/editlayout.php:222
  create_settings_pieform() at 
/home/ceciliavg/maharacode/mahara/htdocs/view/editlayout.php:106

  [WAR] 28 (lib/view.php:2994) Undefined offset: 2
  Call stack (most recent first):

  log_message("Undefined offset: 2", 8, true, true, 
"/home/ceciliavg/maharacode/mahara/htdocs/lib/view", 2994) at 
/home/ceciliavg/maharacode/mahara/htdocs/lib/errors.php:520
  error(8, "Undefined offset: 2", 
"/home/ceciliavg/maharacode/mahara/htdocs/lib/view", 2994, array(size 4)) 
at /home/ceciliavg/maharacode/mahara/htdocs/lib/view.php:2994
  View->removerow(array(size 2)) at 
/home/ceciliavg/maharacode/mahara/htdocs/view/editlayout.php:701
  set_view_layout(object(Pieform), array(size 16)) at 
/home/ceciliavg/maharacode/mahara/htdocs/view/editlayout.php:643
  settings_submit(object(Pieform), array(size 16)) at 
/home/ceciliavg/maharacode/mahara/htdocs/lib/pieforms/pieform.php:544
  Pieform->__construct(array(size 5)) at 
/home/ceciliavg/maharacode/mahara/htdocs/lib/pieforms/pieform.php:166
  Pieform::process(array(size 5)) at 
/home/ceciliavg/maharacode/mahara/htdocs/lib/mahara.php:5445
  pieform(array(size 5)) at 
/home/ceciliavg/maharacode/mahara/htdocs/view/editlayout.php:222
  create_settings_pieform() at 
/home/ceciliavg/maharacode/mahara/htdocs/view/editlayout.php:106

To manage notifications about this bug go 

[Mahara-contributors] [Bug 1883043] Re: collection pages unvailable as link options in tinyMCE

2020-08-03 Thread Lisa Seeto
** Changed in: mahara/20.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1883043

Title:
  collection pages unvailable as link options in tinyMCE

Status in Mahara:
  Fix Committed
Status in Mahara 19.10 series:
  Fix Released
Status in Mahara 20.04 series:
  Fix Released
Status in Mahara 20.10 series:
  Fix Committed

Bug description:
  When inserting a link using the tinyMCE editor the drop down for "Link
  List" options should display all pages including pages in a
  collection.  This functionality existing in 19.04 (see attached screen
  shot 'tinyMCE-collections.png') but had changed in 19.10 and now no
  longer offers the option.  It should return to its previous function.

  Affects Mahara 19.10, 20.04.

  To test:
  1. On 19.04, create a collection (1 page is fine) and a portfolio page.
  2. Edit the portfolio page and select a text block. In the tinyMCE editor 
select to insert a link and in the pop-up box, select the drop-down for "Link 
List".
  3. See that the link list options contain the collection page(s)
  4. Upgrade to 19.10 and perform, edit the portfolio page and click to accept 
the grid stack transformation
  5. Edit the text block and select to insert a link, select the drop-down for 
"Link List"
  Expected results:
  All pages including the collection->pages display
  Actual results:
  The collection pages are not included.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1883043/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1877001] Re: Skins not showing after upgrade

2020-08-03 Thread Lisa Seeto
** Changed in: mahara/20.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1877001

Title:
  Skins not showing after upgrade

Status in Mahara:
  Fix Committed
Status in Mahara 19.10 series:
  Fix Released
Status in Mahara 20.04 series:
  Fix Released
Status in Mahara 20.10 series:
  Fix Committed

Bug description:
  When upgrading from an older site to 19.10+ site the skins stop
  showing on pages

  and there are error messages in the logs regarding this

  * error(8, "Undefined index: view_block_header_font",
  "/var/www/skin/style.php", 82, array(size 68)) at
  /var/www/skin/style.php:82

  We need an upgrade step to add in blank values for the 2 new fields

  view_block_header_font
  view_block_header_font_color

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1877001/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1889485] Re: Security Upgrade SimpleSAML 1.18.4 to 1.18.7

2020-08-03 Thread Lisa Seeto
** Changed in: mahara/20.04
   Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1889485

Title:
  Security Upgrade SimpleSAML 1.18.4 to 1.18.7

Status in Mahara:
  Fix Committed
Status in Mahara 19.04 series:
  Fix Released
Status in Mahara 19.10 series:
  Fix Released
Status in Mahara 20.04 series:
  Fix Released
Status in Mahara 20.10 series:
  Fix Committed

Bug description:
  From https://simplesamlphp.org/security/202004-01:

  Date
  April 03, 2020
  Affected versions
  SimpleSAMLphp 1.18.5 and older
  Severity
  Low

  Background

  The module controller in SimpleSAML\Module that processes requests for pages 
hosted by modules, has code to identify paths ending with .php and process 
those as PHP code. If no other suitable way of handling the given path exists 
it presents the file to the browser.
  Description

  The check to identify paths ending with .php does not account for uppercase 
letters. If someone requests a path ending with e.g. .PHP and the server is 
serving the code from a case-insensitive file system, such as on Windows, the 
processing of the PHP code does not occur, and the source code is instead 
presented to the browser.
  Affected versions

  SimpleSAMLphp versions 1.18.5 and older.

  We will upgrade to version 1.18.7

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1889485/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1882103] Re: Wrong redirect when creating Pages when Mahara is in a subdir

2020-08-03 Thread Lisa Seeto
** Changed in: mahara/20.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1882103

Title:
  Wrong redirect when creating Pages when Mahara is in a subdir

Status in Mahara:
  Fix Committed
Status in Mahara 19.04 series:
  Fix Released
Status in Mahara 19.10 series:
  Fix Released
Status in Mahara 20.04 series:
  Fix Released
Status in Mahara 20.10 series:
  Fix Committed

Bug description:
  Referencing Bug #1843537
  (https://bugs.launchpad.net/mahara/+bug/1843537)

  In Mahara 20.04 this Bug seems to affect the creation of pages.

  When trying to create a new page while Mahara is installed in a
  subdirectory (https://dns/mahara), after saving the newly created page
  it is created successfully but the user is redirected to an error page
  because wwwroot is missing.

  The problem seems to be in:
  mahara/htdocs/view/editlayout.php in Line 441 

  Much like in the CSV Upload error it does not include the root
  directory

  The original:
  redirect('/view/blocks.php?id=' . $view->get('id'));

  Ammended:
  redirect(get_config('wwwroot') . 'view/blocks.php?id=' . $view->get('id'));

  After changing this, the saving progress redirects to the correct
  page.

  
  Greetings from Germany,

  Philippe

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1882103/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1879410] Re: Add a text block in Dashboard page using TestingDataGenerator.php

2020-08-03 Thread Lisa Seeto
** Changed in: mahara/20.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1879410

Title:
  Add a text block in Dashboard page using TestingDataGenerator.php

Status in Mahara:
  Fix Committed
Status in Mahara 19.04 series:
  Fix Released
Status in Mahara 19.10 series:
  Fix Released
Status in Mahara 20.04 series:
  Fix Released
Status in Mahara 20.10 series:
  Fix Committed

Bug description:
  Data generator scripts are used to auto-populate cloud instances
  (Mahara QA sites) with pre-defined test data.

  Modification of the create_block() function of
  TestingDataGenerator.php is required to add a Text block in the
  Dashboard page.

  Test instructions:
  A site created with pre-populated data using the data population script 
should have a Text block in the dashboard page of every people with info like 
group count, group admin count, group member count.

  When logged in as People1 the text block on dashboard will have 
  Group Count:2 Group Admin:2 Group member:0 
  and for People101
  Group Count:2 Group Admin:1 Group member:1

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1879410/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1876810] Re: More of the count(): Parameter must be an array or an object that implements Countable

2020-08-03 Thread Lisa Seeto
** Changed in: mahara/20.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1876810

Title:
  More of the  count(): Parameter must be an array or an object that
  implements Countable

Status in Mahara:
  Fix Committed
Status in Mahara 20.04 series:
  Fix Released
Status in Mahara 20.10 series:
  Fix Committed

Bug description:
  There were a bunch of places fixed in Bug 1812910 - but there looks to
  have been some places missed in the templates

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1876810/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1885784] Re: Need to update site options submit function to use alias

2020-08-03 Thread Lisa Seeto
** Changed in: mahara/20.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1885784

Title:
  Need to update site options submit function to use alias

Status in Mahara:
  Fix Committed
Status in Mahara 19.04 series:
  Fix Released
Status in Mahara 19.10 series:
  Fix Released
Status in Mahara 20.04 series:
  Fix Released
Status in Mahara 20.10 series:
  Fix Committed

Bug description:
  Currently our code base is using a database call with a query that
  contains a term inserted in escaped characters.  It is more robust and
  safer to use an alias rather than rely that variables put into escaped
  quotes will always reliably work.

  The DB query in question is in admin/site/options.php during the
  siteoptions_submit().

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1885784/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1885231] Re: Class 'Institution' not found when viewing another user's profile page

2020-08-03 Thread Lisa Seeto
** Changed in: mahara/20.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1885231

Title:
   Class 'Institution' not found when viewing another user's profile
  page

Status in Mahara:
  Fix Committed
Status in Mahara 19.04 series:
  Fix Released
Status in Mahara 19.10 series:
  Fix Released
Status in Mahara 20.04 series:
  Fix Released
Status in Mahara 20.10 series:
  Fix Committed

Bug description:
  When we have the following:

  0) Start with a 19.04 site
  1) A site / institution with SE framework enabled
  2) User A creates a collection but does NOT share it
  3) User A adds a 'navigation' block to their profile page and chooses the 
collection
  4) User B logs in and searches up User A goes to the profile page of User A
  - gets error

  The problem here is the navigation block wants to go to function
  get_framework_institution() to work out some info and it fails if
  institution class has not been included

  So we need to make sure institution class is included at the start of
  that function

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1885231/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1875154] Re: PDF export not mentioned on export page when it's available

2020-08-03 Thread Lisa Seeto
** Changed in: mahara/20.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1875154

Title:
  PDF export not mentioned on export page when it's available

Status in Mahara:
  Fix Committed
Status in Mahara 20.04 series:
  Fix Released
Status in Mahara 20.10 series:
  Fix Committed

Bug description:
  When the PDF export has been enabled, a portfolio author does not know
  that it is available because Main menu -> Manage -> Export
  /export/index.php does not mention it, but it should.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1875154/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1875973] Re: Mahara: Site information block needs link to download updated

2020-08-03 Thread Lisa Seeto
** Changed in: mahara/20.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1875973

Title:
  Mahara: Site information block needs link to download updated

Status in Mahara:
  Fix Committed
Status in Mahara 20.04 series:
  Fix Released
Status in Mahara 20.10 series:
  Fix Committed

Bug description:
  Currently it links to launchpad but we want it to link to
  https://www.mahara.org/download

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1875973/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1879847] Re: String missing for allow public views in Reports

2020-08-03 Thread Lisa Seeto
** Changed in: mahara/20.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1879847

Title:
  String missing for allow public views in Reports

Status in Mahara:
  Fix Committed
Status in Mahara 19.04 series:
  Fix Released
Status in Mahara 19.10 series:
  Fix Released
Status in Mahara 20.04 series:
  Fix Released
Status in Mahara 20.10 series:
  Fix Committed

Bug description:
  There is a what looks like a missing string when making a report that shows 
"Content".
  The missing string shows up as: [[allowpublicviews/statistics]] on the page.

  Repo steps:
  - Log in as site admin and go to Admin menu -> Reports
  - Select to 'Configure Report' to open the "Report Configuration" modal.
  - In the 'Report type' drop down select 'Content' the save.
  Expected results:
  - Text displays correctly
  Actual results:
  - [[allowpublicviews/statistics]] appears in column.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1879847/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1886371] Re: Migrate Institution is producing a warning message

2020-08-03 Thread Lisa Seeto
** Changed in: mahara/20.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1886371

Title:
  Migrate Institution is producing a warning message

Status in Mahara:
  Fix Committed
Status in Mahara 20.04 series:
  Fix Released
Status in Mahara 20.10 series:
  Fix Committed

Bug description:
  A warning message is being produced when a person selects to "Move
  Account" in attempt to migrate institution
  (account/migrateinstitution.php)

  To reproduce #1:
  1. Log in as a member of an institution
  2. Navigate to Account menu -> Settings -> Institution Membership
  3. Select "Move Account" link
  Expected results:
  The page "Move Account" displays without any error messages or warnings.
  Actual results:
  The page displays with warning messages (see screen shot)

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1886371/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1875958] Re: 'My groups' sidebar can get very long if you are in lots of groups

2020-08-03 Thread Lisa Seeto
** Changed in: mahara/20.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1875958

Title:
  'My groups' sidebar can get very long if you are in lots of groups

Status in Mahara:
  Fix Committed
Status in Mahara 19.04 series:
  Fix Released
Status in Mahara 19.10 series:
  Fix Released
Status in Mahara 20.04 series:
  Fix Released
Status in Mahara 20.10 series:
  Fix Committed

Bug description:
  When you are a member of many groups the list in the sidebar can get
  very long

  There is an account preference to restrict the list to 'Maximum number
  of groups to display'

  And now there is an account preference to restrict it to certain group
  labels

  But both these options require user making choices / setting up labels

  Another option to make the 'My groups' side bar a little more
  manageable is via css

  This option still lets you scroll to see all your groups but doesn't
  make the page overly long.

  Note: (25 May - after Robert questioned about how many groups should
  display before the scroll bar is displayed): apparently the 'My
  groups' sidebar should be 400px high maximum (or a scroll bar will be
  displayed). When browser View set at 100% this equates to
  approximately 14 lines(Chrome, Firefox & Edge), this number will vary
  depending upon the browser View setting +100-.  The number of groups
  shown before scrolling is also variable due to how many groups the
  person is admin for (2 lines) versus not admin for (1 line).  The
  length of the group name will also impact how many lines are taken per
  group.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1875958/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1882870] Re: Button obscuring text on Install Fonts page

2020-08-03 Thread Lisa Seeto
** Changed in: mahara/20.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1882870

Title:
  Button obscuring text on Install Fonts page

Status in Mahara:
  Fix Committed
Status in Mahara 20.04 series:
  Fix Released
Status in Mahara 20.10 series:
  Fix Committed

Bug description:
  The browse/ choose file button for selecting a "License" file on Admin
  Menu -> Configure Site -> Font -> Install font is obscuring the
  background description text.

  Please see the attached screen shot.

  This was tested in Raw, Ocean themes on current master.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1882870/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1877906] Re: MariaDB error when creating secret URL

2020-08-03 Thread Lisa Seeto
** Changed in: mahara/20.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1877906

Title:
  MariaDB error when creating secret URL

Status in Mahara:
  Fix Committed
Status in Mahara 19.10 series:
  Fix Released
Status in Mahara 20.04 series:
  Fix Released
Status in Mahara 20.10 series:
  Fix Committed

Bug description:
  We have the following error on a site with MariaDB and elascticsearch
  set up if we want to create a new secret URL for a view:

  mysqli error: [1064: You have an error in your SQL syntax; check the manual 
that corresponds to your MariaDB server version for the right syntax to use 
near 'WHERE NOT EXISTS (
  SELECT 1 FROM "search_elasticsearch_q' at line 2] in 
EXECUTE("INSERT INTO "search_elasticsearch_queue" (itemid, type)
  SELECT '1234', 'view' WHERE NOT EXISTS (
  SELECT 1 FROM "search_elasticsearch_queue" WHERE 
itemid = '1234' AND type = 'view'
  )")Command was: INSERT INTO "search_elasticsearch_queue" 
(itemid, type)
  SELECT ?, ? WHERE NOT EXISTS (
  SELECT 1 FROM "search_elasticsearch_queue" WHERE 
itemid = ? AND type = ?
  )

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1877906/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1883471] Re: reduce block margin on gridstack

2020-08-03 Thread Lisa Seeto
** Changed in: mahara/20.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1883471

Title:
  reduce block margin on gridstack

Status in Mahara:
  Fix Committed
Status in Mahara 19.10 series:
  Fix Released
Status in Mahara 20.04 series:
  Fix Released
Status in Mahara 20.10 series:
  Fix Committed

Bug description:
  There is too much bottom margin on the blocks when they are in display mode.
  This could be due to the margin of the resize handlers we have on edit mode 
(check image attached), where we set the block size. There is no need for this 
margin on display since we don't have the handlers there

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1883471/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1883179] Re: Profile Completion has incorrect instructions

2020-08-03 Thread Lisa Seeto
** Changed in: mahara/20.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1883179

Title:
  Profile Completion has incorrect instructions

Status in Mahara:
  Fix Committed
Status in Mahara 20.04 series:
  Fix Released
Status in Mahara 20.10 series:
  Fix Committed

Bug description:
  The description on the Profile Completion page (users/progressbar.php)
  contains the text:

  "Note: Profile completion is currently disabled. You will need to
  enable it in the "Account settings" section of "Configure site" before
  people can track their progress towards completing their profile."

  But the setting is available in the "Side block settings" section in
  Configure Site.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1883179/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1886596] Re: Behat testing data generator throws null on openbadgedisplayer

2020-08-03 Thread Lisa Seeto
** Changed in: mahara/20.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1886596

Title:
  Behat testing data generator throws null on openbadgedisplayer

Status in Mahara:
  Fix Committed
Status in Mahara 20.04 series:
  Fix Released
Status in Mahara 20.10 series:
  Fix Committed

Bug description:
  Update needed in Testing Data Generator after update in code requires
  'badgegroup' in the $configdata to must be an an array.(Currently is
  null  at initialisation)

  REPRODUCE 
  1. In the background steps of a test, add the openbadgedisplayer to a page
  2. Navigate to the page where the Open Badges block was added
  3. Leave the page to another page.

  Expected result: No errors on new page
  Current result: Errors about array indexes.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1886596/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1875785] Re: External links in Mahara no longer open in external tab/window by default

2020-08-03 Thread Lisa Seeto
** Changed in: mahara/20.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1875785

Title:
  External links in Mahara no longer open in external tab/window by
  default

Status in Mahara:
  Fix Committed
Status in Mahara 19.10 series:
  Fix Released
Status in Mahara 20.04 series:
  Fix Released
Status in Mahara 20.10 series:
  Fix Committed

Bug description:
  Code: Release 2020.04_RC2
  Browser/s: Chrome & Firefox
  Theme: Raw

  Summary: The functionality for related bug ​#1802205 'Make all
  external links in Mahara open in external tab/window by default' no
  longer works.

  Steps:

  As logged in PersonA:
  1. Create a new page with a text block on it that has a few/5 paragraphs of 
text.

  2. Use the tinymce editor to add the following links before the text 
paragraphs using the Insert/Edit Link modal:
  a. External URL = https://www.catalyst.net.nz/ 
 Text to display = 'Catalyst default-None, new tab/window'
 Open link in... = 'None'
  b. External URL = https://www.catalyst.net.nz/ 
 Text to display = 'Catalyst -same page'
 Open link in... = 'Same page'
  c. External URL display = https://www.catalyst.net.nz/ 
 Text to display = 'Catalyst -new tab/window'
 Open link in... = 'New window'
  d. Internal URL = 
http://http://mahara.rdaymond.wgtn.cat-it.co.nz/artefact/internal/index.php 
 Text to display = 'Profile page default-None, same tab/window'
 Open link in... = 'None'
  e. Internal URL = 
http://http://mahara.rdaymond.wgtn.cat-it.co.nz/artefact/internal/index.php
 Text to display = 'Profile page - same page', 
 Open link in... = 'Same page'
  f. Internal URL = 
http://http://mahara.rdaymond.wgtn.cat-it.co.nz/artefact/internal/index.php
 Text to display = 'Profile page - new tab/window'
 Open link in... = 'New window'.

  3. At the bottom of the page, enter the text 'End of page' select the
  text and use the tinymce editor to create an anchor tag (3rd option
  line, second to last icon) named 'Page_End'.

  4. Create the following in block link to the 'Page_End' anchor from the top 
of the page:
 URL = #Page_End
 Text to display = 'Link to page end -default None'
 Open link in... = 'None'

  Expected results: When selected, each link should behave as per its displayed 
link text.
  Actual results: all links behave as expected EXCEPT for 2.a.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1875785/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1883031] Re: The cancel link (button) on forms has an odd style once clicked

2020-08-03 Thread Lisa Seeto
** Changed in: mahara/20.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1883031

Title:
  The cancel link (button) on forms has an odd style once clicked

Status in Mahara:
  Fix Committed
Status in Mahara 20.04 series:
  Fix Released
Status in Mahara 20.10 series:
  Fix Committed

Bug description:
  I noticed this issue on adding a Plan form when I clicked (and held
  the click) on the 'cancel' button.

  In 19.10 it used to give a grey background but now it gives a dark
  green background

  It only appears for a split second but I'm not sure if it needs to
  appear at all or if the style needs fixing

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1883031/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1887317] Re: LoadXML error when upgrading from 18.10 to 20.04

2020-08-03 Thread Lisa Seeto
** Changed in: mahara/20.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1887317

Title:
  LoadXML error when upgrading from 18.10 to 20.04

Status in Mahara:
  Fix Committed
Status in Mahara 19.04 series:
  Fix Released
Status in Mahara 19.10 series:
  Fix Released
Status in Mahara 20.04 series:
  Fix Released
Status in Mahara 20.10 series:
  Fix Committed

Bug description:
  There is a malformed xml in artefact description that will produce an
  exception when running upgrades for code to related to following bug

  https://bugs.launchpad.net/mahara/+bug/1826948

  we might need to catch this exception when calling LoadXML during the
  upgrade

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1887317/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1880771] Re: When adjusting group membership via the Engage -> People page the modal doesn't close on submit

2020-08-03 Thread Lisa Seeto
** Changed in: mahara/20.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1880771

Title:
  When adjusting group membership via the Engage -> People page the
  modal doesn't close on submit

Status in Mahara:
  Fix Committed
Status in Mahara 19.04 series:
  Fix Released
Status in Mahara 19.10 series:
  Fix Released
Status in Mahara 20.04 series:
  Fix Released
Status in Mahara 20.10 series:
  Fix Committed

Bug description:
  This is because the js is expecting .modal.in when it actually has
  .modal.show

  To test:
  Make sure you have a site with some users and groups

  Login in as admin and go to Engage -> People
  Click on 'Edit group membership' for a user
  Select a group either in the Add member or Invite parts and click on 'Apply 
changes'

  The modal should close on saving

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1880771/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1884466] Re: The delete_inactive_users cli script can timeout

2020-08-03 Thread Lisa Seeto
** Changed in: mahara/20.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1884466

Title:
  The delete_inactive_users cli script can timeout

Status in Mahara:
  Fix Committed
Status in Mahara 19.04 series:
  Fix Released
Status in Mahara 19.10 series:
  Fix Released
Status in Mahara 20.04 series:
  Fix Released
Status in Mahara 20.10 series:
  Fix Committed

Bug description:
  We need to up the set_time_limit call handle the fact that some users
  have lots of content

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1884466/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1879410] Re: Add a text block in Dashboard page using TestingDataGenerator.php

2020-08-03 Thread Cecilia Vela Gurovic
** Changed in: mahara/19.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1879410

Title:
  Add a text block in Dashboard page using TestingDataGenerator.php

Status in Mahara:
  Fix Committed
Status in Mahara 19.04 series:
  Fix Released
Status in Mahara 19.10 series:
  Fix Released
Status in Mahara 20.04 series:
  Fix Committed
Status in Mahara 20.10 series:
  Fix Committed

Bug description:
  Data generator scripts are used to auto-populate cloud instances
  (Mahara QA sites) with pre-defined test data.

  Modification of the create_block() function of
  TestingDataGenerator.php is required to add a Text block in the
  Dashboard page.

  Test instructions:
  A site created with pre-populated data using the data population script 
should have a Text block in the dashboard page of every people with info like 
group count, group admin count, group member count.

  When logged in as People1 the text block on dashboard will have 
  Group Count:2 Group Admin:2 Group member:0 
  and for People101
  Group Count:2 Group Admin:1 Group member:1

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1879410/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1885231] Re: Class 'Institution' not found when viewing another user's profile page

2020-08-03 Thread Cecilia Vela Gurovic
** Changed in: mahara/19.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1885231

Title:
   Class 'Institution' not found when viewing another user's profile
  page

Status in Mahara:
  Fix Committed
Status in Mahara 19.04 series:
  Fix Released
Status in Mahara 19.10 series:
  Fix Released
Status in Mahara 20.04 series:
  Fix Committed
Status in Mahara 20.10 series:
  Fix Committed

Bug description:
  When we have the following:

  0) Start with a 19.04 site
  1) A site / institution with SE framework enabled
  2) User A creates a collection but does NOT share it
  3) User A adds a 'navigation' block to their profile page and chooses the 
collection
  4) User B logs in and searches up User A goes to the profile page of User A
  - gets error

  The problem here is the navigation block wants to go to function
  get_framework_institution() to work out some info and it fails if
  institution class has not been included

  So we need to make sure institution class is included at the start of
  that function

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1885231/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1882103] Re: Wrong redirect when creating Pages when Mahara is in a subdir

2020-08-03 Thread Cecilia Vela Gurovic
** Changed in: mahara/19.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1882103

Title:
  Wrong redirect when creating Pages when Mahara is in a subdir

Status in Mahara:
  Fix Committed
Status in Mahara 19.04 series:
  Fix Released
Status in Mahara 19.10 series:
  Fix Released
Status in Mahara 20.04 series:
  Fix Committed
Status in Mahara 20.10 series:
  Fix Committed

Bug description:
  Referencing Bug #1843537
  (https://bugs.launchpad.net/mahara/+bug/1843537)

  In Mahara 20.04 this Bug seems to affect the creation of pages.

  When trying to create a new page while Mahara is installed in a
  subdirectory (https://dns/mahara), after saving the newly created page
  it is created successfully but the user is redirected to an error page
  because wwwroot is missing.

  The problem seems to be in:
  mahara/htdocs/view/editlayout.php in Line 441 

  Much like in the CSV Upload error it does not include the root
  directory

  The original:
  redirect('/view/blocks.php?id=' . $view->get('id'));

  Ammended:
  redirect(get_config('wwwroot') . 'view/blocks.php?id=' . $view->get('id'));

  After changing this, the saving progress redirects to the correct
  page.

  
  Greetings from Germany,

  Philippe

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1882103/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1880803] Re: errors when copying a page after editing column widths manually

2020-08-03 Thread Cecilia Vela Gurovic
** Changed in: mahara/19.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1880803

Title:
  errors when copying a page after editing column widths manually

Status in Mahara:
  Fix Committed
Status in Mahara 19.04 series:
  Fix Released
Status in Mahara 19.10 series:
  Fix Released
Status in Mahara 20.04 series:
  Fix Committed
Status in Mahara 20.10 series:
  Fix Committed

Bug description:
  For any version newer than 19.04, follow the steps below and then
  upgrade. It will display the same errors when trying to copy or
  translate the view with the old layout.

  On 19.04

  to replicate:
  - go to User menu-> Preferences -> Settigns
  - set 'Show controls to add and remove columns when editing a page' to yes 
and save
  - create a view
  - set a custom layout e.g. 3 rows with 3 columns and 1 row with 1 column
  - play with the column changing the widths
  - display the page and make a copy and try to edit the view

  the following errors are displayed

  [WAR] 28 (lib/view.php:2994) Undefined offset: 4
  Call stack (most recent first):

  log_message("Undefined offset: 4", 8, true, true, 
"/home/ceciliavg/maharacode/mahara/htdocs/lib/view", 2994) at 
/home/ceciliavg/maharacode/mahara/htdocs/lib/errors.php:520
  error(8, "Undefined offset: 4", 
"/home/ceciliavg/maharacode/mahara/htdocs/lib/view", 2994, array(size 4)) 
at /home/ceciliavg/maharacode/mahara/htdocs/lib/view.php:2994
  View->removerow(array(size 2)) at 
/home/ceciliavg/maharacode/mahara/htdocs/view/editlayout.php:701
  set_view_layout(object(Pieform), array(size 16)) at 
/home/ceciliavg/maharacode/mahara/htdocs/view/editlayout.php:643
  settings_submit(object(Pieform), array(size 16)) at 
/home/ceciliavg/maharacode/mahara/htdocs/lib/pieforms/pieform.php:544
  Pieform->__construct(array(size 5)) at 
/home/ceciliavg/maharacode/mahara/htdocs/lib/pieforms/pieform.php:166
  Pieform::process(array(size 5)) at 
/home/ceciliavg/maharacode/mahara/htdocs/lib/mahara.php:5445
  pieform(array(size 5)) at 
/home/ceciliavg/maharacode/mahara/htdocs/view/editlayout.php:222
  create_settings_pieform() at 
/home/ceciliavg/maharacode/mahara/htdocs/view/editlayout.php:106

  [WAR] 28 (lib/view.php:2994) Undefined offset: 3
  Call stack (most recent first):

  log_message("Undefined offset: 3", 8, true, true, 
"/home/ceciliavg/maharacode/mahara/htdocs/lib/view", 2994) at 
/home/ceciliavg/maharacode/mahara/htdocs/lib/errors.php:520
  error(8, "Undefined offset: 3", 
"/home/ceciliavg/maharacode/mahara/htdocs/lib/view", 2994, array(size 4)) 
at /home/ceciliavg/maharacode/mahara/htdocs/lib/view.php:2994
  View->removerow(array(size 2)) at 
/home/ceciliavg/maharacode/mahara/htdocs/view/editlayout.php:701
  set_view_layout(object(Pieform), array(size 16)) at 
/home/ceciliavg/maharacode/mahara/htdocs/view/editlayout.php:643
  settings_submit(object(Pieform), array(size 16)) at 
/home/ceciliavg/maharacode/mahara/htdocs/lib/pieforms/pieform.php:544
  Pieform->__construct(array(size 5)) at 
/home/ceciliavg/maharacode/mahara/htdocs/lib/pieforms/pieform.php:166
  Pieform::process(array(size 5)) at 
/home/ceciliavg/maharacode/mahara/htdocs/lib/mahara.php:5445
  pieform(array(size 5)) at 
/home/ceciliavg/maharacode/mahara/htdocs/view/editlayout.php:222
  create_settings_pieform() at 
/home/ceciliavg/maharacode/mahara/htdocs/view/editlayout.php:106

  [WAR] 28 (lib/view.php:2994) Undefined offset: 2
  Call stack (most recent first):

  log_message("Undefined offset: 2", 8, true, true, 
"/home/ceciliavg/maharacode/mahara/htdocs/lib/view", 2994) at 
/home/ceciliavg/maharacode/mahara/htdocs/lib/errors.php:520
  error(8, "Undefined offset: 2", 
"/home/ceciliavg/maharacode/mahara/htdocs/lib/view", 2994, array(size 4)) 
at /home/ceciliavg/maharacode/mahara/htdocs/lib/view.php:2994
  View->removerow(array(size 2)) at 
/home/ceciliavg/maharacode/mahara/htdocs/view/editlayout.php:701
  set_view_layout(object(Pieform), array(size 16)) at 
/home/ceciliavg/maharacode/mahara/htdocs/view/editlayout.php:643
  settings_submit(object(Pieform), array(size 16)) at 
/home/ceciliavg/maharacode/mahara/htdocs/lib/pieforms/pieform.php:544
  Pieform->__construct(array(size 5)) at 
/home/ceciliavg/maharacode/mahara/htdocs/lib/pieforms/pieform.php:166
  Pieform::process(array(size 5)) at 
/home/ceciliavg/maharacode/mahara/htdocs/lib/mahara.php:5445
  pieform(array(size 5)) at 
/home/ceciliavg/maharacode/mahara/htdocs/view/editlayout.php:222
  create_settings_pieform() at 
/home/ceciliavg/maharacode/mahara/htdocs/view/editlayout.php:106

To manage notifications about this bug go

[Mahara-contributors] [Bug 1877906] Re: MariaDB error when creating secret URL

2020-08-03 Thread Cecilia Vela Gurovic
** Changed in: mahara/19.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1877906

Title:
  MariaDB error when creating secret URL

Status in Mahara:
  Fix Committed
Status in Mahara 19.10 series:
  Fix Released
Status in Mahara 20.04 series:
  Fix Committed
Status in Mahara 20.10 series:
  Fix Committed

Bug description:
  We have the following error on a site with MariaDB and elascticsearch
  set up if we want to create a new secret URL for a view:

  mysqli error: [1064: You have an error in your SQL syntax; check the manual 
that corresponds to your MariaDB server version for the right syntax to use 
near 'WHERE NOT EXISTS (
  SELECT 1 FROM "search_elasticsearch_q' at line 2] in 
EXECUTE("INSERT INTO "search_elasticsearch_queue" (itemid, type)
  SELECT '1234', 'view' WHERE NOT EXISTS (
  SELECT 1 FROM "search_elasticsearch_queue" WHERE 
itemid = '1234' AND type = 'view'
  )")Command was: INSERT INTO "search_elasticsearch_queue" 
(itemid, type)
  SELECT ?, ? WHERE NOT EXISTS (
  SELECT 1 FROM "search_elasticsearch_queue" WHERE 
itemid = ? AND type = ?
  )

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1877906/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1885784] Re: Need to update site options submit function to use alias

2020-08-03 Thread Cecilia Vela Gurovic
** Changed in: mahara/19.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1885784

Title:
  Need to update site options submit function to use alias

Status in Mahara:
  Fix Committed
Status in Mahara 19.04 series:
  Fix Released
Status in Mahara 19.10 series:
  Fix Released
Status in Mahara 20.04 series:
  Fix Committed
Status in Mahara 20.10 series:
  Fix Committed

Bug description:
  Currently our code base is using a database call with a query that
  contains a term inserted in escaped characters.  It is more robust and
  safer to use an alias rather than rely that variables put into escaped
  quotes will always reliably work.

  The DB query in question is in admin/site/options.php during the
  siteoptions_submit().

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1885784/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1883471] Re: reduce block margin on gridstack

2020-08-03 Thread Cecilia Vela Gurovic
** Changed in: mahara/19.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1883471

Title:
  reduce block margin on gridstack

Status in Mahara:
  Fix Committed
Status in Mahara 19.10 series:
  Fix Released
Status in Mahara 20.04 series:
  Fix Committed
Status in Mahara 20.10 series:
  Fix Committed

Bug description:
  There is too much bottom margin on the blocks when they are in display mode.
  This could be due to the margin of the resize handlers we have on edit mode 
(check image attached), where we set the block size. There is no need for this 
margin on display since we don't have the handlers there

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1883471/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1883043] Re: collection pages unvailable as link options in tinyMCE

2020-08-03 Thread Cecilia Vela Gurovic
** Changed in: mahara/19.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1883043

Title:
  collection pages unvailable as link options in tinyMCE

Status in Mahara:
  Fix Committed
Status in Mahara 19.10 series:
  Fix Released
Status in Mahara 20.04 series:
  Fix Committed
Status in Mahara 20.10 series:
  Fix Committed

Bug description:
  When inserting a link using the tinyMCE editor the drop down for "Link
  List" options should display all pages including pages in a
  collection.  This functionality existing in 19.04 (see attached screen
  shot 'tinyMCE-collections.png') but had changed in 19.10 and now no
  longer offers the option.  It should return to its previous function.

  Affects Mahara 19.10, 20.04.

  To test:
  1. On 19.04, create a collection (1 page is fine) and a portfolio page.
  2. Edit the portfolio page and select a text block. In the tinyMCE editor 
select to insert a link and in the pop-up box, select the drop-down for "Link 
List".
  3. See that the link list options contain the collection page(s)
  4. Upgrade to 19.10 and perform, edit the portfolio page and click to accept 
the grid stack transformation
  5. Edit the text block and select to insert a link, select the drop-down for 
"Link List"
  Expected results:
  All pages including the collection->pages display
  Actual results:
  The collection pages are not included.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1883043/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1877001] Re: Skins not showing after upgrade

2020-08-03 Thread Cecilia Vela Gurovic
** Changed in: mahara/19.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1877001

Title:
  Skins not showing after upgrade

Status in Mahara:
  Fix Committed
Status in Mahara 19.10 series:
  Fix Released
Status in Mahara 20.04 series:
  Fix Committed
Status in Mahara 20.10 series:
  Fix Committed

Bug description:
  When upgrading from an older site to 19.10+ site the skins stop
  showing on pages

  and there are error messages in the logs regarding this

  * error(8, "Undefined index: view_block_header_font",
  "/var/www/skin/style.php", 82, array(size 68)) at
  /var/www/skin/style.php:82

  We need an upgrade step to add in blank values for the 2 new fields

  view_block_header_font
  view_block_header_font_color

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1877001/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1879847] Re: String missing for allow public views in Reports

2020-08-03 Thread Cecilia Vela Gurovic
** Changed in: mahara/19.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1879847

Title:
  String missing for allow public views in Reports

Status in Mahara:
  Fix Committed
Status in Mahara 19.04 series:
  Fix Released
Status in Mahara 19.10 series:
  Fix Released
Status in Mahara 20.04 series:
  Fix Committed
Status in Mahara 20.10 series:
  Fix Committed

Bug description:
  There is a what looks like a missing string when making a report that shows 
"Content".
  The missing string shows up as: [[allowpublicviews/statistics]] on the page.

  Repo steps:
  - Log in as site admin and go to Admin menu -> Reports
  - Select to 'Configure Report' to open the "Report Configuration" modal.
  - In the 'Report type' drop down select 'Content' the save.
  Expected results:
  - Text displays correctly
  Actual results:
  - [[allowpublicviews/statistics]] appears in column.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1879847/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1884466] Re: The delete_inactive_users cli script can timeout

2020-08-03 Thread Cecilia Vela Gurovic
** Changed in: mahara/19.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1884466

Title:
  The delete_inactive_users cli script can timeout

Status in Mahara:
  Fix Committed
Status in Mahara 19.04 series:
  Fix Released
Status in Mahara 19.10 series:
  Fix Released
Status in Mahara 20.04 series:
  Fix Committed
Status in Mahara 20.10 series:
  Fix Committed

Bug description:
  We need to up the set_time_limit call handle the fact that some users
  have lots of content

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1884466/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1880771] Re: When adjusting group membership via the Engage -> People page the modal doesn't close on submit

2020-08-03 Thread Cecilia Vela Gurovic
** Changed in: mahara/19.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1880771

Title:
  When adjusting group membership via the Engage -> People page the
  modal doesn't close on submit

Status in Mahara:
  Fix Committed
Status in Mahara 19.04 series:
  Fix Released
Status in Mahara 19.10 series:
  Fix Released
Status in Mahara 20.04 series:
  Fix Committed
Status in Mahara 20.10 series:
  Fix Committed

Bug description:
  This is because the js is expecting .modal.in when it actually has
  .modal.show

  To test:
  Make sure you have a site with some users and groups

  Login in as admin and go to Engage -> People
  Click on 'Edit group membership' for a user
  Select a group either in the Add member or Invite parts and click on 'Apply 
changes'

  The modal should close on saving

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1880771/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1887317] Re: LoadXML error when upgrading from 18.10 to 20.04

2020-08-03 Thread Cecilia Vela Gurovic
** Changed in: mahara/19.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1887317

Title:
  LoadXML error when upgrading from 18.10 to 20.04

Status in Mahara:
  Fix Committed
Status in Mahara 19.04 series:
  Fix Released
Status in Mahara 19.10 series:
  Fix Released
Status in Mahara 20.04 series:
  Fix Committed
Status in Mahara 20.10 series:
  Fix Committed

Bug description:
  There is a malformed xml in artefact description that will produce an
  exception when running upgrades for code to related to following bug

  https://bugs.launchpad.net/mahara/+bug/1826948

  we might need to catch this exception when calling LoadXML during the
  upgrade

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1887317/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1875958] Re: 'My groups' sidebar can get very long if you are in lots of groups

2020-08-03 Thread Cecilia Vela Gurovic
** Changed in: mahara/19.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1875958

Title:
  'My groups' sidebar can get very long if you are in lots of groups

Status in Mahara:
  Fix Committed
Status in Mahara 19.04 series:
  Fix Released
Status in Mahara 19.10 series:
  Fix Released
Status in Mahara 20.04 series:
  Fix Committed
Status in Mahara 20.10 series:
  Fix Committed

Bug description:
  When you are a member of many groups the list in the sidebar can get
  very long

  There is an account preference to restrict the list to 'Maximum number
  of groups to display'

  And now there is an account preference to restrict it to certain group
  labels

  But both these options require user making choices / setting up labels

  Another option to make the 'My groups' side bar a little more
  manageable is via css

  This option still lets you scroll to see all your groups but doesn't
  make the page overly long.

  Note: (25 May - after Robert questioned about how many groups should
  display before the scroll bar is displayed): apparently the 'My
  groups' sidebar should be 400px high maximum (or a scroll bar will be
  displayed). When browser View set at 100% this equates to
  approximately 14 lines(Chrome, Firefox & Edge), this number will vary
  depending upon the browser View setting +100-.  The number of groups
  shown before scrolling is also variable due to how many groups the
  person is admin for (2 lines) versus not admin for (1 line).  The
  length of the group name will also impact how many lines are taken per
  group.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1875958/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1875785] Re: External links in Mahara no longer open in external tab/window by default

2020-08-03 Thread Cecilia Vela Gurovic
** Changed in: mahara/19.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1875785

Title:
  External links in Mahara no longer open in external tab/window by
  default

Status in Mahara:
  Fix Committed
Status in Mahara 19.10 series:
  Fix Released
Status in Mahara 20.04 series:
  Fix Committed
Status in Mahara 20.10 series:
  Fix Committed

Bug description:
  Code: Release 2020.04_RC2
  Browser/s: Chrome & Firefox
  Theme: Raw

  Summary: The functionality for related bug ​#1802205 'Make all
  external links in Mahara open in external tab/window by default' no
  longer works.

  Steps:

  As logged in PersonA:
  1. Create a new page with a text block on it that has a few/5 paragraphs of 
text.

  2. Use the tinymce editor to add the following links before the text 
paragraphs using the Insert/Edit Link modal:
  a. External URL = https://www.catalyst.net.nz/ 
 Text to display = 'Catalyst default-None, new tab/window'
 Open link in... = 'None'
  b. External URL = https://www.catalyst.net.nz/ 
 Text to display = 'Catalyst -same page'
 Open link in... = 'Same page'
  c. External URL display = https://www.catalyst.net.nz/ 
 Text to display = 'Catalyst -new tab/window'
 Open link in... = 'New window'
  d. Internal URL = 
http://http://mahara.rdaymond.wgtn.cat-it.co.nz/artefact/internal/index.php 
 Text to display = 'Profile page default-None, same tab/window'
 Open link in... = 'None'
  e. Internal URL = 
http://http://mahara.rdaymond.wgtn.cat-it.co.nz/artefact/internal/index.php
 Text to display = 'Profile page - same page', 
 Open link in... = 'Same page'
  f. Internal URL = 
http://http://mahara.rdaymond.wgtn.cat-it.co.nz/artefact/internal/index.php
 Text to display = 'Profile page - new tab/window'
 Open link in... = 'New window'.

  3. At the bottom of the page, enter the text 'End of page' select the
  text and use the tinymce editor to create an anchor tag (3rd option
  line, second to last icon) named 'Page_End'.

  4. Create the following in block link to the 'Page_End' anchor from the top 
of the page:
 URL = #Page_End
 Text to display = 'Link to page end -default None'
 Open link in... = 'None'

  Expected results: When selected, each link should behave as per its displayed 
link text.
  Actual results: all links behave as expected EXCEPT for 2.a.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1875785/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1876625] Re: Date picker not working for Admin -> People when selecting a date to filter users

2020-08-03 Thread Cecilia Vela Gurovic
** Changed in: mahara/19.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1876625

Title:
  Date picker not working for Admin -> People when selecting a date to
  filter users

Status in Mahara:
  Fix Committed
Status in Mahara 19.04 series:
  Fix Released
Status in Mahara 19.10 series:
  Fix Released
Status in Mahara 20.04 series:
  Fix Committed
Status in Mahara 20.10 series:
  Fix Committed

Bug description:
  To test:

  Go to Admin -> People -> Search Users
  Click on Advanced options and select 'People have not logged since' from the 
'Last login' dropdown

  The results should change

  Note: for good testing you will need to update some users to have varying 
'lastlogin' values 
  - you can do this by going, eg:
   UPDATE usr SET lastlogin = '2020-01-01 12:12:12' WHERE id = 2;
   UPDATE usr SET lastlogin = '2020-02-02 12:12:12' WHERE id = 3;
  etc

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1876625/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1889485] Re: Security Upgrade SimpleSAML 1.18.4 to 1.18.7

2020-08-03 Thread Cecilia Vela Gurovic
** Changed in: mahara/19.10
   Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1889485

Title:
  Security Upgrade SimpleSAML 1.18.4 to 1.18.7

Status in Mahara:
  Fix Committed
Status in Mahara 19.04 series:
  Fix Released
Status in Mahara 19.10 series:
  Fix Released
Status in Mahara 20.04 series:
  In Progress
Status in Mahara 20.10 series:
  Fix Committed

Bug description:
  From https://simplesamlphp.org/security/202004-01:

  Date
  April 03, 2020
  Affected versions
  SimpleSAMLphp 1.18.5 and older
  Severity
  Low

  Background

  The module controller in SimpleSAML\Module that processes requests for pages 
hosted by modules, has code to identify paths ending with .php and process 
those as PHP code. If no other suitable way of handling the given path exists 
it presents the file to the browser.
  Description

  The check to identify paths ending with .php does not account for uppercase 
letters. If someone requests a path ending with e.g. .PHP and the server is 
serving the code from a case-insensitive file system, such as on Windows, the 
processing of the PHP code does not occur, and the source code is instead 
presented to the browser.
  Affected versions

  SimpleSAMLphp versions 1.18.5 and older.

  We will upgrade to version 1.18.7

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1889485/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1889485] A change has been merged

2020-08-03 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/11105
Committed: 
https://git.mahara.org/mahara/mahara/commit/139c185edac29ceeb4e64f855bf483a6e32723ee
Submitter: Cecilia Vela Gurovic (cecili...@catalyst.net.nz)
Branch:19.10_STABLE

commit 139c185edac29ceeb4e64f855bf483a6e32723ee
Author: Lisa Seeto 
Date:   Thu Jul 30 11:39:35 2020 +1200

Bug 1889485: Security Upgrade SimpleSAML 1.18.4 to 1.18.7

- upgrade to version 1.18.7

Change-Id: I4e7ca4de32a4c69224c184013c15f92069cc97ff
Signed-off-by: Lisa Seeto 

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1889485

Title:
  Security Upgrade SimpleSAML 1.18.4 to 1.18.7

Status in Mahara:
  Fix Committed
Status in Mahara 19.04 series:
  Fix Released
Status in Mahara 19.10 series:
  In Progress
Status in Mahara 20.04 series:
  In Progress
Status in Mahara 20.10 series:
  Fix Committed

Bug description:
  From https://simplesamlphp.org/security/202004-01:

  Date
  April 03, 2020
  Affected versions
  SimpleSAMLphp 1.18.5 and older
  Severity
  Low

  Background

  The module controller in SimpleSAML\Module that processes requests for pages 
hosted by modules, has code to identify paths ending with .php and process 
those as PHP code. If no other suitable way of handling the given path exists 
it presents the file to the browser.
  Description

  The check to identify paths ending with .php does not account for uppercase 
letters. If someone requests a path ending with e.g. .PHP and the server is 
serving the code from a case-insensitive file system, such as on Windows, the 
processing of the PHP code does not occur, and the source code is instead 
presented to the browser.
  Affected versions

  SimpleSAMLphp versions 1.18.5 and older.

  We will upgrade to version 1.18.7

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1889485/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1890225] [NEW] Replace oauth-php library with PHPs OAuth or similar

2020-08-03 Thread Rebecca Blundell
Public bug reported:

In Webservices we currently have this library (from the README.Mahara):

Website: https://code.google.com/archive/p/oauth-php/
Version: 175
Notes: This package is not maintained and was last updated in 2010
   This library is used to provide the OAuth 1.x server side processing.

We should replace with an oauth2 php library https://oauth.net/code/php/
or checkout what Moodle do.

This needs some investigation to see how it's currently being used and
what an equivalent and up-to-date replacement would be.

** Affects: mahara
 Importance: Undecided
 Status: New

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1890225

Title:
  Replace oauth-php library with PHPs OAuth or similar

Status in Mahara:
  New

Bug description:
  In Webservices we currently have this library (from the
  README.Mahara):

  Website: https://code.google.com/archive/p/oauth-php/
  Version: 175
  Notes: This package is not maintained and was last updated in 2010
 This library is used to provide the OAuth 1.x server side processing.

  We should replace with an oauth2 php library
  https://oauth.net/code/php/ or checkout what Moodle do.

  This needs some investigation to see how it's currently being used and
  what an equivalent and up-to-date replacement would be.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1890225/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1889485] A change has been merged

2020-08-03 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/11104
Committed: 
https://git.mahara.org/mahara/mahara/commit/56d1f7ee448c7bdee82d0779b268258b7d76e4cb
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:20.04_STABLE

commit 56d1f7ee448c7bdee82d0779b268258b7d76e4cb
Author: Lisa Seeto 
Date:   Thu Jul 30 11:39:35 2020 +1200

Bug 1889485: Security Upgrade SimpleSAML 1.18.4 to 1.18.7

- upgrade to version 1.18.7

Change-Id: I4e7ca4de32a4c69224c184013c15f92069cc97ff
Signed-off-by: Lisa Seeto 

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1889485

Title:
  Security Upgrade SimpleSAML 1.18.4 to 1.18.7

Status in Mahara:
  Fix Committed
Status in Mahara 19.04 series:
  Fix Released
Status in Mahara 19.10 series:
  In Progress
Status in Mahara 20.04 series:
  In Progress
Status in Mahara 20.10 series:
  Fix Committed

Bug description:
  From https://simplesamlphp.org/security/202004-01:

  Date
  April 03, 2020
  Affected versions
  SimpleSAMLphp 1.18.5 and older
  Severity
  Low

  Background

  The module controller in SimpleSAML\Module that processes requests for pages 
hosted by modules, has code to identify paths ending with .php and process 
those as PHP code. If no other suitable way of handling the given path exists 
it presents the file to the browser.
  Description

  The check to identify paths ending with .php does not account for uppercase 
letters. If someone requests a path ending with e.g. .PHP and the server is 
serving the code from a case-insensitive file system, such as on Windows, the 
processing of the PHP code does not occur, and the source code is instead 
presented to the browser.
  Affected versions

  SimpleSAMLphp versions 1.18.5 and older.

  We will upgrade to version 1.18.7

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1889485/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1890218] [NEW] Plugin jQuery UI touchpunch no longer maintained

2020-08-03 Thread Rebecca Blundell
Public bug reported:

>From the github page:
jQuery UI Touch Punch is a small hack that enables the use of touch events on 
sites using the jQuery UI user interface library.
https://github.com/furf/jquery-ui-touch-punch

Touch Punch works by using simulated events to map touch events to their
mouse event analogs.

This library was last updated in 2014. Given the proliferation of touch
devices since then it seems maybe it might have been superseded? Or
maybe we don't need it anymore? We should investigate whether we need
this old library still.

** Affects: mahara
 Importance: Undecided
 Status: New

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1890218

Title:
  Plugin jQuery UI touchpunch no longer maintained

Status in Mahara:
  New

Bug description:
  From the github page:
  jQuery UI Touch Punch is a small hack that enables the use of touch events on 
sites using the jQuery UI user interface library.
  https://github.com/furf/jquery-ui-touch-punch

  Touch Punch works by using simulated events to map touch events to
  their mouse event analogs.

  This library was last updated in 2014. Given the proliferation of
  touch devices since then it seems maybe it might have been superseded?
  Or maybe we don't need it anymore? We should investigate whether we
  need this old library still.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1890218/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1875958] Re: 'My groups' sidebar can get very long if you are in lots of groups

2020-08-03 Thread Robert Lyon
** Changed in: mahara/19.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1875958

Title:
  'My groups' sidebar can get very long if you are in lots of groups

Status in Mahara:
  Fix Committed
Status in Mahara 19.04 series:
  Fix Released
Status in Mahara 19.10 series:
  Fix Committed
Status in Mahara 20.04 series:
  Fix Committed
Status in Mahara 20.10 series:
  Fix Committed

Bug description:
  When you are a member of many groups the list in the sidebar can get
  very long

  There is an account preference to restrict the list to 'Maximum number
  of groups to display'

  And now there is an account preference to restrict it to certain group
  labels

  But both these options require user making choices / setting up labels

  Another option to make the 'My groups' side bar a little more
  manageable is via css

  This option still lets you scroll to see all your groups but doesn't
  make the page overly long.

  Note: (25 May - after Robert questioned about how many groups should
  display before the scroll bar is displayed): apparently the 'My
  groups' sidebar should be 400px high maximum (or a scroll bar will be
  displayed). When browser View set at 100% this equates to
  approximately 14 lines(Chrome, Firefox & Edge), this number will vary
  depending upon the browser View setting +100-.  The number of groups
  shown before scrolling is also variable due to how many groups the
  person is admin for (2 lines) versus not admin for (1 line).  The
  length of the group name will also impact how many lines are taken per
  group.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1875958/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1876625] Re: Date picker not working for Admin -> People when selecting a date to filter users

2020-08-03 Thread Robert Lyon
** Changed in: mahara/19.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1876625

Title:
  Date picker not working for Admin -> People when selecting a date to
  filter users

Status in Mahara:
  Fix Committed
Status in Mahara 19.04 series:
  Fix Released
Status in Mahara 19.10 series:
  Fix Committed
Status in Mahara 20.04 series:
  Fix Committed
Status in Mahara 20.10 series:
  Fix Committed

Bug description:
  To test:

  Go to Admin -> People -> Search Users
  Click on Advanced options and select 'People have not logged since' from the 
'Last login' dropdown

  The results should change

  Note: for good testing you will need to update some users to have varying 
'lastlogin' values 
  - you can do this by going, eg:
   UPDATE usr SET lastlogin = '2020-01-01 12:12:12' WHERE id = 2;
   UPDATE usr SET lastlogin = '2020-02-02 12:12:12' WHERE id = 3;
  etc

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1876625/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1880771] Re: When adjusting group membership via the Engage -> People page the modal doesn't close on submit

2020-08-03 Thread Robert Lyon
** Changed in: mahara/19.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1880771

Title:
  When adjusting group membership via the Engage -> People page the
  modal doesn't close on submit

Status in Mahara:
  Fix Committed
Status in Mahara 19.04 series:
  Fix Released
Status in Mahara 19.10 series:
  Fix Committed
Status in Mahara 20.04 series:
  Fix Committed
Status in Mahara 20.10 series:
  Fix Committed

Bug description:
  This is because the js is expecting .modal.in when it actually has
  .modal.show

  To test:
  Make sure you have a site with some users and groups

  Login in as admin and go to Engage -> People
  Click on 'Edit group membership' for a user
  Select a group either in the Add member or Invite parts and click on 'Apply 
changes'

  The modal should close on saving

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1880771/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1889485] Re: Security Upgrade SimpleSAML 1.18.4 to 1.18.7

2020-08-03 Thread Robert Lyon
** Changed in: mahara/19.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1889485

Title:
  Security Upgrade SimpleSAML 1.18.4 to 1.18.7

Status in Mahara:
  Fix Committed
Status in Mahara 19.04 series:
  Fix Released
Status in Mahara 19.10 series:
  In Progress
Status in Mahara 20.04 series:
  In Progress
Status in Mahara 20.10 series:
  Fix Committed

Bug description:
  From https://simplesamlphp.org/security/202004-01:

  Date
  April 03, 2020
  Affected versions
  SimpleSAMLphp 1.18.5 and older
  Severity
  Low

  Background

  The module controller in SimpleSAML\Module that processes requests for pages 
hosted by modules, has code to identify paths ending with .php and process 
those as PHP code. If no other suitable way of handling the given path exists 
it presents the file to the browser.
  Description

  The check to identify paths ending with .php does not account for uppercase 
letters. If someone requests a path ending with e.g. .PHP and the server is 
serving the code from a case-insensitive file system, such as on Windows, the 
processing of the PHP code does not occur, and the source code is instead 
presented to the browser.
  Affected versions

  SimpleSAMLphp versions 1.18.5 and older.

  We will upgrade to version 1.18.7

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1889485/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1880803] Re: errors when copying a page after editing column widths manually

2020-08-03 Thread Robert Lyon
** Changed in: mahara/19.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1880803

Title:
  errors when copying a page after editing column widths manually

Status in Mahara:
  Fix Committed
Status in Mahara 19.04 series:
  Fix Released
Status in Mahara 19.10 series:
  Fix Committed
Status in Mahara 20.04 series:
  Fix Committed
Status in Mahara 20.10 series:
  Fix Committed

Bug description:
  For any version newer than 19.04, follow the steps below and then
  upgrade. It will display the same errors when trying to copy or
  translate the view with the old layout.

  On 19.04

  to replicate:
  - go to User menu-> Preferences -> Settigns
  - set 'Show controls to add and remove columns when editing a page' to yes 
and save
  - create a view
  - set a custom layout e.g. 3 rows with 3 columns and 1 row with 1 column
  - play with the column changing the widths
  - display the page and make a copy and try to edit the view

  the following errors are displayed

  [WAR] 28 (lib/view.php:2994) Undefined offset: 4
  Call stack (most recent first):

  log_message("Undefined offset: 4", 8, true, true, 
"/home/ceciliavg/maharacode/mahara/htdocs/lib/view", 2994) at 
/home/ceciliavg/maharacode/mahara/htdocs/lib/errors.php:520
  error(8, "Undefined offset: 4", 
"/home/ceciliavg/maharacode/mahara/htdocs/lib/view", 2994, array(size 4)) 
at /home/ceciliavg/maharacode/mahara/htdocs/lib/view.php:2994
  View->removerow(array(size 2)) at 
/home/ceciliavg/maharacode/mahara/htdocs/view/editlayout.php:701
  set_view_layout(object(Pieform), array(size 16)) at 
/home/ceciliavg/maharacode/mahara/htdocs/view/editlayout.php:643
  settings_submit(object(Pieform), array(size 16)) at 
/home/ceciliavg/maharacode/mahara/htdocs/lib/pieforms/pieform.php:544
  Pieform->__construct(array(size 5)) at 
/home/ceciliavg/maharacode/mahara/htdocs/lib/pieforms/pieform.php:166
  Pieform::process(array(size 5)) at 
/home/ceciliavg/maharacode/mahara/htdocs/lib/mahara.php:5445
  pieform(array(size 5)) at 
/home/ceciliavg/maharacode/mahara/htdocs/view/editlayout.php:222
  create_settings_pieform() at 
/home/ceciliavg/maharacode/mahara/htdocs/view/editlayout.php:106

  [WAR] 28 (lib/view.php:2994) Undefined offset: 3
  Call stack (most recent first):

  log_message("Undefined offset: 3", 8, true, true, 
"/home/ceciliavg/maharacode/mahara/htdocs/lib/view", 2994) at 
/home/ceciliavg/maharacode/mahara/htdocs/lib/errors.php:520
  error(8, "Undefined offset: 3", 
"/home/ceciliavg/maharacode/mahara/htdocs/lib/view", 2994, array(size 4)) 
at /home/ceciliavg/maharacode/mahara/htdocs/lib/view.php:2994
  View->removerow(array(size 2)) at 
/home/ceciliavg/maharacode/mahara/htdocs/view/editlayout.php:701
  set_view_layout(object(Pieform), array(size 16)) at 
/home/ceciliavg/maharacode/mahara/htdocs/view/editlayout.php:643
  settings_submit(object(Pieform), array(size 16)) at 
/home/ceciliavg/maharacode/mahara/htdocs/lib/pieforms/pieform.php:544
  Pieform->__construct(array(size 5)) at 
/home/ceciliavg/maharacode/mahara/htdocs/lib/pieforms/pieform.php:166
  Pieform::process(array(size 5)) at 
/home/ceciliavg/maharacode/mahara/htdocs/lib/mahara.php:5445
  pieform(array(size 5)) at 
/home/ceciliavg/maharacode/mahara/htdocs/view/editlayout.php:222
  create_settings_pieform() at 
/home/ceciliavg/maharacode/mahara/htdocs/view/editlayout.php:106

  [WAR] 28 (lib/view.php:2994) Undefined offset: 2
  Call stack (most recent first):

  log_message("Undefined offset: 2", 8, true, true, 
"/home/ceciliavg/maharacode/mahara/htdocs/lib/view", 2994) at 
/home/ceciliavg/maharacode/mahara/htdocs/lib/errors.php:520
  error(8, "Undefined offset: 2", 
"/home/ceciliavg/maharacode/mahara/htdocs/lib/view", 2994, array(size 4)) 
at /home/ceciliavg/maharacode/mahara/htdocs/lib/view.php:2994
  View->removerow(array(size 2)) at 
/home/ceciliavg/maharacode/mahara/htdocs/view/editlayout.php:701
  set_view_layout(object(Pieform), array(size 16)) at 
/home/ceciliavg/maharacode/mahara/htdocs/view/editlayout.php:643
  settings_submit(object(Pieform), array(size 16)) at 
/home/ceciliavg/maharacode/mahara/htdocs/lib/pieforms/pieform.php:544
  Pieform->__construct(array(size 5)) at 
/home/ceciliavg/maharacode/mahara/htdocs/lib/pieforms/pieform.php:166
  Pieform::process(array(size 5)) at 
/home/ceciliavg/maharacode/mahara/htdocs/lib/mahara.php:5445
  pieform(array(size 5)) at 
/home/ceciliavg/maharacode/mahara/htdocs/view/editlayout.php:222
  create_settings_pieform() at 
/home/ceciliavg/maharacode/mahara/htdocs/view/editlayout.php:106

To manage notifications about this bug g

[Mahara-contributors] [Bug 1879847] Re: String missing for allow public views in Reports

2020-08-03 Thread Robert Lyon
** Changed in: mahara/19.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1879847

Title:
  String missing for allow public views in Reports

Status in Mahara:
  Fix Committed
Status in Mahara 19.04 series:
  Fix Released
Status in Mahara 19.10 series:
  Fix Committed
Status in Mahara 20.04 series:
  Fix Committed
Status in Mahara 20.10 series:
  Fix Committed

Bug description:
  There is a what looks like a missing string when making a report that shows 
"Content".
  The missing string shows up as: [[allowpublicviews/statistics]] on the page.

  Repo steps:
  - Log in as site admin and go to Admin menu -> Reports
  - Select to 'Configure Report' to open the "Report Configuration" modal.
  - In the 'Report type' drop down select 'Content' the save.
  Expected results:
  - Text displays correctly
  Actual results:
  - [[allowpublicviews/statistics]] appears in column.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1879847/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1885231] Re: Class 'Institution' not found when viewing another user's profile page

2020-08-03 Thread Robert Lyon
** Changed in: mahara/19.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1885231

Title:
   Class 'Institution' not found when viewing another user's profile
  page

Status in Mahara:
  Fix Committed
Status in Mahara 19.04 series:
  Fix Released
Status in Mahara 19.10 series:
  Fix Committed
Status in Mahara 20.04 series:
  Fix Committed
Status in Mahara 20.10 series:
  Fix Committed

Bug description:
  When we have the following:

  0) Start with a 19.04 site
  1) A site / institution with SE framework enabled
  2) User A creates a collection but does NOT share it
  3) User A adds a 'navigation' block to their profile page and chooses the 
collection
  4) User B logs in and searches up User A goes to the profile page of User A
  - gets error

  The problem here is the navigation block wants to go to function
  get_framework_institution() to work out some info and it fails if
  institution class has not been included

  So we need to make sure institution class is included at the start of
  that function

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1885231/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1887317] Re: LoadXML error when upgrading from 18.10 to 20.04

2020-08-03 Thread Robert Lyon
** Changed in: mahara/19.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1887317

Title:
  LoadXML error when upgrading from 18.10 to 20.04

Status in Mahara:
  Fix Committed
Status in Mahara 19.04 series:
  Fix Released
Status in Mahara 19.10 series:
  Fix Committed
Status in Mahara 20.04 series:
  Fix Committed
Status in Mahara 20.10 series:
  Fix Committed

Bug description:
  There is a malformed xml in artefact description that will produce an
  exception when running upgrades for code to related to following bug

  https://bugs.launchpad.net/mahara/+bug/1826948

  we might need to catch this exception when calling LoadXML during the
  upgrade

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1887317/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1882103] Re: Wrong redirect when creating Pages when Mahara is in a subdir

2020-08-03 Thread Robert Lyon
** Changed in: mahara/19.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1882103

Title:
  Wrong redirect when creating Pages when Mahara is in a subdir

Status in Mahara:
  Fix Committed
Status in Mahara 19.04 series:
  Fix Released
Status in Mahara 19.10 series:
  Fix Committed
Status in Mahara 20.04 series:
  Fix Committed
Status in Mahara 20.10 series:
  Fix Committed

Bug description:
  Referencing Bug #1843537
  (https://bugs.launchpad.net/mahara/+bug/1843537)

  In Mahara 20.04 this Bug seems to affect the creation of pages.

  When trying to create a new page while Mahara is installed in a
  subdirectory (https://dns/mahara), after saving the newly created page
  it is created successfully but the user is redirected to an error page
  because wwwroot is missing.

  The problem seems to be in:
  mahara/htdocs/view/editlayout.php in Line 441 

  Much like in the CSV Upload error it does not include the root
  directory

  The original:
  redirect('/view/blocks.php?id=' . $view->get('id'));

  Ammended:
  redirect(get_config('wwwroot') . 'view/blocks.php?id=' . $view->get('id'));

  After changing this, the saving progress redirects to the correct
  page.

  
  Greetings from Germany,

  Philippe

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1882103/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1879410] Re: Add a text block in Dashboard page using TestingDataGenerator.php

2020-08-03 Thread Robert Lyon
** Changed in: mahara/19.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1879410

Title:
  Add a text block in Dashboard page using TestingDataGenerator.php

Status in Mahara:
  Fix Committed
Status in Mahara 19.04 series:
  Fix Released
Status in Mahara 19.10 series:
  Fix Committed
Status in Mahara 20.04 series:
  Fix Committed
Status in Mahara 20.10 series:
  Fix Committed

Bug description:
  Data generator scripts are used to auto-populate cloud instances
  (Mahara QA sites) with pre-defined test data.

  Modification of the create_block() function of
  TestingDataGenerator.php is required to add a Text block in the
  Dashboard page.

  Test instructions:
  A site created with pre-populated data using the data population script 
should have a Text block in the dashboard page of every people with info like 
group count, group admin count, group member count.

  When logged in as People1 the text block on dashboard will have 
  Group Count:2 Group Admin:2 Group member:0 
  and for People101
  Group Count:2 Group Admin:1 Group member:1

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1879410/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1884466] Re: The delete_inactive_users cli script can timeout

2020-08-03 Thread Robert Lyon
** Changed in: mahara/19.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1884466

Title:
  The delete_inactive_users cli script can timeout

Status in Mahara:
  Fix Committed
Status in Mahara 19.04 series:
  Fix Released
Status in Mahara 19.10 series:
  Fix Committed
Status in Mahara 20.04 series:
  Fix Committed
Status in Mahara 20.10 series:
  Fix Committed

Bug description:
  We need to up the set_time_limit call handle the fact that some users
  have lots of content

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1884466/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1885784] Re: Need to update site options submit function to use alias

2020-08-03 Thread Robert Lyon
** Changed in: mahara/19.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1885784

Title:
  Need to update site options submit function to use alias

Status in Mahara:
  Fix Committed
Status in Mahara 19.04 series:
  Fix Released
Status in Mahara 19.10 series:
  Fix Committed
Status in Mahara 20.04 series:
  Fix Committed
Status in Mahara 20.10 series:
  Fix Committed

Bug description:
  Currently our code base is using a database call with a query that
  contains a term inserted in escaped characters.  It is more robust and
  safer to use an alias rather than rely that variables put into escaped
  quotes will always reliably work.

  The DB query in question is in admin/site/options.php during the
  siteoptions_submit().

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1885784/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1890217] [NEW] Replace unmaintained Dwoo templating engine

2020-08-03 Thread Rebecca Blundell
Public bug reported:

The Dwoo templating engine, which we use to process all our Smarty
templates is no longer maintained. The website has been taken down and
the Github project is archived: https://github.com/dwoo-project/dwoo

This may start to cause problems for us as PHP moves on and Dwoo does
not keep up with the new code. Currently it has been unmaintained since
2018. It looks like Dwoo was developed to make Smarty faster, but
perhaps it is no longer faster. Smarty is at least patched for the
latest PHP versions.

We need to investigate what to do next in order to not be relying on an
unmaintained library for all our templating. We can probably patch it
ourselves for a limited time, but will need to move on from Dwoo.

** Affects: mahara
 Importance: Undecided
 Status: New

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1890217

Title:
  Replace unmaintained Dwoo templating engine

Status in Mahara:
  New

Bug description:
  The Dwoo templating engine, which we use to process all our Smarty
  templates is no longer maintained. The website has been taken down and
  the Github project is archived: https://github.com/dwoo-project/dwoo

  This may start to cause problems for us as PHP moves on and Dwoo does
  not keep up with the new code. Currently it has been unmaintained
  since 2018. It looks like Dwoo was developed to make Smarty faster,
  but perhaps it is no longer faster. Smarty is at least patched for the
  latest PHP versions.

  We need to investigate what to do next in order to not be relying on
  an unmaintained library for all our templating. We can probably patch
  it ourselves for a limited time, but will need to move on from Dwoo.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1890217/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1890214] [NEW] SE framework editor re-creating DB records when not needed

2020-08-03 Thread Cecilia Vela Gurovic
Public bug reported:

On the SmartEvidence framework editor when new information that is not
saved to the DB is added, the javascript form will not have the DB
record ids for this data.

The framework.json.php file is responsible for saving the framework to the DB. 
The way the algorithm works, it will check if the data from the js form 
contains the DB ids (uids in the form).
If there are records on the DB that are not present in the js form data, then 
these are DB records that need to be removed because they have been deleted in 
the js form.
If there are fields with no uids, then this is new data that needs to be saved.

So if we are adding new standards or elements and save the form, unless  we 
find a way to add the DB ids of the newly created records to the js form, 
everytime the form is saved it will delete the records and add new ones with 
same data.
This stops happening for existing records when we reload the page, but will 
happen again for new data.

To test this:
- create a new framework with name 'New framework' and save
- go into the DB and run the query to get the id
select id, name from framework where name='New framework'
- on the DB run the query to check the standards and elements
select s.id sid, s.shortname,
e.id eid, e.shortname, e.parent from
framework_standard s left join
framework_standard_element e
on e.standard=s.id
where s.framework= order by eid;
- go to the site and without reloading the page or making any changes, save the 
form again
- on the DB, run the query to get the standards and elements again
- compare the columns 'sid' and 'eid'

expected result: they should be the same for both results
actual result: the sid column values are different comparing both results, and 
the same thing happens with the eid column values

** Affects: mahara
 Importance: Low
 Status: Confirmed

** Changed in: mahara
   Status: New => Confirmed

** Changed in: mahara
   Importance: Undecided => Low

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1890214

Title:
  SE framework editor re-creating DB records when not needed

Status in Mahara:
  Confirmed

Bug description:
  On the SmartEvidence framework editor when new information that is not
  saved to the DB is added, the javascript form will not have the DB
  record ids for this data.

  The framework.json.php file is responsible for saving the framework to the 
DB. The way the algorithm works, it will check if the data from the js form 
contains the DB ids (uids in the form).
  If there are records on the DB that are not present in the js form data, then 
these are DB records that need to be removed because they have been deleted in 
the js form.
  If there are fields with no uids, then this is new data that needs to be 
saved.

  So if we are adding new standards or elements and save the form, unless  we 
find a way to add the DB ids of the newly created records to the js form, 
everytime the form is saved it will delete the records and add new ones with 
same data.
  This stops happening for existing records when we reload the page, but will 
happen again for new data.

  To test this:
  - create a new framework with name 'New framework' and save
  - go into the DB and run the query to get the id
  select id, name from framework where name='New framework'
  - on the DB run the query to check the standards and elements
  select s.id sid, s.shortname,
  e.id eid, e.shortname, e.parent from
  framework_standard s left join
  framework_standard_element e
  on e.standard=s.id
  where s.framework= order by eid;
  - go to the site and without reloading the page or making any changes, save 
the form again
  - on the DB, run the query to get the standards and elements again
  - compare the columns 'sid' and 'eid'

  expected result: they should be the same for both results
  actual result: the sid column values are different comparing both results, 
and the same thing happens with the eid column values

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1890214/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1890213] [NEW] Upgrade: ADODB 5.20.16 to 5.20.18

2020-08-03 Thread Lisa Seeto
Public bug reported:

Our current version of ADODB (5.20.16) can be upgraded to version
5.20.18.

https://github.com/ADOdb/ADOdb/releases

Change logs:
-
5.20.18 - 28-Jun-2020:
 mssql: Retrieve error messages early before connection closed. #614

5.20.17 - 31-Mar-2020:
  core: fix PHP notice in ADOdb_Exception constructor when using transactions. 
#601
  mssql: fix PHP notice due to uninitialized array with PHP 7.4. #608
  active record: Fix UpdateActiveTable failing with mixed case column names. 
#610

** Affects: mahara
 Importance: Undecided
 Status: New

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1890213

Title:
  Upgrade: ADODB 5.20.16 to 5.20.18

Status in Mahara:
  New

Bug description:
  Our current version of ADODB (5.20.16) can be upgraded to version
  5.20.18.

  https://github.com/ADOdb/ADOdb/releases

  Change logs:
  -
  5.20.18 - 28-Jun-2020:
   mssql: Retrieve error messages early before connection closed. #614

  5.20.17 - 31-Mar-2020:
core: fix PHP notice in ADOdb_Exception constructor when using 
transactions. #601
mssql: fix PHP notice due to uninitialized array with PHP 7.4. #608
active record: Fix UpdateActiveTable failing with mixed case column names. 
#610

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1890213/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1889693] Re: Incorrect tooltip on page for quick edit

2020-08-03 Thread Robert Lyon
** Changed in: mahara
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1889693

Title:
  Incorrect tooltip on page for quick edit

Status in Mahara:
  Fix Committed

Bug description:
  hovering over the cog icon shows broken string

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1889693/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1889485] A change has been merged

2020-08-03 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/11106
Committed: 
https://git.mahara.org/mahara/mahara/commit/f64ccffddc730696cb7a9a9f515fb2e243be5675
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:19.04_STABLE

commit f64ccffddc730696cb7a9a9f515fb2e243be5675
Author: Lisa Seeto 
Date:   Thu Jul 30 11:39:35 2020 +1200

Bug 1889485: Security Upgrade SimpleSAML 1.18.4 to 1.18.7

- upgrade to version 1.18.7

Change-Id: I4e7ca4de32a4c69224c184013c15f92069cc97ff
Signed-off-by: Lisa Seeto 

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1889485

Title:
  Security Upgrade SimpleSAML 1.18.4 to 1.18.7

Status in Mahara:
  Fix Committed
Status in Mahara 19.04 series:
  Fix Committed
Status in Mahara 19.10 series:
  In Progress
Status in Mahara 20.04 series:
  In Progress
Status in Mahara 20.10 series:
  Fix Committed

Bug description:
  From https://simplesamlphp.org/security/202004-01:

  Date
  April 03, 2020
  Affected versions
  SimpleSAMLphp 1.18.5 and older
  Severity
  Low

  Background

  The module controller in SimpleSAML\Module that processes requests for pages 
hosted by modules, has code to identify paths ending with .php and process 
those as PHP code. If no other suitable way of handling the given path exists 
it presents the file to the browser.
  Description

  The check to identify paths ending with .php does not account for uppercase 
letters. If someone requests a path ending with e.g. .PHP and the server is 
serving the code from a case-insensitive file system, such as on Windows, the 
processing of the PHP code does not occur, and the source code is instead 
presented to the browser.
  Affected versions

  SimpleSAMLphp versions 1.18.5 and older.

  We will upgrade to version 1.18.7

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1889485/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1889693] A change has been merged

2020-08-03 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/11098
Committed: 
https://git.mahara.org/mahara/mahara/commit/7c8b101ab5a2dd40acda3fbfaa409582a8e6fcfd
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master

commit 7c8b101ab5a2dd40acda3fbfaa409582a8e6fcfd
Author: Robert Lyon 
Date:   Fri Jul 31 09:11:08 2020 +1200

Bug 1889693: Quick edit title not correct if hovering over cog

When hovering over 'Quick edit' text on a page block the title tooltip
shows correctly but if you hover over the cog you get broken string

Change-Id: I7e4e5c7e3e3ca200477cd1ab8c2d6ad8acbf93be
Signed-off-by: Robert Lyon 

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1889693

Title:
  Incorrect tooltip on page for quick edit

Status in Mahara:
  Fix Committed

Bug description:
  hovering over the cog icon shows broken string

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1889693/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1889485] Re: Security Upgrade SimpleSAML 1.18.4 to 1.18.7

2020-08-03 Thread Robert Lyon
** Changed in: mahara/19.04
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1889485

Title:
  Security Upgrade SimpleSAML 1.18.4 to 1.18.7

Status in Mahara:
  Fix Committed
Status in Mahara 19.04 series:
  Fix Committed
Status in Mahara 19.10 series:
  In Progress
Status in Mahara 20.04 series:
  In Progress
Status in Mahara 20.10 series:
  Fix Committed

Bug description:
  From https://simplesamlphp.org/security/202004-01:

  Date
  April 03, 2020
  Affected versions
  SimpleSAMLphp 1.18.5 and older
  Severity
  Low

  Background

  The module controller in SimpleSAML\Module that processes requests for pages 
hosted by modules, has code to identify paths ending with .php and process 
those as PHP code. If no other suitable way of handling the given path exists 
it presents the file to the browser.
  Description

  The check to identify paths ending with .php does not account for uppercase 
letters. If someone requests a path ending with e.g. .PHP and the server is 
serving the code from a case-insensitive file system, such as on Windows, the 
processing of the PHP code does not occur, and the source code is instead 
presented to the browser.
  Affected versions

  SimpleSAMLphp versions 1.18.5 and older.

  We will upgrade to version 1.18.7

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1889485/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1889485] Re: Security Upgrade SimpleSAML 1.18.4 to 1.18.7

2020-08-03 Thread Robert Lyon
** Changed in: mahara/20.10
   Status: Confirmed => Fix Committed

** Changed in: mahara/19.04
   Status: Confirmed => In Progress

** Changed in: mahara/19.10
   Status: Confirmed => In Progress

** Changed in: mahara/20.04
   Status: Confirmed => In Progress

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1889485

Title:
  Security Upgrade SimpleSAML 1.18.4 to 1.18.7

Status in Mahara:
  Fix Committed
Status in Mahara 19.04 series:
  In Progress
Status in Mahara 19.10 series:
  In Progress
Status in Mahara 20.04 series:
  In Progress
Status in Mahara 20.10 series:
  Fix Committed

Bug description:
  From https://simplesamlphp.org/security/202004-01:

  Date
  April 03, 2020
  Affected versions
  SimpleSAMLphp 1.18.5 and older
  Severity
  Low

  Background

  The module controller in SimpleSAML\Module that processes requests for pages 
hosted by modules, has code to identify paths ending with .php and process 
those as PHP code. If no other suitable way of handling the given path exists 
it presents the file to the browser.
  Description

  The check to identify paths ending with .php does not account for uppercase 
letters. If someone requests a path ending with e.g. .PHP and the server is 
serving the code from a case-insensitive file system, such as on Windows, the 
processing of the PHP code does not occur, and the source code is instead 
presented to the browser.
  Affected versions

  SimpleSAMLphp versions 1.18.5 and older.

  We will upgrade to version 1.18.7

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1889485/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1889485] A patch has been submitted for review

2020-08-03 Thread Mahara Bot
Patch for "19.10_STABLE" branch: https://reviews.mahara.org/11105

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1889485

Title:
  Security Upgrade SimpleSAML 1.18.4 to 1.18.7

Status in Mahara:
  Fix Committed
Status in Mahara 19.04 series:
  In Progress
Status in Mahara 19.10 series:
  In Progress
Status in Mahara 20.04 series:
  In Progress
Status in Mahara 20.10 series:
  Fix Committed

Bug description:
  From https://simplesamlphp.org/security/202004-01:

  Date
  April 03, 2020
  Affected versions
  SimpleSAMLphp 1.18.5 and older
  Severity
  Low

  Background

  The module controller in SimpleSAML\Module that processes requests for pages 
hosted by modules, has code to identify paths ending with .php and process 
those as PHP code. If no other suitable way of handling the given path exists 
it presents the file to the browser.
  Description

  The check to identify paths ending with .php does not account for uppercase 
letters. If someone requests a path ending with e.g. .PHP and the server is 
serving the code from a case-insensitive file system, such as on Windows, the 
processing of the PHP code does not occur, and the source code is instead 
presented to the browser.
  Affected versions

  SimpleSAMLphp versions 1.18.5 and older.

  We will upgrade to version 1.18.7

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1889485/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1889485] A change has been merged

2020-08-03 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/11093
Committed: 
https://git.mahara.org/mahara/mahara/commit/7f97ceb72e4cf0caafaee2963a3ec2152b874137
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master

commit 7f97ceb72e4cf0caafaee2963a3ec2152b874137
Author: Lisa Seeto 
Date:   Thu Jul 30 11:39:35 2020 +1200

Bug 1889485: Security Upgrade SimpleSAML 1.18.4 to 1.18.7

- upgrade to version 1.18.7

Change-Id: I4e7ca4de32a4c69224c184013c15f92069cc97ff
Signed-off-by: Lisa Seeto 

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1889485

Title:
  Security Upgrade SimpleSAML 1.18.4 to 1.18.7

Status in Mahara:
  Confirmed
Status in Mahara 19.04 series:
  Confirmed
Status in Mahara 19.10 series:
  Confirmed
Status in Mahara 20.04 series:
  Confirmed
Status in Mahara 20.10 series:
  Confirmed

Bug description:
  From https://simplesamlphp.org/security/202004-01:

  Date
  April 03, 2020
  Affected versions
  SimpleSAMLphp 1.18.5 and older
  Severity
  Low

  Background

  The module controller in SimpleSAML\Module that processes requests for pages 
hosted by modules, has code to identify paths ending with .php and process 
those as PHP code. If no other suitable way of handling the given path exists 
it presents the file to the browser.
  Description

  The check to identify paths ending with .php does not account for uppercase 
letters. If someone requests a path ending with e.g. .PHP and the server is 
serving the code from a case-insensitive file system, such as on Windows, the 
processing of the PHP code does not occur, and the source code is instead 
presented to the browser.
  Affected versions

  SimpleSAMLphp versions 1.18.5 and older.

  We will upgrade to version 1.18.7

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1889485/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp