[Mahara-contributors] [Bug 1845053] Re: Font size and size variable review

2020-08-17 Thread Cecilia Vela Gurovic
** Changed in: mahara
   Status: Confirmed => In Progress

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1845053

Title:
  Font size and size variable review

Status in Mahara:
  In Progress

Bug description:
  As part of our accessibility review, we are going to increase the base
  font size from 14px to 16px. In addition, there are some elements that
  do not yet have font size variables. They will be changed to allow for
  flexibility.

  We'll also need to review the line height at the same time and the
  hover background and whether and if so where we are going to keep it.
  UX will be needed for that.

  All these changes are to be looked at alongside the WCAG 2.1
  guidelines.

  Tagging against 20.04 as these will be bigger changes and need a fair
  amount of testing in all our themes.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1845053/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1889020] Re: Behat failing tests when trying to add blocks on pages

2020-08-17 Thread Cecilia Vela Gurovic
** Changed in: mahara
   Status: Confirmed => In Progress

** Changed in: mahara
 Assignee: (unassigned) => Cecilia Vela Gurovic (ceciliavg)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1889020

Title:
  Behat failing tests when trying to add blocks on pages

Status in Mahara:
  In Progress

Bug description:
  There are a few behat tests that fail, so far I've seen
  edit_default_template_pages.feature
  group_view_block.feature
  shared_with_group.feature

  They try to add a block but the modal is never opened and then the
  tests fails trying to select a blocktype from a modal that is not
  visible.

  By looking into the Network tab of the browser while running the
  tests, I could see that there are too many calls to
  view/blocks.json.php taking a long time to run. This could be delaying
  the modal load, but we would need to look into this a bit more.

  The calls have parameters like
  id: 2
  change: 1
  action_moveblockinstance_id_6_newx_0_newy_0_newheight_8_newwidth_6: true

  so they're just trying to resize or move the blocks inside the page.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1889020/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1890369] Re: Upgrade: HTML Purifier 4.12.0 to 4.13.0

2020-08-17 Thread Cecilia Vela Gurovic
** Changed in: mahara
   Importance: Undecided => High

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1890369

Title:
  Upgrade: HTML Purifier 4.12.0 to 4.13.0

Status in Mahara:
  In Progress

Bug description:
  Related to https://bugs.launchpad.net/mahara/+bug/1865115

  Upgrading HTML Purifier from 4.12.0 to 4.13.0:

  https://github.com/ezyang/htmlpurifier/blob/v4.13.0/NEWS

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1890369/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1889340] Re: Adding indexes to tag table to speed things up

2020-08-17 Thread Cecilia Vela Gurovic
** Changed in: mahara/20.10
   Status: Confirmed => In Progress

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1889340

Title:
  Adding indexes to tag table to speed things up

Status in Mahara:
  In Progress
Status in Mahara 19.04 series:
  Confirmed
Status in Mahara 19.10 series:
  Confirmed
Status in Mahara 20.04 series:
  Confirmed
Status in Mahara 20.10 series:
  In Progress

Bug description:
  To make requests to tags table faster

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1889340/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1890363] A change has been merged

2020-08-17 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/11145
Committed: 
https://git.mahara.org/mahara/mahara/commit/a0a1320a1d4bf16cc8dd753c1a95db3844d71161
Submitter: Cecilia Vela Gurovic (cecili...@catalyst.net.nz)
Branch:master

commit a0a1320a1d4bf16cc8dd753c1a95db3844d71161
Author: Lisa Seeto 
Date:   Mon Aug 17 15:18:01 2020 +1200

Bug 1890363: Upgrade: Dropzone 5.5.0 to 5.7.0

- upgrade with release 5.7.0 found here:
https://github.com/enyo/dropzone/releases/tag/v5.7.0

Change-Id: I5f6a0d445e9c3479c0c9c6af2f35bb5e128fc40c
Signed-off-by: Lisa Seeto 

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1890363

Title:
  Upgrade: Dropzone 5.5.0 to 5.7.0

Status in Mahara:
  Fix Committed

Bug description:
  Related to https://bugs.launchpad.net/mahara/+bug/1865115

  Updating current version 5.5.0 to 5.7.0.

  https://github.com/enyo/dropzone/releases

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1890363/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1890363] Re: Upgrade: Dropzone 5.5.0 to 5.7.0

2020-08-17 Thread Cecilia Vela Gurovic
** Changed in: mahara
   Importance: Undecided => High

** Changed in: mahara
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1890363

Title:
  Upgrade: Dropzone 5.5.0 to 5.7.0

Status in Mahara:
  Fix Committed

Bug description:
  Related to https://bugs.launchpad.net/mahara/+bug/1865115

  Updating current version 5.5.0 to 5.7.0.

  https://github.com/enyo/dropzone/releases

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1890363/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1889341] Re: upgrade jquery 3.4.1 to 3.5.1

2020-08-17 Thread Cecilia Vela Gurovic
** Changed in: mahara/19.04
   Status: Confirmed => In Progress

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1889341

Title:
  upgrade jquery 3.4.1 to 3.5.1

Status in Mahara:
  Fix Committed
Status in Mahara 19.04 series:
  In Progress
Status in Mahara 19.10 series:
  Fix Committed
Status in Mahara 20.04 series:
  Fix Committed
Status in Mahara 20.10 series:
  Fix Committed

Bug description:
  Related to https://bugs.launchpad.net/mahara/+bug/1865115

  jquery is now at 3.5.1 and we are on 3.4.1.  Version 3.5.0 contained
  security fixes as described below:

  https://blog.jquery.com/2020/04/10/jquery-3-5-0-released/

  Change log:
  https://github.com/jquery/jquery/compare/3.4.1...3.5.1

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1889341/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1889341] A patch has been submitted for review

2020-08-17 Thread Mahara Bot
Patch for "19.04_STABLE" branch: https://reviews.mahara.org/11154

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1889341

Title:
  upgrade jquery 3.4.1 to 3.5.1

Status in Mahara:
  Fix Committed
Status in Mahara 19.04 series:
  In Progress
Status in Mahara 19.10 series:
  Fix Committed
Status in Mahara 20.04 series:
  Fix Committed
Status in Mahara 20.10 series:
  Fix Committed

Bug description:
  Related to https://bugs.launchpad.net/mahara/+bug/1865115

  jquery is now at 3.5.1 and we are on 3.4.1.  Version 3.5.0 contained
  security fixes as described below:

  https://blog.jquery.com/2020/04/10/jquery-3-5-0-released/

  Change log:
  https://github.com/jquery/jquery/compare/3.4.1...3.5.1

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1889341/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1889341] A change has been merged

2020-08-17 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/11153
Committed: 
https://git.mahara.org/mahara/mahara/commit/a5996bf059d3af0c6ea1bf7f4fc02ee8c24ef15f
Submitter: Cecilia Vela Gurovic (cecili...@catalyst.net.nz)
Branch:19.10_STABLE

commit a5996bf059d3af0c6ea1bf7f4fc02ee8c24ef15f
Author: Lisa Seeto 
Date:   Wed Jul 29 16:20:34 2020 +1200

Bug 1889341: upgrade jquery 3.4.1 to 3.5.1

- updated jquery using min file found here:
https://code.jquery.com/jquery-3.5.1.min.js

Change-Id: I2d83e0fdf9ff4ab888e16522128778f45d313780
Signed-off-by: Lisa Seeto 
(cherry picked from commit 49efbd9bdb512e9ed603cfcce19b37d385a6daf1)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1889341

Title:
  upgrade jquery 3.4.1 to 3.5.1

Status in Mahara:
  Fix Committed
Status in Mahara 19.04 series:
  In Progress
Status in Mahara 19.10 series:
  Fix Committed
Status in Mahara 20.04 series:
  Fix Committed
Status in Mahara 20.10 series:
  Fix Committed

Bug description:
  Related to https://bugs.launchpad.net/mahara/+bug/1865115

  jquery is now at 3.5.1 and we are on 3.4.1.  Version 3.5.0 contained
  security fixes as described below:

  https://blog.jquery.com/2020/04/10/jquery-3-5-0-released/

  Change log:
  https://github.com/jquery/jquery/compare/3.4.1...3.5.1

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1889341/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1891949] Re: sign off block height on gridstack

2020-08-17 Thread Cecilia Vela Gurovic
** No longer affects: mahara/19.04

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1891949

Title:
  sign off block height on gridstack

Status in Mahara:
  Confirmed
Status in Mahara 19.10 series:
  New
Status in Mahara 20.04 series:
  New
Status in Mahara 20.10 series:
  Confirmed

Bug description:
  The sign off block content is very different when editing the page from when 
viewing the page. This makes the block have a lot of extra space when viewing 
the page. We can make the height be predefined for viewsing since it will 
always have the same content, it can only have
  Sign off / Verify lines
  or
  Sign off alone

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1891949/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1889341] A patch has been submitted for review

2020-08-17 Thread Mahara Bot
Patch for "20.04_STABLE" branch: https://reviews.mahara.org/11152

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1889341

Title:
  upgrade jquery 3.4.1 to 3.5.1

Status in Mahara:
  Fix Committed
Status in Mahara 19.04 series:
  In Progress
Status in Mahara 19.10 series:
  Fix Committed
Status in Mahara 20.04 series:
  Fix Committed
Status in Mahara 20.10 series:
  Fix Committed

Bug description:
  Related to https://bugs.launchpad.net/mahara/+bug/1865115

  jquery is now at 3.5.1 and we are on 3.4.1.  Version 3.5.0 contained
  security fixes as described below:

  https://blog.jquery.com/2020/04/10/jquery-3-5-0-released/

  Change log:
  https://github.com/jquery/jquery/compare/3.4.1...3.5.1

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1889341/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1889341] Re: upgrade jquery 3.4.1 to 3.5.1

2020-08-17 Thread Cecilia Vela Gurovic
** Changed in: mahara/20.04
   Status: Confirmed => Fix Committed

** Changed in: mahara/19.10
   Status: Confirmed => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1889341

Title:
  upgrade jquery 3.4.1 to 3.5.1

Status in Mahara:
  Fix Committed
Status in Mahara 19.04 series:
  In Progress
Status in Mahara 19.10 series:
  Fix Committed
Status in Mahara 20.04 series:
  Fix Committed
Status in Mahara 20.10 series:
  Fix Committed

Bug description:
  Related to https://bugs.launchpad.net/mahara/+bug/1865115

  jquery is now at 3.5.1 and we are on 3.4.1.  Version 3.5.0 contained
  security fixes as described below:

  https://blog.jquery.com/2020/04/10/jquery-3-5-0-released/

  Change log:
  https://github.com/jquery/jquery/compare/3.4.1...3.5.1

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1889341/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1889341] A change has been merged

2020-08-17 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/11152
Committed: 
https://git.mahara.org/mahara/mahara/commit/86fe066274b945b38123b7133cd8d731fad1cc18
Submitter: Cecilia Vela Gurovic (cecili...@catalyst.net.nz)
Branch:20.04_STABLE

commit 86fe066274b945b38123b7133cd8d731fad1cc18
Author: Lisa Seeto 
Date:   Wed Jul 29 16:20:34 2020 +1200

Bug 1889341: upgrade jquery 3.4.1 to 3.5.1

- updated jquery using min file found here:
https://code.jquery.com/jquery-3.5.1.min.js

Change-Id: I2d83e0fdf9ff4ab888e16522128778f45d313780
Signed-off-by: Lisa Seeto 
(cherry picked from commit 49efbd9bdb512e9ed603cfcce19b37d385a6daf1)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1889341

Title:
  upgrade jquery 3.4.1 to 3.5.1

Status in Mahara:
  Fix Committed
Status in Mahara 19.04 series:
  In Progress
Status in Mahara 19.10 series:
  Fix Committed
Status in Mahara 20.04 series:
  Fix Committed
Status in Mahara 20.10 series:
  Fix Committed

Bug description:
  Related to https://bugs.launchpad.net/mahara/+bug/1865115

  jquery is now at 3.5.1 and we are on 3.4.1.  Version 3.5.0 contained
  security fixes as described below:

  https://blog.jquery.com/2020/04/10/jquery-3-5-0-released/

  Change log:
  https://github.com/jquery/jquery/compare/3.4.1...3.5.1

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1889341/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1889341] A patch has been submitted for review

2020-08-17 Thread Mahara Bot
Patch for "19.10_STABLE" branch: https://reviews.mahara.org/11153

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1889341

Title:
  upgrade jquery 3.4.1 to 3.5.1

Status in Mahara:
  Fix Committed
Status in Mahara 19.04 series:
  In Progress
Status in Mahara 19.10 series:
  Fix Committed
Status in Mahara 20.04 series:
  Fix Committed
Status in Mahara 20.10 series:
  Fix Committed

Bug description:
  Related to https://bugs.launchpad.net/mahara/+bug/1865115

  jquery is now at 3.5.1 and we are on 3.4.1.  Version 3.5.0 contained
  security fixes as described below:

  https://blog.jquery.com/2020/04/10/jquery-3-5-0-released/

  Change log:
  https://github.com/jquery/jquery/compare/3.4.1...3.5.1

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1889341/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1889341] Re: upgrade jquery 3.4.1 to 3.5.1

2020-08-17 Thread Cecilia Vela Gurovic
** Changed in: mahara/20.10
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1889341

Title:
  upgrade jquery 3.4.1 to 3.5.1

Status in Mahara:
  Fix Committed
Status in Mahara 19.04 series:
  Confirmed
Status in Mahara 19.10 series:
  Fix Committed
Status in Mahara 20.04 series:
  Fix Committed
Status in Mahara 20.10 series:
  Fix Committed

Bug description:
  Related to https://bugs.launchpad.net/mahara/+bug/1865115

  jquery is now at 3.5.1 and we are on 3.4.1.  Version 3.5.0 contained
  security fixes as described below:

  https://blog.jquery.com/2020/04/10/jquery-3-5-0-released/

  Change log:
  https://github.com/jquery/jquery/compare/3.4.1...3.5.1

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1889341/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1889341] A change has been merged

2020-08-17 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/11092
Committed: 
https://git.mahara.org/mahara/mahara/commit/49efbd9bdb512e9ed603cfcce19b37d385a6daf1
Submitter: Cecilia Vela Gurovic (cecili...@catalyst.net.nz)
Branch:master

commit 49efbd9bdb512e9ed603cfcce19b37d385a6daf1
Author: Lisa Seeto 
Date:   Wed Jul 29 16:20:34 2020 +1200

Bug 1889341: upgrade jquery 3.4.1 to 3.5.1

- updated jquery using min file found here:
https://code.jquery.com/jquery-3.5.1.min.js

Change-Id: I2d83e0fdf9ff4ab888e16522128778f45d313780
Signed-off-by: Lisa Seeto 

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1889341

Title:
  upgrade jquery 3.4.1 to 3.5.1

Status in Mahara:
  Fix Committed
Status in Mahara 19.04 series:
  Confirmed
Status in Mahara 19.10 series:
  Confirmed
Status in Mahara 20.04 series:
  Confirmed
Status in Mahara 20.10 series:
  Fix Committed

Bug description:
  Related to https://bugs.launchpad.net/mahara/+bug/1865115

  jquery is now at 3.5.1 and we are on 3.4.1.  Version 3.5.0 contained
  security fixes as described below:

  https://blog.jquery.com/2020/04/10/jquery-3-5-0-released/

  Change log:
  https://github.com/jquery/jquery/compare/3.4.1...3.5.1

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1889341/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1891426] A patch has been submitted for review

2020-08-17 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/11151

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1891426

Title:
  Behat: Move quota checks to notification_quota.feature

Status in Mahara:
  In Progress

Bug description:
  We have a test called /user_content/file_edit.feature which includes
  checks for the upload quota allowed. These would be better placed in
  /settings/notification_quota.feature.

  Remove steps related to quota from file_edit.feature and add them to
  notification_quota.feature in the section where UserA logs in (approx
  ln 33)

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1891426/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1891426] Re: Behat: Move quota checks to notification_quota.feature

2020-08-17 Thread Rebecca Blundell
** Changed in: mahara
   Status: New => In Progress

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1891426

Title:
  Behat: Move quota checks to notification_quota.feature

Status in Mahara:
  In Progress

Bug description:
  We have a test called /user_content/file_edit.feature which includes
  checks for the upload quota allowed. These would be better placed in
  /settings/notification_quota.feature.

  Remove steps related to quota from file_edit.feature and add them to
  notification_quota.feature in the section where UserA logs in (approx
  ln 33)

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1891426/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1891955] A patch has been submitted for review

2020-08-17 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/11150

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1891955

Title:
  Behat: rename versioning.feature->timeline.feature

Status in Mahara:
  Fix Committed

Bug description:
  Let's change the name of this test to make it more obvious what it does:
  versioning.feature->timeline.feature

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1891955/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1891955] [NEW] Behat: rename versioning.feature->timeline.feature

2020-08-17 Thread Rebecca Blundell
Public bug reported:

Let's change the name of this test to make it more obvious what it does:
versioning.feature->timeline.feature

** Affects: mahara
 Importance: Undecided
 Assignee: Rangi Daymond (rangid)
 Status: Fix Committed


** Tags: behat-test

** Changed in: mahara
   Status: New => In Progress

** Changed in: mahara
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1891955

Title:
  Behat: rename versioning.feature->timeline.feature

Status in Mahara:
  Fix Committed

Bug description:
  Let's change the name of this test to make it more obvious what it does:
  versioning.feature->timeline.feature

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1891955/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1891941] Re: Correct inbox notifications for collection access

2020-08-17 Thread Lisa Seeto
** Changed in: mahara
   Status: Confirmed => In Progress

** Changed in: mahara
 Assignee: (unassigned) => Lisa Seeto (lisaseeto)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1891941

Title:
  Correct inbox notifications for collection access

Status in Mahara:
  In Progress

Bug description:
  This is a follow-on from bug #922911 and marked as high as new
  functionality.

  Please see the screenshot for additional information. The notification
  is not correct when displayed via the Mahara inbox:

  1. There is an indentation where there shouldn't be one. Or if there
  were a bullet point, it should be displayed. When there is only one
  item though, there shouldn't be a list, but just the item as lists
  start with two items.

  2. The text from 'See URL...' should not be in the inbox notification
  but only in the email notification.

  3. The 'More... ->' link should read 'Portfolio ->' instead and have
  an accessible title that mentions the portfolio title.

  4. The notification should start with 'You have been given access to'
  but not repeat the subject.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1891941/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1891941] Re: Correct inbox notifications for collection access

2020-08-17 Thread Kristina Hoeppner
** Description changed:

  This is a follow-on from bug #922911 and marked as high as new
  functionality.
  
  Please see the screenshot for additional information. The notification
  is not correct when displayed via the Mahara inbox:
  
  1. There is an indentation where there shouldn't be one. Or if there
  were a bullet point, it should be displayed. When there is only one item
  though, there shouldn't be a list, but just the item as lists start with
  two items.
  
  2. The text from 'See URL...' should not be in the inbox notification
  but only in the email notification.
  
  3. The 'More... ->' link should read 'Portfolio ->' instead and have an
  accessible title that mentions the portfolio title.
+ 
+ 4. The notification should start with 'You have been given access to'
+ but not repeat the subject.

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1891941

Title:
  Correct inbox notifications for collection access

Status in Mahara:
  Confirmed

Bug description:
  This is a follow-on from bug #922911 and marked as high as new
  functionality.

  Please see the screenshot for additional information. The notification
  is not correct when displayed via the Mahara inbox:

  1. There is an indentation where there shouldn't be one. Or if there
  were a bullet point, it should be displayed. When there is only one
  item though, there shouldn't be a list, but just the item as lists
  start with two items.

  2. The text from 'See URL...' should not be in the inbox notification
  but only in the email notification.

  3. The 'More... ->' link should read 'Portfolio ->' instead and have
  an accessible title that mentions the portfolio title.

  4. The notification should start with 'You have been given access to'
  but not repeat the subject.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1891941/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1891568] Re: Behat: Add test for "Pages and collections" page elements

2020-08-17 Thread Rebecca Blundell
** Description changed:

  Automating manual test. These are the details from the spreadsheet:
  
  Overview page contains the following
  * Page title - “Pages and Collections
- * listing of existing pages 
+ * listing of existing pages
  * default pages – Dashboard & Profile page
  * side bar – user info. Online users, Tags
  * section header – search, sort, add & copy button
  
  Displays create and Copy button, Search and Sort by with drop down
  arrow, Edit and Delete button
  
  Create a new test called pages_collections.feature
+ tag it @mainflow
  
  Add tests that the default elements are present on the page. This does
  not include the header and footer elements or any functionality. These
  things are tested elsewhere.

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1891568

Title:
  Behat: Add test for "Pages and collections" page elements

Status in Mahara:
  New

Bug description:
  Automating manual test. These are the details from the spreadsheet:

  Overview page contains the following
  * Page title - “Pages and Collections
  * listing of existing pages
  * default pages – Dashboard & Profile page
  * side bar – user info. Online users, Tags
  * section header – search, sort, add & copy button

  Displays create and Copy button, Search and Sort by with drop down
  arrow, Edit and Delete button

  Create a new test called pages_collections.feature
  tag it @mainflow

  Add tests that the default elements are present on the page. This does
  not include the header and footer elements or any functionality. These
  things are tested elsewhere.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1891568/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1891951] [NEW] Behat: comments are moderated if made anonymously

2020-08-17 Thread Rebecca Blundell
Public bug reported:

Automating manual test. Test from spreadsheet is below:

When “Make public” is set to “Yes”, comment moderation should kick in
automatically as per https://reviews.mahara.org/8575

We test anonymous comments in social/add_delete_comments.feature. We can
add a check to this to make sure moderation is forced for anonymous
comments.

1. Because the feature name is mis-leading, let's rename it to 
anonymous_comments.feature
2. After Joe Anonymous makes his comment, add a check that he sees "Comment 
submitted, awaiting moderation"
3. When the page owner logs back in, confirm that the anonymous comment says 
"This comment is private - " and they can click the button for "Make comment 
public"
4. Review test content. Decide whether page mtime scenario makes sense here or 
if it should be in a separate file.

** Affects: mahara
 Importance: Undecided
 Assignee: Rangi Daymond (rangid)
 Status: New


** Tags: behat-test

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1891951

Title:
  Behat: comments are moderated if made anonymously

Status in Mahara:
  New

Bug description:
  Automating manual test. Test from spreadsheet is below:

  When “Make public” is set to “Yes”, comment moderation should kick in
  automatically as per https://reviews.mahara.org/8575

  We test anonymous comments in social/add_delete_comments.feature. We
  can add a check to this to make sure moderation is forced for
  anonymous comments.

  1. Because the feature name is mis-leading, let's rename it to 
anonymous_comments.feature
  2. After Joe Anonymous makes his comment, add a check that he sees "Comment 
submitted, awaiting moderation"
  3. When the page owner logs back in, confirm that the anonymous comment says 
"This comment is private - " and they can click the button for "Make comment 
public"
  4. Review test content. Decide whether page mtime scenario makes sense here 
or if it should be in a separate file.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1891951/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1891949] [NEW] sign off block height on gridstack

2020-08-17 Thread Cecilia Vela Gurovic
Public bug reported:

The sign off block content is very different when editing the page from when 
viewing the page. This makes the block have a lot of extra space when viewing 
the page. We can make the height be predefined for viewsing since it will 
always have the same content, it can only have
Sign off / Verify lines
or
Sign off alone

** Affects: mahara
 Importance: Medium
 Status: Confirmed

** Affects: mahara/19.04
 Importance: Medium
 Status: New

** Affects: mahara/19.10
 Importance: Medium
 Status: New

** Affects: mahara/20.04
 Importance: Medium
 Status: New

** Affects: mahara/20.10
 Importance: Medium
 Status: Confirmed

** Changed in: mahara
   Status: New => Confirmed

** Changed in: mahara
Milestone: None => 20.10.0

** Changed in: mahara
   Importance: Undecided => Medium

** Also affects: mahara/19.10
   Importance: Undecided
   Status: New

** Also affects: mahara/19.04
   Importance: Undecided
   Status: New

** Also affects: mahara/20.10
   Importance: Medium
   Status: Confirmed

** Also affects: mahara/20.04
   Importance: Undecided
   Status: New

** Changed in: mahara/20.04
Milestone: None => 20.04.2

** Changed in: mahara/19.10
Milestone: None => 19.10.5

** Changed in: mahara/20.04
   Importance: Undecided => Medium

** Changed in: mahara/19.10
   Importance: Undecided => Medium

** Changed in: mahara/19.04
   Importance: Undecided => Medium

** Changed in: mahara/19.04
Milestone: None => 19.04.7

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1891949

Title:
  sign off block height on gridstack

Status in Mahara:
  Confirmed
Status in Mahara 19.04 series:
  New
Status in Mahara 19.10 series:
  New
Status in Mahara 20.04 series:
  New
Status in Mahara 20.10 series:
  Confirmed

Bug description:
  The sign off block content is very different when editing the page from when 
viewing the page. This makes the block have a lot of extra space when viewing 
the page. We can make the height be predefined for viewsing since it will 
always have the same content, it can only have
  Sign off / Verify lines
  or
  Sign off alone

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1891949/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1891425] Re: Reset configurable theme to default causing warning and loss of styles

2020-08-17 Thread Robert Lyon
** Changed in: mahara
   Status: In Progress => Fix Committed

** Changed in: mahara
   Importance: Undecided => Medium

** Changed in: mahara
Milestone: None => 21.04.0

** Changed in: mahara
Milestone: 21.04.0 => 20.10.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1891425

Title:
  Reset configurable theme to default causing warning and loss of styles

Status in Mahara:
  Fix Committed

Bug description:
  It is possible to set a configurable theme for an institution that
  will itself have a default configuration of pre-set colours.  It is
  possible to configure a new theme, save it and then select "Reset" to
  return to the default pre-set theme values.  Currently, a warning is
  being produced and Mahara is losing its styling.

  To reproduce:
  1. Have an institution and log in with an admin member
  2. Edit the institution settings and select "Configurable Theme" from the 
Theme drop-down
  3. Set the theme values to any other colour via colour picker or hex value, 
save
  4. The site should update with the newly configured theme, select to edit the 
institution again
  5. return to the Theme settings and set "Reset colours" to "yes", save the 
page.
  Expected result:
  The theme is returned to the default configurable theme configuration
  Actual result:
  All Mahara styling is lost, a warning is produced:

  Institution updated successfully.  Others will see the new theme the next 
time they log in.
  [WAR] 72 (lib/web.php:90) array_merge(): Argument #2 is not an array
  Call stack (most recent first):

  log_message("array_merge(): Argument #2 is not an array", 8, true, true, 
"/home/lisaseeto/code/mahara-test/htdocs/lib/web.ph...", 90) at 
/home/lisaseeto/code/mahara-test/htdocs/lib/errors.php:521
  error(2, "array_merge(): Argument #2 is not an array", 
"/home/lisaseeto/code/mahara-test/htdocs/lib/web.ph...", 90, array(size 11)) at 
Unknown:0
  array_merge(array(size 2), null) at 
/home/lisaseeto/code/mahara-test/htdocs/lib/web.php:90
  get_stylesheets_for_current_page(array(size 2), array(size 0)) at 
/home/lisaseeto/code/mahara-test/htdocs/lib/web.php:646
  smarty(array(size 2)) at 
/home/lisaseeto/code/mahara-test/htdocs/admin/users/institutions.php:716

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1891425/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1891425] A change has been merged

2020-08-17 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/11138
Committed: 
https://git.mahara.org/mahara/mahara/commit/0a579a93c8db7602bf7effb17c7989dc67c2637d
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master

commit 0a579a93c8db7602bf7effb17c7989dc67c2637d
Author: Lisa Seeto 
Date:   Fri Aug 14 09:47:58 2020 +1200

Bug 1891425: Reset configurable theme to default causing warning and
loss of styles

- add check that $sheets can be set to additional_stylesheets before attempting
to merge into array
- fix reset to default config theme values issue

Change-Id: I11b4b3433b818f45958f69f45d8172c580073a53
Signed-off-by: Lisa Seeto 

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1891425

Title:
  Reset configurable theme to default causing warning and loss of styles

Status in Mahara:
  Fix Committed

Bug description:
  It is possible to set a configurable theme for an institution that
  will itself have a default configuration of pre-set colours.  It is
  possible to configure a new theme, save it and then select "Reset" to
  return to the default pre-set theme values.  Currently, a warning is
  being produced and Mahara is losing its styling.

  To reproduce:
  1. Have an institution and log in with an admin member
  2. Edit the institution settings and select "Configurable Theme" from the 
Theme drop-down
  3. Set the theme values to any other colour via colour picker or hex value, 
save
  4. The site should update with the newly configured theme, select to edit the 
institution again
  5. return to the Theme settings and set "Reset colours" to "yes", save the 
page.
  Expected result:
  The theme is returned to the default configurable theme configuration
  Actual result:
  All Mahara styling is lost, a warning is produced:

  Institution updated successfully.  Others will see the new theme the next 
time they log in.
  [WAR] 72 (lib/web.php:90) array_merge(): Argument #2 is not an array
  Call stack (most recent first):

  log_message("array_merge(): Argument #2 is not an array", 8, true, true, 
"/home/lisaseeto/code/mahara-test/htdocs/lib/web.ph...", 90) at 
/home/lisaseeto/code/mahara-test/htdocs/lib/errors.php:521
  error(2, "array_merge(): Argument #2 is not an array", 
"/home/lisaseeto/code/mahara-test/htdocs/lib/web.ph...", 90, array(size 11)) at 
Unknown:0
  array_merge(array(size 2), null) at 
/home/lisaseeto/code/mahara-test/htdocs/lib/web.php:90
  get_stylesheets_for_current_page(array(size 2), array(size 0)) at 
/home/lisaseeto/code/mahara-test/htdocs/lib/web.php:646
  smarty(array(size 2)) at 
/home/lisaseeto/code/mahara-test/htdocs/admin/users/institutions.php:716

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1891425/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1891946] Re: Behat: Comment rating, license and attachment

2020-08-17 Thread Rebecca Blundell
** Description changed:

  Automating manual test. Test from spreadsheet is below:
  
  Pre req: Site Admin has turned on comment ratings and license metadata.
  Set make public to Yes and verify License field, Licensor and Original
  URL fields are displayed.
  
- Add comment and click window sizer icon then add rating. 
- Attach feedback file into the files area and click Add attachment to add 
another file then click comment button or click cancel. Author receives 
Notification  
+ Add comment and click window sizer icon then add rating.
+ Attach feedback file into the files area and click Add attachment to add 
another file then click comment button or click cancel. Author receives 
Notification
  
  NB: Comment ratings is turned on in Extensions->Plugin adminstration->Comment
  License is turned on in Site options->Site settings->License metadata
  (But perhaps these can be turned on in the background).
  
  I have no idea what is meant by the 'window sizer' icon. Perhaps this is
  no longer relevant. If you know what it means, test it, otherwise
  ignore.
  
  We need at least 2 users for this:
  UserA has a page which is visible to UserB.
  UserB comments on the page, using the rating, attaching a file and filling in 
the license field and url.
- UserA gets notified of the comment, can see the attachment and the rating. If 
they go to Files they should have a commentfiles folder including the attached 
file. Following the edit option for the file should show all the file 
information. Note that the license information isn't currently seen in these 
places. This will be reported as a separate bug (if it is one, tbc).
+ UserA gets notified of the comment, can see the attachment and the rating. If 
they go to Files they should have a commentfiles folder including the attached 
file. Following the edit option for the file should show all the file 
information. Note that the license information isn't currently displayed, so we 
are not checking for it.

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1891946

Title:
  Behat: Comment rating, license and attachment

Status in Mahara:
  New

Bug description:
  Automating manual test. Test from spreadsheet is below:

  Pre req: Site Admin has turned on comment ratings and license
  metadata. Set make public to Yes and verify License field, Licensor
  and Original URL fields are displayed.

  Add comment and click window sizer icon then add rating.
  Attach feedback file into the files area and click Add attachment to add 
another file then click comment button or click cancel. Author receives 
Notification

  NB: Comment ratings is turned on in Extensions->Plugin adminstration->Comment
  License is turned on in Site options->Site settings->License metadata
  (But perhaps these can be turned on in the background).

  I have no idea what is meant by the 'window sizer' icon. Perhaps this
  is no longer relevant. If you know what it means, test it, otherwise
  ignore.

  We need at least 2 users for this:
  UserA has a page which is visible to UserB.
  UserB comments on the page, using the rating, attaching a file and filling in 
the license field and url.
  UserA gets notified of the comment, can see the attachment and the rating. If 
they go to Files they should have a commentfiles folder including the attached 
file. Following the edit option for the file should show all the file 
information. Note that the license information isn't currently displayed, so we 
are not checking for it.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1891946/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1891939] Re: Instituion static page edit not disabled

2020-08-17 Thread Cecilia Vela Gurovic
when upgrading to TinyMCE 5, on commit ada3e2cd6f87c8d22980f28ffe0dc957308796aa
on the file theme/raw/sass/lib/_tinymce.scss
the mce-tinymce class from the editor is changed to tox-tinymce

we should remove the references from the code to mce-tinymce class in the 
jQuery selector and styles
since they won't return any object.

other places to check:

Make sure the tinyMCE editor is visible when is located inside a modal,
for example when editing a text blocktype, an dit has the correct width
on the rest of the places we use tinymce


** Changed in: mahara
   Importance: Undecided => Medium

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1891939

Title:
  Instituion static page edit not disabled

Status in Mahara:
  In Progress

Bug description:
  Should not allow to edit an institution static page while the 'Use
  site default' is set to yes

  To test
  - Have an institution
  - Go to Admin menu -> Institutions -> static pages
  - Set 'Use site default' to yes

  expected result: the tinyMCE editor is greyed out and you are not allowed to 
make changes
  actual result: the tinyMCE editor is enabled

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1891939/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1891939] A patch has been submitted for review

2020-08-17 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/11149

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1891939

Title:
  Instituion static page edit not disabled

Status in Mahara:
  In Progress

Bug description:
  Should not allow to edit an institution static page while the 'Use
  site default' is set to yes

  To test
  - Have an institution
  - Go to Admin menu -> Institutions -> static pages
  - Set 'Use site default' to yes

  expected result: the tinyMCE editor is greyed out and you are not allowed to 
make changes
  actual result: the tinyMCE editor is enabled

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1891939/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1891946] [NEW] Behat: Comment rating, license and attachment

2020-08-17 Thread Rebecca Blundell
Public bug reported:

Automating manual test. Test from spreadsheet is below:

Pre req: Site Admin has turned on comment ratings and license metadata.
Set make public to Yes and verify License field, Licensor and Original
URL fields are displayed.

Add comment and click window sizer icon then add rating. 
Attach feedback file into the files area and click Add attachment to add 
another file then click comment button or click cancel. Author receives 
Notification  

NB: Comment ratings is turned on in Extensions->Plugin adminstration->Comment
License is turned on in Site options->Site settings->License metadata
(But perhaps these can be turned on in the background).

I have no idea what is meant by the 'window sizer' icon. Perhaps this is
no longer relevant. If you know what it means, test it, otherwise
ignore.

We need at least 2 users for this:
UserA has a page which is visible to UserB.
UserB comments on the page, using the rating, attaching a file and filling in 
the license field and url.
UserA gets notified of the comment, can see the attachment and the rating. If 
they go to Files they should have a commentfiles folder including the attached 
file. Following the edit option for the file should show all the file 
information. Note that the license information isn't currently seen in these 
places. This will be reported as a separate bug (if it is one, tbc).

** Affects: mahara
 Importance: Undecided
 Assignee: Rangi Daymond (rangid)
 Status: New


** Tags: behat-test

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1891946

Title:
  Behat: Comment rating, license and attachment

Status in Mahara:
  New

Bug description:
  Automating manual test. Test from spreadsheet is below:

  Pre req: Site Admin has turned on comment ratings and license
  metadata. Set make public to Yes and verify License field, Licensor
  and Original URL fields are displayed.

  Add comment and click window sizer icon then add rating. 
  Attach feedback file into the files area and click Add attachment to add 
another file then click comment button or click cancel. Author receives 
Notification  

  NB: Comment ratings is turned on in Extensions->Plugin adminstration->Comment
  License is turned on in Site options->Site settings->License metadata
  (But perhaps these can be turned on in the background).

  I have no idea what is meant by the 'window sizer' icon. Perhaps this
  is no longer relevant. If you know what it means, test it, otherwise
  ignore.

  We need at least 2 users for this:
  UserA has a page which is visible to UserB.
  UserB comments on the page, using the rating, attaching a file and filling in 
the license field and url.
  UserA gets notified of the comment, can see the attachment and the rating. If 
they go to Files they should have a commentfiles folder including the attached 
file. Following the edit option for the file should show all the file 
information. Note that the license information isn't currently seen in these 
places. This will be reported as a separate bug (if it is one, tbc).

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1891946/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1890369] A patch has been submitted for review

2020-08-17 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/11148

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1890369

Title:
  Upgrade: HTML Purifier 4.12.0 to 4.13.0

Status in Mahara:
  In Progress

Bug description:
  Related to https://bugs.launchpad.net/mahara/+bug/1865115

  Upgrading HTML Purifier from 4.12.0 to 4.13.0:

  https://github.com/ezyang/htmlpurifier/blob/v4.13.0/NEWS

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1890369/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1890369] Re: Upgrade: HTML Purifier 4.12.0 to 4.13.0

2020-08-17 Thread Lisa Seeto
** Changed in: mahara
 Assignee: (unassigned) => Lisa Seeto (lisaseeto)

** Changed in: mahara
   Status: New => In Progress

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1890369

Title:
  Upgrade: HTML Purifier 4.12.0 to 4.13.0

Status in Mahara:
  In Progress

Bug description:
  Related to https://bugs.launchpad.net/mahara/+bug/1865115

  Upgrading HTML Purifier from 4.12.0 to 4.13.0:

  https://github.com/ezyang/htmlpurifier/blob/v4.13.0/NEWS

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1890369/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1891941] [NEW] Correct inbox notifications for collection access

2020-08-17 Thread Kristina Hoeppner
Public bug reported:

This is a follow-on from bug #922911 and marked as high as new
functionality.

Please see the screenshot for additional information. The notification
is not correct when displayed via the Mahara inbox:

1. There is an indentation where there shouldn't be one. Or if there
were a bullet point, it should be displayed. When there is only one item
though, there shouldn't be a list, but just the item as lists start with
two items.

2. The text from 'See URL...' should not be in the inbox notification
but only in the email notification.

3. The 'More... ->' link should read 'Portfolio ->' instead and have an
accessible title that mentions the portfolio title.

** Affects: mahara
 Importance: High
 Status: Confirmed

** Attachment added: "shared_pages_notification.png"
   
https://bugs.launchpad.net/bugs/1891941/+attachment/540/+files/shared_pages_notification.png

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1891941

Title:
  Correct inbox notifications for collection access

Status in Mahara:
  Confirmed

Bug description:
  This is a follow-on from bug #922911 and marked as high as new
  functionality.

  Please see the screenshot for additional information. The notification
  is not correct when displayed via the Mahara inbox:

  1. There is an indentation where there shouldn't be one. Or if there
  were a bullet point, it should be displayed. When there is only one
  item though, there shouldn't be a list, but just the item as lists
  start with two items.

  2. The text from 'See URL...' should not be in the inbox notification
  but only in the email notification.

  3. The 'More... ->' link should read 'Portfolio ->' instead and have
  an accessible title that mentions the portfolio title.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1891941/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1891938] Re: Exclude submission to group for tutors and admins

2020-08-17 Thread Kristina Hoeppner
** Tags added: snack-sized

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1891938

Title:
  Exclude submission to group for tutors and admins

Status in Mahara:
  Confirmed

Bug description:
  When portfolio submissions are allowed in a group, the group
  portfolios block displays 'Members without a submission to the group'.
  That shows everyone, no matter whether group member, tutor, or admin.
  However, that is confusing because typically, admins and tutors
  wouldn't submit a portfolio to a group.

  It would be better to only allow regular group members to submit
  portfolios to a group and remove that capability for group admins and
  group tutors.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1891938/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1891939] [NEW] Instituion static page edit not disabled

2020-08-17 Thread Cecilia Vela Gurovic
Public bug reported:

Should not allow to edit an institution static page while the 'Use site
default' is set to yes

To test
- Have an institution
- Go to Admin menu -> Institutions -> static pages
- Set 'Use site default' to yes

expected result: the tinyMCE editor is greyed out and you are not allowed to 
make changes
actual result: the tinyMCE editor is enabled

** Affects: mahara
 Importance: Undecided
 Assignee: Cecilia Vela Gurovic (ceciliavg)
 Status: In Progress

** Description changed:

- Should not allow to edit an instituion static page while the 'Use site
+ Should not allow to edit an institution static page while the 'Use site
  default' is set to yes
  
  To test
  - Have an institution
- - Go to Afdmin menu -> Institutions -> static pages
+ - Go to Admin menu -> Institutions -> static pages
  - Set 'Use site default' to yes
  
- expected result: the tinyMCE editor is grayed out and you are not allowed to 
make changes
+ expected result: the tinyMCE editor is greyed out and you are not allowed to 
make changes
  actual result: the tinyMCE editor is enabled

** Changed in: mahara
Milestone: None => 20.10.0

** Changed in: mahara
 Assignee: (unassigned) => Cecilia Vela Gurovic (ceciliavg)

** Changed in: mahara
   Status: New => In Progress

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1891939

Title:
  Instituion static page edit not disabled

Status in Mahara:
  In Progress

Bug description:
  Should not allow to edit an institution static page while the 'Use
  site default' is set to yes

  To test
  - Have an institution
  - Go to Admin menu -> Institutions -> static pages
  - Set 'Use site default' to yes

  expected result: the tinyMCE editor is greyed out and you are not allowed to 
make changes
  actual result: the tinyMCE editor is enabled

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1891939/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1891940] [NEW] Correct time stamp in submission notification

2020-08-17 Thread Kristina Hoeppner
Public bug reported:

When you submit a portfolio to a group, you receive a notification
stating:

"This is to confirm that you submitted the collection "Title of the
collection" successfully to the group "Recertification 2020" at
18-08-2020, 08:49."

The time stamp is wrong and should have the regular format of 18 August
2020, 08:49.

** Affects: mahara
 Importance: Medium
 Status: Confirmed


** Tags: bite-sized

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1891940

Title:
  Correct time stamp in submission notification

Status in Mahara:
  Confirmed

Bug description:
  When you submit a portfolio to a group, you receive a notification
  stating:

  "This is to confirm that you submitted the collection "Title of the
  collection" successfully to the group "Recertification 2020" at
  18-08-2020, 08:49."

  The time stamp is wrong and should have the regular format of 18
  August 2020, 08:49.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1891940/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1891937] [NEW] Sign-off icon can still be clicked in version on the time line

2020-08-17 Thread Kristina Hoeppner
Public bug reported:

When you add a sign-off block to a page and add that to the time line,
you can still click the 'sign-off' icon as page owner and the pop-up
comes up. However, there is a grey overlay that doesn't allow you to
click anything, but there is no message saying that you can't click
elements in a version of a portfolio.

The only way to get back was to refresh the page. It would be better if
either buttons, icons, etc. weren't clickable at all or a pop-up message
displayed that stated that nothing can be clicked when attempting to
click since it is a version.

** Affects: mahara
 Importance: Medium
 Status: Confirmed


** Tags: timeline versioning

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1891937

Title:
  Sign-off icon can still be clicked in version on the time line

Status in Mahara:
  Confirmed

Bug description:
  When you add a sign-off block to a page and add that to the time line,
  you can still click the 'sign-off' icon as page owner and the pop-up
  comes up. However, there is a grey overlay that doesn't allow you to
  click anything, but there is no message saying that you can't click
  elements in a version of a portfolio.

  The only way to get back was to refresh the page. It would be better
  if either buttons, icons, etc. weren't clickable at all or a pop-up
  message displayed that stated that nothing can be clicked when
  attempting to click since it is a version.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1891937/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1891938] [NEW] Exclude submission to group for tutors and admins

2020-08-17 Thread Kristina Hoeppner
Public bug reported:

When portfolio submissions are allowed in a group, the group portfolios
block displays 'Members without a submission to the group'. That shows
everyone, no matter whether group member, tutor, or admin. However, that
is confusing because typically, admins and tutors wouldn't submit a
portfolio to a group.

It would be better to only allow regular group members to submit
portfolios to a group and remove that capability for group admins and
group tutors.

** Affects: mahara
 Importance: Wishlist
 Status: Confirmed


** Tags: groups submission

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1891938

Title:
  Exclude submission to group for tutors and admins

Status in Mahara:
  Confirmed

Bug description:
  When portfolio submissions are allowed in a group, the group
  portfolios block displays 'Members without a submission to the group'.
  That shows everyone, no matter whether group member, tutor, or admin.
  However, that is confusing because typically, admins and tutors
  wouldn't submit a portfolio to a group.

  It would be better to only allow regular group members to submit
  portfolios to a group and remove that capability for group admins and
  group tutors.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1891938/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp