[Mahara-contributors] [Bug 1891949] Re: sign off block height on gridstack

2020-08-19 Thread Cecilia Vela Gurovic
** Changed in: mahara/20.10
   Status: Confirmed => In Progress

** Changed in: mahara/20.10
 Assignee: (unassigned) => Cecilia Vela Gurovic (ceciliavg)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1891949

Title:
  sign off block height on gridstack

Status in Mahara:
  In Progress
Status in Mahara 19.10 series:
  New
Status in Mahara 20.04 series:
  New
Status in Mahara 20.10 series:
  In Progress

Bug description:
  The sign off block content is very different when editing the page from when 
viewing the page. This makes the block have a lot of extra space when viewing 
the page. We can make the height be predefined for viewsing since it will 
always have the same content, it can only have
  Sign off / Verify lines
  or
  Sign off alone

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1891949/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1891941] A patch has been submitted for review

2020-08-19 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/11160

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1891941

Title:
  Correct inbox notifications for collection access

Status in Mahara:
  In Progress

Bug description:
  This is a follow-on from bug #922911 and marked as high as new
  functionality.

  Please see the screenshot for additional information. The notification
  is not correct when displayed via the Mahara inbox:

  1. There is an indentation where there shouldn't be one. Or if there
  were a bullet point, it should be displayed. When there is only one
  item though, there shouldn't be a list, but just the item as lists
  start with two items.

  2. The text from 'See URL...' should not be in the inbox notification
  but only in the email notification.

  3. The 'More... ->' link should read 'Portfolio ->' instead and have
  an accessible title that mentions the portfolio title.

  4. The notification should start with 'You have been given access to'
  but not repeat the subject.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1891941/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1892103] Re: Cover image file selector defaults to png

2020-08-19 Thread Cecilia Vela Gurovic
I can't replicate this error.
I even checked the code and I can see in the settigns of the form we are 
allowing  'jpg' and 'png'.
on htdocs/view/editlayout.php line 421 on master branch

...
'accept'   => 'image/jpg,image/png',
...

** Changed in: mahara
   Status: Confirmed => Incomplete

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1892103

Title:
  Cover image file selector defaults to png

Status in Mahara:
  Incomplete

Bug description:
  When you want to upload a cover image to a page or collection, the
  file browser automatically defaults to png even though jpg is possible
  to use as well. If we restrict the file type, then jpg should be
  included.

  To replicate:

  1. Create a page.
  2. In the 'Advanced settings', click the 'Add a file' button. The file 
selector is displayed.
  3. Click the 'Browse' button instead of selecting an already uploaded picture.
  Expected result: I can see png and jpg files.
  Actual result: I only see png.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1892103/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1892103] Re: Cover image file selector defaults to png

2020-08-19 Thread Cecilia Vela Gurovic
** Changed in: mahara
 Assignee: (unassigned) => Cecilia Vela Gurovic (ceciliavg)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1892103

Title:
  Cover image file selector defaults to png

Status in Mahara:
  Confirmed

Bug description:
  When you want to upload a cover image to a page or collection, the
  file browser automatically defaults to png even though jpg is possible
  to use as well. If we restrict the file type, then jpg should be
  included.

  To replicate:

  1. Create a page.
  2. In the 'Advanced settings', click the 'Add a file' button. The file 
selector is displayed.
  3. Click the 'Browse' button instead of selecting an already uploaded picture.
  Expected result: I can see png and jpg files.
  Actual result: I only see png.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1892103/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1892254] Re: Only SAML auth instance for metadata not active but can still see metadata choice on IdP discovery page

2020-08-19 Thread Cecilia Vela Gurovic
** Changed in: mahara
   Status: In Progress => Fix Committed

** Changed in: mahara
 Assignee: (unassigned) => Robert Lyon (robertl-9)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1892254

Title:
  Only SAML auth instance for metadata not active but can still see
  metadata choice on IdP discovery page

Status in Mahara:
  Fix Committed

Bug description:
  If we have the following:

  A site with a couple of institutions (Institution1 and Institution2)
  each having a SAML auth instance with different metadata (say IdP1 and
  IdP2)

  If Instance2 sets it's saml auth to not be active then we shouldn't
  expect to see the auth option on the IdP Discovery page (
  auth/saml/index.php  )

  We need to adjust the discovery page to only show the IdP's that are
  being used by 1 or more active SAML instances.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1892254/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1892254] A change has been merged

2020-08-19 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/11158
Committed: 
https://git.mahara.org/mahara/mahara/commit/599740ae944fe305081136b39d251c7e634c683d
Submitter: Cecilia Vela Gurovic (cecili...@catalyst.net.nz)
Branch:master

commit 599740ae944fe305081136b39d251c7e634c683d
Author: Robert Lyon 
Date:   Thu Aug 20 09:20:14 2020 +1200

Bug 1892254: Only show active instance IdPs on discovery page

If we have more metadata options than we need - we should not show the
extra ones

Change-Id: I506c1ebfd9764a66dffb0b5128ee680ffbe82046
Signed-off-by: Robert Lyon 

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1892254

Title:
  Only SAML auth instance for metadata not active but can still see
  metadata choice on IdP discovery page

Status in Mahara:
  Fix Committed

Bug description:
  If we have the following:

  A site with a couple of institutions (Institution1 and Institution2)
  each having a SAML auth instance with different metadata (say IdP1 and
  IdP2)

  If Instance2 sets it's saml auth to not be active then we shouldn't
  expect to see the auth option on the IdP Discovery page (
  auth/saml/index.php  )

  We need to adjust the discovery page to only show the IdP's that are
  being used by 1 or more active SAML instances.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1892254/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1892286] [NEW] Behat: Review peer_assessment.feature and confirm coverage

2020-08-19 Thread Rebecca Blundell
Public bug reported:

The regression spreadsheet has the following test:

Peers can perform a blind review of a portfolio authors skills and
competencies when the “Peer assessment” block is on a page. They are not
able to see any content of the person they are assessing. Peer
assessments can be saved as drafts before making them available to the
portfolio author and others

More info about new functionality found here
https://bugs.launchpad.net/mahara/+bug/1784778
https://bugs.launchpad.net/mahara/+bug/1784781


Please review /user_content/peer_assessment.feature and see whether the above 
functionality is covered. 
1. Update this bug with any changes that need to be made.
2. Update the spreadsheet with AT coverage.

** Affects: mahara
 Importance: Undecided
 Assignee: Rangi Daymond (rangid)
 Status: New


** Tags: behat-test

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1892286

Title:
  Behat: Review peer_assessment.feature and confirm coverage

Status in Mahara:
  New

Bug description:
  The regression spreadsheet has the following test:

  Peers can perform a blind review of a portfolio authors skills and
  competencies when the “Peer assessment” block is on a page. They are
  not able to see any content of the person they are assessing. Peer
  assessments can be saved as drafts before making them available to the
  portfolio author and others

  More info about new functionality found here
  https://bugs.launchpad.net/mahara/+bug/1784778
  https://bugs.launchpad.net/mahara/+bug/1784781

  
  Please review /user_content/peer_assessment.feature and see whether the above 
functionality is covered. 
  1. Update this bug with any changes that need to be made.
  2. Update the spreadsheet with AT coverage.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1892286/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1892283] [NEW] Behat: Write test for datepicker

2020-08-19 Thread Rebecca Blundell
Public bug reported:

Automating a manual test. This is from Bug 1744191: The date picker is
updated with the bootstrap-datepicker. However that original bug is for
code to update the file browser consistently across the site, so is not
specifically related to the datepicker. What we need here is a test for
the basic functionality of the datepicker.


1. User logged in
2. User browse to Main menu > Content > Resume
3. Confirm that the date is in the same format as when created using the old 
date picker ✔
4. Confirm the date picker is displayed when the user clicks inside the date 
field ✔
5. Confirm the user can enter a date by typing in a date using the keyboard ✔
6. Confirm the user can change a day inside the date picker by clicking the 
adjacent number in the calendar ✔
7. Confirm the user can change the month by
 a. Clicking the forward > icon ✔
 b. Clicking the month and year located in centre of modal window at the top ✔
 c. Confirm months are now displayed instead of days and year is displayed in 
centre of modal window at the top ✔
8. Confirm the user can change the year inside the date picker by clicking the 
month and year located in centre of modal window at the top ✔
9. Confirm years are now displayed instead of days and a year range is 
displayed in centre of modal window at the top ✔
10. Confirm the user can delete the date by clicking the trash can icon ✔

** Affects: mahara
 Importance: Undecided
 Assignee: Rangi Daymond (rangid)
 Status: New


** Tags: behat-test

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1892283

Title:
  Behat: Write test for datepicker

Status in Mahara:
  New

Bug description:
  Automating a manual test. This is from Bug 1744191: The date picker is
  updated with the bootstrap-datepicker. However that original bug is
  for code to update the file browser consistently across the site, so
  is not specifically related to the datepicker. What we need here is a
  test for the basic functionality of the datepicker.

  
  1. User logged in
  2. User browse to Main menu > Content > Resume
  3. Confirm that the date is in the same format as when created using the old 
date picker ✔
  4. Confirm the date picker is displayed when the user clicks inside the date 
field ✔
  5. Confirm the user can enter a date by typing in a date using the keyboard ✔
  6. Confirm the user can change a day inside the date picker by clicking the 
adjacent number in the calendar ✔
  7. Confirm the user can change the month by
   a. Clicking the forward > icon ✔
   b. Clicking the month and year located in centre of modal window at the top ✔
   c. Confirm months are now displayed instead of days and year is displayed in 
centre of modal window at the top ✔
  8. Confirm the user can change the year inside the date picker by clicking 
the month and year located in centre of modal window at the top ✔
  9. Confirm years are now displayed instead of days and a year range is 
displayed in centre of modal window at the top ✔
  10. Confirm the user can delete the date by clicking the trash can icon ✔

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1892283/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1892277] [NEW] Behat: Smart Evidence - review automated and manual tests

2020-08-19 Thread Rebecca Blundell
Public bug reported:

In the regression spreadsheet, there are the following items:

1. Change SE framework via matrix   
Collection page>Annotation>click on different SE framework  

2. Change SE framework via Page 
Portfolio>Page>Edit page> Annotation>Standard drop down menu>click on different 
SE framework


I wasn't sure exactly what needs to be tested here, but we should be
able to add more SmartEvidence tests to Behat as needed.

I suggest reviewing the current SE tests of which there are several:
/site_features/install_framework.feature
/site_features/annotation_and_smartevidence.feature
/site_features/institution_smartevidence.feature
/site_features/smart_evidence_editor.feature
/site_features/smart_evidence_workflow.feature

1. After confirming what is tested and what still needs to be covered, create 
bug reports for adding new functionality to behat.
2. Update the spreadsheet to reference any changes made so that we do not 
revisit this again later.

** Affects: mahara
 Importance: Undecided
 Assignee: Rangi Daymond (rangid)
 Status: New


** Tags: behat-test

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1892277

Title:
  Behat: Smart Evidence - review automated and manual tests

Status in Mahara:
  New

Bug description:
  In the regression spreadsheet, there are the following items:

  1. Change SE framework via matrix 
  Collection page>Annotation>click on different SE framework  

  2. Change SE framework via Page   
  Portfolio>Page>Edit page> Annotation>Standard drop down menu>click on 
different SE framework


  I wasn't sure exactly what needs to be tested here, but we should be
  able to add more SmartEvidence tests to Behat as needed.

  I suggest reviewing the current SE tests of which there are several:
  /site_features/install_framework.feature
  /site_features/annotation_and_smartevidence.feature
  /site_features/institution_smartevidence.feature
  /site_features/smart_evidence_editor.feature
  /site_features/smart_evidence_workflow.feature

  1. After confirming what is tested and what still needs to be covered, create 
bug reports for adding new functionality to behat.
  2. Update the spreadsheet to reference any changes made so that we do not 
revisit this again later.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1892277/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1891955] A change has been merged

2020-08-19 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/11150
Committed: 
https://git.mahara.org/mahara/mahara/commit/fac6e1414b3c5ebbac881a0407daff20d19b69b1
Submitter: Cecilia Vela Gurovic (cecili...@catalyst.net.nz)
Branch:master

commit fac6e1414b3c5ebbac881a0407daff20d19b69b1
Author: Rangi Daymond 
Date:   Tue Aug 18 13:37:33 2020 +1200

Bug: 1891955 Behat: rename versioning.feature to timeline.feature

Change-Id: I5070d4b87b5b9b5cbf0b2bc1ab23f849ff220aa5

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1891955

Title:
  Behat: rename versioning.feature->timeline.feature

Status in Mahara:
  Fix Committed

Bug description:
  Let's change the name of this test to make it more obvious what it does:
  versioning.feature->timeline.feature

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1891955/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1891955] Re: Behat: rename versioning.feature->timeline.feature

2020-08-19 Thread Cecilia Vela Gurovic
** Changed in: mahara
Milestone: None => 20.10.0

** Changed in: mahara
   Status: In Progress => Fix Committed

** Changed in: mahara
   Importance: Undecided => Critical

** Changed in: mahara
   Importance: Critical => Low

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1891955

Title:
  Behat: rename versioning.feature->timeline.feature

Status in Mahara:
  Fix Committed

Bug description:
  Let's change the name of this test to make it more obvious what it does:
  versioning.feature->timeline.feature

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1891955/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1892265] [NEW] Add to behat an after step check to see if there is an error call stack

2020-08-19 Thread Robert Lyon
Public bug reported:

Currently we can do 
And I should not see "Call stack"

But it would be better to have some fast way of checking after every
step if a callstack error has been generated

But rather than check the DOM (which will be slow) we could have the
lib/error.php set a session flag to check for.

Also we might not want to throw behat error / make it a failed step but
just alert us to the fact that backtrace has been generated so we can
check if it's valid or not

** Affects: mahara
 Importance: Wishlist
 Status: New

** Changed in: mahara
   Importance: Undecided => Wishlist

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1892265

Title:
  Add to behat an after step check to see if there is an error call
  stack

Status in Mahara:
  New

Bug description:
  Currently we can do 
  And I should not see "Call stack"

  But it would be better to have some fast way of checking after every
  step if a callstack error has been generated

  But rather than check the DOM (which will be slow) we could have the
  lib/error.php set a session flag to check for.

  Also we might not want to throw behat error / make it a failed step
  but just alert us to the fact that backtrace has been generated so we
  can check if it's valid or not

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1892265/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1891844] Re: ajax loaded blocks not resizing properly

2020-08-19 Thread Robert Lyon
** Changed in: mahara/20.04
   Status: New => Confirmed

** Changed in: mahara/19.10
   Status: New => Confirmed

** Changed in: mahara/19.04
   Status: New => Confirmed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1891844

Title:
  ajax loaded blocks not resizing properly

Status in Mahara:
  In Progress
Status in Mahara 19.04 series:
  Confirmed
Status in Mahara 19.10 series:
  Confirmed
Status in Mahara 20.04 series:
  Confirmed
Status in Mahara 20.10 series:
  In Progress

Bug description:
  need to wait until ajax loaded blocks have finish loading, to trigger
  gridstack load resize

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1891844/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1892256] Re: Undefined variable: duplicates error when updating SAML metadata in SAML instance

2020-08-19 Thread Robert Lyon
** Changed in: mahara
   Importance: Medium => High

** Also affects: mahara/19.10
   Importance: Undecided
   Status: New

** Also affects: mahara/20.10
   Importance: High
   Status: In Progress

** Also affects: mahara/19.04
   Importance: Undecided
   Status: New

** Also affects: mahara/20.04
   Importance: Undecided
   Status: New

** Changed in: mahara/20.04
   Importance: Undecided => High

** Changed in: mahara/19.10
   Importance: Undecided => High

** Changed in: mahara/19.04
   Importance: Undecided => High

** Changed in: mahara/20.04
Milestone: None => 20.04.2

** Changed in: mahara/19.10
Milestone: None => 19.10.5

** Changed in: mahara/19.04
Milestone: None => 19.04.7

** Changed in: mahara/20.04
   Status: New => Confirmed

** Changed in: mahara/19.10
   Status: New => Confirmed

** Changed in: mahara/19.04
   Status: New => Confirmed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1892256

Title:
  Undefined variable: duplicates error when updating SAML metadata in
  SAML instance

Status in Mahara:
  In Progress
Status in Mahara 19.04 series:
  Confirmed
Status in Mahara 19.10 series:
  Confirmed
Status in Mahara 20.04 series:
  Confirmed
Status in Mahara 20.10 series:
  In Progress

Bug description:
  This is because we can't chain the db query result and finding the
  resultant object value in the same "if" statement

  We need to break this down into testable parts

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1892256/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1892256] A patch has been submitted for review

2020-08-19 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/11159

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1892256

Title:
  Undefined variable: duplicates error when updating SAML metadata in
  SAML instance

Status in Mahara:
  In Progress
Status in Mahara 19.04 series:
  Confirmed
Status in Mahara 19.10 series:
  Confirmed
Status in Mahara 20.04 series:
  Confirmed
Status in Mahara 20.10 series:
  In Progress

Bug description:
  This is because we can't chain the db query result and finding the
  resultant object value in the same "if" statement

  We need to break this down into testable parts

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1892256/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1892256] [NEW] Undefined variable: duplicates error when updating SAML metadata in SAML instance

2020-08-19 Thread Robert Lyon
Public bug reported:

This is because we can't chain the db query result and finding the
resultant object value in the same "if" statement

We need to break this down into testable parts

** Affects: mahara
 Importance: High
 Status: In Progress

** Affects: mahara/19.04
 Importance: High
 Status: Confirmed

** Affects: mahara/19.10
 Importance: High
 Status: Confirmed

** Affects: mahara/20.04
 Importance: High
 Status: Confirmed

** Affects: mahara/20.10
 Importance: High
 Status: In Progress

** Changed in: mahara
   Status: New => In Progress

** Changed in: mahara
   Importance: Undecided => Medium

** Changed in: mahara
Milestone: None => 20.10.0

** Summary changed:

- Error when updating SAML metadata in SAML instance
+ Undefined variable: duplicates error when updating SAML metadata in SAML 
instance

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1892256

Title:
  Undefined variable: duplicates error when updating SAML metadata in
  SAML instance

Status in Mahara:
  In Progress
Status in Mahara 19.04 series:
  Confirmed
Status in Mahara 19.10 series:
  Confirmed
Status in Mahara 20.04 series:
  Confirmed
Status in Mahara 20.10 series:
  In Progress

Bug description:
  This is because we can't chain the db query result and finding the
  resultant object value in the same "if" statement

  We need to break this down into testable parts

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1892256/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1891955] Re: Behat: rename versioning.feature->timeline.feature

2020-08-19 Thread Cecilia Vela Gurovic
** Changed in: mahara
   Status: Fix Committed => In Progress

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1891955

Title:
  Behat: rename versioning.feature->timeline.feature

Status in Mahara:
  In Progress

Bug description:
  Let's change the name of this test to make it more obvious what it does:
  versioning.feature->timeline.feature

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1891955/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1892106] Re: Allow webservices external apps to show configuration options based on functions it contains

2020-08-19 Thread Robert Lyon
** Changed in: mahara
   Status: New => In Progress

** Changed in: mahara
   Importance: Undecided => Wishlist

** Changed in: mahara
Milestone: None => 20.10.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1892106

Title:
  Allow webservices external apps to show configuration options based on
  functions it contains

Status in Mahara:
  In Progress

Bug description:
  Currently the LTI module has the ability to configure the following 2 options:
  - autocreateusers
  - parentauth

  And they are used in the module_lti_launch function.

  But if we make a custom webservice and include module_lti_launch as
  one of it's services we have no way (apart from directly on database)
  to set these options

  Currently the webservice/admin/oauthv1sregister.php page shows the config cog 
if a module has 
  has_oauth_service_config() set to true and displays the config form via 
get_oauth_service_config_options()

  But what we should have is some code that checks if the webservice
  contains functions that have config options and then display the
  button / form

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1892106/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1892254] A patch has been submitted for review

2020-08-19 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/11158

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1892254

Title:
  Only SAML auth instance for metadata not active but can still see
  metadata choice on IdP discovery page

Status in Mahara:
  In Progress

Bug description:
  If we have the following:

  A site with a couple of institutions (Institution1 and Institution2)
  each having a SAML auth instance with different metadata (say IdP1 and
  IdP2)

  If Instance2 sets it's saml auth to not be active then we shouldn't
  expect to see the auth option on the IdP Discovery page (
  auth/saml/index.php  )

  We need to adjust the discovery page to only show the IdP's that are
  being used by 1 or more active SAML instances.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1892254/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1892254] Re: Only SAML auth instance for metadata not active but can still see metadata choice on IdP discovery page

2020-08-19 Thread Robert Lyon
** Changed in: mahara
   Status: Confirmed => In Progress

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1892254

Title:
  Only SAML auth instance for metadata not active but can still see
  metadata choice on IdP discovery page

Status in Mahara:
  In Progress

Bug description:
  If we have the following:

  A site with a couple of institutions (Institution1 and Institution2)
  each having a SAML auth instance with different metadata (say IdP1 and
  IdP2)

  If Instance2 sets it's saml auth to not be active then we shouldn't
  expect to see the auth option on the IdP Discovery page (
  auth/saml/index.php  )

  We need to adjust the discovery page to only show the IdP's that are
  being used by 1 or more active SAML instances.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1892254/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1892254] [NEW] Only SAML auth instance for metadata not active but can still see metadata choice on IdP discovery page

2020-08-19 Thread Robert Lyon
Public bug reported:

If we have the following:

A site with a couple of institutions (Institution1 and Institution2)
each having a SAML auth instance with different metadata (say IdP1 and
IdP2)

If Instance2 sets it's saml auth to not be active then we shouldn't
expect to see the auth option on the IdP Discovery page (
auth/saml/index.php  )

We need to adjust the discovery page to only show the IdP's that are
being used by 1 or more active SAML instances.

** Affects: mahara
 Importance: Wishlist
 Status: Confirmed


** Tags: idp saml

** Changed in: mahara
   Importance: High => Wishlist

** Changed in: mahara
Milestone: None => 20.10.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1892254

Title:
  Only SAML auth instance for metadata not active but can still see
  metadata choice on IdP discovery page

Status in Mahara:
  Confirmed

Bug description:
  If we have the following:

  A site with a couple of institutions (Institution1 and Institution2)
  each having a SAML auth instance with different metadata (say IdP1 and
  IdP2)

  If Instance2 sets it's saml auth to not be active then we shouldn't
  expect to see the auth option on the IdP Discovery page (
  auth/saml/index.php  )

  We need to adjust the discovery page to only show the IdP's that are
  being used by 1 or more active SAML instances.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1892254/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp