date:20200824

Patch for "master" branch: https://reviews.mahara.org/11180

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1886614

Title:
  SmartEvidence framework editor improvements

Status in Mahara:
  In Progress

Bug description:
  There are still some improvements to do on the SmartEvidence framework
  editor

  So far we could be fixing the layout so we don't have a huge form to
  edit the framework, that makes it confusing and too hard to handle

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1886614/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1892655] Re: need to escape mysql keyword 'row' in gridstacklayout.js

2020-08-24 Thread Cecilia Vela Gurovic

** Changed in: mahara/20.10
 Assignee: (unassigned) => Cecilia Vela Gurovic (ceciliavg)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1892655

Title:
  need to escape mysql keyword 'row' in gridstacklayout.js

Status in Mahara:
  In Progress
Status in Mahara 19.10 series:
  New
Status in Mahara 20.04 series:
  New
Status in Mahara 20.10 series:
  In Progress

Bug description:
  or it will fail the translation process from old layout pages to new
  grisdtack layout

  the words 'row' and 'rows' became reserved words in MySQL 8.0.2

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1892655/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1892426] Re: Help icon text missing in certain file browser modals

** Changed in: mahara
   Status: Confirmed => In Progress

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1892426

Title:
  Help icon text missing in certain file browser modals

Status in Mahara:
  In Progress

Bug description:
  When you add an attachment to a journal entry or to 'Goals and skills'
  in the resume or add a cover image, the help icons for the license
  metadata do not display the actual help text. It's always using the
  same method.

  To replicate:

  1. Turn on 'License metadata' in 'Configure site' -> 'Site options'.
  2. Create a journal entry.
  3. Click the 'Add a file' button under 'Attachments'.
  4. Click one of the three help icons.
  Expected result: The help text is displayed.
  Actual result: Error message is displayed.

  5. Go to 'Goals and skills' in the resume.
  6. Edit one of the goals.
  7. Click the 'Add a file' button under 'Attachments'.
  8. Click one of the three help icons.
  Expected result: The help text is displayed.
  Actual result: Error message is displayed.

  Once implemented, check that the help icon text still displays
  correctly for the following:

  a) Main menu -> Create -> Files
  b) in the block 'File(s) to download'

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1892426/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1892426] Re: Help icon text missing in certain file browser modals

** Changed in: mahara
 Assignee: (unassigned) => Lisa Seeto (lisaseeto)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1892426

Title:
  Help icon text missing in certain file browser modals

Status in Mahara:
  Confirmed

Bug description:
  When you add an attachment to a journal entry or to 'Goals and skills'
  in the resume or add a cover image, the help icons for the license
  metadata do not display the actual help text. It's always using the
  same method.

  To replicate:

  1. Turn on 'License metadata' in 'Configure site' -> 'Site options'.
  2. Create a journal entry.
  3. Click the 'Add a file' button under 'Attachments'.
  4. Click one of the three help icons.
  Expected result: The help text is displayed.
  Actual result: Error message is displayed.

  5. Go to 'Goals and skills' in the resume.
  6. Edit one of the goals.
  7. Click the 'Add a file' button under 'Attachments'.
  8. Click one of the three help icons.
  Expected result: The help text is displayed.
  Actual result: Error message is displayed.

  Once implemented, check that the help icon text still displays
  correctly for the following:

  a) Main menu -> Create -> Files
  b) in the block 'File(s) to download'

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1892426/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1883803] A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/11179

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1883803

Title:
  Missing Help Text Icon: admin/site/menu.php

Status in Mahara:
  In Progress

Bug description:
  The Help icons are missing for "External link" and "Site file" on the
  "Menus" page (admin/site/menu.php) Admin menu -> Configure site ->
  Menus.

  To replicate:
  1. Log into Mahara as a site admin
  2. Navigate to the Menus page: Admin menu -> Configure Site -> Menus
  3. Set the Keyboard focus to the the radio button for "External link"
  4. Navigate the keyboard focus (tab once) and press enter
  5. Observe that the pop-up for the help text for "External link" will appear 
but does not have a help icon to distinguish it
  This happens with "Site file" as well.

  Another issue, is that when the cursor is hovered over the "External
  link" and "Site files" it changes to the cursor associated with
  mousing over links.

  Versions: Mahara 20.04, 19.10 19.04

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1883803/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1883803] Re: Missing Help Text Icon: admin/site/menu.php

** Changed in: mahara
 Assignee: (unassigned) => Lisa Seeto (lisaseeto)

** Changed in: mahara
   Status: Triaged => In Progress

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1883803

Title:
  Missing Help Text Icon: admin/site/menu.php

Status in Mahara:
  In Progress

Bug description:
  The Help icons are missing for "External link" and "Site file" on the
  "Menus" page (admin/site/menu.php) Admin menu -> Configure site ->
  Menus.

  To replicate:
  1. Log into Mahara as a site admin
  2. Navigate to the Menus page: Admin menu -> Configure Site -> Menus
  3. Set the Keyboard focus to the the radio button for "External link"
  4. Navigate the keyboard focus (tab once) and press enter
  5. Observe that the pop-up for the help text for "External link" will appear 
but does not have a help icon to distinguish it
  This happens with "Site file" as well.

  Another issue, is that when the cursor is hovered over the "External
  link" and "Site files" it changes to the cursor associated with
  mousing over links.

  Versions: Mahara 20.04, 19.10 19.04

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1883803/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1857010] Re: Mahara page tag search optimization

Hi Kevin,

A patch was created so that queries to the table goes faster:

https://reviews.mahara.org/#/c/11096/

You could test to see if this patch solves the issue.

Kind regards,
Lisa

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1857010

Title:
  Mahara page tag search optimization

Status in Mahara:
  Confirmed

Bug description:
  Mahara Version: 19.04.3
  DB Version: MySQL 5.1
  Reporting: Optimization

  Issue:
  The search function '(Title, description, tags)' on the 'pages and 
collections' page is slow when there are large numbers of tags and if that user 
has many pages/collections.
  This is not an issue with version: Mahara 18.04.5

  Details:
  For Mahara 19.04.3 I have 166,618 entries in the 'mah_tag' table and my user 
has 200 pages.
  When doing a search with (Title, description, tags) selected it takes about 
15 seconds for the search.

  For Mahara 18.04.5 I have 139,877 entries in the 'mah_view_tag' table and my 
user has 200 pages.
  When doing a search with (Title, description, tags) selected it takes less 
than a second for the search.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1857010/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1873119] Re: Artefact comments are they appearing in HTML / PDF exports

** Changed in: mahara
Milestone: 20.10.0 => 21.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1873119

Title:
  Artefact comments are they appearing in HTML / PDF exports

Status in Mahara:
  Confirmed

Bug description:
  If they are appearing in HTML export in a modal then we need to get
  them to appear in PDF a different way (probably appended to base of
  artefact)

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1873119/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1836687] Re: Tinymce uses different fonts than bootstrap

Evonne is changing heading levels. Let's get those through first.

** Changed in: mahara
Milestone: 20.10.0 => 21.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1836687

Title:
  Tinymce uses different fonts than bootstrap

Status in Mahara:
  Confirmed

Bug description:
  The tinymce editor does not use the same font family or weight as the
  rest of mahara

  To replicate:
  1. go to a page with a tinymce editor, eg a page with a comment block
  2. enter text into the editor

  expected result: font styles should be the same as mahara
  actual result: font styles are different

  see attached screenshot

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1836687/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1810438] Re: Files are removed from the timeline when deleted

** Changed in: mahara
Milestone: 20.10.0 => 21.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1810438

Title:
  Files are removed from the timeline when deleted

Status in Mahara:
  Confirmed

Bug description:
  When a file is placed on a page, e.g. via the "Files to download"
  block and the state saved to the timeline, it does not appear on the
  timeline once the file has been deleted from the Files area though it
  should still appear on the Timeline.

  1. User A has a page with the "Image" block and the "Files to download" 
block. The download block contains both the image and also another file.
  2. User A saves that state to the timeline.
  3. User A deletes the image that is used in the "Image" block and the "Files 
to download" block from their file repository.
  Expected result: The image is still displayed in the timeline.
  Actual result: The image is not displayed in the timeline neither in the 
"Image" block nor the "Files to download" block thus not rendering it a true 
respresentation of the state of that page at that time.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1810438/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1890349] Re: SAML auth update user issues

** Changed in: mahara/20.10
   Status: Confirmed => In Progress

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1890349

Title:
  SAML auth update user issues

Status in Mahara:
  In Progress
Status in Mahara 20.04 series:
  Confirmed
Status in Mahara 20.10 series:
  In Progress

Bug description:
  Currently if you have a user in Mahara that logs in via SAML and has
  update user option set then their admin/staff status is updated. If
  this info is not being passed in via SAML from IdP it means they are
  updated to be normal members.

  We should only do this updating if any of the SAML instance settings are set 
for:
  - rolesiteadmin
  - rolesitestaff
  - roleinstadmin
  - roleinststaff

  And if the particular one is not set to ignore updating this part of
  the user's profile

  Also we need to check that the following is correct
   if ($institutionrole == 'admin') {
   $institution->addUserAsStaff($user);
   }

  Should it be  $institution->addUserAsAdmin($user);

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1890349/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1892794] Re: Allow local custom profile fields also be accessible via webservices

2020-08-24 Thread Cecilia Vela Gurovic

** Summary changed:

- Allow local custom profile fileds  also be accessible via webservices
+ Allow local custom profile fields  also be accessible via webservices

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1892794

Title:
  Allow local custom profile fields  also be accessible via webservices

Status in Mahara:
  In Progress

Bug description:
  What is wanted:

  Have the mahara_user_external.php webservice function be able to set /
  fetch the information for local custom fields.

  Currently we have to hardcode in the extra fields in the _parameters()
  or _returns() functions

  It would be better if the local/lib/artefact_internal.php had a
  function to call to fetch webservice info for the local profile fields

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1892794/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1892794] Re: Allow local custom profile fileds also be accessible via webservices

2020-08-24 Thread Robert Lyon

So in your local/lib/artefact_internal.php file you would need something
like so:

class PluginArtefactInternalLocal extends PluginArtefactInternal {

public static function get_artefact_types() {
return array(
'cat',
'dog',
);
}

public static function get_profile_artefact_types() {
  return array(
  'cat',
  'dog',
  );
}

public static function get_contactinfo_artefact_types() {
  return array(
  'cat',
  'dog',
  );
}

public static function get_webservice_options() {
  return array(
  'cat' => new external_value(PARAM_TEXT, 'Cat name', 
VALUE_OPTIONAL),
  'dog' => new external_value(PARAM_TEXT, 'Dog name', 
VALUE_OPTIONAL),
  );
}
}

class ArtefactTypeProfileLocal extends ArtefactTypeProfile {
public static function get_all_fields() {
$out = array(
'cat' => 'text',
'dog' => 'text',
);
return $out;
}
}

class ArtefactTypeCat extends ArtefactTypeProfileField {}
class ArtefactTypeDog extends ArtefactTypeProfileField {}


** Changed in: mahara
Milestone: None => 20.10.0

** Changed in: mahara
   Status: New => In Progress

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1892794

Title:
  Allow local custom profile fileds  also be accessible via webservices

Status in Mahara:
  In Progress

Bug description:
  What is wanted:

  Have the mahara_user_external.php webservice function be able to set /
  fetch the information for local custom fields.

  Currently we have to hardcode in the extra fields in the _parameters()
  or _returns() functions

  It would be better if the local/lib/artefact_internal.php had a
  function to call to fetch webservice info for the local profile fields

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1892794/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1892794] A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/11178

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1892794

Title:
  Allow local custom profile fileds  also be accessible via webservices

Status in Mahara:
  In Progress

Bug description:
  What is wanted:

  Have the mahara_user_external.php webservice function be able to set /
  fetch the information for local custom fields.

  Currently we have to hardcode in the extra fields in the _parameters()
  or _returns() functions

  It would be better if the local/lib/artefact_internal.php had a
  function to call to fetch webservice info for the local profile fields

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1892794/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1892794] [NEW] Allow local custom profile fileds also be accessible via webservices

2020-08-24 Thread Robert Lyon

Public bug reported:

What is wanted:

Have the mahara_user_external.php webservice function be able to set /
fetch the information for local custom fields.

Currently we have to hardcode in the extra fields in the _parameters()
or _returns() functions

It would be better if the local/lib/artefact_internal.php had a function
to call to fetch webservice info for the local profile fields

** Affects: mahara
 Importance: Wishlist
 Status: In Progress

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1892794

Title:
  Allow local custom profile fileds  also be accessible via webservices

Status in Mahara:
  In Progress

Bug description:
  What is wanted:

  Have the mahara_user_external.php webservice function be able to set /
  fetch the information for local custom fields.

  Currently we have to hardcode in the extra fields in the _parameters()
  or _returns() functions

  It would be better if the local/lib/artefact_internal.php had a
  function to call to fetch webservice info for the local profile fields

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1892794/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1876185] Re: Allow redis function without needing sentinel

** Tags added: nominatedfeature

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1876185

Title:
  Allow redis function without needing sentinel

Status in Mahara:
  Fix Committed

Bug description:
  When redis was set up in mahara it was envisioned to be used with
  redis sentinel in a cluster situation

  But we should also allow redis to be usable without sentinel

  Looking at the code we probably need to adjust the get_redis_master()
  and get_redis_servers() functions in htdocs/auth/lib.php

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1876185/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1892790] A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/11177

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1892790

Title:
  Google Apps Block unable to parse URL to google drive folder

Status in Mahara:
  In Progress

Bug description:
  Google Drive URLs aren't parsed correctly any more and don't display
  the Google Drive folder icon (or whatever needs to be displayed).

  For example, the folder https://drive.google.com/drive/folders/0B-V_s
  ... 00Y2JmLTkwNjUtZGM0ODJiZGNjYWEy has been shared publicly but on
  MyPortfolio (and also master) it only displays:

  "Unable to parse embedded code or URL:
  https://drive.google.com/drive/folders/0B-V_s ...
  0Y2JmLTkwNjUtZGM0ODJiZGNjYWEy"

  To replicate:
  1. Log in and create a page and select to create a "Google Apps" block
  2. In the "Embed code or URL" put the above url and save the block.
  Expected results:
  The block displays with icon etc... correctly
  Actual results:
  The block displays with "Unable to parse embedded code or URL: 
https://drive.google.com/drive/folders/0B-V_s9Ys157uZmFkY2RlOWMtNGY4Yy00Y2JmLTkwNjUtZGM0ODJiZGNjYWEy
 "

  Our regex is failing to parse this pattern and we'll need to add to it
  while keeping any necessary previous patterns for backwards
  compatibility.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1892790/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1892428] A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/11176

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1892428

Title:
  Turn peer role into configurable role so it can see content

Status in Mahara:
  In Progress

Bug description:
  It shall be possible for a peer to see the portfolio content.
  Currently, Mahara does not allow someone with the 'Peer' role to see
  the content of the portfolio pages to which the peer has access to.
  This is restrictive for some organisations. Therefore, we are going to
  turn it into an institution setting so that an institution
  administrator can determine how that role shall behave.

  Since this is an assessment feature that may be more often then not be
  determined by an organisation rather than individuals, it is best to
  make it an institution setting and not require the decision to be made
  on each individual peer block.

  We propose to create a new institution setting 'Allow peers to see
  portfolio content' for the peer role with the two possible states:

  1. Can't see any content but can create peer assessment (the current setting)
  2. Can see the entire portfolio and can create peer assessment

  This setting decides what the peer assessor can do when they are
  commenting on a portfolio in that particular institution.

  More details as determined with Cecilia:

  1. A new field will be added to institution settings.

  If set to 'Yes': if the portfolio owner belongs to this institution,
  all account holders that have peer role access to that portfolio will
  be able to see the block contents.

  For multiple institutions: If the owner of the portfolio belongs to
  more than one institution, then the most restrictive rule will apply.
  In other words, if an account holder has peer access to a portfolio,
  they will be able to see the block content only if all the
  institutions the owner belongs to have this setting set to 'Yes'.

  Default value will be 'No'. This will be saved on the
  'institution_config' table on the DB.

  This new field could be placed just below 'Allow public institution
  portfolios'.

  Field name: Allow peers to see portfolio content

  Description: Allow account holders who receive the 'Peer' role on a
  portfolio to see the entire content in the portfolio.

  Help file text: The 'Peer' role is only available for portfolio
  access. If it is set to 'No', the peer can only see the block headings
  on pages on which peer assessments are required. On pages where there
  is no peer assessment, they will not be able to see anything. If an
  account holder has the role of 'Peer and manager', they can always see
  the entire portfolio, no matter this setting here.

  2.Accessing a portfolio by a peer

  The check to see whether a peer can see the block content or not will
  be done when rendering a block instance (on view display).

  This change can be done in the PluginBlocktype class, by adding a code
  to the display_for_roles function. This is the function that defines
  if the block should display content or not.

  If an account holder has more than one portfolio access role, then the more 
permissive one counts, e.g. account holder has
  a) Peer role with access to content in one institution and peer role without 
access to content in another institution: Can't see content (see 1 above)
  b) Peer role without access to content and manager role, i.e. 'Peer and 
manager', then they can see the content on the portfolio because the manager 
role is more permissive and thus counts.
  b) Peer role with access to content and manager role: Can see content

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1892428/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1892790] [NEW] Google Apps Block unable to parse URL to google drive folder

Public bug reported:

Google Drive URLs aren't parsed correctly any more and don't display the
Google Drive folder icon (or whatever needs to be displayed).

For example, the folder https://drive.google.com/drive/folders/0B-V_s
... 00Y2JmLTkwNjUtZGM0ODJiZGNjYWEy has been shared publicly but on
MyPortfolio (and also master) it only displays:

"Unable to parse embedded code or URL:
https://drive.google.com/drive/folders/0B-V_s ...
0Y2JmLTkwNjUtZGM0ODJiZGNjYWEy"

To replicate:
1. Log in and create a page and select to create a "Google Apps" block
2. In the "Embed code or URL" put the above url and save the block.
Expected results:
The block displays with icon etc... correctly
Actual results:
The block displays with "Unable to parse embedded code or URL:
https://drive.google.com/drive/folders/0B-V_s9Ys157uZmFkY2RlOWMtNGY4Yy00Y2JmLTkwNjUtZGM0ODJiZGNjYWEy
"

Our regex is failing to parse this pattern and we'll need to add to it
while keeping any necessary previous patterns for backwards
compatibility.

** Affects: mahara
Importance: Undecided
Assignee: Lisa Seeto (lisaseeto)
Status: In Progress

--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1892790

Title:
Google Apps Block unable to parse URL to google drive folder

Status in Mahara:
In Progress

Bug description:
Google Drive URLs aren't parsed correctly any more and don't display
the Google Drive folder icon (or whatever needs to be displayed).

For example, the folder https://drive.google.com/drive/folders/0B-V_s
... 00Y2JmLTkwNjUtZGM0ODJiZGNjYWEy has been shared publicly but on
MyPortfolio (and also master) it only displays:

"Unable to parse embedded code or URL:
https://drive.google.com/drive/folders/0B-V_s ...
0Y2JmLTkwNjUtZGM0ODJiZGNjYWEy"

Our regex is failing to parse this pattern and we'll need to add to it
while keeping any necessary previous patterns for backwards
compatibility.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1892790/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1819379] A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/11175

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1819379

Title:
  update chromedriver for behat

Status in Mahara:
  Confirmed

Bug description:
  Given that there is an exploit for chrome versions below
  72.0.3626.121, we should update chromedriver to work with newer
  versions. (Our current version 2.38 is only compatible with chrome up
  to version 67). The chrome version on Jenkins will need to be updated
  to run with the new chromedriver.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1819379/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1892428] Re: Turn peer role into configurable role so it can see content

2020-08-24 Thread Cecilia Vela Gurovic

** Changed in: mahara
   Status: Confirmed => In Progress

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1892428

Title:
  Turn peer role into configurable role so it can see content

Status in Mahara:
  In Progress

Bug description:
  It shall be possible for a peer to see the portfolio content.
  Currently, Mahara does not allow someone with the 'Peer' role to see
  the content of the portfolio pages to which the peer has access to.
  This is restrictive for some organisations. Therefore, we are going to
  turn it into an institution setting so that an institution
  administrator can determine how that role shall behave.

  Since this is an assessment feature that may be more often then not be
  determined by an organisation rather than individuals, it is best to
  make it an institution setting and not require the decision to be made
  on each individual peer block.

  We propose to create a new institution setting 'Allow peers to see
  portfolio content' for the peer role with the two possible states:

  1. Can't see any content but can create peer assessment (the current setting)
  2. Can see the entire portfolio and can create peer assessment

  This setting decides what the peer assessor can do when they are
  commenting on a portfolio in that particular institution.

  More details as determined with Cecilia:

  1. A new field will be added to institution settings.

  If set to 'Yes': if the portfolio owner belongs to this institution,
  all account holders that have peer role access to that portfolio will
  be able to see the block contents.

  For multiple institutions: If the owner of the portfolio belongs to
  more than one institution, then the most restrictive rule will apply.
  In other words, if an account holder has peer access to a portfolio,
  they will be able to see the block content only if all the
  institutions the owner belongs to have this setting set to 'Yes'.

  Default value will be 'No'. This will be saved on the
  'institution_config' table on the DB.

  This new field could be placed just below 'Allow public institution
  portfolios'.

  Field name: Allow peers to see portfolio content

  Description: Allow account holders who receive the 'Peer' role on a
  portfolio to see the entire content in the portfolio.

  Help file text: The 'Peer' role is only available for portfolio
  access. If it is set to 'No', the peer can only see the block headings
  on pages on which peer assessments are required. On pages where there
  is no peer assessment, they will not be able to see anything. If an
  account holder has the role of 'Peer and manager', they can always see
  the entire portfolio, no matter this setting here.

  2.Accessing a portfolio by a peer

  The check to see whether a peer can see the block content or not will
  be done when rendering a block instance (on view display).

  This change can be done in the PluginBlocktype class, by adding a code
  to the display_for_roles function. This is the function that defines
  if the block should display content or not.

  If an account holder has more than one portfolio access role, then the more 
permissive one counts, e.g. account holder has
  a) Peer role with access to content in one institution and peer role without 
access to content in another institution: Can't see content (see 1 above)
  b) Peer role without access to content and manager role, i.e. 'Peer and 
manager', then they can see the content on the portfolio because the manager 
role is more permissive and thus counts.
  b) Peer role with access to content and manager role: Can see content

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1892428/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1890349] A patch has been submitted for review