[Mahara-contributors] [Bug 1892993] [NEW] Behat: Open sans default font in tinymce
Public bug reported: Automating manual test. Notes from spreadsheet (20.04 WIP): Verify “opensans” is default font 1) Account menu>Profile>Introduction 2) Main menu>Create>Pages and collections>Add>Page>Page description 3) Main menu>Create>Pages and collections>Add>Page>Add Text block>Content This check can be added anywhere there is a tinymce editor on the page. One example would be the edit_journal feature. Just make a note where you put with this bug number so we know why it's there. The steps are: And I click the "Toggle toolbars on. Show full list of buttons" button in the editor And I should see "Open sans" ** Affects: mahara Importance: Undecided Assignee: Rangi Daymond (rangid) Status: New ** Tags: behat-test -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1892993 Title: Behat: Open sans default font in tinymce Status in Mahara: New Bug description: Automating manual test. Notes from spreadsheet (20.04 WIP): Verify “opensans” is default font 1) Account menu>Profile>Introduction 2) Main menu>Create>Pages and collections>Add>Page>Page description 3) Main menu>Create>Pages and collections>Add>Page>Add Text block>Content This check can be added anywhere there is a tinymce editor on the page. One example would be the edit_journal feature. Just make a note where you put with this bug number so we know why it's there. The steps are: And I click the "Toggle toolbars on. Show full list of buttons" button in the editor And I should see "Open sans" To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1892993/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1892982] [NEW] Behat: Using email in tests
Public bug reported: We don't use email in behat, but apparently we could. Here are some links to the documentation: https://docs.behat.org/en/v2.5/cookbook/intercepting_the_redirections.html#implementing-interception-steps-logic https://docs.behat.org/en/v2.5/cookbook/using_the_profiler_with_minkbundle.html We could investigate whether its possible to implement the system they suggest in Mahara's behat. It would mean that we could automate more of the test suite. ** Affects: mahara Importance: Undecided Status: New ** Tags: behat-dev -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1892982 Title: Behat: Using email in tests Status in Mahara: New Bug description: We don't use email in behat, but apparently we could. Here are some links to the documentation: https://docs.behat.org/en/v2.5/cookbook/intercepting_the_redirections.html#implementing-interception-steps-logic https://docs.behat.org/en/v2.5/cookbook/using_the_profiler_with_minkbundle.html We could investigate whether its possible to implement the system they suggest in Mahara's behat. It would mean that we could automate more of the test suite. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1892982/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1891940] A patch has been submitted for review
Patch for "master" branch: https://reviews.mahara.org/11189 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1891940 Title: Correct time stamp in submission notification Status in Mahara: In Progress Bug description: When you submit a portfolio to a group, you receive a notification stating: "This is to confirm that you submitted the collection "Title of the collection" successfully to the group "Recertification 2020" at 18-08-2020, 08:49." The time stamp is wrong and should have the regular format of 18 August 2020, 08:49. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1891940/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1892106] Re: Allow webservices external apps to show configuration options based on functions it contains
** Changed in: mahara Assignee: (unassigned) => Robert Lyon (robertl-9) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1892106 Title: Allow webservices external apps to show configuration options based on functions it contains Status in Mahara: In Progress Bug description: Currently the LTI module has the ability to configure the following 2 options: - autocreateusers - parentauth And they are used in the module_lti_launch function. But if we make a custom webservice and include module_lti_launch as one of it's services we have no way (apart from directly on database) to set these options Currently the webservice/admin/oauthv1sregister.php page shows the config cog if a module has has_oauth_service_config() set to true and displays the config form via get_oauth_service_config_options() But what we should have is some code that checks if the webservice contains functions that have config options and then display the button / form To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1892106/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1891940] Re: Correct time stamp in submission notification
** Changed in: mahara Assignee: (unassigned) => Lisa Seeto (lisaseeto) ** Changed in: mahara Status: Confirmed => In Progress -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1891940 Title: Correct time stamp in submission notification Status in Mahara: In Progress Bug description: When you submit a portfolio to a group, you receive a notification stating: "This is to confirm that you submitted the collection "Title of the collection" successfully to the group "Recertification 2020" at 18-08-2020, 08:49." The time stamp is wrong and should have the regular format of 18 August 2020, 08:49. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1891940/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1891570] Re: Bar graph of blocktype counts to only show active blocks
** Changed in: mahara Assignee: (unassigned) => Robert Lyon (robertl-9) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1891570 Title: Bar graph of blocktype counts to only show active blocks Status in Mahara: In Progress Bug description: We should only show the top blocks that are active blocks To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1891570/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1891554] Re: Code to generate charjs bar graph is not correct
** Changed in: mahara Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1891554 Title: Code to generate charjs bar graph is not correct Status in Mahara: Fix Committed Bug description: The code in get_bar_graph_json() was not generating a bar graph correctly. Also made the option 'showlegendcallback' so we can turn off the legend when we don't need it Also made the Admin -> Report -> site overview page 'Most frequently used blocks in portfolio pages' list change from a list of top five to a horizontal bar graph of the top 10 To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1891554/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1891554] A change has been merged
Reviewed: https://reviews.mahara.org/11143 Committed: https://git.mahara.org/mahara/mahara/commit/f9d470152bd5babc167893e6997fb61bcfa243f0 Submitter: Cecilia Vela Gurovic (cecili...@catalyst.net.nz) Branch:master commit f9d470152bd5babc167893e6997fb61bcfa243f0 Author: Robert Lyon Date: Fri Aug 14 18:01:02 2020 +1200 Bug 1891554: fixing up how bargraphs ordering work Need to fetch actual top ten and not the first ten Also need to set the axis to start at 0 Change-Id: Iacd1cc527a29ffc0e1dfa1157285b3e5ba073b48 Signed-off-by: Robert Lyon -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1891554 Title: Code to generate charjs bar graph is not correct Status in Mahara: Fix Committed Bug description: The code in get_bar_graph_json() was not generating a bar graph correctly. Also made the option 'showlegendcallback' so we can turn off the legend when we don't need it Also made the Admin -> Report -> site overview page 'Most frequently used blocks in portfolio pages' list change from a list of top five to a horizontal bar graph of the top 10 To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1891554/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1892426] A patch has been submitted for review
Patch for "master" branch: https://reviews.mahara.org/11188 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1892426 Title: Help icon text missing in certain file browser modals Status in Mahara: In Progress Bug description: When you add an attachment to a journal entry or to 'Goals and skills' in the resume or add a cover image, the help icons for the license metadata do not display the actual help text. It's always using the same method. To replicate: 1. Turn on 'License metadata' in 'Configure site' -> 'Site options'. 2. Create a journal entry. 3. Click the 'Add a file' button under 'Attachments'. 4. Click one of the three help icons. Expected result: The help text is displayed. Actual result: Error message is displayed. 5. Go to 'Goals and skills' in the resume. 6. Edit one of the goals. 7. Click the 'Add a file' button under 'Attachments'. 8. Click one of the three help icons. Expected result: The help text is displayed. Actual result: Error message is displayed. Once implemented, check that the help icon text still displays correctly for the following: a) Main menu -> Create -> Files b) in the block 'File(s) to download' To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1892426/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1890349] Re: SAML auth update user issues
** Changed in: mahara/20.10
Assignee: (unassigned) => Robert Lyon (robertl-9)
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1890349
Title:
SAML auth update user issues
Status in Mahara:
In Progress
Status in Mahara 20.04 series:
Confirmed
Status in Mahara 20.10 series:
In Progress
Bug description:
Currently if you have a user in Mahara that logs in via SAML and has
update user option set then their admin/staff status is updated. If
this info is not being passed in via SAML from IdP it means they are
updated to be normal members.
We should only do this updating if any of the SAML instance settings are set
for:
- rolesiteadmin
- rolesitestaff
- roleinstadmin
- roleinststaff
And if the particular one is not set to ignore updating this part of
the user's profile
Also we need to check that the following is correct
if ($institutionrole == 'admin') {
$institution->addUserAsStaff($user);
}
Should it be $institution->addUserAsAdmin($user);
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1890349/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1892104] Re: Block config needs to mention what type of block it is
** Changed in: mahara Assignee: (unassigned) => Cecilia Vela Gurovic (ceciliavg) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1892104 Title: Block config needs to mention what type of block it is Status in Mahara: In Progress Bug description: Currently if we add a block to a page it is a 'placeholder' block When we choose another blocktype and save (without changing title) and then edit it again it is not obvious what type of block it is. We can normally tell by the fields shown but with peer assessment and text block they look very similar so can be confusing. If we delete the title and save the block and edit it again it shows what type of block it is. But it would be better if the block showed the blocktype in the heading bar when chosen / on edit all the time To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1892104/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1892256] Re: Undefined variable: duplicates error when updating SAML metadata in SAML instance
** Changed in: mahara/20.10 Assignee: (unassigned) => Robert Lyon (robertl-9) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1892256 Title: Undefined variable: duplicates error when updating SAML metadata in SAML instance Status in Mahara: In Progress Status in Mahara 19.04 series: Confirmed Status in Mahara 19.10 series: Confirmed Status in Mahara 20.04 series: Confirmed Status in Mahara 20.10 series: In Progress Bug description: This is because we can't chain the db query result and finding the resultant object value in the same "if" statement We need to break this down into testable parts To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1892256/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1891575] Re: LTI only giving access to the first page of a submitted collection
** Changed in: mahara Assignee: (unassigned) => Robert Lyon (robertl-9) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1891575 Title: LTI only giving access to the first page of a submitted collection Status in Mahara: In Progress Bug description: When accessing a collection via LTI submission we only get access to the first page as the url link contains the page id. What we need is to allow the person using that link to be able to access any page in the collection To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1891575/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1892104] A patch has been submitted for review
Patch for "master" branch: https://reviews.mahara.org/11187 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1892104 Title: Block config needs to mention what type of block it is Status in Mahara: In Progress Bug description: Currently if we add a block to a page it is a 'placeholder' block When we choose another blocktype and save (without changing title) and then edit it again it is not obvious what type of block it is. We can normally tell by the fields shown but with peer assessment and text block they look very similar so can be confusing. If we delete the title and save the block and edit it again it shows what type of block it is. But it would be better if the block showed the blocktype in the heading bar when chosen / on edit all the time To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1892104/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1874530] Re: extracting a zipped file's contents not working correctly
** Changed in: mahara Importance: Undecided => Medium ** Changed in: mahara Milestone: None => 20.10.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1874530 Title: extracting a zipped file's contents not working correctly Status in Mahara: In Progress Bug description: This page needs some fixing up, the current problems are: 1) The process bar is in the old css style and should be using the new colours and not have a scroll bar in it 2) The general layout of the page could use some tidying up as well 3) The extraction of files looks to work but there is no redirect back to files page (either automatically or via a button) To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1874530/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1892794] A patch has been submitted for review
Patch for "master" branch: https://reviews.mahara.org/11186 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1892794 Title: Allow local custom profile fields also be accessible via webservices Status in Mahara: In Progress Bug description: What is wanted: Have the mahara_user_external.php webservice function be able to set / fetch the information for local custom fields. Currently we have to hardcode in the extra fields in the _parameters() or _returns() functions It would be better if the local/lib/artefact_internal.php had a function to call to fetch webservice info for the local profile fields To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1892794/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1891266] Re: Behat: Confirm correct dashboard elements are present
** Description changed: Automating a manual test. Copied from spreadsheet: Verify default dashboard includes the following blocks: Latest pages, My pages, Inbox, Topics I’m following (Note these titles are out of date. We need to check the current titles) Verify user can add or remove blocks via edit dashboard For this we can add to the homepage_buttons.feature. I suggest renaming it to dashboard.feature and it can be the core test for items on that page. 1. Add a scenario called "Checking default blocks are displayed". 2. As the section commented "# check for bug 1493199 name changed from “Latest pages” to “Latest changes I can view”" includes a check for that, transfer it to the new scenario. 3. Add checks for the other defaults: Inbox Topics I am following My portfolios Watched pages 4. Follow "Edit dashboard" and confirm that the blocks all contain a "Remove block" option and that all except My portfolios contain a "Configure block" option. 5. Test that the configure modal opens for one of the blocks and that you can save a change. (Note that we are not interested in this test whether the options work.) 6. Test that you can delete one of the blocks 7. Return to the dashboard and confirm the block you deleted is not displayed. + + + ADDITIONAL CHECKS: + There is another manual test that checks a different block can be added to the dashboard. We can incorporate this test too. While editing the dashboard in 4. above, add a block. + In 7. confirm that the new block is displayed. (Let's use a block for this that isn't added elsewhere.) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1891266 Title: Behat: Confirm correct dashboard elements are present Status in Mahara: In Progress Bug description: Automating a manual test. Copied from spreadsheet: Verify default dashboard includes the following blocks: Latest pages, My pages, Inbox, Topics I’m following (Note these titles are out of date. We need to check the current titles) Verify user can add or remove blocks via edit dashboard For this we can add to the homepage_buttons.feature. I suggest renaming it to dashboard.feature and it can be the core test for items on that page. 1. Add a scenario called "Checking default blocks are displayed". 2. As the section commented "# check for bug 1493199 name changed from “Latest pages” to “Latest changes I can view”" includes a check for that, transfer it to the new scenario. 3. Add checks for the other defaults: Inbox Topics I am following My portfolios Watched pages 4. Follow "Edit dashboard" and confirm that the blocks all contain a "Remove block" option and that all except My portfolios contain a "Configure block" option. 5. Test that the configure modal opens for one of the blocks and that you can save a change. (Note that we are not interested in this test whether the options work.) 6. Test that you can delete one of the blocks 7. Return to the dashboard and confirm the block you deleted is not displayed. ADDITIONAL CHECKS: There is another manual test that checks a different block can be added to the dashboard. We can incorporate this test too. While editing the dashboard in 4. above, add a block. In 7. confirm that the new block is displayed. (Let's use a block for this that isn't added elsewhere.) To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1891266/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1892950] [NEW] Behat: Rename create_and_delete_menu_item.feature
Public bug reported: The test for 'Links and resources' is called create_and_delete_menu_item.feature which doesn't make sense. Rename it to links_and_resources.feature and at the same time review functionality. There is no automated test for public links and resources. This could be added. ** Affects: mahara Importance: Undecided Assignee: Rangi Daymond (rangid) Status: New ** Tags: behat-test -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1892950 Title: Behat: Rename create_and_delete_menu_item.feature Status in Mahara: New Bug description: The test for 'Links and resources' is called create_and_delete_menu_item.feature which doesn't make sense. Rename it to links_and_resources.feature and at the same time review functionality. There is no automated test for public links and resources. This could be added. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1892950/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1892948] A patch has been submitted for review
Patch for "master" branch: https://reviews.mahara.org/11185
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1892948
Title:
CSS Advanced options in Skin not allowing position tag
Status in Mahara:
In Progress
Bug description:
Since updating to CSS Tidy 1.7.1, it appears that some options for setting
custom CSS are not available.
To replicate:
1. Have option for skins in config.php set to true for the site (i.e.
$config->skins = true;)
2. Log into site and create a new skin (Create -> Skins -> Create skin)
3. Navigate to 'Advanced' tab and enter the following:
.pageheader {
position: absolute;
}
4. Save the skin. NB: Custom CSS changes are not reflected in the skin
preview.
5. Edit the skin and navigate to the Advanced tab and look at the custom CSS
Expected results:
The editor window contains:
.pageheader {
position: absolute;
}
Actual results:
.pageheader{
}
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1892948/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1892948] [NEW] CSS Advanced options in Skin not allowing position tag
Public bug reported:
Since updating to CSS Tidy 1.7.1, it appears that some options for setting
custom CSS are not available.
To replicate:
1. Have option for skins in config.php set to true for the site (i.e.
$config->skins = true;)
2. Log into site and create a new skin (Create -> Skins -> Create skin)
3. Navigate to 'Advanced' tab and enter the following:
.pageheader {
position: absolute;
}
4. Save the skin. NB: Custom CSS changes are not reflected in the skin preview.
5. Edit the skin and navigate to the Advanced tab and look at the custom CSS
Expected results:
The editor window contains:
.pageheader {
position: absolute;
}
Actual results:
.pageheader{
}
** Affects: mahara
Importance: Undecided
Assignee: Lisa Seeto (lisaseeto)
Status: In Progress
** Description changed:
Since updating to CSS Tidy 1.7.1, it appears that some options for setting
custom CSS are not available.
To replicate:
1. Have option for skins in config.php set to true for the site (i.e.
$config->skins = true;)
2. Log into site and create a new skin (Create -> Skins -> Create skin)
3. Navigate to 'Advanced' tab and enter the following:
.pageheader {
position: absolute;
}
4. Save the skin. NB: Custom CSS changes are not reflected in the skin
preview.
5. Edit the skin and navigate to the Advanced tab and look at the custom CSS
Expected results:
- The window contains:
+ The editor window contains:
.pageheader {
position: absolute;
}
Actual results:
.pageheader{
}
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1892948
Title:
CSS Advanced options in Skin not allowing position tag
Status in Mahara:
In Progress
Bug description:
Since updating to CSS Tidy 1.7.1, it appears that some options for setting
custom CSS are not available.
To replicate:
1. Have option for skins in config.php set to true for the site (i.e.
$config->skins = true;)
2. Log into site and create a new skin (Create -> Skins -> Create skin)
3. Navigate to 'Advanced' tab and enter the following:
.pageheader {
position: absolute;
}
4. Save the skin. NB: Custom CSS changes are not reflected in the skin
preview.
5. Edit the skin and navigate to the Advanced tab and look at the custom CSS
Expected results:
The editor window contains:
.pageheader {
position: absolute;
}
Actual results:
.pageheader{
}
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1892948/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1892105] Re: Cover image file not copied for institution collection
** Changed in: mahara Assignee: Rangi Daymond (rangid) => Cecilia Vela Gurovic (ceciliavg) ** Changed in: mahara Status: Confirmed => In Progress -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1892105 Title: Cover image file not copied for institution collection Status in Mahara: In Progress Bug description: When you have a collection on the institution level and add a cover image, the file is not associated when you copy it into your personal account. The file still comes along, but is not placed into the 'Cover images' folder. It nearly works fine for pages (see note below). This also needs to be tested for copying of collections on all other levels (personal, site, group). To replicate for institution collection: 1. As site or institution admin, create a collection with 1 page. 2. Upload a cover image to the collection. 3. Share the page and make it copyable. 4. Log in as another account holder. 5. Copy the collection. 6. View the collection on 'Pages and collections'. Expected result: The collection's cover image is displayed. Actual result: There is not cover image displayed. **Please note: When the above steps are 'repeated' for a page, the page cover image does display on the 'Pages and collections' page, however, the file is NOT present in the 'Files' > 'Cover images' folder. It is instead placed in a sub-folder of the 'viewfiles' folder, this sub-sub-folder also contains any other files that were present for the copied page. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1892105/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1892820] Re: Behat: Add "take a screenshot" step
** Description changed:
It might help our regression testing if we could add screenshot steps in
tests, so that a tester could run the test suite and afterwards check a
folder of screenshots to make sure that the pages look like they are
supposed to.
We can add a step to call the Mink saveScreenshot() function. This
works:
- /**
- * Save a screenshot for regression testing purposes
- *
- * @Then I take a screenshot as :filename
- */
- public function take_screenshot($filename) {
- if (!$this->running_javascript()) {
- return false;
- }
- $path = get_config('dataroot') . 'behat';
- $this->saveScreenshot($filename, $path);
- }
+ /**
+ * Save a screenshot for regression testing purposes
+ *
+ * @Then I take a screenshot as :filename
+ */
+ public function take_screenshot($filename) {
+ if (!$this->running_javascript()) {
+ return false;
+ }
+ $path = get_config('dataroot') . 'behat';
+ $this->saveScreenshot($filename, $path);
+ }
A limitation of the above is that only the part of the page that is visible
is captured. In Chrome dev-tools there is the following option:
https://www.howtogeek.com/423558/how-to-take-full-page-screenshots-in-google-chrome-without-using-an-extension/
- So now I wonder whether we could write a step to utilise that functionality
rather than calling saveScreenshot as above.
+ So now I wonder whether we could write a step to utilise that functionality
rather than calling saveScreenshot as above.
Things to consider:
Will these steps be slow?
Do we need to tag tests that use them in a different way, and only run when
regression testing is required? Or some other idea?
+
+
+ A couple of other things to consider:
+
+ This extension: https://github.com/elvetemedve/behat-screenshot. The
discussion suggests it does provide full page capture, but it seems people are
having trouble with it:
https://github.com/elvetemedve/behat-screenshot/issues/26
+
+ There is also this one, which says it bypasses selenium and uses chrome
+ directly with a reduction of overhead: https://gitlab.com/DMore/behat-
+ chrome-extension (this is probably heading out of scope for the
+ screenshot problem, but is an interesting idea, particularly as it
+ apparently reduces test time by at least 2/3rds.
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1892820
Title:
Behat: Add "take a screenshot" step
Status in Mahara:
Confirmed
Bug description:
It might help our regression testing if we could add screenshot steps
in tests, so that a tester could run the test suite and afterwards
check a folder of screenshots to make sure that the pages look like
they are supposed to.
We can add a step to call the Mink saveScreenshot() function. This
works:
/**
* Save a screenshot for regression testing purposes
*
* @Then I take a screenshot as :filename
*/
public function take_screenshot($filename) {
if (!$this->running_javascript()) {
return false;
}
$path = get_config('dataroot') . 'behat';
$this->saveScreenshot($filename, $path);
}
A limitation of the above is that only the part of the page that is visible
is captured. In Chrome dev-tools there is the following option:
https://www.howtogeek.com/423558/how-to-take-full-page-screenshots-in-google-chrome-without-using-an-extension/
So now I wonder whether we could write a step to utilise that functionality
rather than calling saveScreenshot as above.
Things to consider:
Will these steps be slow?
Do we need to tag tests that use them in a different way, and only run when
regression testing is required? Or some other idea?
A couple of other things to consider:
This extension: https://github.com/elvetemedve/behat-screenshot. The
discussion suggests it does provide full page capture, but it seems people are
having trouble with it:
https://github.com/elvetemedve/behat-screenshot/issues/26
There is also this one, which says it bypasses selenium and uses
chrome directly with a reduction of overhead: https://gitlab.com/DMore
/behat-chrome-extension (this is probably heading out of scope for the
screenshot problem, but is an interesting idea, particularly as it
apparently reduces test time by at least 2/3rds.
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1892820/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https:
[Mahara-contributors] [Bug 1883803] A patch has been submitted for review
Patch for "19.04_STABLE" branch: https://reviews.mahara.org/11184 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1883803 Title: Missing Help Text Icon: admin/site/menu.php Status in Mahara: Fix Committed Status in Mahara 19.04 series: Fix Committed Status in Mahara 19.10 series: Fix Committed Status in Mahara 20.04 series: Fix Committed Status in Mahara 20.10 series: Fix Committed Bug description: The Help icons are missing for "External link" and "Site file" on the "Menus" page (admin/site/menu.php) Admin menu -> Configure site -> Menus. To replicate: 1. Log into Mahara as a site admin 2. Navigate to the Menus page: Admin menu -> Configure Site -> Menus 3. Set the Keyboard focus to the the radio button for "External link" 4. Navigate the keyboard focus (tab once) and press enter 5. Observe that the pop-up for the help text for "External link" will appear but does not have a help icon to distinguish it This happens with "Site file" as well. Another issue, is that when the cursor is hovered over the "External link" and "Site files" it changes to the cursor associated with mousing over links. Versions: Mahara 20.04, 19.10 19.04 To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1883803/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1883803] A change has been merged
Reviewed: https://reviews.mahara.org/11179 Committed: https://git.mahara.org/mahara/mahara/commit/f8f78e8a685928f03ff757cb4306368e1e69bb99 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:master commit f8f78e8a685928f03ff757cb4306368e1e69bb99 Author: Lisa Seeto Date: Tue Aug 25 15:09:28 2020 +1200 Bug 1883803: Missing Help Text Icon: admin/site/menu.php - added in missing quotation mark Change-Id: I6de86ee38fe7a362294e770996177261818ed0bd Signed-off-by: Lisa Seeto -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1883803 Title: Missing Help Text Icon: admin/site/menu.php Status in Mahara: Fix Committed Status in Mahara 19.04 series: Fix Committed Status in Mahara 19.10 series: Fix Committed Status in Mahara 20.04 series: Fix Committed Status in Mahara 20.10 series: Fix Committed Bug description: The Help icons are missing for "External link" and "Site file" on the "Menus" page (admin/site/menu.php) Admin menu -> Configure site -> Menus. To replicate: 1. Log into Mahara as a site admin 2. Navigate to the Menus page: Admin menu -> Configure Site -> Menus 3. Set the Keyboard focus to the the radio button for "External link" 4. Navigate the keyboard focus (tab once) and press enter 5. Observe that the pop-up for the help text for "External link" will appear but does not have a help icon to distinguish it This happens with "Site file" as well. Another issue, is that when the cursor is hovered over the "External link" and "Site files" it changes to the cursor associated with mousing over links. Versions: Mahara 20.04, 19.10 19.04 To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1883803/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1883803] Re: Missing Help Text Icon: admin/site/menu.php
** Also affects: mahara/19.04 Importance: Undecided Status: New ** Also affects: mahara/20.10 Importance: Medium Assignee: Lisa Seeto (lisaseeto) Status: Fix Committed ** Also affects: mahara/20.04 Importance: Undecided Status: New ** Also affects: mahara/19.10 Importance: Undecided Status: New ** Changed in: mahara/20.04 Status: New => Fix Committed ** Changed in: mahara/19.10 Status: New => Fix Committed ** Changed in: mahara/19.04 Status: New => Fix Committed ** Changed in: mahara/19.04 Importance: Undecided => Medium ** Changed in: mahara/19.10 Importance: Undecided => Medium ** Changed in: mahara/20.04 Importance: Undecided => Medium ** Changed in: mahara/20.04 Milestone: None => 20.04.2 ** Changed in: mahara/19.10 Milestone: None => 19.10.5 ** Changed in: mahara/19.04 Milestone: None => 19.04.7 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1883803 Title: Missing Help Text Icon: admin/site/menu.php Status in Mahara: Fix Committed Status in Mahara 19.04 series: Fix Committed Status in Mahara 19.10 series: Fix Committed Status in Mahara 20.04 series: Fix Committed Status in Mahara 20.10 series: Fix Committed Bug description: The Help icons are missing for "External link" and "Site file" on the "Menus" page (admin/site/menu.php) Admin menu -> Configure site -> Menus. To replicate: 1. Log into Mahara as a site admin 2. Navigate to the Menus page: Admin menu -> Configure Site -> Menus 3. Set the Keyboard focus to the the radio button for "External link" 4. Navigate the keyboard focus (tab once) and press enter 5. Observe that the pop-up for the help text for "External link" will appear but does not have a help icon to distinguish it This happens with "Site file" as well. Another issue, is that when the cursor is hovered over the "External link" and "Site files" it changes to the cursor associated with mousing over links. Versions: Mahara 20.04, 19.10 19.04 To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1883803/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1883803] Re: Missing Help Text Icon: admin/site/menu.php
** Changed in: mahara Importance: Undecided => Medium ** Changed in: mahara Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1883803 Title: Missing Help Text Icon: admin/site/menu.php Status in Mahara: Fix Committed Status in Mahara 19.04 series: Fix Committed Status in Mahara 19.10 series: Fix Committed Status in Mahara 20.04 series: Fix Committed Status in Mahara 20.10 series: Fix Committed Bug description: The Help icons are missing for "External link" and "Site file" on the "Menus" page (admin/site/menu.php) Admin menu -> Configure site -> Menus. To replicate: 1. Log into Mahara as a site admin 2. Navigate to the Menus page: Admin menu -> Configure Site -> Menus 3. Set the Keyboard focus to the the radio button for "External link" 4. Navigate the keyboard focus (tab once) and press enter 5. Observe that the pop-up for the help text for "External link" will appear but does not have a help icon to distinguish it This happens with "Site file" as well. Another issue, is that when the cursor is hovered over the "External link" and "Site files" it changes to the cursor associated with mousing over links. Versions: Mahara 20.04, 19.10 19.04 To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1883803/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1883803] A change has been merged
Reviewed: https://reviews.mahara.org/11183 Committed: https://git.mahara.org/mahara/mahara/commit/4d152d4c0c0f5d627c481ccec6fef572d551150d Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:19.10_STABLE commit 4d152d4c0c0f5d627c481ccec6fef572d551150d Author: Lisa Seeto Date: Tue Aug 25 15:09:28 2020 +1200 Bug 1883803: Missing Help Text Icon: admin/site/menu.php - added in missing quotation mark Change-Id: I6de86ee38fe7a362294e770996177261818ed0bd Signed-off-by: Lisa Seeto (cherry picked from commit f8f78e8a685928f03ff757cb4306368e1e69bb99) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1883803 Title: Missing Help Text Icon: admin/site/menu.php Status in Mahara: Fix Committed Status in Mahara 19.04 series: Fix Committed Status in Mahara 19.10 series: Fix Committed Status in Mahara 20.04 series: Fix Committed Status in Mahara 20.10 series: Fix Committed Bug description: The Help icons are missing for "External link" and "Site file" on the "Menus" page (admin/site/menu.php) Admin menu -> Configure site -> Menus. To replicate: 1. Log into Mahara as a site admin 2. Navigate to the Menus page: Admin menu -> Configure Site -> Menus 3. Set the Keyboard focus to the the radio button for "External link" 4. Navigate the keyboard focus (tab once) and press enter 5. Observe that the pop-up for the help text for "External link" will appear but does not have a help icon to distinguish it This happens with "Site file" as well. Another issue, is that when the cursor is hovered over the "External link" and "Site files" it changes to the cursor associated with mousing over links. Versions: Mahara 20.04, 19.10 19.04 To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1883803/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1883803] A patch has been submitted for review
Patch for "20.04_STABLE" branch: https://reviews.mahara.org/11182 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1883803 Title: Missing Help Text Icon: admin/site/menu.php Status in Mahara: Fix Committed Status in Mahara 19.04 series: Fix Committed Status in Mahara 19.10 series: Fix Committed Status in Mahara 20.04 series: Fix Committed Status in Mahara 20.10 series: Fix Committed Bug description: The Help icons are missing for "External link" and "Site file" on the "Menus" page (admin/site/menu.php) Admin menu -> Configure site -> Menus. To replicate: 1. Log into Mahara as a site admin 2. Navigate to the Menus page: Admin menu -> Configure Site -> Menus 3. Set the Keyboard focus to the the radio button for "External link" 4. Navigate the keyboard focus (tab once) and press enter 5. Observe that the pop-up for the help text for "External link" will appear but does not have a help icon to distinguish it This happens with "Site file" as well. Another issue, is that when the cursor is hovered over the "External link" and "Site files" it changes to the cursor associated with mousing over links. Versions: Mahara 20.04, 19.10 19.04 To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1883803/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1883803] A patch has been submitted for review
Patch for "19.10_STABLE" branch: https://reviews.mahara.org/11183 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1883803 Title: Missing Help Text Icon: admin/site/menu.php Status in Mahara: Fix Committed Status in Mahara 19.04 series: Fix Committed Status in Mahara 19.10 series: Fix Committed Status in Mahara 20.04 series: Fix Committed Status in Mahara 20.10 series: Fix Committed Bug description: The Help icons are missing for "External link" and "Site file" on the "Menus" page (admin/site/menu.php) Admin menu -> Configure site -> Menus. To replicate: 1. Log into Mahara as a site admin 2. Navigate to the Menus page: Admin menu -> Configure Site -> Menus 3. Set the Keyboard focus to the the radio button for "External link" 4. Navigate the keyboard focus (tab once) and press enter 5. Observe that the pop-up for the help text for "External link" will appear but does not have a help icon to distinguish it This happens with "Site file" as well. Another issue, is that when the cursor is hovered over the "External link" and "Site files" it changes to the cursor associated with mousing over links. Versions: Mahara 20.04, 19.10 19.04 To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1883803/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1883803] A change has been merged
Reviewed: https://reviews.mahara.org/11182 Committed: https://git.mahara.org/mahara/mahara/commit/59ae6daebd208d9701ce67491e915c53ae3e3fbf Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:20.04_STABLE commit 59ae6daebd208d9701ce67491e915c53ae3e3fbf Author: Lisa Seeto Date: Tue Aug 25 15:09:28 2020 +1200 Bug 1883803: Missing Help Text Icon: admin/site/menu.php - added in missing quotation mark Change-Id: I6de86ee38fe7a362294e770996177261818ed0bd Signed-off-by: Lisa Seeto (cherry picked from commit f8f78e8a685928f03ff757cb4306368e1e69bb99) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1883803 Title: Missing Help Text Icon: admin/site/menu.php Status in Mahara: Fix Committed Status in Mahara 19.04 series: Fix Committed Status in Mahara 19.10 series: Fix Committed Status in Mahara 20.04 series: Fix Committed Status in Mahara 20.10 series: Fix Committed Bug description: The Help icons are missing for "External link" and "Site file" on the "Menus" page (admin/site/menu.php) Admin menu -> Configure site -> Menus. To replicate: 1. Log into Mahara as a site admin 2. Navigate to the Menus page: Admin menu -> Configure Site -> Menus 3. Set the Keyboard focus to the the radio button for "External link" 4. Navigate the keyboard focus (tab once) and press enter 5. Observe that the pop-up for the help text for "External link" will appear but does not have a help icon to distinguish it This happens with "Site file" as well. Another issue, is that when the cursor is hovered over the "External link" and "Site files" it changes to the cursor associated with mousing over links. Versions: Mahara 20.04, 19.10 19.04 To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1883803/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1883803] A change has been merged
Reviewed: https://reviews.mahara.org/11184 Committed: https://git.mahara.org/mahara/mahara/commit/018cdcc084def62809645e5461aed27936a09bb2 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:19.04_STABLE commit 018cdcc084def62809645e5461aed27936a09bb2 Author: Lisa Seeto Date: Tue Aug 25 15:09:28 2020 +1200 Bug 1883803: Missing Help Text Icon: admin/site/menu.php - added in missing quotation mark Change-Id: I6de86ee38fe7a362294e770996177261818ed0bd Signed-off-by: Lisa Seeto (cherry picked from commit f8f78e8a685928f03ff757cb4306368e1e69bb99) (cherry picked from commit 4d152d4c0c0f5d627c481ccec6fef572d551150d) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1883803 Title: Missing Help Text Icon: admin/site/menu.php Status in Mahara: Fix Committed Status in Mahara 19.04 series: Fix Committed Status in Mahara 19.10 series: Fix Committed Status in Mahara 20.04 series: Fix Committed Status in Mahara 20.10 series: Fix Committed Bug description: The Help icons are missing for "External link" and "Site file" on the "Menus" page (admin/site/menu.php) Admin menu -> Configure site -> Menus. To replicate: 1. Log into Mahara as a site admin 2. Navigate to the Menus page: Admin menu -> Configure Site -> Menus 3. Set the Keyboard focus to the the radio button for "External link" 4. Navigate the keyboard focus (tab once) and press enter 5. Observe that the pop-up for the help text for "External link" will appear but does not have a help icon to distinguish it This happens with "Site file" as well. Another issue, is that when the cursor is hovered over the "External link" and "Site files" it changes to the cursor associated with mousing over links. Versions: Mahara 20.04, 19.10 19.04 To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1883803/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1892820] Re: Behat: Add "take a screenshot" step
** Changed in: mahara
Status: New => Confirmed
** Changed in: mahara
Importance: Undecided => Wishlist
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1892820
Title:
Behat: Add "take a screenshot" step
Status in Mahara:
Confirmed
Bug description:
It might help our regression testing if we could add screenshot steps
in tests, so that a tester could run the test suite and afterwards
check a folder of screenshots to make sure that the pages look like
they are supposed to.
We can add a step to call the Mink saveScreenshot() function. This
works:
/**
* Save a screenshot for regression testing purposes
*
* @Then I take a screenshot as :filename
*/
public function take_screenshot($filename) {
if (!$this->running_javascript()) {
return false;
}
$path = get_config('dataroot') . 'behat';
$this->saveScreenshot($filename, $path);
}
A limitation of the above is that only the part of the page that is visible
is captured. In Chrome dev-tools there is the following option:
https://www.howtogeek.com/423558/how-to-take-full-page-screenshots-in-google-chrome-without-using-an-extension/
So now I wonder whether we could write a step to utilise that functionality
rather than calling saveScreenshot as above.
Things to consider:
Will these steps be slow?
Do we need to tag tests that use them in a different way, and only run when
regression testing is required? Or some other idea?
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1892820/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1890369] Re: Upgrade: HTML Purifier 4.12.0 to 4.13.0
** Changed in: mahara Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1890369 Title: Upgrade: HTML Purifier 4.12.0 to 4.13.0 Status in Mahara: Fix Committed Bug description: Related to https://bugs.launchpad.net/mahara/+bug/1865115 Upgrading HTML Purifier from 4.12.0 to 4.13.0: https://github.com/ezyang/htmlpurifier/blob/v4.13.0/NEWS To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1890369/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1890369] A change has been merged
Reviewed: https://reviews.mahara.org/11148 Committed: https://git.mahara.org/mahara/mahara/commit/30eb58aa04cfbfaa7ecdddcc9c664ca20788d9de Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:master commit 30eb58aa04cfbfaa7ecdddcc9c664ca20788d9de Author: Lisa Seeto Date: Tue Aug 18 10:45:10 2020 +1200 Bug 1890369: Upgrade: HTML Purifier to 4.13.0 - upgrade according to README.Mahara instructions Change-Id: Ie55411435dda704164e7064bedee45bc3cb7feee Signed-off-by: Lisa Seeto -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1890369 Title: Upgrade: HTML Purifier 4.12.0 to 4.13.0 Status in Mahara: Fix Committed Bug description: Related to https://bugs.launchpad.net/mahara/+bug/1865115 Upgrading HTML Purifier from 4.12.0 to 4.13.0: https://github.com/ezyang/htmlpurifier/blob/v4.13.0/NEWS To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1890369/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
