[Mahara-contributors] [Bug 1894026] Re: exports: js files are fetched from the wrong dir in configurable theme

2020-09-02 Thread Cecilia Vela Gurovic
** Changed in: mahara
 Assignee: (unassigned) => Cecilia Vela Gurovic (ceciliavg)

** Changed in: mahara
   Importance: Undecided => Medium

** Changed in: mahara
   Status: New => In Progress

** Changed in: mahara
Milestone: None => 20.10.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1894026

Title:
  exports: js files are fetched from the wrong dir in configurable theme

Status in Mahara:
  In Progress

Bug description:
  when generating the 'All my data' export the html files created have
  the wrong path for the javascript files, if the logged in user
  exporting the data belongs to an institution using a configurable
  theme

  To replicate
  - have an institution with configurable theme set up
  - have a member of that institution and login as that user
  - go to User menu -> Manage -> Export
  - select 'All my data' and click on 'Generate export'
  - extract the downloaded .zip file is a local directory
  - open the HTML/index.html file
  - inspect the code in the browser

  Expected result: the path of the .js file, e.g. jquery.js, should be pointing 
to the HTML/static/theme/raw but the theme.js file that is located in 
HTML/static/theme/custom
  Actual result: the path of some of the .js file (not theme.js) starts with 
HTML/static/theme/custom

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1894026/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1893890] Re: html export complains popper.js is missing

2020-09-02 Thread Lisa Seeto
I wasn't able to see the error following the original steps but could by 
following this process:
- Have a journal and a journal entry
- on the journal entry add a file as an attachment
- Export all account data by going to User menu-> Manage -> Export, select 'All 
my data' and click on 'Generate export'
- Uncompress downloaded file
- open HTML/index.html
- click in the Journal's link
- the journal entry will display with its attachments area panel, click on the 
panel, the error is produced.

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1893890

Title:
  html export complains popper.js is missing

Status in Mahara:
  In Progress

Bug description:
  to test:
  - Have a journal and a journal entry
  - Export all account data by going to User menu-> Manage -> Export, select 
'All my data' and click on 'Generate export'
  - Uncompress downloaded file
  - open HTML/index.html
  - click in the Journal's link

  result: on the browser's console there is an error
  "Bootstrap's tooltips require Popper.js (https://popper.js.org/)"

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1893890/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1893607] Re: Admin reports that list pages should only have links if admin can view page

2020-09-02 Thread Robert Lyon
** Changed in: mahara
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1893607

Title:
  Admin reports that list pages should only have links if admin can view
  page

Status in Mahara:
  Fix Committed

Bug description:
  In some of the admin reports there are pages / collections listed as
  links to the referenced page.

  But admins might not have access to the page (without masquerading) so
  we should only show the links for the pages they have access to (or
  force them to masquerade maybe)

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1893607/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1893607] A change has been merged

2020-09-02 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/11200
Committed: 
https://git.mahara.org/mahara/mahara/commit/f2196d735e9988a951d546eefb918edcf1f42e6e
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master

commit f2196d735e9988a951d546eefb918edcf1f42e6e
Author: Lisa Seeto 
Date:   Tue Sep 1 12:20:18 2020 +1200

Bug 1893607: Admin reports that list pages should only have links if
admin can view page

- add check to see if USER can view portfolio to conditionally display URL
- add check for item pending to conditionally display pending text
- alter formatting of template for readability
- remove pending styling for entire column (needed to have $item->pending != 
null to work
so wasn't working already, and if displayed, requires further styling to have 
accesible contrast

Change-Id: Ice988ab891c8369e2bc4b323b3a0316f7989aae5
Signed-off-by: Lisa Seeto 

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1893607

Title:
  Admin reports that list pages should only have links if admin can view
  page

Status in Mahara:
  Fix Committed

Bug description:
  In some of the admin reports there are pages / collections listed as
  links to the referenced page.

  But admins might not have access to the page (without masquerading) so
  we should only show the links for the pages they have access to (or
  force them to masquerade maybe)

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1893607/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1894026] [NEW] exports: js files are fetched from the wrong dir in configurable theme

2020-09-02 Thread Cecilia Vela Gurovic
Public bug reported:

when generating the 'All my data' export the html files created have the
wrong path for the javascript files, if the logged in user exporting the
data belongs to an institution using a configurable theme

To replicate
- have an institution with configurable theme set up
- have a member of that institution and login as that user
- go to User menu -> Manage -> Export
- select 'All my data' and click on 'Generate export'
- extract the downloaded .zip file is a local directory
- open the HTML/index.html file
- inspect the code in the browser

Expected result: the path of the .js file, e.g. jquery.js, should be pointing 
to the HTML/static/theme/raw but the theme.js file that is located in 
HTML/static/theme/custom
Actual result: the path of some of the .js file (not theme.js) starts with 
HTML/static/theme/custom

** Affects: mahara
 Importance: Undecided
 Status: New

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1894026

Title:
  exports: js files are fetched from the wrong dir in configurable theme

Status in Mahara:
  New

Bug description:
  when generating the 'All my data' export the html files created have
  the wrong path for the javascript files, if the logged in user
  exporting the data belongs to an institution using a configurable
  theme

  To replicate
  - have an institution with configurable theme set up
  - have a member of that institution and login as that user
  - go to User menu -> Manage -> Export
  - select 'All my data' and click on 'Generate export'
  - extract the downloaded .zip file is a local directory
  - open the HTML/index.html file
  - inspect the code in the browser

  Expected result: the path of the .js file, e.g. jquery.js, should be pointing 
to the HTML/static/theme/raw but the theme.js file that is located in 
HTML/static/theme/custom
  Actual result: the path of some of the .js file (not theme.js) starts with 
HTML/static/theme/custom

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1894026/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1892794] A change has been merged

2020-09-02 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/11178
Committed: 
https://git.mahara.org/mahara/mahara/commit/d57289185e6205a51a39ac75d0be6d9be2eeafc0
Submitter: Cecilia Vela Gurovic (cecili...@catalyst.net.nz)
Branch:master

commit d57289185e6205a51a39ac75d0be6d9be2eeafc0
Author: Robert Lyon 
Date:   Tue Aug 25 12:01:08 2020 +1200

Bug 1892794: mahara_user_external to fetch local profile options better

To fetch them from the local/lib/artefact_internal.php file

Change-Id: Ie31ef36823287e7013a4a2d56de91fdfcf9be4af
Signed-off-by: Robert Lyon 

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1892794

Title:
  Allow local custom profile fields  also be accessible via webservices

Status in Mahara:
  Fix Committed

Bug description:
  What is wanted:

  Have the mahara_user_external.php webservice function be able to set /
  fetch the information for local custom fields.

  Currently we have to hardcode in the extra fields in the _parameters()
  or _returns() functions

  It would be better if the local/lib/artefact_internal.php had a
  function to call to fetch webservice info for the local profile fields

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1892794/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1892794] A change has been merged

2020-09-02 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/11186
Committed: 
https://git.mahara.org/mahara/mahara/commit/0ca96efc73b3b2a9120584cfe5a7d1c3ed06cb25
Submitter: Cecilia Vela Gurovic (cecili...@catalyst.net.nz)
Branch:master

commit 0ca96efc73b3b2a9120584cfe5a7d1c3ed06cb25
Author: Robert Lyon 
Date:   Wed Aug 26 12:59:54 2020 +1200

Bug 1892794: Allowing custom profile fields have custom titles

Currently all profile fields title/label named via the artefacttype
But if we want different titles in differnet contexts we can now do
this by adding to our ArtefactTypeWhatever class something like

public static function static_display_title() {
if (... some condition ...) {
return get_string('altoption', 'artefact.internal');
}
return get_string('option', 'artefact.internal');
}

Change-Id: I32cfdc821442a7ba8729d76a18e6ddc1f7a62c95
Signed-off-by: Robert Lyon 

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1892794

Title:
  Allow local custom profile fields  also be accessible via webservices

Status in Mahara:
  Fix Committed

Bug description:
  What is wanted:

  Have the mahara_user_external.php webservice function be able to set /
  fetch the information for local custom fields.

  Currently we have to hardcode in the extra fields in the _parameters()
  or _returns() functions

  It would be better if the local/lib/artefact_internal.php had a
  function to call to fetch webservice info for the local profile fields

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1892794/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1892794] Re: Allow local custom profile fields also be accessible via webservices

2020-09-02 Thread Cecilia Vela Gurovic
** Changed in: mahara
 Assignee: (unassigned) => Robert Lyon (robertl-9)

** Changed in: mahara
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1892794

Title:
  Allow local custom profile fields  also be accessible via webservices

Status in Mahara:
  Fix Committed

Bug description:
  What is wanted:

  Have the mahara_user_external.php webservice function be able to set /
  fetch the information for local custom fields.

  Currently we have to hardcode in the extra fields in the _parameters()
  or _returns() functions

  It would be better if the local/lib/artefact_internal.php had a
  function to call to fetch webservice info for the local profile fields

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1892794/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1892437] Re: stop loading zxcvbn.js library everytime a page is loaded

2020-09-02 Thread Lisa Seeto
** Changed in: mahara
   Status: New => In Progress

** Changed in: mahara
 Assignee: (unassigned) => Cecilia Vela Gurovic (ceciliavg)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1892437

Title:
  stop loading zxcvbn.js library everytime a page is loaded

Status in Mahara:
  In Progress

Bug description:
  This library is loaded as part of the login form, but we actually
  don't need it while the already logged in.

  Loading it every time consumes extra resources that can be avoided.

  See attached images from the js profiling result, this file takes more
  time to load than the rest of the libraries.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1892437/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1893941] [NEW] Elasticsearch on Localhost and Proxy entry

2020-09-02 Thread Wesley Richards
Public bug reported:

Hello everyone,
I just discovered a nasty bug.
If you configure a proxy for Mahara and use Elasticsearch on localhost, the 
proxy entry interferes with the access to Elasticsearch. Mahara can then no 
longer connect to Elasicsearch.
Mahara may try to connect to Elasicsearch through the proxy but localhost on 
the Mahara server is different than localhost on the proxy.
Please excuse my bad English but I hope you understand what I mean ;-)

Mahara: 20.04.1
Elasitcsearch: 6.8.12

Nice greetings from Kassel

Wesley

** Affects: mahara
 Importance: Undecided
 Status: New

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1893941

Title:
  Elasticsearch on Localhost and Proxy entry

Status in Mahara:
  New

Bug description:
  Hello everyone,
  I just discovered a nasty bug.
  If you configure a proxy for Mahara and use Elasticsearch on localhost, the 
proxy entry interferes with the access to Elasticsearch. Mahara can then no 
longer connect to Elasicsearch.
  Mahara may try to connect to Elasicsearch through the proxy but localhost on 
the Mahara server is different than localhost on the proxy.
  Please excuse my bad English but I hope you understand what I mean ;-)

  Mahara: 20.04.1
  Elasitcsearch: 6.8.12

  Nice greetings from Kassel

  Wesley

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1893941/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp