[Mahara-contributors] [Bug 1876185] Re: Allow redis function without needing sentinel
** Tags removed: nominatedfeature ** Tags added: newfeature -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1876185 Title: Allow redis function without needing sentinel Status in Mahara: Fix Committed Bug description: When redis was set up in mahara it was envisioned to be used with redis sentinel in a cluster situation But we should also allow redis to be usable without sentinel Looking at the code we probably need to adjust the get_redis_master() and get_redis_servers() functions in htdocs/auth/lib.php To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1876185/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1892254] Re: Only SAML auth instance for metadata not active but can still see metadata choice on IdP discovery page
** Tags removed: nominatedfeature ** Tags added: newfeature -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1892254 Title: Only SAML auth instance for metadata not active but can still see metadata choice on IdP discovery page Status in Mahara: Fix Committed Bug description: If we have the following: A site with a couple of institutions (Institution1 and Institution2) each having a SAML auth instance with different metadata (say IdP1 and IdP2) If Instance2 sets it's saml auth to not be active then we shouldn't expect to see the auth option on the IdP Discovery page ( auth/saml/index.php ) We need to adjust the discovery page to only show the IdP's that are being used by 1 or more active SAML instances. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1892254/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1892664] Re: Share access with account holders outside of institution is producing a warning
** Also affects: mahara/20.10
Importance: High
Assignee: Lisa Seeto (lisaseeto)
Status: In Progress
** Also affects: mahara/20.04
Importance: Undecided
Status: New
** Changed in: mahara/20.04
Milestone: None => 20.04.2
** Changed in: mahara/20.04
Importance: Undecided => High
** Changed in: mahara/20.04
Status: New => Fix Committed
** Changed in: mahara/20.10
Status: In Progress => Fix Committed
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1892664
Title:
Share access with account holders outside of institution is producing
a warning
Status in Mahara:
Fix Committed
Status in Mahara 20.04 series:
Fix Committed
Status in Mahara 20.10 series:
Fix Committed
Bug description:
A warning is produced when a user who is the only member of an
institution tries to share view access with a user outside of their
institution.
To reproduce:
Have an institution with one member, and members outside of institution on a
site
1. log in as institution member, create a page
2. Share the page with a person on the site who isn't in an institution
(anyone from "Other people") and save
Expected results:
The page is updated with new access rules
Actual results:
A warning is being produced (see attached screen shot for more):
[WAR] 52 (view/access.json.php:70) array_keys() expects parameter 1 to be
array, boolean given
Call stack (most recent first):
log_message("array_keys() expects parameter 1 to be array, bool...", 8,
true, true, "/home/lisaseeto/code/mahara-test/htdocs/view/acces...", 70) at
/home/lisaseeto/code/mahara-test/htdocs/lib/errors.php:521
error(2, "array_keys() expects parameter 1 to be array, bool...",
"/home/lisaseeto/code/mahara-test/htdocs/view/acces...", 70, array(size 73)) at
Unknown:0
array_keys(false) at
/home/lisaseeto/code/mahara-test/htdocs/view/access.json.php:70
[WAR] 52 (view/access.json.php:74) in_array() expects parameter 2 to be
array, null given
Call stack (most recent first):
log_message("in_array() expects parameter 2 to be array, null g...", 8,
true, true, "/home/lisaseeto/code/mahara-test/htdocs/view/acces...", 74) at
/home/lisaseeto/code/mahara-test/htdocs/lib/errors.php:521
error(2, "in_array() expects parameter 2 to be array, null g...",
"/home/lisaseeto/code/mahara-test/htdocs/view/acces...", 74, array(size 75)) at
Unknown:0
in_array("20", null) at
/home/lisaseeto/code/mahara-test/htdocs/view/access.json.php:74
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1892664/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1892664] A change has been merged
Reviewed: https://reviews.mahara.org/11247
Committed:
https://git.mahara.org/mahara/mahara/commit/39ae16fbb4648734cc72b3866e797dc63cac95c0
Submitter: Cecilia Vela Gurovic (cecili...@catalyst.net.nz)
Branch:20.04_STABLE
commit 39ae16fbb4648734cc72b3866e797dc63cac95c0
Author: Lisa Seeto
Date: Mon Aug 24 15:24:22 2020 +1200
Bug 1892664: Share access with users outside of institution is producing
a warning
- add in check for peoplein, set to array if false
Change-Id: Ie8a4c98190b1a15c4a6f7556fd714e50c20d62eb
Signed-off-by: Lisa Seeto
(cherry picked from commit 48e2a2676186a532367db3eb36064f9ae8393364)
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1892664
Title:
Share access with account holders outside of institution is producing
a warning
Status in Mahara:
Fix Committed
Status in Mahara 20.04 series:
Fix Committed
Status in Mahara 20.10 series:
Fix Committed
Bug description:
A warning is produced when a user who is the only member of an
institution tries to share view access with a user outside of their
institution.
To reproduce:
Have an institution with one member, and members outside of institution on a
site
1. log in as institution member, create a page
2. Share the page with a person on the site who isn't in an institution
(anyone from "Other people") and save
Expected results:
The page is updated with new access rules
Actual results:
A warning is being produced (see attached screen shot for more):
[WAR] 52 (view/access.json.php:70) array_keys() expects parameter 1 to be
array, boolean given
Call stack (most recent first):
log_message("array_keys() expects parameter 1 to be array, bool...", 8,
true, true, "/home/lisaseeto/code/mahara-test/htdocs/view/acces...", 70) at
/home/lisaseeto/code/mahara-test/htdocs/lib/errors.php:521
error(2, "array_keys() expects parameter 1 to be array, bool...",
"/home/lisaseeto/code/mahara-test/htdocs/view/acces...", 70, array(size 73)) at
Unknown:0
array_keys(false) at
/home/lisaseeto/code/mahara-test/htdocs/view/access.json.php:70
[WAR] 52 (view/access.json.php:74) in_array() expects parameter 2 to be
array, null given
Call stack (most recent first):
log_message("in_array() expects parameter 2 to be array, null g...", 8,
true, true, "/home/lisaseeto/code/mahara-test/htdocs/view/acces...", 74) at
/home/lisaseeto/code/mahara-test/htdocs/lib/errors.php:521
error(2, "in_array() expects parameter 2 to be array, null g...",
"/home/lisaseeto/code/mahara-test/htdocs/view/acces...", 74, array(size 75)) at
Unknown:0
in_array("20", null) at
/home/lisaseeto/code/mahara-test/htdocs/view/access.json.php:74
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1892664/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1892664] A change has been merged
Reviewed: https://reviews.mahara.org/11173
Committed:
https://git.mahara.org/mahara/mahara/commit/48e2a2676186a532367db3eb36064f9ae8393364
Submitter: Cecilia Vela Gurovic (cecili...@catalyst.net.nz)
Branch:master
commit 48e2a2676186a532367db3eb36064f9ae8393364
Author: Lisa Seeto
Date: Mon Aug 24 15:24:22 2020 +1200
Bug 1892664: Share access with users outside of institution is producing
a warning
- add in check for peoplein, set to array if false
Change-Id: Ie8a4c98190b1a15c4a6f7556fd714e50c20d62eb
Signed-off-by: Lisa Seeto
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1892664
Title:
Share access with account holders outside of institution is producing
a warning
Status in Mahara:
Fix Committed
Status in Mahara 20.04 series:
Fix Committed
Status in Mahara 20.10 series:
Fix Committed
Bug description:
A warning is produced when a user who is the only member of an
institution tries to share view access with a user outside of their
institution.
To reproduce:
Have an institution with one member, and members outside of institution on a
site
1. log in as institution member, create a page
2. Share the page with a person on the site who isn't in an institution
(anyone from "Other people") and save
Expected results:
The page is updated with new access rules
Actual results:
A warning is being produced (see attached screen shot for more):
[WAR] 52 (view/access.json.php:70) array_keys() expects parameter 1 to be
array, boolean given
Call stack (most recent first):
log_message("array_keys() expects parameter 1 to be array, bool...", 8,
true, true, "/home/lisaseeto/code/mahara-test/htdocs/view/acces...", 70) at
/home/lisaseeto/code/mahara-test/htdocs/lib/errors.php:521
error(2, "array_keys() expects parameter 1 to be array, bool...",
"/home/lisaseeto/code/mahara-test/htdocs/view/acces...", 70, array(size 73)) at
Unknown:0
array_keys(false) at
/home/lisaseeto/code/mahara-test/htdocs/view/access.json.php:70
[WAR] 52 (view/access.json.php:74) in_array() expects parameter 2 to be
array, null given
Call stack (most recent first):
log_message("in_array() expects parameter 2 to be array, null g...", 8,
true, true, "/home/lisaseeto/code/mahara-test/htdocs/view/acces...", 74) at
/home/lisaseeto/code/mahara-test/htdocs/lib/errors.php:521
error(2, "in_array() expects parameter 2 to be array, null g...",
"/home/lisaseeto/code/mahara-test/htdocs/view/acces...", 74, array(size 75)) at
Unknown:0
in_array("20", null) at
/home/lisaseeto/code/mahara-test/htdocs/view/access.json.php:74
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1892664/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1892664] A patch has been submitted for review
Patch for "20.04_STABLE" branch: https://reviews.mahara.org/11247
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1892664
Title:
Share access with account holders outside of institution is producing
a warning
Status in Mahara:
Fix Committed
Status in Mahara 20.04 series:
Fix Committed
Status in Mahara 20.10 series:
Fix Committed
Bug description:
A warning is produced when a user who is the only member of an
institution tries to share view access with a user outside of their
institution.
To reproduce:
Have an institution with one member, and members outside of institution on a
site
1. log in as institution member, create a page
2. Share the page with a person on the site who isn't in an institution
(anyone from "Other people") and save
Expected results:
The page is updated with new access rules
Actual results:
A warning is being produced (see attached screen shot for more):
[WAR] 52 (view/access.json.php:70) array_keys() expects parameter 1 to be
array, boolean given
Call stack (most recent first):
log_message("array_keys() expects parameter 1 to be array, bool...", 8,
true, true, "/home/lisaseeto/code/mahara-test/htdocs/view/acces...", 70) at
/home/lisaseeto/code/mahara-test/htdocs/lib/errors.php:521
error(2, "array_keys() expects parameter 1 to be array, bool...",
"/home/lisaseeto/code/mahara-test/htdocs/view/acces...", 70, array(size 73)) at
Unknown:0
array_keys(false) at
/home/lisaseeto/code/mahara-test/htdocs/view/access.json.php:70
[WAR] 52 (view/access.json.php:74) in_array() expects parameter 2 to be
array, null given
Call stack (most recent first):
log_message("in_array() expects parameter 2 to be array, null g...", 8,
true, true, "/home/lisaseeto/code/mahara-test/htdocs/view/acces...", 74) at
/home/lisaseeto/code/mahara-test/htdocs/lib/errors.php:521
error(2, "in_array() expects parameter 2 to be array, null g...",
"/home/lisaseeto/code/mahara-test/htdocs/view/acces...", 74, array(size 75)) at
Unknown:0
in_array("20", null) at
/home/lisaseeto/code/mahara-test/htdocs/view/access.json.php:74
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1892664/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1894933] [NEW] Behat: Logged out external links
Public bug reported: https://bugs.launchpad.net/mahara/+bug/1892950 said: "There is no automated test for public links and resources. This could be added." As this is on the manual regression testing at the moment, let's follow through and add it. Notes from spreadsheet: - public – Logged out page: external link/s &/or file/s,add/remove If I missed that this was fixed or unnecessary, please remove the bug. ** Affects: mahara Importance: Medium Assignee: Rangi Daymond (rangid) Status: Confirmed ** Tags: behat-test ** Changed in: mahara Status: New => Confirmed ** Changed in: mahara Importance: Undecided => Medium -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1894933 Title: Behat: Logged out external links Status in Mahara: Confirmed Bug description: https://bugs.launchpad.net/mahara/+bug/1892950 said: "There is no automated test for public links and resources. This could be added." As this is on the manual regression testing at the moment, let's follow through and add it. Notes from spreadsheet: - public – Logged out page: external link/s &/or file/s,add/remove If I missed that this was fixed or unnecessary, please remove the bug. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1894933/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1890349] Re: SAML auth update user issues
** Changed in: mahara/20.10
Status: In Progress => Fix Committed
** Changed in: mahara/20.04
Status: Confirmed => Fix Committed
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1890349
Title:
SAML auth update user issues
Status in Mahara:
Fix Committed
Status in Mahara 20.04 series:
Fix Committed
Status in Mahara 20.10 series:
Fix Committed
Bug description:
Currently if you have a user in Mahara that logs in via SAML and has
update user option set then their admin/staff status is updated. If
this info is not being passed in via SAML from IdP it means they are
updated to be normal members.
We should only do this updating if any of the SAML instance settings are set
for:
- rolesiteadmin
- rolesitestaff
- roleinstadmin
- roleinststaff
And if the particular one is not set to ignore updating this part of
the user's profile
Also we need to check that the following is correct
if ($institutionrole == 'admin') {
$institution->addUserAsStaff($user);
}
Should it be $institution->addUserAsAdmin($user);
Thanks go to SWITCH for sponsoring this fix.
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1890349/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1890349] A change has been merged
Reviewed: https://reviews.mahara.org/11246
Committed:
https://git.mahara.org/mahara/mahara/commit/37ed3c4db03103d7191b3225385893699e2aced7
Submitter: Cecilia Vela Gurovic (cecili...@catalyst.net.nz)
Branch:20.04_STABLE
commit 37ed3c4db03103d7191b3225385893699e2aced7
Author: Robert Lyon
Date: Tue Aug 25 08:20:51 2020 +1200
Bug 1890349: Ignore SAML permission roles if not set in instance config
If we have not set 'roles' option in SAML config then we need to
ignore any of the changing admin/staff roles
Change-Id: I7ac908b35e9f91f1906f1230460909340d23735f
Signed-off-by: Robert Lyon
(cherry picked from commit fe31f2cd13818e4ef2f2fbf157a34eb3ba114c9c)
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1890349
Title:
SAML auth update user issues
Status in Mahara:
Fix Committed
Status in Mahara 20.04 series:
Fix Committed
Status in Mahara 20.10 series:
Fix Committed
Bug description:
Currently if you have a user in Mahara that logs in via SAML and has
update user option set then their admin/staff status is updated. If
this info is not being passed in via SAML from IdP it means they are
updated to be normal members.
We should only do this updating if any of the SAML instance settings are set
for:
- rolesiteadmin
- rolesitestaff
- roleinstadmin
- roleinststaff
And if the particular one is not set to ignore updating this part of
the user's profile
Also we need to check that the following is correct
if ($institutionrole == 'admin') {
$institution->addUserAsStaff($user);
}
Should it be $institution->addUserAsAdmin($user);
Thanks go to SWITCH for sponsoring this fix.
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1890349/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1890349] A patch has been submitted for review
Patch for "20.04_STABLE" branch: https://reviews.mahara.org/11246
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1890349
Title:
SAML auth update user issues
Status in Mahara:
Fix Committed
Status in Mahara 20.04 series:
Fix Committed
Status in Mahara 20.10 series:
Fix Committed
Bug description:
Currently if you have a user in Mahara that logs in via SAML and has
update user option set then their admin/staff status is updated. If
this info is not being passed in via SAML from IdP it means they are
updated to be normal members.
We should only do this updating if any of the SAML instance settings are set
for:
- rolesiteadmin
- rolesitestaff
- roleinstadmin
- roleinststaff
And if the particular one is not set to ignore updating this part of
the user's profile
Also we need to check that the following is correct
if ($institutionrole == 'admin') {
$institution->addUserAsStaff($user);
}
Should it be $institution->addUserAsAdmin($user);
Thanks go to SWITCH for sponsoring this fix.
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1890349/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1890349] A change has been merged
Reviewed: https://reviews.mahara.org/11174
Committed:
https://git.mahara.org/mahara/mahara/commit/fe31f2cd13818e4ef2f2fbf157a34eb3ba114c9c
Submitter: Cecilia Vela Gurovic (cecili...@catalyst.net.nz)
Branch:master
commit fe31f2cd13818e4ef2f2fbf157a34eb3ba114c9c
Author: Robert Lyon
Date: Tue Aug 25 08:20:51 2020 +1200
Bug 1890349: Ignore SAML permission roles if not set in instance config
If we have not set 'roles' option in SAML config then we need to
ignore any of the changing admin/staff roles
Change-Id: I7ac908b35e9f91f1906f1230460909340d23735f
Signed-off-by: Robert Lyon
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1890349
Title:
SAML auth update user issues
Status in Mahara:
Fix Committed
Status in Mahara 20.04 series:
Fix Committed
Status in Mahara 20.10 series:
Fix Committed
Bug description:
Currently if you have a user in Mahara that logs in via SAML and has
update user option set then their admin/staff status is updated. If
this info is not being passed in via SAML from IdP it means they are
updated to be normal members.
We should only do this updating if any of the SAML instance settings are set
for:
- rolesiteadmin
- rolesitestaff
- roleinstadmin
- roleinststaff
And if the particular one is not set to ignore updating this part of
the user's profile
Also we need to check that the following is correct
if ($institutionrole == 'admin') {
$institution->addUserAsStaff($user);
}
Should it be $institution->addUserAsAdmin($user);
Thanks go to SWITCH for sponsoring this fix.
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1890349/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1892256] Re: Undefined variable: duplicates error when updating SAML metadata in SAML instance
I verified this fix by setting up two institutions with the same metadata then slightly changing the metadata in one of the institution's settings in order to trigger another configuration save, saved the SAML configuration and then saved the institution, producing the error. I then applied the patch, repeated the steps and was able to successfully save the institution without any error messages or warnings -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1892256 Title: Undefined variable: duplicates error when updating SAML metadata in SAML instance Status in Mahara: In Progress Status in Mahara 19.04 series: Confirmed Status in Mahara 19.10 series: Confirmed Status in Mahara 20.04 series: Confirmed Status in Mahara 20.10 series: In Progress Bug description: This is because we can't chain the db query result and finding the resultant object value in the same "if" statement We need to break this down into testable parts To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1892256/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1887450] A patch has been submitted for review
Patch for "19.04_STABLE" branch: https://reviews.mahara.org/11245 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1887450 Title: Block header buttons need better labels when Editing Pages Status in Mahara: Fix Committed Status in Mahara 19.04 series: Fix Committed Status in Mahara 19.10 series: Fix Committed Status in Mahara 20.04 series: Fix Committed Status in Mahara 20.10 series: Fix Committed Bug description: It was found that the labels for the buttons that appear when editing a block on a page are not accurately described by a screen reader. The buttons are "Configure block" and "Remove block". The "Remove block" button was entirely missing its label for screen readers, while the "Configure block" reads "Move block" instead of configure block. It looks like the 'sr-only' class needs to be applied correctly to the configure block button so that it misses the move button text and addresses its own purposes and for it to be applied to the remove block button in blocktypecontainerediting.tpl To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1887450/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1887450] A change has been merged
Reviewed: https://reviews.mahara.org/11245 Committed: https://git.mahara.org/mahara/mahara/commit/4b27a8fa06df7bfd104c91fc6916b48d9fc3d3f3 Submitter: Cecilia Vela Gurovic (cecili...@catalyst.net.nz) Branch:19.04_STABLE commit 4b27a8fa06df7bfd104c91fc6916b48d9fc3d3f3 Author: Lisa Seeto Date: Tue Sep 1 15:05:24 2020 +1200 Bug 1887450: Block header buttons need better labels when Editing Pages - add in sr-only tags for buttons Change-Id: I47ca334ea8c197a782641d23843ee8959d5e4e05 Signed-off-by: Lisa Seeto (cherry picked from commit dfba48441f62785a23fa2603c3c6e85b16af0fac) (cherry picked from commit f46ad3d9af4f51fc7975d44cf23d05d5cb0fcefa) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1887450 Title: Block header buttons need better labels when Editing Pages Status in Mahara: Fix Committed Status in Mahara 19.04 series: Fix Committed Status in Mahara 19.10 series: Fix Committed Status in Mahara 20.04 series: Fix Committed Status in Mahara 20.10 series: Fix Committed Bug description: It was found that the labels for the buttons that appear when editing a block on a page are not accurately described by a screen reader. The buttons are "Configure block" and "Remove block". The "Remove block" button was entirely missing its label for screen readers, while the "Configure block" reads "Move block" instead of configure block. It looks like the 'sr-only' class needs to be applied correctly to the configure block button so that it misses the move button text and addresses its own purposes and for it to be applied to the remove block button in blocktypecontainerediting.tpl To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1887450/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1887450] A change has been merged
Reviewed: https://reviews.mahara.org/11244 Committed: https://git.mahara.org/mahara/mahara/commit/eebb1e1dbeee886478fbe01067a48874dc0e5067 Submitter: Cecilia Vela Gurovic (cecili...@catalyst.net.nz) Branch:19.10_STABLE commit eebb1e1dbeee886478fbe01067a48874dc0e5067 Author: Lisa Seeto Date: Tue Sep 1 15:05:24 2020 +1200 Bug 1887450: Block header buttons need better labels when Editing Pages - add in sr-only tags for buttons Change-Id: I47ca334ea8c197a782641d23843ee8959d5e4e05 Signed-off-by: Lisa Seeto (cherry picked from commit dfba48441f62785a23fa2603c3c6e85b16af0fac) (cherry picked from commit f46ad3d9af4f51fc7975d44cf23d05d5cb0fcefa) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1887450 Title: Block header buttons need better labels when Editing Pages Status in Mahara: Fix Committed Status in Mahara 19.04 series: Fix Committed Status in Mahara 19.10 series: Fix Committed Status in Mahara 20.04 series: Fix Committed Status in Mahara 20.10 series: Fix Committed Bug description: It was found that the labels for the buttons that appear when editing a block on a page are not accurately described by a screen reader. The buttons are "Configure block" and "Remove block". The "Remove block" button was entirely missing its label for screen readers, while the "Configure block" reads "Move block" instead of configure block. It looks like the 'sr-only' class needs to be applied correctly to the configure block button so that it misses the move button text and addresses its own purposes and for it to be applied to the remove block button in blocktypecontainerediting.tpl To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1887450/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1887450] A change has been merged
Reviewed: https://reviews.mahara.org/11201 Committed: https://git.mahara.org/mahara/mahara/commit/dfba48441f62785a23fa2603c3c6e85b16af0fac Submitter: Cecilia Vela Gurovic (cecili...@catalyst.net.nz) Branch:master commit dfba48441f62785a23fa2603c3c6e85b16af0fac Author: Lisa Seeto Date: Tue Sep 1 15:05:24 2020 +1200 Bug 1887450: Block header buttons need better labels when Editing Pages - add in sr-only tags for buttons Change-Id: I47ca334ea8c197a782641d23843ee8959d5e4e05 Signed-off-by: Lisa Seeto -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1887450 Title: Block header buttons need better labels when Editing Pages Status in Mahara: Fix Committed Status in Mahara 19.04 series: Fix Committed Status in Mahara 19.10 series: Fix Committed Status in Mahara 20.04 series: Fix Committed Status in Mahara 20.10 series: Fix Committed Bug description: It was found that the labels for the buttons that appear when editing a block on a page are not accurately described by a screen reader. The buttons are "Configure block" and "Remove block". The "Remove block" button was entirely missing its label for screen readers, while the "Configure block" reads "Move block" instead of configure block. It looks like the 'sr-only' class needs to be applied correctly to the configure block button so that it misses the move button text and addresses its own purposes and for it to be applied to the remove block button in blocktypecontainerediting.tpl To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1887450/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1887450] A change has been merged
Reviewed: https://reviews.mahara.org/11243 Committed: https://git.mahara.org/mahara/mahara/commit/f46ad3d9af4f51fc7975d44cf23d05d5cb0fcefa Submitter: Cecilia Vela Gurovic (cecili...@catalyst.net.nz) Branch:20.04_STABLE commit f46ad3d9af4f51fc7975d44cf23d05d5cb0fcefa Author: Lisa Seeto Date: Tue Sep 1 15:05:24 2020 +1200 Bug 1887450: Block header buttons need better labels when Editing Pages - add in sr-only tags for buttons Change-Id: I47ca334ea8c197a782641d23843ee8959d5e4e05 Signed-off-by: Lisa Seeto (cherry picked from commit dfba48441f62785a23fa2603c3c6e85b16af0fac) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1887450 Title: Block header buttons need better labels when Editing Pages Status in Mahara: Fix Committed Status in Mahara 19.04 series: Fix Committed Status in Mahara 19.10 series: Fix Committed Status in Mahara 20.04 series: Fix Committed Status in Mahara 20.10 series: Fix Committed Bug description: It was found that the labels for the buttons that appear when editing a block on a page are not accurately described by a screen reader. The buttons are "Configure block" and "Remove block". The "Remove block" button was entirely missing its label for screen readers, while the "Configure block" reads "Move block" instead of configure block. It looks like the 'sr-only' class needs to be applied correctly to the configure block button so that it misses the move button text and addresses its own purposes and for it to be applied to the remove block button in blocktypecontainerediting.tpl To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1887450/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1887450] A patch has been submitted for review
Patch for "20.04_STABLE" branch: https://reviews.mahara.org/11243 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1887450 Title: Block header buttons need better labels when Editing Pages Status in Mahara: Fix Committed Status in Mahara 19.04 series: Fix Committed Status in Mahara 19.10 series: Fix Committed Status in Mahara 20.04 series: Fix Committed Status in Mahara 20.10 series: Fix Committed Bug description: It was found that the labels for the buttons that appear when editing a block on a page are not accurately described by a screen reader. The buttons are "Configure block" and "Remove block". The "Remove block" button was entirely missing its label for screen readers, while the "Configure block" reads "Move block" instead of configure block. It looks like the 'sr-only' class needs to be applied correctly to the configure block button so that it misses the move button text and addresses its own purposes and for it to be applied to the remove block button in blocktypecontainerediting.tpl To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1887450/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1887450] A patch has been submitted for review
Patch for "19.10_STABLE" branch: https://reviews.mahara.org/11244 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1887450 Title: Block header buttons need better labels when Editing Pages Status in Mahara: Fix Committed Status in Mahara 19.04 series: Fix Committed Status in Mahara 19.10 series: Fix Committed Status in Mahara 20.04 series: Fix Committed Status in Mahara 20.10 series: Fix Committed Bug description: It was found that the labels for the buttons that appear when editing a block on a page are not accurately described by a screen reader. The buttons are "Configure block" and "Remove block". The "Remove block" button was entirely missing its label for screen readers, while the "Configure block" reads "Move block" instead of configure block. It looks like the 'sr-only' class needs to be applied correctly to the configure block button so that it misses the move button text and addresses its own purposes and for it to be applied to the remove block button in blocktypecontainerediting.tpl To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1887450/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1887450] Re: Block header buttons need better labels when Editing Pages
** Also affects: mahara/19.04 Importance: Undecided Status: New ** Also affects: mahara/20.10 Importance: High Assignee: Lisa Seeto (lisaseeto) Status: In Progress ** Also affects: mahara/19.10 Importance: Undecided Status: New ** Also affects: mahara/20.04 Importance: Undecided Status: New ** Changed in: mahara/20.04 Importance: Undecided => High ** Changed in: mahara/19.10 Importance: Undecided => High ** Changed in: mahara/19.04 Importance: Undecided => High ** Changed in: mahara/19.04 Milestone: None => 19.10.5 ** Changed in: mahara/19.04 Milestone: 19.10.5 => 19.04.7 ** Changed in: mahara/19.10 Milestone: None => 19.10.5 ** Changed in: mahara/20.04 Milestone: None => 20.04.2 ** Changed in: mahara/20.04 Status: New => Fix Committed ** Changed in: mahara/19.04 Status: New => Fix Committed ** Changed in: mahara/20.10 Status: In Progress => Fix Committed ** Changed in: mahara/19.10 Status: New => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1887450 Title: Block header buttons need better labels when Editing Pages Status in Mahara: Fix Committed Status in Mahara 19.04 series: Fix Committed Status in Mahara 19.10 series: Fix Committed Status in Mahara 20.04 series: Fix Committed Status in Mahara 20.10 series: Fix Committed Bug description: It was found that the labels for the buttons that appear when editing a block on a page are not accurately described by a screen reader. The buttons are "Configure block" and "Remove block". The "Remove block" button was entirely missing its label for screen readers, while the "Configure block" reads "Move block" instead of configure block. It looks like the 'sr-only' class needs to be applied correctly to the configure block button so that it misses the move button text and addresses its own purposes and for it to be applied to the remove block button in blocktypecontainerediting.tpl To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1887450/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1891575] Re: LTI only giving access to the first page of a submitted collection
I have verified using the following steps: 1. Logged into an account via Moodle and then navigated to the Web Submissions Link -> Login to Mahara 2. On Mahara, created a 3 page collection 3. On Moodle, followed Web Services Submissions link, found the collection and submitted it. 4. Logged out and logged back in to Moodle with an account with Teacher role 5. Navigated to submitted work and found the collection 6. Followed the collection URL and was redirected to Mahara 7. I could confirm that I could access all pages within the collection. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1891575 Title: LTI only giving access to the first page of a submitted collection Status in Mahara: In Progress Bug description: When accessing a collection via LTI submission we only get access to the first page as the url link contains the page id. What we need is to allow the person using that link to be able to access any page in the collection To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1891575/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1889480] Re: Adding new Maroon theme
Bug report opened again for https://reviews.mahara.org/#/c/11091/ -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1889480 Title: Adding new Maroon theme Status in Mahara: In Progress Bug description: Adding a new theme called Maroon To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1889480/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1835681] Re: Check if we still need the config parameter "developermode"
That analysis is correct Lisa. We should just remove those DEEVMODE_ options as they don't do anything anymore for the mochikit part (as it is gone) and if people want special devmode css they can add it to their css/sass files rather than having a dedicated htdocs/theme/debug.css file -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1835681 Title: Check if we still need the config parameter "developermode" Status in Mahara: In Progress Bug description: There is the config.php parameter "developermode". It says in /lib /config-defaults.php: * @global int|bool $cfg->developermode Developer mode * When set, the following things (among others) will happen: * * * 'debug.css' will be included on each page. You can edit this file to add * debugging CSS at your discretion * * the unpacked version of MochiKit will be used * * These options are a performance hit otherwise, enable when you are * developing for Mahara */ $cfg->developermode = false; // $cfg->developermode = DEVMODE_DEBUGCSS | DEVMODE_UNPACKEDJS; --- It would need to be checked what "among others" is. We are not using debug.css and Mochikit has been removed. Before we get rid of the parameter though, it would need to be checked if removing it impacts anything else. Once the analysis is available, we can make a decision. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1835681/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1893159] A change has been merged
Reviewed: https://reviews.mahara.org/11242 Committed: https://git.mahara.org/mahara/mahara/commit/3afc821077127f483fc784e54c15e55f990bd62b Submitter: Cecilia Vela Gurovic (cecili...@catalyst.net.nz) Branch:19.04_STABLE commit 3afc821077127f483fc784e54c15e55f990bd62b Author: Lisa Seeto Date: Thu Aug 27 15:11:31 2020 +1200 Bug 1893159: Dashboard widgets are not receiving customisable theme styling - add in styling for widgets - add upgrade step to show warning to resave custom theme Change-Id: Ie6b46989200e4a19300ac228229dfe14bf0e8565 Signed-off-by: Lisa Seeto -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1893159 Title: Dashboard widgets are not receiving customisable theme styling Status in Mahara: Fix Committed Status in Mahara 19.04 series: Fix Committed Status in Mahara 19.10 series: Fix Committed Status in Mahara 20.04 series: Fix Committed Status in Mahara 20.10 series: Fix Committed Bug description: Currently the Dashboard widgets for "Create", "Share" and "Engage" do not receive the styling carried over from an institution's customisable theme (see attached screen shot) To replicate: Have an institution and at least one member who has dashboard info showing (to see the widgets) 1. Log in to site as administrator, in the Institution settings, select 'Customisable theme' for Theme and select custom colours (default config theme colours are fine). 2. Save the institution 3. Log in as institution member and navigate to dashboard, hover over the dashboard widgets Expected results: The Dashboard widgets display in customised colours matching the header Actual results: The Dashboard widgets display in the Raw theme colours. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1893159/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1893159] A patch has been submitted for review
Patch for "19.04_STABLE" branch: https://reviews.mahara.org/11242 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1893159 Title: Dashboard widgets are not receiving customisable theme styling Status in Mahara: Fix Committed Status in Mahara 19.04 series: Fix Committed Status in Mahara 19.10 series: Fix Committed Status in Mahara 20.04 series: Fix Committed Status in Mahara 20.10 series: Fix Committed Bug description: Currently the Dashboard widgets for "Create", "Share" and "Engage" do not receive the styling carried over from an institution's customisable theme (see attached screen shot) To replicate: Have an institution and at least one member who has dashboard info showing (to see the widgets) 1. Log in to site as administrator, in the Institution settings, select 'Customisable theme' for Theme and select custom colours (default config theme colours are fine). 2. Save the institution 3. Log in as institution member and navigate to dashboard, hover over the dashboard widgets Expected results: The Dashboard widgets display in customised colours matching the header Actual results: The Dashboard widgets display in the Raw theme colours. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1893159/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1893159] Re: Dashboard widgets are not receiving customisable theme styling
** Also affects: mahara/19.04 Importance: Undecided Status: New ** Changed in: mahara/19.04 Status: New => Fix Committed ** Changed in: mahara/19.04 Importance: Undecided => Medium ** Changed in: mahara/19.04 Milestone: None => 19.04.7 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1893159 Title: Dashboard widgets are not receiving customisable theme styling Status in Mahara: Fix Committed Status in Mahara 19.04 series: Fix Committed Status in Mahara 19.10 series: Fix Committed Status in Mahara 20.04 series: Fix Committed Status in Mahara 20.10 series: Fix Committed Bug description: Currently the Dashboard widgets for "Create", "Share" and "Engage" do not receive the styling carried over from an institution's customisable theme (see attached screen shot) To replicate: Have an institution and at least one member who has dashboard info showing (to see the widgets) 1. Log in to site as administrator, in the Institution settings, select 'Customisable theme' for Theme and select custom colours (default config theme colours are fine). 2. Save the institution 3. Log in as institution member and navigate to dashboard, hover over the dashboard widgets Expected results: The Dashboard widgets display in customised colours matching the header Actual results: The Dashboard widgets display in the Raw theme colours. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1893159/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1893159] A patch has been submitted for review
Patch for "19.10_STABLE" branch: https://reviews.mahara.org/11241 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1893159 Title: Dashboard widgets are not receiving customisable theme styling Status in Mahara: Fix Committed Status in Mahara 19.04 series: New Status in Mahara 19.10 series: Fix Committed Status in Mahara 20.04 series: Fix Committed Status in Mahara 20.10 series: Fix Committed Bug description: Currently the Dashboard widgets for "Create", "Share" and "Engage" do not receive the styling carried over from an institution's customisable theme (see attached screen shot) To replicate: Have an institution and at least one member who has dashboard info showing (to see the widgets) 1. Log in to site as administrator, in the Institution settings, select 'Customisable theme' for Theme and select custom colours (default config theme colours are fine). 2. Save the institution 3. Log in as institution member and navigate to dashboard, hover over the dashboard widgets Expected results: The Dashboard widgets display in customised colours matching the header Actual results: The Dashboard widgets display in the Raw theme colours. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1893159/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1893159] Re: Dashboard widgets are not receiving customisable theme styling
** Changed in: mahara/19.10 Milestone: None => 19.10.5 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1893159 Title: Dashboard widgets are not receiving customisable theme styling Status in Mahara: Fix Committed Status in Mahara 19.04 series: New Status in Mahara 19.10 series: Fix Committed Status in Mahara 20.04 series: Fix Committed Status in Mahara 20.10 series: Fix Committed Bug description: Currently the Dashboard widgets for "Create", "Share" and "Engage" do not receive the styling carried over from an institution's customisable theme (see attached screen shot) To replicate: Have an institution and at least one member who has dashboard info showing (to see the widgets) 1. Log in to site as administrator, in the Institution settings, select 'Customisable theme' for Theme and select custom colours (default config theme colours are fine). 2. Save the institution 3. Log in as institution member and navigate to dashboard, hover over the dashboard widgets Expected results: The Dashboard widgets display in customised colours matching the header Actual results: The Dashboard widgets display in the Raw theme colours. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1893159/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1893159] A change has been merged
Reviewed: https://reviews.mahara.org/11241 Committed: https://git.mahara.org/mahara/mahara/commit/06c066d0fe0cd8bd653d119880b6fd3950d73baa Submitter: Cecilia Vela Gurovic (cecili...@catalyst.net.nz) Branch:19.10_STABLE commit 06c066d0fe0cd8bd653d119880b6fd3950d73baa Author: Lisa Seeto Date: Thu Aug 27 15:11:31 2020 +1200 Bug 1893159: Dashboard widgets are not receiving customisable theme styling - add in styling for widgets - add upgrade step to show warning to resave custom theme Change-Id: Ie6b46989200e4a19300ac228229dfe14bf0e8565 Signed-off-by: Lisa Seeto -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1893159 Title: Dashboard widgets are not receiving customisable theme styling Status in Mahara: Fix Committed Status in Mahara 19.04 series: New Status in Mahara 19.10 series: Fix Committed Status in Mahara 20.04 series: Fix Committed Status in Mahara 20.10 series: Fix Committed Bug description: Currently the Dashboard widgets for "Create", "Share" and "Engage" do not receive the styling carried over from an institution's customisable theme (see attached screen shot) To replicate: Have an institution and at least one member who has dashboard info showing (to see the widgets) 1. Log in to site as administrator, in the Institution settings, select 'Customisable theme' for Theme and select custom colours (default config theme colours are fine). 2. Save the institution 3. Log in as institution member and navigate to dashboard, hover over the dashboard widgets Expected results: The Dashboard widgets display in customised colours matching the header Actual results: The Dashboard widgets display in the Raw theme colours. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1893159/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1893159] Re: Dashboard widgets are not receiving customisable theme styling
** Also affects: mahara/19.10 Importance: Undecided Status: New ** Changed in: mahara/19.10 Status: New => Fix Committed ** Changed in: mahara/19.10 Importance: Undecided => Medium -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1893159 Title: Dashboard widgets are not receiving customisable theme styling Status in Mahara: Fix Committed Status in Mahara 19.04 series: New Status in Mahara 19.10 series: Fix Committed Status in Mahara 20.04 series: Fix Committed Status in Mahara 20.10 series: Fix Committed Bug description: Currently the Dashboard widgets for "Create", "Share" and "Engage" do not receive the styling carried over from an institution's customisable theme (see attached screen shot) To replicate: Have an institution and at least one member who has dashboard info showing (to see the widgets) 1. Log in to site as administrator, in the Institution settings, select 'Customisable theme' for Theme and select custom colours (default config theme colours are fine). 2. Save the institution 3. Log in as institution member and navigate to dashboard, hover over the dashboard widgets Expected results: The Dashboard widgets display in customised colours matching the header Actual results: The Dashboard widgets display in the Raw theme colours. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1893159/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1893159] A change has been merged
Reviewed: https://reviews.mahara.org/11240 Committed: https://git.mahara.org/mahara/mahara/commit/80340e7e73e8e30229b7e09e6e4513b9acff7990 Submitter: Cecilia Vela Gurovic (cecili...@catalyst.net.nz) Branch:20.04_STABLE commit 80340e7e73e8e30229b7e09e6e4513b9acff7990 Author: Lisa Seeto Date: Thu Aug 27 15:11:31 2020 +1200 Bug 1893159: Dashboard widgets are not receiving customisable theme styling - add in styling for widgets - add upgrade step to show warning to resave custom theme Change-Id: Ie6b46989200e4a19300ac228229dfe14bf0e8565 Signed-off-by: Lisa Seeto -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1893159 Title: Dashboard widgets are not receiving customisable theme styling Status in Mahara: Fix Committed Status in Mahara 20.04 series: Fix Committed Status in Mahara 20.10 series: Fix Committed Bug description: Currently the Dashboard widgets for "Create", "Share" and "Engage" do not receive the styling carried over from an institution's customisable theme (see attached screen shot) To replicate: Have an institution and at least one member who has dashboard info showing (to see the widgets) 1. Log in to site as administrator, in the Institution settings, select 'Customisable theme' for Theme and select custom colours (default config theme colours are fine). 2. Save the institution 3. Log in as institution member and navigate to dashboard, hover over the dashboard widgets Expected results: The Dashboard widgets display in customised colours matching the header Actual results: The Dashboard widgets display in the Raw theme colours. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1893159/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1893159] A patch has been submitted for review
Patch for "20.04_STABLE" branch: https://reviews.mahara.org/11240 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1893159 Title: Dashboard widgets are not receiving customisable theme styling Status in Mahara: Fix Committed Status in Mahara 20.04 series: Fix Committed Status in Mahara 20.10 series: Fix Committed Bug description: Currently the Dashboard widgets for "Create", "Share" and "Engage" do not receive the styling carried over from an institution's customisable theme (see attached screen shot) To replicate: Have an institution and at least one member who has dashboard info showing (to see the widgets) 1. Log in to site as administrator, in the Institution settings, select 'Customisable theme' for Theme and select custom colours (default config theme colours are fine). 2. Save the institution 3. Log in as institution member and navigate to dashboard, hover over the dashboard widgets Expected results: The Dashboard widgets display in customised colours matching the header Actual results: The Dashboard widgets display in the Raw theme colours. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1893159/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1893159] Re: Dashboard widgets are not receiving customisable theme styling
** Also affects: mahara/20.04 Importance: Undecided Status: New ** Also affects: mahara/20.10 Importance: Medium Assignee: Lisa Seeto (lisaseeto) Status: Fix Committed ** Changed in: mahara/20.04 Milestone: None => 20.04.2 ** Changed in: mahara/20.04 Status: New => Fix Committed ** Changed in: mahara/20.04 Importance: Undecided => Medium -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1893159 Title: Dashboard widgets are not receiving customisable theme styling Status in Mahara: Fix Committed Status in Mahara 20.04 series: Fix Committed Status in Mahara 20.10 series: Fix Committed Bug description: Currently the Dashboard widgets for "Create", "Share" and "Engage" do not receive the styling carried over from an institution's customisable theme (see attached screen shot) To replicate: Have an institution and at least one member who has dashboard info showing (to see the widgets) 1. Log in to site as administrator, in the Institution settings, select 'Customisable theme' for Theme and select custom colours (default config theme colours are fine). 2. Save the institution 3. Log in as institution member and navigate to dashboard, hover over the dashboard widgets Expected results: The Dashboard widgets display in customised colours matching the header Actual results: The Dashboard widgets display in the Raw theme colours. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1893159/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1893159] A change has been merged
Reviewed: https://reviews.mahara.org/11191 Committed: https://git.mahara.org/mahara/mahara/commit/d99b0d2dc2041c095dade7b31b9f4095707cbbb6 Submitter: Cecilia Vela Gurovic (cecili...@catalyst.net.nz) Branch:master commit d99b0d2dc2041c095dade7b31b9f4095707cbbb6 Author: Lisa Seeto Date: Thu Aug 27 15:11:31 2020 +1200 Bug 1893159: Dashboard widgets are not receiving customisable theme styling - add in styling for widgets - add upgrade step to show warning to resave custom theme Change-Id: Ie6b46989200e4a19300ac228229dfe14bf0e8565 Signed-off-by: Lisa Seeto -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1893159 Title: Dashboard widgets are not receiving customisable theme styling Status in Mahara: Fix Committed Bug description: Currently the Dashboard widgets for "Create", "Share" and "Engage" do not receive the styling carried over from an institution's customisable theme (see attached screen shot) To replicate: Have an institution and at least one member who has dashboard info showing (to see the widgets) 1. Log in to site as administrator, in the Institution settings, select 'Customisable theme' for Theme and select custom colours (default config theme colours are fine). 2. Save the institution 3. Log in as institution member and navigate to dashboard, hover over the dashboard widgets Expected results: The Dashboard widgets display in customised colours matching the header Actual results: The Dashboard widgets display in the Raw theme colours. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1893159/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1893159] Re: Dashboard widgets are not receiving customisable theme styling
** Changed in: mahara Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1893159 Title: Dashboard widgets are not receiving customisable theme styling Status in Mahara: Fix Committed Bug description: Currently the Dashboard widgets for "Create", "Share" and "Engage" do not receive the styling carried over from an institution's customisable theme (see attached screen shot) To replicate: Have an institution and at least one member who has dashboard info showing (to see the widgets) 1. Log in to site as administrator, in the Institution settings, select 'Customisable theme' for Theme and select custom colours (default config theme colours are fine). 2. Save the institution 3. Log in as institution member and navigate to dashboard, hover over the dashboard widgets Expected results: The Dashboard widgets display in customised colours matching the header Actual results: The Dashboard widgets display in the Raw theme colours. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1893159/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1883800] Re: Report configuration modal content truncated on small screen
I'm not marking this issue as duplicate though because we would lose the detail. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1883800 Title: Report configuration modal content truncated on small screen Status in Mahara: In Progress Bug description: When viewed in a small screen (i.e mobile) the modal content for configuring a report (admin/users/statistics.php) is truncated. To reproduce: 1. Navigate to Mahara site on small screen dimensions (i.e change the dimensions to mobile via the browser and log in as Admin 2. Navigate to the Reports page (Admin menu -> Reports) 3. Open the configuration modal (click on "Configure report") Expected results: All modal content is displayed. Actual results: Modal content is truncated (see attached screenshot) Versions: Mahara 20.04, 19.10, 19.04 To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1883800/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1883800] Re: Report configuration modal content truncated on small screen
This is addressed by Evonne in https://reviews.mahara.org/#/c/11078/ ** Changed in: mahara Milestone: None => 20.10.0 ** Changed in: mahara Status: Triaged => In Progress ** Changed in: mahara Importance: Undecided => Medium -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1883800 Title: Report configuration modal content truncated on small screen Status in Mahara: In Progress Bug description: When viewed in a small screen (i.e mobile) the modal content for configuring a report (admin/users/statistics.php) is truncated. To reproduce: 1. Navigate to Mahara site on small screen dimensions (i.e change the dimensions to mobile via the browser and log in as Admin 2. Navigate to the Reports page (Admin menu -> Reports) 3. Open the configuration modal (click on "Configure report") Expected results: All modal content is displayed. Actual results: Modal content is truncated (see attached screenshot) Versions: Mahara 20.04, 19.10, 19.04 To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1883800/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
