[Mahara-contributors] [Bug 1384467] A patch has been submitted for review

2021-05-02 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/11744

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1384467

Title:
  CSS is not stripping out bad css attributes anymore

Status in Mahara:
  Fix Released
Status in Mahara 1.10 series:
  Fix Released
Status in Mahara 15.04 series:
  Fix Released

Bug description:
  If I add some custom CSS to a skin that has badly formed css it
  doesn't strip out the bad lines.

  eg:

  #footer {
   color: #deface;
   top:cat;
   width: 300px;
   odd:fellow;
  }

  It used to strip it down to leave the valid lines.

  eg:

  #footer {
   color: #deface;
   width: 300px;
  }

  This looks to have been broken with this patch
  https://reviews.mahara.org/#/c/3846/

  Well not broken as such but the  $preserve_css should be able to be
  set via either the site config or directly in the config.php file so
  that only sites that want to allow things like comments in the css can
  turn it on rather than it be on by default for the skins.

  It still strips out html tags - so that is good

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1384467/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 796102] A patch has been submitted for review

2021-05-02 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/11744

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/796102

Title:
  User search index: db upgrade warning on postgres

Status in Mahara:
  Fix Released

Bug description:
  The DB upgrade fails on "if (!index_exists($table, $index)) {" (though
  it's a warning, not an error)

  The upgrade went through and finished but none of these new indexes
  were created.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/796102/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1539322] A patch has been submitted for review

2021-05-02 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/11744

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1539322

Title:
  Remove mobile device detection

Status in Mahara:
  Fix Released

Bug description:
  Mahara 15.10 introduced Bootstrap. All themes are now responsive. When
  I tested the "Deactivate device detection" functionality, I couldn't
  see much of a difference when using the site. I did notice the content
  chooser was displayed the start of the words instead of only showing
  the icon on the "Edit page" screen.

  I wonder if we can remove the custom device detection. You can enable
  the user turning off device detection in Admin -> Config site -> User
  settings -> Users can disable device detection. That then happens on
  the account settings page.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1539322/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1483077] A patch has been submitted for review

2021-05-02 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/11744

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1483077

Title:
  Problem with mysql upgrade - not escaping table name

Status in Mahara:
  Fix Released
Status in Mahara 1.10 series:
  Fix Released
Status in Mahara 1.9 series:
  Fix Released
Status in Mahara 15.04 series:
  Fix Released
Status in Mahara 15.10 series:
  Fix Released

Bug description:
  User getting error

  adodb_throw(SHOW INDEXES FROM group, )

  
https://mahara.org/interaction/forum/topic.php?id=7318&offset=0&limit=10#post29430

  Here the command uses a keyword 'group' without quoting it to be a
  table name

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1483077/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1619036] A patch has been submitted for review

2021-05-02 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/11744

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1619036

Title:
  ADODB error when edit page layout

Status in Mahara:
  Fix Released
Status in Mahara 16.10 series:
  Fix Released

Bug description:
  Version: master (16.10)

  I got the following error when editing a page layout

  [WAR] b0 (lib/adodb/adodb.inc.php:3496) Undefined offset: 0
  Call stack (most recent first):
  log_message("Undefined offset: 0", 8, true, true, 
"/var/www/html/mahara/master/htdocs/lib/adodb/adodb...", 3496) at 
/var/www/html/mahara/master/htdocs/lib/errors.php:513
  error(8, "Undefined offset: 0", 
"/var/www/html/mahara/master/htdocs/lib/adodb/adodb...", 3496, array(size 7)) 
at /var/www/html/mahara/master/htdocs/lib/adodb/adodb.inc.php:3496
  ADORecordSet->GetAssoc(true) at 
/var/www/html/mahara/master/htdocs/lib/dml.php:562
  recordset_to_assoc(object(ADORecordSet_postgres8)) at 
/var/www/html/mahara/master/htdocs/lib/dml.php:644
  get_records_select_assoc("view_layout", "layoutmenuorder > 0 AND iscustom = 
0", array(size 0), "layoutmenuorder", "id, id") at 
/var/www/html/mahara/master/htdocs/view/layout.php:54

  This happened after we upgraded ADODB to 5.20.5

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1619036/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1539346] A patch has been submitted for review

2021-05-02 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/11744

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1539346

Title:
  Upgrade adodb to 5.20.5

Status in Mahara:
  Fix Released

Bug description:
  Updating the adodb library

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1539346/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1898650] A patch has been submitted for review

2021-05-02 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/11744

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1898650

Title:
  Duplicate Collection View Displayorder

Status in Mahara:
  Fix Released

Bug description:
  Mahara: 19.10.04  ( 2019093018 )
  OS: Linux 16.04 (PHP 7.0)
  DB: Postgres
  Browser: FF / Chrome

  
  In certain situations, the users are able to create a collection where the 
displayorder of the pages are duplicated. i.e. 2 pages with displayorder = 0 in 
the collection_view table.

  I have no idea how this situation came about. I only saw it in one of
  our production sites.

  For 1 collection with 37 pages, there were:

  * 2 pages with displayorder = 0
  * 2 pages with displayorder = 1

  The remaining pages were ordered correctly starting from 2 onwards.

  The result was the error:

  'A nonrecoverable error occurred. This probably means you have
  encountered a bug in the system'

  When trying to go to the Pages and Collections screen.

  The offending subquery which returned multiple records for a column is
  in lib/view.php::get_myviews_data() line 3804:

  $collselect = '
  UNION
  SELECT (SELECT view FROM {collection_view} cvid WHERE 
cvid.collection = c.id AND displayorder = 0) as id,
  null AS vid, c.name as title, c.name AS vtitle, c.description, 
null as type, c.ctime as vctime, c.mtime as vmtime, c.mtime as vatime,
  c.owner, c.group, c.institution, null as locked, null as 
ownerformat, null as urlid, null AS vvisits,
 (SELECT COUNT(*) FROM {collection_view} cv WHERE 
cv.collection = c.id) AS numviews, c.id AS collid';

  
  As a side note, we really should not be calling subqueries for a column. This 
has huge performance issues since that subquery will be run for every row.

  I also note that there is another subquery to retrieve 'numviews'.
  Again, another performance hit.

  
  To eliminate the performance hit, the following should be changed:

  $collselect = '
  UNION
  SELECT cvid.view as id,
  null AS vid, c.name as title, c.name AS vtitle, c.description, 
null as type, c.ctime as vctime, c.mtime as vmtime, c.mtime as vatime,
  c.owner, c.group, c.institution, null as locked, null as 
ownerformat, null as urlid, null AS vvisits,
  numviews.numviews AS numviews, c.id AS collid';


  $collfrom = '
  FROM {view} v
  LEFT OUTER JOIN {collection_view} cv ON cv.view = v.id
  LEFT OUTER JOIN {collection} c ON cv.collection = c.id
  INNER join {collection_view} cvid on cvid.collection = c.id AND 
cvid.displayorder = 0
  INNER JOIN (SELECT COUNT(*) as numviews, numcv.collection 
  FROM {collection_view} numcv
  INNER JOIN {collection} numc ON numcv.collection = numc.id
  GROUP BY numcv.collection) as numviews on 
numviews.collection = cv.collection';

  
  and under 'mostcomments':

  $collgroupby = ' GROUP BY cvid.view, numviews.numviews, c.id';

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1898650/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1862370] A patch has been submitted for review

2021-05-02 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/11744

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1862370

Title:
  New submissions plugin

Status in Mahara:
  Fix Released

Bug description:
  This plugin adds a comfortable management of current and already released 
group submissions by providing a sort and filterable table in an own group tab 
including direct access to the portfolios resp. their archived version.
  Additional metadata is also provided together with the possibility to release 
the portfolio or to assign an evaluator and an evaluation result.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1862370/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1890973] A patch has been submitted for review

2021-05-02 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/11744

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1890973

Title:
  Behat: 'Shared with me' pages displayed in order of most recent
  comments

Status in Mahara:
  Fix Released

Bug description:
  Automating manual test:

  From the main menu click on Share
  select Shared with me (note: Shared by me doesn't have comment details,
  it has access details)
  Displays Title/Comments/Last comments page
  lists the most recently modified or commented on pages that have been shared 
with you
  They may have been shared with you directly, shared with friends of the 
owner, or shared with one of your groups, shared with registered users, or 
shared with the public.

  can add to /make_comment_public.feature to make sure this is covered:
  Add a test for the column headings and a test for the order of
  comments displayed. The existing test has pages sharing and comments,
  so should be straight-forward.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1890973/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1898502] A patch has been submitted for review

2021-05-02 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/11744

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1898502

Title:
  Android tablet - TinyMCE editor allows all 6 heading sizes

Status in Mahara:
  Fix Released
Status in Mahara 20.10 series:
  Fix Committed
Status in Mahara 21.04 series:
  Fix Released

Bug description:
  Environment: master.dev
  Platform/s: Android versions 7 & 9 with Chrome and also Firefox

  Release 20.10 uses TinyMCE version 5.0 which is now described on their
  web-site as 'legacy' for mobile, fixing this may require upgrading
  TinyMCE.  Web site: https://www.tiny.cloud/docs/mobile/

  Precondition: Logged in person has a page with a text block.

  Steps:
  1. Logged in user chooses to edit a text block (tap block), selects some text 
to make into a heading, and using the 'T' option selects to view the 'Styles' 
Headings options and selects a heading style (should only be 3 choices 
available).

  Expected results: only three headings are available for selection (and
  when the updated page is viewed and the heading 'Inspected', it shows
  use of either h4, h5 or h6).

  Actual result: there are 6 options available and if 'Heading 1' is
  selected, when the updated page is viewed and the heading 'Inspected',
  it shows use of h1.

  Refer to Bug #1895213

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1898502/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1892428] A patch has been submitted for review

2021-05-02 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/11744

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1892428

Title:
  Turn peer role into configurable role so it can see content

Status in Mahara:
  Fix Released

Bug description:
  It shall be possible for a peer to see the portfolio content.
  Currently, Mahara does not allow someone with the 'Peer' role to see
  the content of the portfolio pages to which the peer has access to.
  This is restrictive for some organisations. Therefore, we are going to
  turn it into an institution setting so that an institution
  administrator can determine how that role shall behave.

  Since this is an assessment feature that may be more often then not be
  determined by an organisation rather than individuals, it is best to
  make it an institution setting and not require the decision to be made
  on each individual peer block.

  We propose to create a new institution setting 'Allow peers to see
  portfolio content' for the peer role with the two possible states:

  1. Can't see any content but can create peer assessment (the current setting)
  2. Can see the entire portfolio and can create peer assessment

  This setting decides what the peer assessor can do when they are
  commenting on a portfolio in that particular institution.

  More details as determined with Cecilia:

  1. A new field will be added to institution settings.

  If set to 'Yes': if the portfolio owner belongs to this institution,
  all account holders that have peer role access to that portfolio will
  be able to see the block contents.

  For multiple institutions: If the owner of the portfolio belongs to
  more than one institution, then the most restrictive rule will apply.
  In other words, if an account holder has peer access to a portfolio,
  they will be able to see the block content only if all the
  institutions the owner belongs to have this setting set to 'Yes'.

  Default value will be 'No'. This will be saved on the
  'institution_config' table on the DB.

  This new field could be placed just below 'Allow public institution
  portfolios'.

  Field name: Allow peers to see portfolio content

  Description: Allow account holders who receive the 'Peer' role on a
  portfolio to see the entire content in the portfolio.

  Help file text: The 'Peer' role is only available for portfolio
  access. If it is set to 'No', the peer can only see the block headings
  on pages on which peer assessments are required. On pages where there
  is no peer assessment, they will not be able to see anything. If an
  account holder has the role of 'Peer and manager', they can always see
  the entire portfolio, no matter this setting here.

  2.Accessing a portfolio by a peer

  The check to see whether a peer can see the block content or not will
  be done when rendering a block instance (on view display).

  This change can be done in the PluginBlocktype class, by adding a code
  to the display_for_roles function. This is the function that defines
  if the block should display content or not.

  If an account holder has more than one portfolio access role, then the more 
permissive one counts, e.g. account holder has
  a) Peer role with access to content in one institution and peer role without 
access to content in another institution: Can't see content (see 1 above)
  b) Peer role without access to content and manager role, i.e. 'Peer and 
manager', then they can see the content on the portfolio because the manager 
role is more permissive and thus counts.
  b) Peer role with access to content and manager role: Can see content

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1892428/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1904946] A patch has been submitted for review

2021-05-02 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/11744

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1904946

Title:
  Filebrowser - Uploading number of files exceeding limit gives never-
  ending spinner

Status in Mahara:
  Fix Released

Bug description:
  In the /etc/php/7.2/apache2/php.ini files it states max_file_uploads =
  20

  Trying to upload more than max_file_uploads in one request will cause
  the wrong error messages to appear.

  Reproduce:
  1. Create -> Files -> Browse
  2. Select 21 files and click 'ok'

  Expect:
  - Info messages appear for each upload-file saying it's being uploaded
  - Once uploaded, the matching info message turns to a temp success message 
(green) and disappears
  - All the selected files have been uploaded and appear in the user's list of 
files

  Actual:
  - Info messages appear for each upload-file saying it's being uploaded
  - The the 21st file does not get uploaded due to the restriction but the user 
doesn't know about the restriction
  - The info message matching the 1st file in the selected upload-list stays 
forever spinning.

  Notes:
  - Even if a message stays spinning forever because there was a file(s) that 
didn't get uploaded, the text in the message should match the non-uploaded file
  - There should be a message informing the user of the max number of files 
they're allowed to upload at any one time
  - The filebrowser could prevent the user from selecting more than the 
max_file_uploads number

  Todo:
  - (Maximum upload size: [SPACE AVAILABLE]MB, maximum file uploads: [VALLUE 
FROM PHP.INI FILE], check what happens when PHP.ini doesn't have a value for 
max_file_uploads)
  - Error message: replace info message with an error message for the same file.
  - (nice to have)check upload_validate js function to check if we can alert 
the user before files are uploaded

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1904946/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1906708] A patch has been submitted for review

2021-05-02 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/11744

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1906708

Title:
  The Mahara docker environment needs a sendmail program.

Status in Mahara:
  Fix Released

Bug description:
  The dev docker environment requires a /usr/sbin/sendmail program to
  accept mail.  Without this some Behat tests fail. And some web pages
  will display errors about being unable to send mail.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1906708/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1903478] A patch has been submitted for review

2021-05-02 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/11744

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1903478

Title:
  View update of description breaks for pages owned by deleted group

Status in Mahara:
  Fix Released
Status in Mahara 20.10 series:
  Fix Committed
Status in Mahara 21.04 series:
  Fix Released

Bug description:
  Original report at
  https://mahara.org/interaction/forum/topic.php?id=8730

  When running upgrade to move the description field info to be a block
  on the page there is an error if the page is a group page and belongs
  to a group that has been deleted.

  The problem occurs because there is some code in the view constructor
  that throws an error in this instance.

  Will need to adjust the upgrade to ignore the viewids that meet this
  criteria

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1903478/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1906596] A patch has been submitted for review

2021-05-02 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/11744

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1906596

Title:
  Update developer docker options to use compose

Status in Mahara:
  Fix Released

Bug description:
  Update developer docker instructions to use compose, and update docker
  readme to reflect it.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1906596/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1909116] A patch has been submitted for review

2021-05-02 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/11744

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1909116

Title:
  Unable to install MAHARA 20.10 on Mysql 5.6

Status in Mahara:
  Fix Released

Bug description:
  Hi,

  I tried installing Mahara 20.10.0 on PHP 7.2 and MYSQL 5.6 However I
  am unable to install it with Mysql 5.6 Getting "failed to upgrade"
  error message on installing core module.

  I also tried to install it with Mysql 5.7 and its working fine.

  Does Mahara supports Mysql 5.6 ? If not then please change the docs
  for minimum requirements.
  https://github.com/MaharaProject/mahara/blob/20.10.0_RELEASE/README.md
  #system-requirements

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1909116/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1907000] A patch has been submitted for review

2021-05-02 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/11744

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1907000

Title:
  recent/tagged journal entries block creates new entry on dragging

Status in Mahara:
  Fix Released

Bug description:
  When we are on the editing view of a page, the '+ New entry' text that
  appears on the top of the journal block, recent journal entries block,
  and tagged journal entries block is only detected as a button for the
  journal block and not the other two.

  Dragging the recent journal entries block and tagged journal entries
  block's '+ New entry' area to reposition the block on the tag (upon
  releasing the mouse) opens up the '+ New entry' page.

  Reproduce:
  - create journal entries
  - add tags to some entries
  - create a new page
  - add a journal block (configured correctly so that it displays journal 
entries)
  - add a recent journal entries block (configured correctly so that it 
displays journal entries)
  - add a tagged journal entries block (configured correctly so that it 
displays journal entries)
  - on the edit view, move the mouse over the texts '+ New entry'

  Expected: All three blocks with mouse hover displays a pointer
  Actual: Only the journal block appears with a pointer on hover

  - drag the recent journal entries block

  Expected: Reposition the block to the new location
  Actual: The page is directed to the new journal entry page

  - drag the tagged journal entries block

  Expected: Reposition the block to the new location
  Actual: The page is directed to the new journal entry page

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1907000/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1915961] A patch has been submitted for review

2021-05-02 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/11744

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1915961

Title:
  Change date format in CSV export for 'Account details' report

Status in Mahara:
  Fix Released

Bug description:
  When you download the 'Account details' report as CSV file, the date
  for the last login is mentioned as 14 June 2021, 7:40. That makes it
  impossible to sort the column. The date in the export should be
  displayed as 2021-06-14, 7:40 instead so sorting is possible. However,
  when viewing the report online, the date format can stay for easier
  readability. It also looks like the sorting is done there correctly.

  To replicate:

  1. Add a few people to your site and log in as them. Masquerading won't help 
there.
  2. Go to Admin menu -> Reports -> Accounts details report and activate the 
column 'Last login'.
  3. View the report and see the login dates.
  4. Download the CSV file.

  Results:
  - Expected: The date column in the CSV file can be sorted and shows the date 
as 2021-06-14, 7:40
  - Actual result: The date column can't be sorted.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1915961/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1915366] A patch has been submitted for review

2021-05-02 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/11744

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1915366

Title:
  Allow docker-compose to run multpile instances on one host

Status in Mahara:
  Fix Released

Bug description:
  These changes build on the mailhog addition:

  It adds a new compose file for shared containers:
  * A new container, Nginx provides routing between the web containers.
  * Mailhog is shared between all containers.

  In future the PostgreSQL container could be shared but is not
  currently done for the sake of simplicity.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1915366/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1913504] A patch has been submitted for review

2021-05-02 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/11744

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1913504

Title:
  Issues with postgres 12 and adsrc column

Status in Mahara:
  Fix Released
Status in Mahara 19.10 series:
  In Progress
Status in Mahara 20.04 series:
  In Progress
Status in Mahara 20.10 series:
  In Progress
Status in Mahara 21.04 series:
  Fix Released

Bug description:
  Get this error:

  EXECUTE("SELECT d.adnum as num, d.adsrc as def from pg_attrdef d,
  pg_class c where d.adrelid=c.oid and c.relname='usr_login_data' order
  by d.adnum")

   Call stack (most recent first):
* exception(object(ADODB_Exception)) at Unknown:0
   [DBG] d3 (lib/errors.php:692) Exception thrown by smarty call while handling 
exception:
   [DBG] d3 (lib/errors.php:692) [ADODB_Exception]: postgres8 error: [-1: 
ERROR:  column d.adsrc does not exist
   [DBG] d3 (lib/errors.php:692) LINE 1: SELECT d.adnum as num, d.adsrc as def 
from pg_attrdef d, pg_...#012PHP message: [DBG] d3 (lib/errors.php:692) 

  To fix it we need to do the following

  https://github.com/ADOdb/ADOdb/issues/562

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1913504/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1915352] A patch has been submitted for review

2021-05-02 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/11744

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1915352

Title:
  Problem with view_instructions_lock when deleting a page

Status in Mahara:
  Fix Released
Status in Mahara 20.10 series:
  Fix Committed
Status in Mahara 21.04 series:
  Fix Released

Bug description:
  When we delete a page we remove the view_instructions_lock row for the
  copied views if there is a match but not for the originaltemplate if
  there is a match

  When we delete a view we need to do both
  delete_records('view_instructions_lock', 'view', $this->id);
  and
  delete_records('view_instructions_lock', 'originaltemplate', 
$this->id);

  We also need to have an upgrade step to fix sites where they upgraded so that 
the 
  "viewinstlock_ori_fk" FOREIGN KEY (originaltemplate) REFERENCES view(id)

  exists on the view_instructions_lock table

  This relates to a mistake in
  https://reviews.mahara.org/#/c/10825/

  To test:

  1 Make a new site (note it has to be new and not upgraded)
  2 Make a new user
  3 Make an institution
  4 Make an institution page for this institution and set Advanced -> Template 
to 'yes'
  5 Go to share for the page and under Advanced options ->  Copy for new 
institution members to 'yes'
  6 Add a user to institution
  7 Delete the original institution page

  You should get the following error
  ERROR:  update or delete on table "view" violates foreign key constraint 
"viewinstlock_ori_fk" on table "view_instructions_lock"

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1915352/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1915985] A patch has been submitted for review

2021-05-02 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/11744

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1915985

Title:
  Upgrade Gridstack from v0.4.0 to v0.6.4

Status in Mahara:
  Fix Released

Bug description:
  https://github.com/gridstack/gridstack.js/releases?after=v2.2.0

  v1.2.0 - update to jquery v3.5.1
  v2.2.0
  - drop support for IE11
  - remove all jQuery from main code and API (except jqueryui) rewrite to 
typescript
  v2.0.1
  v2.1.0

  we will only jump to the latest version of the current major 0.
  version for now to be time conscious of release coming up.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1915985/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1915980] A patch has been submitted for review

2021-05-02 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/11744

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1915980

Title:
  Upgrade Dropzone from v5.7.0 to v5.7.6

Status in Mahara:
  Fix Released

Bug description:
  Changelog: mainly minor fixes and small changes
  -> 
https://github.com/dropzone/dropzone/blob/62d5dbce13421faa84dcae6ae6b6a55aa5ec0e30/CHANGELOG.md

  Note: 5.7.3 (retracted due to problems) - ignore this version

  We should upgrade to v5.7.6

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1915980/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1915469] A patch has been submitted for review

2021-05-02 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/11744

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1915469

Title:
  Making theming of buttons more efficient

Status in Mahara:
  Fix Released

Bug description:
  Buttons in list-group-item that float right and stick to the top
  hav various breakpoints that do different things, so redoing them
  to use flex in a more consistent way and reduce the need for many
  overrides in the theme.

  Expected behaviour:
  In list-group-items, edit and delete buttons etc stick to the top
  right corner of that list-group item at all browser widths, even
  if title wraps.

  Actual behaviour:
  The buttons stick at the top when in desktop width, then unstick
  on tablet view, and some align to left at some breakpoint, and when
  title wraps it would unstick at desktop width, or neglect the
  user icon if there is one to the left of the title.

  Additionally, improving the CSS for input select, drop-down select,
  switches, etc. buttons to prevent too many overrides when the buttons
  are styled more graphically.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1915469/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1915986] A patch has been submitted for review

2021-05-02 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/11744

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1915986

Title:
  Upgrade Javascript Templates from v3.11.0 to v3.19.0

Status in Mahara:
  Fix Released

Bug description:
  Doesn't look like anything has changed - should be a straight forward
  upgrade.

  https://github.com/blueimp/JavaScript-
  Templates/compare/v3.19.0...v3.11.0

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1915986/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1915988] A patch has been submitted for review

2021-05-02 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/11744

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1915988

Title:
  Upgrade json editor from 1.3.0 to 1.3.5

Status in Mahara:
  Fix Released

Bug description:
  https://github.com/json-editor/json-editor/blob/master/CHANGELOG.md

  v1.3.3 Minor fixes
  v1.3.4 Minor fixes

  Leaving the 2.0.0 for another fix as it seems there is a lot that
  needs fixing

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1915988/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1915989] A patch has been submitted for review

2021-05-02 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/11744

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1915989

Title:
  Upgrade marked  from v1.1.1 to v2.0.0

Status in Mahara:
  Fix Released

Bug description:
  https://github.com/markedjs/marked/releases/tag/v2.0.0

  Breaking changes to do with keywords and removing support for IE11

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1915989/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1915978] A patch has been submitted for review

2021-05-02 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/11744

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1915978

Title:
  Upgrade CSS Tidy from v1.7.1 to v1.7.3

Status in Mahara:
  Fix Released

Bug description:
  Minor bug fix. We should update to version 1.7.3

  https://github.com/Cerdic/CSSTidy

  Not sure how to test this yet.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1915978/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1915973] A patch has been submitted for review

2021-05-02 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/11744

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1915973

Title:
  Update ADODB from 5.20.18 to 5.20.20

Status in Mahara:
  Fix Released

Bug description:
  Adodb requires some changes to work with PHP 8. 
  https://github.com/ADOdb/ADOdb/blob/v5.21.0-rc.1/docs/changelog.md

  The release on January 31, 2021 includes fixes for some of the current
  issues: https://github.com/ADOdb/ADOdb/milestone/2 RC 5.21 looks
  further in to PHP 8 compatibility, we should updates our version when
  it is released properly.

  We are currently on 5.20.18.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1915973/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1916654] A patch has been submitted for review

2021-05-02 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/11744

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1916654

Title:
  Links that point to the page editor page in the Mahara manual don't
  work any more

Status in Mahara:
  Fix Released
Status in Mahara 20.04 series:
  In Progress
Status in Mahara 20.10 series:
  In Progress
Status in Mahara 21.04 series:
  Fix Released

Bug description:
  When you edit a page in Mahara and click the 'Help' link in the page
  footer, you are taken to
  manual.mahara.org/en/20.10/portfolio/page_editor.html, which does not
  exist any more. The link needs to be updated.

  This is an issue for Mahara 20.04+.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1916654/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1915998] A patch has been submitted for review

2021-05-02 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/11744

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1915998

Title:
  Upgrade videojs from v7.6.5 to v7.11.4

Status in Mahara:
  Fix Released

Bug description:
  https://github.com/videojs/video.js/releases

  Performance updates, minor fixes, minor features, with chores to do.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1915998/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1915992] A patch has been submitted for review

2021-05-02 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/11744

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1915992

Title:
  Upgrade momentjs from v2.24.0 to v2.29.1

Status in Mahara:
  Fix Committed

Bug description:
  Lots of changes especially locale, no breaking changes.

  https://github.com/moment/moment/blob/develop/CHANGELOG.md

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1915992/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1915997] A patch has been submitted for review

2021-05-02 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/11744

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1915997

Title:
  Upgrade tinymce from v5.0.13 to v5.7.0

Status in Mahara:
  Fix Released

Bug description:
  https://www.tiny.cloud/docs/changelog/

  There's been a lot of change - a mix of everything. Not sure how much
  there is to do.

  A few security fixes: at v5.1.6 and v5.6.0

  Mahara specific things to test:
  - mathslate: mathjax needs to be turned on via settings and there should be a 
square root icon beside the emoticon icon in the tinymce menu
  - adding an image into tinymce, allowing image uploads from Mahara

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1915997/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1915987] A patch has been submitted for review

2021-05-02 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/11744

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1915987

Title:
  Upgrade jscolor from v2.3.3 to v2.4.5

Status in Mahara:
  Fix Released

Bug description:
  Looks to be small upgrades:
  https://jscolor.com/release/2.4/CHANGELOG.txt

  Let's upgrade up for the minor fixes and added support

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1915987/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1917382] A patch has been submitted for review

2021-05-02 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/11744

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1917382

Title:
  Update composer.json file to upgrade libraries

Status in Mahara:
  Fix Committed

Bug description:
  Updating libraries in composer.json

  - PHPUnit to v8
  - tbc

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1917382/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1916997] A patch has been submitted for review

2021-05-02 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/11744

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1916997

Title:
  Tidying up some phpdocs in library files

Status in Mahara:
  Fix Released

Bug description:
  Adding in / tidying up errors with docblocks found with phpdoc

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1916997/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1919273] A patch has been submitted for review

2021-05-02 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/11744

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1919273

Title:
  Trigger off fast_index.php when reindexing the site with elasticsearch

Status in Mahara:
  Fix Released

Bug description:
  When we re-index the site it can take a while to re-index everything
  on larger sites.

  We already have a fast_index.php CLI script to speed this up - but it
  would be better to fire this off as part of the re-index rather than
  run it separately

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1919273/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1918367] A patch has been submitted for review

2021-05-02 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/11744

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1918367

Title:
  LTI accessing pages of collection when link is for
  progresscompletion.php page

Status in Mahara:
  Fix Released
Status in Mahara 20.10 series:
  In Progress
Status in Mahara 21.04 series:
  Fix Released

Bug description:
  We made a fix in Bug #1891575 for allowing the LTI access to any page
  in the collection but we didn't take into account the
  collection/progresscompletion.php page (if enabled) as that ID is not
  a view ID but the collection ID

  We need to adjust the check so that we can handle this situation

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1918367/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1922628] A patch has been submitted for review

2021-05-02 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/11744

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1922628

Title:
  'More options' button pages has 'Manage access' option

Status in Mahara:
  Fix Released

Bug description:
  My story
  ==

  As an account holder I want to be able to give access to my portfolio
  directly from any portfolio page so that I can enter the 'Edit access'
  screen without needing to go into 'Edit' mode or in the case of the
  portfolio completion page to another page or 'Shared by me'.

  How
  ==

  * The 'More options' button becomes available for portfolio authors on the 
'Portfolio completion' page and on the SmartEvidence page.
  * It contains the option 'Manage access' that takes the author to the 'Edit 
access' screen for the portfolio.
  * On a regular portfolio page, the 'More options' button also contains 
'Manage access'.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1922628/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1922514] A patch has been submitted for review

2021-05-02 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/11744

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1922514

Title:
  Profile completion preview doesn't list tips

Status in Mahara:
  Fix Released

Bug description:
  When you set up the profile completion for an institution at
  /admin/users/institutions.php (site admin needs to allow it in Admin
  menu -> Configure site -> site options -> Side block settings) then
  you see the 'Profile completion preview' and the text 'Profile
  completion tips' is rather large in there. It also shows up when you
  are a member of an institution that has it turned on and configured in
  your personal side block.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1922514/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1922624] A patch has been submitted for review

2021-05-02 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/11744

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1922624

Title:
  Create a default option for comments on the 'Note' block and for pages

Status in Mahara:
  Fix Released

Bug description:
  We can't set a default for allowing or not allowing of comments on new
  'Note' blocks. This is to be added to the 'internal' plugin type
  artefact at the bottom of the page in a new section 'Default comment
  permission'. That way, future additional default settings could be
  added there. The default comment setting for files stays in the 'file'
  plugin type artefact.

  Additionally, create a site setting that sets the default for page
  comments.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1922624/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1922627] A patch has been submitted for review

2021-05-02 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/11744

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1922627

Title:
  Granular options which portfolios to see in 'Latest changes I can
  view'

Status in Mahara:
  Fix Released

Bug description:
  My story
  ==

  As an account holder I want to be able to determine which portfolios
  to show on the dashboard in the block 'Latest changes I can view' so
  that I can access them quickly but don't necessarily see all of them.

  How
  ==

  1. Add configurable option (labelled like the tick boxes like on 'Shared with 
me') to the 'Latest changes I can view' block to decide which portfolios to 
display in the block. 
  2. All options are set to 'Yes' in the dashboard template per default, i.e. 
me, friends, my groups, my institutions, registered people, and public.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1922627/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1922632] A patch has been submitted for review

2021-05-02 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/11744

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1922632

Title:
  Restrict with how many people or groups of people you can share your
  portfolio

Status in Mahara:
  Fix Released

Bug description:
  My story
  ==

  As site admin I want restrict with how many people portfolios can be
  shared via a config.php setting so that I have more control,
  especially when the site is used for very specific purposes.

  How
  ==

  * Create a new config.php value only (no site options on front-end setting) 
that allows you to set a limit.
  * Per default, no limit is set.
  * For the accesslistmaximum config value: When it is set, an info alert is 
displayed above the sharing table, letting a portfolio author know with how 
many entities they can share their portfolio, e.g. 'You can share your 
portfolio with up to 1 person or group of people.' plural form: You can share 
your portfolio with up to X people or groups of people.'

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1922632/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1922634] A patch has been submitted for review

2021-05-02 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/11744

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1922634

Title:
  'Portfolio review' block

Status in Mahara:
  Fix Released

Bug description:
  My story
  ==

  As an institution admin I want to set up portfolio reviews so that
  verifiers, managers, auditors, etc. can make their statements, either
  predefined or as a comment.

  How
  ==

  * Make it possible for the 'Portfolio completion' progress page to receive 
blocks.
  * Create a new block 'Portfolio review' that can only be added to the 
'Portfolio completion' progress page. Note: Use the allowed_in_view() function 
but adjust it so that if one is copying a page with the block on it copies 
across.
  * When the block has been added to a portfolio marked as template, then only 
the template author / author group (in our case institution administrators) can 
make changes to the block on the template and thus see the page 'Edit' button.
  * The 'Edit' button for the completion page is visible though on all when the 
portfolio is not a template and thus a regular portfolio author could add the 
review blocks in their personal pages and create a template there.
  * Statements are locked from editing when the portfolio is marked as 
'Template' and copied into an account. The block config is copied along. A 
portfolio author who copied a template cannot make any changes to the 
'Portfolio completion' page and doesn't see the 'Edit' button.
  * The block can be placed onto the page multiple times.
  * The block and its configuration is copied when the portfolio is copied.
  * The block on the 'Portfolio completion' page is only visible to the group 
of people who are allowed to complete the statement. Only when they have 
completed the statement will it be displayed to the portfolio author and any 
other viewer.
  * Create a 'Reviewer' role that is generic to the system and can be applied 
on the 'Edit access' screen. At the moment, the only purpose would be for 
selecting a subgroup of people for review, but that could be expanded in the 
future for other things. That's why it's not to be tied to the review block.

  
  Resetting statement
  -

  * Portfolio author or reviewer clicks the 'More options' button on the 
portfolio completion page and clicks the link 'Reset review'.
  * Modal comes up from the top, where they can select the review statement 
(pre-made statement or comment statement) they want to have reverted. The block 
title is displayed in the drop-down menu.
  * They only see the statements though they are allowed to ask to be reverted.
  * Write some explanatory text.
  * Notification is sent to the person or groups of people that are allowed to 
revert a statement. For group admins that means the admins of the group with 
whom the portfolio is shared, for example.
  * Person who can revert the statement receives temporary access to the 
portfolio to reset the statement without needing to be added to the access 
rules (like with objectionable content).
  * Notification is sent to the person who wanted the reset so they know it's 
been actioned.

  
  Display on the page
  --

  * Blocks are only shown to groups of people who have been selected to be able 
to confirm the statement to which they have access until they have confirmed 
the statement or added a comment. Before then, they are not shown to the 
portfolio author or other viewers. This is to prevent the auditor statement 
option to be seen when the majority of people will not need it.
  * Use an empty tick box (Font Awesome icon 'square') instead of the grey dot 
when there is a statement to complete.
* When reviewer clicks it, there is a confirmation modal that tells them of 
the consequences for proceeding, i.e. portfolio is locked from editing, they 
cannot revert their selection and could only do that by contacting their 
administrator, no other verifier can be selected.
* The tick that is displayed once statement has been confirmed is a square 
box with a tick (Font Awesome icon 'check-square').
  * When the statement is not yet available due to the date, then display a 
grey line and an info box right above the respective statement to indicate when 
it becomes available. 
  * Primary statement is displayed differently from other statements and thus 
needs its own class so that it can be targeted.
  * When name of reviewer can be displayed, each ticked review mentions the 
reviewer's name (preferred name function) with a link to their profile page and 
the date and time when the statement was approved.
  * When the statement requested not to display the reviewer's name, then only 
the date and time are displayed.
  * When a statement has a comment field, 
* have draft and publish states (like fo

[Mahara-contributors] [Bug 1922630] A patch has been submitted for review

2021-05-02 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/11744

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1922630

Title:
  More useful information on the 'Portfolio completion' overview page

Status in Mahara:
  Fix Released

Bug description:
  Listed here are the changes that are to be made to the existing
  portfolio completion page.

  * Info icon (same as for other contextual help) is displayed after the page 
title that can be clicked (rather than hover) to display the page description. 
That allows for more consistency across desktop and mobile devices. The styling 
and CSS is like the contextual help with H1 for the heading.
  * When there is no page verification turned on (via the sign-off block), the 
'Verification' column is not shown.
  * Verifier statements are displayed below the list of pages and verifier can 
tick them. The display of them is managed in the 'Verifier statement' wishlist 
item.
  * For portfolio author, display the 'More options' button with a link to 
'Manage access'. This is done in a separate wishlist item as well.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1922630/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1922680] A patch has been submitted for review

2021-05-02 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/11744

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1922680

Title:
  Portfolio viewer removes themselves from a portfolio

Status in Mahara:
  Fix Released

Bug description:
  My story
  ==

  As a portfolio viewer I want to remove myself from a portfolio so that
  I do not see the portfolios on my list of portfolios to which I have
  access.

  How
  ==

  **Important**: This applies only to access that has been given to a
  person themselves, not public, registered accounts, group access, e.g.
  view access table has user column set with an ID.

  * When a portfolio has been shared with a person, that person sees an 
additional option on each portfolio page via the 'More options' button: A trash 
icon in red and the text 'Remove my access' (not in red).
  * When a portfolio has been shared with a person, that person can remove 
their own access on 'Shared with me' by clicking the 'Remove my access' icon.
  * When the icon / button is clicked, a confirmation modal is displayed that 
states that access is lost to the entire portfolio. 
  * The modal contains a message field allowing the viewer to provide a reason 
(similarly to the 'Objectionable content' modal).
  * Notification is sent to the portfolio author with the decision by the 
reviewer.
  * Viewer is removed from the access list for the portfolio.
  * The date and time when the viewer removes themselves is recorded in the 
event log.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1922680/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1922635] A patch has been submitted for review

2021-05-02 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/11744

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1922635

Title:
  Add portfolio completion information to 'Shared with me' page

Status in Mahara:
  Fix Released

Bug description:
  My story
  ==

  As a portfolio viewer I want to see the sign-off and verification
  status of a portfolio on 'Shared with me' so that I can quickly see
  what state the portfolios are in and whether I want to take a closer
  look.

  It doesn't matter whether I am the reviewer for a portfolio or not.
  The existing columns remain.

  How
  ==

  * New column added to the list when portfolio has been shared personally: 
* 'Remove my access', which allows the person who has received personal 
access to the portfolio to remove themselves. This is only possible if the 
portfolio has been shared with a particular person (or friend), but not when 
shared with a group, institution, site, public.
  * New column added when portfolio completion page exists: Show percentage of 
the sign-off and verifications, i.e. the same percentage displayed on the 
'Portfolio completion' page itself.
  * New column added when a **primary** review statement can be completed:
* Icon (line) indicates whether the portfolio the viewer has access to is 
one they could review for the primary statement.
* Icon empty check box is displayed when a statement I can make hasn't been 
made yet. That also applies to statements that only consist of a comment. 
Clicking the icon does *not* change its status but takes the reviewer to the 
page itself so they can review the portfolio first.
* Icon green tick box is displayed when a statement the reviewer made has 
been completed.
  * Accessibility text needs to include name of the portfolio author and the 
title of the portfolio for the icons.
  * Icon 'tooltip' text:
* Review not available yet: 'Review for the portfolio "Title" by NAME 
cannot yet be made'.
* Review to be done: 'Complete review for the portfolio "Title" by NAME'.
* Review done: 'Completed review for the portfolio "Title" by NAME'.
* Remove access: 'Remove my access from the portfolio "Title" by NAME'.

  
  **Important**: This applies only to access that has been given to a person 
themselves, not public, registered accounts, group access, e.g. view access 
table has user column set with an ID.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1922635/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1922689] A patch has been submitted for review

2021-05-02 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/11744

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1922689

Title:
  Report: Completion and review

Status in Mahara:
  Fix Released

Bug description:
  My story
  ==

  As an institution admin I want to see easily which portfolio author
  has which verifier (the role of 'Reviewer') so that I can report over
  that information and intervene if necessary.

  How
  ==

  General information for the report
  --

  * Normal reporting capabilities are retained, e.g. that when a person is 
selected, reports are only shown for them where applicable reports are 
available, select data range, configuration selected on the configuration 
screen, columns are sortable (unless where it does not make sense due to the 
data, which should be mentioned).
  * When 'Personal information' is mentioned, this means:
* First name, last name, display / preferred name, username, student ID. 
* Preferred name is ticked per default but can be unticked and other fields 
selected instead.
  * Each column (but personal information and email) receives help text icon.
  * Each column is sortable (unless where it does not make sense due to the 
data, which should be mentioned).

  Report-specific
  -

  No dashboard graph

  Columns:

  * Personal information for portfolio author
  * Email address for portfolio author
  * Portfolio title
  * Portfolio creation date
  * Template title with link to it
  * Personal information for reviewer
  * Email address for reviewer
  * Date on which reviewer received access to the portfolio 
  * Three separate columns: 
* Date on which reviewer access was revoked by the portfolio author,
* Date on which the reviewer removed themselves, or 
* Date when the reviewer was removed by the system automatically. -> This 
may just be commented out as the automatic removal depends on a few other things
  * Date on which reviewer ticked the primary statement. 
  * Percentage of completion in sign-off block (per individual → a given 
because the report is not an aggregated one) as per progress bar on the 
portfolio completion progress page at the end date of the selected date range.
  * On configuration screen a multi-select filter allows to select which 
portfolio templates to display its copies (if site is selected, all institution 
and site templates are mentioned, but if institution is selected, only 
institution templates are listed; no other templates can be selected). This 
helps ensure that the correct template is used. This needs to be a sticky 
selector that only needs to be set once and doesn't change until it is changed 
again:
 * All
 * Portfolios created from institution / site template 1
 * Portfolios created from institution / site template 2
  * On configuration screen select filter for reviewer, i.e. static drop-down 
menu for the 'Reviewer' role:
* Show all
* Show only portfolio authors that have a current reviewer (ignores 
reviewers that have been removed)
* Show only portfolio authors that don't have a current reviewer
  * Date selector: Include portfolios that were created during the selected 
time frame. That allows to capture regular and pro-rated portfolios. The filter 
then takes care of whether a portfolio is potentially listed multiple times or 
only once. → A portfolio author would be listed more than once if they switched 
reviewers.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1922689/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1922683] A patch has been submitted for review

2021-05-02 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/11744

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1922683

Title:
  Send notification when revoking access for a person

Status in Mahara:
  Fix Released

Bug description:
  My story
  ==

  As a portfolio author I want to revoke the access for a person I gave
  access to my portfolio and send a notification to that person letting
  them know about this change.

  How
  ==

  When a portfolio author removes someone whom they added by 'Search for
  person or friend' from having access to their portfolio, a system
  notification is sent to that person who is being removed informing
  them about the removal. The date and time is recorded in the event
  log.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1922683/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1922704] A patch has been submitted for review

2021-05-02 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/11744

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1922704

Title:
  Fix heading styles in instructions

Status in Mahara:
  Fix Released

Bug description:
  The heading styles in the instructions look different than the same
  heading styles in the regular text block content part.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1922704/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1922692] A patch has been submitted for review

2021-05-02 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/11744

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1922692

Title:
  Report: Reviewer summary

Status in Mahara:
  Fix Released

Bug description:
  My story
  ==

  As an institution admin I want to see quickly how many portfolios
  reviewers have been assigned so that I can report over that number and
  see trends developing or if too many portfolios for a reviewer
  intervene.

  
  How
  ==

  General information for the report
  --

  * Normal reporting capabilities are retained, e.g. that when a person is 
selected, reports are only shown for them where applicable reports are 
available, select data range, configuration selected on the configuration 
screen, columns are sortable (unless where it does not make sense due to the 
data, which should be mentioned).
  * When 'Personal information' is mentioned, this means:
* First name, last name, display / preferred name, username, student ID. 
* Preferred name is ticked per default but can be unticked and other fields 
selected instead.
  * Each column (but personal information and email) receives help text icon.
  * Each column is sortable (unless where it does not make sense due to the 
data, which should be mentioned).

  Report-specific
  -

  **Pie chart graph on overview report page**

  * Based on tabular data (see below)
  * Snapshot of the status yesterday
  * All portfolios, no matter whether regular or pro-rated because it’s the 
relationship that we are focusing on here.
  * Display includes the number of reviewers and the percentage to the overall 
number of reviewers who had been allocated portfolios.
  * On 'Overview' report be able to select the template(s) that shall be 
displayed and make that a sticky selection. Display only the sticky filter but 
you change the selection on the tabular report.**

  **Columns for tabular report**

  * Week, i.e. Monday through Sunday of the previous week, represented by 'w.c. 
Monday date' (w.c. = 'week commencing') as we have in another report
  * A column for each of the following total number of portfolios (no matter 
whether regular or pro-rated) per reviewer as on Sunday at 23:59: 1, 2, 3, 4, 
5, 6, 7, 8, 9, 10 or more
  * Regular date selector with start date of a month ago.
  * On configuration screen multi-select filter for which portfolios to display 
(if site is selected, all institution and site templates are mentioned, but if 
institution is selected, only institution templates are listed; no other 
templates can be selected). This needs to be a sticky selector that only needs 
to be set once and doesn't change until it is changed again.
  * Fix for date in the CSV download (check that is was merged in already)

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1922692/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1922694] A patch has been submitted for review

2021-05-02 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/11744

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1922694

Title:
  Report: Portfolios with reviewer

Status in Mahara:
  Fix Released

Bug description:
  My story
  ==

  As an institution admin I want to see quickly how many portfolio
  authors (don't) have a reviewer on a weekly basis so that I can report
  over these numbers, track the development, and intervene if necessary.

  
  How
  ==

  General information for the report
  --

  * Normal reporting capabilities are retained, e.g. that when a person is 
selected, reports are only shown for them where applicable reports are 
available, select data range, configuration selected on the configuration 
screen, columns are sortable (unless where it does not make sense due to the 
data, which should be mentioned).
  * When 'Personal information' is mentioned, this means:
* First name, last name, display / preferred name, username, student ID. 
* Preferred name is ticked per default but can be unticked and other fields 
selected instead.
  * Each column (but personal information and email) receives help text icon.
  * Each column is sortable (unless where it does not make sense due to the 
data, which should be mentioned).

  
  Report-specific
  -

  This report is for the number of portfolio authors with and without
  the role of 'Reviewer' set for a portfolio that they copied / that was
  copied from a template.

  Weekly snapshot report created each Monday at 1:30 (TBD) for the
  previous week.

  * Pie chart
  * Line graph
  * Tabular report

  **Pie chart (snapshot overview)**

  * Displays number of portfolio authors with and without current reviewer as 
at Sunday at 23:59 for the previous week
  * Display includes the number of portfolio authors and the percentage
  * In configuration be able to select which templates (via multi-select) shall 
be displayed and make that a sticky selection.

  **Line graph snapshot (report over time)**

  * Display number of portfolio authors with a current reviewer as at Sunday at 
23:59 for the previous week. Variations that happen during the week are ignored.
  * Data points are on a monthly basis and can be clicked to see the results 
(both number and percentage). Variations during the week do not matter.
  * Same template(s) selected as for pie chart graph

  **Tabular report columns**

  * Week, i.e. Monday through Sunday of the previous week, represented by 'w.c. 
Monday date' (w.c. = 'week commencing') as we have in another report
* Number of portfolio authors that have a current reviewer on Sunday at 
23:59
* Number of portfolio authors that don't have a current reviewer on Sunday 
at 23:59
  * Regular date selector.
  * On configuration screen filter for which portfolios to display via a 
multi-selector that is sticky.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1922694/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1922695] A patch has been submitted for review

2021-05-02 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/11744

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1922695

Title:
  Remove the institution membership joining notification when account is
  created by the system

Status in Mahara:
  Fix Released
Status in Mahara 20.10 series:
  Fix Committed
Status in Mahara 21.04 series:
  Fix Released

Bug description:
  When an account is created via web services or other automated
  processes, do not send a notification about the person having been
  added to an institution. This can be very confusing when they may not
  yet know that they are getting an account.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1922695/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1922705] A patch has been submitted for review

2021-05-02 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/11744

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1922705

Title:
  Show alert when closing block via 'Close' icon

Status in Mahara:
  Fix Released

Bug description:
  'My story
  ==

  As a portfolio author I want to click the 'X' on a block configuration
  block and be warned about losing changes if I don't save so that I
  don't close the modal accidentally and lose all my text.

  How
  ==

  Code that would check if there are unsaved changes before the 'Close'
  icon is clicked on a block configuration screen. This does not
  influence the 'Cancel' link at the bottom of the modal.

  The text that should come up when clicking the 'X' and having unsaved
  changes: Any unsaved changes will be lost.

  With buttons 'Confirm' and 'Back'.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1922705/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1922834] A patch has been submitted for review

2021-05-02 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/11744

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1922834

Title:
  Show student ID as part of the display name function

Status in Mahara:
  Fix Released

Bug description:
  Adjust the display name function to be more flexible.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1922834/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1922702] A patch has been submitted for review

2021-05-02 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/11744

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1922702

Title:
  'Quick edit' doesn't show TinyMCE

Status in Mahara:
  Fix Released

Bug description:
  When you have a page and put a text block on it, the 'Quick edit'
  option doesn't display TinyMCE. Tested in Chrome and Firefox.

  To replicate:

  1. Set up a regular portfolio page on the site or institution level.
  1. Put a text block onto the page.
  1. Go into 'Display' mode.
  1. Click the 'Details' mode icon (magnifying glass with +).

  Result:
  * Expected: The 'Block' field shows TinyMCE.
  * Actual: It's a plain text field.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1922702/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1922706] A patch has been submitted for review

2021-05-02 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/11744

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1922706

Title:
  Password reset link broken

Status in Mahara:
  Fix Released

Bug description:
  A password reset cannot be performed properly under certain
  circumstances.

  Test instructions to follow. This may also need to be backported.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1922706/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1922835] A patch has been submitted for review

2021-05-02 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/11744

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1922835

Title:
  Create portfolio creation queue for institution templates

Status in Mahara:
  Fix Released

Bug description:
  My story
  ==

  As an institution admin I want to automatically copy portfolios into
  new accounts in a more efficient way, especially when lots of
  portfolios are created at once so that there is not too big a load on
  the server and the site can continued to be used without problems.

  * Create a queue for copying portfolios into newly created accounts: Instead 
of immediately copying the portfolio template for new accounts, put it into a 
queue as often lots of accounts are added, e.g. via web services, CSV file, 
etc. so that Mahara doesn't crash. Even if only one account is created and a 
copy needed, still use the queue for that to keep the number of rules low and 
thus not add additional break points.
  * The cron runs every minute

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1922835/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1922836] A patch has been submitted for review

2021-05-02 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/11744

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1922836

Title:
  Make display of the name more flexible on a page

Status in Mahara:
  Fix Released

Bug description:
  Allow for additional information to be displayed as part of the name
  line on a portfolio page. There is no configuration setting for this
  at this stage, but can be done hard-coded.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1922836/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1922838] A patch has been submitted for review

2021-05-02 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/11744

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1922838

Title:
  Not returned to correct URL when deleting pages within institution
  collection

Status in Mahara:
  Fix Released

Bug description:
  When you delete the last page from an institution collection, you are
  not returned to the institution's 'Pages and collections' page but a
  URL that doesn't exist.

  Please also check if it needs to be backported.

  
  This is a follow-on from bug #1915352

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1922838/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1922837] A patch has been submitted for review

2021-05-02 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/11744

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1922837

Title:
  Create templates more efficiently on the institution and site level

Status in Mahara:
  Fix Released

Bug description:
  My story
  ==

  As an institution admin I want to create a new template more
  efficiently that can be copied into new accounts.

  How
  ==

  Changes are made to the collection 'Edit' screen for *institution and site 
portfolios only* (we already have an advanced sharing option of 'Copy to new 
members' that is only available on these two levels and thus might be used to 
tap into):
  * Add a switch 'Template' to the collection 'Add' screen. This is needed 
because it can't be guaranteed that the template is only created to be an 
auto-copied one.
* If the switch on the collection is set to 'Yes' and the screen is saved, 
grey out all 'Template' switches on pages that are included in the collection 
or will be added in the future (and display 'Yes' in the greyed out state) so 
that it can inherit the settings. *Side note*: When a page is removed from the 
collection, it stays a template, but it's not auto-copied because the 
auto-copying functionality sits on the collection side of things.
* If the switch on the collection is set to 'Yes' and the screen is saved, 
automatically turn 'Prevent removing of blocks' on because the placeholder 
blocks signal to pharmacists what the recertification requirements are and they 
should not be removed. However, it is still possible to reset this for 
individual pages by the admin or later pharmacists and thus doesn't become a 
locked template setting like the instructions, i.e. this switch is not greyed 
out.
* If the 'Template' switch is set to 'No' on the collection again, upon 
saving, the individual 'Template' switches on the pages can be set separately 
(typical behaviour in Mahara for hierarchies). There is not going to be a 
change to the 'Prevent removing of blocks' switches.
* If the 'Template' switch on the collection is set back to 'Yes', all 
'Template' switches on the pages are greyed out again (see above) and the 
'Prevent removing of blocks' switch is set to 'Yes' but not greyed out.
  * Add a switch for 'Current auto-copied template'. 
* When ticked and the collection is saved, i.e. click the 'Next: Add pages' 
button, the previously auto-copied template in the institution has its status 
reset to 'No'. The switch can be put back to 'No' if no institution portfolio 
should be auto-copied so that there are no auto-copied templates in an 
institution or on the site level.
* Since this is a destructive option, have modal that tells of the 
consequences, e.g. the only active template, name of the old template that is 
set to be inactive, auto-copying, old template gets sharing permissions dropped.
* When the switch is flipped back to 'No', also bring up a modal that tells 
of the consequences, i.e. no template will be copied automatically.
  * Sharing when 'Current auto-copied template' is set to 'Yes':
* Automatically share the portfolio with the institution, make it copyable, 
and use it as portfolio that is copied automatically into new accounts 
henceforth.
* Automatically remove the sharing permissions for the old portfolio that 
is not considered institution template any more.

  When this portfolio template is copied, keep the collection title and prefix 
it with the display name. That way, the name is seen more easily than in the 
secondary information. Yes, it doubles up, but keeps it clear.
* The name prefix is to be done only on portfolios marked as 'Template'. 
The portfolio authors can still change the collection title to something else 
once it's in their account.
* Only prefix the collection title, not a every page. Page titles stay as 
they are.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1922837/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1922841] A patch has been submitted for review

2021-05-02 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/11744

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1922841

Title:
  Can't copy personal locked portfolio

Status in Mahara:
  Fix Released

Bug description:
  To replicate:

  1. Set up auto-copy collection with a primary statement that locks the 
portfolio (new functionality for 21.04 of collection template and auto-copy).
  2. Create a new account.
  3. Run the cron so that the portfolio is copied.
  4. Log in as portfolio owner and share the portfolio with a verifier.
  5. Log in as verifier and tick the statement.
  6. Log back in as portfolio owner.
  7. Copy the collection / copy a page within the collection.

  Result:

  Expected: The copying works.
  Actual: Error message:

  [WAR] 0a (lib/view.php:432) View::create_from_template: Attempting to create 
a View from another View that is not marked as a template
  Call stack (most recent first):

  View::create_from_template() at 
/home/kristina/code/mahara/htdocs/lib/collection.php:436
  Collection::create_from_template() at 
/home/kristina/code/mahara/htdocs/lib/view.php:7775
  copyview() at /home/kristina/code/mahara/htdocs/view/copy.php:34

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1922841/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1922840] A patch has been submitted for review

2021-05-02 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/11744

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1922840

Title:
  Find student ID and lowercase search for names in Elasticsearch

Status in Mahara:
  Fix Released

Bug description:
  Elasticsearch was prevented from indexing the student ID and also
  couldn't find certain results when they were all lowercase

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1922840/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1922844] A patch has been submitted for review

2021-05-02 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/11744

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1922844

Title:
  Fix button drop-down toggles

Status in Mahara:
  Fix Released

Bug description:
  Fix button drop-down toggles

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1922844/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1923531] A patch has been submitted for review

2021-05-02 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/11744

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1923531

Title:
  Make password instructions more explicit

Status in Mahara:
  Fix Released

Bug description:
  Change password-creation instructions so that they explicitly mention
  the characters a portfolio owner can include, e.g. "... upper-case
  [A-Z], ... lower-case [a-z], ... numerals [0-9] and symbols [!, @, #,
  $, %, &, (, ), ?]."

  This is to make the process of creating a password easier for the
  portfolio owner.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1923531/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1923676] A patch has been submitted for review

2021-05-02 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/11744

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1923676

Title:
  Group administrator be allowed to see group submission archive for
  their group

Status in Mahara:
  Fix Released

Bug description:
  Currently only the site admins can see the submission archive list
  (via the Admin -> Groups section)

  It would be good for a group admin to be able to see the archive info
  for their particular group

  To do:
  Add a submissions group tab for group admins so they can get a page within 
their group listing the archived submissions

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1923676/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1924941] A patch has been submitted for review

2021-05-02 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/11744

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1924941

Title:
  Test Client for LTI webservice not showing required fields

Status in Mahara:
  Fix Committed

Bug description:
  Nor is it showing the descriptions under the fields

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1924941/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1924949] A patch has been submitted for review

2021-05-02 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/11744

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1924949

Title:
  Error when adding an image block to a site page

Status in Mahara:
  Fix Released

Bug description:
  When you create a site page and add an image block, the warning below
  appears when you navigate away from the page.

  Robert says:

  "Why does htdocs/lib/form/elements/filebrowser.php expect there to be
  tabs made and then ignores this for site pages?"

  ---
  if (!empty($element['tabs'])) {
  $tabdata = pieform_element_filebrowser_configure_tabs($element, $prefix);
   ...
  ---

  Then

  ---
  if ($viewowner['type'] == 'institution' && $viewowner['id'] == 'mahara') {
  // No filebrowser tabs for site views
  return null;
  }
  ---

  "I believe the problem relates to those two bits of code".

  How to replicate:

  1. Create a site page
  2. Add the 'Image' block, upload an image, and save the block configuration.
  3. Go to the 'Edit access' page (for example).

  Expected result: The page loads correctly.
  Actual result: The error message below.



  [WAR] 6d (lib/form/elements/filebrowser.php:49) Trying to access array offset 
on value of type null
  Call stack (most recent first):

  log_message("Trying to access array offset on value of type nul...", 8, 
true, true, "/home/kristina/code/mahara/htdocs/lib/form/element...", 49) at 
/home/kristina/code/mahara/htdocs/lib/errors.php:515
  error(8, "Trying to access array offset on value of type nul...", 
"/home/kristina/code/mahara/htdocs/lib/form/element...", 49, array(size 11)) at 
/home/kristina/code/mahara/htdocs/lib/form/elements/filebrowser.php:49
  pieform_element_filebrowser(object(Pieform), array(size 17)) at 
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:1605
  Pieform->build_element_html(array(size 17)) at 
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:760
  Pieform->build() at 
/home/kristina/code/mahara/htdocs/blocktype/lib.php:1656
  BlockInstance->build_configure_form(true) at 
/home/kristina/code/mahara/htdocs/blocktype/lib.php:1232
  BlockInstance->render_editing(true, true) at 
/home/kristina/code/mahara/htdocs/lib/view.php:2553
  View->changeblockinstance(array(size 5)) at 
/home/kristina/code/mahara/htdocs/lib/view.php:1930
  View->process_changes() at 
/home/kristina/code/mahara/htdocs/view/blocks.json.php:30

  [WAR] 4e (lib/form/elements/filebrowser.php:49) Trying to access array offset 
on value of type null
  Call stack (most recent first):

  log_message("Trying to access array offset on value of type nul...", 8, 
true, true, "/home/kristina/code/mahara/htdocs/lib/form/element...", 49) at 
/home/kristina/code/mahara/htdocs/lib/errors.php:515
  error(8, "Trying to access array offset on value of type nul...", 
"/home/kristina/code/mahara/htdocs/lib/form/element...", 49, array(size 11)) at 
/home/kristina/code/mahara/htdocs/lib/form/elements/filebrowser.php:49
  pieform_element_filebrowser(object(Pieform), array(size 17)) at 
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:1605
  Pieform->build_element_html(array(size 17)) at 
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:760
  Pieform->build() at 
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:1045
  Pieform->json_reply(0array(size 8), null) at 
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:1012
  Pieform->reply(0array(size 7)) at 
/home/kristina/code/mahara/htdocs/blocktype/lib.php:1187
  BlockInstance->instance_config_store(object(Pieform), array(size 5)) at 
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:572
  Pieform->__construct(array(size 15)) at 
/home/kristina/code/mahara/htdocs/lib/mahara.php:5497
  pieform_instance(array(size 15)) at 
/home/kristina/code/mahara/htdocs/blocktype/lib.php:1649
  BlockInstance->build_configure_form() at 
/home/kristina/code/mahara/htdocs/view/blocks.php:72

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1924949/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1924942] A patch has been submitted for review

2021-05-02 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/11744

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1924942

Title:
  Create user webservice description for username parameter is incorrect

Status in Mahara:
  Fix Released

Bug description:
  It says:

  "Between 3 and 30 characters long. Letters, numbers and most standard
  symbols are allowed"

  But we can have usernames longer than 30 characters

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1924942/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1926243] A patch has been submitted for review

2021-05-02 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/11744

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1926243

Title:
  General language string review for Mahara 21.04

Status in Mahara:
  Fix Released
Status in Mahara 21.04 series:
  Fix Released

Bug description:
  Review strings that haven't already been updated during the code
  review process

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1926243/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1926115] A patch has been submitted for review

2021-05-02 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/11744

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1926115

Title:
  Webservices check that service exists when using test client

Status in Mahara:
  Fix Released

Bug description:
  When using the test client we need to make sure that there are
  services active and set to use the authentication type. As normally no
  service is set to use the 'User' auth type by default when site is
  installed.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1926115/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1926245] A patch has been submitted for review

2021-05-02 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/11744

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1926245

Title:
  Verifier summary: tabular mode check typo

Status in Mahara:
  Fix Released

Bug description:
  if in tabular mode we can sort a column to update the table otherwise
  reload the page

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1926245/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1926365] A patch has been submitted for review

2021-05-02 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/11744

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1926365

Title:
  Unable to drag/drop a block on empty page

Status in Mahara:
  Fix Released

Bug description:
  The drop-able area is too small to drop a block onto

  This only happens if there are no block already on the page

  You can still add a block by click / add form

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1926365/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1926382] A patch has been submitted for review

2021-05-02 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/11744

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1926382

Title:
  Portfolio locking - replace duplicate code with lock_collection

Status in Mahara:
  Fix Released

Bug description:
  Replace duplicate code

   // Lock the collection
  if ($view->get_collection()) {
  $collectionid = $view->get_collection()->get('id');
  execute_sql("UPDATE {collection} SET lock = 1 WHERE id = ?", 
array($collectionid));
  }

  
  with the new function in lib/collection.php

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1926382/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1926381] A patch has been submitted for review

2021-05-02 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/11744

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1926381

Title:
  Small Mahara 21.04 styling fixes

Status in Mahara:
  Fix Released
Status in Mahara 21.04 series:
  Fix Released

Bug description:
  The colour contrast in the help icon in the side block 'Friend
  control' accessible via /user/index.php is insufficient in the Modern
  theme (see screenshot). Can you please check the other built-in themes
  as well?

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1926381/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1926380] A patch has been submitted for review

2021-05-02 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/11744

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1926380

Title:
  Device detection error

Status in Mahara:
  Fix Released

Bug description:
  There is an error with the device detection that we removed for 21.04.

  Error message:

  [WAR] cb (admin/site/options.php:990) Undefined index: 
userscandisabledevicedetection
  Call stack (most recent first):

  log_message("Undefined index: userscandisabledevicedetection", 8, true, 
true, "/home/kristina/code/mahara/htdocs/admin/site/optio...", 990) at 
/home/kristina/code/mahara/htdocs/lib/errors.php:515
  error(8, "Undefined index: userscandisabledevicedetection", 
"/home/kristina/code/mahara/htdocs/admin/site/optio...", 990, array(size 7)) at 
/home/kristina/code/mahara/htdocs/admin/site/options.php:990
  siteoptions_submit(object(Pieform), array(size 101)) at 
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:572
  Pieform->__construct(array(size 9)) at 
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:168
  Pieform::process(array(size 9)) at 
/home/kristina/code/mahara/htdocs/lib/mahara.php:5589
  pieform(array(size 9)) at 
/home/kristina/code/mahara/htdocs/admin/site/options.php:854


  

  How to replicate:

  1. Fresh database.
  2. Log in as site admin.
  3. Go to Admin menu -> Configure site -> Site options.
  4. Change the theme to any of the available ones.
  5. Save.

  Results:
  - Expected: The page saves without issues.
  - Actual: Above error message

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1926380/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1926519] A patch has been submitted for review

2021-05-02 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/11744

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1926519

Title:
  Restrict which blocks can be put onto the portfolio completion page

Status in Mahara:
  Fix Released

Bug description:
  Only a few block types should be allowed on the portfolio completion
  page. That requires that all blocks that should not be displayed need
  to have the block type restriction added.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1926519/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1926384] A patch has been submitted for review

2021-05-02 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/11744

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1926384

Title:
  Copy institution portfolio (queue not reducing)

Status in Mahara:
  Fix Released

Bug description:
  Return copy status upon completion

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1926384/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1926407] A patch has been submitted for review

2021-05-02 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/11744

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1926407

Title:
  Allow older skins not to break when they are applied to a page

Status in Mahara:
  Fix Released

Bug description:
  Normally we can just re-save the skin to fix them but if they are a
  favourite then we don't have permissions to re-save them.

  So it would be better to avoid the breakage

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1926407/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1926530] A patch has been submitted for review

2021-05-02 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/11744

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1926530

Title:
  Elasticsearch producing warning: Undefined property: stdClass::$icon

Status in Mahara:
  Fix Released

Bug description:
  It is possible to produce a warning via an Elasticsearch call if the
  results produce a broken icon link.

  The warning is as follows:
  [WAR] 85 (search/elasticsearch/type/ElasticsearchType_artefact.php:332) 
Undefined property: stdClass::$icon
  Call stack (most recent first):
  log_message("Undefined property: stdClass::$icon", 8, true, true, 
"/var/www/master-dev-prod-mahara/releases/202104280...", 332) at 
/var/www/master-dev-prod-mahara/releases/20210428075700/lib/errors.php:515
  error(8, "Undefined property: stdClass::$icon", 
"/var/www/master-dev-prod-mahara/releases/202104280...", 332, array(size 7)) at 
/var/www/master-dev-prod-mahara/releases/20210428075700/search/elasticsearch/type/ElasticsearchType_artefact.php:332
  ElasticsearchType_artefact::getRecordDataById("artefact", "3560") at 
/var/www/master-dev-prod-mahara/releases/20210428075700/search/elasticsearch/lib.php:1926
  ElasticsearchPseudotype_all::search("TEST", 10, 0, array(size 4), null, 
object(LiveUser)) at 
/var/www/master-dev-prod-mahara/releases/20210428075700/search/elasticsearch/lib.php:1073
  PluginSearchElasticsearch::search_all("TEST", 10, 0, array(size 4), null) at 
/var/www/master-dev-prod-mahara/releases/20210428075700/search/elasticsearch/json/elasticsearch.php:53

  This was first produced on dev.mahara.org on 21.04.dev code, while
  searching for the term, "test".

  
  --

  ## Testing on dev.mahara.org

  - $icon is an undefined property
  - function causing this error: getRecordDataById("artefact", "3560")

  Looking at the artefact table ...
  -[ RECORD 1 ]---+
  id  | 3560
  artefacttype| socialprofile
  container   | 0
  parent  |
  owner   | 1
  institution |
  group   |
  ctime   | 2020-10-08 13:50:27
  mtime   | 2020-10-08 13:50:27
  atime   | 2020-10-08 13:50:27
  locked  | 0
  title   | test tumblr
  description | Tumblr
  note| tumblr
  author  | 1
  authorname  |
  allowcomments   | 0
  approvecomments | 0
  license |
  licensor|
  licensorurl |
  path| /3560

  
  - a socialprofile artefact caused this, owned by user=1 that is catadmin
  - try adding another tumblr with username=meow
  - re-index elasticsearch
  - search for meow gives the same error

  ```bash
  [WAR] ca (search/elasticsearch/type/ElasticsearchType_artefact.php:332) 
Undefined property: stdClass::$icon
  Call stack (most recent first):

  log_message("Undefined property: stdClass::$icon", 8, true, true, 
"/var/www/master-dev-prod-mahara/releases/202104280...", 332) at 
/var/www/master-dev-prod-mahara/releases/20210428075700/lib/errors.php:515
  error(8, "Undefined property: stdClass::$icon", 
"/var/www/master-dev-prod-mahara/releases/202104280...", 332, array(size 7)) at 
/var/www/master-dev-prod-mahara/releases/20210428075700/search/elasticsearch/type/ElasticsearchType_artefact.php:332
  ElasticsearchType_artefact::getRecordDataById("artefact", "3915") at 
/var/www/master-dev-prod-mahara/releases/20210428075700/search/elasticsearch/lib.php:1926
  ElasticsearchPseudotype_all::search("meow", 10, 0, array(size 5), null, 
object(LiveUser)) at 
/var/www/master-dev-prod-mahara/releases/20210428075700/search/elasticsearch/lib.php:1073
  PluginSearchElasticsearch::search_all("meow", 10, 0, array(size 5), null, 
object(LiveUser)) at 
/var/www/master-dev-prod-mahara/releases/20210428075700/search/elasticsearch/index.php:55

  ```

  log_message("Undefined property: stdClass::$icon", 8, true, true, 
"/var/www/master-dev-prod-mahara/releases/202104280...", 332) at 
/var/www/master-dev-prod-mahara/releases/20210428075700/lib/errors.php:515
  error(8, "Undefined property: stdClass::$icon", 
"/var/www/master-dev-prod-mahara/releases/202104280...", 332, array(size 7)) at 
/var/www/master-dev-prod-mahara/releases/20210428075700/search/elasticsearch/type/ElasticsearchType_artefact.php:332
  ElasticsearchType_artefact::getRecordDataById("artefact", "3560") at 
/var/www/master-dev-prod-mahara/releases/20210428075700/search/elasticsearch/lib.php:1926
  ElasticsearchPseudotype_all::search("test", 10, 0, array(size 5), null, 
object(LiveUser)) at 
/var/www/master-dev-prod-mahara/releases/20210428075700/search/elasticsearch/lib.php:1073
  PluginSearchElasticsearch::search_all("test", 10, 0, array(size 5), null, 
object(LiveUser)) at 
/var/www/master-dev-prod-mahara/releases/20210428075700/search/elasticsearch/ind

[Mahara-contributors] [Bug 1926529] A patch has been submitted for review

2021-05-02 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/11744

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1926529

Title:
  Profile icon has a rectangular border around square icons

Status in Mahara:
  Fix Released

Bug description:
  The profile icon displayed on comments has a grey border that isn't
  correctly displaying

  Re-create the bug

  1. Create  a page
  2. Go to the bottom of the page to see the comments are
  3. Look at the profile icon displayed beside the comments 

  Expected: the profile icon is square and so is its border
  Currently: the profile icon is square but the border is twice the length of 
it verically

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1926529/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1926540] A patch has been submitted for review

2021-05-02 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/11744

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1926540

Title:
  Creating a progress collection then adding a page causes two
  collections to show on index page

Status in Mahara:
  Fix Released

Bug description:
  This happens when dragging / dropping page into collection

  The collections are the same one but there is a problem with the
  display order having both the progress  page and new page being order
  = 0

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1926540/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1926549] A patch has been submitted for review

2021-05-02 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/11744

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1926549

Title:
  Portfolio with portfolio completion page can't be viewed when
  submitted to a group

Status in Mahara:
  Fix Released

Bug description:
  When you submitted a collection with portfolio completion, then the
  group admin cannot view the collection because they don't have access
  to the portfoliocompletion.php page.

  To replicate:

  1. As a site admin, set up a controlled group and allow submissions.
  2. Upload accounts to the site via a CSV file.
  3. Add people into the group.
  4. Enable 'Portfolio completion' for the institution where the people are in 
('No institution' is fine).
  4. Log in as one of those people.
  5. Create a couple of pages.
  6. Set up a collection with portfolio completion enabled.
  7. Add your pages.
  8. Submit the collection to the group.
  9. Log in as site admin again, go to the group homepage, and click on the 
link to the collection.

  Results:
  - Expected: You are taken to the portfolio completion page.
  - Actual: 'Access denied' message

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1926549/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1926550] A patch has been submitted for review

2021-05-02 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/11744

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1926550

Title:
  Warning "Undefined variable stdClass::$count" on statistics.php for
  completion and review report

Status in Mahara:
  Fix Released

Bug description:
  Branch: Master
  DB: Mysql 8
  Browser: Firefox

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1926550/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1926930] [NEW] Locally overwrite Behat tests

2021-05-02 Thread Kristina Hoeppner
Public bug reported:

When a site has customisations that affect the behaviour of a Mahara
site, the Behat tests need to be adjusted. However, currently, there is
no way of doing that outside of the normal Behat directory and the core
tests would need to be updated. That can easily lead to merge conflicts
that need to be resolved.

It would be better if local Behat tests could be kept in a separate
directory and overwrite the core Behat tests, similarly to what we do
with the local language and theme changes etc. in the /local directory.

** Affects: mahara
 Importance: Wishlist
 Status: Confirmed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1926930

Title:
  Locally overwrite Behat tests

Status in Mahara:
  Confirmed

Bug description:
  When a site has customisations that affect the behaviour of a Mahara
  site, the Behat tests need to be adjusted. However, currently, there
  is no way of doing that outside of the normal Behat directory and the
  core tests would need to be updated. That can easily lead to merge
  conflicts that need to be resolved.

  It would be better if local Behat tests could be kept in a separate
  directory and overwrite the core Behat tests, similarly to what we do
  with the local language and theme changes etc. in the /local
  directory.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1926930/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1901256] Re: Can't set plan task completion date to today's date

2021-05-02 Thread Robert Lyon
** Also affects: mahara/21.10
   Importance: Undecided
   Status: New

** Changed in: mahara/21.10
   Status: New => In Progress

** Changed in: mahara
   Status: In Progress => Confirmed

** Changed in: mahara/21.10
Milestone: None => 21.10.0

** Changed in: mahara/21.10
   Importance: Undecided => High

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1901256

Title:
  Can't set plan task completion date to today's date

Status in Mahara:
  Confirmed
Status in Mahara 21.10 series:
  In Progress

Bug description:
  It is not possible to create a plan task with today's date as
  completion date because (I think) it uses midnight as time and that
  will have already passed.

  This may need to be a general fix, i.e. when we use the date picker
  and there is no time displayed, we always assume it is the end of the
  day, e.g. date at 23:59 instead of date at 00:00.

  To replicate:

  1. Create a plan and a task.
  2. In the date picker for 'Completion date' select today's date.
  3. Save.
  Expected result: The form is saved correctly.
  Actual result: Error message "The completion date must be in the future." is 
displayed.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1901256/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1911824] Re: When you copy a collection with SmartEvidence, all annotations come along as well

2021-05-02 Thread Robert Lyon
** Also affects: mahara/21.10
   Importance: Undecided
   Status: New

** Changed in: mahara/21.10
   Status: New => In Progress

** Changed in: mahara/21.10
   Importance: Undecided => High

** Changed in: mahara/21.10
Milestone: None => 21.10.0

** Changed in: mahara
   Status: In Progress => Confirmed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1911824

Title:
  When you copy a collection with SmartEvidence, all annotations come
  along as well

Status in Mahara:
  Confirmed
Status in Mahara 21.10 series:
  In Progress

Bug description:
  When your collection contains SmartEvidence, the annotation content
  (but not the feedback) and the annotation is set back to 'Ready for
  assessment'.

  So as not to copy somebody else's reflections, it would be better to
  not copy annotations along at all.

  When an account holder copies a collection that isn't owned by them
  containing SmartEvidence, the collection copy should not have any
  annotation blocks copied over.

  However, when the author of a collection containing SmartEvidence
  duplicates the collection, the copy shall have the annotation copied
  over from the original collection as the content inside annotation
  blocks reflect their own work.

  To replicate:

  1. Create a collection with at least one page and SmartEvidence activated.
  2. Add an annotation to one standard.
  3. Make the collection available and allow copying.
  4. Log in as somebody else and view the collection.
  5. Copy the entire collection.
  6. Go to the SmartEvidence page.
  Expected result: The SmartEvidence map is empty and there are no annotation 
blocks on pages.
  Actual result: The annotation blocks are still there and the status on the 
SmartEvidence page for them is 'Ready for assessment', i.e. the blue circle.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1911824/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1906558] Re: Mahara docker for Behat requires css and initcomposer make targets to run

2021-05-02 Thread Robert Lyon
** Also affects: mahara/21.10
   Importance: Undecided
   Status: New

** Changed in: mahara/21.10
   Status: New => In Progress

** Changed in: mahara
   Status: In Progress => Confirmed

** Changed in: mahara/21.10
   Importance: Undecided => Medium

** Changed in: mahara/21.10
Milestone: None => 21.10.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1906558

Title:
  Mahara docker for Behat requires css and initcomposer make targets to
  run

Status in Mahara:
  Confirmed
Status in Mahara 21.10 series:
  In Progress

Bug description:
  Running the Behat tests in docker fails if the ccs and initcomposer
  make targets are not made first.

  This needs to be added to the docker/README. Also these targets should
  be added as make dependencies.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1906558/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1904636] Re: Only check pre-login hook if the auth method is active

2021-05-02 Thread Robert Lyon
** Also affects: mahara/21.10
   Importance: Undecided
   Status: New

** Also affects: mahara/21.04
   Importance: Medium
   Status: In Progress

** Changed in: mahara/21.10
   Status: New => In Progress

** Changed in: mahara/21.04
   Status: In Progress => Confirmed

** Changed in: mahara/21.10
   Importance: Undecided => Medium

** Changed in: mahara/21.10
Milestone: None => 21.10.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1904636

Title:
  Only check pre-login hook if the auth method is active

Status in Mahara:
  Confirmed
Status in Mahara 21.04 series:
  Confirmed
Status in Mahara 21.10 series:
  In Progress

Bug description:
  Noticed this problem when dealing with a db that had an old auth type
  in it that didn't exist on local codebase.

  When an auth method is inactive we shouldn't need to check it's
  prelogin hook

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1904636/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1913490] Re: Not providing an export-relative link for artefact

2021-05-02 Thread Robert Lyon
** Also affects: mahara/21.10
   Importance: Undecided
   Status: New

** Changed in: mahara/21.10
   Status: New => In Progress

** Changed in: mahara
   Status: In Progress => Confirmed

** Changed in: mahara/21.10
   Importance: Undecided => Medium

** Changed in: mahara/21.10
Milestone: None => 21.10.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1913490

Title:
  Not providing an export-relative link for artefact

Status in Mahara:
  Confirmed
Status in Mahara 21.10 series:
  In Progress

Bug description:
  When exporting a portfolio page where a comment is made with an image
  attachment. (could also apply to other filetypes)

  Steps to reproduce:
  1. Create a portfolio page
  2. Add an image block
  3. Add a comment to the image block with an image attachment
  4. Go to Manage->Export
  5. Check that the comments setting is switched on
  6. Export page

  Expect: The success message for exporting the portfolio is successful!
  Actual: The info message displayed says 'Export generated with some errors'

  One way to reproduce the more helpful [DBG] message, is to exporting twice.
  1. On the first time, click continue without allowing the export to finish
  2. In the second time we press 'Generate export', we'll see the DBG message 

  Seems to be the source of #1850737

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1913490/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1916648] Re: blocktype/externalfeed/lib.php:84 count(): Parameter must be an array or an object that implements Countable

2021-05-02 Thread Robert Lyon
** Also affects: mahara/21.10
   Importance: Undecided
   Status: New

** Changed in: mahara/21.10
   Status: New => In Progress

** Changed in: mahara/21.04
   Status: In Progress => Confirmed

** Changed in: mahara/21.10
   Importance: Undecided => Medium

** Changed in: mahara/21.10
Milestone: None => 21.10.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1916648

Title:
  blocktype/externalfeed/lib.php:84  count(): Parameter must be an array
  or an object that implements Countable

Status in Mahara:
  Confirmed
Status in Mahara 21.04 series:
  Confirmed
Status in Mahara 21.10 series:
  In Progress

Bug description:
  We need to check that the variable is not empty and is an array before
  we can do the counting

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1916648/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1819379] Re: update chromedriver for behat

2021-05-02 Thread Robert Lyon
As we will want to keep all current version branches on the same
chromedriver version I've target which branches in this bug report

** Also affects: mahara/21.10
   Importance: Undecided
   Status: New

** Changed in: mahara/21.10
   Status: New => In Progress

** Changed in: mahara/21.10
   Importance: Undecided => High

** Also affects: mahara/20.10
   Importance: Undecided
   Status: New

** Also affects: mahara/20.04
   Importance: Undecided
   Status: New

** Also affects: mahara/21.04
   Importance: High
   Status: In Progress

** Changed in: mahara/21.10
Milestone: None => 21.10.0

** Changed in: mahara/20.10
Milestone: None => 20.10.2

** Changed in: mahara/20.04
Milestone: None => 20.04.4

** Changed in: mahara/20.10
   Importance: Undecided => High

** Changed in: mahara/20.04
   Importance: Undecided => High

** Changed in: mahara/20.10
   Status: New => Confirmed

** Changed in: mahara/20.04
   Status: New => Confirmed

** Changed in: mahara/21.04
   Status: In Progress => Confirmed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1819379

Title:
  update chromedriver for behat

Status in Mahara:
  Confirmed
Status in Mahara 20.04 series:
  Confirmed
Status in Mahara 20.10 series:
  Confirmed
Status in Mahara 21.04 series:
  Confirmed
Status in Mahara 21.10 series:
  In Progress

Bug description:
  Given that there is an exploit for chrome versions below
  72.0.3626.121, we should update chromedriver to work with newer
  versions. (Our current version 2.38 is only compatible with chrome up
  to version 67). The chrome version on Jenkins will need to be updated
  to run with the new chromedriver.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1819379/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1912705] Re: Task "export_process_queue" fails on cron run

2021-05-02 Thread Robert Lyon
** Also affects: mahara/21.10
   Importance: Undecided
   Status: New

** Changed in: mahara/21.10
   Status: New => In Progress

** Changed in: mahara/21.04
   Status: In Progress => Confirmed

** Changed in: mahara/21.10
Milestone: None => 21.10.0

** Changed in: mahara/21.10
   Importance: Undecided => High

** Changed in: mahara/20.10
Milestone: 20.10.1 => 20.10.2

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1912705

Title:
  Task "export_process_queue" fails on cron run

Status in Mahara:
  Confirmed
Status in Mahara 20.10 series:
  Confirmed
Status in Mahara 21.04 series:
  Confirmed
Status in Mahara 21.10 series:
  In Progress

Bug description:
  When submissions are set to be archived before being released back to
  the submitter, they are queued for export and an archived version is
  created. This processed failed for us and we were given a hint in the
  cron logs/output that the error was thrown at
  `htdocs/artefact/comment/blocktype/comment/lib.php:111`.

  Adding a `debug_print_backtrace()` to the file reveals more in the cron 
output:
  ```
  [INF] 35 (lib/cron.php:190) Running core cron export_process_queue
  #0  PluginBlocktypeComment::render_instance_export(BlockInstance Object 
([BlockInstanceid] => 320133,[BlockInstanceblocktype] => 
comment,[BlockInst[truncated]
  , html) called at [/mahara/htdocs/lib/mahara.php:1818]
  #1  call_static_method(PluginBlocktypeComment, render_instance_export, 
BlockInstance Object ([BlockInstanceid] => 320133,[BlockInstanceblocktype] => 
comment,[BlockInst[truncated]
  , html) called at [/mahara/htdocs/blocktype/lib.php:1351]
  #2  BlockInstance->render_viewing(html, ) called at 
[/mahara/htdocs/lib/view.php:2290]
  #3  View->build_column(3, 1, , html, ) called at 
[/mahara/htdocs/lib/view.php:2241]
  #4  View->build_columns(3, , html, ) called at 
[/mahara/htdocs/lib/view.php:2182]
  #5  View->build_rows(, html) called at 
[/mahara/htdocs/export/html/lib.php:479]
  #6  PluginExportHtml->dump_view_export_data() called at 
[/mahara/htdocs/export/html/lib.php:242]
  #7  PluginExportHtml->export() called at 
[/mahara/htdocs/export/lib.php:1015]
  #8  PluginExportAll->export() called at 
[/mahara/htdocs/export/lib.php:704]
  #9  export_process_queue() called at 
[/mahara/htdocs/lib/cron.php:198]
  [WAR] 35 (lib/errors.php:536) [Error]: Call to a member function get() on 
null at /mahara/htdocs/artefact/comment/blocktype/comment/lib.php:112
  Call stack (most recent first):
    * exception(object(Error)) at Unknown:0
  A nonrecoverable error occurred. This probably means you have encountered a 
bug in the system
  ```

  We were able to fix it by explicitly declaring `global $exporter;` in
  `htdocs/export/lib.php:602` at the very start of the
  `export_process_queue` function - please refer to attached patch.

  It also affects portfolio exports when the "Export to queue" settings
  is enabled in Configure site > Site options > Account settings.

  
  --
  Application/System version(s):
  Mahara
  $config->version = 2020013013;
  $config->series = '20.04';
  $config->release = '20.04.2';

  OS
  Ubuntu 18.04.5 LTS

  DB
  MySQL 5.7
  --

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1912705/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1912685] Re: Upgrade SimpleSAMLphp to 1.19.0

2021-05-02 Thread Robert Lyon
** Changed in: mahara/20.10
   Status: Fix Committed => In Progress

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1912685

Title:
  Upgrade SimpleSAMLphp to 1.19.0

Status in Mahara:
  Fix Released
Status in Mahara 19.10 series:
  Fix Committed
Status in Mahara 20.04 series:
  Fix Committed
Status in Mahara 20.10 series:
  In Progress
Status in Mahara 21.04 series:
  Fix Released

Bug description:
  From the SimpleSAMLphp announcement email today:

  
  we have released version 1.19.0 of SimpleSAMLphp. The main focus of the 1.19 
release is to provide a migration path to our new templating, routing and 
translation systems.

  The changelog and upgrade notes are available here, respectively:

  https://simplesamlphp.org/docs/1.19/simplesamlphp-changelog
  https://simplesamlphp.org/docs/1.19/simplesamlphp-upgrade-notes-1.19

  The release is available for download here:

  
https://github.com/simplesamlphp/simplesamlphp/releases/download/v1.19.0/simplesamlphp-1.19.0.tar.gz

  You can check the integrity of this file by comparing the SHA256 digest:
  229787a4baf27a51e52bda660c56d069f167354800bffc72440dcacb3a6f

  Best regards,
  Olav Morken
  Uninett / Feide 

  To view this discussion on the web visit
  https://groups.google.com/d/msgid/simplesamlphp-announce/faf80d5f-1777
  -472f-9a4e-2c77a102a303n%40googlegroups.com.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1912685/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1918367] Re: LTI accessing pages of collection when link is for progresscompletion.php page

2021-05-02 Thread Robert Lyon
** Changed in: mahara/20.10
   Status: Confirmed => In Progress

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1918367

Title:
  LTI accessing pages of collection when link is for
  progresscompletion.php page

Status in Mahara:
  Fix Released
Status in Mahara 20.10 series:
  In Progress
Status in Mahara 21.04 series:
  Fix Released

Bug description:
  We made a fix in Bug #1891575 for allowing the LTI access to any page
  in the collection but we didn't take into account the
  collection/progresscompletion.php page (if enabled) as that ID is not
  a view ID but the collection ID

  We need to adjust the check so that we can handle this situation

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1918367/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1912685] Re: Upgrade SimpleSAMLphp to 1.19.0

2021-05-02 Thread Robert Lyon
** Changed in: mahara/19.10
   Status: Confirmed => Fix Committed

** Changed in: mahara/20.04
   Status: Confirmed => Fix Committed

** Changed in: mahara/20.10
   Status: Confirmed => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1912685

Title:
  Upgrade SimpleSAMLphp to 1.19.0

Status in Mahara:
  Fix Released
Status in Mahara 19.10 series:
  Fix Committed
Status in Mahara 20.04 series:
  Fix Committed
Status in Mahara 20.10 series:
  Fix Committed
Status in Mahara 21.04 series:
  Fix Released

Bug description:
  From the SimpleSAMLphp announcement email today:

  
  we have released version 1.19.0 of SimpleSAMLphp. The main focus of the 1.19 
release is to provide a migration path to our new templating, routing and 
translation systems.

  The changelog and upgrade notes are available here, respectively:

  https://simplesamlphp.org/docs/1.19/simplesamlphp-changelog
  https://simplesamlphp.org/docs/1.19/simplesamlphp-upgrade-notes-1.19

  The release is available for download here:

  
https://github.com/simplesamlphp/simplesamlphp/releases/download/v1.19.0/simplesamlphp-1.19.0.tar.gz

  You can check the integrity of this file by comparing the SHA256 digest:
  229787a4baf27a51e52bda660c56d069f167354800bffc72440dcacb3a6f

  Best regards,
  Olav Morken
  Uninett / Feide 

  To view this discussion on the web visit
  https://groups.google.com/d/msgid/simplesamlphp-announce/faf80d5f-1777
  -472f-9a4e-2c77a102a303n%40googlegroups.com.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1912685/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1926388] Re: Google Sheets in Google Apps block not working

2021-05-02 Thread Robert Lyon
** Changed in: mahara/20.10
Milestone: 20.10.1 => 20.10.2

** Changed in: mahara/20.04
Milestone: 20.04.3 => 20.04.4

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1926388

Title:
  Google Sheets in Google Apps block not working

Status in Mahara:
  Confirmed
Status in Mahara 20.04 series:
  Confirmed
Status in Mahara 20.10 series:
  Confirmed
Status in Mahara 21.04 series:
  Confirmed
Status in Mahara 21.10 series:
  Confirmed

Bug description:
  An issue was found when trying to create a Google Apps block for a
  google spreadsheet.  When pasting in the URL
  (https://docs.google.com/spreadsheets/d/e/2PACX-
  1vSLP46DGAOPhBqjp60r7qG6xy3nrHLGtikeSSVH9LqAP29A-
  Do5VCUDoKR0koK2EN820cbpgxcyxHWu/pubhtml) to a web browser, it had no
  problem displaying the document contents.

  Steps to reproduce:
  1. Log into Mahara as any user and navigate or create a new page you can edit
  2. Select a 'Google Apps' block and in the URL/Embed input enter in: 
https://docs.google.com/spreadsheets/d/e/2PACX-1vSLP46DGAOPhBqjp60r7qG6xy3nrHLGtikeSSVH9LqAP29A-Do5VCUDoKR0koK2EN820cbpgxcyxHWu/pubhtml,
 save the block & display the page
  Expected results:
  The block displays the google spreadsheet information
  Actual results:
  The block shows an error: "The file you requested does not exist".
  3. Repeat the above steps but in the URL/Embed input put in this: https://docs.google.com/presentation/d/e/2PACX-1vS_cNi8FtOCBaXeOz_iOMiclHMoKWTfw71ogiS3cu5-oTGcgmhT9qTj3Yg5u_dJzSfW9JaVykatXZH9/embed?start=false&loop=false&delayms=3000";
 frameborder="0" width="960" height="569" allowfullscreen="true" 
mozallowfullscreen="true" webkitallowfullscreen="true">
  4. Observe the same actual results from above.

  Was tested on 21.04.dev

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1926388/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1912685] Re: Upgrade SimpleSAMLphp to 1.19.0

2021-05-02 Thread Robert Lyon
** Summary changed:

- Upgrade SimpleSAMLphp to 1.19.x
+ Upgrade SimpleSAMLphp to 1.19.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1912685

Title:
  Upgrade SimpleSAMLphp to 1.19.0

Status in Mahara:
  Fix Released
Status in Mahara 19.10 series:
  Confirmed
Status in Mahara 20.04 series:
  Confirmed
Status in Mahara 20.10 series:
  Confirmed
Status in Mahara 21.04 series:
  Fix Released

Bug description:
  From the SimpleSAMLphp announcement email today:

  
  we have released version 1.19.0 of SimpleSAMLphp. The main focus of the 1.19 
release is to provide a migration path to our new templating, routing and 
translation systems.

  The changelog and upgrade notes are available here, respectively:

  https://simplesamlphp.org/docs/1.19/simplesamlphp-changelog
  https://simplesamlphp.org/docs/1.19/simplesamlphp-upgrade-notes-1.19

  The release is available for download here:

  
https://github.com/simplesamlphp/simplesamlphp/releases/download/v1.19.0/simplesamlphp-1.19.0.tar.gz

  You can check the integrity of this file by comparing the SHA256 digest:
  229787a4baf27a51e52bda660c56d069f167354800bffc72440dcacb3a6f

  Best regards,
  Olav Morken
  Uninett / Feide 

  To view this discussion on the web visit
  https://groups.google.com/d/msgid/simplesamlphp-announce/faf80d5f-1777
  -472f-9a4e-2c77a102a303n%40googlegroups.com.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1912685/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp